spree_core 3.0.5 → 3.0.6

data/spec/mailers/reimbursement_mailer_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+require 'email_spec'
+
+describe Spree::ReimbursementMailer, :type => :mailer do
+  include EmailSpec::Helpers
+  include EmailSpec::Matchers
+
+  let(:reimbursement) { create(:reimbursement) }
+
+  context ":from not set explicitly" do
+    it "falls back to spree config" do
+      message = Spree::ReimbursementMailer.reimbursement_email(reimbursement)
+      expect(message.from).to eq [Spree::Store.current.mail_from_address]
+    end
+  end
+
+  it "accepts a reimbursement id as an alternative to a Reimbursement object" do
+    expect(Spree::Reimbursement).to receive(:find).with(reimbursement.id).and_return(reimbursement)
+
+    expect {
+      Spree::ReimbursementMailer.reimbursement_email(reimbursement.id).body
+    }.not_to raise_error
+  end
+
+  context "emails must be translatable" do
+    context "reimbursement_email" do
+      context "pt-BR locale" do
+        before do
+          I18n.enforce_available_locales = false
+          pt_br_shipped_email = { :spree => { :reimbursement_mailer => { :reimbursement_email => { :dear_customer => 'Caro Cliente,' } } } }
+          I18n.backend.store_translations :'pt-BR', pt_br_shipped_email
+          I18n.locale = :'pt-BR'
+        end
+
+        after do
+          I18n.locale = I18n.default_locale
+          I18n.enforce_available_locales = true
+        end
+
+        specify do
+          reimbursement_email = Spree::ReimbursementMailer.reimbursement_email(reimbursement)
+          expect(reimbursement_email.body).to include("Caro Cliente,")
+        end
+      end
+    end
+  end
+end

data/spec/mailers/shipment_mailer_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+require 'email_spec'
+
+describe Spree::ShipmentMailer, :type => :mailer do
+  include EmailSpec::Helpers
+  include EmailSpec::Matchers
+
+  before { create(:store) }
+
+  let(:shipment) do
+    order = stub_model(Spree::Order)
+    product = stub_model(Spree::Product, :name => %Q{The "BEST" product})
+    variant = stub_model(Spree::Variant, :product => product)
+    line_item = stub_model(Spree::LineItem, :variant => variant, :order => order, :quantity => 1, :price => 5)
+    shipment = stub_model(Spree::Shipment)
+    allow(shipment).to receive_messages(:line_items => [line_item], :order => order)
+    allow(shipment).to receive_messages(:tracking_url => "TRACK_ME")
+    shipment
+  end
+
+  context ":from not set explicitly" do
+    it "falls back to spree config" do
+      message = Spree::ShipmentMailer.shipped_email(shipment)
+      expect(message.from).to eq([Spree::Store.current.mail_from_address])
+    end
+  end
+
+  # Regression test for #2196
+  it "doesn't include out of stock in the email body" do
+    shipment_email = Spree::ShipmentMailer.shipped_email(shipment)
+    expect(shipment_email.body).not_to include(%Q{Out of Stock})
+  end
+
+  it "shipment_email accepts an shipment id as an alternative to an Shipment object" do
+    expect(Spree::Shipment).to receive(:find).with(shipment.id).and_return(shipment)
+    expect {
+      Spree::ShipmentMailer.shipped_email(shipment.id).body
+    }.not_to raise_error
+  end
+
+  context "emails must be translatable" do
+    context "shipped_email" do
+      context "pt-BR locale" do
+        before do
+          I18n.enforce_available_locales = false
+          pt_br_shipped_email = { :spree => { :shipment_mailer => { :shipped_email => { :dear_customer => 'Caro Cliente,' } } } }
+          I18n.backend.store_translations :'pt-BR', pt_br_shipped_email
+          I18n.locale = :'pt-BR'
+        end
+
+        after do
+          I18n.locale = I18n.default_locale
+          I18n.enforce_available_locales = true
+        end
+
+        specify do
+          shipped_email = Spree::ShipmentMailer.shipped_email(shipment)
+          expect(shipped_email).to have_body_text("Caro Cliente,")
+        end
+      end
+    end
+  end
+end

data/spec/mailers/test_mailer_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+require 'email_spec'
+
+describe Spree::TestMailer, :type => :mailer do
+  include EmailSpec::Helpers
+  include EmailSpec::Matchers
+
+  before { create(:store) }
+
+  let(:user) { create(:user) }
+
+  context ":from not set explicitly" do
+    it "falls back to spree config" do
+      message = Spree::TestMailer.test_email('test@example.com')
+      expect(message.from).to eq([Spree::Store.current.mail_from_address])
+    end
+  end
+
+  it "confirm_email accepts a user id as an alternative to a User object" do
+    expect {
+      test_email = Spree::TestMailer.test_email('test@example.com')
+    }.not_to raise_error
+  end
+end

data/spec/models/spree/ability_spec.rb

@@ -0,0 +1,246 @@
+require 'spec_helper'
+require 'cancan/matchers'
+require 'spree/testing_support/ability_helpers'
+require 'spree/testing_support/bar_ability'
+
+# Fake ability for testing registration of additional abilities
+class FooAbility
+  include CanCan::Ability
+
+  def initialize(user)
+    # allow anyone to perform index on Order
+    can :index, Spree::Order
+    # allow anyone to update an Order with id of 1
+    can :update, Spree::Order do |order|
+      order.id == 1
+    end
+  end
+end
+
+describe Spree::Ability, :type => :model do
+  let(:user) { create(:user) }
+  let(:ability) { Spree::Ability.new(user) }
+  let(:token) { nil }
+
+  before do
+    user.spree_roles.clear
+  end
+
+  TOKEN = 'token123'
+
+  after(:each) {
+    Spree::Ability.abilities = Set.new
+    user.spree_roles = []
+  }
+
+  context 'register_ability' do
+    it 'should add the ability to the list of abilties' do
+      Spree::Ability.register_ability(FooAbility)
+      expect(Spree::Ability.new(user).abilities).not_to be_empty
+    end
+
+    it 'should apply the registered abilities permissions' do
+      Spree::Ability.register_ability(FooAbility)
+      expect(Spree::Ability.new(user).can?(:update, mock_model(Spree::Order, :id => 1))).to be true
+    end
+  end
+
+  context 'for general resource' do
+    let(:resource) { Object.new }
+
+    context 'with admin user' do
+      before(:each) { allow(user).to receive(:has_spree_role?).and_return(true) }
+      it_should_behave_like 'access granted'
+      it_should_behave_like 'index allowed'
+    end
+
+    context 'with customer' do
+      it_should_behave_like 'access denied'
+      it_should_behave_like 'no index allowed'
+    end
+  end
+
+  context 'for admin protected resources' do
+    let(:resource) { Object.new }
+    let(:resource_shipment) { Spree::Shipment.new }
+    let(:resource_product) { Spree::Product.new }
+    let(:resource_user) { Spree.user_class.new }
+    let(:resource_order) { Spree::Order.new }
+    let(:fakedispatch_user) { Spree.user_class.new }
+    let(:fakedispatch_ability) { Spree::Ability.new(fakedispatch_user) }
+
+    context 'with admin user' do
+      it 'should be able to admin' do
+        user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+        expect(ability).to be_able_to :admin, resource
+        expect(ability).to be_able_to :index, resource_order
+        expect(ability).to be_able_to :show, resource_product
+        expect(ability).to be_able_to :create, resource_user
+      end
+    end
+
+    context 'with fakedispatch user' do
+      it 'should be able to admin on the order and shipment pages' do
+        user.spree_roles << Spree::Role.find_or_create_by(name: 'bar')
+
+        Spree::Ability.register_ability(BarAbility)
+
+        expect(ability).not_to be_able_to :admin, resource
+
+        expect(ability).to be_able_to :admin, resource_order
+        expect(ability).to be_able_to :index, resource_order
+        expect(ability).not_to be_able_to :update, resource_order
+        # ability.should_not be_able_to :create, resource_order # Fails
+
+        expect(ability).to be_able_to :admin, resource_shipment
+        expect(ability).to be_able_to :index, resource_shipment
+        expect(ability).to be_able_to :create, resource_shipment
+
+        expect(ability).not_to be_able_to :admin, resource_product
+        expect(ability).not_to be_able_to :update, resource_product
+        # ability.should_not be_able_to :show, resource_product # Fails
+
+        expect(ability).not_to be_able_to :admin, resource_user
+        expect(ability).not_to be_able_to :update, resource_user
+        expect(ability).to be_able_to :update, user
+        # ability.should_not be_able_to :create, resource_user # Fails
+        # It can create new users if is has access to the :admin, User!!
+
+        # TODO change the Ability class so only users and customers get the extra premissions?
+
+        Spree::Ability.remove_ability(BarAbility)
+      end
+    end
+
+    context 'with customer' do
+      it 'should not be able to admin' do
+        expect(ability).not_to be_able_to :admin, resource
+        expect(ability).not_to be_able_to :admin, resource_order
+        expect(ability).not_to be_able_to :admin, resource_product
+        expect(ability).not_to be_able_to :admin, resource_user
+      end
+    end
+  end
+
+  context 'as Guest User' do
+
+    context 'for Country' do
+      let(:resource) { Spree::Country.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for OptionType' do
+      let(:resource) { Spree::OptionType.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for OptionValue' do
+      let(:resource) { Spree::OptionType.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Order' do
+      let(:resource) { Spree::Order.new }
+
+      context 'requested by same user' do
+        before(:each) { resource.user = user }
+        it_should_behave_like 'access granted'
+        it_should_behave_like 'no index allowed'
+      end
+
+      context 'requested by other user' do
+        before(:each) { resource.user = Spree.user_class.new }
+        it_should_behave_like 'create only'
+      end
+
+      context 'requested with proper token' do
+        let(:token) { 'TOKEN123' }
+        before(:each) { allow(resource).to receive_messages guest_token: 'TOKEN123' }
+        it_should_behave_like 'access granted'
+        it_should_behave_like 'no index allowed'
+      end
+
+      context 'requested with inproper token' do
+        let(:token) { 'FAIL' }
+        before(:each) { allow(resource).to receive_messages guest_token: 'TOKEN123' }
+        it_should_behave_like 'create only'
+      end
+    end
+
+    context 'for Product' do
+      let(:resource) { Spree::Product.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for ProductProperty' do
+      let(:resource) { Spree::Product.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Property' do
+      let(:resource) { Spree::Product.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for State' do
+      let(:resource) { Spree::State.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Taxons' do
+      let(:resource) { Spree::Taxon.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Taxonomy' do
+      let(:resource) { Spree::Taxonomy.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for User' do
+      context 'requested by same user' do
+        let(:resource) { user }
+        it_should_behave_like 'access granted'
+        it_should_behave_like 'no index allowed'
+      end
+      context 'requested by other user' do
+        let(:resource) { Spree.user_class.new }
+        it_should_behave_like 'create only'
+      end
+    end
+
+    context 'for Variant' do
+      let(:resource) { Spree::Variant.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Zone' do
+      let(:resource) { Spree::Zone.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+  end
+
+end

data/spec/models/spree/address_spec.rb

@@ -0,0 +1,291 @@
+require 'spec_helper'
+
+describe Spree::Address, :type => :model do
+
+  subject { Spree::Address }
+
+  describe "clone" do
+    it "creates a copy of the address with the exception of the id, updated_at and created_at attributes" do
+      state = create(:state)
+      original = create(:address,
+                         :address1 => 'address1',
+                         :address2 => 'address2',
+                         :alternative_phone => 'alternative_phone',
+                         :city => 'city',
+                         :country => Spree::Country.first,
+                         :firstname => 'firstname',
+                         :lastname => 'lastname',
+                         :company => 'company',
+                         :phone => 'phone',
+                         :state_id => state.id,
+                         :state_name => state.name,
+                         :zipcode => '10001')
+
+      cloned = original.clone
+
+      expect(cloned.address1).to eq(original.address1)
+      expect(cloned.address2).to eq(original.address2)
+      expect(cloned.alternative_phone).to eq(original.alternative_phone)
+      expect(cloned.city).to eq(original.city)
+      expect(cloned.country_id).to eq(original.country_id)
+      expect(cloned.firstname).to eq(original.firstname)
+      expect(cloned.lastname).to eq(original.lastname)
+      expect(cloned.company).to eq(original.company)
+      expect(cloned.phone).to eq(original.phone)
+      expect(cloned.state_id).to eq(original.state_id)
+      expect(cloned.state_name).to eq(original.state_name)
+      expect(cloned.zipcode).to eq(original.zipcode)
+
+      expect(cloned.id).not_to eq(original.id)
+      expect(cloned.created_at).not_to eq(original.created_at)
+      expect(cloned.updated_at).not_to eq(original.updated_at)
+    end
+  end
+
+  context "aliased attributes" do
+    let(:address) { Spree::Address.new }
+
+    it "first_name" do
+      address.firstname = "Ryan"
+      expect(address.first_name).to eq("Ryan")
+    end
+
+    it "last_name" do
+      address.lastname = "Bigg"
+      expect(address.last_name).to eq("Bigg")
+    end
+  end
+
+  context "validation" do
+    before do
+      configure_spree_preferences do |config|
+        config.address_requires_state = true
+      end
+    end
+
+    let(:country) { mock_model(Spree::Country, :states => [state], :states_required => true) }
+    let(:state) { stub_model(Spree::State, :name => 'maryland', :abbr => 'md') }
+    let(:address) { build(:address, :country => country) }
+
+    before do
+      allow(country.states).to receive_messages :find_all_by_name_or_abbr => [state]
+    end
+
+    it "state_name is not nil and country does not have any states" do
+      address.state = nil
+      address.state_name = 'alabama'
+      expect(address).to be_valid
+    end
+
+    it "errors when state_name is nil" do
+      address.state_name = nil
+      address.state = nil
+      expect(address).not_to be_valid
+    end
+
+    it "full state name is in state_name and country does contain that state" do
+      address.state_name = 'alabama'
+      # called by state_validate to set up state_id.
+      # Perhaps this should be a before_validation instead?
+      expect(address).to be_valid
+      expect(address.state).not_to be_nil
+      expect(address.state_name).to be_nil
+    end
+
+    it "state abbr is in state_name and country does contain that state" do
+      address.state_name = state.abbr
+      expect(address).to be_valid
+      expect(address.state_id).not_to be_nil
+      expect(address.state_name).to be_nil
+    end
+
+    it "state is entered but country does not contain that state" do
+      address.state = state
+      address.country = stub_model(Spree::Country, :states_required => true)
+      address.valid?
+      expect(address.errors["state"]).to eq(['is invalid'])
+    end
+
+    it "both state and state_name are entered but country does not contain the state" do
+      address.state = state
+      address.state_name = 'maryland'
+      address.country = stub_model(Spree::Country, :states_required => true)
+      expect(address).to be_valid
+      expect(address.state_id).to be_nil
+    end
+
+    it "both state and state_name are entered and country does contain the state" do
+      address.state = state
+      address.state_name = 'maryland'
+      expect(address).to be_valid
+      expect(address.state_name).to be_nil
+    end
+
+    it "address_requires_state preference is false" do
+      Spree::Config.set :address_requires_state => false
+      address.state = nil
+      address.state_name = nil
+      expect(address).to be_valid
+    end
+
+    it "requires phone" do
+      address.phone = ""
+      address.valid?
+      expect(address.errors["phone"]).to eq(["can't be blank"])
+    end
+
+    it "requires zipcode" do
+      address.zipcode = ""
+      address.valid?
+      expect(address.errors['zipcode']).to include("can't be blank")
+    end
+
+    context "zipcode validation" do
+      it "validates the zipcode" do
+        allow(address.country).to receive(:iso).and_return('US')
+        address.zipcode = 'abc'
+        address.valid?
+        expect(address.errors['zipcode']).to include('is invalid')
+      end
+
+      it "accepts a zip code with surrounding white space" do
+        allow(address.country).to receive(:iso).and_return('US')
+        address.zipcode = ' 12345 '
+        address.valid?
+        expect(address.errors['zipcode']).not_to include('is invalid')
+      end
+
+      context 'does not validate' do
+        it 'does not have a country' do
+          address.country = nil
+          address.valid?
+          expect(address.errors['zipcode']).not_to include('is invalid')
+        end
+
+        it 'does not have an iso' do
+          allow(address.country).to receive(:iso).and_return(nil)
+          address.valid?
+          expect(address.errors['zipcode']).not_to include('is invalid')
+        end
+
+        it 'does not have a zipcode' do
+          address.zipcode = ""
+          address.valid?
+          expect(address.errors['zipcode']).not_to include('is invalid')
+        end
+
+        it 'does not have a supported country iso' do
+          allow(address.country).to receive(:iso).and_return('BO')
+          address.valid?
+          expect(address.errors['zipcode']).not_to include('is invalid')
+        end
+      end
+    end
+
+    context "phone not required" do
+      before { allow(address).to receive_messages require_phone?: false }
+
+      it "shows no errors when phone is blank" do
+        address.phone = ""
+        address.valid?
+        expect(address.errors[:phone].size).to eq 0
+      end
+    end
+
+    context "zipcode not required" do
+      before { allow(address).to receive_messages require_zipcode?: false }
+
+      it "shows no errors when phone is blank" do
+        address.zipcode = ""
+        address.valid?
+        expect(address.errors[:zipcode].size).to eq 0
+      end
+    end
+  end
+
+  context ".default" do
+    context "no user given" do
+      before do
+        @default_country_id = Spree::Config[:default_country_id]
+        new_country = create(:country)
+        Spree::Config[:default_country_id] = new_country.id
+      end
+
+      after do
+        Spree::Config[:default_country_id] = @default_country_id
+      end
+
+      it "sets up a new record with Spree::Config[:default_country_id]" do
+        expect(Spree::Address.default.country).to eq(Spree::Country.find(Spree::Config[:default_country_id]))
+      end
+
+      # Regression test for #1142
+      it "uses the first available country if :default_country_id is set to an invalid value" do
+        Spree::Config[:default_country_id] = "0"
+        expect(Spree::Address.default.country).to eq(Spree::Country.first)
+      end
+    end
+
+    context "user given" do
+      let(:bill_address) { Spree::Address.new(phone: Time.now.to_i) }
+      let(:ship_address) { double("ShipAddress") }
+      let(:user) { double("User", bill_address: bill_address, ship_address: ship_address) }
+
+      it "returns a copy of that user bill address" do
+        expect(subject.default(user).phone).to eq bill_address.phone
+      end
+
+      it "falls back to build default when user has no address" do
+        allow(user).to receive_messages(bill_address: nil)
+        expect(subject.default(user)).to eq subject.build_default
+      end
+    end
+  end
+
+  context '#full_name' do
+    context 'both first and last names are present' do
+      let(:address) { stub_model(Spree::Address, :firstname => 'Michael', :lastname => 'Jackson') }
+      specify { expect(address.full_name).to eq('Michael Jackson') }
+    end
+
+    context 'first name is blank' do
+      let(:address) { stub_model(Spree::Address, :firstname => nil, :lastname => 'Jackson') }
+      specify { expect(address.full_name).to eq('Jackson') }
+    end
+
+    context 'last name is blank' do
+      let(:address) { stub_model(Spree::Address, :firstname => 'Michael', :lastname => nil) }
+      specify { expect(address.full_name).to eq('Michael') }
+    end
+
+    context 'both first and last names are blank' do
+      let(:address) { stub_model(Spree::Address, :firstname => nil, :lastname => nil) }
+      specify { expect(address.full_name).to eq('') }
+    end
+
+  end
+
+  context '#state_text' do
+    context 'state is blank' do
+      let(:address) { stub_model(Spree::Address, :state => nil, :state_name => 'virginia') }
+      specify { expect(address.state_text).to eq('virginia') }
+    end
+
+    context 'both name and abbr is present' do
+      let(:state) { stub_model(Spree::State, :name => 'virginia', :abbr => 'va') }
+      let(:address) { stub_model(Spree::Address, :state => state) }
+      specify { expect(address.state_text).to eq('va') }
+    end
+
+    context 'only name is present' do
+      let(:state) { stub_model(Spree::State, :name => 'virginia', :abbr => nil) }
+      let(:address) { stub_model(Spree::Address, :state => state) }
+      specify { expect(address.state_text).to eq('virginia') }
+    end
+  end
+
+  context "defines require_phone? helper method" do
+    let(:address) { stub_model(Spree::Address) }
+    specify { expect(address.instance_eval{ require_phone? }).to be true}
+  end
+end