spree_core 3.0.5 → 3.0.6

data/spec/lib/spree/core/validators/email_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe EmailValidator do
+
+  class Tester
+    include ActiveModel::Validations
+    attr_accessor :email_address
+    validates :email_address, email: true
+  end
+
+  let(:valid_emails) {[
+    'valid@email.com',
+    'valid@email.com.uk',
+    'e@email.com',
+    'valid+email@email.com',
+    'valid-email@email.com',
+    'valid_email@email.com',
+    'validemail_@email.com',
+    'valid.email@email.com'
+  ]}
+  let(:invalid_emails) {[
+    '',
+    ' ',
+    'invalid email@email.com',
+    'invalidemail @email.com',
+    'invalidemail@email..com',
+    '.invalid.email@email.com',
+    'invalid.email.@email.com',
+    '@email.com',
+    '.@email.com',
+    'invalidemailemail.com',
+    '@invalid.email@email.com',
+    'invalid@email@email.com',
+    'invalid.email@@email.com'
+  ]}
+
+  it 'validates valid email addresses' do
+    tester = Tester.new
+    valid_emails.each do |email|
+      tester.email_address = email
+      expect(tester.valid?).to be true
+    end
+  end
+
+  it 'validates invalid email addresses' do
+    tester = Tester.new
+    invalid_emails.each do |email|
+      tester.email_address = email
+      expect(tester.valid?).to be false
+    end
+  end
+
+end

data/spec/lib/spree/localized_number_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe Spree::LocalizedNumber do
+
+  context ".parse" do
+    before do
+      I18n.enforce_available_locales = false
+      I18n.locale = I18n.default_locale
+      I18n.backend.store_translations(:de, { :number => { :currency => { :format => { :delimiter => '.', :separator => ',' } } } })
+    end
+
+    after do
+      I18n.locale = I18n.default_locale
+      I18n.enforce_available_locales = true
+    end
+
+    context "with decimal point" do
+      it "captures the proper amount for a formatted price" do
+        expect(subject.class.parse('1,599.99')).to eql 1599.99
+      end
+    end
+
+    context "with decimal comma" do
+      it "captures the proper amount for a formatted price" do
+        I18n.locale = :de
+        expect(subject.class.parse('1.599,99')).to eql 1599.99
+      end
+    end
+
+    context "with a numeric price" do
+      it "uses the price as is" do
+        I18n.locale = :de
+        expect(subject.class.parse(1599.99)).to eql 1599.99
+      end
+    end
+  end
+
+end

data/spec/lib/spree/migrations_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+module Spree
+  describe Migrations do
+    let(:app_migrations) { [".", "34_add_title.rb", "52_add_text.rb"] }
+    let(:engine_migrations) { [".", "334_create_orders.spree.rb", "777_create_products.spree.rb"] }
+
+    let(:config) { double("Config", root: "dir") }
+
+    subject { described_class.new(config, "spree")  }
+
+    before do
+      expect(File).to receive(:exists?).with("config/spree.yml").and_return true
+      expect(File).to receive(:directory?).with("db/migrate").and_return true
+    end
+
+    it "warns about missing migrations" do
+      expect(Dir).to receive(:entries).with("db/migrate").and_return app_migrations
+      expect(Dir).to receive(:entries).with("dir/db/migrate").and_return engine_migrations
+
+      silence_stream(STDOUT) {
+        expect(subject.check).to eq true
+      }
+    end
+
+    context "no missing migrations" do
+      it "says nothing" do
+        expect(Dir).to receive(:entries).with("dir/db/migrate").and_return engine_migrations
+        expect(Dir).to receive(:entries).with("db/migrate").and_return (app_migrations + engine_migrations)
+        expect(subject.check).to eq nil
+      end
+    end
+  end
+end

data/spec/lib/spree/money_spec.rb

@@ -0,0 +1,122 @@
+# coding: utf-8
+require 'spec_helper'
+
+describe Spree::Money do
+  before do
+    configure_spree_preferences do |config|
+      config.currency = "USD"
+    end
+  end
+
+  it "formats correctly" do
+    money = Spree::Money.new(10)
+    expect(money.to_s).to eq("$10.00")
+  end
+
+  it "can get cents" do
+    money = Spree::Money.new(10)
+    expect(money.cents).to eq(1000)
+  end
+
+  context "with currency" do
+    it "passed in option" do
+      money = Spree::Money.new(10, :with_currency => true, :html => false)
+      expect(money.to_s).to eq("$10.00 USD")
+    end
+  end
+
+  context "hide cents" do
+    it "hides cents suffix" do
+      money = Spree::Money.new(10, no_cents: true)
+      expect(money.to_s).to eq("$10")
+    end
+
+    it "shows cents suffix" do
+      money = Spree::Money.new(10)
+      expect(money.to_s).to eq("$10.00")
+    end
+  end
+
+  context "currency parameter" do
+    context "when currency is specified in Canadian Dollars" do
+      it "uses the currency param over the global configuration" do
+        money = Spree::Money.new(10, :currency => 'CAD', :with_currency => true, :html => false)
+        expect(money.to_s).to eq("$10.00 CAD")
+      end
+    end
+
+    context "when currency is specified in Japanese Yen" do
+      it "uses the currency param over the global configuration" do
+        money = Spree::Money.new(100, :currency => 'JPY', :html => false)
+        expect(money.to_s).to eq("¥100")
+      end
+    end
+  end
+
+  context "symbol positioning" do
+    it "passed in option" do
+      money = Spree::Money.new(10, :symbol_position => :after, :html => false)
+      expect(money.to_s).to eq("10.00 $")
+    end
+  end
+
+  context "sign before symbol" do
+    it "defaults to -$10.00" do
+      money = Spree::Money.new(-10)
+      expect(money.to_s).to eq("-$10.00")
+    end
+
+    it "passed in option" do
+      money = Spree::Money.new(-10, :sign_before_symbol => false)
+      expect(money.to_s).to eq("$-10.00")
+    end
+  end
+
+  context "JPY" do
+    before do
+      configure_spree_preferences do |config|
+        config.currency = "JPY"
+      end
+    end
+
+    it "formats correctly" do
+      money = Spree::Money.new(1000, :html => false)
+      expect(money.to_s).to eq("¥1,000")
+    end
+  end
+
+  context "EUR" do
+    before do
+      configure_spree_preferences do |config|
+        config.currency = "EUR"
+      end
+    end
+
+    # Regression test for #2634
+    it "formats as plain by default" do
+      money = Spree::Money.new(10, symbol_position: :after)
+      expect(money.to_s).to eq("10.00 €")
+    end
+
+    it "formats as HTML if asked (nicely) to" do
+      money = Spree::Money.new(10, symbol_position: :after)
+      # The HTML'ified version of "10.00 €"
+      expect(money.to_html).to eq("10.00 €")
+    end
+
+    it "formats as HTML with currency" do
+      money = Spree::Money.new(10, symbol_position: :after, with_currency: true)
+      # The HTML'ified version of "10.00 €"
+      expect(money.to_html).to eq("10.00&nbsp;&#x20AC; <span class=\"currency\">EUR</span>")
+    end
+  end
+
+  describe "#as_json" do
+    let(:options) { double('options') }
+
+    it "returns the expected string" do
+      money = Spree::Money.new(10)
+      expect(money.as_json(options)).to eq("$10.00")
+    end
+  end
+end

data/spec/lib/tasks/exchanges_spec.rb

@@ -0,0 +1,136 @@
+require 'spec_helper'
+
+describe "exchanges:charge_unreturned_items" do
+  include_context "rake"
+
+  describe '#prerequisites' do
+    it { expect(subject.prerequisites).to include("environment") }
+  end
+
+  context "there are no unreturned items" do
+    it { expect { subject.invoke }.not_to change { Spree::Order.count } }
+  end
+
+  context "there are unreturned items" do
+    let!(:order) { create(:shipped_order, line_items_count: 2) }
+    let(:return_item_1) { create(:exchange_return_item, inventory_unit: order.inventory_units.first) }
+    let(:return_item_2) { create(:exchange_return_item, inventory_unit: order.inventory_units.last) }
+    let!(:rma) { create(:return_authorization, order: order, return_items: [return_item_1, return_item_2]) }
+    let!(:tax_rate) { create(:tax_rate, zone: order.tax_zone, tax_category: return_item_2.exchange_variant.tax_category) }
+
+    before do
+      @original_expedited_exchanges_pref = Spree::Config[:expedited_exchanges]
+      Spree::Config[:expedited_exchanges] = true
+      Spree::StockItem.update_all(count_on_hand: 10)
+      rma.save!
+      Spree::Shipment.last.ship!
+      return_item_1.receive!
+      Timecop.travel travel_time
+    end
+
+    after do
+      Timecop.return
+      Spree::Config[:expedited_exchanges] = @original_expedited_exchanges_pref
+    end
+
+    context "fewer than the config allowed days have passed" do
+      let(:travel_time) { (Spree::Config[:expedited_exchanges_days_window] - 1).days }
+
+      it "does not create a new order" do
+        expect { subject.invoke }.not_to change { Spree::Order.count }
+      end
+    end
+
+    context "more than the config allowed days have passed" do
+
+      let(:travel_time) { (Spree::Config[:expedited_exchanges_days_window] + 1).days }
+
+      it "creates a new completed order" do
+        expect { subject.invoke }.to change { Spree::Order.count }
+        expect(Spree::Order.last).to be_completed
+      end
+
+      it "moves the shipment for the unreturned items to the new order" do
+        subject.invoke
+        new_order = Spree::Order.last
+        expect(new_order.shipments.count).to eq 1
+        expect(return_item_2.reload.exchange_shipment.order).to eq Spree::Order.last
+      end
+
+      it "creates line items on the order for the unreturned items" do
+        subject.invoke
+        expect(Spree::Order.last.line_items.map(&:variant)).to eq [return_item_2.exchange_variant]
+      end
+
+      it "associates the exchanges inventory units with the new line items" do
+        subject.invoke
+        expect(return_item_2.reload.exchange_inventory_unit.try(:line_item).try(:order)).to eq Spree::Order.last
+      end
+
+      it "uses the credit card from the previous order" do
+        subject.invoke
+        new_order = Spree::Order.last
+        expect(new_order.credit_cards).to be_present
+        expect(new_order.credit_cards.first).to eq order.valid_credit_cards.first
+      end
+
+      it "authorizes the order for the full amount of the unreturned items including taxes" do
+        expect { subject.invoke }.to change { Spree::Payment.count }.by(1)
+        new_order = Spree::Order.last
+        expected_amount = return_item_2.reload.exchange_variant.price + new_order.additional_tax_total + new_order.included_tax_total
+        expect(new_order.total).to eq expected_amount
+        payment = new_order.payments.first
+        expect(payment.amount).to eq expected_amount
+        expect(payment).to be_pending
+        expect(new_order.item_total).to eq return_item_2.reload.exchange_variant.price
+      end
+
+      it "does not attempt to create a new order for the item more than once" do
+        subject.invoke
+        subject.reenable
+        expect { subject.invoke }.not_to change { Spree::Order.count }
+      end
+
+      it "associates the store of the original order with the exchange order" do
+        allow_any_instance_of(Spree::Order).to receive(:store_id).and_return(123)
+
+        expect(Spree::Order).to receive(:create!).once.with(hash_including({store_id: 123})) { |attrs| Spree::Order.new(attrs.except(:store_id)).tap(&:save!) }
+        subject.invoke
+      end
+
+      context "there is no card from the previous order" do
+        let!(:credit_card) { create(:credit_card, user: order.user, default: true, gateway_customer_profile_id: "BGS-123") }
+        before { allow_any_instance_of(Spree::Order).to receive(:valid_credit_cards) { [] } }
+
+        it "attempts to use the user's default card" do
+          expect { subject.invoke }.to change { Spree::Payment.count }.by(1)
+          new_order = Spree::Order.last
+          expect(new_order.credit_cards).to be_present
+          expect(new_order.credit_cards.first).to eq credit_card
+        end
+      end
+
+      context "it is unable to authorize the credit card" do
+        before { allow_any_instance_of(Spree::Payment).to receive(:authorize!).and_raise(RuntimeError) }
+
+        it "raises an error with the order" do
+          expect { subject.invoke }.to raise_error(UnableToChargeForUnreturnedItems)
+        end
+      end
+
+      context "the exchange inventory unit is not shipped" do
+        before { return_item_2.reload.exchange_inventory_unit.update_columns(state: "on hand") }
+        it "does not create a new order" do
+          expect { subject.invoke }.not_to change { Spree::Order.count }
+        end
+      end
+
+      context "the exchange inventory unit has been returned" do
+        before { return_item_2.reload.exchange_inventory_unit.update_columns(state: "returned") }
+        it "does not create a new order" do
+          expect { subject.invoke }.not_to change { Spree::Order.count }
+        end
+      end
+    end
+  end
+end

data/spec/mailers/order_mailer_spec.rb

@@ -0,0 +1,124 @@
+require 'spec_helper'
+require 'email_spec'
+
+describe Spree::OrderMailer, :type => :mailer do
+  include EmailSpec::Helpers
+  include EmailSpec::Matchers
+
+  before { create(:store) }
+
+  let(:order) do
+    order = stub_model(Spree::Order)
+    product = stub_model(Spree::Product, :name => %Q{The "BEST" product})
+    variant = stub_model(Spree::Variant, :product => product)
+    price = stub_model(Spree::Price, :variant => variant, :amount => 5.00)
+    line_item = stub_model(Spree::LineItem, :variant => variant, :order => order, :quantity => 1, :price => 4.99)
+    allow(variant).to receive_messages(:default_price => price)
+    allow(order).to receive_messages(:line_items => [line_item])
+    order
+  end
+
+  context ":from not set explicitly" do
+    it "falls back to spree config" do
+      message = Spree::OrderMailer.confirm_email(order)
+      expect(message.from).to eq([Spree::Store.current.mail_from_address])
+    end
+  end
+
+  it "doesn't aggressively escape double quotes in confirmation body" do
+    confirmation_email = Spree::OrderMailer.confirm_email(order)
+    expect(confirmation_email.body).not_to include(""")
+  end
+
+  it "confirm_email accepts an order id as an alternative to an Order object" do
+    expect(Spree::Order).to receive(:find).with(order.id).and_return(order)
+    expect {
+      Spree::OrderMailer.confirm_email(order.id).body
+    }.not_to raise_error
+  end
+
+  it "cancel_email accepts an order id as an alternative to an Order object" do
+    expect(Spree::Order).to receive(:find).with(order.id).and_return(order)
+    expect {
+      cancel_email = Spree::OrderMailer.cancel_email(order.id).body
+    }.not_to raise_error
+  end
+
+  context "only shows eligible adjustments in emails" do
+    before do
+      create(:adjustment, :order => order, :eligible => true, :label => "Eligible Adjustment")
+      create(:adjustment, :order => order, :eligible => false, :label => "Ineligible Adjustment")
+    end
+
+    let!(:confirmation_email) { Spree::OrderMailer.confirm_email(order) }
+    let!(:cancel_email) { Spree::OrderMailer.cancel_email(order) }
+
+    specify do
+      expect(confirmation_email.body).not_to include("Ineligible Adjustment")
+    end
+
+    specify do
+      expect(cancel_email.body).not_to include("Ineligible Adjustment")
+    end
+  end
+
+  context "displays unit costs from line item" do
+    # Regression test for #2772
+
+    # Tests mailer view spree/order_mailer/confirm_email.text.erb
+    specify do
+      confirmation_email = Spree::OrderMailer.confirm_email(order)
+      expect(confirmation_email).to have_body_text("4.99")
+      expect(confirmation_email).to_not have_body_text("5.00")
+    end
+
+    # Tests mailer view spree/order_mailer/cancel_email.text.erb
+    specify do
+      cancel_email = Spree::OrderMailer.cancel_email(order)
+      expect(cancel_email).to have_body_text("4.99")
+      expect(cancel_email).to_not have_body_text("5.00")
+    end
+  end
+
+  context "emails must be translatable" do
+
+    context "pt-BR locale" do
+      before do
+        I18n.enforce_available_locales = false
+        pt_br_confirm_mail = { :spree => { :order_mailer => { :confirm_email => { :dear_customer => 'Caro Cliente,' } } } }
+        pt_br_cancel_mail = { :spree => { :order_mailer => { :cancel_email => { :order_summary_canceled => 'Resumo da Pedido [CANCELADA]' } } } }
+        I18n.backend.store_translations :'pt-BR', pt_br_confirm_mail
+        I18n.backend.store_translations :'pt-BR', pt_br_cancel_mail
+        I18n.locale = :'pt-BR'
+      end
+
+      after do
+        I18n.locale = I18n.default_locale
+        I18n.enforce_available_locales = true
+      end
+
+      context "confirm_email" do
+        specify do
+          confirmation_email = Spree::OrderMailer.confirm_email(order)
+          expect(confirmation_email).to have_body_text("Caro Cliente,")
+        end
+      end
+
+      context "cancel_email" do
+        specify do
+          cancel_email = Spree::OrderMailer.cancel_email(order)
+          expect(cancel_email).to have_body_text("Resumo da Pedido [CANCELADA]")
+        end
+      end
+    end
+  end
+
+  context "with preference :send_core_emails set to false" do
+    it "sends no email" do
+      Spree::Config.set(:send_core_emails, false)
+      message = Spree::OrderMailer.confirm_email(order)
+      expect(message.body).to be_blank
+    end
+  end
+
+end