solidus_backend_devise_token_auth 2.8.0.alpha.2

data/spec/features/admin/promotion_adjustments_spec.rb

@@ -0,0 +1,277 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Promotion Adjustments", type: :feature, js: true do
+  stub_authorization!
+
+  context "creating a new promotion", js: true do
+    before(:each) do
+      visit spree.new_admin_promotion_path
+      expect(page).to have_title("New Promotion - Promotions")
+    end
+
+    it "should allow an admin to create a flat rate discount coupon promo" do
+      fill_in "Name", with: "SAVE SAVE SAVE"
+      fill_in "Promotion Code", with: "order"
+
+      click_button "Create"
+      expect(page).to have_title("SAVE SAVE SAVE - Promotions")
+
+      select "Item total", from: "Discount rules"
+      within('#rule_fields') { click_button "Add" }
+
+      find('[id$=_preferred_amount]').set(30)
+      within('#rule_fields') { click_button "Update" }
+
+      select "Create whole-order adjustment", from: "Adjustment type"
+      within('#action_fields') do
+        click_button "Add"
+        select "Flat Rate", from: I18n.t('spree.admin.promotions.actions.calculator_label')
+        fill_in "Amount", with: 5
+      end
+      within('#actions_container') { click_button "Update" }
+      expect(page).to have_text 'successfully updated'
+
+      promotion = Spree::Promotion.find_by(name: "SAVE SAVE SAVE")
+      expect(promotion.codes.first.value).to eq("order")
+
+      first_rule = promotion.rules.first
+      expect(first_rule.class).to eq(Spree::Promotion::Rules::ItemTotal)
+      expect(first_rule.preferred_amount).to eq(30)
+
+      first_action = promotion.actions.first
+      expect(first_action.class).to eq(Spree::Promotion::Actions::CreateAdjustment)
+      first_action_calculator = first_action.calculator
+      expect(first_action_calculator.class).to eq(Spree::Calculator::FlatRate)
+      expect(first_action_calculator.preferred_amount).to eq(5)
+    end
+
+    it "should allow an admin to create a single user coupon promo with flat rate discount" do
+      fill_in "Name", with: "SAVE SAVE SAVE"
+      fill_in "promotion[usage_limit]", with: "1"
+      fill_in "Promotion Code", with: "single_use"
+
+      click_button "Create"
+      expect(page).to have_title("SAVE SAVE SAVE - Promotions")
+
+      select "Create whole-order adjustment", from: "Adjustment type"
+      within('#action_fields') do
+        click_button "Add"
+        select "Flat Rate", from: I18n.t('spree.admin.promotions.actions.calculator_label')
+        fill_in "Amount", with: "5"
+      end
+      within('#actions_container') { click_button "Update" }
+      expect(page).to have_text 'successfully updated'
+
+      promotion = Spree::Promotion.find_by(name: "SAVE SAVE SAVE")
+      expect(promotion.usage_limit).to eq(1)
+      expect(promotion.codes.first.value).to eq("single_use")
+
+      first_action = promotion.actions.first
+      expect(first_action.class).to eq(Spree::Promotion::Actions::CreateAdjustment)
+      first_action_calculator = first_action.calculator
+      expect(first_action_calculator.class).to eq(Spree::Calculator::FlatRate)
+      expect(first_action_calculator.preferred_amount).to eq(5)
+    end
+
+    it "should allow an admin to create an automatic promo with flat percent discount" do
+      fill_in "Name", with: "SAVE SAVE SAVE"
+      choose "Apply to all orders"
+      click_button "Create"
+      expect(page).to have_title("SAVE SAVE SAVE - Promotions")
+
+      select "Item total", from: "Discount rules"
+      within('#rule_fields') { click_button "Add" }
+
+      find('[id$=_preferred_amount]').set(30)
+      within('#rule_fields') { click_button "Update" }
+
+      select "Create whole-order adjustment", from: "Adjustment type"
+      within('#action_fields') do
+        click_button "Add"
+        select "Flat Percent", from: I18n.t('spree.admin.promotions.actions.calculator_label')
+        fill_in "Flat Percent", with: "10"
+      end
+      within('#actions_container') { click_button "Update" }
+      expect(page).to have_text 'successfully updated'
+
+      promotion = Spree::Promotion.find_by(name: "SAVE SAVE SAVE")
+      expect(promotion.codes.first).to be_nil
+
+      first_rule = promotion.rules.first
+      expect(first_rule.class).to eq(Spree::Promotion::Rules::ItemTotal)
+      expect(first_rule.preferred_amount).to eq(30)
+
+      first_action = promotion.actions.first
+      expect(first_action.class).to eq(Spree::Promotion::Actions::CreateAdjustment)
+      first_action_calculator = first_action.calculator
+      expect(first_action_calculator.class).to eq(Spree::Calculator::FlatPercentItemTotal)
+      expect(first_action_calculator.preferred_flat_percent).to eq(10)
+    end
+
+    it "should allow an admin to create an product promo with percent per item discount" do
+      create(:product, name: "RoR Mug")
+
+      fill_in "Name", with: "SAVE SAVE SAVE"
+      choose "Apply to all orders"
+      click_button "Create"
+      expect(page).to have_title("SAVE SAVE SAVE - Promotions")
+
+      select "Product(s)", from: "Discount rules"
+      within("#rule_fields") { click_button "Add" }
+      select2_search "RoR Mug", from: "Choose products"
+      within('#rule_fields') { click_button "Update" }
+
+      select "Create per-line-item adjustment", from: "Adjustment type"
+      within('#action_fields') do
+        click_button "Add"
+        select "Percent Per Item", from: I18n.t('spree.admin.promotions.actions.calculator_label')
+        fill_in "Percent", with: "10"
+      end
+      within('#actions_container') { click_button "Update" }
+      expect(page).to have_text 'successfully updated'
+
+      promotion = Spree::Promotion.find_by(name: "SAVE SAVE SAVE")
+      expect(promotion.codes.first).to be_nil
+
+      first_rule = promotion.rules.first
+      expect(first_rule.class).to eq(Spree::Promotion::Rules::Product)
+      expect(first_rule.products.map(&:name)).to include("RoR Mug")
+
+      first_action = promotion.actions.first
+      expect(first_action.class).to eq(Spree::Promotion::Actions::CreateItemAdjustments)
+      first_action_calculator = first_action.calculator
+      expect(first_action_calculator.class).to eq(Spree::Calculator::PercentOnLineItem)
+      expect(first_action_calculator.preferred_percent).to eq(10)
+    end
+
+    it "should allow an admin to create an automatic promotion with free shipping (no code)" do
+      fill_in "Name", with: "SAVE SAVE SAVE"
+      choose "Apply to all orders"
+      click_button "Create"
+      expect(page).to have_title("SAVE SAVE SAVE - Promotions")
+
+      select "Item total", from: "Discount rules"
+      within('#rule_fields') { click_button "Add" }
+      find('[id$=_preferred_amount]').set(30)
+      within('#rule_fields') { click_button "Update" }
+
+      select "Free shipping", from: "Adjustment type"
+      within('#action_fields') { click_button "Add" }
+      expect(page).to have_content('Makes all shipments for the order free')
+
+      promotion = Spree::Promotion.find_by(name: "SAVE SAVE SAVE")
+      expect(promotion.codes).to be_empty
+      expect(promotion.rules.first).to be_a(Spree::Promotion::Rules::ItemTotal)
+      expect(promotion.actions.first).to be_a(Spree::Promotion::Actions::FreeShipping)
+    end
+
+    it "should allow an admin to create an automatic promotion" do
+      fill_in "Name", with: "SAVE SAVE SAVE"
+      choose "Apply to all orders"
+      click_button "Create"
+      expect(page).to have_title("SAVE SAVE SAVE - Promotions")
+
+      promotion = Spree::Promotion.find_by(name: "SAVE SAVE SAVE")
+      expect(promotion).to be_apply_automatically
+      expect(promotion.path).to be_nil
+      expect(promotion.codes).to be_empty
+      expect(promotion.rules).to be_blank
+    end
+
+    it "should allow an admin to create a promo with generated codes" do
+      fill_in "Name", with: "SAVE SAVE SAVE"
+      choose "Multiple promotion codes"
+      fill_in "Base code", with: "testing"
+      fill_in "Number of codes", with: "10"
+
+      perform_enqueued_jobs {
+        click_button "Create"
+        expect(page).to have_title("SAVE SAVE SAVE - Promotions")
+      }
+
+      promotion = Spree::Promotion.find_by(name: "SAVE SAVE SAVE")
+      expect(promotion.path).to be_nil
+      expect(promotion).not_to be_apply_automatically
+      expect(promotion.rules).to be_blank
+
+      expect(promotion.codes.count).to eq(10)
+    end
+
+    it "ceasing to be eligible for a promotion with item total rule then becoming eligible again" do
+      fill_in "Name", with: "SAVE SAVE SAVE"
+      choose "Apply to all orders"
+      click_button "Create"
+      expect(page).to have_title("SAVE SAVE SAVE - Promotions")
+
+      select "Item total", from: "Discount rules"
+      within('#rule_fields') { click_button "Add" }
+      find('[id$=_preferred_amount]').set(50)
+      within('#rule_fields') { click_button "Update" }
+
+      select "Create whole-order adjustment", from: "Adjustment type"
+      within('#action_fields') do
+        click_button "Add"
+        select "Flat Rate", from: I18n.t('spree.admin.promotions.actions.calculator_label')
+        fill_in "Amount", with: "5"
+      end
+      within('#actions_container') { click_button "Update" }
+      expect(page).to have_text 'successfully updated'
+
+      promotion = Spree::Promotion.find_by(name: "SAVE SAVE SAVE")
+
+      first_rule = promotion.rules.first
+      expect(first_rule.class).to eq(Spree::Promotion::Rules::ItemTotal)
+      expect(first_rule.preferred_amount).to eq(50)
+
+      first_action = promotion.actions.first
+      expect(first_action.class).to eq(Spree::Promotion::Actions::CreateAdjustment)
+      expect(first_action.calculator.class).to eq(Spree::Calculator::FlatRate)
+      expect(first_action.calculator.preferred_amount).to eq(5)
+    end
+
+    context 'creating a promotion with promotion action that has a calculator with complex preferences' do
+      before do
+        class ComplexCalculator < Spree::Calculator
+          preference :amount, :decimal
+          preference :currency, :string
+          preference :mapping, :hash
+          preference :list, :array
+
+          def self.description
+            "Complex Calculator"
+          end
+        end
+        @calculators = Rails.application.config.spree.calculators.promotion_actions_create_item_adjustments
+        Rails.application.config.spree.calculators.promotion_actions_create_item_adjustments = [ComplexCalculator]
+      end
+
+      after do
+        Rails.application.config.spree.calculators.promotion_actions_create_item_adjustments = @calculators
+      end
+
+      it "does not show array and hash form fields" do
+        fill_in "Name", with: "SAVE SAVE SAVE"
+        choose "Apply to all orders"
+        click_button "Create"
+        expect(page).to have_title("SAVE SAVE SAVE - Promotions")
+
+        select "Create per-line-item adjustment", from: "Adjustment type"
+        within('#action_fields') do
+          click_button "Add"
+          select "Complex Calculator", from: I18n.t('spree.admin.promotions.actions.calculator_label')
+        end
+        within('#actions_container') { click_button "Update" }
+        expect(page).to have_text 'successfully updated'
+
+        within('#action_fields') do
+          expect(page).to have_field('Amount')
+          expect(page).to have_field('Currency')
+          expect(page).to_not have_field('Mapping')
+          expect(page).to_not have_field('List')
+        end
+      end
+    end
+  end
+end

data/spec/features/admin/promotions/option_value_rule_spec.rb

@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+feature 'Promotion with option value rule' do
+  let(:user) { create(:user) }
+
+  before do
+    allow_any_instance_of(Spree::Admin::BaseController).to receive(:try_spree_current_user).and_return(user)
+  end
+
+  stub_ability_authorization!
+
+  given(:variant) { create :variant }
+  given!(:product) { variant.product }
+  given!(:option_value) { variant.option_values.first }
+
+  given(:promotion) { create :promotion }
+
+  background do
+    visit spree.edit_admin_promotion_path(promotion)
+  end
+
+  scenario "adding an option value rule", js: true do
+    select "Option Value(s)", from: "Discount rules"
+
+    within("#rules_container") { click_button "Add" }
+
+    within("#rules_container .promotion-block") do
+      expect(page).to have_content("Product")
+      expect(page).to have_content("Option Values")
+
+      click_button "Add"
+    end
+
+    within('.promo-rule-option-value') do
+      targetted_select2_search product.name, from: '.js-promo-rule-option-value-product-select'
+      targetted_select2_search option_value.name, from: '.js-promo-rule-option-value-option-values-select'
+    end
+
+    within('#rules_container') { click_button "Update" }
+
+    expect(page).to have_content("has been successfully updated")
+
+    first_rule = promotion.rules.reload.first
+    expect(first_rule.class).to eq Spree::Promotion::Rules::OptionValue
+    expect(first_rule.preferred_eligible_values).to eq Hash[product.id => [option_value.id]]
+  end
+
+  context "with an attempted XSS" do
+    let(:xss_string) { %(<script>throw("XSS")</script>) }
+    before do
+      option_value.update!(name: xss_string)
+    end
+    scenario "adding an option value rule", js: true do
+      select "Option Value(s)", from: "Discount rules"
+      within("#rules_container") { click_button "Add" }
+
+      within("#rules_container .promotion-block") do
+        click_button "Add"
+      end
+
+      within('.promo-rule-option-value') do
+        targetted_select2_search product.name, from: '.js-promo-rule-option-value-product-select'
+        targetted_select2_search option_value.name, from: '.js-promo-rule-option-value-option-values-select'
+      end
+    end
+  end
+
+  context "with an existing option value rule" do
+    given(:variant1) { create :variant }
+    given(:variant2) { create :variant }
+    background do
+      rule = Spree::Promotion::Rules::OptionValue.new
+      rule.promotion = promotion
+      rule.preferred_eligible_values = Hash[
+        variant1.product_id => variant1.option_values.pluck(:id),
+        variant2.product_id => variant2.option_values.pluck(:id)
+      ]
+      rule.save!
+
+      visit spree.edit_admin_promotion_path(promotion)
+    end
+
+    scenario "deleting a product", js: true do
+      expect(page).to have_css('.promo-rule-option-value', count: 2)
+      all('.promo-rule-option-value')[1].find('.remove').click
+
+      within('#rules_container') { click_button "Update" }
+
+      expect(page).to have_content("has been successfully updated")
+
+      first_rule = promotion.rules.reload.first
+      expect(first_rule.preferred_eligible_values).to eq Hash[variant1.product_id => variant1.option_values.pluck(:id)]
+    end
+  end
+end

data/spec/features/admin/promotions/product_rule_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+feature 'Promotion with product rule', js: true do
+  stub_authorization!
+
+  given!(:product) { create :product, name: "BlamCo Mac & Cheese", sku: "PRODUCT_SKU" }
+  given!(:variant) { create :variant, sku: "VARIANT_SKU", product: product }
+  given!(:option_value) { variant.option_values.first }
+
+  given(:promotion) { create :promotion }
+
+  def add_promotion_rule_of_type(type)
+    select type, from: "Discount rules"
+    within("#rules_container") { click_button "Add" }
+  end
+
+  background do
+    visit spree.edit_admin_promotion_path(promotion)
+    add_promotion_rule_of_type("Product(s)")
+  end
+
+  it "can select by product sku" do
+    select2_search product.name, from: "Choose products", search: "PRODUCT_SKU"
+  end
+
+  it "can select by variant sku" do
+    select2_search product.name, from: "Choose products", search: "VARIANT_SKU"
+  end
+
+  it "can select by product name" do
+    select2_search product.name, from: "Choose products"
+  end
+end

data/spec/features/admin/promotions/promotion_categories_spec.rb

@@ -0,0 +1,83 @@
+require 'spec_helper'
+
+describe 'Promotion Categories', type: :feature do
+  stub_authorization!
+
+  context "index" do
+    before do
+      create(:promotion_category, name: 'name1', code: 'code1')
+      create(:promotion_category, name: 'name2', code: 'code2')
+      visit spree.admin_promotion_categories_path
+    end
+
+    context "listing promotion categories" do
+      it "should list the existing promotion categories" do
+        within_row(1) do
+          expect(column_text(1)).to eq("name1")
+          expect(column_text(2)).to eq("code1")
+        end
+
+        within_row(2) do
+          expect(column_text(1)).to eq("name2")
+          expect(column_text(2)).to eq("code2")
+        end
+      end
+    end
+  end
+
+  context "create" do
+    before do
+      visit spree.admin_promotion_categories_path
+      click_on "New Promotion Category"
+    end
+
+    it "should allow an admin to create a new promotion category" do
+      fill_in "promotion_category_name", with: "promotion test"
+      fill_in "promotion_category_code", with: "prtest"
+      click_button "Create"
+      expect(page).to have_content("successfully created!")
+    end
+
+    it "should not allow admin to create promotion category when invalid data" do
+      fill_in "promotion_category_name", with: ""
+      fill_in "promotion_category_code", with: "prtest"
+      click_button "Create"
+      expect(page).to have_content("Name can't be blank")
+    end
+  end
+
+  context "edit" do
+    before(:each) do
+      create(:promotion_category, name: 'name1')
+      visit spree.admin_promotion_categories_path
+      within_row(1) { click_icon :edit }
+    end
+
+    it "should allow an admin to edit an existing promotion category" do
+      fill_in "promotion_category_name", with: "name 99"
+      click_button "Update"
+      expect(page).to have_content("successfully updated!")
+      expect(page).to have_content("name 99")
+    end
+
+    it "should show validation errors" do
+      fill_in "promotion_category_name", with: ""
+      click_button "Update"
+      expect(page).to have_content("Name can't be blank")
+    end
+  end
+
+  context "delete" do
+    before(:each) do
+      create(:promotion_category, name: 'name1')
+      visit spree.admin_promotion_categories_path
+    end
+
+    it "should allow an admin to delete an existing promotion category", js: true do
+      accept_alert do
+        click_icon :trash
+      end
+      expect(page).to have_content("successfully removed!")
+    end
+  end
+end

data/spec/features/admin/promotions/tiered_calculator_spec.rb

@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+feature "Tiered Calculator Promotions" do
+  stub_authorization!
+
+  let(:promotion) { create :promotion }
+
+  background do
+    visit spree.edit_admin_promotion_path(promotion)
+  end
+
+  scenario "adding a tiered percent calculator", js: true do
+    select "Create whole-order adjustment", from: "Adjustment type"
+    within('#action_fields') { click_button "Add" }
+
+    select "Tiered Percent", from: I18n.t('spree.admin.promotions.actions.calculator_label')
+    within('#actions_container') { click_button "Update" }
+
+    within("#actions_container .settings") do
+      expect(page).to have_content("Base Percent")
+      expect(page).to have_content("Tiers")
+
+      page.find('a.button').click
+    end
+
+    fill_in "Base Percent", with: 5
+
+    within(".tier") do
+      find("input:last-child").set(100)
+      find("input:first-child").set(10)
+    end
+
+    within('#actions_container') { click_button "Update" }
+
+    first_action = promotion.actions.first
+    expect(first_action.class).to eq Spree::Promotion::Actions::CreateAdjustment
+
+    first_action_calculator = first_action.calculator
+    expect(first_action_calculator.class).to eq Spree::Calculator::TieredPercent
+    expect(first_action_calculator.preferred_base_percent).to eq 5
+    expect(first_action_calculator.preferred_tiers).to eq(BigDecimal(100) => BigDecimal(10))
+  end
+
+  context "with an existing tiered flat rate calculator" do
+    let(:promotion) { create :promotion, :with_order_adjustment }
+
+    background do
+      action = promotion.actions.first
+
+      action.calculator = Spree::Calculator::TieredFlatRate.new
+      action.calculator.preferred_base_amount = 5
+      action.calculator.preferred_tiers = { 100 => 10, 200 => 15, 300 => 20 }
+      action.calculator.save!
+
+      visit spree.edit_admin_promotion_path(promotion)
+    end
+
+    scenario "deleting a tier", js: true do
+      within(".tier:nth-child(2)") do
+        find(".remove").click
+      end
+
+      within('#actions_container') { click_button "Update" }
+
+      expect(page).to have_text('has been successfully updated!')
+
+      calculator = promotion.actions.first.calculator
+      expect(calculator.preferred_tiers).to eq({
+        BigDecimal(100) => 10,
+        BigDecimal(300) => 20
+      })
+    end
+  end
+end

data/spec/features/admin/promotions/user_rule_spec.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+feature 'Promotion with user rule', js: true do
+  stub_authorization!
+
+  given(:promotion) { create :promotion }
+
+  background do
+    visit spree.edit_admin_promotion_path(promotion)
+  end
+
+  context "multiple users" do
+    let!(:user) { create(:user, email: 'foo@example.com') }
+    let!(:other_user) { create(:user, email: 'bar@example.com') }
+
+    scenario "searching a user" do
+      select "User", from: "Discount rules"
+      within("#rules_container") { click_button "Add" }
+
+      select2_search "foo", from: "Choose users", select: false
+
+      expect(page).to have_content('foo@example.com')
+      expect(page).not_to have_content('bar@example.com')
+    end
+  end
+
+  # this is now prevented by validating the email address
+  # before saving it into the database
+  xcontext "with an attempted XSS" do
+    let(:xss_string) { %(<script>throw("XSS")</script>) }
+    given!(:user) { create(:user, email: xss_string) }
+
+    scenario "adding an option value rule" do
+      select "User", from: "Discount rules"
+      within("#rules_container") { click_button "Add" }
+
+      select2_search "<script>", from: "Choose users"
+
+      expect(page).to have_content(xss_string)
+    end
+  end
+end

data/spec/features/admin/reimbursements_spec.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Promotions', type: :feature do
+  stub_authorization!
+  let!(:reimbursement) { create(:reimbursement) }
+
+  it "should display the reimbursements table" do
+    visit spree.admin_order_reimbursement_path(reimbursement.order, reimbursement)
+    expect(page).to have_css('table thead tr th', text: 'Product')
+    expect(page).to have_css('table thead tr th', text: 'Preferred Reimbursement Type')
+    expect(page).to have_css('table thead tr th', text: 'Reimbursement Type Override')
+    expect(page).to have_css('table thead tr th', text: 'Exchange for')
+    expect(page).to have_css('table thead tr th', text: 'Amount Before Sales Tax')
+    expect(page).to have_css('table thead tr th', text: 'Total')
+  end
+end