solidus_backend_devise_token_auth 2.8.0.alpha.2

data/spec/features/admin/products/products_spec.rb

@@ -0,0 +1,336 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Products", type: :feature do
+  context "as admin user" do
+    stub_authorization!
+
+    before(:each) do
+      visit spree.admin_path
+    end
+
+    def build_option_type_with_values(name, values)
+      ot = FactoryBot.create(:option_type, name: name)
+      values.each do |val|
+        ot.option_values.create(name: val.downcase, presentation: val)
+      end
+      ot
+    end
+
+    context "listing products" do
+      context "sorting" do
+        before do
+          create(:product, name: 'apache baseball cap', price: 10)
+          create(:product, name: 'zomg shirt', price: 5)
+        end
+
+        it "should list existing products with correct sorting by name" do
+          click_nav "Products"
+          # Name ASC
+          within_row(1) { expect(page).to have_content('apache baseball cap') }
+          within_row(2) { expect(page).to have_content("zomg shirt") }
+
+          # Name DESC
+          click_link "admin_products_listing_name_title"
+          within_row(1) { expect(page).to have_content("zomg shirt") }
+          within_row(2) { expect(page).to have_content('apache baseball cap') }
+        end
+
+        it "should list existing products with correct sorting by price" do
+          click_nav "Products"
+
+          # Name ASC (default)
+          within_row(1) { expect(page).to have_content('apache baseball cap') }
+          within_row(2) { expect(page).to have_content("zomg shirt") }
+
+          # Price DESC
+          click_link "admin_products_listing_price_title"
+          within_row(1) { expect(page).to have_content("zomg shirt") }
+          within_row(2) { expect(page).to have_content('apache baseball cap') }
+        end
+      end
+
+      context "currency displaying" do
+        context "using Russian Rubles" do
+          before do
+            Spree::Config[:currency] = "RUB"
+          end
+
+          let!(:product) do
+            create(:product, name: "Just a product", price: 19.99)
+          end
+
+          # Regression test for https://github.com/spree/spree/issues/2737
+          context "uses руб as the currency symbol" do
+            it "on the products listing page" do
+              visit spree.admin_products_path
+              within_row(1) { expect(page).to have_content("19.99 ₽") }
+            end
+          end
+        end
+      end
+      context "when none of the product prices are in the same currency as the default in the store" do
+        before do
+          Spree::Config[:currency] = "MXN"
+        end
+
+        let!(:product) do
+          create(:product, name: "Just a product", price: 19.99)
+        end
+
+        it 'defaults it to Spree::Config.currency and sets the price as blank' do
+          Spree::Config[:currency] = "USD"
+          visit spree.admin_product_path(product)
+          within("#product_price_field") do
+            expect(page).to have_content("USD")
+          end
+        end
+      end
+    end
+
+    context "searching products" do
+      it "should be able to search deleted products", js: true do
+        create(:product, name: 'apache baseball cap', deleted_at: "2011-01-06 18:21:13")
+        create(:product, name: 'zomg shirt')
+
+        click_nav "Products"
+        expect(page).to have_content("zomg shirt")
+        expect(page).not_to have_content("apache baseball cap")
+        check "Show Deleted"
+        click_button 'Search'
+        expect(find('input[name="q[with_deleted]"]')).to be_checked
+        expect(page).to have_content("zomg shirt")
+        expect(page).to have_content("apache baseball cap")
+        uncheck "Show Deleted"
+        click_button 'Search'
+        expect(page).to have_content("zomg shirt")
+        expect(page).not_to have_content("apache baseball cap")
+      end
+
+      it "should be able to search products by their properties" do
+        create(:product, name: 'apache baseball cap', sku: "A100")
+        create(:product, name: 'apache baseball cap2', sku: "B100")
+        create(:product, name: 'zomg shirt')
+
+        click_nav "Products"
+        fill_in "Name", with: "ap"
+        click_button 'Search'
+        expect(page).to have_content("apache baseball cap")
+        expect(page).to have_content("apache baseball cap2")
+        expect(page).not_to have_content("zomg shirt")
+
+        fill_in "SKU", with: "A1"
+        click_button "Search"
+        expect(page).to have_content("apache baseball cap")
+        expect(page).not_to have_content("apache baseball cap2")
+        expect(page).not_to have_content("zomg shirt")
+      end
+
+      # Regression test for https://github.com/solidusio/solidus/issues/2016
+      it "should be able to search and sort by price" do
+        product = create(:product, name: 'apache baseball cap', sku: "A001")
+        create(:variant, product: product, sku: "A002")
+        create(:product, name: 'zomg shirt', sku: "Z001")
+
+        click_nav "Products"
+        expect(page).to have_content("apache baseball cap")
+        expect(page).to have_content("zomg shirt")
+        expect(page).to have_css('#listing_products > tbody > tr', count: 2)
+
+        fill_in "SKU", with: "A"
+        click_button 'Search'
+        expect(page).to have_content("apache baseball cap")
+        expect(page).not_to have_content("zomg shirt")
+        expect(page).to have_css('#listing_products > tbody > tr', count: 1)
+
+        # Sort by master price
+        click_on 'Master Price'
+        expect(page).to have_css('.sort_link.asc', text: 'Master Price')
+        expect(page).to have_content("apache baseball cap")
+        expect(page).not_to have_content("zomg shirt")
+        expect(page).to have_css('#listing_products > tbody > tr', count: 1)
+      end
+    end
+
+    context "creating a new product" do
+      before(:each) do
+        @shipping_category = create(:shipping_category)
+        click_nav "Products"
+        click_on "New Product"
+      end
+
+      it "should allow an admin to create a new product", js: true do
+        fill_in "product_name", with: "Baseball Cap"
+        fill_in "product_sku", with: "B100"
+        fill_in "product_price", with: "100"
+        fill_in "product_available_on", with: "2012/01/24"
+        select @shipping_category.name, from: "product_shipping_category_id"
+        click_button "Create"
+        expect(page).to have_content("successfully created!")
+        click_button "Update"
+        expect(page).to have_content("successfully updated!")
+      end
+
+      it "should show validation errors", js: false do
+        fill_in "product_name", with: "Baseball Cap"
+        fill_in "product_sku", with: "B100"
+        fill_in "product_price", with: "100"
+        click_button "Create"
+        expect(page).to have_content("Shipping category can't be blank")
+      end
+
+      context "using a locale with a different decimal format " do
+        before do
+          # change English locale’s separator and delimiter to match 19,99 format
+          I18n.backend.store_translations(:en,
+            number: {
+              currency: {
+                format: {
+                  separator: ",",
+                  delimiter: "."
+                }
+              }
+            })
+        end
+
+        after do
+          # revert changes to English locale
+          I18n.backend.store_translations(:en,
+            number: {
+              currency: {
+                format: {
+                  separator: ".",
+                  delimiter: ","
+                }
+              }
+            })
+        end
+
+        it "should show localized price value on validation errors", js: true do
+          fill_in "Name", with: " "
+          select @shipping_category.name, from: "product_shipping_category_id"
+          fill_in "product_price", with: "19,99"
+          click_button "Create"
+          expect(page).to have_content("Name can't be blank")
+          expect(page).to have_field('product_price', with: '19,99')
+        end
+      end
+
+      # Regression test for https://github.com/spree/spree/issues/2097
+      it "can set the count on hand to a null value", js: true do
+        fill_in "product_name", with: "Baseball Cap"
+        fill_in "product_price", with: "100"
+        select @shipping_category.name, from: "product_shipping_category_id"
+        click_button "Create"
+        expect(page).to have_content("successfully created!")
+        click_button "Update"
+        expect(page).to have_content("successfully updated!")
+      end
+    end
+
+    context "cloning a product", js: true do
+      it "should allow an admin to clone a product" do
+        create(:product)
+
+        click_nav "Products"
+        within_row(1) do
+          click_icon :copy
+        end
+
+        expect(page).to have_content("Product has been cloned")
+      end
+
+      context "cloning a deleted product" do
+        it "should allow an admin to clone a deleted product" do
+          create(:product, name: "apache baseball cap")
+
+          click_nav "Products"
+          check "Show Deleted"
+          click_button "Search"
+
+          expect(page).to have_content("apache baseball cap")
+
+          within_row(1) do
+            click_icon :copy
+          end
+
+          expect(page).to have_content("Product has been cloned")
+        end
+      end
+    end
+
+    context 'updating a product', js: true do
+      let(:product) { create(:product) }
+
+      it 'should parse correctly available_on' do
+        visit spree.admin_product_path(product)
+        fill_in "product_available_on", with: "2012/12/25"
+        click_button "Update"
+        expect(page).to have_content("successfully updated!")
+        expect(Spree::Product.last.available_on).to eq('Tue, 25 Dec 2012 00:00:00 UTC +00:00')
+      end
+    end
+
+    context 'deleting a product', js: true do
+      let!(:product) { create(:product) }
+
+      it "product details are still viewable" do
+        visit spree.admin_products_path
+
+        expect(page).to have_content(product.name)
+        accept_alert do
+          click_icon :trash
+        end
+
+        expect(page).to have_no_content(product.name)
+
+        # This will show our deleted product
+        check "Show Deleted"
+        click_button "Search"
+        click_link product.name
+        expect(page).to have_field('Master Price', with: product.price.to_f)
+        expect(page).to_not have_content('Images')
+        expect(page).to_not have_content('Prices')
+        expect(page).to_not have_content('Product Properties')
+      end
+    end
+  end
+
+  context 'with only product permissions' do
+    before do
+      allow_any_instance_of(Spree::Admin::BaseController).to receive(:spree_current_user).and_return(nil)
+    end
+
+    custom_authorization! do |_user|
+      can [:admin, :update, :index, :read], Spree::Product
+    end
+    let!(:product) { create(:product) }
+
+    it "should only display accessible links on index" do
+      visit spree.admin_products_path
+      expect(page).to have_link('Products')
+      expect(page).not_to have_link('Option Types')
+      expect(page).not_to have_link('Properties')
+
+      expect(page).not_to have_link('New Product')
+      expect(page).not_to have_css('a.clone')
+      expect(page).to have_css('a.edit')
+      expect(page).not_to have_css('a.delete-resource')
+    end
+
+    it "should only display accessible links on edit" do
+      visit spree.admin_product_path(product)
+
+      # product tabs should be hidden
+      expect(page).to have_link('Product Details')
+      expect(page).not_to have_link('Images')
+      expect(page).not_to have_link('Variants')
+      expect(page).not_to have_link('Product Properties')
+      expect(page).not_to have_link('Stock Management')
+
+      # no create permission
+      expect(page).not_to have_link('New Product')
+    end
+  end
+end

data/spec/features/admin/products/properties_spec.rb

@@ -0,0 +1,141 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Properties", type: :feature do
+  stub_authorization!
+
+  before(:each) do
+    visit spree.admin_path
+    click_nav "Products"
+  end
+
+  context "Property index" do
+    before do
+      create(:property, name: 'shirt size', presentation: 'size')
+      create(:property, name: 'shirt fit', presentation: 'fit')
+      click_link "Property Types"
+    end
+
+    context "listing product properties" do
+      it "should list the existing product properties" do
+        within_row(1) do
+          expect(column_text(1)).to eq("shirt size")
+          expect(column_text(2)).to eq("size")
+        end
+
+        within_row(2) do
+          expect(column_text(1)).to eq("shirt fit")
+          expect(column_text(2)).to eq("fit")
+        end
+      end
+    end
+
+    context "searching properties" do
+      it 'should list properties matching search query', js: true do
+        fill_in "q_name_cont", with: "size"
+        click_button 'Search'
+
+        expect(page).to have_content("shirt size")
+        expect(page).not_to have_content("shirt fit")
+      end
+    end
+  end
+
+  context "creating a property" do
+    it "should allow an admin to create a new product property", js: true do
+      click_link "Property Types"
+      click_link "new_property_link"
+      within('#new_property') { expect(page).to have_content("New Property Type") }
+
+      fill_in "property_name", with: "color of band"
+      fill_in "property_presentation", with: "color"
+      click_button "Create"
+      expect(page).to have_content("successfully created!")
+    end
+  end
+
+  context "editing a property type" do
+    before(:each) do
+      create(:property)
+      click_link "Property Types"
+      within_row(1) { click_icon :edit }
+    end
+
+    it "should allow an admin to edit an existing product property" do
+      fill_in "property_name", with: "model 99"
+      click_button "Update"
+      expect(page).to have_content("successfully updated!")
+      expect(page).to have_content("model 99")
+    end
+
+    it "should show validation errors" do
+      fill_in "property_name", with: ""
+      click_button "Update"
+      expect(page).to have_content("Name can't be blank")
+    end
+  end
+
+  context "linking a property to a product", js: true do
+    before do
+      create(:product)
+      visit spree.admin_products_path
+      click_icon :edit
+      click_link "Product Properties"
+    end
+
+    # Regression test for https://github.com/spree/spree/issues/2279
+    it "successfully create and then remove product property" do
+      fill_in_property
+
+      check_property_row_count(2)
+
+      delete_product_property
+
+      check_property_row_count(1)
+    end
+
+    # Regression test for https://github.com/spree/spree/issues/4466
+    it "successfully remove and create a product property at the same time" do
+      fill_in_property
+
+      expect(page).to have_css('tr.product_property', count: 2)
+
+      within '#spree_new_product_property' do
+        find('[id$=_property_name]').set("New Property")
+        find('[id$=_value]').set("New Value")
+      end
+
+      delete_product_property
+
+      # Give fadeOut time to complete
+      expect(page).to have_css('tr.product_property', count: 1)
+
+      click_button "Update"
+
+      expect(page).not_to have_content("Product is not found")
+
+      check_property_row_count(2)
+    end
+
+    def fill_in_property
+      expect(page).to have_content('Products')
+      fill_in "product_product_properties_attributes_0_property_name", with: "A Property"
+      fill_in "product_product_properties_attributes_0_value", with: "A Value"
+      click_button "Update"
+      click_link "Product Properties"
+    end
+
+    def delete_product_property
+      accept_alert do
+        click_icon :trash
+      end
+      expect(page).to have_content 'successfully removed'
+    end
+
+    def check_property_row_count(expected_row_count)
+      click_link "Product Properties"
+      expect(page).to have_css("tbody#product_properties tr", count: expected_row_count)
+    end
+  end
+end

data/spec/features/admin/products/stock_management_spec.rb

@@ -0,0 +1,84 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Product Stock", type: :feature do
+  stub_authorization!
+
+  before(:each) do
+    visit spree.admin_path
+  end
+
+  context "given a product with a variant and a stock location" do
+    let!(:stock_location) { create(:stock_location, name: 'Default') }
+    let!(:product) { create(:product, name: 'apache baseball cap', price: 10) }
+    let!(:variant) { create(:variant, product: product) }
+    let(:stock_item) { variant.stock_items.find_by(stock_location: stock_location) }
+
+    before do
+      stock_location.stock_item(variant).update_column(:count_on_hand, 10)
+
+      click_nav "Products"
+      within_row(1) { click_icon :edit }
+      click_link "Product Stock"
+    end
+
+    # Regression test for https://github.com/spree/spree/issues/3304
+    # It is OK to still render the stock page, ensure no errors in this case
+    context "with no stock location" do
+      before do
+        Spree::StockLocation.destroy_all
+        find_by_id('content-header').click_link('Products')
+        within_row(1) do
+          click_icon :edit
+        end
+        click_link "Product Stock"
+      end
+
+      it "renders" do
+        expect(page).to have_content('Productsapache baseball cap')
+        expect(page.current_url).to match("admin/products/apache-baseball-cap/stock")
+      end
+    end
+
+    it "can create a positive stock adjustment", js: true do
+      adjust_count_on_hand('14')
+      stock_item.reload
+      expect(stock_item.count_on_hand).to eq 24
+      expect(stock_item.stock_movements.count).to eq 1
+      expect(stock_item.stock_movements.first.quantity).to eq 14
+    end
+
+    it "can create a negative stock adjustment", js: true do
+      adjust_count_on_hand('-4')
+      stock_item.reload
+      expect(stock_item.count_on_hand).to eq 6
+      expect(stock_item.stock_movements.count).to eq 1
+      expect(stock_item.stock_movements.first.quantity).to eq(-4)
+    end
+
+    def adjust_count_on_hand(count_on_hand)
+      within("tr#spree_variant_#{variant.id}") do
+        find(:css, "input[type='number']").set(count_on_hand)
+        click_icon :check
+      end
+      expect(page).to have_content('Updated successfully')
+    end
+
+    context "with stock locations that don't have stock items for variant yet" do
+      before do
+        create(:stock_location, name: 'Other location', propagate_all_variants: false)
+      end
+
+      it "can add stock items to other stock locations", js: true do
+        visit current_url
+        within('.variant-stock-items', text: variant.sku) do
+          fill_in "variant-count-on-hand-#{variant.id}", with: '3'
+          select "Other location", from: "stock_location_id"
+          click_icon(:plus)
+        end
+        expect(page).to have_content('Created successfully')
+      end
+    end
+  end
+end

data/spec/features/admin/products/variant_spec.rb

@@ -0,0 +1,89 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Variants", type: :feature do
+  stub_authorization!
+
+  let(:product) { create(:product_with_option_types, price: "1.99", cost_price: "1.00", weight: "2.5", height: "3.0", width: "1.0", depth: "1.5") }
+
+  context "creating a new variant" do
+    it "should allow an admin to create a new variant" do
+      product.options.each do |option|
+        create(:option_value, option_type: option.option_type)
+      end
+
+      visit spree.admin_path
+      click_nav "Products"
+      within_row(1) { click_icon :edit }
+      click_link "Variants"
+      click_on "New Variant"
+      expect(page).to have_field('variant_price', with: "1.99")
+      expect(page).to have_field('variant_cost_price', with: "1.00")
+      expect(page).to have_field('variant_weight', with: "2.50")
+      expect(page).to have_field('variant_height', with: "3.00")
+      expect(page).to have_field('variant_width', with: "1.00")
+      expect(page).to have_field('variant_depth', with: "1.50")
+      expect(page).to have_select('variant[tax_category_id]')
+    end
+  end
+
+  context "listing variants" do
+    context "currency displaying" do
+      context "using Russian Rubles" do
+        before do
+          Spree::Config[:currency] = "RUB"
+        end
+
+        let!(:variant) do
+          create(:variant, product: product, price: 19.99)
+        end
+
+        # Regression test for https://github.com/spree/spree/issues/2737
+        context "uses руб as the currency symbol" do
+          it "on the products listing page" do
+            visit spree.admin_product_variants_path(product)
+            within_row(1) { expect(page).to have_content("19.99 ₽") }
+          end
+        end
+      end
+    end
+  end
+
+  context "editing existent variant" do
+    let!(:variant) { create(:variant, product: product) }
+
+    context "if product has an option type" do
+      let!(:option_type) { create(:option_type) }
+      let!(:option_value) { create(:option_value, option_type: option_type) }
+
+      before do
+        product.option_types << option_type
+        variant.option_values << option_value
+      end
+
+      it "page has a field for editing the option value", js: true do
+        visit spree.edit_admin_product_variant_path(product, variant)
+        expect(page).to have_css("label", text: option_type.presentation)
+        expect(page).to have_select('Size', selected: 'S')
+      end
+    end
+  end
+
+  context "deleting a variant", js: true do
+    let!(:variant) { create(:variant, product: product) }
+    let!(:option_type) { create(:option_type) }
+    let!(:option_value) { create(:option_value, option_type: option_type) }
+
+    it "can delete a variant" do
+      visit spree.admin_product_variants_path(product)
+      within 'tr', text: 'Size: S' do
+        accept_alert do
+          click_icon :trash
+        end
+      end
+
+      expect(page).to have_no_text('Size: S')
+    end
+  end
+end