solidus_backend_devise_token_auth 2.8.0.alpha.2

data/spec/controllers/spree/admin/users_controller_spec.rb

@@ -0,0 +1,249 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Spree::Admin::UsersController, type: :controller do
+  let(:user) { create(:user) }
+
+  let(:state) { create(:state, state_code: 'NY') }
+  let(:valid_address_attributes) do
+    {
+      firstname: 'Foo',
+      lastname: 'Bar',
+      city: "New York",
+      country_id: state.country.id,
+      state_id: state.id,
+      phone: '555-555-5555',
+      address1: '123 Fake St.',
+      zipcode: '10001',
+    }
+  end
+
+  context "#show" do
+    stub_authorization! do |_user|
+      can [:admin, :manage], Spree.user_class
+    end
+
+    it "redirects to edit" do
+      get :show, params: { id: user.id }
+      expect(response).to redirect_to spree.edit_admin_user_path(user)
+    end
+  end
+
+  context '#authorize_admin' do
+    context "with ability to admin users" do
+      stub_authorization! do |_user|
+        can [:manage], Spree.user_class
+      end
+
+      it 'can visit index' do
+        post :index
+        expect(response).to be_successful
+      end
+    end
+
+    context "without ability to admin users" do
+      stub_authorization! do |_user|
+      end
+
+      it 'denies access' do
+        post :index
+        expect(response).to redirect_to '/unauthorized'
+      end
+    end
+  end
+
+  describe "#create" do
+    let(:dummy_role) { Spree::Role.create(name: "dummyrole") }
+
+    # The created user
+    def user
+      Spree.user_class.last
+    end
+
+    stub_authorization! do |_user|
+      can :manage, Spree.user_class
+    end
+
+    context "when the user can manage roles" do
+      stub_authorization! do |_user|
+        can :manage, Spree.user_class
+        can :manage, Spree::Role
+      end
+
+      it "can create user with roles" do
+        post :create, params: { user: { first_name: "Bob", password: 'lubieplacki', email: 'lubie@placki.com', spree_role_ids: [dummy_role.id] } }
+        expect(user.spree_roles).to eq([dummy_role])
+      end
+
+      it "can create user without roles" do
+        post :create, params: { user: { first_name: "Bob", password: 'lubieplacki', email: 'lubie@placki.com' } }
+        expect(user.spree_roles).to eq([])
+      end
+    end
+
+    context "when the user cannot manage roles" do
+      it "cannot assign users roles" do
+        post :create, params: { user: { first_name: "Bob", password: 'lubieplacki', email: 'lubie@placki.com', spree_role_ids: [dummy_role.id] } }
+        expect(user.spree_roles).to eq([])
+      end
+
+      it "can create user without roles" do
+        post :create, params: { user: { first_name: "Bob", password: 'lubieplacki', email: 'lubie@placki.com' } }
+        expect(user.spree_roles).to eq([])
+      end
+    end
+
+    it "can create a shipping_address" do
+      post :create, params: { user: { ship_address_attributes: valid_address_attributes, password: 'lubieplacki', email: 'lubie@placki.com' } }
+      expect(user.reload.ship_address.city).to eq('New York')
+    end
+
+    it "can create a billing_address" do
+      post :create, params: { user: { bill_address_attributes: valid_address_attributes, password: 'lubieplacki', email: 'lubie@placki.com' } }
+      expect(user.reload.bill_address.city).to eq('New York')
+    end
+
+    it "can set stock locations" do
+      location = Spree::StockLocation.create(name: "my_location")
+      location_2 = Spree::StockLocation.create(name: "my_location_2")
+      post :create, params: { user: { stock_location_ids: [location.id, location_2.id], password: 'lubieplacki', email: 'lubie@placki.com' } }
+      expect(user.stock_locations).to match_array([location, location_2])
+    end
+  end
+
+  describe "#update" do
+    let(:dummy_role) { Spree::Role.create(name: "dummyrole") }
+    let(:ability) { Spree::Ability.new(user) }
+
+    stub_authorization! do |_user|
+      can :manage, Spree.user_class
+    end
+
+    context "when the user can manage roles" do
+      stub_authorization! do |_user|
+        can :manage, Spree.user_class
+        can :manage, Spree::Role
+      end
+
+      it "can set roles" do
+        expect {
+          put :update, params: { id: user.id, user: { first_name: "Bob", spree_role_ids: [dummy_role.id] } }
+        }.to change { user.reload.spree_roles.to_a }.to([dummy_role])
+      end
+
+      it "can clear roles" do
+        user.spree_roles << dummy_role
+        expect {
+          put :update, params: { id: user.id, user: { first_name: "Bob", spree_role_ids: [""] } }
+        }.to change { user.reload.spree_roles.to_a }.to([])
+      end
+
+      context 'when no role params are present' do
+        it 'does not clear all present user roles' do
+          user.spree_roles << dummy_role
+          put :update, params: { id: user.id, user: { first_name: "Bob" } }
+          expect(user.reload.spree_roles).to_not be_empty
+        end
+      end
+    end
+
+    context "when the user cannot manage roles" do
+      it "cannot set roles" do
+        expect {
+          put :update, params: { id: user.id, user: { first_name: "Bob", spree_role_ids: [dummy_role.id] } }
+        }.not_to change { user.reload.spree_roles.to_a }
+      end
+
+      it "cannot clear roles" do
+        user.spree_roles << dummy_role
+        expect {
+          put :update, params: { id: user.id, user: { first_name: "Bob" } }
+        }.not_to change { user.reload.spree_roles.to_a }
+      end
+    end
+
+    context "allowed to update email" do
+      stub_authorization! do |_user|
+        can [:admin, :update, :update_email], Spree.user_class
+      end
+
+      it "can change email of a user" do
+        expect {
+          put :update, params: { id: user.id, user: { email: "bob@example.com" } }
+        }.to change { user.reload.email }.to("bob@example.com")
+      end
+    end
+
+    context "not allowed to update email" do
+      stub_authorization! do |_user|
+        can [:admin, :update], Spree.user_class
+      end
+
+      it "cannot change email of a user" do
+        expect {
+          put :update, params: { id: user.id, user: { email: "bob@example.com" } }
+        }.not_to change { user.reload.email }
+      end
+    end
+
+    it "can update ship_address attributes" do
+      post :update, params: { id: user.id, user: { ship_address_attributes: valid_address_attributes } }
+      expect(user.reload.ship_address.city).to eq('New York')
+    end
+
+    it "can update bill_address attributes" do
+      post :update, params: { id: user.id, user: { bill_address_attributes: valid_address_attributes } }
+      expect(user.reload.bill_address.city).to eq('New York')
+    end
+
+    it "can set stock locations" do
+      location = Spree::StockLocation.create(name: "my_location")
+      location_2 = Spree::StockLocation.create(name: "my_location_2")
+      post :update, params: { id: user.id, user: { stock_location_ids: [location.id, location_2.id] } }
+      expect(user.stock_locations).to match_array([location, location_2])
+    end
+  end
+
+  describe "#orders" do
+    stub_authorization! do |_user|
+      can :manage, Spree.user_class
+    end
+
+    let(:order) { create(:order) }
+    before { user.orders << order }
+
+    it "assigns a list of the users orders" do
+      get :orders, params: { id: user.id }
+      expect(assigns[:orders].count).to eq 1
+      expect(assigns[:orders].first).to eq order
+    end
+
+    it "assigns a ransack search for Spree::Order" do
+      get :orders, params: { id: user.id }
+      expect(assigns[:search]).to be_a Ransack::Search
+      expect(assigns[:search].klass).to eq Spree::Order
+    end
+  end
+
+  describe "#items" do
+    stub_authorization! do |_user|
+      can :manage, Spree.user_class
+    end
+
+    let(:order) { create(:order) }
+    before { user.orders << order }
+
+    it "assigns a list of the users orders" do
+      get :items, params: { id: user.id }
+      expect(assigns[:orders].count).to eq 1
+      expect(assigns[:orders].first).to eq order
+    end
+
+    it "assigns a ransack search for Spree::Order" do
+      get :items, params: { id: user.id }
+      expect(assigns[:search]).to be_a Ransack::Search
+      expect(assigns[:search].klass).to eq Spree::Order
+    end
+  end
+end

data/spec/controllers/spree/admin/variants_controller_spec.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+module Spree
+  module Admin
+    describe VariantsController, type: :controller do
+      stub_authorization!
+
+      describe "#index" do
+        let(:product) { create(:product) }
+        let(:params) { { product_id: product.slug } }
+
+        subject { get :index, params: params }
+
+        context "the value of @parent" do
+          it "is the product" do
+            subject
+            expect(assigns(:parent)).to eq product
+          end
+
+          context "with a deleted product" do
+            before { product.discard }
+
+            it "is the product" do
+              subject
+              expect(assigns(:parent)).to eq product
+            end
+          end
+        end
+
+        context "the value of @collection" do
+          let!(:variant) { create(:variant, product: product) }
+          let!(:deleted_variant) { create(:variant, product: product) }
+
+          context "with soft-deleted variants" do
+            before { deleted_variant.discard }
+
+            context "when deleted is not requested" do
+              it "excludes deleted variants" do
+                subject
+                expect(assigns(:collection)).to include variant
+                expect(assigns(:collection)).not_to include deleted_variant
+              end
+            end
+
+            context "when deleted is requested" do
+              let(:params) { { product_id: product.slug, deleted: "on" } }
+
+              it "includes deleted variants" do
+                subject
+                expect(assigns(:collection)).to include variant
+                expect(assigns(:collection)).to include deleted_variant
+              end
+            end
+          end
+        end
+      end
+
+      describe "#delete" do
+        let!(:variant) { create(:variant) }
+        let(:product) { variant.product }
+
+        it "can be deleted" do
+          delete :destroy, params: { product_id: product.to_param, id: variant.to_param }
+          expect(variant.reload).to be_discarded
+        end
+      end
+    end
+  end
+end

data/spec/features/admin/configuration/payment_methods_spec.rb

@@ -0,0 +1,167 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Payment Methods", type: :feature do
+  stub_authorization!
+
+  before(:each) do
+    visit spree.admin_path
+    click_link "Settings"
+  end
+
+  context "admin visiting payment methods listing page" do
+    before do
+      create(:check_payment_method)
+    end
+
+    it "should display existing payment methods" do
+      click_link "Payments"
+      expect(page).to have_link 'Payment Methods'
+      within("table#listing_payment_methods") do
+        expect(all("th")[1].text).to eq("Name")
+        expect(all("th")[2].text).to eq("Type")
+        expect(all("th")[3].text).to eq("Available to users")
+        expect(all("th")[4].text).to eq("Available to admin")
+        expect(all("th")[5].text).to eq("State")
+      end
+
+      within('table#listing_payment_methods') do
+        expect(page).to have_content(Spree::PaymentMethod::Check.model_name.human)
+      end
+    end
+  end
+
+  context "admin creating a new payment method" do
+    it "should be able to create a new payment method" do
+      click_link "Payments"
+      expect(page).to have_link 'Payment Methods'
+      click_link "admin_new_payment_methods_link"
+      expect(page).to have_content("New Payment Method")
+      fill_in "payment_method_name", with: "check90"
+      fill_in "payment_method_description", with: "check90 desc"
+      select Spree::PaymentMethod::Check.model_name.human, from: "Type"
+      click_button "Create"
+      expect(page).to have_content("successfully created!")
+    end
+  end
+
+  context "admin editing a payment method" do
+    let!(:payment_method) { create(:check_payment_method) }
+
+    before do
+      click_link "Payments"
+      expect(page).to have_link 'Payment Methods'
+      within("table#listing_payment_methods") do
+        click_icon(:edit)
+      end
+    end
+
+    it "should be able to edit an existing payment method" do
+      fill_in "payment_method_name", with: "Payment 99"
+      click_button "Update"
+      expect(page).to have_content("successfully updated!")
+      expect(page).to have_field("payment_method_name", with: "Payment 99")
+    end
+
+    context "with multiple stores available" do
+      before do
+        create(:store, name: "Default Store", url: "spreestore.example.com")
+        visit current_path
+      end
+
+      it "should be able to change the associated stores" do
+        select "Default Store", from: "Stores"
+        click_button "Update"
+        expect(page).to have_content("successfully updated!")
+        expect(page).to have_select("payment_method_store_ids", selected: "Default Store")
+      end
+    end
+
+    it "should display validation errors" do
+      fill_in "payment_method_name", with: ""
+      click_button "Update"
+      expect(page).to have_content("Name can't be blank")
+    end
+
+    context 'with payment method having hash and array as preference' do
+      class ComplexPayments < Spree::PaymentMethod
+        preference :name, :string
+        preference :mapping, :hash
+        preference :recipients, :array
+      end
+
+      let!(:payment_method) { ComplexPayments.create!(name: 'Complex Payments') }
+
+      it "does not display preference fields that are hash or array" do
+        expect(page).to have_field("Name")
+        expect(page).to_not have_field("Mapping")
+        expect(page).to_not have_field("Recipients")
+      end
+    end
+  end
+
+  context "changing type and payment_source", js: true do
+    before do
+      create(:credit_card_payment_method)
+    end
+
+    it "displays message when changing type" do
+      click_link "Payments"
+      expect(page).to have_link 'Payment Methods'
+      click_icon :edit
+      expect(page).to have_content('Test Mode')
+
+      select Spree::PaymentMethod::Check.model_name.human, from: 'Type'
+      expect(page).to have_content('you must save first')
+      expect(page).to have_no_content('Test Mode')
+
+      # change back
+      select Spree::PaymentMethod::BogusCreditCard.model_name.human, from: 'Type'
+      expect(page).to have_no_content('you must save first')
+      expect(page).to have_content('Test Mode')
+    end
+
+    it "displays message when changing preference source" do
+      Spree::Config.static_model_preferences.add(Spree::PaymentMethod::BogusCreditCard, 'my_prefs', {})
+
+      click_link "Payments"
+      expect(page).to have_link 'Payment Methods'
+      click_icon :edit
+      expect(page).to have_content('Test Mode')
+
+      select 'my_prefs', from: 'Preference Source'
+      expect(page).to have_content('you must save first')
+      expect(page).to have_no_content('Test Mode')
+
+      # change back
+      select '(custom)', from: 'Preference Source'
+      expect(page).to have_no_content('you must save first')
+      expect(page).to have_content('Test Mode')
+    end
+
+    it "updates successfully and keeps secrets" do
+      Spree::Config.static_model_preferences.add(Spree::PaymentMethod::BogusCreditCard, 'my_prefs', { server: 'secret' })
+
+      click_link "Payments"
+      expect(page).to have_link 'Payment Methods'
+      click_icon :edit
+
+      select 'my_prefs', from: 'Preference Source'
+      click_on 'Update'
+      expect(page).to have_content('Using static preferences')
+      expect(page).to have_no_content('secret')
+
+      # change back
+      select '(custom)', from: 'Preference Source'
+      click_on 'Update'
+      expect(page).to have_content('Test Mode')
+      expect(page).to have_no_content('secret')
+    end
+
+    after do
+      # cleanup
+      Spree::Config.static_model_preferences.for_class(Spree::PaymentMethod::BogusCreditCard).clear
+    end
+  end
+end

data/spec/features/admin/configuration/shipping_methods_spec.rb

@@ -0,0 +1,114 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Shipping Methods", type: :feature do
+  stub_authorization!
+  let!(:zone) { create(:global_zone) }
+  let!(:shipping_method) { create(:shipping_method, zones: [zone]) }
+
+  before do
+    visit spree.admin_path
+    click_link "Settings"
+    click_link "Shipping"
+  end
+
+  context "show" do
+    it "should display existing shipping methods" do
+      within_row(1) do
+        expect(column_text(1)).to eq(shipping_method.name)
+        expect(column_text(2)).to eq(zone.name)
+        expect(column_text(3)).to eq("Flat rate")
+        expect(column_text(4)).to eq("Yes")
+      end
+    end
+  end
+
+  context "create", js: true do
+    it "should be able to create a new shipping method" do
+      click_link "New Shipping Method"
+
+      fill_in "shipping_method_name", with: "bullock cart"
+
+      within("#shipping_method_categories_field") do
+        check first("input[type='checkbox']")["name"]
+      end
+
+      click_on "Create"
+      expect(current_path).to eql(spree.edit_admin_shipping_method_path(Spree::ShippingMethod.last))
+    end
+
+    context 'with shipping method having a calculator with array or hash preference type' do
+      before do
+        class ComplexShipments < Spree::ShippingCalculator
+          preference :amount, :decimal
+          preference :currency, :string
+          preference :mapping, :hash
+          preference :list, :array
+
+          def self.description
+            "Complex Shipments"
+          end
+        end
+        @calculators = Rails.application.config.spree.calculators.shipping_methods
+        Rails.application.config.spree.calculators.shipping_methods = [ComplexShipments]
+      end
+
+      after do
+        Rails.application.config.spree.calculators.shipping_methods = @calculators
+      end
+
+      it "does not show array and hash form fields" do
+        click_link "New Shipping Method"
+
+        fill_in "shipping_method_name", with: "bullock cart"
+
+        within("#shipping_method_categories_field") do
+          check first("input[type='checkbox']")["name"]
+        end
+
+        click_on "Create"
+        select 'Complex Shipments', from: 'Base Calculator'
+        click_on "Update"
+
+        expect(page).to have_field('Amount')
+        expect(page).to have_field('Currency')
+        expect(page).to_not have_field('Mapping')
+        expect(page).to_not have_field('List')
+      end
+    end
+  end
+
+  # Regression test for https://github.com/spree/spree/issues/1331
+  context "update" do
+    it "can update the existing calculator", js: true do
+      within("#listing_shipping_methods") do
+        click_icon :edit
+      end
+
+      fill_in 'Amount', with: 20
+
+      click_button "Update"
+
+      expect(page).to have_content 'successfully updated'
+      expect(page).to have_field 'Amount', with: '20.0'
+    end
+
+    it "can change the calculator", js: true do
+      within("#listing_shipping_methods") do
+        click_icon :edit
+      end
+
+      select 'Flexible Rate per package item', from: 'Base Calculator'
+
+      fill_in 'First Item', with: 10
+      fill_in 'Additional Item', with: 20
+
+      click_button "Update"
+
+      expect(page).to have_content 'successfully updated'
+      expect(page).to have_field 'First Item', with: '10.0'
+      expect(page).to have_field 'Additional Item', with: '20.0'
+    end
+  end
+end

data/spec/features/admin/configuration/stock_locations_spec.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Stock Locations", type: :feature do
+  stub_authorization!
+
+  before(:each) do
+    create(:country)
+    visit spree.admin_path
+    click_link "Settings"
+    click_link "Shipping"
+    click_link "Stock Locations"
+  end
+
+  it "can create a new stock location" do
+    click_link "New Stock Location"
+    fill_in "Name", with: "London"
+    check "Active"
+    click_button "Create"
+
+    expect(page).to have_content("successfully created")
+    expect(page).to have_content("London")
+  end
+
+  it "can delete an existing stock location", js: true do
+    create(:stock_location)
+    visit current_path
+
+    expect(find('#listing_stock_locations')).to have_content("NY Warehouse")
+    accept_alert do
+      click_icon :trash
+    end
+
+    expect(page).to have_content('Stock Location "NY Warehouse" has been successfully removed')
+
+    visit current_path
+    expect(page).to have_content("No Stock Locations found")
+  end
+
+  it "can update an existing stock location" do
+    create(:stock_location)
+    visit current_path
+
+    expect(page).to have_content("NY Warehouse")
+
+    click_icon :edit
+    fill_in "Name", with: "London"
+    click_button "Update"
+
+    expect(page).to have_content("successfully updated")
+    expect(page).to have_content("London")
+  end
+end