solidus_backend_devise_token_auth 2.8.0.alpha.2

data/spec/features/admin/orders/payments_spec.rb

@@ -0,0 +1,289 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Payments', type: :feature do
+  stub_authorization!
+
+  context "with a pre-existing payment" do
+    let!(:payment) do
+      create(:payment,
+        order:          order,
+        amount:         order.outstanding_balance,
+        payment_method: create(:credit_card_payment_method),
+        state:          state)
+    end
+
+    let(:order) { create(:completed_order_with_totals, number: 'R100', line_items_price: 50) }
+    let(:state) { 'checkout' }
+
+    before do
+      visit "/admin/orders/#{order.number}/payments"
+    end
+
+    # Regression tests for https://github.com/spree/spree/issues/1453
+    context 'with a check payment', js: true do
+      let(:order) { create(:completed_order_with_totals, number: 'R100') }
+      let!(:payment) do
+        create(:payment,
+          order:          order,
+          amount:         order.outstanding_balance,
+          payment_method: create(:check_payment_method, available_to_admin: true)) # Check
+      end
+
+      it 'capturing a check payment from a new order' do
+        click_icon(:capture)
+        expect(page).not_to have_content('Cannot perform requested operation')
+        expect(page).to have_content('Payment Updated')
+      end
+
+      it 'voids a check payment from a new order' do
+        click_icon(:void)
+        expect(page).to have_content('Payment Updated')
+      end
+    end
+
+    it 'should list all captures for a payment' do
+      capture_amount = order.outstanding_balance / 2 * 100
+      payment.capture!(capture_amount)
+
+      visit spree.admin_order_payment_path(order, payment)
+      expect(page).to have_content 'Capture Events'
+      # within '#capture_events' do
+      within_row(1) do
+        expect(page).to have_content(capture_amount / 100)
+      end
+      # end
+    end
+
+    it 'displays the address for a credit card when present' do
+      payment.source.update!(address: create(:address, address1: 'my cc address'))
+      visit spree.admin_order_payment_path(order, payment)
+      expect(page).to have_content 'my cc address'
+    end
+
+    it 'lists, updates and creates payments for an order', js: true do
+      within_row(1) do
+        expect(column_text(3)).to eq('Credit Card')
+        expect(column_text(5)).to eq('Checkout')
+        expect(column_text(6)).to have_content('$150.00')
+      end
+
+      click_icon :void
+      expect(page).to have_css('#payment_status', text: 'Balance due')
+      expect(page).to have_content('Payment Updated')
+
+      within_row(1) do
+        expect(column_text(5)).to eq('Void')
+      end
+
+      click_on 'New Payment'
+      expect(page).to have_content('New Payment')
+      click_button 'Update'
+      expect(page).to have_content('successfully created!')
+
+      click_icon(:capture)
+
+      expect(page).to have_selector('#payment_status', text: 'Paid')
+      expect(page).not_to have_selector('#new_payment_section')
+    end
+
+    # Regression test for https://github.com/spree/spree/issues/1269
+    it 'cannot create a payment for an order with no payment methods' do
+      Spree::PaymentMethod.delete_all
+      order.payments.delete_all
+
+      click_on 'New Payment'
+      expect(page).to have_content('You cannot create a payment for an order without any payment methods defined.')
+      expect(page).to have_content('Please define some payment methods first.')
+    end
+
+    context 'payment is pending', js: true do
+      let(:state) { 'pending' }
+
+      it 'allows the amount to be edited by clicking on the edit button then saving' do
+        within_row(1) do
+          click_icon(:edit)
+          fill_in('amount', with: '$1')
+          click_icon(:save)
+          expect(page).to have_selector('td.amount span', text: '$1.00')
+          expect(payment.reload.amount).to eq(1.00)
+        end
+      end
+
+      it 'allows the amount change to be cancelled by clicking on the cancel button' do
+        within_row(1) do
+          click_icon(:edit)
+
+          # Can't use fill_in here, as under poltergeist that will unfocus (and
+          # thus submit) the field under poltergeist
+          find('td.amount input').click
+          page.execute_script("$('td.amount input').val('$1')")
+
+          click_icon(:cancel)
+          expect(page).to have_selector('td.amount span', text: '$150.00')
+          expect(payment.reload.amount).to eq(150.00)
+        end
+      end
+
+      it 'displays an error when the amount is invalid' do
+        within_row(1) do
+          click_icon(:edit)
+          fill_in('amount', with: 'invalid')
+          click_icon(:save)
+        end
+        expect(page).to have_selector('.flash.error', text: 'Invalid resource. Please fix errors and try again.')
+        expect(payment.reload.amount).to eq(150.00)
+      end
+    end
+
+    context 'payment is completed', js: true do
+      let(:state) { 'completed' }
+
+      it 'does not allow the amount to be edited' do
+        within_row(1) do
+          expect(page).not_to have_selector('.fa-edit')
+        end
+      end
+    end
+  end
+
+  context "with no prior payments" do
+    let(:order) { create(:order_with_line_items, line_items_count: 1) }
+    let!(:payment_method) { create(:credit_card_payment_method) }
+
+    # Regression tests for https://github.com/spree/spree/issues/4129
+    context "with a credit card payment method" do
+      before do
+        visit spree.admin_order_payments_path(order)
+      end
+
+      it "is able to create a new credit card payment with valid information", js: true do
+        fill_in "Card Number", with: "4111 1111 1111 1111"
+        fill_in "Name", with: "Test User"
+        fill_in "Expiration", with: "09 / #{Time.current.year + 1}"
+        fill_in "Card Code", with: "007"
+        # Regression test for https://github.com/spree/spree/issues/4277
+        expect(page).to have_css('.ccType[value="visa"]', visible: false)
+        click_button "Continue"
+        expect(page).to have_content("Payment has been successfully created!")
+      end
+
+      it "is unable to create a new payment with invalid information" do
+        click_button "Continue"
+        expect(page).to have_content("Payment could not be created.")
+        expect(page).to have_content("Number can't be blank")
+        expect(page).to have_content("Name can't be blank")
+        expect(page).to have_content("Verification Value can't be blank")
+        expect(page).to have_content("Month is not a number")
+        expect(page).to have_content("Year is not a number")
+      end
+    end
+
+    context "user existing card" do
+      let!(:cc) do
+        create(:credit_card, payment_method: payment_method, gateway_customer_profile_id: "BGS-RFRE")
+      end
+
+      before do
+        order.user.wallet.add(cc)
+        visit spree.admin_order_payments_path(order)
+      end
+
+      it "is able to reuse customer payment source" do
+        expect(find("#card_#{cc.id}")).to be_checked
+        click_button "Continue"
+        expect(page).to have_content("Payment has been successfully created!")
+      end
+    end
+
+    context "with a check" do
+      let(:order) { create(:completed_order_with_totals, line_items_count: 1) }
+      let!(:payment_method) { create(:check_payment_method) }
+
+      before do
+        visit spree.admin_order_payments_path(order.reload)
+      end
+
+      it "can successfully be created and captured", js: true do
+        click_on 'Update'
+        expect(page).to have_content("Payment has been successfully created!")
+        click_icon(:capture)
+        expect(page).to have_content("Payment Updated")
+      end
+    end
+
+    context 'with a soft-deleted payment method' do
+      let(:order) { create(:completed_order_with_totals, line_items_count: 1) }
+      let!(:payment_method) { create(:check_payment_method) }
+      let!(:payment) do
+        create(:payment,
+          order:          order,
+          amount:         order.outstanding_balance,
+          payment_method: payment_method)
+      end
+
+      before do
+        payment_method.discard
+        visit spree.admin_order_payments_path(order.reload)
+      end
+
+      it "can list and view the payment" do
+        expect(page).to have_content(payment.number)
+        click_on payment.number
+        expect(page).to have_current_path("/admin/orders/#{order.number}/payments/#{payment.id}")
+        expect(page).to have_content(payment.amount)
+      end
+    end
+  end
+
+  # Previously this would fail unless the method was named "Credit Card"
+  context "with an differently named payment method" do
+    let(:order) { create(:order_with_line_items, line_items_count: 1) }
+    let!(:chequing_payment_method) { create(:check_payment_method) }
+    let!(:payment_method) { create(:credit_card_payment_method, name: "Multipass!") }
+
+    before do
+      visit spree.admin_order_payments_path(order.reload)
+    end
+
+    it "is able to create a new payment", js: true do
+      choose payment_method.name
+      fill_in "Card Number", with: "4111 1111 1111 1111"
+      fill_in "Name", with: "Test User"
+      fill_in "Expiration", with: "09 / #{Time.current.year + 1}"
+      fill_in "Card Code", with: "007"
+      click_button "Continue"
+      expect(page).to have_content("Payment has been successfully created!")
+    end
+  end
+
+  context "when required quantity is more than available" do
+    let(:product) { create(:product_not_backorderable) }
+
+    let(:order) do
+      create(:order_with_line_items, {
+        line_items_count: 1,
+        line_items_attributes: [{ quantity: 11, product: product }],
+        stock_location: product.master.stock_locations.first
+      })
+    end
+
+    let!(:chequing_payment_method) { create(:check_payment_method) }
+    let!(:payment_method) { create(:credit_card_payment_method, name: "Multipass!") }
+
+    before do
+      visit spree.admin_order_payments_path(order.reload)
+    end
+
+    it "displays an error" do
+      choose payment_method.name
+      fill_in "Card Number", with: "4111 1111 1111 1111"
+      fill_in "Name", with: "Test User"
+      fill_in "Expiration", with: "09 / #{Time.current.year + 1}"
+      fill_in "Card Code", with: "007"
+      click_button "Continue"
+      expect(page).to have_content I18n.t('spree.insufficient_stock_for_order')
+    end
+  end
+end

data/spec/features/admin/orders/return_authorizations_spec.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "ReturnAuthorizations", type: :feature do
+  include OrderFeatureHelper
+
+  stub_authorization!
+
+  let!(:order) { create(:shipped_order) }
+  let!(:return_authorization) { create(:return_authorization, order: order) }
+
+  it "can visit the return authorizations list page" do
+    visit spree.admin_order_return_authorizations_path(order)
+  end
+
+  describe "edit" do
+    it "can visit the return authorizations edit page" do
+      visit spree.edit_admin_order_return_authorization_path(order, return_authorization)
+    end
+
+    it "return authorizations edit page has a data hook for extensions to add content above, below or within the RA form" do
+      visit spree.edit_admin_order_return_authorization_path(order, return_authorization)
+      expect(page).to have_selector("[data-hook=return-authorization-form-wrapper]")
+    end
+  end
+end

data/spec/features/admin/orders/return_payment_state_spec.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Return payment state spec" do
+  stub_authorization!
+
+  before do
+    Spree::RefundReason.create!(name: Spree::RefundReason::RETURN_PROCESSING_REASON, mutable: false)
+  end
+
+  let!(:order) { create(:shipped_order) }
+
+  # Regression test for https://github.com/spree/spree/issues/6229
+  it "refunds and has outstanding_balance of zero", js: true do
+    expect(order).to have_attributes(
+      total: 110,
+      refund_total: 0,
+      payment_total: 110,
+      outstanding_balance: 0,
+      payment_state: 'paid'
+    )
+
+    # From an order with a shipped shipment
+    visit "/admin/orders/#{order.number}/edit"
+
+    # Create a Return Authorization (select the Original Reimbursement type)
+    click_on 'RMA'
+    click_on 'New RMA'
+
+    find('.add-item').click # check first (and only) item
+    select Spree::StockLocation.first.name, from: 'return_authorization[stock_location_id]', visible: false
+    click_on 'Create'
+
+    # Create a Customer Return (select the item from 'Items in Return Authorizations')
+    click_on 'Customer Returns'
+    click_on 'New Customer Return'
+
+    find('input.add-item').click # check first (and only) item
+    select 'Received', from: 'customer_return[return_items_attributes][0][reception_status_event]', visible: false
+    select Spree::StockLocation.first.name, from: 'customer_return[stock_location_id]', visible: false
+    click_on 'Create'
+
+    # Create reimbursement
+    click_on 'Create reimbursement'
+
+    # Reimburse.
+    click_on 'Reimburse'
+
+    expect(page).to have_css('tr.reimbursement-refund')
+
+    order.reload
+
+    expect(order).to have_attributes(
+      total: 110,
+      refund_total: 10,
+      payment_total: 100,
+      outstanding_balance: 0,
+      payment_state: 'paid'
+    )
+  end
+end

data/spec/features/admin/orders/risk_analysis_spec.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Order Risk Analysis', type: :feature do
+  stub_authorization!
+
+  let!(:order) do
+    create(:completed_order_with_pending_payment)
+  end
+
+  def visit_order
+    visit spree.admin_path
+    click_link 'Orders'
+    within_row(1) do
+      click_link order.number
+    end
+  end
+
+  context "the order is considered risky" do
+    before do
+      allow_any_instance_of(Spree::Admin::BaseController).to receive_messages try_spree_current_user: create(:user)
+
+      order.payments.first.update_column(:avs_response, 'N')
+      visit_order
+    end
+
+    it "displays 'Risk Analysis' box" do
+      expect(page).to have_content 'Risk Analysis'
+    end
+
+    it "can be approved" do
+      click_button('Approve')
+      expect(page).to have_content 'Approver'
+      expect(page).to have_content 'Approved at'
+      expect(page).to have_content 'Status: Complete'
+    end
+  end
+
+  context "the order is not considered risky" do
+    before do
+      visit_order
+    end
+
+    it "does not display 'Risk Analysis' box" do
+      expect(page).to_not have_content 'Risk Analysis'
+    end
+  end
+end

data/spec/features/admin/orders/shipments_spec.rb

@@ -0,0 +1,145 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Shipments", type: :feature do
+  include OrderFeatureHelper
+
+  stub_authorization!
+
+  let!(:order) { create(:order_ready_to_ship, number: "R100", state: "complete", line_items_count: 5) }
+
+  # Regression test for https://github.com/spree/spree/issues/4025
+  context "a shipment without a shipping method" do
+    before do
+      order.shipments.each do |s|
+        # Deleting the shipping rates causes there to be no shipping methods
+        s.shipping_rates.delete_all
+      end
+    end
+
+    it "can still be displayed" do
+      visit spree.edit_admin_order_path(order)
+    end
+  end
+
+  context "shipping an order", js: true do
+    before(:each) do
+      visit spree.admin_path
+      click_link "Orders"
+      within_row(1) do
+        click_link "R100"
+      end
+    end
+
+    def ship_shipment
+      find(".ship-shipment-button").click
+
+      expect(page).to have_content("Shipped package")
+      expect(order.reload.shipment_state).to eq("shipped")
+    end
+
+    it "can ship a completed order" do
+      expect {
+        perform_enqueued_jobs {
+          ship_shipment
+        }
+      }.to change{ ActionMailer::Base.deliveries.count }.by(1)
+    end
+
+    it "doesn't send a shipping confirmation email when ask to suppress the mailer" do
+      uncheck 'Send Mailer'
+
+      expect {
+        perform_enqueued_jobs {
+          ship_shipment
+        }
+      }.not_to change{ ActionMailer::Base.deliveries.count }
+    end
+  end
+
+  context "destroying a shipment", js: true do
+    before do
+      visit spree.admin_path
+      click_link "Orders"
+      within_row(1) do
+        click_link "R100"
+      end
+    end
+
+    context "when the line item cannot be found" do
+      it "shows the proper error message" do
+        expect(page).to have_selector '.delete-item'
+        order.shipments.first.line_items.each(&:destroy)
+        accept_alert { first('.delete-item').click }
+        expect(page).to have_content 'The resource you were looking for could not be found.'
+      end
+    end
+
+    context "when the shipment has already been shipped" do
+      it "shows the proper error message" do
+        expect(page).to have_selector '.delete-item'
+        order.shipments.first.ship!
+        accept_alert { first('.delete-item').click }
+        expect(page).to have_content 'Cannot remove items from a shipped shipment'
+      end
+    end
+  end
+
+  context "moving variants between shipments", js: true do
+    let!(:order) { create(:completed_order_with_pending_payment, number: "R100", state: "complete", line_items_count: 5) }
+    let!(:la) { create(:stock_location, name: "LA") }
+    before(:each) do
+      visit spree.admin_path
+      click_link "Orders"
+      within_row(1) do
+        click_link "R100"
+      end
+    end
+
+    it "can move a variant to a new and to an existing shipment" do
+      expect(order.shipments.count).to eq(1)
+      shipment1 = order.shipments[0]
+
+      within('tr', text: order.line_items[0].sku) { click_icon 'arrows-h' }
+      complete_split_to('LA')
+
+      expect(page).to have_css("#shipment_#{shipment1.id} tr.stock-item", count: 4)
+      shipment2 = (order.reload.shipments.to_a - [shipment1]).first
+      expect(page).to have_css("#shipment_#{shipment2.id} tr.stock-item", count: 1)
+      within "#shipment_#{shipment2.id}" do
+        expect(page).to have_content("UPS Ground")
+      end
+
+      within('tr', text: order.line_items[1].sku) { click_icon 'arrows-h' }
+      complete_split_to("LA(#{shipment2.number})")
+      expect(page).to have_css("#shipment_#{shipment2.id} tr.stock-item", count: 2)
+      expect(page).to have_css("#shipment_#{shipment1.id} tr.stock-item", count: 3)
+
+      within "#shipment_#{shipment2.id}" do
+        expect(page).to have_content("UPS Ground")
+      end
+    end
+
+    context "with a ready-to-ship order" do
+      let(:variant) { create(:variant) }
+      let!(:order) do
+        create(
+          :order_ready_to_ship,
+          number: "R100",
+          line_items_attributes: [{ variant: variant, quantity: 5 }]
+        )
+      end
+
+      it "can transfer all items to a new location" do
+        expect(order.shipments.count).to eq(1)
+
+        within('tr', text: order.line_items[0].sku) { click_icon 'arrows-h' }
+        complete_split_to('LA', quantity: 5)
+
+        expect(page).to_not have_content("package from 'NY Warehouse'")
+        expect(page).to have_content("package from 'LA'")
+      end
+    end
+  end
+end

data/spec/features/admin/payments/store_credits_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'Store credits', type: :feature do
+  stub_authorization!
+
+  let(:order) { FactoryBot.create(:completed_order_with_totals) }
+  let(:payment) do
+    FactoryBot.create(
+      :store_credit_payment,
+      order: order,
+      amount: 20
+    )
+  end
+
+  it "viewing a store credit payment" do
+    visit spree.admin_order_payment_path(order, payment)
+
+    expect(page).to have_content "Store Credit"
+    expect(page).to have_content "Amount: $20.00"
+  end
+end

data/spec/features/admin/products/edit/images_spec.rb

@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe "Product Images", type: :feature do
+  stub_authorization!
+
+  let(:file_path) { Rails.root + "../../spec/support/ror_ringer.jpeg" }
+  let(:product)   { create(:product) }
+
+  before do
+    # Ensure attachment style keys are symbolized before running all tests
+    # Otherwise this would result in this error:
+    # undefined method `processors' for \"48x48>\
+    Spree::Image.attachment_definitions[:attachment][:styles].symbolize_keys!
+  end
+
+  context "uploading, editing, and deleting an image", js: true do
+    it "should allow an admin to upload and edit an image for a product" do
+      Spree::Image.attachment_definitions[:attachment].delete :storage
+
+      create(:product)
+
+      visit spree.admin_path
+      click_nav "Products"
+      click_icon(:edit)
+      click_link "Images"
+      click_link "new_image_link"
+      within_fieldset 'New Image' do
+        attach_file('image_attachment', file_path)
+      end
+      click_button "Update"
+      expect(page).to have_content("successfully created!")
+
+      # Icons are hidden, so hover to have them pop-up
+      find('tbody > tr').hover
+      within_row(1) do
+        within ".actions" do
+          click_icon :edit
+        end
+      end
+
+      fill_in "image_alt", with: "ruby on rails t-shirt"
+      click_button "Update"
+
+      expect(page).to have_content "successfully updated!"
+      expect(page).to have_field "image[alt]", with: "ruby on rails t-shirt"
+
+      find('tbody > tr').hover
+      accept_alert do
+        click_icon :trash
+      end
+      expect(page).not_to have_field "image[alt]", with: "ruby on rails t-shirt"
+    end
+  end
+
+  it "should not see variant column when product has no variants" do
+    product = create(:product)
+    product.images.create!(attachment: File.open(file_path))
+    visit spree.admin_product_images_path(product)
+
+    expect(page).not_to have_content("No Images Found.")
+    within("table.index") do
+      # ensure no duplicate images are displayed
+      expect(page).to have_css("tbody tr", count: 1)
+
+      # ensure variant header is not displayed
+      within("thead") do
+        expect(page).not_to have_content("Variant")
+      end
+
+      # ensure correct cell count
+      expect(page).to have_css("thead th", count: 4)
+    end
+  end
+end