shipit-engine 0.5.2 → 0.6.0

data/test/models/status_group_test.rb

@@ -1,24 +1,26 @@
 require 'test_helper'
 
-class StatusGroupTest < ActiveSupport::TestCase
-  setup do
-    @commit = commits(:second)
-    @group = StatusGroup.new(@commit.significant_status, @commit.visible_statuses)
-  end
+module Shipit
+  class StatusGroupTest < ActiveSupport::TestCase
+    setup do
+      @commit = shipit_commits(:second)
+      @group = StatusGroup.new(@commit.significant_status, @commit.visible_statuses)
+    end
 
-  test "#description is a summary of the statuses" do
-    assert_equal '1 / 2 checks OK', @group.description
-  end
+    test "#description is a summary of the statuses" do
+      assert_equal '1 / 2 checks OK', @group.description
+    end
 
-  test "#group? returns true" do
-    assert_equal true, @group.group?
-  end
+    test "#group? returns true" do
+      assert_equal true, @group.group?
+    end
 
-  test "#target_url returns nil" do
-    assert_nil @group.target_url
-  end
+    test "#target_url returns nil" do
+      assert_nil @group.target_url
+    end
 
-  test "#state is significant's status state" do
-    assert_equal @commit.significant_status.state, @group.state
+    test "#state is significant's status state" do
+      assert_equal @commit.significant_status.state, @group.state
+    end
   end
 end

data/test/models/status_test.rb

@@ -1,55 +1,57 @@
 require 'test_helper'
 
-class StatusTest < ActiveSupport::TestCase
-  setup do
-    @commit = commits(:first)
-    @stack = @commit.stack
-  end
-
-  test ".replicate_from_github! is idempotent" do
-    assert_difference '@commit.statuses.count', 1 do
-      @commit.statuses.replicate_from_github!(github_status)
+module Shipit
+  class StatusTest < ActiveSupport::TestCase
+    setup do
+      @commit = shipit_commits(:first)
+      @stack = @commit.stack
     end
 
-    assert_no_difference '@commit.statuses.count' do
-      @commit.statuses.replicate_from_github!(github_status)
+    test ".replicate_from_github! is idempotent" do
+      assert_difference '@commit.statuses.count', 1 do
+        @commit.statuses.replicate_from_github!(github_status)
+      end
+
+      assert_no_difference '@commit.statuses.count' do
+        @commit.statuses.replicate_from_github!(github_status)
+      end
     end
-  end
 
-  test "once created a commit broadcasts an update event" do
-    expect_event(@stack)
-    @commit.statuses.create!(state: 'success')
-  end
+    test "once created a commit broadcasts an update event" do
+      expect_event(@stack)
+      @commit.statuses.create!(state: 'success')
+    end
 
-  test ".replicate_from_github! touches the related stack" do
-    stack_last_updated_at = @stack.updated_at
-    commit_last_updated_at = @commit.updated_at
+    test ".replicate_from_github! touches the related stack" do
+      stack_last_updated_at = @stack.updated_at
+      commit_last_updated_at = @commit.updated_at
 
-    @commit.statuses.replicate_from_github!(github_status)
+      @commit.statuses.replicate_from_github!(github_status)
 
-    assert_not_equal commit_last_updated_at, @commit.reload.updated_at
-    assert_not_equal stack_last_updated_at, @stack.reload.updated_at
-  end
+      assert_not_equal commit_last_updated_at, @commit.reload.updated_at
+      assert_not_equal stack_last_updated_at, @stack.reload.updated_at
+    end
 
-  private
+    private
 
-  def github_status
-    @github_status ||= OpenStruct.new(
-      state: 'success',
-      description: 'This is a description',
-      context: 'default',
-      target_url: 'http://example.com',
-      created_at: 1.day.ago.to_time,
-    )
-  end
+    def github_status
+      @github_status ||= OpenStruct.new(
+        state: 'success',
+        description: 'This is a description',
+        context: 'default',
+        target_url: 'http://example.com',
+        created_at: 1.day.ago.to_time,
+      )
+    end
 
-  def expect_event(stack)
-    Pubsubstub::RedisPubSub.expects(:publish).at_least_once
-    Pubsubstub::RedisPubSub.expects(:publish).with do |channel, event|
-      data = JSON.load(event.data)
-      event.name == 'stack.update' &&
-        channel == "stack.#{stack.id}" &&
-        data['url'] == "/#{stack.to_param}"
+    def expect_event(stack)
+      Pubsubstub::RedisPubSub.expects(:publish).at_least_once
+      Pubsubstub::RedisPubSub.expects(:publish).with do |channel, event|
+        data = JSON.load(event.data)
+        event.name == 'stack.update' &&
+          channel == "stack.#{stack.id}" &&
+          data['url'] == "/#{stack.to_param}"
+      end
     end
   end
 end

data/test/models/task_definitions_test.rb

@@ -1,32 +1,34 @@
 require 'test_helper'
 
-class TaskDefinitionsTest < ActiveSupport::TestCase
-  setup do
-    @definition = TaskDefinition.new(
-      'restart',
-      'action' => 'Restart application',
-      'description' => 'Restart app and job servers',
-      'steps' => ['touch tmp/restart'],
-    )
-  end
+module Shipit
+  class TaskDefinitionsTest < ActiveSupport::TestCase
+    setup do
+      @definition = TaskDefinition.new(
+        'restart',
+        'action' => 'Restart application',
+        'description' => 'Restart app and job servers',
+        'steps' => ['touch tmp/restart'],
+      )
+    end
 
-  test ".load returns nil if payload is nil or blank" do
-    assert_nil TaskDefinition.load('')
-    assert_nil TaskDefinition.load(nil)
-  end
+    test ".load returns nil if payload is nil or blank" do
+      assert_nil TaskDefinition.load('')
+      assert_nil TaskDefinition.load(nil)
+    end
 
-  test ".dump returns nil if given nil" do
-    assert_nil TaskDefinition.dump(nil)
-  end
+    test ".dump returns nil if given nil" do
+      assert_nil TaskDefinition.dump(nil)
+    end
 
-  test "serialization works" do
-    as_json = {
-      id: 'restart',
-      action: 'Restart application',
-      description: 'Restart app and job servers',
-      steps: ['touch tmp/restart'],
-      checklist: [],
-    }
-    assert_equal as_json, TaskDefinition.load(TaskDefinition.dump(@definition)).as_json
+    test "serialization works" do
+      as_json = {
+        id: 'restart',
+        action: 'Restart application',
+        description: 'Restart app and job servers',
+        steps: ['touch tmp/restart'],
+        checklist: [],
+      }
+      assert_equal as_json, TaskDefinition.load(TaskDefinition.dump(@definition)).as_json
+    end
   end
 end

data/test/models/team_test.rb

@@ -1,50 +1,52 @@
 require 'test_helper'
 
-class TeamTest < ActiveSupport::TestCase
-  setup do
-    @team = teams(:shopify_developers)
-  end
+module Shipit
+  class TeamTest < ActiveSupport::TestCase
+    setup do
+      @team = shipit_teams(:shopify_developers)
+    end
 
-  test ".find_or_create_by_handle first search in the database" do
-    assert_equal @team, Team.find_or_create_by_handle('Shopify/developers')
-  end
+    test ".find_or_create_by_handle first search in the database" do
+      assert_equal @team, Team.find_or_create_by_handle('Shopify/developers')
+    end
 
-  test ".find_or_create_by_handle fetch the team from github if it's not in the db already" do
-    Shipit.github_api.expects(:org_teams).with('shopify', per_page: 100)
-    response = stub(rels: {}, data: [new_team])
-    Shipit.github_api.expects(:last_response).returns(response)
-    assert_difference -> { Team.count }, 1 do
-      Team.find_or_create_by_handle('Shopify/new-team')
+    test ".find_or_create_by_handle fetch the team from github if it's not in the db already" do
+      Shipit.github_api.expects(:org_teams).with('shopify', per_page: 100)
+      response = stub(rels: {}, data: [new_team])
+      Shipit.github_api.expects(:last_response).returns(response)
+      assert_difference -> { Team.count }, 1 do
+        Team.find_or_create_by_handle('Shopify/new-team')
+      end
     end
-  end
 
-  test "#refresh_members! fetch all the team members from github" do
-    response = stub(rels: {members: members_resource})
-    Shipit.github_api.expects(:get).with(@team.api_url).returns(response)
-    assert_difference -> { User.count }, 1 do
-      @team.refresh_members!
+    test "#refresh_members! fetch all the team members from github" do
+      response = stub(rels: {members: members_resource})
+      Shipit.github_api.expects(:get).with(@team.api_url).returns(response)
+      assert_difference -> { User.count }, 1 do
+        @team.refresh_members!
+      end
     end
-  end
 
-  private
+    private
 
-  def members_resource
-    stub(get: stub(data: [george], rels: {}))
-  end
+    def members_resource
+      stub(get: stub(data: [george], rels: {}))
+    end
 
-  def george
-    rels = {self: stub(href: 'https://api.github.com/user/george')}
-    stub(id: 42, name: 'George Abitbol', login: 'george', email: 'george@cyclim.se', rels: rels)
-  end
+    def george
+      rels = {self: stub(href: 'https://api.github.com/user/george')}
+      stub(id: 42, name: 'George Abitbol', login: 'george', email: 'george@cyclim.se', rels: rels)
+    end
 
-  def new_team
-    stub(
-      id: 24,
-      name: 'New Team',
-      slug: 'new-team',
-      url: 'https://example.com',
-      description: 'The Best one',
-      organization: 'shopify',
-    )
+    def new_team
+      stub(
+        id: 24,
+        name: 'New Team',
+        slug: 'new-team',
+        url: 'https://example.com',
+        description: 'The Best one',
+        organization: 'shopify',
+      )
+    end
   end
 end

data/test/models/users_test.rb

@@ -1,82 +1,84 @@
 require 'test_helper'
 
-class UsersTest < ActiveSupport::TestCase
-  setup do
-    @user = users(:walrus)
-    rels = {self: stub(href: 'https://api.github.com/user/george')}
-    @github_user = stub(id: 42, name: 'George Abitbol', login: 'george', email: 'george@cyclim.se', rels: rels)
-  end
+module Shipit
+  class UsersTest < ActiveSupport::TestCase
+    setup do
+      @user = shipit_users(:walrus)
+      rels = {self: stub(href: 'https://api.github.com/user/george')}
+      @github_user = stub(id: 42, name: 'George Abitbol', login: 'george', email: 'george@cyclim.se', rels: rels)
+    end
 
-  test "find_or_create_from_github persist a new user if he is unknown" do
-    assert_difference 'User.count', 1 do
-      fetch_user
+    test "find_or_create_from_github persist a new user if he is unknown" do
+      assert_difference 'User.count', 1 do
+        fetch_user
+      end
     end
-  end
 
-  test "find_or_create_from_github returns the existing user if he is known" do
-    existing = fetch_user
+    test "find_or_create_from_github returns the existing user if he is known" do
+      existing = fetch_user
 
-    assert_no_difference 'User.count' do
-      assert_equal existing, fetch_user
+      assert_no_difference 'User.count' do
+        assert_equal existing, fetch_user
+      end
     end
-  end
 
-  test "find_or_create_from_github store the github_id" do
-    user = User.find_or_create_from_github(@github_user)
-    assert_equal @github_user.id, user.github_id
-  end
+    test "find_or_create_from_github store the github_id" do
+      user = User.find_or_create_from_github(@github_user)
+      assert_equal @github_user.id, user.github_id
+    end
 
-  test "find_or_create_from_github store the name" do
-    user = User.find_or_create_from_github(@github_user)
-    assert_equal @github_user.name, user.name
-  end
+    test "find_or_create_from_github store the name" do
+      user = User.find_or_create_from_github(@github_user)
+      assert_equal @github_user.name, user.name
+    end
 
-  test "find_or_create_from_github store the email" do
-    user = User.find_or_create_from_github(@github_user)
-    assert_equal @github_user.email, user.email
-  end
+    test "find_or_create_from_github store the email" do
+      user = User.find_or_create_from_github(@github_user)
+      assert_equal @github_user.email, user.email
+    end
 
-  test "find_or_create_from_github store the login" do
-    user = User.find_or_create_from_github(@github_user)
-    assert_equal @github_user.login, user.login
-  end
+    test "find_or_create_from_github store the login" do
+      user = User.find_or_create_from_github(@github_user)
+      assert_equal @github_user.login, user.login
+    end
 
-  test "#identifiers_for_ping returns a hash with the user's github_id, name, email and github_login" do
-    user = users(:bob)
-    expected_ouput = {github_id: user.github_id, name: user.name, email: user.email, github_login: user.login}
-    assert_equal expected_ouput, user.identifiers_for_ping
-  end
+    test "#identifiers_for_ping returns a hash with the user's github_id, name, email and github_login" do
+      user = shipit_users(:bob)
+      expected_ouput = {github_id: user.github_id, name: user.name, email: user.email, github_login: user.login}
+      assert_equal expected_ouput, user.identifiers_for_ping
+    end
 
-  test "#refresh_from_github! update the user with the latest data from GitHub's API" do
-    Shipit.github_api.expects(:user).with('walrus').returns(@github_user)
-    @user.refresh_from_github!
-    @user.reload
+    test "#refresh_from_github! update the user with the latest data from GitHub's API" do
+      Shipit.github_api.expects(:user).with('walrus').returns(@github_user)
+      @user.refresh_from_github!
+      @user.reload
 
-    assert_equal 'George Abitbol', @user.name
-    assert_equal 'george@cyclim.se', @user.email
-  end
+      assert_equal 'George Abitbol', @user.name
+      assert_equal 'george@cyclim.se', @user.email
+    end
 
-  test "#refresh_from_github! can identify renamed users and update commits and tasks accordingly" do
-    user = users(:bob)
-    user.update!(github_id: @github_user.id)
-    commit = user.authored_commits.last
+    test "#refresh_from_github! can identify renamed users and update commits and tasks accordingly" do
+      user = shipit_users(:bob)
+      user.update!(github_id: @github_user.id)
+      commit = user.authored_commits.last
 
-    Shipit.github_api.expects(:user).with(user.login).raises(Octokit::NotFound)
-    Shipit.github_api.expects(:commit).with(commit.github_repo_name, commit.sha).returns(mock(author: @github_user))
+      Shipit.github_api.expects(:user).with(user.login).raises(Octokit::NotFound)
+      Shipit.github_api.expects(:commit).with(commit.github_repo_name, commit.sha).returns(mock(author: @github_user))
 
-    assert_equal 'bob', user.login
+      assert_equal 'bob', user.login
 
-    user.refresh_from_github!
-    user.reload
+      user.refresh_from_github!
+      user.reload
 
-    assert_equal 'george', user.login
-    assert_equal 'George Abitbol', user.name
-    assert_equal 'george@cyclim.se', user.email
-  end
+      assert_equal 'george', user.login
+      assert_equal 'George Abitbol', user.name
+      assert_equal 'george@cyclim.se', user.email
+    end
 
-  private
+    private
 
-  def fetch_user
-    User.find_or_create_from_github(@github_user)
+    def fetch_user
+      User.find_or_create_from_github(@github_user)
+    end
   end
 end

data/test/unit/command_test.rb

@@ -1,45 +1,47 @@
 require 'test_helper'
 
-class CommandTest < ActiveSupport::TestCase
-  test 'lib/snippets is added to the PATH when command is run' do
-    out = Command.new('which extract-gem-version', chdir: '/tmp').run
-    script_path = Shipit::Engine.root.join('lib', 'snippets', 'extract-gem-version').to_s
-    assert_equal "#{script_path}\r\n", out
-  end
-
-  test "#interpolate_environment_variables replace environment variables by their value" do
-    command = Command.new('cap $ENVIRONMENT deploy', env: {'ENVIRONMENT' => 'production'}, chdir: '.')
-    assert_equal [%(cap production deploy)], command.interpolated_arguments
-  end
-
-  test "#interpolate_environment_variables coerce nil to empty string" do
-    command = Command.new('cap $FOO deploy', env: {'ENVIRONMENT' => 'production'}, chdir: '.')
-    assert_equal [%(cap '' deploy)], command.interpolated_arguments
-  end
-
-  test '#interpolate_environment_variables escape the variable contents' do
-    malicious_string = '$(echo pwnd)'
-    command = Command.new('echo $FOO', env: {'FOO' => malicious_string}, chdir: '.')
-    assert_equal malicious_string, command.run.chomp
-  end
-
-  test "#interpolate_environment_variables fallback to ENV" do
-    command = Command.new('cap $LANG deploy', env: {'ENVIRONMENT' => 'production'}, chdir: '.')
-    assert_equal [%(cap #{ENV['LANG']} deploy)], command.interpolated_arguments
-  end
-
-  test "#timeout is 5 minutes by default" do
-    command = Command.new('cap $LANG deploy', env: {'ENVIRONMENT' => 'production'}, chdir: '.')
-    assert_equal 5.minutes.to_i, command.timeout
-  end
-
-  test "#timeout returns `default_timeout` if present" do
-    command = Command.new('cap $LANG deploy', default_timeout: 5, env: {}, chdir: '.')
-    assert_equal 5, command.timeout
-  end
-
-  test "#timeout returnsthe command option timeout over the `default_timeout` if present" do
-    command = Command.new({'cap $LANG deploy' => {'timeout' => 10}}, default_timeout: 5, env: {}, chdir: '.')
-    assert_equal 10, command.timeout
+module Shipit
+  class CommandTest < ActiveSupport::TestCase
+    test 'lib/snippets is added to the PATH when command is run' do
+      out = Command.new('which extract-gem-version', chdir: '/tmp').run
+      script_path = Shipit::Engine.root.join('lib', 'snippets', 'extract-gem-version').to_s
+      assert_equal "#{script_path}\r\n", out
+    end
+
+    test "#interpolate_environment_variables replace environment variables by their value" do
+      command = Command.new('cap $ENVIRONMENT deploy', env: {'ENVIRONMENT' => 'production'}, chdir: '.')
+      assert_equal [%(cap production deploy)], command.interpolated_arguments
+    end
+
+    test "#interpolate_environment_variables coerce nil to empty string" do
+      command = Command.new('cap $FOO deploy', env: {'ENVIRONMENT' => 'production'}, chdir: '.')
+      assert_equal [%(cap '' deploy)], command.interpolated_arguments
+    end
+
+    test '#interpolate_environment_variables escape the variable contents' do
+      malicious_string = '$(echo pwnd)'
+      command = Command.new('echo $FOO', env: {'FOO' => malicious_string}, chdir: '.')
+      assert_equal malicious_string, command.run.chomp
+    end
+
+    test "#interpolate_environment_variables fallback to ENV" do
+      command = Command.new('cap $LANG deploy', env: {'ENVIRONMENT' => 'production'}, chdir: '.')
+      assert_equal [%(cap #{ENV['LANG']} deploy)], command.interpolated_arguments
+    end
+
+    test "#timeout is 5 minutes by default" do
+      command = Command.new('cap $LANG deploy', env: {'ENVIRONMENT' => 'production'}, chdir: '.')
+      assert_equal 5.minutes.to_i, command.timeout
+    end
+
+    test "#timeout returns `default_timeout` if present" do
+      command = Command.new('cap $LANG deploy', default_timeout: 5, env: {}, chdir: '.')
+      assert_equal 5, command.timeout
+    end
+
+    test "#timeout returnsthe command option timeout over the `default_timeout` if present" do
+      command = Command.new({'cap $LANG deploy' => {'timeout' => 10}}, default_timeout: 5, env: {}, chdir: '.')
+      assert_equal 10, command.timeout
+    end
   end
 end