shipit-engine 0.5.2 → 0.6.0

data/test/controllers/deploys_controller_test.rb

@@ -1,90 +1,92 @@
 require 'test_helper'
 
-class DeploysControllerTest < ActionController::TestCase
-  setup do
-    Deploy.where(status: %w(running pending)).update_all(status: 'success')
-    @stack = stacks(:shipit)
-    @deploy = deploys(:shipit)
-    @commit = commits(:second)
-    session[:user_id] = users(:walrus).id
-  end
+module Shipit
+  class DeploysControllerTest < ActionController::TestCase
+    setup do
+      Deploy.where(status: %w(running pending)).update_all(status: 'success')
+      @stack = shipit_stacks(:shipit)
+      @deploy = shipit_deploys(:shipit)
+      @commit = shipit_commits(:second)
+      session[:user_id] = shipit_users(:walrus).id
+    end
 
-  test ":show is success" do
-    get :show, stack_id: @stack.to_param, id: @deploy.id
-    assert_response :success
-  end
+    test ":show is success" do
+      get :show, stack_id: @stack.to_param, id: @deploy.id
+      assert_response :success
+    end
 
-  test ":new is success" do
-    get :new, stack_id: @stack.to_param, sha: @commit.sha
-    assert_response :success
-  end
+    test ":new is success" do
+      get :new, stack_id: @stack.to_param, sha: @commit.sha
+      assert_response :success
+    end
 
-  test ":new shows a warning if a deploy is already running" do
-    deploys(:shipit_running).update_column(:status, 'running')
+    test ":new shows a warning if a deploy is already running" do
+      shipit_deploys(:shipit_running).update_column(:status, 'running')
 
-    get :new, stack_id: @stack.to_param, sha: @commit.sha
-    assert_response :success
-    assert_select '.warning.concurrent-deploy h2' do |elements|
-      assert_equal 'Lando Walrussian is already deploying!', elements.first.text
+      get :new, stack_id: @stack.to_param, sha: @commit.sha
+      assert_response :success
+      assert_select '.warning.concurrent-deploy h2' do |elements|
+        assert_equal 'Lando Walrussian is already deploying!', elements.first.text
+      end
+      assert_select '#new_deploy #force', 1
     end
-    assert_select '#new_deploy #force', 1
-  end
 
-  test ":create persists a new deploy" do
-    assert_difference '@stack.deploys.count', 1 do
-      post :create, stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id}
+    test ":create persists a new deploy" do
+      assert_difference '@stack.deploys.count', 1 do
+        post :create, stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id}
+      end
     end
-  end
 
-  test ":create can receive an :env hash" do
-    env = {'SAFETY_DISABLED' => '1'}
-    post :create, stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id, env: env}
-    new_deploy = Deploy.last
-    assert_equal env, new_deploy.env
-  end
+    test ":create can receive an :env hash" do
+      env = {'SAFETY_DISABLED' => '1'}
+      post :create, stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id, env: env}
+      new_deploy = Deploy.last
+      assert_equal env, new_deploy.env
+    end
 
-  test ":create ignore :env keys not declared in the deploy spec" do
-    post :create, stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id, env: {'H4X0R' => '1'}}
-    new_deploy = Deploy.last
-    assert_equal({}, new_deploy.env)
-  end
+    test ":create ignore :env keys not declared in the deploy spec" do
+      post :create, stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id, env: {'H4X0R' => '1'}}
+      new_deploy = Deploy.last
+      assert_equal({}, new_deploy.env)
+    end
 
-  test ":create with `force` option ignore the active deploys" do
-    deploys(:shipit_running).update_column(:status, 'running')
+    test ":create with `force` option ignore the active deploys" do
+      shipit_deploys(:shipit_running).update_column(:status, 'running')
 
-    assert_difference '@stack.deploys.count', 1 do
-      post :create, stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id}, force: true
+      assert_difference '@stack.deploys.count', 1 do
+        post :create, stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id}, force: true
+      end
     end
-  end
 
-  test ":create redirect back to :new with a warning if there is an active deploy" do
-    deploys(:shipit_running).update_column(:status, 'running')
+    test ":create redirect back to :new with a warning if there is an active deploy" do
+      shipit_deploys(:shipit_running).update_column(:status, 'running')
 
-    assert_no_difference '@stack.deploys.count' do
-      post :create, stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id}
+      assert_no_difference '@stack.deploys.count' do
+        post :create, stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id}
+      end
+      assert_redirected_to new_stack_deploy_path(@stack, sha: @commit.sha)
     end
-    assert_redirected_to new_stack_deploy_path(@stack, sha: @commit.sha)
-  end
 
-  test ":create redirects to the new deploy" do
-    post :create, stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id}
-    new_deploy = Deploy.last
-    assert_redirected_to stack_deploy_path(@stack, new_deploy)
-  end
+    test ":create redirects to the new deploy" do
+      post :create, stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id}
+      new_deploy = Deploy.last
+      assert_redirected_to stack_deploy_path(@stack, new_deploy)
+    end
 
-  test ":rollback is success" do
-    get :rollback, stack_id: @stack.to_param, id: @deploy.id
-    assert_response :success
-  end
+    test ":rollback is success" do
+      get :rollback, stack_id: @stack.to_param, id: @deploy.id
+      assert_response :success
+    end
 
-  test ":rollback shows a warning if a deploy is already running" do
-    deploys(:shipit_running).update_column(:status, 'running')
+    test ":rollback shows a warning if a deploy is already running" do
+      shipit_deploys(:shipit_running).update_column(:status, 'running')
 
-    get :rollback, stack_id: @stack.to_param, id: @deploy.id
-    assert_response :success
-    assert_select '.warning.concurrent-deploy h2' do |elements|
-      assert_equal 'Lando Walrussian is already deploying!', elements.first.text
+      get :rollback, stack_id: @stack.to_param, id: @deploy.id
+      assert_response :success
+      assert_select '.warning.concurrent-deploy h2' do |elements|
+        assert_equal 'Lando Walrussian is already deploying!', elements.first.text
+      end
+      assert_select '#new_rollback #force', 1
     end
-    assert_select '#new_rollback #force', 1
   end
 end

data/test/controllers/github_authentication_controller_test.rb

@@ -1,12 +1,14 @@
 require 'test_helper'
 
-class GithubAuthenticationControllerTest < ActionController::TestCase
-  test ":callback can sign in to github" do
-    @request.env['omniauth.auth'] = {info: {nickname: 'shipit'}}
-    github_user = mock('Sawyer User')
-    Shipit.github_api.stubs(:user).returns(github_user)
-    User.expects(:find_or_create_from_github).with(github_user).returns(stub(id: 44))
+module Shipit
+  class GithubAuthenticationControllerTest < ActionController::TestCase
+    test ":callback can sign in to github" do
+      @request.env['omniauth.auth'] = {info: {nickname: 'shipit'}}
+      github_user = mock('Sawyer User')
+      Shipit.github_api.stubs(:user).returns(github_user)
+      User.expects(:find_or_create_from_github).with(github_user).returns(stub(id: 44))
 
-    get :callback
+      get :callback
+    end
   end
 end

data/test/controllers/rollbacks_controller_test.rb

@@ -1,55 +1,57 @@
 require 'test_helper'
 
-class RollbacksControllerTest < ActionController::TestCase
-  setup do
-    Deploy.where(status: %w(running pending)).update_all(status: 'success')
-    @stack = stacks(:shipit)
-    @deploy = deploys(:shipit)
-    session[:user_id] = users(:walrus).id
-  end
-
-  test ":create persists a new rollback" do
-    assert_difference '@stack.rollbacks.count', 1 do
-      post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}
+module Shipit
+  class RollbacksControllerTest < ActionController::TestCase
+    setup do
+      Deploy.where(status: %w(running pending)).update_all(status: 'success')
+      @stack = shipit_stacks(:shipit)
+      @deploy = shipit_deploys(:shipit)
+      session[:user_id] = shipit_users(:walrus).id
     end
-  end
 
-  test ":create can receive an :env hash" do
-    env = {'SAFETY_DISABLED' => '1'}
-    post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id, env: env}
-    new_rollback = Rollback.last
-    assert_equal env, new_rollback.env
-  end
+    test ":create persists a new rollback" do
+      assert_difference '@stack.rollbacks.count', 1 do
+        post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}
+      end
+    end
 
-  test ":create ignore :env keys not declared in the deploy spec" do
-    post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id, env: {'H4X0R' => '1'}}
-    new_rollback = Rollback.last
-    assert_equal({}, new_rollback.env)
-  end
+    test ":create can receive an :env hash" do
+      env = {'SAFETY_DISABLED' => '1'}
+      post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id, env: env}
+      new_rollback = Rollback.last
+      assert_equal env, new_rollback.env
+    end
 
-  test ":create redirects to the new deploy" do
-    post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}
-    assert_redirected_to stack_deploy_path(@stack, Rollback.last)
-  end
+    test ":create ignore :env keys not declared in the deploy spec" do
+      post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id, env: {'H4X0R' => '1'}}
+      new_rollback = Rollback.last
+      assert_equal({}, new_rollback.env)
+    end
 
-  test ":create locks deploys" do
-    post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}
-    assert @stack.reload.locked?
-  end
+    test ":create redirects to the new deploy" do
+      post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}
+      assert_redirected_to stack_deploy_path(@stack, Rollback.last)
+    end
 
-  test ":create redirects back to the :new page if there is an active deploy" do
-    deploys(:shipit_running).update_column(:status, 'running')
-    assert_no_difference '@stack.deploys.count' do
+    test ":create locks deploys" do
       post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}
+      assert @stack.reload.locked?
+    end
+
+    test ":create redirects back to the :new page if there is an active deploy" do
+      shipit_deploys(:shipit_running).update_column(:status, 'running')
+      assert_no_difference '@stack.deploys.count' do
+        post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}
+      end
+      assert_redirected_to rollback_stack_deploy_path(@stack, @deploy)
     end
-    assert_redirected_to rollback_stack_deploy_path(@stack, @deploy)
-  end
 
-  test ":create with `force` option ignore the active deploys" do
-    deploys(:shipit_running).update_column(:status, 'running')
-    assert_difference '@stack.deploys.count', 1 do
-      post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}, force: true
+    test ":create with `force` option ignore the active deploys" do
+      shipit_deploys(:shipit_running).update_column(:status, 'running')
+      assert_difference '@stack.deploys.count', 1 do
+        post :create, stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}, force: true
+      end
+      assert_redirected_to stack_deploy_path(@stack, Rollback.last)
     end
-    assert_redirected_to stack_deploy_path(@stack, Rollback.last)
   end
 end

data/test/controllers/stacks_controller_test.rb

@@ -1,164 +1,167 @@
 require 'test_helper'
 
-class StacksControllerTest < ActionController::TestCase
-  setup do
-    @stack = stacks(:shipit)
-    session[:user_id] = users(:walrus).id
-  end
+module Shipit
+  class StacksControllerTest < ActionController::TestCase
+    setup do
+      @routes = Shipit::Engine.routes
+      @stack = shipit_stacks(:shipit)
+      session[:user_id] = shipit_users(:walrus).id
+    end
 
-  test "validates that Shipit.github_oauth_id is present" do
-    Shipit.stubs(github_oauth_credentials: {'secret' => 'abc'})
-    get :index
-    assert_template 'missing_settings'
-    assert_select "#github_oauth_id .missing"
-    assert_select ".missing", count: 1
-  end
+    test "validates that Shipit.github_oauth_id is present" do
+      Shipit.stubs(github_oauth_credentials: {'secret' => 'abc'})
+      get :index
+      assert_template 'missing_settings'
+      assert_select "#github_oauth_id .missing"
+      assert_select ".missing", count: 1
+    end
 
-  test "validates that Shipit.github_oauth_secret is present" do
-    Shipit.stubs(github_oauth_credentials: {'id' => 'abc'})
-    get :index
-    assert_template 'missing_settings'
-    assert_select "#github_oauth_secret .missing"
-    assert_select ".missing", count: 1
-  end
+    test "validates that Shipit.github_oauth_secret is present" do
+      Shipit.stubs(github_oauth_credentials: {'id' => 'abc'})
+      get :index
+      assert_template 'missing_settings'
+      assert_select "#github_oauth_secret .missing"
+      assert_select ".missing", count: 1
+    end
 
-  test "validates that Shipit.github_api_credentials is present" do
-    Shipit.stubs(github_api_credentials: {})
-    get :index
-    assert_template 'missing_settings'
-    assert_select "#github_api .missing"
-    assert_select ".missing", count: 1
-  end
+    test "validates that Shipit.github_api_credentials is present" do
+      Shipit.stubs(github_api_credentials: {})
+      get :index
+      assert_template 'missing_settings'
+      assert_select "#github_api .missing"
+      assert_select ".missing", count: 1
+    end
 
-  test "validates that Shipit.redis_url is present" do
-    Shipit.stubs(redis_url: nil)
-    get :index
-    assert_template 'missing_settings'
-    assert_select "#redis_url .missing"
-    assert_select ".missing", count: 1
-  end
+    test "validates that Shipit.redis_url is present" do
+      Shipit.stubs(redis_url: nil)
+      get :index
+      assert_template 'missing_settings'
+      assert_select "#redis_url .missing"
+      assert_select ".missing", count: 1
+    end
 
-  test "validates that Shipit.host is present" do
-    Shipit.stubs(host: nil)
-    get :index
-    assert_template 'missing_settings'
-    assert_select "#host .missing"
-    assert_select ".missing", count: 1
-  end
+    test "validates that Shipit.host is present" do
+      Shipit.stubs(host: nil)
+      get :index
+      assert_template 'missing_settings'
+      assert_select "#host .missing"
+      assert_select ".missing", count: 1
+    end
 
-  test "GitHub authentication is mandatory" do
-    session[:user_id] = nil
-    get :index
-    assert_redirected_to '/github/auth/github?origin=http%3A%2F%2Ftest.host%2F'
-  end
+    test "GitHub authentication is mandatory" do
+      session[:user_id] = nil
+      get :index
+      assert_redirected_to '/github/auth/github?origin=http%3A%2F%2Ftest.host%2F'
+    end
 
-  test "current_user must be a member of Shipit.github_team" do
-    Shipit.stubs(:github_team).returns(teams(:cyclimse_cooks))
-    get :index
-    assert_response :forbidden
-    assert_equal 'You must be a member of cyclimse/cooks to access this application.', response.body
-  end
+    test "current_user must be a member of Shipit.github_team" do
+      Shipit.stubs(:github_team).returns(shipit_teams(:cyclimse_cooks))
+      get :index
+      assert_response :forbidden
+      assert_equal 'You must be a member of cyclimse/cooks to access this application.', response.body
+    end
 
-  test "#show is success" do
-    get :show, id: @stack.to_param
-    assert_response :ok
-  end
+    test "#show is success" do
+      get :show, id: @stack.to_param
+      assert_response :ok
+    end
 
-  test "#show handles locked stacks without a lock_author" do
-    @stack.update!(lock_reason: "I am a lock with no author")
-    get :show, id: @stack.to_param
-  end
+    test "#show handles locked stacks without a lock_author" do
+      @stack.update!(lock_reason: "I am a lock with no author")
+      get :show, id: @stack.to_param
+    end
 
-  test "#show auto-links URLs in lock reason" do
-    @stack.update!(lock_reason: 'http://google.com')
-    get :show, id: @stack.to_param
-    assert_response :ok
-    assert_select 'a[href="http://google.com"]'
-  end
+    test "#show auto-links URLs in lock reason" do
+      @stack.update!(lock_reason: 'http://google.com')
+      get :show, id: @stack.to_param
+      assert_response :ok
+      assert_select 'a[href="http://google.com"]'
+    end
 
-  test "#create creates a Stack, queues a job to setup webhooks and redirects to it" do
-    params = {}
-    params[:stack] = {
-      repo_name: "rails",
-      repo_owner: "rails",
-      environment: "staging",
-      branch: "staging",
-    }
+    test "#create creates a Stack, queues a job to setup webhooks and redirects to it" do
+      params = {}
+      params[:stack] = {
+        repo_name: "rails",
+        repo_owner: "rails",
+        environment: "staging",
+        branch: "staging",
+      }
+
+      assert_difference "Stack.count" do
+        post :create, params
+      end
 
-    assert_difference "Stack.count" do
-      post :create, params
+      assert_redirected_to stack_path(Stack.last)
     end
 
-    assert_redirected_to stack_path(Stack.last)
-  end
+    test "#create when not valid renders new" do
+      assert_no_difference "Stack.count" do
+        post :create, stack: {repo_owner: 'some', repo_name: 'owner/path'}
+      end
 
-  test "#create when not valid renders new" do
-    assert_no_difference "Stack.count" do
-      post :create, stack: {repo_owner: 'some', repo_name: 'owner/path'}
+      assert_template :new
     end
 
-    assert_template :new
-  end
-
-  test "#destroy enqueues a DestroyStackJob" do
-    assert_enqueued_with(job: DestroyStackJob, args: [@stack]) do
-      delete :destroy, id: @stack.to_param
+    test "#destroy enqueues a DestroyStackJob" do
+      assert_enqueued_with(job: DestroyStackJob, args: [@stack]) do
+        delete :destroy, id: @stack.to_param
+      end
+      assert_redirected_to stacks_path
     end
-    assert_redirected_to stacks_path
-  end
 
-  test "#settings is success" do
-    get :settings, id: @stack.to_param
-    assert_response :success
-  end
+    test "#settings is success" do
+      get :settings, id: @stack.to_param
+      assert_response :success
+    end
 
-  test "#update allows to lock the stack" do
-    refute @stack.locked?
+    test "#update allows to lock the stack" do
+      refute @stack.locked?
 
-    patch :update, id: @stack.to_param, stack: {lock_reason: 'Went out to eat some chips!'}
-    @stack.reload
-    assert @stack.locked?
-    assert_equal users(:walrus), @stack.lock_author
-  end
+      patch :update, id: @stack.to_param, stack: {lock_reason: 'Went out to eat some chips!'}
+      @stack.reload
+      assert @stack.locked?
+      assert_equal shipit_users(:walrus), @stack.lock_author
+    end
 
-  test "#update allows to unlock the stack" do
-    @stack.update!(lock_reason: 'Went out to eat some chips!')
-    assert @stack.locked?
+    test "#update allows to unlock the stack" do
+      @stack.update!(lock_reason: 'Went out to eat some chips!')
+      assert @stack.locked?
 
-    patch :update, id: @stack.to_param, stack: {lock_reason: ''}
-    @stack.reload
-    refute @stack.locked?
-    assert_instance_of AnonymousUser, @stack.lock_author
-  end
+      patch :update, id: @stack.to_param, stack: {lock_reason: ''}
+      @stack.reload
+      refute @stack.locked?
+      assert_instance_of AnonymousUser, @stack.lock_author
+    end
 
-  test "#refresh queues a RefreshStatusesJob and a GithubSyncJob" do
-    request.env['HTTP_REFERER'] = stack_settings_path(@stack)
+    test "#refresh queues a RefreshStatusesJob and a GithubSyncJob" do
+      request.env['HTTP_REFERER'] = stack_settings_path(@stack)
 
-    assert_enqueued_with(job: RefreshStatusesJob, args: [stack_id: @stack.id]) do
-      assert_enqueued_with(job: GithubSyncJob, args: [stack_id: @stack.id]) do
-        post :refresh, id: @stack.to_param
+      assert_enqueued_with(job: RefreshStatusesJob, args: [stack_id: @stack.id]) do
+        assert_enqueued_with(job: GithubSyncJob, args: [stack_id: @stack.id]) do
+          post :refresh, id: @stack.to_param
+        end
       end
-    end
 
-    assert_redirected_to stack_settings_path(@stack)
-  end
+      assert_redirected_to stack_settings_path(@stack)
+    end
 
-  test "#sync_webhooks queues #{Stack::REQUIRED_HOOKS.count} SetupGithubHookJob" do
-    assert_enqueued_jobs(Stack::REQUIRED_HOOKS.count) do
-      post :sync_webhooks, id: @stack.to_param
+    test "#sync_webhooks queues #{Stack::REQUIRED_HOOKS.count} SetupGithubHookJob" do
+      assert_enqueued_jobs(Stack::REQUIRED_HOOKS.count) do
+        post :sync_webhooks, id: @stack.to_param
+      end
+      assert_redirected_to stack_settings_path(@stack)
     end
-    assert_redirected_to stack_settings_path(@stack)
-  end
 
-  test "#clear_git_cache queues a ClearGitCacheJob" do
-    assert_enqueued_with(job: ClearGitCacheJob, args: [@stack]) do
-      post :clear_git_cache, id: @stack.to_param
+    test "#clear_git_cache queues a ClearGitCacheJob" do
+      assert_enqueued_with(job: ClearGitCacheJob, args: [@stack]) do
+        post :clear_git_cache, id: @stack.to_param
+      end
+      assert_redirected_to stack_settings_path(@stack)
     end
-    assert_redirected_to stack_settings_path(@stack)
-  end
 
-  test "#update redirects to return_to parameter" do
-    patch :update, id: @stack.to_param, stack: {ignore_ci: false}, return_to: stack_path(@stack)
-    assert_redirected_to stack_path(@stack)
+    test "#update redirects to return_to parameter" do
+      patch :update, id: @stack.to_param, stack: {ignore_ci: false}, return_to: stack_path(@stack)
+      assert_redirected_to stack_path(@stack)
+    end
   end
 end