shipit-engine 0.5.2 → 0.6.0

data/test/controllers/status_controller_test.rb

@@ -1,10 +1,12 @@
 require 'test_helper'
 
-class StatusControllerTest < ActionController::TestCase
-  test ":version returns Shipit.revision" do
-    Shipit.expects(:revision).returns('foo')
-    get :version
-    assert_response :success
-    assert_equal 'foo', response.body
+module Shipit
+  class StatusControllerTest < ActionController::TestCase
+    test ":version returns Shipit.revision" do
+      Shipit.expects(:revision).returns('foo')
+      get :version
+      assert_response :success
+      assert_equal 'foo', response.body
+    end
   end
 end

data/test/controllers/tasks_controller_test.rb

@@ -1,88 +1,90 @@
 require 'test_helper'
 
-class TasksControllerTest < ActionController::TestCase
-  setup do
-    @stack = stacks(:shipit)
-    @definition = @stack.find_task_definition('restart')
-    @task = tasks(:shipit_restart)
-    @commit = commits(:second)
-    session[:user_id] = users(:walrus).id
-  end
+module Shipit
+  class TasksControllerTest < ActionController::TestCase
+    setup do
+      @stack = shipit_stacks(:shipit)
+      @definition = @stack.find_task_definition('restart')
+      @task = shipit_tasks(:shipit_restart)
+      @commit = shipit_commits(:second)
+      session[:user_id] = shipit_users(:walrus).id
+    end
 
-  test "tasks defined in the shipit.yml can be displayed" do
-    get :new, stack_id: @stack, definition_id: @definition.id
-    assert_response :ok
-  end
+    test "tasks defined in the shipit.yml can be displayed" do
+      get :new, stack_id: @stack, definition_id: @definition.id
+      assert_response :ok
+    end
 
-  test "tasks defined in the shipit.yml can be triggered" do
-    assert_difference '@stack.tasks.count', 1 do
-      post :create, stack_id: @stack, definition_id: @definition.id
+    test "tasks defined in the shipit.yml can be triggered" do
+      assert_difference '@stack.tasks.count', 1 do
+        post :create, stack_id: @stack, definition_id: @definition.id
+      end
+      assert_redirected_to stack_task_path(@stack, Task.last)
     end
-    assert_redirected_to stack_task_path(@stack, Task.last)
-  end
 
-  test "triggered tasks can be observed" do
-    get :show, stack_id: @stack, id: @task.id
-    assert_response :ok
-  end
+    test "triggered tasks can be observed" do
+      get :show, stack_id: @stack, id: @task.id
+      assert_response :ok
+    end
 
-  test ":abort call abort! on the deploy" do
-    @task = deploys(:shipit_running)
-    @task.pid = 42
-    post :abort, stack_id: @stack.to_param, id: @task.id
+    test ":abort call abort! on the deploy" do
+      @task = shipit_deploys(:shipit_running)
+      @task.pid = 42
+      post :abort, stack_id: @stack.to_param, id: @task.id
 
-    @task.reload
-    assert_response :success
-    assert_equal 'aborting', @task.reload.status
-    assert_equal false, @task.rollback_once_aborted?
-  end
+      @task.reload
+      assert_response :success
+      assert_equal 'aborting', @task.reload.status
+      assert_equal false, @task.rollback_once_aborted?
+    end
 
-  test ":abort schedule the rollback if `rollback` is present" do
-    @task = deploys(:shipit_running)
-    @task.pid = 42
-    post :abort, stack_id: @stack.to_param, id: @task.id, rollback: 'true'
+    test ":abort schedule the rollback if `rollback` is present" do
+      @task = shipit_deploys(:shipit_running)
+      @task.pid = 42
+      post :abort, stack_id: @stack.to_param, id: @task.id, rollback: 'true'
 
-    @task.reload
-    assert_response :success
-    assert_equal 'aborting', @task.status
-    assert_equal true, @task.rollback_once_aborted?
-  end
+      @task.reload
+      assert_response :success
+      assert_equal 'aborting', @task.status
+      assert_equal true, @task.rollback_once_aborted?
+    end
 
-  test ":index list the stack deploys" do
-    get :index, stack_id: @stack.to_param
-    assert_response :success
-    assert_select '.task-list .task', @stack.tasks.count
-  end
+    test ":index list the stack deploys" do
+      get :index, stack_id: @stack.to_param
+      assert_response :success
+      assert_select '.task-list .task', @stack.tasks.count
+    end
 
-  test ":index paginates with the `since` parameter" do
-    get :index, stack_id: @stack.to_param, since: @stack.tasks.last.id
-    assert_response :success
-    assert_select '.task-list .task', @stack.tasks.count - 1
-  end
+    test ":index paginates with the `since` parameter" do
+      get :index, stack_id: @stack.to_param, since: @stack.tasks.last.id
+      assert_response :success
+      assert_select '.task-list .task', @stack.tasks.count - 1
+    end
 
-  test ":tail returns the task status, output, and next url" do
-    @task = deploys(:shipit_running)
-    last_chunk = @task.chunks.last
+    test ":tail returns the task status, output, and next url" do
+      @task = shipit_deploys(:shipit_running)
+      last_chunk = @task.chunks.last
 
-    get :tail, stack_id: @stack.to_param, id: @task.id, last_id: last_chunk.id, format: :json
-    assert_response :success
-    assert_json_keys %w(url status output)
-    assert_json 'status', @task.status
-  end
+      get :tail, stack_id: @stack.to_param, id: @task.id, last_id: last_chunk.id, format: :json
+      assert_response :success
+      assert_json_keys %w(url status output)
+      assert_json 'status', @task.status
+    end
 
-  test ":tail doesn't returns the next url if the task is finished" do
-    @task = deploys(:shipit)
+    test ":tail doesn't returns the next url if the task is finished" do
+      @task = shipit_deploys(:shipit)
 
-    get :tail, stack_id: @stack.to_param, id: @task.id, format: :json
-    assert_response :success
-    assert_no_json 'url'
-  end
+      get :tail, stack_id: @stack.to_param, id: @task.id, format: :json
+      assert_response :success
+      assert_no_json 'url'
+    end
 
-  test ":tail returns the rollback url if the task have been aborted" do
-    @task = deploys(:shipit_aborted)
+    test ":tail returns the rollback url if the task have been aborted" do
+      @task = shipit_deploys(:shipit_aborted)
 
-    get :tail, stack_id: @stack.to_param, id: @task.id, format: :json
-    assert_response :success
-    assert_json_keys %w(status output rollback_url)
+      get :tail, stack_id: @stack.to_param, id: @task.id, format: :json
+      assert_response :success
+      assert_json_keys %w(status output rollback_url)
+    end
   end
 end

data/test/controllers/webhooks_controller_test.rb

@@ -1,176 +1,178 @@
 require 'test_helper'
 
-class WebhooksControllerTest < ActionController::TestCase
-  setup do
-    @stack = stacks(:shipit)
-    GithubHook.any_instance.stubs(:verify_signature).returns(true)
-  end
+module Shipit
+  class WebhooksControllerTest < ActionController::TestCase
+    setup do
+      @stack = shipit_stacks(:shipit)
+      GithubHook.any_instance.stubs(:verify_signature).returns(true)
+    end
 
-  test ":push with the target branch queues a GithubSyncJob" do
-    request.headers['X-Github-Event'] = 'push'
-    params = payload(:push_master)
+    test ":push with the target branch queues a GithubSyncJob" do
+      request.headers['X-Github-Event'] = 'push'
+      params = payload(:push_master)
 
-    assert_enqueued_with(job: GithubSyncJob, args: [stack_id: @stack.id]) do
-      post :push, {stack_id: @stack.id}.merge(params)
+      assert_enqueued_with(job: GithubSyncJob, args: [stack_id: @stack.id]) do
+        post :push, {stack_id: @stack.id}.merge(params)
+      end
     end
-  end
 
-  test ":push with the target branch queues a GitMirrorUpdateJob" do
-    request.headers['X-Github-Event'] = 'push'
-    params = payload(:push_master)
+    test ":push with the target branch queues a GitMirrorUpdateJob" do
+      request.headers['X-Github-Event'] = 'push'
+      params = payload(:push_master)
 
-    assert_enqueued_with(job: GitMirrorUpdateJob, args: [@stack]) do
-      post :push, {stack_id: @stack.id}.merge(params)
+      assert_enqueued_with(job: GitMirrorUpdateJob, args: [@stack]) do
+        post :push, {stack_id: @stack.id}.merge(params)
+      end
     end
-  end
 
-  test ":push does not enqueue a job if not the target branch" do
-    request.headers['X-Github-Event'] = 'push'
-    params = payload(:push_not_master)
-    assert_no_enqueued_jobs do
-      post :push, {stack_id: @stack.id}.merge(params)
+    test ":push does not enqueue a job if not the target branch" do
+      request.headers['X-Github-Event'] = 'push'
+      params = payload(:push_not_master)
+      assert_no_enqueued_jobs do
+        post :push, {stack_id: @stack.id}.merge(params)
+      end
     end
-  end
 
-  test ":state create a Status for the specific commit" do
-    request.headers['X-Github-Event'] = 'status'
+    test ":state create a Status for the specific commit" do
+      request.headers['X-Github-Event'] = 'status'
+
+      status_payload = payload(:status_master)
+      commit = shipit_commits(:first)
 
-    status_payload = payload(:status_master)
-    commit = commits(:first)
+      assert_difference 'commit.statuses.count', 1 do
+        post :state, {stack_id: @stack.id}.merge(status_payload)
+      end
 
-    assert_difference 'commit.statuses.count', 1 do
-      post :state, {stack_id: @stack.id}.merge(status_payload)
+      status = commit.statuses.last
+      assert_equal status_payload['target_url'], status.target_url
+      assert_equal status_payload['state'], status.state
+      assert_equal status_payload['description'], status.description
+      assert_equal status_payload['context'], status.context
+      assert_equal status_payload['created_at'], status.created_at.iso8601
     end
 
-    status = commit.statuses.last
-    assert_equal status_payload['target_url'], status.target_url
-    assert_equal status_payload['state'], status.state
-    assert_equal status_payload['description'], status.description
-    assert_equal status_payload['context'], status.context
-    assert_equal status_payload['created_at'], status.created_at.iso8601
-  end
+    test ":state with a unexisting commit trows ActiveRecord::RecordNotFound" do
+      request.headers['X-Github-Event'] = 'status'
+      params = {'sha' => 'notarealcommit', 'state' => 'pending', 'branches' => [{'name' => 'master'}]}
+      assert_raises ActiveRecord::RecordNotFound do
+        post :state, {stack_id: @stack.id}.merge(params)
+      end
+    end
 
-  test ":state with a unexisting commit trows ActiveRecord::RecordNotFound" do
-    request.headers['X-Github-Event'] = 'status'
-    params = {'sha' => 'notarealcommit', 'state' => 'pending', 'branches' => [{'name' => 'master'}]}
-    assert_raises ActiveRecord::RecordNotFound do
+    test ":state in an untracked branche bails out" do
+      request.headers['X-Github-Event'] = 'status'
+      params = {'sha' => 'notarealcommit', 'state' => 'pending', 'branches' => []}
       post :state, {stack_id: @stack.id}.merge(params)
+      assert_response :ok
     end
-  end
 
-  test ":state in an untracked branche bails out" do
-    request.headers['X-Github-Event'] = 'status'
-    params = {'sha' => 'notarealcommit', 'state' => 'pending', 'branches' => []}
-    post :state, {stack_id: @stack.id}.merge(params)
-    assert_response :ok
-  end
+    test ":push returns head :ok if request is ping" do
+      @request.headers['X-Github-Event'] = 'ping'
 
-  test ":push returns head :ok if request is ping" do
-    @request.headers['X-Github-Event'] = 'ping'
-
-    assert_no_enqueued_jobs do
-      post :state, stack_id: @stack.id, zen: "Git is beautiful"
-      assert_response :ok
+      assert_no_enqueued_jobs do
+        post :state, stack_id: @stack.id, zen: "Git is beautiful"
+        assert_response :ok
+      end
     end
-  end
 
-  test ":state returns head :ok if request is ping" do
-    @request.headers['X-Github-Event'] = 'ping'
+    test ":state returns head :ok if request is ping" do
+      @request.headers['X-Github-Event'] = 'ping'
 
-    assert_no_enqueued_jobs do
-      post :state, stack_id: @stack.id
-      assert_response :ok
+      assert_no_enqueued_jobs do
+        post :state, stack_id: @stack.id
+        assert_response :ok
+      end
     end
-  end
 
-  test ":state verifies webhook signature" do
-    commit = commits(:first)
+    test ":state verifies webhook signature" do
+      commit = shipit_commits(:first)
 
-    params = {"sha" => commit.sha, "state" => "pending", "target_url" => "https://ci.example.com/1000/output"}
-    signature = 'sha1=4848deb1c9642cd938e8caa578d201ca359a8249'
+      params = {"sha" => commit.sha, "state" => "pending", "target_url" => "https://ci.example.com/1000/output"}
+      signature = 'sha1=4848deb1c9642cd938e8caa578d201ca359a8249'
 
-    @request.headers['X-Github-Event'] = 'push'
-    @request.headers['X-Hub-Signature'] = signature
+      @request.headers['X-Github-Event'] = 'push'
+      @request.headers['X-Hub-Signature'] = signature
 
-    GithubHook.any_instance.expects(:verify_signature).with(signature, URI.encode_www_form(params)).returns(false)
+      GithubHook.any_instance.expects(:verify_signature).with(signature, URI.encode_www_form(params)).returns(false)
 
-    post :push, {stack_id: @stack.id}.merge(params)
-    assert_response :unprocessable_entity
-  end
+      post :push, {stack_id: @stack.id}.merge(params)
+      assert_response :unprocessable_entity
+    end
 
-  test ":push verifies webhook signature" do
-    params = {"ref" => "refs/heads/master"}
-    signature = 'sha1=ad1d939e9acd6bdc2415a2dd5951be0f2a796ce0'
+    test ":push verifies webhook signature" do
+      params = {"ref" => "refs/heads/master"}
+      signature = 'sha1=ad1d939e9acd6bdc2415a2dd5951be0f2a796ce0'
 
-    @request.headers['X-Github-Event'] = 'push'
-    @request.headers['X-Hub-Signature'] = signature
+      @request.headers['X-Github-Event'] = 'push'
+      @request.headers['X-Hub-Signature'] = signature
 
-    GithubHook.any_instance.expects(:verify_signature).with(signature, URI.encode_www_form(params)).returns(false)
+      GithubHook.any_instance.expects(:verify_signature).with(signature, URI.encode_www_form(params)).returns(false)
 
-    post :push, {stack_id: @stack.id}.merge(params)
-    assert_response :unprocessable_entity
-  end
+      post :push, {stack_id: @stack.id}.merge(params)
+      assert_response :unprocessable_entity
+    end
 
-  test ":membership creates the mentioned team on the fly" do
-    assert_difference -> { Team.count }, 1 do
-      post :membership, membership_params.merge(team: {
-        id: 48,
-        name: 'Ouiche Cooks',
-        slug: 'ouiche-cooks',
-        url: 'https://example.com',
-      })
-      assert_response :ok
+    test ":membership creates the mentioned team on the fly" do
+      assert_difference -> { Team.count }, 1 do
+        post :membership, membership_params.merge(team: {
+          id: 48,
+          name: 'Ouiche Cooks',
+          slug: 'ouiche-cooks',
+          url: 'https://example.com',
+        })
+        assert_response :ok
+      end
     end
-  end
 
-  test ":membership creates the mentioned user on the fly" do
-    Shipit.github_api.expects(:user).with('george').returns(george)
-    assert_difference -> { User.count }, 1 do
-      post :membership, membership_params.merge(member: {login: 'george'})
-      assert_response :ok
+    test ":membership creates the mentioned user on the fly" do
+      Shipit.github_api.expects(:user).with('george').returns(george)
+      assert_difference -> { User.count }, 1 do
+        post :membership, membership_params.merge(member: {login: 'george'})
+        assert_response :ok
+      end
     end
-  end
 
-  test ":membership can delete an user membership" do
-    assert_difference -> { Membership.count }, -1 do
-      post :membership, membership_params.merge(_action: 'removed')
-      assert_response :ok
+    test ":membership can delete an user membership" do
+      assert_difference -> { Membership.count }, -1 do
+        post :membership, membership_params.merge(_action: 'removed')
+        assert_response :ok
+      end
     end
-  end
 
-  test ":membership can append an user membership" do
-    assert_difference -> { Membership.count }, 1 do
-      post :membership, membership_params.merge(member: {login: 'bob'})
-      assert_response :ok
+    test ":membership can append an user membership" do
+      assert_difference -> { Membership.count }, 1 do
+        post :membership, membership_params.merge(member: {login: 'bob'})
+        assert_response :ok
+      end
     end
-  end
 
-  test ":membership can append an user twice" do
-    assert_no_difference -> { Membership.count } do
-      post :membership, membership_params
-      assert_response :ok
+    test ":membership can append an user twice" do
+      assert_no_difference -> { Membership.count } do
+        post :membership, membership_params
+        assert_response :ok
+      end
     end
-  end
 
-  test ":membership can delete an user twice" do
-    assert_no_difference -> { Membership.count } do
-      post :membership, membership_params.merge(_action: 'removed', member: {login: 'bob'})
-      assert_response :ok
+    test ":membership can delete an user twice" do
+      assert_no_difference -> { Membership.count } do
+        post :membership, membership_params.merge(_action: 'removed', member: {login: 'bob'})
+        assert_response :ok
+      end
     end
-  end
 
-  private
+    private
 
-  def membership_params
-    {_action: 'added', team: team_params, organization: {login: 'shopify'}, member: {login: 'walrus'}}
-  end
+    def membership_params
+      {_action: 'added', team: team_params, organization: {login: 'shopify'}, member: {login: 'walrus'}}
+    end
 
-  def team_params
-    {id: teams(:shopify_developers).id, slug: 'developers', name: 'Developers', url: 'http://example.com'}
-  end
+    def team_params
+      {id: shipit_teams(:shopify_developers).id, slug: 'developers', name: 'Developers', url: 'http://example.com'}
+    end
 
-  def george
-    rels = {self: stub(href: 'https://api.github.com/user/george')}
-    stub(id: 42, name: 'George Abitbol', login: 'george', email: 'george@cyclim.se', rels: rels)
+    def george
+      rels = {self: stub(href: 'https://api.github.com/user/george')}
+      stub(id: 42, name: 'George Abitbol', login: 'george', email: 'george@cyclim.se', rels: rels)
+    end
   end
 end