shipit-engine 0.5.2 → 0.6.0

data/test/controllers/api/hooks_controller_test.rb

@@ -1,74 +1,78 @@
 require 'test_helper'
 
-class Api::HooksControllerTest < ActionController::TestCase
-  setup do
-    authenticate!
-    @stack = stacks(:shipit)
-  end
+module Shipit
+  module Api
+    class HooksControllerTest < ActionController::TestCase
+      setup do
+        authenticate!
+        @stack = shipit_stacks(:shipit)
+      end
 
-  test "#index without a stack_id returns the list of global hooks" do
-    hook = Hook.global.first
+      test "#index without a stack_id returns the list of global hooks" do
+        hook = Hook.global.first
 
-    get :index
-    assert_response :ok
-    assert_json '0.id', hook.id
-    assert_json '0.url', hook.url
-    assert_json '0.content_type', hook.content_type
-    assert_no_json '0.stack'
-  end
+        get :index
+        assert_response :ok
+        assert_json '0.id', hook.id
+        assert_json '0.url', hook.url
+        assert_json '0.content_type', hook.content_type
+        assert_no_json '0.stack'
+      end
 
-  test "#index with a stack_id returns the list of scoped hooks" do
-    hook = Hook.scoped_to(@stack).first
+      test "#index with a stack_id returns the list of scoped hooks" do
+        hook = Hook.scoped_to(@stack).first
 
-    get :index, stack_id: @stack.to_param
-    assert_response :ok
-    assert_json '0.id', hook.id
-    assert_json '0.url', hook.url
-    assert_json '0.content_type', hook.content_type
-    assert_json '0.stack.id', @stack.id
-  end
+        get :index, stack_id: @stack.to_param
+        assert_response :ok
+        assert_json '0.id', hook.id
+        assert_json '0.url', hook.url
+        assert_json '0.content_type', hook.content_type
+        assert_json '0.stack.id', @stack.id
+      end
 
-  test "#show returns the hooks" do
-    hook = Hook.scoped_to(@stack).first
+      test "#show returns the hooks" do
+        hook = Hook.scoped_to(@stack).first
 
-    get :show, stack_id: @stack.to_param, id: hook.id
-    assert_response :ok
+        get :show, stack_id: @stack.to_param, id: hook.id
+        assert_response :ok
 
-    assert_json 'id', hook.id
-    assert_json 'url', hook.url
-    assert_json 'content_type', hook.content_type
-    assert_json 'stack.id', @stack.id
-  end
+        assert_json 'id', hook.id
+        assert_json 'url', hook.url
+        assert_json 'content_type', hook.content_type
+        assert_json 'stack.id', @stack.id
+      end
 
-  test "#create adds a new hook" do
-    assert_difference -> { Hook.count }, 1 do
-      post :create, url: 'https://example.com/hook', events: %w(deploy rollback)
-    end
-    assert_json 'url', 'https://example.com/hook'
-    assert_json 'id', Hook.last.id
-  end
+      test "#create adds a new hook" do
+        assert_difference -> { Hook.count }, 1 do
+          post :create, url: 'https://example.com/hook', events: %w(deploy rollback)
+        end
+        assert_json 'url', 'https://example.com/hook'
+        assert_json 'id', Hook.last.id
+      end
 
-  test "#create do not allow to set protected attributes" do
-    post :create, url: 'https://example.com/hook', events: %w(deploy rollback), created_at: 2.months.ago.to_s(:db)
-    Hook.last.created_at > 2.seconds.ago
-  end
+      test "#create do not allow to set protected attributes" do
+        post :create, url: 'https://example.com/hook', events: %w(deploy rollback), created_at: 2.months.ago.to_s(:db)
+        Hook.last.created_at > 2.seconds.ago
+      end
 
-  test "#create returns validation errors" do
-    post :create, url: '../etc/passwd', events: %w(deploy)
-    assert_response :unprocessable_entity
-    assert_json 'errors', 'url' => ['is not a valid URL']
-  end
+      test "#create returns validation errors" do
+        post :create, url: '../etc/passwd', events: %w(deploy)
+        assert_response :unprocessable_entity
+        assert_json 'errors', 'url' => ['is not a valid URL']
+      end
 
-  test "#update changes an existing hook" do
-    hook = Hook.global.first
-    patch :update, id: hook.id, url: 'https://shipit.com/'
-    assert_response :ok
-    assert_json 'url', 'https://shipit.com/'
-  end
+      test "#update changes an existing hook" do
+        hook = Hook.global.first
+        patch :update, id: hook.id, url: 'https://shipit.com/'
+        assert_response :ok
+        assert_json 'url', 'https://shipit.com/'
+      end
 
-  test "#destroy removes an existing hook" do
-    hook = Hook.global.first
-    delete :destroy, id: hook.id
-    assert_response :no_content
+      test "#destroy removes an existing hook" do
+        hook = Hook.global.first
+        delete :destroy, id: hook.id
+        assert_response :no_content
+      end
+    end
   end
 end

data/test/controllers/api/locks_controller_test.rb

@@ -1,43 +1,47 @@
 require 'test_helper'
 
-class Api::LocksControllerTest < ActionController::TestCase
-  setup do
-    authenticate!
-    @stack = stacks(:shipit)
-  end
+module Shipit
+  module Api
+    class LocksControllerTest < ActionController::TestCase
+      setup do
+        authenticate!
+        @stack = shipit_stacks(:shipit)
+      end
 
-  test "#create sets a lock" do
-    post :create, stack_id: @stack.to_param, reason: 'Just for fun!'
-    assert_response :ok
-    assert_json 'is_locked', true
-    assert_json 'lock_reason', 'Just for fun!'
-  end
+      test "#create sets a lock" do
+        post :create, stack_id: @stack.to_param, reason: 'Just for fun!'
+        assert_response :ok
+        assert_json 'is_locked', true
+        assert_json 'lock_reason', 'Just for fun!'
+      end
 
-  test "#create fails if already locked" do
-    @stack.update!(lock_reason: "Don't forget me")
-    post :create, stack_id: @stack.to_param, reason: 'Just for fun!'
-    assert_response :conflict
-  end
+      test "#create fails if already locked" do
+        @stack.update!(lock_reason: "Don't forget me")
+        post :create, stack_id: @stack.to_param, reason: 'Just for fun!'
+        assert_response :conflict
+      end
 
-  test "#update sets a lock" do
-    put :update, stack_id: @stack.to_param, reason: 'Just for fun!'
-    assert_response :ok
-    assert_json 'is_locked', true
-    assert_json 'lock_reason', 'Just for fun!'
-  end
+      test "#update sets a lock" do
+        put :update, stack_id: @stack.to_param, reason: 'Just for fun!'
+        assert_response :ok
+        assert_json 'is_locked', true
+        assert_json 'lock_reason', 'Just for fun!'
+      end
 
-  test "#update can override a previous lock" do
-    @stack.update!(lock_reason: 'Meh...')
-    put :update, stack_id: @stack.to_param, reason: 'Just for fun!'
-    assert_response :ok
-    assert_json 'is_locked', true
-    assert_json 'lock_reason', 'Just for fun!'
-  end
+      test "#update can override a previous lock" do
+        @stack.update!(lock_reason: 'Meh...')
+        put :update, stack_id: @stack.to_param, reason: 'Just for fun!'
+        assert_response :ok
+        assert_json 'is_locked', true
+        assert_json 'lock_reason', 'Just for fun!'
+      end
 
-  test "#destroy clears the lock" do
-    @stack.update!(lock_reason: 'Meh...')
-    delete :destroy, stack_id: @stack.to_param
-    assert_response :ok
-    assert_json 'is_locked', false
+      test "#destroy clears the lock" do
+        @stack.update!(lock_reason: 'Meh...')
+        delete :destroy, stack_id: @stack.to_param
+        assert_response :ok
+        assert_json 'is_locked', false
+      end
+    end
   end
 end

data/test/controllers/api/outputs_controller_test.rb

@@ -1,17 +1,21 @@
 require 'test_helper'
 
-class Api::OutputsControllerTest < ActionController::TestCase
-  setup do
-    @stack = stacks(:shipit)
-    authenticate!
-  end
+module Shipit
+  module Api
+    class OutputsControllerTest < ActionController::TestCase
+      setup do
+        @stack = shipit_stacks(:shipit)
+        authenticate!
+      end
 
-  test "#show returns the task output as plain text" do
-    task = @stack.tasks.last
+      test "#show returns the task output as plain text" do
+        task = @stack.tasks.last
 
-    get :show, stack_id: @stack.to_param, task_id: task.id
-    assert_response :ok
-    assert_equal 'text/plain', response.content_type
-    assert_equal task.chunk_output, response.body
+        get :show, stack_id: @stack.to_param, task_id: task.id
+        assert_response :ok
+        assert_equal 'text/plain', response.content_type
+        assert_equal task.chunk_output, response.body
+      end
+    end
   end
 end

data/test/controllers/api/stacks_controller_test.rb

@@ -1,57 +1,61 @@
 require 'test_helper'
 
-class Api::StacksControllerTest < ActionController::TestCase
-  setup do
-    authenticate!
-    @stack = stacks(:shipit)
-  end
-
-  test "#index returns a list of stacks" do
-    stack = Stack.last
-
-    get :index
-    assert_response :ok
-    assert_json '0.id', stack.id
-    assert_json do |stacks|
-      assert_equal 3, stacks.size
-    end
-  end
-
-  test "#index is paginable" do
-    get :index, page_size: 1
-    assert_json do |list|
-      assert_instance_of Array, list
-      assert_equal 1, list.size
-
-      stack_id = list.last['id']
-      assert_link 'next', api_stacks_url(since: stack_id, page_size: 1)
-      assert_link 'first', api_stacks_url(page_size: 1)
-    end
-  end
-
-  test "the `next` link is not provided when the last page is reached" do
-    get :index, page_size: Stack.count
-    assert_no_link 'next'
-  end
-
-  test "an api client scoped to a stack will only see that one stack" do
-    authenticate!(:here_come_the_walrus)
-    get :index
-    assert_json do |stacks|
-      assert_equal 1, stacks.size
+module Shipit
+  module Api
+    class StacksControllerTest < ActionController::TestCase
+      setup do
+        authenticate!
+        @stack = shipit_stacks(:shipit)
+      end
+
+      test "#index returns a list of stacks" do
+        stack = Stack.last
+
+        get :index
+        assert_response :ok
+        assert_json '0.id', stack.id
+        assert_json do |stacks|
+          assert_equal 3, stacks.size
+        end
+      end
+
+      test "#index is paginable" do
+        get :index, page_size: 1
+        assert_json do |list|
+          assert_instance_of Array, list
+          assert_equal 1, list.size
+
+          stack_id = list.last['id']
+          assert_link 'next', api_stacks_url(since: stack_id, page_size: 1)
+          assert_link 'first', api_stacks_url(page_size: 1)
+        end
+      end
+
+      test "the `next` link is not provided when the last page is reached" do
+        get :index, page_size: Stack.count
+        assert_no_link 'next'
+      end
+
+      test "an api client scoped to a stack will only see that one stack" do
+        authenticate!(:here_come_the_walrus)
+        get :index
+        assert_json do |stacks|
+          assert_equal 1, stacks.size
+        end
+      end
+
+      test "a request with insufficient permissions will render a 403" do
+        @client.update!(permissions: [])
+        get :index
+        assert_response :forbidden
+        assert_json 'message', 'This operation requires the `read:stack` permission'
+      end
+
+      test "#show renders the stack" do
+        get :show, id: @stack.to_param
+        assert_response :ok
+        assert_json 'id', @stack.id
+      end
     end
   end
-
-  test "a request with insufficient permissions will render a 403" do
-    @client.update!(permissions: [])
-    get :index
-    assert_response :forbidden
-    assert_json 'message', 'This operation requires the `read:stack` permission'
-  end
-
-  test "#show renders the stack" do
-    get :show, id: @stack.to_param
-    assert_response :ok
-    assert_json 'id', @stack.id
-  end
 end

data/test/controllers/api/tasks_controller_test.rb

@@ -1,36 +1,40 @@
 require 'test_helper'
 
-class Api::TasksControllerTest < ActionController::TestCase
-  setup do
-    @stack = stacks(:shipit)
-    authenticate!
-  end
+module Shipit
+  module Api
+    class TasksControllerTest < ActionController::TestCase
+      setup do
+        @stack = shipit_stacks(:shipit)
+        authenticate!
+      end
 
-  test "#index returns a list of tasks" do
-    task = @stack.tasks.last
+      test "#index returns a list of tasks" do
+        task = @stack.tasks.last
 
-    get :index, stack_id: @stack.to_param
-    assert_response :ok
-    assert_json '0.id', task.id
-  end
+        get :index, stack_id: @stack.to_param
+        assert_response :ok
+        assert_json '0.id', task.id
+      end
 
-  test "#show returns a task" do
-    task = @stack.tasks.last
+      test "#show returns a task" do
+        task = @stack.tasks.last
 
-    get :show, stack_id: @stack.to_param, id: task.id
-    assert_response :ok
-    assert_json 'id', task.id
-  end
+        get :show, stack_id: @stack.to_param, id: task.id
+        assert_response :ok
+        assert_json 'id', task.id
+      end
 
-  test "#trigger triggers a custom task" do
-    post :trigger, stack_id: @stack.to_param, task_name: 'restart'
-    assert_response :accepted
-    assert_json 'type', 'task'
-    assert_json 'status', 'pending'
-  end
+      test "#trigger triggers a custom task" do
+        post :trigger, stack_id: @stack.to_param, task_name: 'restart'
+        assert_response :accepted
+        assert_json 'type', 'task'
+        assert_json 'status', 'pending'
+      end
 
-  test "#trigger returns a 404 when the task doesn't exist" do
-    post :trigger, stack_id: @stack.to_param, task_name: 'doesnt_exist'
-    assert_response :not_found
+      test "#trigger returns a 404 when the task doesn't exist" do
+        post :trigger, stack_id: @stack.to_param, task_name: 'doesnt_exist'
+        assert_response :not_found
+      end
+    end
   end
 end

data/test/controllers/commit_checks_controller_test.rb

@@ -1,34 +1,36 @@
 require 'test_helper'
 
-class CommitChecksControllerTest < ActionController::TestCase
-  setup do
-    @commit = commits(:fifth)
-    @checks = @commit.checks
-    @stack = @commit.stack
-    @checks.write('foobar')
-    @checks.status = 'running'
-    session[:user_id] = users(:walrus).id
-  end
+module Shipit
+  class CommitChecksControllerTest < ActionController::TestCase
+    setup do
+      @commit = shipit_commits(:fifth)
+      @checks = @commit.checks
+      @stack = @commit.stack
+      @checks.write('foobar')
+      @checks.status = 'running'
+      session[:user_id] = shipit_users(:walrus).id
+    end
 
-  test ":tail is success" do
-    get :tail, stack_id: @stack.to_param, sha: @commit.sha
-    assert_response :success
-    assert_json 'output', 'foobar'
-    assert_json 'url', stack_tail_commit_checks_path(@stack, sha: @commit.sha, since: 6)
-    assert_json 'status', 'running'
-  end
+    test ":tail is success" do
+      get :tail, stack_id: @stack.to_param, sha: @commit.sha
+      assert_response :success
+      assert_json 'output', 'foobar'
+      assert_json 'url', stack_tail_commit_checks_path(@stack, sha: @commit.sha, since: 6)
+      assert_json 'status', 'running'
+    end
 
-  test ":tail doesn't provide another url if the task is finished" do
-    @checks.status = 'success'
-    get :tail, stack_id: @stack.to_param, sha: @commit.sha
-    assert_response :success
-    assert_json 'url', nil
-  end
+    test ":tail doesn't provide another url if the task is finished" do
+      @checks.status = 'success'
+      get :tail, stack_id: @stack.to_param, sha: @commit.sha
+      assert_response :success
+      assert_json 'url', nil
+    end
 
-  test ":tail returns only the output after the provided offset" do
-    @checks.status = 'success'
-    get :tail, stack_id: @stack.to_param, sha: @commit.sha, since: 5
-    assert_response :success
-    assert_json 'output', 'r'
+    test ":tail returns only the output after the provided offset" do
+      @checks.status = 'success'
+      get :tail, stack_id: @stack.to_param, sha: @commit.sha, since: 5
+      assert_response :success
+      assert_json 'output', 'r'
+    end
   end
 end