shipit-engine 0.30.0 → 0.34.0

data/test/models/pull_request_assignment_test.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Shipit
+  class PullRequestAssignmentTest < ActiveSupport::TestCase
+    setup do
+      @assignment = shipit_pull_request_assignments(:walrus_shopify_developers)
+    end
+
+    test "no duplicates are accepted" do
+      assignment = PullRequestAssignment.new(user: @assignment.user, pull_request: @assignment.pull_request)
+      refute assignment.valid?
+    end
+  end
+end

data/test/models/release_statuses_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/rollbacks_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/shipit/check_run_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -8,13 +9,130 @@ module Shipit
       @check_run = shipit_check_runs(:second_pending_travis)
     end
 
+    test ".create_or_update_from_github! updates successfully" do
+      completed_at = Time.now
+      assert_difference -> { @commit.check_runs.count }, +1 do
+        @commit.check_runs.create_or_update_from_github!(
+          @stack.id,
+          github_check_run(conclusion: nil, completed_at: '2021-04-29T18:05:12Z')
+        )
+      end
+
+      assert_no_enqueued_jobs(only: RefreshCheckRunsJob) do
+        @commit.check_runs.create_or_update_from_github!(
+          @stack.id,
+          github_check_run(conclusion: 'success', completed_at: completed_at + 1.minute)
+        )
+      end
+
+      assert_equal 'success', @commit.check_runs.last.conclusion
+    end
+
+    test ".create_or_update_from_github! updates successfully using latest timestamp" do
+      completed_at = Time.now
+      assert_difference -> { @commit.check_runs.count }, +1 do
+        @commit.check_runs.create_or_update_from_github!(
+          @stack.id,
+          github_check_run(conclusion: 'success', completed_at: completed_at)
+        )
+      end
+
+      assert_enqueued_with(job: RefreshCheckRunsJob) do
+        @commit.check_runs.create_or_update_from_github!(
+          @stack.id,
+          github_check_run(conclusion: nil, completed_at: completed_at)
+        )
+      end
+
+      # RefreshCheckRunsJob would enqueue if the timestamp was older/equivalent
+      assert_no_enqueued_jobs(only: RefreshCheckRunsJob) do
+        @commit.check_runs.create_or_update_from_github!(
+          @stack.id,
+          github_check_run(
+            conclusion: 'action_required',
+            completed_at: completed_at,
+            started_at: completed_at + 1.minute,
+          ),
+        )
+      end
+
+      assert_equal 'action_required', @commit.check_runs.last.conclusion
+    end
+
     test ".create_or_update_from_github! is idempotent" do
+      completed_at = Time.now
+      assert_difference -> { @commit.check_runs.count }, +1 do
+        @commit.check_runs.create_or_update_from_github!(@stack.id, github_check_run(completed_at: completed_at))
+      end
+
+      assert_no_difference -> { @commit.check_runs.count } do
+        assert_no_enqueued_jobs(only: RefreshCheckRunsJob) do
+          @commit.check_runs.create_or_update_from_github!(@stack.id, github_check_run(completed_at: completed_at))
+        end
+      end
+    end
+
+    test ".create_or_update_from_github! enqueues refresh and updates record when new statuses have stale timestamps" do
+      completed_at = Time.now
       assert_difference -> { @commit.check_runs.count }, +1 do
-        @commit.check_runs.create_or_update_from_github!(@stack.id, github_check_run)
+        @commit.check_runs.create_or_update_from_github!(
+          @stack.id,
+          github_check_run(conclusion: 'success', completed_at: completed_at)
+        )
+      end
+
+      assert_equal 'success', @commit.check_runs.last.conclusion
+
+      updated_conclusion = 'action_required'
+      updated_check_run = github_check_run(conclusion: updated_conclusion, completed_at: completed_at - 1.minute)
+
+      assert_no_difference -> { @commit.check_runs.count } do
+        assert_enqueued_with(job: RefreshCheckRunsJob) do
+          @commit.check_runs.create_or_update_from_github!(@stack.id, updated_check_run)
+        end
+      end
+
+      assert_equal updated_conclusion, @commit.check_runs.last.conclusion
+
+      # If the refresh returns the same data, then the record should end up the same, but no refresh should be necessary
+      assert_no_difference -> { @commit.check_runs.count } do
+        assert_no_enqueued_jobs(only: RefreshCheckRunsJob) do
+          @commit.check_runs.create_or_update_from_github!(@stack.id, updated_check_run)
+        end
       end
 
+      assert_equal updated_conclusion, @commit.check_runs.last.conclusion
+    end
+
+    test ".create_or_update_from_github! does not enqueues refresh when old statuses has no timestamp" do
+      completed_at = Time.now
+      assert_difference -> { @commit.check_runs.count }, +1 do
+        @commit.check_runs.create_or_update_from_github!(
+          @stack.id,
+          github_check_run(conclusion: 'success', completed_at: completed_at)
+        )
+      end
+
+      @commit.check_runs.last.update!(github_updated_at: nil)
+
+      assert_no_difference -> { @commit.check_runs.count } do
+        assert_no_enqueued_jobs(only: RefreshCheckRunsJob) do
+          @commit.check_runs.create_or_update_from_github!(
+            @stack.id,
+            github_check_run(conclusion: nil, completed_at: completed_at - 1.minute)
+          )
+        end
+      end
+    end
+
+    test ".create_or_update_from_github! enqueues refresh when new statuses have no timestamps" do
       assert_no_difference -> { @commit.check_runs.count } do
-        @commit.check_runs.create_or_update_from_github!(@stack.id, github_check_run)
+        assert_enqueued_with(job: RefreshCheckRunsJob, args: [stack_id: @stack.id]) do
+          @commit.check_runs.create_or_update_from_github!(
+            @stack.id,
+            github_check_run(conclusion: nil, completed_at: nil, started_at: nil)
+          )
+        end
       end
     end
 
@@ -35,16 +153,18 @@ module Shipit
 
     private
 
-    def github_check_run
-      @github_check_run ||= OpenStruct.new(
+    def github_check_run(conclusion: 'success', completed_at: Time.now, started_at: Time.now - 1.minute)
+      OpenStruct.new(
         id: 424_242,
-        conclusion: 'success',
+        conclusion: conclusion,
         output: OpenStruct.new(
           description: 'This is a description',
         ),
         name: 'Test Suite',
         html_url: 'http://example.com/run',
         details_url: 'http://example.com/details',
+        completed_at: completed_at,
+        started_at: started_at,
       )
     end
   end

data/test/models/shipit/provisioning_handler/base_test.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Shipit
+  module ProvisioningHandler
+    class BaseTest < ActiveSupport::TestCase
+      test "provides a default #up handler" do
+        assert(
+          handler.respond_to?(:up),
+          "expected #{handler.class.name} to provide a default #up handler"
+        )
+      end
+
+      test "provides a default #down handler" do
+        assert(
+          handler.respond_to?(:down),
+          "expected #{handler.class.name} to provide a default #down handler"
+        )
+      end
+
+      test "provides a default #provision? handler" do
+        assert_equal true, handler.provision?
+      end
+
+      private
+
+      def handler
+        ProvisioningHandler::Base.new(mock("Stack"))
+      end
+    end
+  end
+end

data/test/models/shipit/provisioning_handler/unregistered_provisioning_handler_test.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Shipit
+  module ProvisioningHandler
+    class UnregisteredProvisioningHandlerTest < ActiveSupport::TestCase
+      test "#up stops transitions" do
+        stack = shipit_stacks(:shipit)
+        stack.update(provision_status: :deprovisioned)
+
+        assert_throws :halt do
+          UnregisteredProvisioningHandler.new(stack).up
+        end
+      end
+
+      test "#up locks the stack" do
+        stack = shipit_stacks(:shipit)
+        stack.update(provision_status: :deprovisioned)
+
+        assert_changes -> { stack.locked? }, from: false, to: true do
+          catch :halt do
+            UnregisteredProvisioningHandler.new(stack).up
+          end
+        end
+      end
+
+      test "#down stops transitions" do
+        stack = shipit_stacks(:shipit)
+        stack.update(provision_status: :deprovisioned)
+
+        assert_throws :halt do
+          UnregisteredProvisioningHandler.new(stack).down
+        end
+      end
+
+      test "#down prevents transitions" do
+        stack = shipit_stacks(:shipit)
+        stack.update(provision_status: :deprovisioned)
+
+        assert_changes -> { stack.locked? }, from: false, to: true do
+          catch :halt do
+            UnregisteredProvisioningHandler.new(stack).down
+          end
+        end
+      end
+    end
+  end
+end

data/test/models/shipit/provisioning_handler_test.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Shipit
+  class StackProvisioningHandlerTest < ActiveSupport::TestCase
+    teardown do
+      Shipit::ProvisioningHandler.reset_registry!
+    end
+
+    test "uses the no-op handler as default when no default handler is registered" do
+      assert_equal Shipit::ProvisioningHandler::Base, Shipit::ProvisioningHandler.default
+    end
+
+    test "allows registration of a default handler" do
+      mock_handler = mock("Mock Provisioning Handler")
+
+      Shipit::ProvisioningHandler.default = mock_handler
+
+      assert_equal mock_handler, Shipit::ProvisioningHandler.default
+    end
+
+    test "UnregisteredProvisioningHandler is returned when an attempt to fetch an unregistered handler is made" do
+      unregistered_handler = mock("Mock Provisioning Handler")
+
+      assert_equal(
+        Shipit::ProvisioningHandler::UnregisteredProvisioningHandler,
+        Shipit::ProvisioningHandler.fetch(unregistered_handler)
+      )
+    end
+
+    test "registers handlers so they become fetchable" do
+      mock_handler = mock("Mock Provisioning Handler")
+
+      Shipit::ProvisioningHandler.register(mock_handler)
+
+      assert_equal mock_handler, Shipit::ProvisioningHandler.fetch(mock_handler.to_s)
+    end
+
+    test "handlers are called during provisioning" do
+      stack = shipit_stacks(:review_stack)
+      stack.update(
+        provision_status: :deprovisioned
+      )
+      handler = Shipit::ProvisioningHandler.default
+
+      handler.any_instance.expects(:up)
+
+      assert stack.provision!, "stack should have provisioned."
+    end
+
+    test "handlers are called during deprovisioning" do
+      stack = shipit_stacks(:review_stack)
+      stack.update(
+        provision_status: :provisioned
+      )
+      handler = Shipit::ProvisioningHandler.default
+
+      handler.any_instance.expects(:down)
+
+      assert stack.deprovision!, "stack should have deprovisioned."
+    end
+  end
+end

data/test/models/shipit/pull_request_test.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+module Shipit
+  class PullRequestTest < ActiveSupport::TestCase
+    test "github_pull_request= parses into a a Shipit::PullRequest" do
+      github_pull_request = resource(
+        {
+          url: "https://api.github.com/repos/Codertocat/Hello-World/pulls/2",
+          id: 279147437,
+          number: 2,
+          state: "open",
+          additions: 100,
+          deletions: 101,
+          title: "Update the README with new information.",
+          head: {
+            sha: "ec26c3e57ca3a959ca5aad62de7213c562f8c821",
+          },
+          user: {
+            login: "Codertocat",
+          },
+          assignees: [
+            {
+              login: "bob",
+            },
+          ],
+          labels: [
+            {
+              name: "deploy",
+            },
+          ],
+        }
+      )
+      stack = shipit_stacks(:review_stack)
+      pull_request = stack.pull_request
+
+      stack.pull_request.github_pull_request = github_pull_request
+
+      assert_equal 279147437, pull_request.github_id
+      assert_equal 2, pull_request.number
+      assert_equal "https://api.github.com/repos/Codertocat/Hello-World/pulls/2", pull_request.api_url
+      assert_equal "Update the README with new information.", pull_request.title
+      assert_equal "open", pull_request.state
+      assert_equal 100, pull_request.additions
+      assert_equal 101, pull_request.deletions
+      assert_equal shipit_users(:codertocat), pull_request.user
+      assert_equal [shipit_users(:bob)], pull_request.assignees
+      assert_equal ["deploy"], pull_request.labels
+    end
+  end
+end

data/test/models/shipit/repository_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -19,7 +20,7 @@ module Shipit
 
     test "owner and name are case insensitive" do
       assert_no_difference -> { Repository.count } do
-        error = assert_raises ActiveRecord::RecordInvalid do
+        error = assert_raises(ActiveRecord::RecordInvalid) do
           Repository.create!(
             owner: @repository.owner.upcase,
             name: @repository.name.upcase,
@@ -62,6 +63,10 @@ module Shipit
       assert_equal "https://github.com/#{@repository.owner}/#{@repository.name}.git", @repository.git_url
     end
 
+    test "review_stacks_enabled defaults to false" do
+      assert_equal false, Repository.new.review_stacks_enabled
+    end
+
     test "from_github_repo_name" do
       owner = "repository-owner"
       name = "repository-name"

data/test/models/shipit/review_stack_provision_status_test.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Shipit
+  class ReviewStackProvisionStatusTest < ActiveSupport::TestCase
+    test "stacks default to deprovisioned state" do
+      stack = Shipit::ReviewStack.new
+
+      assert_equal 'deprovisioned', stack.provision_status
+    end
+
+    test "non-review stacks don't transition" do
+      stack = Shipit::ReviewStack.new
+      stack.provision
+
+      assert_equal 'deprovisioned', stack.provision_status
+    end
+
+    test "review stacks that are deprovisioned can be provisioned" do
+      stack = review_stack(provision_status: :deprovisioned)
+
+      stack.provision
+
+      assert_equal 'provisioning', stack.provision_status
+    end
+
+    test "review stacks that are provisioning can succeed" do
+      stack = review_stack(provision_status: :provisioning)
+
+      stack.provision_success
+
+      assert_equal 'provisioned', stack.provision_status
+    end
+
+    test "review stacks that are provisioning can fail" do
+      stack = review_stack(provision_status: :provisioning)
+
+      stack.provision_failure
+
+      assert_equal 'deprovisioned', stack.provision_status
+    end
+
+    test "review stacks are provisioned can be deprovisioned" do
+      stack = review_stack(provision_status: :provisioned)
+
+      stack.deprovision
+
+      assert 'deprovisioning', stack.provision_status
+    end
+
+    test "review stacks that are deprovisioning can succeed" do
+      stack = review_stack(provision_status: :deprovisioning)
+
+      stack.deprovision_success
+
+      assert_equal 'deprovisioned', stack.provision_status
+    end
+
+    test "review stacks that are deprovisioning can fail" do
+      stack = review_stack(provision_status: :deprovisioning)
+
+      stack.deprovision_failure
+
+      assert_equal 'provisioned', stack.provision_status
+    end
+
+    def review_stack(provision_status: :deprovisioned)
+      stack = shipit_stacks(:review_stack)
+      stack.provision_status = provision_status
+
+      stack.save!
+
+      stack
+    end
+  end
+end