shipit-engine 0.30.0 → 0.34.0

data/app/models/shipit/team.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 module Shipit
-  class Team < ActiveRecord::Base
+  class Team < Record
     REQUIRED_HOOKS = %i(membership).freeze
 
     has_many :memberships
@@ -25,7 +26,8 @@ module Shipit
       end
 
       def find_team_on_github(organization, slug)
-        teams = Shipit::OctokitIterator.new { Shipit.github.api.org_teams(organization, per_page: 100) }
+        gh_api = Shipit.github(organization: organization).api
+        teams = Shipit::OctokitIterator.new(github_api: gh_api) { gh_api.org_teams(organization, per_page: 100) }
         teams.find { |t| t.slug == slug }
       rescue Octokit::NotFound
       end
@@ -40,7 +42,8 @@ module Shipit
     end
 
     def refresh_members!
-      github_members = Shipit::OctokitIterator.new(Shipit.github.api.get(api_url).rels[:members])
+      github_api = Shipit.github(organization: organization).api
+      github_members = Shipit::OctokitIterator.new(github_api.get(api_url).rels[:members])
       members = github_members.map { |u| User.find_or_create_from_github(u) }
       self.members = members
       save!

data/app/models/shipit/undeployed_commit.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   class UndeployedCommit < DelegateClass(Commit)
     attr_reader :index

data/app/models/shipit/unlimited_api_client.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   class UnlimitedApiClient
     def stack_id?

data/app/models/shipit/user.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 module Shipit
-  class User < ActiveRecord::Base
+  class User < Record
     DEFAULT_AVATAR = URI.parse('https://avatars.githubusercontent.com/u/583231?')
 
     has_many :memberships
@@ -14,6 +15,8 @@ module Shipit
 
     def self.find_or_create_by_login!(login)
       find_or_create_by!(login: login) do |user|
+        # Users are global, any app can be used
+        # This will not work for users that only exist in an Enterprise install
         user.github_user = Shipit.github.api.user(login)
       end
     end
@@ -23,9 +26,9 @@ module Shipit
     end
 
     def self.find_or_create_author_from_github_commit(github_commit)
-      if github_commit.commit.message =~ /^#{PullRequest::MERGE_REQUEST_FIELD}: ([\w\-\.]+)$/
+      if (match_info = github_commit.commit.message.match(/^#{MergeRequest::MERGE_REQUEST_FIELD}: ([\w\-\.]+)$/))
         begin
-          return find_or_create_by_login!($1)
+          return find_or_create_by_login!(match_info[1])
         rescue Octokit::NotFound
           # Corner case where the merge-requested-by user cannot be found (renamed/deleted).
           # In this case we carry on and search for the commit author
@@ -68,7 +71,7 @@ module Shipit
     end
 
     def identifiers_for_ping
-      {github_id: github_id, name: name, email: email, github_login: login}
+      { github_id: github_id, name: name, email: email, github_login: login }
     end
 
     def logged_in?
@@ -79,12 +82,19 @@ module Shipit
       @authorized ||= Shipit.github_teams.empty? || teams.where(id: Shipit.github_teams.map(&:id)).exists?
     end
 
+    def repositories_contributed_to
+      return [] unless id
+      Stack.where(id: stacks_contributed_to).distinct.pluck(:repository_id)
+    end
+
     def stacks_contributed_to
       return [] unless id
       Commit.where('author_id = :id or committer_id = :id', id: id).distinct.pluck(:stack_id)
     end
 
     def refresh_from_github!
+      # Users are global, any app can be used
+      # This will not work for users that only exist in an Enterprise install
       update!(github_user: Shipit.github.api.user(github_id))
     rescue Octokit::NotFound
       identify_renamed_user!
@@ -137,11 +147,12 @@ module Shipit
 
       begin
         github_api.emails
-                  .sort_by { |e| e.primary ? 0 : 1 }
-                  .map(&:email)
-                  .find { |e| email_valid_and_preferred?(e) }
-      rescue Octokit::NotFound, Octokit::Forbidden
+          .sort_by { |e| e.primary ? 0 : 1 }
+          .map(&:email)
+          .find { |e| email_valid_and_preferred?(e) }
+      rescue Octokit::NotFound, Octokit::Forbidden, Octokit::Unauthorized
         # If the user hasn't agreed to the necessary permission, we can't access their private emails.
+        Rails.logger.warn("Failed to retrieve emails for user '#{github_user.name || github_user.login}'")
         nil
       end
     end

data/app/models/shipit/variable_definition.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   class VariableDefinition
     attr_reader :name, :title, :default, :select

data/app/models/shipit/webhooks.rb

@@ -1,9 +1,20 @@
+# frozen_string_literal: true
 module Shipit
   module Webhooks
     class << self
       def default_handlers
         {
           'push' => [Handlers::PushHandler],
+          'pull_request' => [
+            Handlers::PullRequest::OpenedHandler,
+            Handlers::PullRequest::ClosedHandler,
+            Handlers::PullRequest::ReopenedHandler,
+            Handlers::PullRequest::EditedHandler,
+            Handlers::PullRequest::AssignedHandler,
+            Handlers::PullRequest::LabeledHandler,
+            Handlers::PullRequest::UnlabeledHandler,
+            Handlers::PullRequest::LabelCapturingHandler,
+          ],
           'status' => [Handlers::StatusHandler],
           'membership' => [Handlers::MembershipHandler],
           'check_suite' => [Handlers::CheckSuiteHandler],

data/app/models/shipit/webhooks/handlers/check_suite_handler.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   module Webhooks
     module Handlers

data/app/models/shipit/webhooks/handlers/handler.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   module Webhooks
     module Handlers

data/app/models/shipit/webhooks/handlers/membership_handler.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Shipit
   module Webhooks
     module Handlers

data/app/models/shipit/webhooks/handlers/pull_request/assigned_handler.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+module Shipit
+  module Webhooks
+    module Handlers
+      module PullRequest
+        class AssignedHandler < Shipit::Webhooks::Handlers::Handler
+          params do
+            requires :action, String
+            requires :number, Integer
+            requires :pull_request do
+              requires :id, Integer
+              requires :number, Integer
+              requires :url, String
+              requires :title, String
+              requires :state, String
+              requires :additions, Integer
+              requires :deletions, Integer
+              requires :head do
+                requires :sha, String
+                requires :ref, String
+              end
+              requires :user do
+                requires :login, String
+              end
+              requires :assignees, Array do
+                requires :login, String
+              end
+              requires :labels, Array do
+                requires :name, String
+              end
+            end
+            requires :repository do
+              requires :full_name, String
+            end
+            requires :sender do
+              requires :login, String
+            end
+          end
+
+          def process
+            return unless respond_to_assignee_change?
+
+            pull_request.update(github_pull_request: params.pull_request) if pull_request.present?
+          end
+
+          private
+
+          def respond_to_assignee_change?
+            %w[assigned unassigned].include?(params.action)
+          end
+
+          def pull_request
+            @pull_request ||= Shipit::PullRequest
+              .joins(:stack, stack: :repository)
+              .find_by(
+                number: params.number,
+                stacks: {
+                  repositories:
+                    {
+                      id: repository.id,
+                    },
+                }
+              )
+          end
+
+          def repository
+            Shipit::Repository.from_github_repo_name(params.repository.full_name) || Shipit::NullRepository.new
+          end
+        end
+      end
+    end
+  end
+end

data/app/models/shipit/webhooks/handlers/pull_request/closed_handler.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+module Shipit
+  module Webhooks
+    module Handlers
+      module PullRequest
+        class ClosedHandler < Shipit::Webhooks::Handlers::Handler
+          params do
+            requires :action, String
+            requires :number, Integer
+            requires :pull_request do
+              requires :id, Integer
+              requires :number, Integer
+              requires :url, String
+              requires :title, String
+              requires :state, String
+              requires :additions, Integer
+              requires :deletions, Integer
+              requires :head do
+                requires :sha, String
+                requires :ref, String
+              end
+              requires :user do
+                requires :login, String
+              end
+              requires :assignees, Array do
+                requires :login, String
+              end
+              requires :labels, Array do
+                requires :name, String
+              end
+            end
+            requires :repository do
+              requires :full_name, String
+            end
+            requires :sender do
+              requires :login, String
+            end
+          end
+
+          def process
+            return unless respond_to_pull_request_closed?
+
+            review_stack.archive!
+          end
+
+          private
+
+          def repository
+            @repository ||=
+              Shipit::Repository.from_github_repo_name(params.repository.full_name) ||
+              Shipit::NullRepository.new
+          end
+
+          def review_stack
+            @review_stack ||=
+              Shipit::Webhooks::Handlers::PullRequest::ReviewStackAdapter
+                .new(params, scope: repository.review_stacks)
+          end
+
+          def respond_to_pull_request_closed?
+            params.action == "closed"
+          end
+        end
+      end
+    end
+  end
+end

data/app/models/shipit/webhooks/handlers/pull_request/edited_handler.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+module Shipit
+  module Webhooks
+    module Handlers
+      module PullRequest
+        class EditedHandler < Shipit::Webhooks::Handlers::Handler
+          params do
+            requires :action, String
+            requires :number, Integer
+            requires :pull_request do
+              requires :id, Integer
+              requires :number, Integer
+              requires :url, String
+              requires :title, String
+              requires :state, String
+              requires :additions, Integer
+              requires :deletions, Integer
+              requires :head do
+                requires :sha, String
+                requires :ref, String
+              end
+              requires :user do
+                requires :login, String
+              end
+              requires :assignees, Array do
+                requires :login, String
+              end
+              requires :labels, Array do
+                requires :name, String
+              end
+            end
+            requires :repository do
+              requires :full_name, String
+            end
+            requires :sender do
+              requires :login, String
+            end
+          end
+
+          def process
+            return unless respond_to_pull_request_edited?
+
+            pull_request.update(github_pull_request: params.pull_request) if pull_request.present?
+          end
+
+          private
+
+          def pull_request
+            @pull_request ||= Shipit::PullRequest
+              .joins(:stack, stack: :repository)
+              .find_by(
+                number: params.number,
+                stacks: {
+                  repositories:
+                    {
+                      id: repository.id,
+                    },
+                }
+              )
+          end
+
+          def repository
+            Shipit::Repository.from_github_repo_name(params.repository.full_name) || Shipit::NullRepository.new
+          end
+
+          def respond_to_pull_request_edited?
+            params.action == "edited"
+          end
+        end
+      end
+    end
+  end
+end

data/app/models/shipit/webhooks/handlers/pull_request/label_capturing_handler.rb

@@ -0,0 +1,127 @@
+# frozen_string_literal: true
+
+module Shipit
+  module Webhooks
+    module Handlers
+      module PullRequest
+        class LabelCapturingHandler < Shipit::Webhooks::Handlers::Handler
+          params do
+            requires :action, String
+            requires :number, Integer
+            requires :pull_request do
+              requires :id, Integer
+              requires :number, Integer
+              requires :url, String
+              requires :title, String
+              requires :state, String
+              requires :additions, Integer
+              requires :deletions, Integer
+              requires :head do
+                requires :sha, String
+                requires :ref, String
+              end
+              requires :user do
+                requires :login, String
+              end
+              requires :assignees, Array do
+                requires :login, String
+              end
+              requires :labels, Array do
+                requires :name, String
+              end
+            end
+            requires :repository do
+              requires :full_name, String
+            end
+            requires :sender do
+              requires :login, String
+            end
+          end
+
+          def process
+            return unless capture_labels?
+
+            capture_labels
+
+            stack
+          end
+
+          private
+
+          def capture_labels?
+            opened_active_stack? ||
+              labeled_active_stack? ||
+              unlabeled_active_stack? ||
+              reopened_active_stack?
+          end
+
+          def opened_active_stack?
+            opened? && stack.present?
+          end
+
+          def labeled_active_stack?
+            labeled? && stack.present? && !stack.archived?
+          end
+
+          def unlabeled_active_stack?
+            unlabeled? && stack.present? && !stack.archived?
+          end
+
+          def reopened_active_stack?
+            reopened? && stack.present? && !stack.archived?
+          end
+
+          def opened?
+            action == "opened"
+          end
+
+          def labeled?
+            action == "labeled"
+          end
+
+          def unlabeled?
+            action == "unlabeled"
+          end
+
+          def reopened?
+            action == "reopened"
+          end
+
+          def action
+            params.action
+          end
+
+          def pull_request
+            params.pull_request
+          end
+
+          def capture_labels
+            return unless pull_request = stack.pull_request
+
+            pull_request.update!(labels: params.pull_request.labels.map(&:name))
+          end
+
+          def review_stack
+            @review_stack ||=
+              Shipit::Webhooks::Handlers::PullRequest::ReviewStackAdapter
+                .new(params, scope: repository.review_stacks)
+          end
+
+          def repository
+            @repository ||=
+              Shipit::Repository
+                .from_github_repo_name(params.repository.full_name) || NullRepository.new
+          end
+
+          def stack
+            @stack ||= review_stack.stack
+          end
+
+          def labels
+            Array.new(pull_request.labels).map(&:name)
+          end
+        end
+      end
+    end
+  end
+end