shipit-engine 0.30.0 → 0.34.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (410) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +19 -4
  3. data/Rakefile +4 -2
  4. data/app/assets/images/magic-solid.svg +1 -0
  5. data/app/assets/javascripts/shipit/repositories_search.js.coffee +60 -0
  6. data/app/assets/javascripts/shipit/{search.js.coffee → stack_search.js.coffee} +0 -0
  7. data/app/assets/stylesheets/_pages/_deploy.scss +0 -2
  8. data/app/assets/stylesheets/_pages/_repositories.scss +148 -0
  9. data/app/assets/stylesheets/_pages/_stacks.scss +19 -3
  10. data/app/assets/stylesheets/merge_status.scss +0 -3
  11. data/app/assets/stylesheets/shipit.scss +1 -0
  12. data/app/controllers/concerns/shipit/active_model_serializers_patch.rb +1 -0
  13. data/app/controllers/concerns/shipit/api/cacheable.rb +1 -0
  14. data/app/controllers/concerns/shipit/api/paginable.rb +3 -2
  15. data/app/controllers/concerns/shipit/api/rendering.rb +5 -4
  16. data/app/controllers/concerns/shipit/authentication.rb +3 -2
  17. data/app/controllers/concerns/shipit/pagination.rb +2 -1
  18. data/app/controllers/shipit/api/base_controller.rb +11 -6
  19. data/app/controllers/shipit/api/ccmenu_controller.rb +2 -1
  20. data/app/controllers/shipit/api/commits_controller.rb +2 -1
  21. data/app/controllers/shipit/api/deploys_controller.rb +6 -3
  22. data/app/controllers/shipit/api/hooks_controller.rb +6 -5
  23. data/app/controllers/shipit/api/locks_controller.rb +5 -4
  24. data/app/controllers/shipit/api/merge_requests_controller.rb +37 -0
  25. data/app/controllers/shipit/api/outputs_controller.rb +2 -1
  26. data/app/controllers/shipit/api/release_statuses_controller.rb +3 -2
  27. data/app/controllers/shipit/api/rollbacks_controller.rb +34 -0
  28. data/app/controllers/shipit/api/stacks_controller.rb +32 -5
  29. data/app/controllers/shipit/api/tasks_controller.rb +6 -5
  30. data/app/controllers/shipit/api_clients_controller.rb +4 -3
  31. data/app/controllers/shipit/ccmenu_url_controller.rb +4 -3
  32. data/app/controllers/shipit/commit_checks_controller.rb +2 -1
  33. data/app/controllers/shipit/commits_controller.rb +2 -1
  34. data/app/controllers/shipit/deploys_controller.rb +4 -3
  35. data/app/controllers/shipit/github_authentication_controller.rb +4 -3
  36. data/app/controllers/shipit/merge_requests_controller.rb +31 -0
  37. data/app/controllers/shipit/merge_status_controller.rb +31 -30
  38. data/app/controllers/shipit/release_statuses_controller.rb +3 -2
  39. data/app/controllers/shipit/repositories_controller.rb +74 -0
  40. data/app/controllers/shipit/rollbacks_controller.rb +3 -2
  41. data/app/controllers/shipit/shipit_controller.rb +2 -1
  42. data/app/controllers/shipit/stacks_controller.rb +24 -9
  43. data/app/controllers/shipit/status_controller.rb +2 -1
  44. data/app/controllers/shipit/tasks_controller.rb +7 -6
  45. data/app/controllers/shipit/webhooks_controller.rb +26 -6
  46. data/app/helpers/shipit/chunks_helper.rb +3 -2
  47. data/app/helpers/shipit/deploys_helper.rb +4 -3
  48. data/app/helpers/shipit/github_url_helper.rb +9 -0
  49. data/app/helpers/shipit/merge_status_helper.rb +1 -0
  50. data/app/helpers/shipit/shipit_helper.rb +1 -1
  51. data/app/helpers/shipit/stacks_helper.rb +5 -0
  52. data/app/helpers/shipit/tasks_helper.rb +1 -0
  53. data/app/jobs/shipit/background_job.rb +4 -0
  54. data/app/jobs/shipit/background_job/unique.rb +1 -0
  55. data/app/jobs/shipit/cache_deploy_spec_job.rb +1 -0
  56. data/app/jobs/shipit/chunk_rollup_job.rb +4 -0
  57. data/app/jobs/shipit/clear_git_cache_job.rb +1 -0
  58. data/app/jobs/shipit/continuous_delivery_job.rb +2 -1
  59. data/app/jobs/shipit/create_on_github_job.rb +7 -1
  60. data/app/jobs/shipit/create_release_statuses_job.rb +1 -0
  61. data/app/jobs/shipit/deferred_touch_job.rb +4 -0
  62. data/app/jobs/shipit/deliver_hook_job.rb +2 -1
  63. data/app/jobs/shipit/destroy_job.rb +1 -0
  64. data/app/jobs/shipit/destroy_repository_job.rb +24 -0
  65. data/app/jobs/shipit/destroy_stack_job.rb +3 -2
  66. data/app/jobs/shipit/emit_event_job.rb +2 -1
  67. data/app/jobs/shipit/fetch_commit_stats_job.rb +1 -0
  68. data/app/jobs/shipit/fetch_deployed_revision_job.rb +1 -0
  69. data/app/jobs/shipit/github_sync_job.rb +15 -10
  70. data/app/jobs/shipit/mark_deploy_healthy_job.rb +1 -0
  71. data/app/jobs/shipit/perform_commit_checks_job.rb +1 -0
  72. data/app/jobs/shipit/perform_task_job.rb +5 -92
  73. data/app/jobs/shipit/process_merge_requests_job.rb +32 -0
  74. data/app/jobs/shipit/purge_old_deliveries_job.rb +1 -0
  75. data/app/jobs/shipit/reap_dead_tasks_job.rb +21 -0
  76. data/app/jobs/shipit/refresh_check_runs_job.rb +1 -0
  77. data/app/jobs/shipit/refresh_github_user_job.rb +1 -0
  78. data/app/jobs/shipit/refresh_merge_request_job.rb +11 -0
  79. data/app/jobs/shipit/refresh_statuses_job.rb +1 -0
  80. data/app/jobs/shipit/setup_github_hook_job.rb +1 -0
  81. data/app/jobs/shipit/update_estimated_deploy_duration_job.rb +1 -0
  82. data/app/jobs/shipit/update_github_last_deployed_ref_job.rb +5 -4
  83. data/app/models/concerns/shipit/deferred_touch.rb +4 -3
  84. data/app/models/shipit/anonymous_user.rb +15 -2
  85. data/app/models/shipit/api_client.rb +3 -2
  86. data/app/models/shipit/application_record.rb +2 -1
  87. data/app/models/shipit/check_run.rb +41 -4
  88. data/app/models/shipit/command_line_user.rb +5 -0
  89. data/app/models/shipit/commit.rb +42 -24
  90. data/app/models/shipit/commit_checks.rb +15 -13
  91. data/app/models/shipit/commit_deployment.rb +6 -5
  92. data/app/models/shipit/commit_deployment_status.rb +5 -4
  93. data/app/models/shipit/commit_message.rb +1 -0
  94. data/app/models/shipit/delivery.rb +4 -3
  95. data/app/models/shipit/deploy.rb +23 -28
  96. data/app/models/shipit/deploy_spec.rb +38 -7
  97. data/app/models/shipit/deploy_spec/bundler_discovery.rb +1 -0
  98. data/app/models/shipit/deploy_spec/capistrano_discovery.rb +1 -0
  99. data/app/models/shipit/deploy_spec/file_system.rb +20 -7
  100. data/app/models/shipit/deploy_spec/kubernetes_discovery.rb +1 -0
  101. data/app/models/shipit/deploy_spec/lerna_discovery.rb +13 -4
  102. data/app/models/shipit/deploy_spec/npm_discovery.rb +5 -4
  103. data/app/models/shipit/deploy_spec/pypi_discovery.rb +1 -0
  104. data/app/models/shipit/deploy_spec/rubygems_discovery.rb +1 -0
  105. data/app/models/shipit/deploy_stats.rb +2 -1
  106. data/app/models/shipit/duration.rb +5 -2
  107. data/app/models/shipit/ephemeral_commit_checks.rb +1 -0
  108. data/app/models/shipit/github_hook.rb +2 -1
  109. data/app/models/shipit/github_status.rb +2 -1
  110. data/app/models/shipit/hook.rb +34 -7
  111. data/app/models/shipit/membership.rb +3 -2
  112. data/app/models/shipit/merge_request.rb +304 -0
  113. data/app/models/shipit/output_chunk.rb +7 -2
  114. data/app/models/shipit/provisioning_handler.rb +32 -0
  115. data/app/models/shipit/provisioning_handler/base.rb +30 -0
  116. data/app/models/shipit/provisioning_handler/unregistered_provisioning_handler.rb +35 -0
  117. data/app/models/shipit/pull_request.rb +28 -266
  118. data/app/models/shipit/pull_request_assignment.rb +10 -0
  119. data/app/models/shipit/record.rb +18 -0
  120. data/app/models/shipit/release_status.rb +4 -3
  121. data/app/models/shipit/repository.rb +71 -6
  122. data/app/models/shipit/review_stack.rb +130 -0
  123. data/app/models/shipit/review_stack_provisioning_queue.rb +39 -0
  124. data/app/models/shipit/rollback.rb +1 -0
  125. data/app/models/shipit/stack.rb +144 -44
  126. data/app/models/shipit/status.rb +3 -2
  127. data/app/models/shipit/status/common.rb +7 -6
  128. data/app/models/shipit/status/group.rb +2 -1
  129. data/app/models/shipit/status/missing.rb +2 -1
  130. data/app/models/shipit/status/unknown.rb +2 -1
  131. data/app/models/shipit/task.rb +98 -12
  132. data/app/models/shipit/task_definition.rb +1 -0
  133. data/app/models/shipit/task_execution_strategy/base.rb +20 -0
  134. data/app/models/shipit/task_execution_strategy/default.rb +109 -0
  135. data/app/models/shipit/team.rb +6 -3
  136. data/app/models/shipit/undeployed_commit.rb +1 -0
  137. data/app/models/shipit/unlimited_api_client.rb +1 -0
  138. data/app/models/shipit/user.rb +19 -8
  139. data/app/models/shipit/variable_definition.rb +1 -0
  140. data/app/models/shipit/webhooks.rb +11 -0
  141. data/app/models/shipit/webhooks/handlers/check_suite_handler.rb +1 -0
  142. data/app/models/shipit/webhooks/handlers/handler.rb +1 -0
  143. data/app/models/shipit/webhooks/handlers/membership_handler.rb +1 -0
  144. data/app/models/shipit/webhooks/handlers/pull_request/assigned_handler.rb +74 -0
  145. data/app/models/shipit/webhooks/handlers/pull_request/closed_handler.rb +68 -0
  146. data/app/models/shipit/webhooks/handlers/pull_request/edited_handler.rb +74 -0
  147. data/app/models/shipit/webhooks/handlers/pull_request/label_capturing_handler.rb +127 -0
  148. data/app/models/shipit/webhooks/handlers/pull_request/labeled_handler.rb +106 -0
  149. data/app/models/shipit/webhooks/handlers/pull_request/opened_handler.rb +83 -0
  150. data/app/models/shipit/webhooks/handlers/pull_request/reopened_handler.rb +88 -0
  151. data/app/models/shipit/webhooks/handlers/pull_request/review_stack_adapter.rb +103 -0
  152. data/app/models/shipit/webhooks/handlers/pull_request/unlabeled_handler.rb +107 -0
  153. data/app/models/shipit/webhooks/handlers/push_handler.rb +5 -1
  154. data/app/models/shipit/webhooks/handlers/status_handler.rb +1 -0
  155. data/app/serializers/concerns/shipit/conditional_attributes.rb +1 -0
  156. data/app/serializers/shipit/anonymous_user_serializer.rb +1 -0
  157. data/app/serializers/shipit/command_line_user_serializer.rb +1 -0
  158. data/app/serializers/shipit/commit_serializer.rb +1 -0
  159. data/app/serializers/shipit/deploy_serializer.rb +8 -1
  160. data/app/serializers/shipit/hook_serializer.rb +1 -0
  161. data/app/serializers/shipit/merge_request_serializer.rb +21 -0
  162. data/app/serializers/shipit/pull_request_serializer.rb +6 -8
  163. data/app/serializers/shipit/review_stack_serializer.rb +7 -0
  164. data/app/serializers/shipit/rollback_serializer.rb +1 -0
  165. data/app/serializers/shipit/short_commit_serializer.rb +1 -0
  166. data/app/serializers/shipit/stack_serializer.rb +8 -6
  167. data/app/serializers/shipit/tail_task_serializer.rb +11 -2
  168. data/app/serializers/shipit/task_serializer.rb +2 -17
  169. data/app/serializers/shipit/user_serializer.rb +6 -1
  170. data/app/validators/ascii_only_validator.rb +1 -0
  171. data/app/validators/subset_validator.rb +2 -1
  172. data/app/views/layouts/merge_status.html.erb +1 -1
  173. data/app/views/layouts/shipit.html.erb +1 -1
  174. data/app/views/shipit/_variables.html.erb +1 -1
  175. data/app/views/shipit/ccmenu/project.xml.builder +2 -1
  176. data/app/views/shipit/deploys/show.html.erb +2 -2
  177. data/app/views/shipit/merge_requests/_merge_request.html.erb +29 -0
  178. data/app/views/shipit/{pull_requests → merge_requests}/index.html.erb +2 -2
  179. data/app/views/shipit/merge_requests/merge_requests/_pull_request.html.erb +29 -0
  180. data/app/views/shipit/merge_requests/merge_requests/index.html.erb +20 -0
  181. data/app/views/shipit/merge_status/_merge_queue_button.html.erb +3 -3
  182. data/app/views/shipit/merge_status/backlogged.html.erb +1 -1
  183. data/app/views/shipit/merge_status/failure.html.erb +1 -1
  184. data/app/views/shipit/merge_status/locked.html.erb +1 -1
  185. data/app/views/shipit/merge_status/success.html.erb +2 -2
  186. data/app/views/shipit/repositories/_header.html.erb +19 -0
  187. data/app/views/shipit/repositories/index.html.erb +31 -0
  188. data/app/views/shipit/repositories/new.html.erb +23 -0
  189. data/app/views/shipit/repositories/settings.html.erb +53 -0
  190. data/app/views/shipit/repositories/show.html.erb +30 -0
  191. data/app/views/shipit/stacks/_banners.html.erb +15 -1
  192. data/app/views/shipit/stacks/_header.html.erb +20 -7
  193. data/app/views/shipit/stacks/_stack.html.erb +8 -0
  194. data/app/views/shipit/stacks/all_tasks.html.erb +28 -0
  195. data/app/views/shipit/stacks/index.html.erb +3 -2
  196. data/app/views/shipit/stacks/new.html.erb +1 -1
  197. data/app/views/shipit/stacks/settings.html.erb +5 -5
  198. data/app/views/shipit/stacks/show.html.erb +1 -1
  199. data/app/views/shipit/tasks/_task_output.html.erb +1 -1
  200. data/app/views/shipit/tasks/show.html.erb +1 -1
  201. data/config/initializers/inflections.rb +2 -1
  202. data/config/locales/en.yml +4 -3
  203. data/config/routes.rb +25 -7
  204. data/config/secrets.development.example.yml +24 -0
  205. data/config/secrets.development.shopify.yml +20 -9
  206. data/db/migrate/20200226211925_add_index_to_tasks_status.rb +5 -0
  207. data/db/migrate/20200427135152_add_pull_request_head_sha_to_commit.rb +5 -0
  208. data/db/migrate/20200615181558_add_rollback_once_aborted_to.rb +5 -0
  209. data/db/migrate/20200706145406_add_review_stacks.rb +12 -0
  210. data/db/migrate/20200804144639_rename_pull_request_to_merge_request.rb +7 -0
  211. data/db/migrate/20200804161512_rename_commits_pull_request_id_to_merge_request_id.rb +5 -0
  212. data/db/migrate/20200813134712_recreate_shipit_pull_requests.rb +22 -0
  213. data/db/migrate/20200813194056_create_pull_request_assignments.rb +8 -0
  214. data/db/migrate/20201001125502_add_provision_pr_stacks_flag_to_repositories.rb +7 -0
  215. data/db/migrate/20201008145809_add_retry_attempt_to_tasks.rb +5 -0
  216. data/db/migrate/20201008152744_add_max_retries_to_tasks.rb +5 -0
  217. data/db/migrate/20210325194053_remove_stacks_branch_default.rb +5 -0
  218. data/db/migrate/20210504200438_add_github_updated_at_to_check_runs.rb +5 -0
  219. data/lib/shipit.rb +61 -17
  220. data/lib/shipit/cast_value.rb +1 -0
  221. data/lib/shipit/command.rb +20 -21
  222. data/lib/shipit/commands.rb +14 -6
  223. data/lib/shipit/csv_serializer.rb +1 -0
  224. data/lib/shipit/deploy_commands.rb +1 -0
  225. data/lib/shipit/engine.rb +9 -2
  226. data/lib/shipit/environment_variables.rb +11 -1
  227. data/lib/shipit/first_parent_commits_iterator.rb +1 -0
  228. data/lib/shipit/flock.rb +9 -1
  229. data/lib/shipit/github_app.rb +15 -12
  230. data/lib/shipit/github_http_cache_middleware.rb +1 -0
  231. data/lib/shipit/null_serializer.rb +1 -0
  232. data/lib/shipit/octokit_check_runs.rb +3 -2
  233. data/lib/shipit/octokit_iterator.rb +4 -3
  234. data/lib/shipit/paginator.rb +3 -2
  235. data/lib/shipit/review_stack_commands.rb +8 -0
  236. data/lib/shipit/rollback_commands.rb +1 -0
  237. data/lib/shipit/same_site_cookie_middleware.rb +29 -0
  238. data/lib/shipit/simple_message_verifier.rb +3 -2
  239. data/lib/shipit/stack_commands.rb +37 -7
  240. data/lib/shipit/stat.rb +1 -0
  241. data/lib/shipit/task_commands.rb +23 -16
  242. data/lib/shipit/version.rb +2 -1
  243. data/lib/snippets/publish-lerna-independent-packages +35 -34
  244. data/lib/snippets/publish-lerna-independent-packages-legacy +39 -0
  245. data/lib/snippets/release-gem +5 -1
  246. data/lib/tasks/cron.rake +13 -2
  247. data/lib/tasks/dev.rake +3 -2
  248. data/lib/tasks/shipit.rake +15 -14
  249. data/lib/tasks/teams.rake +1 -0
  250. data/test/controllers/api/base_controller_test.rb +3 -2
  251. data/test/controllers/api/ccmenu_controller_test.rb +9 -8
  252. data/test/controllers/api/commits_controller_test.rb +3 -2
  253. data/test/controllers/api/deploys_controller_test.rb +32 -14
  254. data/test/controllers/api/hooks_controller_test.rb +8 -7
  255. data/test/controllers/api/locks_controller_test.rb +7 -6
  256. data/test/controllers/api/{pull_requests_controller_test.rb → merge_requests_controller_test.rb} +17 -16
  257. data/test/controllers/api/outputs_controller_test.rb +3 -1
  258. data/test/controllers/api/release_statuses_controller_test.rb +2 -1
  259. data/test/controllers/api/rollback_controller_test.rb +113 -0
  260. data/test/controllers/api/stacks_controller_test.rb +71 -16
  261. data/test/controllers/api/tasks_controller_test.rb +13 -12
  262. data/test/controllers/api_clients_controller_test.rb +5 -4
  263. data/test/controllers/ccmenu_controller_test.rb +4 -3
  264. data/test/controllers/commit_checks_controller_test.rb +4 -3
  265. data/test/controllers/commits_controller_test.rb +3 -2
  266. data/test/controllers/deploys_controller_test.rb +32 -21
  267. data/test/controllers/github_authentication_controller_test.rb +1 -0
  268. data/test/controllers/merge_requests_controller_test.rb +32 -0
  269. data/test/controllers/merge_status_controller_test.rb +7 -6
  270. data/test/controllers/release_statuses_controller_test.rb +3 -2
  271. data/test/controllers/repositories_controller_test.rb +71 -0
  272. data/test/controllers/rollbacks_controller_test.rb +9 -8
  273. data/test/controllers/stacks_controller_test.rb +41 -19
  274. data/test/controllers/status_controller_test.rb +1 -0
  275. data/test/controllers/tasks_controller_test.rb +32 -19
  276. data/test/controllers/webhooks_controller_test.rb +33 -17
  277. data/test/dummy/app/assets/config/manifest.js +3 -0
  278. data/test/dummy/config/application.rb +7 -2
  279. data/test/dummy/config/database.yml +9 -0
  280. data/test/dummy/config/environments/development.rb +3 -4
  281. data/test/dummy/config/environments/test.rb +2 -5
  282. data/test/dummy/config/secrets_double_github_app.yml +79 -0
  283. data/test/dummy/db/schema.rb +59 -17
  284. data/test/dummy/db/seeds.rb +2 -1
  285. data/test/fixtures/payloads/check_suite_master.json +4 -32
  286. data/test/fixtures/payloads/invalid_pull_request.json +117 -0
  287. data/test/fixtures/payloads/provision_disabled_pull_request.json +454 -0
  288. data/test/fixtures/payloads/pull_request_assigned.json +480 -0
  289. data/test/fixtures/payloads/pull_request_closed.json +454 -0
  290. data/test/fixtures/payloads/pull_request_labeled.json +461 -0
  291. data/test/fixtures/payloads/pull_request_opened.json +454 -0
  292. data/test/fixtures/payloads/pull_request_reopened.json +454 -0
  293. data/test/fixtures/payloads/pull_request_unlabeled.json +454 -0
  294. data/test/fixtures/payloads/pull_request_with_no_repo.json +454 -0
  295. data/test/fixtures/payloads/push_master.json +1 -1
  296. data/test/fixtures/payloads/push_not_master.json +1 -1
  297. data/test/fixtures/shipit/commits.yml +31 -3
  298. data/test/fixtures/shipit/hooks.yml +1 -0
  299. data/test/fixtures/shipit/merge_requests.yml +141 -0
  300. data/test/fixtures/shipit/pull_request_assignments.yml +3 -0
  301. data/test/fixtures/shipit/pull_requests.yml +10 -131
  302. data/test/fixtures/shipit/repositories.yml +5 -0
  303. data/test/fixtures/shipit/stacks.yml +235 -14
  304. data/test/fixtures/shipit/statuses.yml +9 -0
  305. data/test/fixtures/shipit/tasks.yml +4 -1
  306. data/test/fixtures/shipit/users.yml +7 -0
  307. data/test/fixtures/timeout +2 -1
  308. data/test/helpers/api_helper.rb +1 -0
  309. data/test/helpers/fixture_aliases_helper.rb +1 -0
  310. data/test/helpers/hooks_helper.rb +2 -1
  311. data/test/helpers/json_helper.rb +20 -12
  312. data/test/helpers/links_helper.rb +4 -3
  313. data/test/helpers/payloads_helper.rb +5 -0
  314. data/test/helpers/queries_helper.rb +3 -2
  315. data/test/jobs/cache_deploy_spec_job_test.rb +2 -1
  316. data/test/jobs/chunk_rollup_job_test.rb +16 -1
  317. data/test/jobs/deliver_hook_job_test.rb +1 -0
  318. data/test/jobs/destroy_repository_job_test.rb +27 -0
  319. data/test/jobs/destroy_stack_job_test.rb +1 -0
  320. data/test/jobs/emit_event_job_test.rb +2 -1
  321. data/test/jobs/fetch_commit_stats_job_test.rb +1 -0
  322. data/test/jobs/fetch_deployed_revision_job_test.rb +1 -0
  323. data/test/jobs/github_sync_job_test.rb +3 -1
  324. data/test/jobs/mark_deploy_healthy_job_test.rb +1 -0
  325. data/test/jobs/perform_task_job_test.rb +12 -11
  326. data/test/jobs/{merge_pull_requests_job_test.rb → process_merge_requests_job_test.rb} +19 -18
  327. data/test/jobs/purge_old_deliveries_job_test.rb +1 -0
  328. data/test/jobs/reap_dead_tasks_job_test.rb +68 -0
  329. data/test/jobs/refresh_github_user_job_test.rb +1 -0
  330. data/test/jobs/refresh_status_job_test.rb +1 -0
  331. data/test/jobs/unique_job_test.rb +1 -0
  332. data/test/jobs/update_github_last_deployed_ref_job_test.rb +1 -0
  333. data/test/lib/shipit/deploy_commands_test.rb +16 -0
  334. data/test/lib/shipit/task_commands_test.rb +17 -0
  335. data/test/middleware/same_site_cookie_middleware_test.rb +52 -0
  336. data/test/models/api_client_test.rb +1 -0
  337. data/test/models/commit_checks_test.rb +1 -0
  338. data/test/models/commit_deployment_status_test.rb +4 -3
  339. data/test/models/commit_deployment_test.rb +2 -1
  340. data/test/models/commits_test.rb +96 -19
  341. data/test/models/delivery_test.rb +2 -1
  342. data/test/models/deploy_spec_test.rb +110 -65
  343. data/test/models/deploy_stats_test.rb +1 -0
  344. data/test/models/deploys_test.rb +197 -36
  345. data/test/models/duration_test.rb +1 -0
  346. data/test/models/github_hook_test.rb +1 -0
  347. data/test/models/hook_test.rb +47 -10
  348. data/test/models/membership_test.rb +1 -0
  349. data/test/models/{pull_request_test.rb → merge_request_test.rb} +53 -37
  350. data/test/models/pull_request_assignment_test.rb +16 -0
  351. data/test/models/release_statuses_test.rb +1 -0
  352. data/test/models/rollbacks_test.rb +1 -0
  353. data/test/models/shipit/check_run_test.rb +125 -5
  354. data/test/models/shipit/provisioning_handler/base_test.rb +33 -0
  355. data/test/models/shipit/provisioning_handler/unregistered_provisioning_handler_test.rb +49 -0
  356. data/test/models/shipit/provisioning_handler_test.rb +64 -0
  357. data/test/models/shipit/pull_request_test.rb +52 -0
  358. data/test/models/shipit/repository_test.rb +6 -1
  359. data/test/models/shipit/review_stack_provision_status_test.rb +77 -0
  360. data/test/models/shipit/review_stack_provisioning_queue_test.rb +63 -0
  361. data/test/models/shipit/review_stack_test.rb +91 -0
  362. data/test/models/{stacks_test.rb → shipit/stacks_test.rb} +121 -16
  363. data/test/models/shipit/webhooks/handlers/pull_request/assigned_handler_test.rb +45 -0
  364. data/test/models/shipit/webhooks/handlers/pull_request/closed_handler_test.rb +192 -0
  365. data/test/models/shipit/webhooks/handlers/pull_request/edited_handler_test.rb +47 -0
  366. data/test/models/shipit/webhooks/handlers/pull_request/label_capturing_handler_test.rb +209 -0
  367. data/test/models/shipit/webhooks/handlers/pull_request/labeled_handler_test.rb +332 -0
  368. data/test/models/shipit/webhooks/handlers/pull_request/opened_handler_test.rb +238 -0
  369. data/test/models/shipit/webhooks/handlers/pull_request/reopened_handler_test.rb +282 -0
  370. data/test/models/shipit/webhooks/handlers/pull_request/review_stack_adapter_test.rb +107 -0
  371. data/test/models/shipit/webhooks/handlers/pull_request/unlabeled_handler_test.rb +324 -0
  372. data/test/models/shipit/{wehbooks → webhooks}/handlers_test.rb +1 -0
  373. data/test/models/status/group_test.rb +1 -0
  374. data/test/models/status/missing_test.rb +1 -0
  375. data/test/models/status_test.rb +1 -0
  376. data/test/models/task_definitions_test.rb +9 -8
  377. data/test/models/tasks_test.rb +81 -1
  378. data/test/models/team_test.rb +4 -2
  379. data/test/models/undeployed_commits_test.rb +1 -0
  380. data/test/models/users_test.rb +13 -5
  381. data/test/serializers/shipit/pull_request_serializer_test.rb +29 -0
  382. data/test/test_command_integration.rb +3 -2
  383. data/test/test_helper.rb +49 -31
  384. data/test/unit/anonymous_user_serializer_test.rb +14 -0
  385. data/test/unit/command_test.rb +16 -10
  386. data/test/unit/commands_test.rb +1 -0
  387. data/test/unit/commit_serializer_test.rb +16 -0
  388. data/test/unit/csv_serializer_test.rb +3 -2
  389. data/test/unit/deploy_commands_test.rb +75 -18
  390. data/test/unit/deploy_serializer_test.rb +17 -0
  391. data/test/unit/environment_variables_test.rb +5 -4
  392. data/test/unit/github_app_test.rb +3 -3
  393. data/test/unit/github_apps_test.rb +416 -0
  394. data/test/unit/github_url_helper_test.rb +6 -0
  395. data/test/unit/rollback_commands_test.rb +2 -1
  396. data/test/unit/shipit_deployment_checks_test.rb +77 -0
  397. data/test/unit/shipit_helper_test.rb +17 -0
  398. data/test/unit/shipit_task_execution_strategy_test.rb +47 -0
  399. data/test/unit/shipit_test.rb +15 -0
  400. data/test/unit/user_serializer_test.rb +14 -0
  401. data/test/unit/variable_definition_test.rb +1 -0
  402. metadata +320 -178
  403. data/app/controllers/shipit/api/pull_requests_controller.rb +0 -36
  404. data/app/controllers/shipit/pull_requests_controller.rb +0 -30
  405. data/app/jobs/shipit/merge_pull_requests_job.rb +0 -31
  406. data/app/jobs/shipit/refresh_pull_request_job.rb +0 -10
  407. data/app/views/shipit/pull_requests/_pull_request.html.erb +0 -29
  408. data/test/controllers/pull_requests_controller_test.rb +0 -31
  409. data/test/fixtures/shipit/output_chunks.yml +0 -47
  410. data/test/models/output_chunk_test.rb +0 -20
@@ -134,3 +134,12 @@ canaries_fifth_success:
134
134
  created_at: <%= 7.days.ago.to_s(:db) %>
135
135
  state: success
136
136
  target_url: "http://www.example.com"
137
+
138
+ review_stack_commit_success:
139
+ stack: review_stack
140
+ commit_id: 801
141
+ description: lets go
142
+ context: ci/travis
143
+ created_at: <%= 10.days.ago.to_s(:db) %>
144
+ state: success
145
+ target_url: "http://www.example.com"
@@ -11,6 +11,7 @@ shipit:
11
11
  created_at: <%= (60 - 1).minutes.ago.to_s(:db) %>
12
12
  started_at: <%= (60 - 1).minutes.ago.to_s(:db) %>
13
13
  ended_at: <%= (60 - 6).minutes.ago.to_s(:db) %>
14
+ max_retries: 3
14
15
 
15
16
  shipit2:
16
17
  id: 2
@@ -28,7 +29,7 @@ shipit2:
28
29
 
29
30
  shipit_restart:
30
31
  id: 3
31
- user: walrus
32
+ user: ~
32
33
  type: Shipit::Task
33
34
  stack: shipit
34
35
  status: success
@@ -60,6 +61,8 @@ shipit_pending:
60
61
  deletions: 406
61
62
  created_at: <%= (60 - 4).minutes.ago.to_s(:db) %>
62
63
  allow_concurrency: true
64
+ max_retries: 1
65
+ retry_attempt: 0
63
66
 
64
67
  shipit_running:
65
68
  id: 5
@@ -5,6 +5,13 @@ walrus:
5
5
  encrypted_github_access_token: "ffHk4diyVKppJGfwfJefMizxF45H\n" # t0k3n
6
6
  encrypted_github_access_token_iv: "gRSldoTZ+fmrIDoY\n"
7
7
 
8
+ codertocat:
9
+ name: Coding Cat
10
+ email: coding@cat.com
11
+ login: Codertocat
12
+ encrypted_github_access_token: "ffHk4diyVKppJGfwfJefMizxF45H\n" # t0k3n
13
+ encrypted_github_access_token_iv: "gRSldoTZ+fmrIDoY\n"
14
+
8
15
  bob:
9
16
  name: Bob the Builder
10
17
  email: bob@bob.com
@@ -1,4 +1,5 @@
1
1
  #!/usr/bin/env ruby
2
+ # frozen_string_literal: true
2
3
 
3
4
  trap('INT') do
4
5
  puts "Recieved SIGINT, aborting."
@@ -11,5 +12,5 @@ trap('TERM') do
11
12
  end
12
13
 
13
14
  puts "Sleeping for 10 seconds"
14
- sleep 10
15
+ sleep(10)
15
16
  puts "I wasn't killed? WTF"
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  module ApiHelper
2
3
  private
3
4
 
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  module FixtureAliasesHelper
2
3
  def shipit_deploys(*args)
3
4
  shipit_tasks(*args)
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  module HooksHelper
2
3
  def expect_hook(event, stack = nil, payload = nil)
3
4
  spy_on_hook
@@ -24,7 +25,7 @@ module HooksHelper
24
25
  end
25
26
  matcher = args.map(&:inspect).join(', ')
26
27
  got = called&.args&.map(&:inspect)&.join(', ')
27
- refute called, "Expected no hook matching: (#{matcher})\n got: (#{got})"
28
+ refute(called, "Expected no hook matching: (#{matcher})\n got: (#{got})")
28
29
  end
29
30
 
30
31
  private
@@ -1,29 +1,37 @@
1
+ # frozen_string_literal: true
1
2
  module JSONHelper
2
3
  UNDEFINED = Object.new.freeze
3
4
  private_constant :UNDEFINED
4
5
 
5
- def assert_json(path = nil, expected_value = UNDEFINED, document: response.body)
6
+ def assert_json(path = nil, expected_value = UNDEFINED, &block)
7
+ assert_json_document(response.body, path, expected_value, &block)
8
+ end
9
+
10
+ def assert_json_document(document, path, expected_value = UNDEFINED)
6
11
  value = follow_path(path.to_s.split('.'), document: document)
7
12
  if block_given?
8
13
  yield value
9
14
  elsif expected_value == UNDEFINED
10
15
  raise ArgumentError, "Missing either expected_value or a block"
11
16
  elsif expected_value.nil?
12
- assert_nil value
17
+ assert_nil(value)
13
18
  else
14
- assert_equal expected_value, value
19
+ assert_equal(expected_value, value)
15
20
  end
16
21
  end
17
22
 
18
23
  def assert_json_keys(path, keys = nil, document: response.body)
19
- keys, path = path, nil if keys.nil?
24
+ if keys.nil?
25
+ keys = path
26
+ path = nil
27
+ end
20
28
 
21
29
  value = follow_path(path.to_s.split('.'), document: document)
22
30
  case value
23
31
  when Hash
24
- assert_equal keys.sort, value.keys.sort
32
+ assert_equal(keys.sort, value.keys.sort)
25
33
  else
26
- assert false, "Expected #{path} to be a Hash, was: #{value.inspect}"
34
+ assert(false, "Expected #{path} to be a Hash, was: #{value.inspect}")
27
35
  end
28
36
  end
29
37
 
@@ -33,11 +41,11 @@ module JSONHelper
33
41
  leaf = follow_path(segments, document: document)
34
42
  case leaf
35
43
  when Hash
36
- refute leaf.key?(last_segment), "Expected #{leaf.inspect} not to include #{last_segment.inspect}"
44
+ refute(leaf.key?(last_segment), "Expected #{leaf.inspect} not to include #{last_segment.inspect}")
37
45
  when Array
38
- refute leaf.size > last_segment.to_i, "Expected #{leaf.inspect} to not have element at index #{last_segment.to_i}"
46
+ refute(leaf.size > last_segment.to_i, "Expected #{leaf.inspect} to not have element at index #{last_segment.to_i}")
39
47
  else
40
- assert false, "Expected #{leaf.inspect} to be a Hash or Array"
48
+ assert(false, "Expected #{leaf.inspect} to be a Hash or Array")
41
49
  end
42
50
  end
43
51
 
@@ -48,13 +56,13 @@ module JSONHelper
48
56
  segments.inject(parsed_json) do |object, key|
49
57
  case object
50
58
  when Hash
51
- assert_includes object, key
59
+ assert_includes(object, key)
52
60
  object[key]
53
61
  when Array
54
- assert object.size > key.to_i, "#{object.inspect} have no property #{key}"
62
+ assert(object.size > key.to_i, "#{object.inspect} have no property #{key}")
55
63
  object[key.to_i]
56
64
  else
57
- assert false, "Expected #{object.inspect} to be a Hash or Array"
65
+ assert(false, "Expected #{object.inspect} to be a Hash or Array")
58
66
  end
59
67
  end
60
68
  end
@@ -1,13 +1,14 @@
1
+ # frozen_string_literal: true
1
2
  module LinksHelper
2
3
  LINKS_PATTERN = /\<(.*?)\>; rel="(\w+)"/
3
4
 
4
5
  def assert_link(rel, url)
5
- assert_includes response_links, rel
6
- assert_equal url, response_links[rel], %(rel="#{rel}" is incorrect)
6
+ assert_includes(response_links, rel)
7
+ assert_equal(url, response_links[rel], %(rel="#{rel}" is incorrect))
7
8
  end
8
9
 
9
10
  def assert_no_link(rel)
10
- assert_nil response_links[rel], %(expected rel="#{rel}" to be nil)
11
+ assert_nil(response_links[rel], %(expected rel="#{rel}" to be nil))
11
12
  end
12
13
 
13
14
  private
@@ -1,5 +1,10 @@
1
+ # frozen_string_literal: true
1
2
  module PayloadsHelper
2
3
  def payload(name)
3
4
  Shipit::Engine.root.join('test/fixtures/payloads', "#{name}.json").read
4
5
  end
6
+
7
+ def payload_parsed(name)
8
+ JSON.parse(payload(name))
9
+ end
5
10
  end
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  module QueriesHelper
2
3
  def assert_no_queries(ignored_sql = nil, &block)
3
4
  assert_queries(0, ignored_sql, &block)
@@ -8,7 +9,7 @@ module QueriesHelper
8
9
  subscriber = ActiveSupport::Notifications.subscribe('sql.active_record', counter)
9
10
  yield counter
10
11
  queries = counter.log.empty? ? '' : "\nQueries:\n#{counter.log.join("\n")}"
11
- assert_equal num, counter.log.size, "#{counter.log.size} instead of #{num} queries were executed.#{queries}"
12
+ assert_equal(num, counter.log.size, "#{counter.log.size} instead of #{num} queries were executed.#{queries}")
12
13
  ensure
13
14
  ActiveSupport::Notifications.unsubscribe(subscriber)
14
15
  end
@@ -35,7 +36,7 @@ module QueriesHelper
35
36
 
36
37
  # FIXME: this needs to be refactored so specific database can add their own
37
38
  # ignored SQL. This ignored SQL is for Oracle.
38
- ignored_sql.concat [/^select .*nextval/i, /^SAVEPOINT/, /^ROLLBACK TO/, /^\s*select .* from all_triggers/im]
39
+ ignored_sql.concat([/^select .*nextval/i, /^SAVEPOINT/, /^ROLLBACK TO/, /^\s*select .* from all_triggers/im])
39
40
 
40
41
  attr_reader :ignore
41
42
  attr_reader :log
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  require 'test_helper'
2
3
 
3
4
  module Shipit
@@ -9,7 +10,7 @@ module Shipit
9
10
  end
10
11
 
11
12
  test "#perform checkout the repository to the last recorded commit and cache the deploy spec" do
12
- @stack.update!(cached_deploy_spec: DeploySpec.new('review' => {'checklist' => %w(foo bar)}))
13
+ @stack.update!(cached_deploy_spec: DeploySpec.new('review' => { 'checklist' => %w(foo bar) }))
13
14
 
14
15
  dir = Pathname(Dir.tmpdir)
15
16
  StackCommands.any_instance.expects(:with_temporary_working_directory).with(commit: @last_commit).yields(dir)
@@ -1,9 +1,11 @@
1
+ # frozen_string_literal: true
1
2
  require 'test_helper'
2
3
 
3
4
  module Shipit
4
5
  class ChunkRollupJobTest < ActiveSupport::TestCase
5
6
  setup do
6
7
  @task = shipit_tasks(:shipit)
8
+ @task.write("dummy output")
7
9
  @job = ChunkRollupJob.new
8
10
  end
9
11
 
@@ -14,10 +16,10 @@ module Shipit
14
16
  @job.perform(@task)
15
17
 
16
18
  @task.reload
17
- assert_equal 0, @task.chunks.count
18
19
  assert @task.output.present?
19
20
  assert_equal expected_output, @task.chunk_output
20
21
  assert @task.rolled_up
22
+ assert_nil Shipit.redis.get(@task.send(:output_key))
21
23
  end
22
24
 
23
25
  test "#peform ignores non-finished jobs" do
@@ -39,5 +41,18 @@ module Shipit
39
41
 
40
42
  @job.perform(@task)
41
43
  end
44
+
45
+ test "#perform takes into account data still in the DB" do
46
+ output_chunks = Shipit::OutputChunk.create(text: "DB output", task: @task)
47
+ expected_output = [output_chunks.text, @task.chunk_output].join("\n")
48
+
49
+ @job.perform(@task)
50
+
51
+ @task.reload
52
+ assert_equal expected_output, @task.chunk_output
53
+ assert @task.rolled_up
54
+ assert_empty Shipit::OutputChunk.where(task: @task)
55
+ assert_nil Shipit.redis.get(@task.send(:output_key))
56
+ end
42
57
  end
43
58
  end
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  require 'test_helper'
2
3
 
3
4
  module Shipit
@@ -0,0 +1,27 @@
1
+ # frozen_string_literal: true
2
+ require 'test_helper'
3
+
4
+ module Shipit
5
+ class DestroyRepositoryJobTest < ActiveSupport::TestCase
6
+ setup do
7
+ @job = DestroyRepositoryJob.new
8
+ @repository = Repository.first
9
+ end
10
+
11
+ test "perform destroys the repository" do
12
+ assert_difference -> { Repository.count }, -1 do
13
+ @job.perform(@repository)
14
+ end
15
+ end
16
+
17
+ test "perform destroys the repository's stacks" do
18
+ stack = Stack.first
19
+ Shipit.github.api.expects(:remove_hook).times(stack.github_hooks.count)
20
+ @repository.stacks << stack
21
+
22
+ assert_difference -> { Stack.count }, -@repository.stacks.size do
23
+ @job.perform(@repository)
24
+ end
25
+ end
26
+ end
27
+ end
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  require 'test_helper'
2
3
 
3
4
  module Shipit
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  require 'test_helper'
2
3
 
3
4
  module Shipit
@@ -9,7 +10,7 @@ module Shipit
9
10
 
10
11
  test "#perform schedule deliveries" do
11
12
  assert_enqueued_jobs(2, only: DeliverHookJob) do
12
- @job.perform(event: :deploy, stack_id: @stack.id, payload: {foo: 42}.to_json)
13
+ @job.perform(event: :deploy, stack_id: @stack.id, payload: { foo: 42 }.to_json)
13
14
  end
14
15
  end
15
16
  end
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  require 'test_helper'
2
3
 
3
4
  module Shipit
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  require 'test_helper'
2
3
 
3
4
  module Shipit
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  require 'test_helper'
2
3
 
3
4
  module Shipit
@@ -90,7 +91,7 @@ module Shipit
90
91
  last = stub(sha: 123)
91
92
  first = stub(sha: 345)
92
93
  Shipit::FirstParentCommitsIterator.any_instance.stubs(:each).multiple_yields(last, first)
93
- @job.stubs(lookup_commit: nil)
94
+ @job.stubs(lookup_commit: nil, stack: @stack)
94
95
 
95
96
  commits, parent = @job.fetch_missing_commits { stub }
96
97
  assert_nil parent
@@ -103,6 +104,7 @@ module Shipit
103
104
  Shipit::FirstParentCommitsIterator.any_instance.stubs(:each).multiple_yields(last, first)
104
105
  @job.stubs(:lookup_commit).with(123).returns(nil)
105
106
  @job.stubs(:lookup_commit).with(345).returns(first)
107
+ @job.stubs(stack: @stack)
106
108
 
107
109
  commits, parent = @job.fetch_missing_commits { stub }
108
110
  assert_equal first, parent
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  require 'test_helper'
2
3
 
3
4
  module Shipit
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  require 'test_helper'
2
3
 
3
4
  module Shipit
@@ -18,9 +19,9 @@ module Shipit
18
19
  end
19
20
 
20
21
  test "#perform fetch commits from the API" do
21
- @job.stubs(:capture!)
22
- @job.stubs(:capture)
23
- @commands = stub(:commands)
22
+ Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture!)
23
+ Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture)
24
+ @commands = stub
24
25
  Commands.expects(:for).with(@deploy).returns(@commands)
25
26
 
26
27
  @commands.expects(:fetched?).once.returns(FakeSuccessfulCommand.new)
@@ -38,7 +39,7 @@ module Shipit
38
39
  @deploy.stack.expects(:release_status?).at_least_once.returns(false)
39
40
  Dir.stubs(:chdir).yields
40
41
  DeployCommands.any_instance.expects(:perform).returns([])
41
- @job.stubs(:capture!)
42
+ Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture!)
42
43
 
43
44
  assert_enqueued_with(job: FetchDeployedRevisionJob, args: [@deploy.stack]) do
44
45
  @job.perform(@deploy)
@@ -49,7 +50,7 @@ module Shipit
49
50
  @deploy.stack.expects(:release_status?).at_least_once.returns(false)
50
51
  Dir.stubs(:chdir).yields
51
52
  DeployCommands.any_instance.expects(:perform).returns([])
52
- @job.stubs(:capture!)
53
+ Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture!)
53
54
 
54
55
  assert_equal 'pending', @deploy.status
55
56
  @job.perform(@deploy)
@@ -62,7 +63,7 @@ module Shipit
62
63
 
63
64
  Dir.stubs(:chdir).yields
64
65
  DeployCommands.any_instance.expects(:perform).returns([])
65
- @job.stubs(:capture!)
66
+ Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture!)
66
67
 
67
68
  assert_equal 'pending', @deploy.status
68
69
  @job.perform(@deploy)
@@ -76,7 +77,7 @@ module Shipit
76
77
 
77
78
  Dir.stubs(:chdir).yields
78
79
  DeployCommands.any_instance.expects(:perform).returns([])
79
- @job.stubs(:capture!)
80
+ Shipit::TaskExecutionStrategy::Default.any_instance.stubs(:capture!)
80
81
 
81
82
  assert_equal 'pending', @deploy.status
82
83
  @job.perform(@deploy)
@@ -84,7 +85,7 @@ module Shipit
84
85
  end
85
86
 
86
87
  test "marks deploy as `error` if any application error is raised" do
87
- @job.expects(:capture!).raises("some error")
88
+ Shipit::TaskExecutionStrategy::Default.any_instance.expects(:capture!).raises("some error")
88
89
  assert_nothing_raised do
89
90
  @job.perform(@deploy)
90
91
  end
@@ -93,7 +94,7 @@ module Shipit
93
94
  end
94
95
 
95
96
  test "marks deploy as `failed` if a command exit with an error code" do
96
- @job.expects(:capture!).at_least_once.raises(Command::Error.new('something'))
97
+ Shipit::TaskExecutionStrategy::Default.any_instance.expects(:capture!).at_least_once.raises(Command::Error.new('something'))
97
98
  @job.perform(@deploy)
98
99
  assert_equal 'failed', @deploy.reload.status
99
100
  end
@@ -132,7 +133,7 @@ module Shipit
132
133
 
133
134
  @job.perform(@deploy)
134
135
 
135
- assert_equal 'timedout', @deploy.reload.status
136
+ assert_equal('timedout', @deploy.reload.status)
136
137
  ensure
137
138
  Shipit.timeout_exit_codes = previous_exit_codes
138
139
  end
@@ -140,7 +141,7 @@ module Shipit
140
141
 
141
142
  test "records stack support for rollbacks and fetching deployed revision" do
142
143
  @job.stubs(:capture!)
143
- @commands = stub(:commands)
144
+ @commands = stub
144
145
  @commands.stubs(:fetched?).returns([])
145
146
  @commands.stubs(:fetch).returns([])
146
147
  @commands.stubs(:clone).returns([])