shipit-engine 0.30.0 → 0.34.0

data/test/controllers/github_authentication_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/controllers/merge_requests_controller_test.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+module Shipit
+  class MergeRequestsControllerTest < ActionController::TestCase
+    setup do
+      @stack = shipit_stacks(:shipit)
+      @pr = shipit_merge_requests(:shipit_pending)
+      session[:user_id] = shipit_users(:walrus).id
+    end
+
+    test "#index shows pending pull requests" do
+      get :index, params: { stack_id: @stack.to_param }
+      assert_response :success
+      assert_select '.pr-list .pr', @stack.merge_requests.pending.count
+    end
+
+    test "#add can enqueue a pull request" do
+      assert_difference -> { MergeRequest.count }, +1 do
+        post :create, params: { stack_id: @stack.to_param, number_or_url: '#5' }
+      end
+      assert_redirected_to stack_merge_requests_path(@stack)
+    end
+
+    test "#destroy can cancel a pending pull request" do
+      assert_predicate @pr, :pending?
+      delete :destroy, params: { stack_id: @stack.to_param, id: @pr.id }
+      assert_redirected_to stack_merge_requests_path(@stack)
+      assert_predicate @pr.reload, :canceled?
+    end
+  end
+end

data/test/controllers/merge_status_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -9,27 +10,27 @@ module Shipit
     end
 
     test "GET show" do
-      get :show, params: {referrer: 'https://github.com/Shopify/shipit-engine/pull/42', branch: 'master'}
+      get :show, params: { referrer: 'https://github.com/Shopify/shipit-engine/pull/42', branch: 'master' }
       assert_response :ok
       assert_includes response.body, 'Ready to ship!'
     end
 
     test "GET show when there is no matching stacks" do
-      get :show, params: {referrer: 'https://github.com/Shopify/unknown-repo/pull/42', branch: 'master'}
+      get :show, params: { referrer: 'https://github.com/Shopify/unknown-repo/pull/42', branch: 'master' }
       assert_response :ok
       assert_predicate response.body, :blank?
     end
 
     test "GET anonymous show returns a login message" do
       session.delete(:user_id)
-      get :show, params: {referrer: 'https://github.com/Shopify/shipit-engine/pull/42', branch: 'master'}
+      get :show, params: { referrer: 'https://github.com/Shopify/shipit-engine/pull/42', branch: 'master' }
       assert_response :ok
       assert_includes response.body.downcase, 'please log in'
     end
 
     test "GET anonymous show when there is no matching stack is blank" do
       session.delete(:user_id)
-      get :show, params: {referrer: 'https://github.com/Shopify/unknown-repo/pull/42', branch: 'master'}
+      get :show, params: { referrer: 'https://github.com/Shopify/unknown-repo/pull/42', branch: 'master' }
       assert_response :ok
       assert_predicate response.body, :blank?
     end
@@ -47,7 +48,7 @@ module Shipit
         merge_queue_enabled: true,
       )
 
-      get :show, params: {referrer: 'https://github.com/Shopify/shipit-engine/pull/42', branch: 'master'}
+      get :show, params: { referrer: 'https://github.com/Shopify/shipit-engine/pull/42', branch: 'master' }
       assert_response :ok
       assert_includes response.body, 'shipit-engine/foo'
     end
@@ -66,7 +67,7 @@ module Shipit
         merge_queue_enabled: true,
       )
 
-      get :show, params: {referrer: 'https://github.com/Shopify/shipit-engine/pull/42', branch: 'master'}
+      get :show, params: { referrer: 'https://github.com/Shopify/shipit-engine/pull/42', branch: 'master' }
       assert_response :ok
       assert_includes response.body, 'locked'
     end

data/test/controllers/release_statuses_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -10,7 +11,7 @@ module Shipit
 
     test ":create allow users to append release statuses and mark the deploy as success" do
       assert_difference -> { ReleaseStatus.count }, +1 do
-        post :create, params: {stack_id: @stack, deploy_id: @deploy.id, status: 'success'}
+        post :create, params: { stack_id: @stack, deploy_id: @deploy.id, status: 'success' }
         assert_response :created
       end
 
@@ -23,7 +24,7 @@ module Shipit
 
     test ":create allow users to append release statuses and mark the deploy as faulty" do
       assert_difference -> { ReleaseStatus.count }, +1 do
-        post :create, params: {stack_id: @stack, deploy_id: @deploy.id, status: 'failure'}
+        post :create, params: { stack_id: @stack, deploy_id: @deploy.id, status: 'failure' }
         assert_response :created
       end
 

data/test/controllers/repositories_controller_test.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+module Shipit
+  class RepositoriesControllerTest < ActionController::TestCase
+    setup do
+      @routes = Shipit::Engine.routes
+      @repository = shipit_repositories(:shipit)
+      session[:user_id] = shipit_users(:walrus).id
+    end
+
+    test "GitHub authentication is mandatory" do
+      session[:user_id] = nil
+      get :index
+      assert_redirected_to '/github/auth/github?origin=http%3A%2F%2Ftest.host%2Frepositories'
+    end
+
+    test "current_user must be a member of at least a Shipit.github_teams" do
+      session[:user_id] = shipit_users(:bob).id
+      Shipit.stubs(:github_teams).returns([shipit_teams(:cyclimse_cooks), shipit_teams(:shopify_developers)])
+      get :index
+      assert_response :forbidden
+      assert_equal(
+        'You must be a member of cyclimse/cooks or shopify/developers to access this application.',
+        response.body,
+      )
+    end
+
+    test "#show is success" do
+      get :show, params: { id: @repository.to_param }
+      assert_response :ok
+    end
+
+    test "#create creates a repository and redirects to it" do
+      assert_difference "Repository.count" do
+        post :create, params: {
+          repository: {
+            name: 'valid',
+            owner: 'repository',
+          },
+        }
+      end
+      assert_redirected_to repository_path(Repository.last)
+    end
+
+    test "#create when not valid renders new" do
+      assert_no_difference "Repository.count" do
+        post :create, params: {
+          repository: {
+            owner: 'some',
+            name: 'owner/path',
+          },
+        }
+      end
+      assert_response :success
+    end
+
+    test "#destroy enqueues a DestroyRepositoryJob" do
+      assert_enqueued_with(job: DestroyRepositoryJob, args: [@repository]) do
+        delete :destroy, params: { id: @repository.to_param }
+      end
+
+      assert_redirected_to repositories_path
+    end
+
+    test "#settings is success" do
+      get :settings, params: { id: @repository.to_param }
+      assert_response :success
+    end
+  end
+end

data/test/controllers/rollbacks_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -11,37 +12,37 @@ module Shipit
 
     test ":create persists a new rollback" do
       assert_difference '@stack.rollbacks.count', 1 do
-        post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}}
+        post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id } }
       end
     end
 
     test ":create can receive an :env hash" do
-      env = {'SAFETY_DISABLED' => '1'}
-      post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id, env: env}}
+      env = { 'SAFETY_DISABLED' => '1' }
+      post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id, env: env } }
       new_rollback = Rollback.last
       assert_equal env, new_rollback.env
     end
 
     test ":create ignore :env keys not declared in the deploy spec" do
-      post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id, env: {'H4X0R' => '1'}}}
+      post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id, env: { 'H4X0R' => '1' } } }
       new_rollback = Rollback.last
       assert_equal({}, new_rollback.env)
     end
 
     test ":create redirects to the new deploy" do
-      post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}}
+      post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id } }
       assert_redirected_to stack_deploy_path(@stack, Rollback.last)
     end
 
     test ":create locks deploys" do
-      post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}}
+      post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id } }
       assert @stack.reload.locked?
     end
 
     test ":create redirects back to the :new page if there is an active deploy" do
       shipit_deploys(:shipit_running).update!(allow_concurrency: false, status: 'running')
       assert_no_difference '@stack.deploys.count' do
-        post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}}
+        post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id } }
       end
       assert_redirected_to rollback_stack_deploy_path(@stack, @deploy)
     end
@@ -49,7 +50,7 @@ module Shipit
     test ":create with `force` option ignore the active deploys" do
       shipit_deploys(:shipit_running).update_column(:status, 'running')
       assert_difference '@stack.deploys.count', 1 do
-        post :create, params: {stack_id: @stack.to_param, rollback: {parent_id: @deploy.id}, force: 'true'}
+        post :create, params: { stack_id: @stack.to_param, rollback: { parent_id: @deploy.id }, force: 'true' }
       end
       assert_redirected_to stack_deploy_path(@stack, Rollback.last)
     end

data/test/controllers/stacks_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -46,13 +47,32 @@ module Shipit
       )
     end
 
+    test "#index list all stacks" do
+      get :index, params: { show_archived: true }
+      assert_response :ok
+      assert_select ".stack", count: Stack.count
+    end
+
+    test "#index list all not archived stacks" do
+      get :index
+      assert_response :ok
+      assert_select ".stack", count: Stack.not_archived.count
+    end
+
+    test "#index list a repo stacks if the :repo params is passed" do
+      repo = shipit_repositories(:shipit)
+      get :index, params: { repo: repo.full_name }
+      assert_response :ok
+      assert_select ".stack", count: repo.stacks.count
+    end
+
     test "#show is success" do
-      get :show, params: {id: @stack.to_param}
+      get :show, params: { id: @stack.to_param }
       assert_response :ok
     end
 
     test "#show with faulty and validating deploys is success" do
-      get :show, params: {id: shipit_stacks(:shipit_canaries).to_param}
+      get :show, params: { id: shipit_stacks(:shipit_canaries).to_param }
       assert_response :ok
     end
 
@@ -60,18 +80,18 @@ module Shipit
       @stack = shipit_stacks(:check_runs)
       assert_not_equal 0, CheckRun.where(stack_id: @stack.id).count
 
-      get :show, params: {id: @stack.to_param}
+      get :show, params: { id: @stack.to_param }
       assert_response :ok
     end
 
     test "#show handles locked stacks without a lock_author" do
       @stack.update!(lock_reason: "I am a lock with no author")
-      get :show, params: {id: @stack.to_param}
+      get :show, params: { id: @stack.to_param }
     end
 
     test "#show auto-links URLs in lock reason" do
       @stack.update!(lock_reason: 'http://google.com')
-      get :show, params: {id: @stack.to_param}
+      get :show, params: { id: @stack.to_param }
       assert_response :ok
       assert_select 'a[href="http://google.com"]'
     end
@@ -93,38 +113,38 @@ module Shipit
 
     test "#create when not valid renders new" do
       assert_no_difference "Stack.count" do
-        post :create, params: {stack: {repo_owner: 'some', repo_name: 'owner/path'}}
+        post :create, params: { stack: { repo_owner: 'some', repo_name: 'owner/path' } }
       end
       assert_response :success
     end
 
     test "#destroy enqueues a DestroyStackJob" do
       assert_enqueued_with(job: DestroyStackJob, args: [@stack]) do
-        delete :destroy, params: {id: @stack.to_param}
+        delete :destroy, params: { id: @stack.to_param }
       end
       assert_redirected_to stacks_path
     end
 
     test "#settings is success" do
-      get :settings, params: {id: @stack.to_param}
+      get :settings, params: { id: @stack.to_param }
       assert_response :success
     end
 
     test "#statistics is success" do
-      get :statistics, params: {id: @stack.to_param}
+      get :statistics, params: { id: @stack.to_param }
       assert_response :success
     end
 
     test "#statistics redirects to #show if no deploys are present" do
       @stack.deploys.destroy_all
-      get :statistics, params: {id: @stack.to_param}
+      get :statistics, params: { id: @stack.to_param }
       assert_redirected_to stack_path(@stack)
     end
 
     test "#update allows to lock the stack" do
       refute @stack.locked?
 
-      patch :update, params: {id: @stack.to_param, stack: {lock_reason: 'Went out to eat some chips!'}}
+      patch :update, params: { id: @stack.to_param, stack: { lock_reason: 'Went out to eat some chips!' } }
       @stack.reload
       assert @stack.locked?
       assert_equal shipit_users(:walrus), @stack.lock_author
@@ -134,7 +154,7 @@ module Shipit
       @stack.update!(lock_reason: 'Went out to eat some chips!')
       assert @stack.locked?
 
-      patch :update, params: {id: @stack.to_param, stack: {lock_reason: ''}}
+      patch :update, params: { id: @stack.to_param, stack: { lock_reason: '' } }
       @stack.reload
       refute @stack.locked?
       assert_instance_of AnonymousUser, @stack.lock_author
@@ -144,7 +164,7 @@ module Shipit
       refute @stack.archived?
       refute @stack.locked?
 
-      patch :update, params: {id: @stack.to_param, stack: {archived: "true"}}
+      patch :update, params: { id: @stack.to_param, stack: { archived: "true" } }
       @stack.reload
       assert @stack.archived?
       assert @stack.locked?
@@ -157,10 +177,12 @@ module Shipit
       assert @stack.locked?
       assert @stack.archived?
 
-      patch :update, params: {id: @stack.to_param, stack: {archived: "false"}}
+      patch :update, params: { id: @stack.to_param, stack: { archived: "false" } }
       @stack.reload
       refute @stack.archived?
       refute @stack.locked?
+      assert_nil @stack.locked_since
+      assert_nil @stack.lock_reason
       assert_instance_of AnonymousUser, @stack.lock_author
     end
 
@@ -170,7 +192,7 @@ module Shipit
       assert_enqueued_with(job: RefreshStatusesJob, args: [stack_id: @stack.id]) do
         assert_enqueued_with(job: RefreshCheckRunsJob, args: [stack_id: @stack.id]) do
           assert_enqueued_with(job: GithubSyncJob, args: [stack_id: @stack.id]) do
-            post :refresh, params: {id: @stack.to_param}
+            post :refresh, params: { id: @stack.to_param }
           end
         end
       end
@@ -180,23 +202,23 @@ module Shipit
 
     test "#clear_git_cache queues a ClearGitCacheJob" do
       assert_enqueued_with(job: ClearGitCacheJob, args: [@stack]) do
-        post :clear_git_cache, params: {id: @stack.to_param}
+        post :clear_git_cache, params: { id: @stack.to_param }
       end
       assert_redirected_to stack_settings_path(@stack)
     end
 
     test "#clear_git_cache displays a flash message" do
-      post :clear_git_cache, params: {id: @stack.to_param}
+      post :clear_git_cache, params: { id: @stack.to_param }
       assert_equal 'Git Cache clearing scheduled', flash[:success]
     end
 
     test "#update redirects to return_to parameter" do
-      patch :update, params: {id: @stack.to_param, stack: {ignore_ci: false}, return_to: stack_path(@stack)}
+      patch :update, params: { id: @stack.to_param, stack: { ignore_ci: false }, return_to: stack_path(@stack) }
       assert_redirected_to stack_path(@stack)
     end
 
     test "#lookup redirects to the canonical URL" do
-      get :lookup, params: {id: @stack.id}
+      get :lookup, params: { id: @stack.id }
       assert_redirected_to stack_path(@stack)
     end
 

data/test/controllers/status_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/controllers/tasks_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -11,7 +12,7 @@ module Shipit
     end
 
     test "tasks defined in the shipit.yml can be displayed" do
-      get :new, params: {stack_id: @stack, definition_id: @definition.id}
+      get :new, params: { stack_id: @stack, definition_id: @definition.id }
       assert_response :ok
     end
 
@@ -20,7 +21,7 @@ module Shipit
 
       assert_predicate @stack, :active_task?
       assert_no_difference -> { @stack.tasks.count } do
-        post :create, params: {stack_id: @stack, definition_id: @definition.id}
+        post :create, params: { stack_id: @stack, definition_id: @definition.id }
       end
       assert_redirected_to new_stack_tasks_path(@stack, @definition)
     end
@@ -30,7 +31,7 @@ module Shipit
 
       assert_predicate @stack, :active_task?
       assert_difference -> { @stack.tasks.count } do
-        post :create, params: {stack_id: @stack, definition_id: @definition.id, force: 'true'}
+        post :create, params: { stack_id: @stack, definition_id: @definition.id, force: 'true' }
       end
       assert_redirected_to stack_task_path(@stack, Task.last)
     end
@@ -38,26 +39,26 @@ module Shipit
     test "tasks defined in the shipit.yml can be triggered while the stack is being deployed if specified as such" do
       @definition = @stack.find_task_definition('flush_cache')
       assert_difference -> { @stack.tasks.count } do
-        post :create, params: {stack_id: @stack, definition_id: @definition.id}
+        post :create, params: { stack_id: @stack, definition_id: @definition.id }
       end
       assert_redirected_to stack_task_path(@stack, Task.last)
     end
 
     test "tasks with variables defined in the shipit.yml can be triggered with their variables set" do
-      env = {"FOO" => "0"}
+      env = { "FOO" => "0" }
 
-      post :create, params: {stack_id: @stack, definition_id: @definition.id, task: {env: env}, force: 'true'}
+      post :create, params: { stack_id: @stack, definition_id: @definition.id, task: { env: env }, force: 'true' }
 
       assert_redirected_to stack_tasks_path(@stack, Task.last)
     end
 
     test "triggered tasks can be observed" do
-      get :show, params: {stack_id: @stack, id: @task.id}
+      get :show, params: { stack_id: @stack, id: @task.id }
       assert_response :ok
     end
 
     test "triggered tasks can be observed as raw text" do
-      get :show, params: {stack_id: @stack, id: @task.id}, format: 'txt'
+      get :show, params: { stack_id: @stack, id: @task.id }, format: 'txt'
       assert_response :success
       assert_equal("text/plain", @response.media_type)
     end
@@ -65,7 +66,7 @@ module Shipit
     test ":abort call abort! on the deploy" do
       @task = shipit_deploys(:shipit_running)
       @task.ping
-      post :abort, params: {stack_id: @stack.to_param, id: @task.id}
+      post :abort, params: { stack_id: @stack.to_param, id: @task.id }
 
       @task.reload
       assert_response :success
@@ -77,7 +78,7 @@ module Shipit
     test ":abort schedule the rollback if `rollback` is present" do
       @task = shipit_deploys(:shipit_running)
       @task.ping
-      post :abort, params: {stack_id: @stack.to_param, id: @task.id, rollback: 'true'}
+      post :abort, params: { stack_id: @stack.to_param, id: @task.id, rollback: 'true' }
 
       @task.reload
       assert_response :success
@@ -87,31 +88,43 @@ module Shipit
     end
 
     test ":index list the stack deploys" do
-      get :index, params: {stack_id: @stack.to_param}
+      get :index, params: { stack_id: @stack.to_param }
       assert_response :success
       assert_select '.task-list .task', @stack.tasks.count
     end
 
     test ":index paginates with the `since` parameter" do
-      get :index, params: {stack_id: @stack.to_param, since: @stack.tasks.last.id}
+      get :index, params: { stack_id: @stack.to_param, since: @stack.tasks.last.id }
       assert_response :success
       assert_select '.task-list .task', @stack.tasks.count - 1
     end
 
     test ":tail returns the task status, output, and next url" do
       @task = shipit_deploys(:shipit_running)
-      last_chunk = @task.chunks.last
+      @task.write("dummy output")
+      last_chunk = @task.chunk_output.bytesize
 
-      get :tail, params: {stack_id: @stack.to_param, id: @task.id, last_id: last_chunk.id}, format: :json
+      get :tail, params: { stack_id: @stack.to_param, id: @task.id }, format: :json
       assert_response :success
       assert_json_keys %w(url status output)
       assert_json 'status', @task.status
+      assert_json 'output', @task.chunk_output
+      assert_json 'url', "/shopify/shipit-engine/production/tasks/#{@task.id}/tail?last_byte=#{last_chunk}"
+    end
+
+    test ":tail can handle last_byte as string" do
+      @task = shipit_deploys(:shipit_running)
+      @task.write("dummy output")
+
+      get :tail, params: { stack_id: @stack.to_param, id: @task.id, last_byte: "50" }, format: :json
+      assert_response :success
+      assert_json_keys %w(url status output)
     end
 
     test ":tail doesn't returns the next url if the task is finished" do
       @task = shipit_deploys(:shipit)
 
-      get :tail, params: {stack_id: @stack.to_param, id: @task.id}, format: :json
+      get :tail, params: { stack_id: @stack.to_param, id: @task.id }, format: :json
       assert_response :success
       assert_no_json 'url'
     end
@@ -119,7 +132,7 @@ module Shipit
     test ":tail returns the rollback url if the task have been aborted" do
       @task = shipit_deploys(:shipit_aborted)
 
-      get :tail, params: {stack_id: @stack.to_param, id: @task.id}, format: :json
+      get :tail, params: { stack_id: @stack.to_param, id: @task.id }, format: :json
       assert_response :success
       assert_json_keys %w(status output rollback_url)
     end
@@ -127,7 +140,7 @@ module Shipit
     test ":lookup returns stack task url if the task is an instance of Task" do
       @task = shipit_tasks(:shipit_restart)
 
-      get :lookup, params: {id: @task.id}
+      get :lookup, params: { id: @task.id }
 
       assert_redirected_to stack_task_path(@task.stack, @task)
     end
@@ -135,7 +148,7 @@ module Shipit
     test ":lookup returns stack deploy url if the task is an instance of Deploy" do
       @task = shipit_tasks(:shipit)
 
-      get :lookup, params: {id: @task.id}
+      get :lookup, params: { id: @task.id }
 
       assert_redirected_to stack_deploy_path(@task.stack, @task)
     end
@@ -143,7 +156,7 @@ module Shipit
     test ":lookup returns stack deploy url if the task is an instance of Rollback" do
       @task = shipit_tasks(:shipit_rollback)
 
-      get :lookup, params: {id: @task.id}
+      get :lookup, params: { id: @task.id }
 
       assert_redirected_to stack_deploy_path(@task.stack, @task)
     end