rubycritic 2.6.0 → 2.7.0

data/test/lib/rubycritic/core/location_test.rb

@@ -1,37 +1,37 @@
-require "test_helper"
-require "rubycritic/core/location"
+require 'test_helper'
+require 'rubycritic/core/location'
 
 describe Rubycritic::Location do
-  describe "attribute readers" do
+  describe 'attribute readers' do
     before do
-      @path = "./foo.rb"
-      @line = "42"
+      @path = './foo.rb'
+      @line = '42'
       @location = Rubycritic::Location.new(@path, @line)
     end
 
-    it "has a pathname" do
+    it 'has a pathname' do
       @location.pathname.must_equal Pathname.new(@path)
     end
 
-    it "has a line number" do
+    it 'has a line number' do
       @location.line.must_equal @line.to_i
     end
 
-    it "has a file name" do
-      @location.file_name.must_equal "foo"
+    it 'has a file name' do
+      @location.file_name.must_equal 'foo'
     end
   end
 
-  it "is comparable" do
-    location1 = Rubycritic::Location.new("./foo", 42)
-    location2 = Rubycritic::Location.new("./foo", 42)
+  it 'is comparable' do
+    location1 = Rubycritic::Location.new('./foo', 42)
+    location2 = Rubycritic::Location.new('./foo', 42)
     location1.must_equal location2
   end
 
-  it "is sortable" do
-    location1 = Rubycritic::Location.new("./foo", 42)
-    location2 = Rubycritic::Location.new("./bar", 23)
-    location3 = Rubycritic::Location.new("./bar", 16)
+  it 'is sortable' do
+    location1 = Rubycritic::Location.new('./foo', 42)
+    location2 = Rubycritic::Location.new('./bar', 23)
+    location3 = Rubycritic::Location.new('./bar', 16)
     [location1, location2, location3].sort.must_equal [location3, location2, location1]
   end
 end

data/test/lib/rubycritic/core/smell_test.rb

@@ -1,68 +1,68 @@
-require "test_helper"
-require "rubycritic/core/smell"
+require 'test_helper'
+require 'rubycritic/core/smell'
 
 describe Rubycritic::Smell do
-  describe "attribute readers" do
+  describe 'attribute readers' do
     before do
-      @locations = [Rubycritic::Location.new("./foo", "42")]
-      @context = "#bar"
-      @message = "This smells"
+      @locations = [Rubycritic::Location.new('./foo', '42')]
+      @context = '#bar'
+      @message = 'This smells'
       @score = 0
       @type = :complexity
       @smell = Rubycritic::Smell.new(
-        :locations => @locations,
-        :context   => @context,
-        :message   => @message,
-        :score     => @score,
-        :type      => @type
+        locations: @locations,
+        context: @context,
+        message: @message,
+        score: @score,
+        type: @type
       )
     end
 
-    it "has a context reader" do
+    it 'has a context reader' do
       @smell.context.must_equal @context
     end
 
-    it "has a locations reader" do
+    it 'has a locations reader' do
       @smell.locations.must_equal @locations
     end
 
-    it "has a message reader" do
+    it 'has a message reader' do
       @smell.message.must_equal @message
     end
 
-    it "has a score reader" do
+    it 'has a score reader' do
       @smell.score.must_equal @score
     end
 
-    it "has a type reader" do
+    it 'has a type reader' do
       @smell.type.must_equal @type
     end
   end
 
-  describe "#at_location?" do
-    it "returns true if the smell has a location that matches the location passed as argument" do
-      location = Rubycritic::Location.new("./foo", "42")
-      smell = Rubycritic::Smell.new(:locations => [location])
+  describe '#at_location?' do
+    it 'returns true if the smell has a location that matches the location passed as argument' do
+      location = Rubycritic::Location.new('./foo', '42')
+      smell = Rubycritic::Smell.new(locations: [location])
       smell.at_location?(location).must_equal true
     end
   end
 
-  describe "#multiple_locations?" do
-    it "returns true if the smell has more than one location" do
-      location1 = Rubycritic::Location.new("./foo", "42")
-      location2 = Rubycritic::Location.new("./foo", "23")
-      smell = Rubycritic::Smell.new(:locations => [location1, location2])
+  describe '#multiple_locations?' do
+    it 'returns true if the smell has more than one location' do
+      location1 = Rubycritic::Location.new('./foo', '42')
+      location2 = Rubycritic::Location.new('./foo', '23')
+      smell = Rubycritic::Smell.new(locations: [location1, location2])
       smell.multiple_locations?.must_equal true
     end
   end
 
-  describe "#==" do
-    it "returns true if two smells have the same base attributes" do
+  describe '#==' do
+    it 'returns true if two smells have the same base attributes' do
       attributes = {
-        :context => "#bar",
-        :message => "This smells",
-        :score => 0,
-        :type => :complexity
+        context: '#bar',
+        message: 'This smells',
+        score: 0,
+        type: :complexity
       }
       smell1 = Rubycritic::Smell.new(attributes)
       smell2 = Rubycritic::Smell.new(attributes)

data/test/lib/rubycritic/core/smells_array_test.rb

@@ -1,28 +1,28 @@
-require "test_helper"
-require "rubycritic/core/smell"
+require 'test_helper'
+require 'rubycritic/core/smell'
 
-describe "Array of Smells" do
-  it "is sortable" do
-    location1 = Rubycritic::Location.new("./foo", 42)
-    location2 = Rubycritic::Location.new("./bar", 23)
-    location3 = Rubycritic::Location.new("./bar", 16)
-    smell1 = Rubycritic::Smell.new(:locations => [location1])
-    smell2 = Rubycritic::Smell.new(:locations => [location2])
-    smell3 = Rubycritic::Smell.new(:locations => [location3])
+describe 'Array of Smells' do
+  it 'is sortable' do
+    location1 = Rubycritic::Location.new('./foo', 42)
+    location2 = Rubycritic::Location.new('./bar', 23)
+    location3 = Rubycritic::Location.new('./bar', 16)
+    smell1 = Rubycritic::Smell.new(locations: [location1])
+    smell2 = Rubycritic::Smell.new(locations: [location2])
+    smell3 = Rubycritic::Smell.new(locations: [location3])
     [smell1, smell2, smell3].sort.must_equal [smell3, smell2, smell1]
   end
 
-  it "implements set intersection" do
-    smell1 = Rubycritic::Smell.new(:context => "#bar")
-    smell2 = Rubycritic::Smell.new(:context => "#bar")
-    smell3 = Rubycritic::Smell.new(:context => "#foo")
+  it 'implements set intersection' do
+    smell1 = Rubycritic::Smell.new(context: '#bar')
+    smell2 = Rubycritic::Smell.new(context: '#bar')
+    smell3 = Rubycritic::Smell.new(context: '#foo')
     ([smell1, smell3] & [smell2]).must_equal [smell1]
   end
 
-  it "implements set union" do
-    smell1 = Rubycritic::Smell.new(:context => "#bar")
-    smell2 = Rubycritic::Smell.new(:context => "#bar")
-    smell3 = Rubycritic::Smell.new(:context => "#foo")
+  it 'implements set union' do
+    smell1 = Rubycritic::Smell.new(context: '#bar')
+    smell2 = Rubycritic::Smell.new(context: '#bar')
+    smell3 = Rubycritic::Smell.new(context: '#foo')
     ([smell1, smell3] | [smell2]).must_equal [smell1, smell3]
   end
 end

data/test/lib/rubycritic/generators/console_report_test.rb

@@ -1,10 +1,10 @@
-require "test_helper"
-require "rubycritic/generators/console_report"
-require "rubycritic/core/rating"
-require "rubycritic/core/smell"
+require 'test_helper'
+require 'rubycritic/generators/console_report'
+require 'rubycritic/core/rating'
+require 'rubycritic/core/smell'
 
 describe Rubycritic::Generator::ConsoleReport do
-  describe "#generate_report" do
+  describe '#generate_report' do
     before do
       @mock_analysed_module = mock_analysed_module
       capture_output_streams do
@@ -14,8 +14,8 @@ describe Rubycritic::Generator::ConsoleReport do
       end
     end
 
-    it "outputs the report to the stdout" do
-      assert @output.size > 0, "expected report to be output to stdout"
+    it 'outputs the report to the stdout' do
+      assert @output.size > 0, 'expected report to be output to stdout'
     end
 
     it "starts the report with the module's name" do
@@ -24,57 +24,57 @@ describe Rubycritic::Generator::ConsoleReport do
     end
 
     it "includes the module's rating in the report" do
-      assert output_contains?("Rating", @mock_analysed_module.rating)
+      assert output_contains?('Rating', @mock_analysed_module.rating)
     end
 
     it "includes the module's rating in the report" do
-      assert output_contains?("Churn", @mock_analysed_module.churn)
+      assert output_contains?('Churn', @mock_analysed_module.churn)
     end
 
     it "includes the module's rating in the report" do
-      assert output_contains?("Complexity", @mock_analysed_module.complexity)
+      assert output_contains?('Complexity', @mock_analysed_module.complexity)
     end
 
     it "includes the module's rating in the report" do
-      assert output_contains?("Duplication", @mock_analysed_module.duplication)
+      assert output_contains?('Duplication', @mock_analysed_module.duplication)
     end
 
-    it "includes the number of smells in the report" do
-      assert output_contains?("Smells", @mock_analysed_module.smells.count)
+    it 'includes the number of smells in the report' do
+      assert output_contains?('Smells', @mock_analysed_module.smells.count)
     end
 
-    it "includes the smell and its attributes in the report" do
+    it 'includes the smell and its attributes in the report' do
       @mock_analysed_module.smells.each do |smell|
-        assert output_contains?(smell), "expected smell type and context to be reported"
+        assert output_contains?(smell), 'expected smell type and context to be reported'
         smell.locations.each do |location|
-          assert output_contains?(location), "expected all smell locations to be reported"
+          assert output_contains?(location), 'expected all smell locations to be reported'
         end
       end
     end
 
     def output_contains?(*strs)
       @lines ||= @output.split("\n")
-      expr = strs.map(&:to_s).map! { |s| Regexp.escape(s) }.join(".*")
+      expr = strs.map(&:to_s).map! { |s| Regexp.escape(s) }.join('.*')
       @lines.any? { |l| l[/#{expr}/] }
     end
 
     def mock_analysed_module
       OpenStruct.new(
-        :name         => "TestModule",
-        :rating       => Rubycritic::Rating.from_cost(3),
-        :churn        => 10,
-        :complexity   => 0,
-        :duplication  => 20,
-        :smells       => [mock_smell]
+        name: 'TestModule',
+        rating: Rubycritic::Rating.from_cost(3),
+        churn: 10,
+        complexity: 0,
+        duplication: 20,
+        smells: [mock_smell]
       )
     end
 
     def mock_smell
       smell = Rubycritic::Smell.new
       smell.locations << Rubycritic::Location.new(__FILE__, 3)
-      smell.type = "SmellySmell"
-      smell.context = "You"
-      smell.message = "Seriously, take a shower or something"
+      smell.type = 'SmellySmell'
+      smell.context = 'You'
+      smell.message = 'Seriously, take a shower or something'
       smell
     end
   end

data/test/lib/rubycritic/generators/turbulence_test.rb

@@ -1,15 +1,15 @@
-require "test_helper"
-require "rubycritic/generators/html/turbulence"
+require 'test_helper'
+require 'rubycritic/generators/html/turbulence'
 
 describe Rubycritic::Turbulence do
-  describe "::data" do
-    it "returns json data that maps pathname, churn and complexity to name, x and y" do
-      files = [AnalysedModuleDouble.new(:name => "Foo", :churn => 1, :complexity => 2)]
+  describe '::data' do
+    it 'returns json data that maps pathname, churn and complexity to name, x and y' do
+      files = [AnalysedModuleDouble.new(name: 'Foo', churn: 1, complexity: 2)]
       turbulence_data = Rubycritic::Turbulence.data(files)
       instance_parsed_json = JSON.parse(turbulence_data).first
-      instance_parsed_json["name"].must_equal "Foo"
-      instance_parsed_json["x"].must_equal 1
-      instance_parsed_json["y"].must_equal 2
+      instance_parsed_json['name'].must_equal 'Foo'
+      instance_parsed_json['x'].must_equal 1
+      instance_parsed_json['y'].must_equal 2
     end
   end
 end

data/test/lib/rubycritic/generators/view_helpers_test.rb

@@ -1,66 +1,66 @@
-require "test_helper"
-require "rubycritic/generators/html/view_helpers"
-require "pathname"
+require 'test_helper'
+require 'rubycritic/generators/html/view_helpers'
+require 'pathname'
 
 describe Rubycritic::ViewHelpers do
-  context "when the file is in the root directory" do
-    let(:generator) { GeneratorDouble.new("foo.html") }
+  context 'when the file is in the root directory' do
+    let(:generator) { GeneratorDouble.new('foo.html') }
 
-    describe "#file_path" do
-      context "when the other file is in the same directory" do
-        it "creates a relative path to a file" do
-          generator.file_path("bar.html").to_s.must_equal "bar.html"
+    describe '#file_path' do
+      context 'when the other file is in the same directory' do
+        it 'creates a relative path to a file' do
+          generator.file_path('bar.html').to_s.must_equal 'bar.html'
         end
       end
 
-      context "when the other file is in a subdirectory" do
-        it "creates a relative path to a file" do
-          generator.file_path("subdirectory/bar.html").to_s.must_equal "subdirectory/bar.html"
+      context 'when the other file is in a subdirectory' do
+        it 'creates a relative path to a file' do
+          generator.file_path('subdirectory/bar.html').to_s.must_equal 'subdirectory/bar.html'
         end
       end
     end
 
-    describe "#asset_path" do
-      it "creates a relative path to an asset" do
-        generator.asset_path("stylesheets/application.css").to_s
-          .must_equal "assets/stylesheets/application.css"
+    describe '#asset_path' do
+      it 'creates a relative path to an asset' do
+        generator.asset_path('stylesheets/application.css').to_s
+                 .must_equal 'assets/stylesheets/application.css'
       end
     end
   end
 
-  context "when the file is n directories deep" do
-    let(:generator) { GeneratorDouble.new("lets/go/crazy/foo.html") }
+  context 'when the file is n directories deep' do
+    let(:generator) { GeneratorDouble.new('lets/go/crazy/foo.html') }
 
-    describe "#file_path" do
-      context "when the other file is in the same directory" do
-        it "creates a relative path to a file" do
-          generator.file_path("lets/go/crazy/bar.html").to_s.must_equal "bar.html"
+    describe '#file_path' do
+      context 'when the other file is in the same directory' do
+        it 'creates a relative path to a file' do
+          generator.file_path('lets/go/crazy/bar.html').to_s.must_equal 'bar.html'
         end
       end
 
-      context "when the other file is in the root directory" do
-        it "creates a relative path to a file" do
-          generator.file_path("bar.html").to_s.must_equal "../../../bar.html"
+      context 'when the other file is in the root directory' do
+        it 'creates a relative path to a file' do
+          generator.file_path('bar.html').to_s.must_equal '../../../bar.html'
         end
       end
 
-      context "when the other file has n-1 directories in common" do
-        it "creates a relative path to a file" do
-          generator.file_path("lets/go/home/bar.html").to_s.must_equal "../home/bar.html"
+      context 'when the other file has n-1 directories in common' do
+        it 'creates a relative path to a file' do
+          generator.file_path('lets/go/home/bar.html').to_s.must_equal '../home/bar.html'
         end
       end
 
-      context "when the other file is one directory deeper" do
-        it "creates a relative path to a file" do
-          generator.file_path("lets/go/crazy/everybody/bar.html").to_s.must_equal "everybody/bar.html"
+      context 'when the other file is one directory deeper' do
+        it 'creates a relative path to a file' do
+          generator.file_path('lets/go/crazy/everybody/bar.html').to_s.must_equal 'everybody/bar.html'
         end
       end
     end
 
-    describe "#asset_path" do
-      it "creates a relative path to an asset" do
-        generator.asset_path("stylesheets/application.css").to_s
-          .must_equal "../../../assets/stylesheets/application.css"
+    describe '#asset_path' do
+      it 'creates a relative path to an asset' do
+        generator.asset_path('stylesheets/application.css').to_s
+                 .must_equal '../../../assets/stylesheets/application.css'
       end
     end
   end
@@ -78,6 +78,6 @@ class GeneratorDouble
   end
 
   def root_directory
-    Pathname.new("root_directory")
+    Pathname.new('root_directory')
   end
 end

data/test/lib/rubycritic/smells_status_setter_test.rb

@@ -1,20 +1,20 @@
-require "test_helper"
-require "rubycritic/core/smell"
-require "rubycritic/smells_status_setter"
+require 'test_helper'
+require 'rubycritic/core/smell'
+require 'rubycritic/smells_status_setter'
 
 describe Rubycritic::SmellsStatusSetter do
-  describe "::smells" do
+  describe '::smells' do
     before do
-      @smell = Rubycritic::Smell.new(:context => "#bar")
+      @smell = Rubycritic::Smell.new(context: '#bar')
       @smells = [@smell]
     end
 
-    it "marks old smells" do
+    it 'marks old smells' do
       Rubycritic::SmellsStatusSetter.set(@smells, @smells)
       @smell.status.must_equal :old
     end
 
-    it "marks new smells" do
+    it 'marks new smells' do
       Rubycritic::SmellsStatusSetter.set([], @smells)
       @smell.status.must_equal :new
     end