rubycritic 2.6.0 → 2.7.0

data/test/lib/rubycritic/analysers/smells/flay_test.rb

@@ -1,38 +1,38 @@
-require "test_helper"
-require "rubycritic/analysers/smells/flay"
-require "rubycritic/core/analysed_module"
-require "pathname"
+require 'test_helper'
+require 'rubycritic/analysers/smells/flay'
+require 'rubycritic/core/analysed_module'
+require 'pathname'
 
 describe Rubycritic::Analyser::FlaySmells do
-  context "when analysing a bunch of files with duplicate code" do
+  context 'when analysing a bunch of files with duplicate code' do
     before do
       @analysed_modules = [
-        Rubycritic::AnalysedModule.new(:pathname => Pathname.new("test/samples/flay/smelly.rb")),
-        Rubycritic::AnalysedModule.new(:pathname => Pathname.new("test/samples/flay/smelly2.rb"))
+        Rubycritic::AnalysedModule.new(pathname: Pathname.new('test/samples/flay/smelly.rb')),
+        Rubycritic::AnalysedModule.new(pathname: Pathname.new('test/samples/flay/smelly2.rb'))
       ]
       Rubycritic::Analyser::FlaySmells.new(@analysed_modules).run
     end
 
-    it "detects its smells" do
+    it 'detects its smells' do
       @analysed_modules.first.smells?.must_equal true
     end
 
-    it "creates smells with messages" do
+    it 'creates smells with messages' do
       smell = @analysed_modules.first.smells.first
       smell.message.must_be_instance_of String
     end
 
-    it "creates smells with scores" do
+    it 'creates smells with scores' do
       smell = @analysed_modules.first.smells.first
       smell.score.must_be_kind_of Numeric
     end
 
-    it "creates smells with more than one location" do
+    it 'creates smells with more than one location' do
       smell = @analysed_modules.first.smells.first
       smell.multiple_locations?.must_equal true
     end
 
-    it "calculates the mass of duplicate code" do
+    it 'calculates the mass of duplicate code' do
       @analysed_modules.first.duplication.must_be(:>, 0)
     end
   end

data/test/lib/rubycritic/analysers/smells/flog_test.rb

@@ -1,24 +1,24 @@
-require "analysers_test_helper"
-require "rubycritic/analysers/smells/flog"
+require 'analysers_test_helper'
+require 'rubycritic/analysers/smells/flog'
 
 describe Rubycritic::Analyser::FlogSmells do
-  context "when analysing a complex file" do
+  context 'when analysing a complex file' do
     before do
-      @analysed_module = AnalysedModuleDouble.new(:path => "test/samples/flog/smelly.rb", :smells => [])
+      @analysed_module = AnalysedModuleDouble.new(path: 'test/samples/flog/smelly.rb', smells: [])
       analysed_modules = [@analysed_module]
       Rubycritic::Analyser::FlogSmells.new(analysed_modules).run
     end
 
-    it "detects its smells" do
+    it 'detects its smells' do
       @analysed_module.smells.length.must_equal 1
     end
 
-    it "creates smells with messages" do
+    it 'creates smells with messages' do
       smell = @analysed_module.smells.first
       smell.message.must_be_instance_of String
     end
 
-    it "creates smells with scores" do
+    it 'creates smells with scores' do
       smell = @analysed_module.smells.first
       smell.score.must_be :>, 0
     end

data/test/lib/rubycritic/analysers/smells/reek_test.rb

@@ -1,25 +1,25 @@
-require "analysers_test_helper"
-require "rubycritic/analysers/smells/reek"
+require 'analysers_test_helper'
+require 'rubycritic/analysers/smells/reek'
 
 describe Rubycritic::Analyser::ReekSmells do
-  context "when analysing a smelly file" do
+  context 'when analysing a smelly file' do
     before do
-      pathname = Pathname.new("test/samples/reek/smelly.rb")
-      @analysed_module = AnalysedModuleDouble.new(:pathname => pathname, :smells => [])
+      pathname = Pathname.new('test/samples/reek/smelly.rb')
+      @analysed_module = AnalysedModuleDouble.new(pathname: pathname, smells: [])
       analysed_modules = [@analysed_module]
       Rubycritic::Analyser::ReekSmells.new(analysed_modules).run
     end
 
-    it "detects its smells" do
+    it 'detects its smells' do
       @analysed_module.smells.length.must_equal 2
     end
 
-    it "creates smells with messages" do
+    it 'creates smells with messages' do
       first_smell = @analysed_module.smells.first
       first_smell.message.must_equal "has boolean parameter 'reek'"
 
       last_smell = @analysed_module.smells.last
-      last_smell.message.must_equal "has no descriptive comment"
+      last_smell.message.must_equal 'has no descriptive comment'
     end
   end
 end

data/test/lib/rubycritic/browser_test.rb

@@ -0,0 +1,16 @@
+require 'test_helper'
+require 'rubycritic/browser'
+
+describe Rubycritic::Browser do
+  before do
+    @report_path = 'tmp/rubycritic/overview.html'
+    @browser = Rubycritic::Browser.new @report_path
+  end
+
+  describe '#open' do
+    it 'should be open report with launch browser' do
+      Launchy.stubs(:open).returns(true)
+      @browser.open.must_equal true
+    end
+  end
+end

data/test/lib/rubycritic/commands/status_reporter_test.rb

@@ -1,66 +1,78 @@
-require "test_helper"
-require "rubycritic/commands/status_reporter"
-require "rubycritic/cli/options"
+require 'test_helper'
+require 'rubycritic/commands/status_reporter'
+require 'rubycritic/cli/options'
 
 describe Rubycritic::Command::StatusReporter do
   let(:success_status) { Rubycritic::Command::StatusReporter::SUCCESS }
   let(:score_below_minimum) { Rubycritic::Command::StatusReporter::SCORE_BELOW_MINIMUM }
 
-  describe "with default options" do
+  describe 'with default options' do
     before do
       @options = Rubycritic::Cli::Options.new([])
       @options.parse
       @reporter = Rubycritic::Command::StatusReporter.new(@options.to_h)
     end
 
-    it "has a default" do
+    it 'has a default' do
       @reporter.status.must_equal success_status
       @reporter.status_message.must_be_nil
     end
 
-    it "accept a score" do
+    it 'accept a score' do
       @reporter.score = 50
       @reporter.status.must_equal success_status
-      @reporter.status_message.must_equal "Score: 50"
+      @reporter.status_message.must_equal 'Score: 50.0'
+    end
+
+    it 'should format the score' do
+      @reporter.score = 98.95258620689656
+      @reporter.status.must_equal success_status
+      @reporter.status_message.must_equal 'Score: 98.95'
     end
   end
 
-  describe "with minimum-score option" do
+  describe 'with minimum-score option' do
     before do
-      @options = Rubycritic::Cli::Options.new(["-s", "99"])
+      @options = Rubycritic::Cli::Options.new(['-s', '99'])
       @options.parse
       @reporter = Rubycritic::Command::StatusReporter.new(@options.to_h)
     end
 
-    it "has a default" do
+    it 'has a default' do
       @reporter.status.must_equal success_status
       @reporter.status_message.must_be_nil
     end
 
-    describe "when score is below minimum" do
+    describe 'when score is below minimum' do
       let(:score) { 98 }
-      it "should return the correct status" do
+      it 'should return the correct status' do
         @reporter.score = score
         @reporter.status.must_equal score_below_minimum
-        @reporter.status_message.must_equal "Score (98) is below the minimum 99"
+        @reporter.status_message.must_equal 'Score (98.0) is below the minimum 99'
+      end
+
+      it 'should format the score' do
+        @reporter.score = 98.95258620689656
+        @reporter.status.must_equal score_below_minimum
+        @reporter.status_message.must_equal 'Score (98.95) is below the minimum 99'
       end
     end
 
-    describe "when score is equal the minimum" do
+    describe 'when score is equal the minimum' do
       let(:score) { 99 }
-      it "should return the correct status" do
+      it 'should return the correct status' do
         @reporter.score = score
         @reporter.status.must_equal success_status
-        @reporter.status_message.must_equal "Score: 99"
+        @reporter.status_message.must_equal 'Score: 99.0'
       end
     end
 
-    describe "when score is above the minimum" do
+    describe 'when score is above the minimum' do
       let(:score) { 100 }
-      it "should return the correct status" do
+      it 'should return the correct status' do
         @reporter.score = score
         @reporter.status.must_equal success_status
-        @reporter.status_message.must_equal "Score: 100"
+        @reporter.status_message.must_equal 'Score: 100.0'
       end
     end
   end

data/test/lib/rubycritic/configuration_test.rb

@@ -1,25 +1,25 @@
-require "test_helper"
-require "rubycritic/configuration"
+require 'test_helper'
+require 'rubycritic/configuration'
 
 describe Rubycritic::Configuration do
-  describe "#root" do
+  describe '#root' do
     before do
       Rubycritic::Config.set
       @default = Rubycritic::Config.root
     end
 
-    it "has a default" do
+    it 'has a default' do
       Rubycritic::Config.root.must_be_instance_of String
     end
 
-    it "can be set to a relative path" do
-      Rubycritic::Config.root = "foo"
-      Rubycritic::Config.root.must_equal File.expand_path("foo")
+    it 'can be set to a relative path' do
+      Rubycritic::Config.root = 'foo'
+      Rubycritic::Config.root.must_equal File.expand_path('foo')
     end
 
-    it "can be set to an absolute path" do
-      Rubycritic::Config.root = "/foo"
-      Rubycritic::Config.root.must_equal "/foo"
+    it 'can be set to an absolute path' do
+      Rubycritic::Config.root = '/foo'
+      Rubycritic::Config.root.must_equal '/foo'
     end
 
     after do

data/test/lib/rubycritic/core/analysed_module_test.rb

@@ -1,85 +1,85 @@
-require "test_helper"
-require "rubycritic/core/analysed_module"
-require "rubycritic/core/smell"
+require 'test_helper'
+require 'rubycritic/core/analysed_module'
+require 'rubycritic/core/smell'
 
 describe Rubycritic::AnalysedModule do
-  describe "attribute readers" do
+  describe 'attribute readers' do
     before do
-      @name = "Foo"
-      @pathname = Pathname.new("foo.rb")
+      @name = 'Foo'
+      @pathname = Pathname.new('foo.rb')
       @smells = []
       @churn = 1
       @complexity = 2
       @analysed_module = Rubycritic::AnalysedModule.new(
-        :name       => @name,
-        :pathname   => @pathname,
-        :smells     => @smells,
-        :churn      => @churn,
-        :complexity => @complexity
+        name: @name,
+        pathname: @pathname,
+        smells: @smells,
+        churn: @churn,
+        complexity: @complexity
       )
     end
 
-    it "has a name reader" do
+    it 'has a name reader' do
       @analysed_module.name.must_equal @name
     end
 
-    it "has a pathname reader" do
+    it 'has a pathname reader' do
       @analysed_module.pathname.must_equal @pathname
     end
 
-    it "has a path reader" do
+    it 'has a path reader' do
       @analysed_module.path.must_equal @pathname.to_s
     end
 
-    it "has a smells reader" do
+    it 'has a smells reader' do
       @analysed_module.smells.must_equal @smells
     end
 
-    it "has a churn reader" do
+    it 'has a churn reader' do
       @analysed_module.churn.must_equal @churn
     end
 
-    it "has a complexity reader" do
+    it 'has a complexity reader' do
       @analysed_module.complexity.must_equal @complexity
     end
   end
 
-  describe "#cost" do
-    it "returns the remediation cost of fixing the analysed_module" do
-      smells = [SmellDouble.new(:cost => 1), SmellDouble.new(:cost => 2)]
-      analysed_module = Rubycritic::AnalysedModule.new(:smells => smells, :complexity => 0)
+  describe '#cost' do
+    it 'returns the remediation cost of fixing the analysed_module' do
+      smells = [SmellDouble.new(cost: 1), SmellDouble.new(cost: 2)]
+      analysed_module = Rubycritic::AnalysedModule.new(smells: smells, complexity: 0)
       analysed_module.cost.must_equal 3
     end
   end
 
-  describe "#complexity_per_method" do
-    context "when the file has no methods" do
-      it "returns a placeholder" do
-        analysed_module = Rubycritic::AnalysedModule.new(:complexity => 0, :methods_count => 0)
-        analysed_module.complexity_per_method.must_equal "N/A"
+  describe '#complexity_per_method' do
+    context 'when the file has no methods' do
+      it 'returns a placeholder' do
+        analysed_module = Rubycritic::AnalysedModule.new(complexity: 0, methods_count: 0)
+        analysed_module.complexity_per_method.must_equal 'N/A'
       end
     end
 
-    context "when the file has at least one method" do
-      it "returns the average complexity per method" do
-        analysed_module = Rubycritic::AnalysedModule.new(:complexity => 10, :methods_count => 2)
+    context 'when the file has at least one method' do
+      it 'returns the average complexity per method' do
+        analysed_module = Rubycritic::AnalysedModule.new(complexity: 10, methods_count: 2)
         analysed_module.complexity_per_method.must_equal 5
       end
     end
   end
 
-  describe "#smells?" do
-    it "returns true if the analysed_module has at least one smell" do
-      analysed_module = Rubycritic::AnalysedModule.new(:smells => [SmellDouble.new])
+  describe '#smells?' do
+    it 'returns true if the analysed_module has at least one smell' do
+      analysed_module = Rubycritic::AnalysedModule.new(smells: [SmellDouble.new])
       analysed_module.smells?.must_equal true
     end
   end
 
-  describe "#smells_at_location" do
-    it "returns the smells of an analysed_module at a certain location" do
-      location = Rubycritic::Location.new("./foo", "42")
-      smells = [Rubycritic::Smell.new(:locations => [location])]
-      analysed_module = Rubycritic::AnalysedModule.new(:smells => smells)
+  describe '#smells_at_location' do
+    it 'returns the smells of an analysed_module at a certain location' do
+      location = Rubycritic::Location.new('./foo', '42')
+      smells = [Rubycritic::Smell.new(locations: [location])]
+      analysed_module = Rubycritic::AnalysedModule.new(smells: smells)
       analysed_module.smells_at_location(location).must_equal smells
     end
   end

data/test/lib/rubycritic/core/analysed_modules_collection_test.rb

@@ -1,62 +1,62 @@
-require "test_helper"
-require "rubycritic/core/analysed_modules_collection"
+require 'test_helper'
+require 'rubycritic/core/analysed_modules_collection'
 
 describe Rubycritic::AnalysedModulesCollection do
   subject { Rubycritic::AnalysedModulesCollection.new(paths) }
 
-  describe ".new" do
-    context "with an empty path" do
-      let(:paths) { "" }
+  describe '.new' do
+    context 'with an empty path' do
+      let(:paths) { '' }
 
-      it "returns an empty collection" do
+      it 'returns an empty collection' do
         subject.count.must_equal 0
       end
     end
 
-    context "with a list of files" do
+    context 'with a list of files' do
       let(:paths) { %w(test/samples/doesnt_exist.rb test/samples/unparsable.rb test/samples/empty.rb) }
 
-      it "registers one AnalysedModule element per existent file" do
+      it 'registers one AnalysedModule element per existent file' do
         subject.count.must_equal 2
         subject.all? { |a| a.is_a?(Rubycritic::AnalysedModule) }.must_equal true
       end
     end
 
-    context "with a directory" do
-      let(:paths) { "test/samples/" }
+    context 'with a directory' do
+      let(:paths) { 'test/samples/' }
 
-      it "recursively registers all files" do
-        subject.count.must_equal Dir["test/samples/**/*.rb"].count
+      it 'recursively registers all files' do
+        subject.count.must_equal Dir['test/samples/**/*.rb'].count
       end
     end
 
-    context "with redundant paths" do
+    context 'with redundant paths' do
       let(:paths) { %w(test/samples/flog test/samples/flog/complex.rb) }
 
-      it "returns a redundant collection" do
+      it 'returns a redundant collection' do
         subject.count.must_equal 3
       end
     end
   end
 
-  describe "#score" do
-    context "with no modules" do
-      let(:paths) { "" }
+  describe '#score' do
+    context 'with no modules' do
+      let(:paths) { '' }
 
-      it "returns zero" do
+      it 'returns zero' do
         subject.score.must_equal 0.0
       end
     end
 
-    context "with not analysed modules" do
-      let(:paths) { "test/samples/flog" }
+    context 'with not analysed modules' do
+      let(:paths) { 'test/samples/flog' }
 
-      it "returns zero" do
+      it 'returns zero' do
         subject.score.must_equal 0.0
       end
     end
 
-    context "with analysed modules" do
+    context 'with analysed modules' do
       before do
         subject.each_with_index do |mod, i|
           mod.expects(:cost).returns costs[i]
@@ -65,42 +65,42 @@ describe Rubycritic::AnalysedModulesCollection do
 
       let(:paths) { %w(test/samples/flog test/samples/flay) }
 
-      context "with perfect modules" do
+      context 'with perfect modules' do
         let(:costs) { [0.0, 0.0, 0.0, 0.0] }
 
-        it "returns the maximum score" do
+        it 'returns the maximum score' do
           subject.score.must_equal 100.0
         end
       end
 
-      context "with very bad modules" do
+      context 'with very bad modules' do
         let(:costs) { [16.0, 16.0, 16.0, 16.0] }
 
-        it "returns zero" do
+        it 'returns zero' do
           subject.score.must_equal 0.0
         end
       end
 
-      context "with horrible modules" do
+      context 'with horrible modules' do
         let(:costs) { [32.0, 32.0, 32.0, 32.0] }
 
-        it "returns zero" do
+        it 'returns zero' do
           subject.score.must_equal 0.0
         end
       end
 
-      context "with mixed modules" do
+      context 'with mixed modules' do
         let(:costs) { [32.0, 2.0, 0.0, 2.0] }
 
-        it "properly calculates the score" do
+        it 'properly calculates the score' do
           subject.score.must_equal 43.75
         end
       end
 
-      context "with a module above the cost limit" do
+      context 'with a module above the cost limit' do
         let(:costs) { [220.0, 2.0, 0.0, 2.0] }
 
-        it "reduces the impact in the result" do
+        it 'reduces the impact in the result' do
           subject.score.must_equal 43.75
         end
       end