rubycritic 2.6.0 → 2.7.0

data/lib/rubycritic/analysers/smells/flog.rb

@@ -1,10 +1,9 @@
-require "rubycritic/analysers/helpers/flog"
-require "rubycritic/core/smell"
-require "rubycritic/colorize"
+require 'rubycritic/analysers/helpers/flog'
+require 'rubycritic/core/smell'
+require 'rubycritic/colorize'
 
 module Rubycritic
   module Analyser
-
     class FlogSmells
       include Colorize
       HIGH_COMPLEXITY_SCORE_THRESHOLD = 25
@@ -18,13 +17,13 @@ module Rubycritic
       def run
         @analysed_modules.each do |analysed_module|
           add_smells_to(analysed_module)
-          print green "."
+          print green '.'
         end
-        puts ""
+        puts ''
       end
 
       def to_s
-        "flog smells"
+        'flog smells'
       end
 
       private
@@ -42,29 +41,28 @@ module Rubycritic
 
       def create_smell(context, score)
         Smell.new(
-          :locations => smell_locations(context),
-          :context   => context,
-          :message   => "has a flog score of #{score}",
-          :score     => score,
-          :type      => type(score),
-          :cost      => 0
+          locations: smell_locations(context),
+          context: context,
+          message: "has a flog score of #{score}",
+          score: score,
+          type: type(score),
+          cost: 0
         )
       end
 
       def smell_locations(context)
         line = @flog.method_locations[context]
-        file_path, file_line = line.split(":")
+        file_path, file_line = line.split(':')
         [Location.new(file_path, file_line)]
       end
 
       def type(score)
         if score >= VERY_HIGH_COMPLEXITY_SCORE_THRESHOLD
-          "VeryHighComplexity"
+          'VeryHighComplexity'
         else
-          "HighComplexity"
+          'HighComplexity'
         end
       end
     end
-
   end
 end

data/lib/rubycritic/analysers/smells/reek.rb

@@ -1,10 +1,9 @@
-require "rubycritic/analysers/helpers/reek"
-require "rubycritic/core/smell"
-require "rubycritic/colorize"
+require 'rubycritic/analysers/helpers/reek'
+require 'rubycritic/core/smell'
+require 'rubycritic/colorize'
 
 module Rubycritic
   module Analyser
-
     class ReekSmells
       include Colorize
       def initialize(analysed_modules)
@@ -14,13 +13,13 @@ module Rubycritic
       def run
         @analysed_modules.each do |analysed_module|
           add_smells_to(analysed_module)
-          print green "."
+          print green '.'
         end
-        puts ""
+        puts ''
       end
 
       def to_s
-        "reek smells"
+        'reek smells'
       end
 
       private
@@ -33,11 +32,11 @@ module Rubycritic
 
       def create_smell(smell)
         Smell.new(
-          :locations => smell_locations(smell.source, smell.lines),
-          :context   => smell.context,
-          :message   => smell.message,
-          :type      => smell.smell_type,
-          :cost      => 0
+          locations: smell_locations(smell.source, smell.lines),
+          context: smell.context,
+          message: smell.message,
+          type: smell.smell_type,
+          cost: 0
         )
       end
 
@@ -47,6 +46,5 @@ module Rubycritic
         end.sort
       end
     end
-
   end
 end

data/lib/rubycritic/analysers_runner.rb

@@ -1,13 +1,12 @@
-require "rubycritic/core/analysed_modules_collection"
-require "rubycritic/analysers/smells/flay"
-require "rubycritic/analysers/smells/flog"
-require "rubycritic/analysers/smells/reek"
-require "rubycritic/analysers/complexity"
-require "rubycritic/analysers/churn"
-require "rubycritic/analysers/attributes"
+require 'rubycritic/core/analysed_modules_collection'
+require 'rubycritic/analysers/smells/flay'
+require 'rubycritic/analysers/smells/flog'
+require 'rubycritic/analysers/smells/reek'
+require 'rubycritic/analysers/complexity'
+require 'rubycritic/analysers/churn'
+require 'rubycritic/analysers/attributes'
 
 module Rubycritic
-
   class AnalysersRunner
     ANALYSERS = [
       Analyser::FlaySmells,
@@ -16,7 +15,7 @@ module Rubycritic
       Analyser::Complexity,
       Analyser::Attributes,
       Analyser::Churn
-    ]
+    ].freeze
 
     def initialize(paths)
       @paths = paths
@@ -35,5 +34,4 @@ module Rubycritic
       @analysed_modules ||= AnalysedModulesCollection.new(@paths)
     end
   end
-
 end

data/lib/rubycritic/browser.rb

@@ -0,0 +1,17 @@
+require 'launchy'
+
+module Rubycritic
+  class Browser
+    attr_reader :report_path
+
+    def initialize(report_path)
+      @report_path = report_path
+    end
+
+    def open
+      Launchy.open(report_path) do |exception|
+        puts "Attempted to open #{report_path} and failed because #{exception}"
+      end
+    end
+  end
+end

data/lib/rubycritic/cli/application.rb

@@ -1,6 +1,6 @@
-require "rubycritic"
-require "rubycritic/cli/options"
-require "rubycritic/command_factory"
+require 'rubycritic'
+require 'rubycritic/cli/options'
+require 'rubycritic/command_factory'
 
 module Rubycritic
   module Cli

data/lib/rubycritic/cli/options.rb

@@ -1,4 +1,5 @@
-require "optparse"
+require 'optparse'
+require 'rubycritic/browser'
 
 module Rubycritic
   module Cli
@@ -11,44 +12,48 @@ module Rubycritic
       # rubocop:disable Metrics/MethodLength
       def parse
         @parser.new do |opts|
-          opts.banner = "Usage: rubycritic [options] [paths]"
+          opts.banner = 'Usage: rubycritic [options] [paths]'
 
-          opts.on("-p", "--path [PATH]", "Set path where report will be saved (tmp/rubycritic by default)") do |path|
+          opts.on('-p', '--path [PATH]', 'Set path where report will be saved (tmp/rubycritic by default)') do |path|
             @root = path
           end
 
           opts.on(
-            "-f", "--format [FORMAT]",
+            '-f', '--format [FORMAT]',
             [:html, :json, :console],
-            "Report smells in the given format:",
-            "  html (default)",
-            "  json",
-            "  console"
+            'Report smells in the given format:',
+            '  html (default)',
+            '  json',
+            '  console'
           ) do |format|
             @format = format
           end
 
-          opts.on("-s", "--minimum-score [MIN_SCORE]", "Set a minimum score") do |min_score|
+          opts.on('-s', '--minimum-score [MIN_SCORE]', 'Set a minimum score') do |min_score|
             @minimum_score = Integer(min_score)
           end
 
-          opts.on("-m", "--mode-ci", "Use CI mode (faster, but only analyses last commit)") do
+          opts.on('-m', '--mode-ci', 'Use CI mode (faster, but only analyses last commit)') do
             @mode = :ci
           end
 
-          opts.on("--deduplicate-symlinks", "De-duplicate symlinks based on their final target") do
+          opts.on('--deduplicate-symlinks', 'De-duplicate symlinks based on their final target') do
             @deduplicate_symlinks = true
           end
 
-          opts.on("--suppress-ratings", "Suppress letter ratings") do
+          opts.on('--suppress-ratings', 'Suppress letter ratings') do
             @suppress_ratings = true
           end
 
-          opts.on_tail("-v", "--version", "Show gem's version") do
+          opts.on('--no-browser', 'Do not open html report with browser') do
+            @no_browser = true
+          end
+
+          opts.on_tail('-v', '--version', "Show gem's version") do
             @mode = :version
           end
 
-          opts.on_tail("-h", "--help", "Show this message") do
+          opts.on_tail('-h', '--help', 'Show this message') do
             @mode = :help
           end
         end.parse!(@argv)
@@ -57,14 +62,15 @@ module Rubycritic
 
       def to_h
         {
-          :mode => @mode,
-          :root => @root,
-          :format => @format,
-          :deduplicate_symlinks => @deduplicate_symlinks,
-          :paths => paths,
-          :suppress_ratings => @suppress_ratings,
-          :help_text => @parser.help,
-          :minimum_score => @minimum_score || 0
+          mode: @mode,
+          root: @root,
+          format: @format,
+          deduplicate_symlinks: @deduplicate_symlinks,
+          paths: paths,
+          suppress_ratings: @suppress_ratings,
+          help_text: @parser.help,
+          minimum_score: @minimum_score || 0,
+          no_browser: @no_browser
         }
       end
 
@@ -72,7 +78,7 @@ module Rubycritic
 
       def paths
         if @argv.empty?
-          ["."]
+          ['.']
         else
           @argv
         end

data/lib/rubycritic/command_factory.rb

@@ -1,4 +1,4 @@
-require "rubycritic/configuration"
+require 'rubycritic/configuration'
 
 module Rubycritic
   class CommandFactory
@@ -10,16 +10,16 @@ module Rubycritic
     def self.command_class(mode)
       case mode
       when :version
-        require "rubycritic/commands/version"
+        require 'rubycritic/commands/version'
         Command::Version
       when :help
-        require "rubycritic/commands/help"
+        require 'rubycritic/commands/help'
         Command::Help
       when :ci
-        require "rubycritic/commands/ci"
+        require 'rubycritic/commands/ci'
         Command::Ci
       else
-        require "rubycritic/commands/default"
+        require 'rubycritic/commands/default'
         Command::Default
       end
     end

data/lib/rubycritic/commands/base.rb

@@ -1,4 +1,4 @@
-require "rubycritic/commands/status_reporter"
+require 'rubycritic/commands/status_reporter'
 
 module Rubycritic
   module Command
@@ -9,7 +9,7 @@ module Rubycritic
       end
 
       def execute
-        raise NotImplementedError
+        fail NotImplementedError
       end
     end
   end

data/lib/rubycritic/commands/ci.rb

@@ -1,7 +1,7 @@
-require "rubycritic/source_control_systems/base"
-require "rubycritic/analysers_runner"
-require "rubycritic/reporter"
-require "rubycritic/commands/default"
+require 'rubycritic/source_control_systems/base'
+require 'rubycritic/analysers_runner'
+require 'rubycritic/reporter'
+require 'rubycritic/commands/default'
 
 module Rubycritic
   module Command

data/lib/rubycritic/commands/default.rb

@@ -1,8 +1,8 @@
-require "rubycritic/source_control_systems/base"
-require "rubycritic/analysers_runner"
-require "rubycritic/revision_comparator"
-require "rubycritic/reporter"
-require "rubycritic/commands/base"
+require 'rubycritic/source_control_systems/base'
+require 'rubycritic/analysers_runner'
+require 'rubycritic/revision_comparator'
+require 'rubycritic/reporter'
+require 'rubycritic/commands/base'
 
 module Rubycritic
   module Command

data/lib/rubycritic/commands/help.rb

@@ -1,4 +1,4 @@
-require "rubycritic/commands/base"
+require 'rubycritic/commands/base'
 
 module Rubycritic
   module Command

data/lib/rubycritic/commands/status_reporter.rb

@@ -11,7 +11,7 @@ module Rubycritic
       end
 
       def score=(score)
-        @score = score
+        @score = score.round(2)
         update_status
       end
 

data/lib/rubycritic/commands/version.rb

@@ -1,5 +1,5 @@
-require "rubycritic/version"
-require "rubycritic/commands/base"
+require 'rubycritic/version'
+require 'rubycritic/commands/base'
 
 module Rubycritic
   module Command

data/lib/rubycritic/configuration.rb

@@ -2,14 +2,16 @@ module Rubycritic
   class Configuration
     attr_reader :root
     attr_accessor :source_control_system, :mode, :format, :deduplicate_symlinks,
-      :suppress_ratings
+                  :suppress_ratings, :open_with, :no_browser
 
     def set(options)
       self.mode = options[:mode] || :default
-      self.root = options[:root] || "tmp/rubycritic"
+      self.root = options[:root] || 'tmp/rubycritic'
       self.format = options[:format] || :html
       self.deduplicate_symlinks = options[:deduplicate_symlinks] || false
       self.suppress_ratings = options[:suppress_ratings] || false
+      self.open_with = options[:open_with]
+      self.no_browser = options[:no_browser]
     end
 
     def root=(path)

data/lib/rubycritic/core/analysed_module.rb

@@ -1,18 +1,17 @@
-require "virtus"
-require "rubycritic/core/rating"
+require 'virtus'
+require 'rubycritic/core/rating'
 
 module Rubycritic
-
   class AnalysedModule
     include Virtus.model
 
     attribute :name
     attribute :pathname
-    attribute :smells, Array, :default => []
+    attribute :smells, Array, default: []
     attribute :churn
     attribute :committed_at
     attribute :complexity
-    attribute :duplication, Integer, :default => 0
+    attribute :duplication, Integer, default: 0
     attribute :methods_count
 
     def path
@@ -29,7 +28,7 @@ module Rubycritic
 
     def complexity_per_method
       if methods_count == 0
-        "N/A"
+        'N/A'
       else
         complexity.fdiv(methods_count).round(1)
       end
@@ -49,16 +48,16 @@ module Rubycritic
 
     def to_h
       {
-        :name => name,
-        :path => path,
-        :smells => smells,
-        :churn => churn,
-        :committed_at => committed_at,
-        :complexity => complexity,
-        :duplication => duplication,
-        :methods_count => methods_count,
-        :cost => cost,
-        :rating => rating
+        name: name,
+        path: path,
+        smells: smells,
+        churn: churn,
+        committed_at: committed_at,
+        complexity: complexity,
+        duplication: duplication,
+        methods_count: methods_count,
+        cost: cost,
+        rating: rating
       }
     end
 
@@ -66,5 +65,4 @@ module Rubycritic
       to_h.to_json(*a)
     end
   end
-
 end