rubycritic 2.6.0 → 2.7.0

data/lib/rubycritic/core/analysed_modules_collection.rb

@@ -1,5 +1,5 @@
-require "rubycritic/source_locator"
-require "rubycritic/core/analysed_module"
+require 'rubycritic/source_locator'
+require 'rubycritic/core/analysed_module'
 
 module Rubycritic
   class AnalysedModulesCollection
@@ -17,7 +17,7 @@ module Rubycritic
 
     def initialize(paths)
       @modules = SourceLocator.new(paths).pathnames.map do |pathname|
-        AnalysedModule.new(:pathname => pathname)
+        AnalysedModule.new(pathname: pathname)
       end
     end
 

data/lib/rubycritic/core/location.rb

@@ -1,7 +1,6 @@
-require "pathname"
+require 'pathname'
 
 module Rubycritic
-
   class Location
     attr_reader :pathname, :line
 
@@ -11,7 +10,7 @@ module Rubycritic
     end
 
     def file_name
-      @pathname.basename.sub_ext("").to_s
+      @pathname.basename.sub_ext('').to_s
     end
 
     def to_s
@@ -20,8 +19,8 @@ module Rubycritic
 
     def to_h
       {
-        :path => pathname.to_s,
-        :line => line
+        path: pathname.to_s,
+        line: line
       }
     end
 
@@ -43,5 +42,4 @@ module Rubycritic
       [@pathname, @line]
     end
   end
-
 end

data/lib/rubycritic/core/rating.rb

@@ -1,12 +1,11 @@
 module Rubycritic
-
   class Rating
     def self.from_cost(cost)
-      if    cost <= 2  then new("A")
-      elsif cost <= 4  then new("B")
-      elsif cost <= 8  then new("C")
-      elsif cost <= 16 then new("D")
-      else new("F")
+      if    cost <= 2  then new('A')
+      elsif cost <= 4  then new('B')
+      elsif cost <= 8  then new('C')
+      elsif cost <= 16 then new('D')
+      else new('F')
       end
     end
 
@@ -26,5 +25,4 @@ module Rubycritic
       to_h.to_json(*a)
     end
   end
-
 end

data/lib/rubycritic/core/smell.rb

@@ -1,14 +1,13 @@
-require "virtus"
-require "rubycritic/core/location"
+require 'virtus'
+require 'rubycritic/core/location'
 
 module Rubycritic
-
   class Smell
     include Virtus.model
 
     attribute :context
     attribute :cost
-    attribute :locations, Array, :default => []
+    attribute :locations, Array, default: []
     attribute :message
     attribute :score
     attribute :status
@@ -25,7 +24,7 @@ module Rubycritic
     def ==(other)
       state == other.state
     end
-    alias_method :eql?, :==
+    alias eql? ==
 
     def to_s
       "(#{type}) #{context} #{message}"
@@ -33,13 +32,13 @@ module Rubycritic
 
     def to_h
       {
-        :context => context,
-        :cost => cost,
-        :locations => locations,
-        :message => message,
-        :score => score,
-        :status => status,
-        :type => type
+        context: context,
+        cost: cost,
+        locations: locations,
+        message: message,
+        score: score,
+        status: status,
+        type: type
       }
     end
 
@@ -57,5 +56,4 @@ module Rubycritic
       [@context, @message, @score, @type]
     end
   end
-
 end

data/lib/rubycritic/generators/console_report.rb

@@ -1,4 +1,4 @@
-require "rubycritic/generators/text/list"
+require 'rubycritic/generators/text/list'
 
 module Rubycritic
   module Generator

data/lib/rubycritic/generators/html/base.rb

@@ -1,18 +1,17 @@
-require "erb"
-require "pathname"
-require "rubycritic/generators/html/view_helpers"
+require 'erb'
+require 'pathname'
+require 'rubycritic/generators/html/view_helpers'
 
 module Rubycritic
   module Generator
     module Html
-
       class Base
         def self.erb_template(template_path)
           ERB.new(File.read(File.join(TEMPLATES_DIR, template_path)))
         end
 
-        TEMPLATES_DIR = File.expand_path("../templates", __FILE__)
-        LAYOUT_TEMPLATE = erb_template(File.join("layouts", "application.html.erb"))
+        TEMPLATES_DIR = File.expand_path('../templates', __FILE__)
+        LAYOUT_TEMPLATE = erb_template(File.join('layouts', 'application.html.erb'))
 
         include ViewHelpers
 
@@ -29,11 +28,13 @@ module Rubycritic
         end
 
         def file_name
-          raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
+          fail NotImplementedError,
+               "The #{self.class} class must implement the #{__method__} method."
         end
 
         def render
-          raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
+          fail NotImplementedError,
+               "The #{self.class} class must implement the #{__method__} method."
         end
 
         private
@@ -46,7 +47,6 @@ module Rubycritic
           binding
         end
       end
-
     end
   end
 end

data/lib/rubycritic/generators/html/code_file.rb

@@ -1,13 +1,12 @@
-require "rubycritic/generators/html/base"
-require "rubycritic/generators/html/line"
+require 'rubycritic/generators/html/base'
+require 'rubycritic/generators/html/line'
 
 module Rubycritic
   module Generator
     module Html
-
       class CodeFile < Base
         LINE_NUMBER_OFFSET = 1
-        TEMPLATE = erb_template("code_file.html.erb")
+        TEMPLATE = erb_template('code_file.html.erb')
 
         def initialize(analysed_module)
           @analysed_module = analysed_module
@@ -19,11 +18,11 @@ module Rubycritic
         end
 
         def file_name
-          @pathname.basename.sub_ext(".html")
+          @pathname.basename.sub_ext('.html')
         end
 
         def render
-          file_code = ""
+          file_code = ''
           File.readlines(@pathname).each.with_index(LINE_NUMBER_OFFSET) do |line_text, line_number|
             location = Location.new(@pathname, line_number)
             line_smells = @analysed_module.smells_at_location(location)
@@ -34,7 +33,6 @@ module Rubycritic
           LAYOUT_TEMPLATE.result(get_binding { file_body })
         end
       end
-
     end
   end
 end

data/lib/rubycritic/generators/html/code_index.rb

@@ -1,18 +1,17 @@
-require "rubycritic/generators/html/base"
+require 'rubycritic/generators/html/base'
 
 module Rubycritic
   module Generator
     module Html
-
       class CodeIndex < Base
-        TEMPLATE = erb_template("code_index.html.erb")
+        TEMPLATE = erb_template('code_index.html.erb')
 
         def initialize(analysed_modules)
           @analysed_modules = analysed_modules
         end
 
         def file_name
-          "code_index.html"
+          'code_index.html'
         end
 
         def render
@@ -20,7 +19,6 @@ module Rubycritic
           LAYOUT_TEMPLATE.result(get_binding { index_body })
         end
       end
-
     end
   end
 end

data/lib/rubycritic/generators/html/line.rb

@@ -1,13 +1,12 @@
-require "cgi"
-require "rubycritic/generators/html/base"
+require 'cgi'
+require 'rubycritic/generators/html/base'
 
 module Rubycritic
   module Generator
     module Html
-
       class Line < Base
-        NORMAL_TEMPLATE = erb_template("line.html.erb")
-        SMELLY_TEMPLATE = erb_template("smelly_line.html.erb")
+        NORMAL_TEMPLATE = erb_template('line.html.erb')
+        SMELLY_TEMPLATE = erb_template('smelly_line.html.erb')
 
         attr_reader :file_directory
 
@@ -31,7 +30,6 @@ module Rubycritic
           end
         end
       end
-
     end
   end
 end

data/lib/rubycritic/generators/html/overview.rb

@@ -1,12 +1,11 @@
-require "rubycritic/generators/html/base"
-require "rubycritic/generators/html/turbulence"
+require 'rubycritic/generators/html/base'
+require 'rubycritic/generators/html/turbulence'
 
 module Rubycritic
   module Generator
     module Html
-
       class Overview < Base
-        TEMPLATE = erb_template("overview.html.erb")
+        TEMPLATE = erb_template('overview.html.erb')
 
         def initialize(analysed_modules)
           @turbulence_data = Turbulence.data(analysed_modules)
@@ -15,7 +14,7 @@ module Rubycritic
         end
 
         def file_name
-          "overview.html"
+          'overview.html'
         end
 
         def render
@@ -23,7 +22,6 @@ module Rubycritic
           LAYOUT_TEMPLATE.result(get_binding { index_body })
         end
       end
-
     end
   end
 end

data/lib/rubycritic/generators/html/smells_index.rb

@@ -1,11 +1,10 @@
-require "rubycritic/generators/html/base"
+require 'rubycritic/generators/html/base'
 
 module Rubycritic
   module Generator
     module Html
-
       class SmellsIndex < Base
-        TEMPLATE = erb_template("smells_index.html.erb")
+        TEMPLATE = erb_template('smells_index.html.erb')
 
         def initialize(analysed_modules)
           @smells = analysed_modules.flat_map(&:smells).uniq
@@ -14,7 +13,7 @@ module Rubycritic
         end
 
         def file_name
-          "smells_index.html"
+          'smells_index.html'
         end
 
         def render
@@ -32,7 +31,6 @@ module Rubycritic
           names
         end
       end
-
     end
   end
 end

data/lib/rubycritic/generators/html/turbulence.rb

@@ -1,17 +1,15 @@
-require "json"
+require 'json'
 
 module Rubycritic
-
   module Turbulence
     def self.data(analysed_modules)
       analysed_modules.map do |analysed_module|
         {
-          :name => analysed_module.name,
-          :x => analysed_module.churn,
-          :y => analysed_module.complexity
+          name: analysed_module.name,
+          x: analysed_module.churn,
+          y: analysed_module.complexity
         }
       end.to_json
     end
   end
-
 end

data/lib/rubycritic/generators/html/view_helpers.rb

@@ -1,5 +1,4 @@
 module Rubycritic
-
   module ViewHelpers
     def timeago_tag(time)
       "<time class='js-timeago' datetime='#{time}'>#{time}</time>"
@@ -32,12 +31,13 @@ module Rubycritic
     end
 
     def file_directory
-      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
+      fail NotImplementedError,
+           "The #{self.class} class must implement the #{__method__} method."
     end
 
     def root_directory
-      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
+      fail NotImplementedError,
+           "The #{self.class} class must implement the #{__method__} method."
     end
   end
-
 end

data/lib/rubycritic/generators/html_report.rb

@@ -1,14 +1,14 @@
-require "fileutils"
-require "rubycritic/generators/html/overview"
-require "rubycritic/generators/html/smells_index"
-require "rubycritic/generators/html/code_index"
-require "rubycritic/generators/html/code_file"
+require 'fileutils'
+require 'rubycritic/configuration'
+require 'rubycritic/generators/html/overview'
+require 'rubycritic/generators/html/smells_index'
+require 'rubycritic/generators/html/code_index'
+require 'rubycritic/generators/html/code_file'
 
 module Rubycritic
   module Generator
-
     class HtmlReport
-      ASSETS_DIR = File.expand_path("../html/assets", __FILE__)
+      ASSETS_DIR = File.expand_path('../html/assets', __FILE__)
 
       def initialize(analysed_modules)
         @analysed_modules = analysed_modules
@@ -18,6 +18,11 @@ module Rubycritic
         create_directories_and_files
         copy_assets_to_report_directory
         puts "New critique at #{report_location}"
+        browser.open unless Config.no_browser
+      end
+
+      def browser
+        @browser ||= Rubycritic::Browser.new(report_location)
       end
 
       private
@@ -25,7 +30,7 @@ module Rubycritic
       def create_directories_and_files
         Array(generators).each do |generator|
           FileUtils.mkdir_p(generator.file_directory)
-          File.open(generator.file_pathname, "w+") do |file|
+          File.open(generator.file_pathname, 'w+') do |file|
             file.write(generator.render)
           end
         end
@@ -61,6 +66,5 @@ module Rubycritic
         overview_generator.file_href
       end
     end
-
   end
 end

data/lib/rubycritic/generators/json/simple.rb

@@ -1,10 +1,9 @@
-require "json"
-require "rubycritic/version"
+require 'json'
+require 'rubycritic/version'
 
 module Rubycritic
   module Generator
     module Json
-
       class Simple
         def initialize(analysed_modules)
           @analysed_modules = analysed_modules
@@ -16,17 +15,16 @@ module Rubycritic
 
         def data
           {
-            :metadata => {
-              :rubycritic => {
-                :version => Rubycritic::VERSION
+            metadata: {
+              rubycritic: {
+                version: Rubycritic::VERSION
               }
             },
-            :analysed_modules => @analysed_modules,
-            :score => @analysed_modules.score
+            analysed_modules: @analysed_modules,
+            score: @analysed_modules.score
           }
         end
       end
-
     end
   end
 end