ruby-pardot 1.3.2 → 1.4.0

data/spec/pardot/objects/visitor_activities_spec.rb

@@ -1,65 +1,61 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+# frozen_string_literal: true
+
+require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper")
 
 describe Pardot::Objects::VisitorActivities do
-  
-  before do
-    @client = create_client
-  end
-  
-  describe "query" do
-    
-    def sample_results
-      %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="ok" version="1.0">
-        <result>
-          <total_results>2</total_results>
-          <visitorActivity>
-            <type_name>Read</type_name>
-            <details>Some details</details>
-          </visitorActivity>
-          <visitorActivity>
-            <type_name>Write</type_name>
-            <details>More details</details>
-          </visitorActivity>
-        </result>
-      </rsp>)
-    end
-    
-    before do
-      @client = create_client
-    end
-    
-    it "should take in some arguments" do
-      fake_get "/api/visitorActivity/version/3/do/query?id_greater_than=200&format=simple", sample_results
-      
-      expect(@client.visitor_activities.query(:id_greater_than => 200)).to eq({"total_results" => 2, 
-        "visitorActivity"=>[
-          {"type_name"=>"Read", "details"=>"Some details"}, 
-          {"type_name"=>"Write", "details"=>"More details"}
-        ]})
-      assert_authorization_header
-    end
-    
-  end
-  
-  describe "read" do
-    
-    def sample_results
-      %(<?xml version="1.0" encoding="UTF-8"?>
-      <rsp stat="ok" version="1.0">
-        <visitorActivity>
-          <type_name>Write</type_name>
-          <details>More details</details>
-        </visitorActivity>
-      </rsp>)
-    end
-    
-    it "should return the prospect" do
-      fake_post "/api/visitorActivity/version/3/do/read/id/10?format=simple", sample_results
-      
-      expect(@client.visitor_activities.read(10)).to eq({"details"=>"More details", "type_name"=>"Write"})
-      assert_authorization_header
+  create_auth_managers.each do |auth_manager|
+    context auth_manager.test_name_suffix do
+      let(:client) { auth_manager.create_client }
+
+      describe 'query' do
+        def sample_results
+          %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="ok" version="1.0">
+            <result>
+              <total_results>2</total_results>
+              <visitorActivity>
+                <type_name>Read</type_name>
+                <details>Some details</details>
+              </visitorActivity>
+              <visitorActivity>
+                <type_name>Write</type_name>
+                <details>More details</details>
+              </visitorActivity>
+            </result>
+          </rsp>)
+        end
+
+        it 'should take in some arguments' do
+          fake_get '/api/visitorActivity/version/3/do/query?id_greater_than=200&format=simple', sample_results
+
+          expect(client.visitor_activities.query(id_greater_than: 200)).to eq({ 'total_results' => 2,
+                                                                                'visitorActivity' => [
+                                                                                  { 'type_name' => 'Read',
+                                                                                    'details' => 'Some details' },
+                                                                                  { 'type_name' => 'Write',
+                                                                                    'details' => 'More details' }
+                                                                                ] })
+          assert_authorization_header auth_manager
+        end
+      end
+
+      describe 'read' do
+        def sample_results
+          %(<?xml version="1.0" encoding="UTF-8"?>
+          <rsp stat="ok" version="1.0">
+            <visitorActivity>
+              <type_name>Write</type_name>
+              <details>More details</details>
+            </visitorActivity>
+          </rsp>)
+        end
+
+        it 'should return the prospect' do
+          fake_post '/api/visitorActivity/version/3/do/read/id/10?format=simple', sample_results
+
+          expect(client.visitor_activities.read(10)).to eq({ 'details' => 'More details', 'type_name' => 'Write' })
+          assert_authorization_header auth_manager
+        end
+      end
     end
-    
   end
-  
-end
+end

data/spec/pardot/objects/visitors_spec.rb

@@ -1,65 +1,60 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+# frozen_string_literal: true
+
+require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper")
 
 describe Pardot::Objects::Visitors do
-  
-  before do
-    @client = create_client
-  end
-  
-  describe "query" do
-    
-    def sample_results
-      %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="ok" version="1.0">
-        <result>
-          <total_results>2</total_results>
-          <visitor>
-            <browser>Firefox</browser>
-            <language>en</language>
-          </visitor>
-          <visitor>
-            <browser>Chrome</browser>
-            <language>es</language>
-          </visitor>
-        </result>
-      </rsp>)
-    end
-    
-    before do
-      @client = create_client
-    end
-    
-    it "should take in some arguments" do
-      fake_get "/api/visitor/version/3/do/query?id_greater_than=200&format=simple", sample_results
-      
-      expect(@client.visitors.query(:id_greater_than => 200)).to eq({"total_results" => 2, 
-        "visitor"=>[
-          {"browser"=>"Firefox", "language"=>"en"}, 
-          {"browser"=>"Chrome", "language"=>"es"}
-        ]})
-      assert_authorization_header
-    end
-    
-  end
-  
-  describe "assign" do
-    
-    def sample_results
-      %(<?xml version="1.0" encoding="UTF-8"?>
-      <rsp stat="ok" version="1.0">
-        <visitor>
-          <browser>Chrome</browser>
-          <language>es</language>
-        </visitor>
-      </rsp>)
-    end
-    
-    it "should return the prospect" do
-      fake_post "/api/visitor/version/3/do/assign/id/10?type=Good&format=simple&name=Jim", sample_results
-      
-      expect(@client.visitors.assign(10, :name => "Jim", :type => "Good")).to eq({"browser"=>"Chrome", "language"=>"es"})
-      assert_authorization_header
+  create_auth_managers.each do |auth_manager|
+    context auth_manager.test_name_suffix do
+      let(:client) { auth_manager.create_client }
+      describe 'query' do
+        def sample_results
+          %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="ok" version="1.0">
+            <result>
+              <total_results>2</total_results>
+              <visitor>
+                <browser>Firefox</browser>
+                <language>en</language>
+              </visitor>
+              <visitor>
+                <browser>Chrome</browser>
+                <language>es</language>
+              </visitor>
+            </result>
+          </rsp>)
+        end
+
+        it 'should take in some arguments' do
+          fake_get '/api/visitor/version/3/do/query?id_greater_than=200&format=simple', sample_results
+
+          expect(client.visitors.query(id_greater_than: 200)).to eq({ 'total_results' => 2,
+                                                                      'visitor' => [
+                                                                        { 'browser' => 'Firefox',
+                                                                          'language' => 'en' },
+                                                                        { 'browser' => 'Chrome', 'language' => 'es' }
+                                                                      ] })
+          assert_authorization_header auth_manager
+        end
+      end
+
+      describe 'assign' do
+        def sample_results
+          %(<?xml version="1.0" encoding="UTF-8"?>
+          <rsp stat="ok" version="1.0">
+            <visitor>
+              <browser>Chrome</browser>
+              <language>es</language>
+            </visitor>
+          </rsp>)
+        end
+
+        it 'should return the prospect' do
+          fake_post '/api/visitor/version/3/do/assign/id/10?type=Good&format=simple&name=Jim', sample_results
+
+          expect(client.visitors.assign(10, name: 'Jim',
+                                            type: 'Good')).to eq({ 'browser' => 'Chrome', 'language' => 'es' })
+          assert_authorization_header auth_manager
+        end
+      end
     end
-    
   end
-  
-end
+end

data/spec/pardot/objects/visits_spec.rb

@@ -1,65 +1,60 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+# frozen_string_literal: true
+
+require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper")
 
 describe Pardot::Objects::Visits do
-  
-  before do
-    @client = create_client
-  end
-  
-  describe "query" do
-    
-    def sample_results
-      %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="ok" version="1.0">
-        <result>
-          <total_results>2</total_results>
-          <visit>
-            <duration_in_seconds>50</duration_in_seconds>
-            <visitor_page_view_count>3</visitor_page_view_count>
-          </visit>
-          <visit>
-            <duration_in_seconds>10</duration_in_seconds>
-            <visitor_page_view_count>1</visitor_page_view_count>
-          </visit>
-        </result>
-      </rsp>)
-    end
-    
-    before do
-      @client = create_client
-    end
-    
-    it "should take in some arguments" do
-      fake_get "/api/visit/version/3/do/query?id_greater_than=200&format=simple", sample_results
-      
-      expect(@client.visits.query(:id_greater_than => 200)).to eq({"total_results" => 2, 
-        "visit"=>[
-          {"duration_in_seconds"=>"50", "visitor_page_view_count"=>"3"}, 
-          {"duration_in_seconds"=>"10", "visitor_page_view_count"=>"1"}
-        ]})
-      assert_authorization_header
-    end
-    
-  end
-  
-  describe "read" do
-    
-    def sample_results
-      %(<?xml version="1.0" encoding="UTF-8"?>
-      <rsp stat="ok" version="1.0">
-        <visit>
-          <duration_in_seconds>10</duration_in_seconds>
-          <visitor_page_view_count>1</visitor_page_view_count>
-        </visit>
-      </rsp>)
-    end
-    
-    it "should return the prospect" do
-      fake_post "/api/visit/version/3/do/read/id/10?format=simple", sample_results
-      
-      expect(@client.visits.read(10)).to eq({"visitor_page_view_count"=>"1", "duration_in_seconds"=>"10"})
-      assert_authorization_header
+  create_auth_managers.each do |auth_manager|
+    context auth_manager.test_name_suffix do
+      let(:client) { auth_manager.create_client }
+      describe 'query' do
+        def sample_results
+          %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="ok" version="1.0">
+            <result>
+              <total_results>2</total_results>
+              <visit>
+                <duration_in_seconds>50</duration_in_seconds>
+                <visitor_page_view_count>3</visitor_page_view_count>
+              </visit>
+              <visit>
+                <duration_in_seconds>10</duration_in_seconds>
+                <visitor_page_view_count>1</visitor_page_view_count>
+              </visit>
+            </result>
+          </rsp>)
+        end
+
+        it 'should take in some arguments' do
+          fake_get '/api/visit/version/3/do/query?id_greater_than=200&format=simple', sample_results
+
+          expect(client.visits.query(id_greater_than: 200)).to eq({ 'total_results' => 2,
+                                                                    'visit' => [
+                                                                      { 'duration_in_seconds' => '50',
+                                                                        'visitor_page_view_count' => '3' },
+                                                                      { 'duration_in_seconds' => '10',
+                                                                        'visitor_page_view_count' => '1' }
+                                                                    ] })
+          assert_authorization_header auth_manager
+        end
+      end
+
+      describe 'read' do
+        def sample_results
+          %(<?xml version="1.0" encoding="UTF-8"?>
+          <rsp stat="ok" version="1.0">
+            <visit>
+              <duration_in_seconds>10</duration_in_seconds>
+              <visitor_page_view_count>1</visitor_page_view_count>
+            </visit>
+          </rsp>)
+        end
+
+        it 'should return the prospect' do
+          fake_post '/api/visit/version/3/do/read/id/10?format=simple', sample_results
+
+          expect(client.visits.read(10)).to eq({ 'visitor_page_view_count' => '1', 'duration_in_seconds' => '10' })
+          assert_authorization_header auth_manager
+        end
+      end
     end
-    
   end
-  
-end
+end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubygems'
 require 'cgi'
 require 'tempfile'

data/spec/support/client_support.rb

@@ -1,6 +1,42 @@
+# frozen_string_literal: true
 
-def create_client
-  @client = Pardot::Client.new "user@test.com", "foo", "bar"
-  @client.api_key = "my_api_key"
-  @client
+def create_auth_managers
+  [UsernamePasswordAuthManager.new, SalesforceAccessTokenAuthManager.new]
+end
+
+class UsernamePasswordAuthManager
+  attr_accessor :test_name_suffix, :expected_authorization_header
+
+  def initialize
+    @test_name_suffix = 'With UsernamePassword Auth'
+    @expected_authorization_header = 'Pardot api_key=my_api_key, user_key=bar'
+  end
+
+  def create_client
+    client = Pardot::Client.new 'user@test.com', 'foo', 'bar'
+    client.api_key = 'my_api_key'
+    client
+  end
+
+  def has_business_unit_id_header?
+    false
+  end
+end
+
+class SalesforceAccessTokenAuthManager
+  attr_accessor :test_name_suffix, :expected_authorization_header, :expected_business_unit_id_header
+
+  def initialize
+    @test_name_suffix = 'With Salesforce OAuth'
+    @expected_authorization_header = 'Bearer access_token_value'
+    @expected_business_unit_id_header = '0Uv000000000001CAA'
+  end
+
+  def create_client
+    Pardot::Client.new nil, nil, nil, 3, 'access_token_value', '0Uv000000000001CAA'
+  end
+
+  def has_business_unit_id_header?
+    false
+  end
 end

data/spec/support/fakeweb.rb

@@ -1,18 +1,23 @@
+# frozen_string_literal: true
+
 require 'fakeweb'
 FakeWeb.allow_net_connect = false
 
-def fake_post path, response
-  FakeWeb.register_uri(:post, "https://pi.pardot.com#{path}", :body => response)
+def fake_post(path, response)
+  FakeWeb.register_uri(:post, "https://pi.pardot.com#{path}", body: response)
 end
 
-def fake_get path, response
-  FakeWeb.register_uri(:get, "https://pi.pardot.com#{path}", :body => response)
+def fake_get(path, response)
+  FakeWeb.register_uri(:get, "https://pi.pardot.com#{path}", body: response)
 end
 
-def fake_authenticate client, api_key
+def fake_authenticate(client, api_key)
   client.api_key = api_key
 end
 
-def assert_authorization_header
-  expect(FakeWeb.last_request[:authorization]).to eq('Pardot api_key=my_api_key, user_key=bar')
-end
+def assert_authorization_header(auth_manager)
+  expect(FakeWeb.last_request[:authorization]).to eq(auth_manager.expected_authorization_header)
+  if auth_manager.has_business_unit_id_header?
+    expect(FakeWeb.last_request['Business-Unit-Id']).to eq(auth_manager.expected_business_unit_id_header)
+  end
+end