ruby-pardot 1.3.2 → 1.4.0

data/lib/pardot/objects/emails.rb

@@ -1,44 +1,39 @@
 module Pardot
   module Objects
-
     module Emails
-
       def emails
         @emails ||= Emails.new self
       end
 
       class Emails
-
-        def initialize client
+        def initialize(client)
           @client = client
         end
 
-        def read_by_id id
+        def read_by_id(id)
           get "/do/read/id/#{id}"
         end
 
-        def send_to_prospect prospect_id, params
+        def send_to_prospect(prospect_id, params)
           post "/do/send/prospect_id/#{prospect_id}", params
         end
 
-        def send_to_list params
-          post "/do/send", params
+        def send_to_list(params)
+          post '/do/send', params
         end
 
         protected
 
-        def get path, params = {}, result = "email"
-          response = @client.get "email", path, params
+        def get(path, params = {}, result = 'email')
+          response = @client.get 'email', path, params
           result ? response[result] : response
         end
 
-        def post path, params = {}, result = "email"
-          response = @client.post "email", path, params
+        def post(path, params = {}, result = 'email')
+          response = @client.post 'email', path, params
           result ? response[result] : response
         end
-
       end
-
     end
   end
 end

data/lib/pardot/objects/list_memberships.rb

@@ -1,36 +1,32 @@
 module Pardot
   module Objects
     module ListMemberships
-
       def list_memberships
         @list_memberships ||= ListMemberships.new self
       end
 
       class ListMemberships
-
-        def initialize client
+        def initialize(client)
           @client = client
         end
 
-        def query params
-          result = get "/do/query", params, "result"
-          result["total_results"] = result["total_results"].to_i if result["total_results"]
+        def query(params)
+          result = get '/do/query', params, 'result'
+          result['total_results'] = result['total_results'].to_i if result['total_results']
           result
         end
 
-        def read_by_id id, params = {}
+        def read_by_id(id, params = {})
           get "/do/read/id/#{id}", params
         end
 
         protected
 
-        def get path, params = {}, result = "listMembership"
-          response = @client.get "listMembership", path, params
+        def get(path, params = {}, result = 'listMembership')
+          response = @client.get 'listMembership', path, params
           result ? response[result] : response
         end
-
       end
-
     end
   end
-end
+end

data/lib/pardot/objects/lists.rb

@@ -1,50 +1,45 @@
 module Pardot
   module Objects
-    
     module Lists
-      
       def lists
         @lists ||= Lists.new self
       end
-      
+
       class Lists
-        
-        def initialize client
+        def initialize(client)
           @client = client
         end
-        
-        def create id, params = {}
-          post "/do/create", params
+
+        def create(_id, params = {})
+          post '/do/create', params
         end
-        
-        def query params
-          result = get "/do/query", params, "result"
-          result["total_results"] = result["total_results"].to_i if result["total_results"]
+
+        def query(params)
+          result = get '/do/query', params, 'result'
+          result['total_results'] = result['total_results'].to_i if result['total_results']
           result
         end
-        
-        def read_by_id id, params = {}
+
+        def read_by_id(id, params = {})
           get "/do/read/id/#{id}", params
         end
-        
-        def update id, params = {}
+
+        def update(id, _params = {})
           post "/do/update/#{id}"
         end
-        
+
         protected
-        
-        def get path, params = {}, result = "list"
-          response = @client.get "list", path, params
+
+        def get(path, params = {}, result = 'list')
+          response = @client.get 'list', path, params
           result ? response[result] : response
         end
-        
-        def post path, params = {}, result = "list"
-          response = @client.post "list", path, params
+
+        def post(path, params = {}, result = 'list')
+          response = @client.post 'list', path, params
           result ? response[result] : response
         end
-        
       end
-      
     end
   end
 end

data/lib/pardot/objects/opportunities.rb

@@ -1,54 +1,49 @@
 module Pardot
   module Objects
-    
     module Opportunities
-      
       def opportunities
         @opportunities ||= Opportunities.new self
       end
-      
+
       class Opportunities
-        
-        def initialize client
+        def initialize(client)
           @client = client
         end
-        
-        def query params
-          result = get "/do/query", params, "result"
-          result["total_results"] = result["total_results"].to_i if result["total_results"]
+
+        def query(params)
+          result = get '/do/query', params, 'result'
+          result['total_results'] = result['total_results'].to_i if result['total_results']
           result
         end
-        
-        def create_by_email email, params = {}
+
+        def create_by_email(email, params = {})
           post "/do/create/prospect_email/#{email}", params
         end
-        
-        def create_by_id prospect_id, params = {}
+
+        def create_by_id(prospect_id, params = {})
           post "/do/create/prospect_id/#{prospect_id}", params
         end
-        
-        def read_by_id id, params = {}
+
+        def read_by_id(id, params = {})
           post "/do/read/id/#{id}", params
         end
-        
-        def update_by_id id, params = {}
+
+        def update_by_id(id, params = {})
           post "/do/update/id/#{id}", params
         end
-        
+
         protected
-        
-        def get path, params = {}, result = "opportunity"
-          response = @client.get "opportunity", path, params
+
+        def get(path, params = {}, result = 'opportunity')
+          response = @client.get 'opportunity', path, params
           result ? response[result] : response
         end
-        
-        def post path, params = {}, result = "opportunity"
-          response = @client.post "opportunity", path, params
+
+        def post(path, params = {}, result = 'opportunity')
+          response = @client.post 'opportunity', path, params
           result ? response[result] : response
         end
-        
       end
-      
     end
   end
 end

data/lib/pardot/objects/prospect_accounts.rb

@@ -6,7 +6,6 @@ module Pardot
       end
 
       class ProspectAccounts
-
         def initialize(client)
           @client = client
         end
@@ -18,18 +17,18 @@ module Pardot
           result
         end
 
-        def describe(params={})
+        def describe(params = {})
           post('/do/describe', params)
         end
 
-        def create(params={})
+        def create(params = {})
           post('/do/create', params)
         end
 
         # read_by_id
         # update_by_id
-        [:read, :update].each do |verb|
-          define_method(verb) do |id, params={}|
+        %i[read update].each do |verb|
+          define_method(verb) do |id, params = {}|
             post(api_url(verb, 'id', id), params)
           end
         end
@@ -40,12 +39,12 @@ module Pardot
           "/do/#{verb}/#{direct_to}/#{value}"
         end
 
-        def get(path, params={}, result='prospectAccount')
+        def get(path, params = {}, result = 'prospectAccount')
           response = @client.get('prospectAccount', path, params)
           result ? response[result] : response
         end
 
-        def post(path, params={}, result='prospectAccount')
+        def post(path, params = {}, result = 'prospectAccount')
           response = @client.post('prospectAccount', path, params)
           result ? response[result] : response
         end

data/lib/pardot/objects/prospects.rb

@@ -3,109 +3,105 @@ require 'cgi'
 module Pardot
   module Objects
     module Prospects
-
       def prospects
         @prospects ||= Prospects.new self
       end
 
       class Prospects
-
-        def initialize client
+        def initialize(client)
           @client = client
         end
 
-        def query search_criteria
-          result = get "/do/query", search_criteria, "result"
-          result["total_results"] = result["total_results"].to_i if result["total_results"]
+        def query(search_criteria)
+          result = get '/do/query', search_criteria, 'result'
+          result['total_results'] = result['total_results'].to_i if result['total_results']
           result
         end
 
-        def assign_by_email email, params
+        def assign_by_email(email, params)
           post "/do/assign/email/#{CGI.escape(email)}", params
         end
 
-        def assign_by_id id, params
+        def assign_by_id(id, params)
           post "/do/assign/id/#{CGI.escape(id)}", params
         end
 
-        def assign_by_fid fid, params
+        def assign_by_fid(fid, params)
           post "/do/assign/fid/#{CGI.escape(fid)}", params
         end
 
-        def create email, params = {}
+        def create(email, params = {})
           post "/do/create/email/#{CGI.escape(email)}", params
         end
 
-        def delete_by_id id, params = {}
+        def delete_by_id(id, params = {})
           post "/do/delete/id/#{CGI.escape(id)}", params
         end
 
-        def delete_by_fid fid, params = {}
+        def delete_by_fid(fid, params = {})
           post "/do/delete/fid/#{CGI.escape(fid)}", params
         end
 
-        def read_by_email email, params = {}
+        def read_by_email(email, params = {})
           post "/do/read/email/#{CGI.escape(email)}", params
         end
 
-        def read_by_id id, params = {}
+        def read_by_id(id, params = {})
           post "/do/read/id/#{CGI.escape(id)}", params
         end
 
-        def read_by_fid fid, params = {}
+        def read_by_fid(fid, params = {})
           post "/do/read/fid/#{CGI.escape(fid)}", params
         end
 
-        def unassign_by_email email, params = {}
+        def unassign_by_email(email, params = {})
           post "/do/unassign/email/#{CGI.escape(email)}", params
         end
 
-        def unassign_by_id id, params = {}
+        def unassign_by_id(id, params = {})
           post "/do/unassign/id/#{CGI.escape(id)}", params
         end
 
-        def unassign_by_fid fid, params = {}
+        def unassign_by_fid(fid, params = {})
           post "/do/unassign/fid/#{CGI.escape(fid)}", params
         end
 
-        def update_by_email email, params = {}
+        def update_by_email(email, params = {})
           post "/do/update/email/#{CGI.escape(email)}", params
         end
 
-        def update_by_id id, params = {}
+        def update_by_id(id, params = {})
           post "/do/update/id/#{CGI.escape(id)}", params
         end
 
-        def update_by_fid fid, params = {}
+        def update_by_fid(fid, params = {})
           post "/do/update/fid/#{CGI.escape(fid)}", params
         end
 
-        def upsert_by_email email, params = {}
+        def upsert_by_email(email, params = {})
           post "/do/upsert/email/#{CGI.escape(email)}", params
         end
 
-        def upsert_by_id id, params = {}
+        def upsert_by_id(id, params = {})
           post "/do/upsert/id/#{CGI.escape(id)}", params
         end
 
-        def upsert_by_fid fid, params = {}
+        def upsert_by_fid(fid, params = {})
           post "/do/upsert/fid/#{CGI.escape(fid)}", params
         end
 
         protected
 
-        def get path, params = {}, result = "prospect"
-          response = @client.get "prospect", path, params
+        def get(path, params = {}, result = 'prospect')
+          response = @client.get 'prospect', path, params
           result ? response[result] : response
         end
 
-        def post path, params = {}, result = "prospect"
-          response = @client.post "prospect", path, params
+        def post(path, params = {}, result = 'prospect')
+          response = @client.post 'prospect', path, params
           result ? response[result] : response
         end
-
       end
-
     end
   end
 end

data/lib/pardot/objects/users.rb

@@ -1,45 +1,41 @@
 module Pardot
   module Objects
     module Users
-      
       def users
         @users ||= Users.new self
       end
-      
+
       class Users
-        
-        def initialize client
+        def initialize(client)
           @client = client
         end
-        
-        def query params
-          result = get "/do/query", params, "result"
-          result["total_results"] = result["total_results"].to_i if result["total_results"]
+
+        def query(params)
+          result = get '/do/query', params, 'result'
+          result['total_results'] = result['total_results'].to_i if result['total_results']
           result
         end
-        
-        def read_by_email email, params = {}
+
+        def read_by_email(email, params = {})
           post "/do/read/email/#{email}", params
         end
-        
-        def read_by_id id, params = {}
+
+        def read_by_id(id, params = {})
           post "/do/read/id/#{id}", params
         end
-        
+
         protected
-        
-        def get path, params = {}, result = "user"
-          response = @client.get "user", path, params
+
+        def get(path, params = {}, result = 'user')
+          response = @client.get 'user', path, params
           result ? response[result] : response
         end
-        
-        def post path, params = {}, result = "user"
-          response = @client.post "user", path, params
+
+        def post(path, params = {}, result = 'user')
+          response = @client.post 'user', path, params
           result ? response[result] : response
         end
-        
       end
-      
     end
   end
 end