ruby-pardot 1.3.2 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e618137557812f8899ff1d06b37bedb49d72cc51e191a091c15b5135780e3bd5
-  data.tar.gz: 22b0992ead0f91fa432af3ccfbad1ea1b1cb65080c7898b8ed9cc9695fbcfa64
+  metadata.gz: 9d135372bc02b957ea7f65dca69f08405a6b6ef3c2a1a62c95e26570daf13b21
+  data.tar.gz: 57d82933ff9755c178f807dfe4d6cb879043e4e7596eb8a334278cced3a8fac4
 SHA512:
-  metadata.gz: 3038da0a48d2608cb4395e4ec8ce0a8fcbd3962357279a4ce76b9e74eb936ea22f4942ded8261aa9507af0bb93501b0a07a8c91b05f1fdb6c1b7fb3cf188c87a
-  data.tar.gz: 7fffe6dd67e999a0c294c170dea8929e2885b4957d08bdfc812338696497db02af39015751fed5ea708b9e5090d09fbbb8594f20b548ad4c5a1d5e16e0b5577f
+  metadata.gz: aa3dfe9f4c8081ebced940fc0e422f6b5d80a72c32046fbf331abc0ca5497598093f0ff7cb00d7ff1c3ec19a62f8c551198675725fd052bcd95b18edab3c3cbe
+  data.tar.gz: 11269265532b8065240c8fc122420bcd9462d44d6198902291804de8711731c4ca62593f98bbdf0aea450e6783792c3826253ef04ef5dfcf7fd13a9a114aedd0

data/.gitignore

@@ -1,3 +1,5 @@
 pkg/*
 *.gem
 .bundle
+.vscode
+bin

data/.rubocop.yml

@@ -0,0 +1,9 @@
+AllCops:
+  NewCops: enable
+
+Metrics/BlockLength:
+  Enabled: false
+Metrics/MethodLength:
+  Enabled: false
+Layout/LineLength:
+  Enabled: false

data/Gemfile

@@ -1,4 +1,6 @@
-source :gemcutter
+# frozen_string_literal: true
+
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in ruby-pardot.gemspec
 gemspec

data/Gemfile.lock

@@ -1,12 +1,12 @@
 PATH
   remote: .
   specs:
-    ruby-pardot (1.3.2)
+    ruby-pardot (1.4.0)
       crack (= 0.4.3)
       httparty (= 0.18.1)
 
 GEM
-  remote: http://rubygems.org/
+  remote: https://rubygems.org/
   specs:
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
@@ -17,7 +17,7 @@ GEM
       multi_xml (>= 0.5.2)
     mime-types (3.3.1)
       mime-types-data (~> 3.2015)
-    mime-types-data (3.2020.0512)
+    mime-types-data (3.2020.1104)
     multi_xml (0.6.0)
     rspec (3.5.0)
       rspec-core (~> 3.5.0)
@@ -39,9 +39,9 @@ PLATFORMS
 
 DEPENDENCIES
   bundler (>= 1.10)
-  fakeweb
+  fakeweb (= 1.3.0)
   rspec (= 3.5.0)
   ruby-pardot!
 
 BUNDLED WITH
-   2.1.4
+   2.2.7

data/README.rdoc

@@ -8,16 +8,18 @@ Add the following to your Gemfile
 
 === Authentication
 
-The client will authenticate before performing other API calls, but you can manually authenticate as well
+In order to use this client, an access token retrieved from Salesforce OAuth must be specified. See
+the [authetication documentation on developer.pardot.com](https://developer.pardot.com/kb/authentication/) for more information.
 
   require "ruby-pardot"
 
-  client = Pardot::Client.new email, password, user_key
-  
-  # will raise a Pardot::ResponseError if login fails
-  # will raise a Pardot::NetError if the http call fails
-  client.authenticate
-  
+  version = 3 # or 4
+  access_token = '<access_token>' # Retrieve an access token from Salesforce using OAuth
+  business_unit_id = '<business_unit_id>' # Specify the Business Unit ID of the account to access
+  client = Pardot::Client.new nil, nil, nil, version, access_token, business_unit_id
+
+Usage of the username, password, and API key authentication is deprecated and will be removed in an upcoming release.
+
 === Object Types
 
 The available objects are:
@@ -33,15 +35,15 @@ The available objects are:
 * visits
 
 === Querying Objects
-  
+
 http://developer.pardot.com/kb/api-version-3/querying-prospects
-  
+
 Most objects accept limit, offset, sort_by, and sord_order parameters
 
   prospects = client.prospects.query(:assigned => false, :sort_by => "last_activity_at", :limit => 20)
-  
+
   prospects["total_results"] # number of prospects found
-  
+
   prospects["prospect"].each do |prospect|
     puts prospect["first_name"]
   end
@@ -53,11 +55,11 @@ See each individual object's API reference page for available methods
 http://developer.pardot.com/kb/api-version-3/using-prospects
 
   prospect = client.prospects.create("user@test.com", :first_name => "John", :last_name => "Doe")
-  
+
   prospect.each do |key, value|
     puts "#{key} is #{value}"
   end
-  
+
 === Emails
 
 See each individual call's [API reference page](http://developer.pardot.com/kb/api-version-3/introduction-table-of-contents).
@@ -66,15 +68,15 @@ See each individual call's [API reference page](http://developer.pardot.com/kb/a
   @pardot.emails.read_by_id(email_id)
   @pardot.emails.send_to_list(:email_template_id => template_id, 'list_ids[]' => list_id, :campaign_id => campaign_id)
   @pardot.emails.send_to_prospect(prospect_id, :campaign_id => campaign_id, :email_template_id => template_id)
-  
+
 === Output formats
-  
+
   client.format = "simple" # default
   client.format = "mobile"
   client.format = "full"
 
 === Error handling
-  
+
 Pardot will respond with an error message when you provide invalid parameters
 
   begin
@@ -84,7 +86,7 @@ Pardot will respond with an error message when you provide invalid parameters
   end
 
 Performing API calls across the internet is inherently unsafe, so be sure to catch the exceptions
-  
+
   begin
     visitor = client.visitors.query(:id_greater_than => 200)
   rescue Pardot::NetError => e

data/Rakefile

@@ -1,11 +1,10 @@
 require 'bundler'
 Bundler::GemHelper.install_tasks
 
-
 require 'rspec/core'
 require 'rspec/core/rake_task'
 
-desc "Run all specs"
+desc 'Run all specs'
 RSpec::Core::RakeTask.new(:spec) do |t|
-  t.pattern = "./spec/**/*_spec.rb"
+  t.pattern = './spec/**/*_spec.rb'
 end

data/lib/pardot/authentication.rb

@@ -1,29 +1,40 @@
 module Pardot
   module Authentication
-    
+    # @deprecated Use of username and password authentication is deprecated.
     def authenticate
-      resp = post "login", nil, nil, nil, :email => @email, :password => @password, :user_key => @user_key
-      update_version(resp["version"]) if resp && resp["version"]
-      @api_key = resp && resp["api_key"]
+      if using_salesforce_access_token?
+        raise 'Authentication not available when using Salesforce access token. See https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/intro_oauth_and_connected_apps.htm for more information.'
+      end
+
+      warn '[DEPRECATION] Use of username and password authentication is deprecated in favor of Salesforce OAuth. See https://developer.pardot.com/kb/authentication/ for more information.'
+      resp = post 'login', nil, nil, nil, email: @email, password: @password, user_key: @user_key
+      update_version(resp['version']) if resp && resp['version']
+      @api_key = resp && resp['api_key']
     end
-    
+
     def authenticated?
-      @api_key != nil
+      !@api_key.nil? || !@salesforce_access_token.nil?
+    end
+
+    def using_salesforce_access_token?
+      @salesforce_access_token != nil
     end
-    
+
     def reauthenticate
+      if using_salesforce_access_token?
+        raise 'Reauthentication not available when using Salesforce access token. See https://developer.salesforce.com/docs/atlas.en-us.mobile_sdk.meta/mobile_sdk/oauth_refresh_token_flow.htm for more information.'
+      end
+
+      warn '[DEPRECATION] Use Salesforce OAuth to refresh the Salesforce access token. See https://developer.salesforce.com/docs/atlas.en-us.mobile_sdk.meta/mobile_sdk/oauth_refresh_token_flow.htm for more information.'
       @api_key = nil
       authenticate
     end
 
     private
 
-    def update_version version
-      if version.is_a? Array
-        version = version.last
-      end
+    def update_version(version)
+      version = version.last if version.is_a? Array
       @version = version if version.to_i > 3
     end
-
   end
 end

data/lib/pardot/client.rb

@@ -1,7 +1,5 @@
 module Pardot
-
   class Client
-
     include HTTParty
     base_uri 'https://pi.pardot.com'
     format :xml
@@ -21,16 +19,29 @@ module Pardot
     include Objects::Visits
     include Objects::VisitorActivities
 
-    attr_accessor :email, :password, :user_key, :api_key, :version, :format
+    attr_accessor :email, :password, :user_key, :api_key, :version, :salesforce_access_token, :business_unit_id, :format
+
+    # @deprecated Arguments email, password and user_key are deprecated. Use salesforce_access_token with Salesforce OAuth.
+    def initialize(email = nil, password = nil, user_key = nil, version = 3, salesforce_access_token = nil, business_unit_id = nil)
+      unless email.nil? || password.nil? || user_key.nil?
+        warn '[DEPRECATION] Use of username and password authentication is deprecated in favor of Salesforce OAuth. See https://developer.pardot.com/kb/authentication/ for more information.'
+      end
+
+      if !salesforce_access_token.nil? && business_unit_id.nil?
+        raise 'business_unit_id required when using Salesforce access_token'
+      end
+      if !business_unit_id.nil? && (!business_unit_id.start_with?('0Uv') || business_unit_id.length != 18)
+        raise "Invalid business_unit_id value. Expected ID to start with '0Uv' and be length of 18 characters."
+      end
 
-    def initialize email, password, user_key, version = 3
       @email = email
       @password = password
       @user_key = user_key
       @version = version
+      @salesforce_access_token = salesforce_access_token
+      @business_unit_id = business_unit_id
 
-      @format = "simple"
+      @format = 'simple'
     end
-
   end
 end

data/lib/pardot/error.rb

@@ -1,19 +1,23 @@
 module Pardot
   class Error < StandardError; end
+
   class NetError < Error; end
+
   class ExpiredApiKeyError < Error; end
 
+  class AccessTokenExpiredError < Error; end
+
   class ResponseError < Error
     def initialize(res)
       @res = res
     end
 
     def to_s
-      @res["__content__"]
+      @res['__content__']
     end
 
     def code
-      @res["code"].to_i
+      @res['code'].to_i
     end
 
     def inspect

data/lib/pardot/http.rb

@@ -1,77 +1,80 @@
 module Pardot
   module Http
-    
-    def get object, path, params = {}, num_retries = 0
+    def get(object, path, params = {}, num_retries = 0)
       smooth_params object, params
       full_path = fullpath object, path
       headers = create_auth_header object
-      check_response self.class.get(full_path, :query => params, :headers => headers)
-      
+      check_response self.class.get(full_path, query: params, headers: headers)
     rescue Pardot::ExpiredApiKeyError => e
       handle_expired_api_key :get, object, path, params, num_retries, e
-      
     rescue SocketError, Interrupt, EOFError, SystemCallError, Timeout::Error, MultiXml::ParseError => e
-      raise Pardot::NetError.new(e)
+      raise Pardot::NetError, e
     end
-    
-    def post object, path, params = {}, num_retries = 0, bodyParams = {}
+
+    def post(object, path, params = {}, num_retries = 0, bodyParams = {})
       smooth_params object, params
       full_path = fullpath object, path
       headers = create_auth_header object
-      check_response self.class.post(full_path, :query => params, :body => bodyParams, :headers => headers)
-      
+      check_response self.class.post(full_path, query: params, body: bodyParams, headers: headers)
     rescue Pardot::ExpiredApiKeyError => e
       handle_expired_api_key :post, object, path, params, num_retries, e
-      
     rescue SocketError, Interrupt, EOFError, SystemCallError, Timeout::Error, MultiXml::ParseError => e
-      raise Pardot::NetError.new(e)
+      raise Pardot::NetError, e
     end
-    
+
     protected
-    
-    def handle_expired_api_key method, object, path, params, num_retries, e
+
+    # @deprecated With Salesforce OAuth, this method will never be invoked.
+    def handle_expired_api_key(method, object, path, params, num_retries, e)
       raise e unless num_retries == 0
-      
+
       reauthenticate
-      
+
       send(method, object, path, params, 1)
     end
-    
-    def smooth_params object, params
-      return if object == "login"
-      
+
+    def smooth_params(object, params)
+      return if object == 'login'
+
       authenticate unless authenticated?
-      params.merge! :format => @format
+      params.merge! format: @format
     end
 
-    def create_auth_header object
-      return if object == "login"
-      { :Authorization => "Pardot api_key=#{@api_key}, user_key=#{@user_key}" }
+    def create_auth_header(object)
+      return if object == 'login'
+
+      if using_salesforce_access_token?
+        {
+          :Authorization => "Bearer #{@salesforce_access_token}",
+          'Pardot-Business-Unit-Id' => @business_unit_id
+        }
+      else
+        { Authorization: "Pardot api_key=#{@api_key}, user_key=#{@user_key}" }
+      end
     end
-    
-    def check_response http_response
-      rsp = http_response["rsp"]
-      
-      error = rsp["err"] if rsp
-      error ||= "Unknown Failure: #{rsp.inspect}" if rsp && rsp["stat"] == "fail"
+
+    def check_response(http_response)
+      rsp = http_response['rsp']
+
+      error = rsp['err'] if rsp
+      error ||= "Unknown Failure: #{rsp.inspect}" if rsp && rsp['stat'] == 'fail'
       content = error['__content__'] if error.is_a?(Hash)
-      
-      if [error, content].include?("Invalid API key or user key") && @api_key
-        raise ExpiredApiKeyError.new @api_key
+
+      if [error, content].include?('access_token is invalid') && using_salesforce_access_token?
+        raise AccessTokenExpiredError,
+              'Access token is invalid. Use Salesforce OAuth to refresh the existing Salesforce access token or to retrieve a new token. See https://developer.salesforce.com/docs/atlas.en-us.mobile_sdk.meta/mobile_sdk/oauth_refresh_token_flow.htm for more information.'
       end
-      
-      raise ResponseError.new error if error
-      
+      raise ExpiredApiKeyError, @api_key if [error, content].include?('Invalid API key or user key') && @api_key
+
+      raise ResponseError, error if error
+
       rsp
     end
-    
-    def fullpath object, path
-      full = File.join("/api", object, "version", @version.to_s)
-      unless path.nil?
-        full = File.join(full, path)
-      end
+
+    def fullpath(object, path)
+      full = File.join('/api', object, 'version', @version.to_s)
+      full = File.join(full, path) unless path.nil?
       full
     end
-    
   end
 end

data/lib/pardot/objects/custom_fields.rb

@@ -1,37 +1,33 @@
 module Pardot
   module Objects
     module CustomFields
-      
       def custom_fields
         @custom_fields ||= CustomFields.new self
       end
-      
+
       class CustomFields
-        
-        def initialize client
+        def initialize(client)
           @client = client
         end
-        
-        def query params
-          result = get "/do/query", params, "result"
-          result["total_results"] = result["total_results"].to_i if result["total_results"]
+
+        def query(params)
+          result = get '/do/query', params, 'result'
+          result['total_results'] = result['total_results'].to_i if result['total_results']
           result
         end
-        
+
         protected
-        
-        def get path, params = {}, result = "customField"
-          response = @client.get "customField", path, params
+
+        def get(path, params = {}, result = 'customField')
+          response = @client.get 'customField', path, params
           result ? response[result] : response
         end
-        
-        def post path, params = {}, result = "user"
-          response = @client.post "customField", path, params
+
+        def post(path, params = {}, result = 'user')
+          response = @client.post 'customField', path, params
           result ? response[result] : response
         end
-        
       end
-      
     end
   end
 end