ruby-pardot 1.3.2 → 1.4.0

data/spec/pardot/error_spec.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Pardot::ResponseError do
   before do
     @res = {
-      "code" => "9",
-      "__content__" => "A prospect with the specified email address already exists"
+      'code' => '9',
+      '__content__' => 'A prospect with the specified email address already exists'
     }
   end
 
@@ -21,10 +23,10 @@ describe Pardot::ResponseError do
       described_class.new(@res)
     end
     specify do
-      expect(subject.to_s).to eq(@res["__content__"])
+      expect(subject.to_s).to eq(@res['__content__'])
     end
     specify do
-      expect(subject.message).to eq(@res["__content__"])
+      expect(subject.message).to eq(@res['__content__'])
     end
   end
 

data/spec/pardot/http_spec.rb

@@ -1,133 +1,124 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+# frozen_string_literal: true
+
+require File.expand_path("#{File.dirname(__FILE__)}/../spec_helper")
 
 describe Pardot::Http do
-  
   before do
     @client = create_client
-    fake_authenticate @client, "my_api_key"
+    fake_authenticate @client, 'my_api_key'
   end
-  
+
   def create_client
-    @client = Pardot::Client.new "user@test.com", "foo", "bar"
+    @client = Pardot::Client.new 'user@test.com', 'foo', 'bar'
   end
-  
-  describe "get" do
-    
-    def get object = "foo", path = "/bar", params = {}
+
+  describe 'get' do
+    def get(object = 'foo', path = '/bar', params = {})
       @client.get object, path, params
     end
-    
-    it "should notice errors and raise them as Pardot::ResponseError" do
-      fake_get "/api/foo/version/3/bar?format=simple",
-               %(?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Login failed</err>\n</rsp>\n)
-      
 
-      expect(lambda { get }).to raise_error(Pardot::ResponseError)
+    it 'should notice errors and raise them as Pardot::ResponseError' do
+      fake_get '/api/foo/version/3/bar?format=simple',
+               %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Login failed</err>\n</rsp>\n)
+
+      expect(-> { get }).to raise_error(Pardot::ResponseError)
     end
-    
-    it "should catch and reraise SocketErrors as Pardot::NetError" do
+
+    it 'should catch and reraise SocketErrors as Pardot::NetError' do
       expect(Pardot::Client).to receive(:get).and_raise(SocketError)
-      
-      expect(lambda { get }).to raise_error(Pardot::NetError)
-    end
-    
-    it "should call handle_expired_api_key when the api key expires" do
-      fake_get "/api/foo/version/3/bar?format=simple",
-               %(?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Invalid API key or user key</err>\n</rsp>\n)
-      
+
+      expect(-> { get }).to raise_error(Pardot::NetError)
+    end
+
+    it 'should call handle_expired_api_key when the api key expires' do
+      fake_get '/api/foo/version/3/bar?format=simple',
+               %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Invalid API key or user key</err>\n</rsp>\n)
+
       expect(@client).to receive(:handle_expired_api_key)
       get
     end
-    
   end
-  
-  describe "post" do
-    
-    def post object = "foo", path = "/bar", params = {}
+
+  describe 'post' do
+    def post(object = 'foo', path = '/bar', params = {})
       @client.post object, path, params
     end
-    
-    it "should notice errors and raise them as Pardot::ResponseError" do
-      fake_post "/api/foo/version/3/bar?format=simple",
-                %(?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Login failed</err>\n</rsp>\n)
-      
-      expect(lambda { post }).to raise_error(Pardot::ResponseError)
+
+    it 'should notice errors and raise them as Pardot::ResponseError' do
+      fake_post '/api/foo/version/3/bar?format=simple',
+                %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Login failed</err>\n</rsp>\n)
+
+      expect(-> { post }).to raise_error(Pardot::ResponseError)
     end
-    
-    it "should catch and reraise SocketErrors as Pardot::NetError" do
+
+    it 'should catch and reraise SocketErrors as Pardot::NetError' do
       expect(Pardot::Client).to receive(:post).and_raise(SocketError)
-      
-      expect(lambda { post }).to raise_error(Pardot::NetError)
-    end
-    
-    it "should call handle_expired_api_key when the api key expires" do
-      fake_post "/api/foo/version/3/bar?format=simple",
-                %(?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Invalid API key or user key</err>\n</rsp>\n)
-      
+
+      expect(-> { post }).to raise_error(Pardot::NetError)
+    end
+
+    it 'should call handle_expired_api_key when the api key expires' do
+      fake_post '/api/foo/version/3/bar?format=simple',
+                %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Invalid API key or user key</err>\n</rsp>\n)
+
       expect(@client).to receive(:handle_expired_api_key)
       post
     end
-    
   end
 
-  describe "getV4" do
-    
-    def get object = "foo", path = "/bar", params = {}
-      @client.version = "4"
+  describe 'getV4' do
+    def get(object = 'foo', path = '/bar', params = {})
+      @client.version = '4'
       @client.get object, path, params
     end
-    
-    it "should notice errors and raise them as Pardot::ResponseError" do
-      fake_get "/api/foo/version/4/bar?format=simple",
-               %(?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Login failed</err>\n</rsp>\n)
-      
-      expect(lambda { get }).to raise_error(Pardot::ResponseError)
+
+    it 'should notice errors and raise them as Pardot::ResponseError' do
+      fake_get '/api/foo/version/4/bar?format=simple',
+               %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Login failed</err>\n</rsp>\n)
+
+      expect(-> { get }).to raise_error(Pardot::ResponseError)
     end
-    
-    it "should catch and reraise SocketErrors as Pardot::NetError" do
+
+    it 'should catch and reraise SocketErrors as Pardot::NetError' do
       expect(Pardot::Client).to receive(:get).and_raise(SocketError)
-      
-      expect(lambda { get }).to raise_error(Pardot::NetError)
-    end
-    
-    it "should call handle_expired_api_key when the api key expires" do
-      fake_get "/api/foo/version/4/bar?format=simple",
-               %(?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Invalid API key or user key</err>\n</rsp>\n)
-      
+
+      expect(-> { get }).to raise_error(Pardot::NetError)
+    end
+
+    it 'should call handle_expired_api_key when the api key expires' do
+      fake_get '/api/foo/version/4/bar?format=simple',
+               %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Invalid API key or user key</err>\n</rsp>\n)
+
       expect(@client).to receive(:handle_expired_api_key)
       get
     end
-    
   end
-  
-  describe "postV4" do
-    
-    def post object = "foo", path = "/bar", params = {}
-      @client.version = "4"
+
+  describe 'postV4' do
+    def post(object = 'foo', path = '/bar', params = {})
+      @client.version = '4'
       @client.post object, path, params
     end
-    
-    it "should notice errors and raise them as Pardot::ResponseError" do
-      fake_post "/api/foo/version/4/bar?format=simple",
-                %(?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Login failed</err>\n</rsp>\n)
-      
-      expect(lambda { post }).to raise_error(Pardot::ResponseError)
+
+    it 'should notice errors and raise them as Pardot::ResponseError' do
+      fake_post '/api/foo/version/4/bar?format=simple',
+                %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Login failed</err>\n</rsp>\n)
+
+      expect(-> { post }).to raise_error(Pardot::ResponseError)
     end
-    
-    it "should catch and reraise SocketErrors as Pardot::NetError" do
+
+    it 'should catch and reraise SocketErrors as Pardot::NetError' do
       expect(Pardot::Client).to receive(:post).and_raise(SocketError)
-      
-      expect(lambda { post }).to raise_error(Pardot::NetError)
-    end
-    
-    it "should call handle_expired_api_key when the api key expires" do
-      fake_post "/api/foo/version/4/bar?format=simple",
-                %(?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Invalid API key or user key</err>\n</rsp>\n)
-      
+
+      expect(-> { post }).to raise_error(Pardot::NetError)
+    end
+
+    it 'should call handle_expired_api_key when the api key expires' do
+      fake_post '/api/foo/version/4/bar?format=simple',
+                %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="fail" version="1.0">\n   <err code="15">Invalid API key or user key</err>\n</rsp>\n)
+
       expect(@client).to receive(:handle_expired_api_key)
       post
     end
-    
   end
-  
-end
+end

data/spec/pardot/objects/custom_fields_spec.rb

@@ -1,58 +1,53 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+# frozen_string_literal: true
+
+require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper")
 
 describe Pardot::Objects::CustomFields do
-  
-  before do
-    @client = create_client
-  end
-  
-  describe "query" do
-    
-    def sample_results
-      %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="ok" version="1.0">
-        <result>
-          <total_results>1</total_results>
-            <customField>
-              <created_at>2019-11-26 13:40:37</created_at>
-              <crm_id null="true" />
-              <field_id>CustomObject1574793618883</field_id>
-              <id>8932</id>
-              <is_record_multiple_responses>false</is_record_multiple_responses>
-              <is_use_values>false</is_use_values>
-              <name>Ω≈ç√∫˜µ≤≥÷</name>
-              <type>Text</type>
-              <type_id>1</type_id>
-              <updated_at>2019-11-26 13:40:37</updated_at>
-          </customField>
-        </result>
-      </rsp>)
-    end
-    
-    before do
-      @client = create_client
-    end
-    
-    it "should take in some arguments" do
-      fake_get "/api/customField/version/3/do/query?id_greater_than=200&format=simple", sample_results
-      
-      expect(@client.custom_fields.query(:id_greater_than => 200)).to eq({"total_results" => 1, 
-        "customField"=>
-          {
-            "id"=>"8932",
-            "name"=>"Ω≈ç√∫˜µ≤≥÷",
-            "field_id"=>"CustomObject1574793618883",
-            "type"=>"Text",
-            "type_id"=>"1",
-            "crm_id"=>{"null"=>"true"},
-            "is_record_multiple_responses"=>"false",
-            "is_use_values"=>"false",
-            "created_at"=>"2019-11-26 13:40:37",
-            "updated_at"=>"2019-11-26 13:40:37"
-          }
-        })
-      assert_authorization_header
+  create_auth_managers.each do |auth_manager|
+    context auth_manager.test_name_suffix do
+      let(:client) { auth_manager.create_client }
+
+      describe 'query' do
+        def sample_results
+          %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="ok" version="1.0">
+            <result>
+              <total_results>1</total_results>
+                <customField>
+                  <created_at>2019-11-26 13:40:37</created_at>
+                  <crm_id null="true" />
+                  <field_id>CustomObject1574793618883</field_id>
+                  <id>8932</id>
+                  <is_record_multiple_responses>false</is_record_multiple_responses>
+                  <is_use_values>false</is_use_values>
+                  <name>Ω≈ç√∫˜µ≤≥÷</name>
+                  <type>Text</type>
+                  <type_id>1</type_id>
+                  <updated_at>2019-11-26 13:40:37</updated_at>
+              </customField>
+            </result>
+          </rsp>)
+        end
+
+        it 'should take in some arguments' do
+          fake_get '/api/customField/version/3/do/query?id_greater_than=200&format=simple', sample_results
+
+          expect(client.custom_fields.query(id_greater_than: 200)).to eq({ 'total_results' => 1,
+                                                                           'customField' =>
+              {
+                'id' => '8932',
+                'name' => 'Ω≈ç√∫˜µ≤≥÷',
+                'field_id' => 'CustomObject1574793618883',
+                'type' => 'Text',
+                'type_id' => '1',
+                'crm_id' => { 'null' => 'true' },
+                'is_record_multiple_responses' => 'false',
+                'is_use_values' => 'false',
+                'created_at' => '2019-11-26 13:40:37',
+                'updated_at' => '2019-11-26 13:40:37'
+              } })
+          assert_authorization_header auth_manager
+        end
+      end
     end
-    
   end
-  
 end

data/spec/pardot/objects/emails_spec.rb

@@ -1,39 +1,37 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+# frozen_string_literal: true
 
-describe Pardot::Objects::Emails do
-
-  before do
-    @client = create_client
-  end
-
-  def sample_response
-    %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="ok" version="1.0">
-      <email>
-        <name>My Email</name>
-      </email>
-    </rsp>)
-  end
-
-  before do
-    @client = create_client
-  end
+require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper")
 
-  it "should take in the email ID" do
-    fake_get "/api/email/version/3/do/read/id/12?format=simple", sample_response
-    expect(@client.emails.read_by_id(12)).to eq({"name" => "My Email"})
-    assert_authorization_header
-  end
-
-  it 'should send to a prospect' do
-    fake_post '/api/email/version/3/do/send/prospect_id/42?campaign_id=765&email_template_id=86&format=simple', sample_response
-    expect(@client.emails.send_to_prospect(42, :campaign_id => 765, :email_template_id => 86)).to eq({"name" => "My Email"})
-    assert_authorization_header
-  end
-
-  it 'should send to a list' do
-    fake_post '/api/email/version/3/do/send?email_template_id=200&list_ids[]=235&campaign_id=654&format=simple', sample_response
-    expect(@client.emails.send_to_list(:email_template_id => 200, 'list_ids[]' => 235, :campaign_id => 654)).to eq({"name" => "My Email"})
-    assert_authorization_header
+describe Pardot::Objects::Emails do
+  create_auth_managers.each do |auth_manager|
+    context auth_manager.test_name_suffix do
+      let(:client) { auth_manager.create_client }
+
+      def sample_response
+        %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="ok" version="1.0">
+          <email>
+            <name>My Email</name>
+          </email>
+        </rsp>)
+      end
+
+      it 'should take in the email ID' do
+        fake_get '/api/email/version/3/do/read/id/12?format=simple', sample_response
+        expect(client.emails.read_by_id(12)).to eq({ 'name' => 'My Email' })
+        assert_authorization_header auth_manager
+      end
+
+      it 'should send to a prospect' do
+        fake_post '/api/email/version/3/do/send/prospect_id/42?campaign_id=765&email_template_id=86&format=simple', sample_response
+        expect(client.emails.send_to_prospect(42, campaign_id: 765, email_template_id: 86)).to eq({ 'name' => 'My Email' })
+        assert_authorization_header auth_manager
+      end
+
+      it 'should send to a list' do
+        fake_post '/api/email/version/3/do/send?email_template_id=200&list_ids%5B%5D=235&campaign_id=654&format=simple', sample_response
+        expect(client.emails.send_to_list(:email_template_id => 200, 'list_ids[]' => 235, :campaign_id => 654)).to eq({ 'name' => 'My Email' })
+        assert_authorization_header auth_manager
+      end
+    end
   end
-
-end
+end

data/spec/pardot/objects/lists_spec.rb

@@ -1,42 +1,38 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+# frozen_string_literal: true
+
+require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper")
 
 describe Pardot::Objects::Lists do
-  
-  before do
-    @client = create_client
-  end
-  
-  describe "query" do
-    
-    def sample_results
-      %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="ok" version="1.0">
-        <result>
-          <total_results>2</total_results>
-          <list>
-            <name>Asdf List</name>
-          </list>
-          <list>
-            <name>Qwerty List</name>
-          </list>
-        </result>
-      </rsp>)
-    end
-    
-    before do
-      @client = create_client
-    end
-    
-    it "should take in some arguments" do
-      fake_get "/api/list/version/3/do/query?id_greater_than=200&format=simple", sample_results
-      
-      expect(@client.lists.query(:id_greater_than => 200)).to eq({"total_results" => 2, 
-        "list"=>[
-          {"name"=>"Asdf List"}, 
-          {"name"=>"Qwerty List"}
-        ]})
-      assert_authorization_header
+  create_auth_managers.each do |auth_manager|
+    context auth_manager.test_name_suffix do
+      let(:client) { auth_manager.create_client }
+
+      describe 'query' do
+        def sample_results
+          %(<?xml version="1.0" encoding="UTF-8"?>\n<rsp stat="ok" version="1.0">
+            <result>
+              <total_results>2</total_results>
+              <list>
+                <name>Asdf List</name>
+              </list>
+              <list>
+                <name>Qwerty List</name>
+              </list>
+            </result>
+          </rsp>)
+        end
+
+        it 'should take in some arguments' do
+          fake_get '/api/list/version/3/do/query?id_greater_than=200&format=simple', sample_results
+
+          expect(client.lists.query(id_greater_than: 200)).to eq({ 'total_results' => 2,
+                                                                   'list' => [
+                                                                     { 'name' => 'Asdf List' },
+                                                                     { 'name' => 'Qwerty List' }
+                                                                   ] })
+          assert_authorization_header auth_manager
+        end
+      end
     end
-    
   end
-  
-end
+end