rubocop 0.80.0 → 1.42.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +71 -38
- data/assets/output.html.erb +1 -1
- data/config/default.yml +1682 -202
- data/config/obsoletion.yml +233 -0
- data/exe/rubocop +15 -9
- data/lib/rubocop/arguments_env.rb +17 -0
- data/lib/rubocop/arguments_file.rb +17 -0
- data/lib/rubocop/ast_aliases.rb +8 -0
- data/lib/rubocop/cache_config.rb +29 -0
- data/lib/rubocop/cached_data.rb +4 -4
- data/lib/rubocop/cli/command/auto_generate_config.rb +147 -0
- data/lib/rubocop/cli/command/base.rb +2 -0
- data/lib/rubocop/cli/command/execute_runner.rb +38 -14
- data/lib/rubocop/cli/command/init_dotfile.rb +4 -5
- data/lib/rubocop/cli/command/show_cops.rb +6 -12
- data/lib/rubocop/cli/command/show_docs_url.rb +48 -0
- data/lib/rubocop/cli/command/suggest_extensions.rb +126 -0
- data/lib/rubocop/cli/command/version.rb +3 -2
- data/lib/rubocop/cli/command.rb +1 -0
- data/lib/rubocop/cli/environment.rb +1 -0
- data/lib/rubocop/cli.rb +41 -14
- data/lib/rubocop/comment_config.rb +90 -99
- data/lib/rubocop/config.rb +117 -42
- data/lib/rubocop/config_finder.rb +68 -0
- data/lib/rubocop/config_loader.rb +122 -133
- data/lib/rubocop/config_loader_resolver.rb +125 -39
- data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
- data/lib/rubocop/config_obsoletion/changed_parameter.rb +26 -0
- data/lib/rubocop/config_obsoletion/cop_rule.rb +33 -0
- data/lib/rubocop/config_obsoletion/extracted_cop.rb +46 -0
- data/lib/rubocop/config_obsoletion/parameter_rule.rb +48 -0
- data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
- data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
- data/lib/rubocop/config_obsoletion/rule.rb +41 -0
- data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
- data/lib/rubocop/config_obsoletion.rb +72 -240
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +31 -7
- data/lib/rubocop/config_validator.rb +95 -29
- data/lib/rubocop/cop/autocorrect_logic.rb +45 -40
- data/lib/rubocop/cop/badge.rb +27 -32
- data/lib/rubocop/cop/base.rb +464 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +34 -14
- data/lib/rubocop/cop/bundler/gem_comment.rb +117 -10
- data/lib/rubocop/cop/bundler/gem_filename.rb +103 -0
- data/lib/rubocop/cop/bundler/gem_version.rb +133 -0
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +45 -28
- data/lib/rubocop/cop/bundler/ordered_gems.rb +7 -18
- data/lib/rubocop/cop/commissioner.rb +105 -74
- data/lib/rubocop/cop/cop.rb +84 -234
- data/lib/rubocop/cop/corrector.rb +77 -119
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +14 -24
- data/lib/rubocop/cop/correctors/condition_corrector.rb +4 -7
- data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +4 -6
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +10 -11
- data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +5 -4
- data/lib/rubocop/cop/correctors/if_then_corrector.rb +55 -0
- data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +7 -7
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +15 -12
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +56 -11
- data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +12 -13
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +64 -9
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +11 -22
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +9 -11
- data/lib/rubocop/cop/correctors/require_library_corrector.rb +23 -0
- data/lib/rubocop/cop/correctors/space_corrector.rb +2 -4
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +7 -9
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +16 -19
- data/lib/rubocop/cop/documentation.rb +39 -0
- data/lib/rubocop/cop/exclude_limit.rb +26 -0
- data/lib/rubocop/cop/force.rb +2 -1
- data/lib/rubocop/cop/gemspec/dependency_version.rb +154 -0
- data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +11 -26
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +7 -20
- data/lib/rubocop/cop/gemspec/require_mfa.rb +145 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +69 -27
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +7 -12
- data/lib/rubocop/cop/generator/configuration_injector.rb +4 -5
- data/lib/rubocop/cop/generator/require_file_injector.rb +4 -7
- data/lib/rubocop/cop/generator.rb +36 -41
- data/lib/rubocop/cop/ignored_node.rb +1 -3
- data/lib/rubocop/cop/internal_affairs/cop_description.rb +98 -0
- data/lib/rubocop/cop/internal_affairs/create_empty_file.rb +37 -0
- data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +68 -0
- data/lib/rubocop/cop/internal_affairs/example_description.rb +92 -0
- data/lib/rubocop/cop/internal_affairs/example_heredoc_delimiter.rb +111 -0
- data/lib/rubocop/cop/internal_affairs/inherit_deprecated_cop_class.rb +34 -0
- data/lib/rubocop/cop/internal_affairs/lambda_or_proc.rb +46 -0
- data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +60 -0
- data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +80 -0
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +8 -17
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +4 -4
- data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +147 -0
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +11 -14
- data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +12 -10
- data/lib/rubocop/cop/internal_affairs/redundant_context_config_parameter.rb +46 -0
- data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +62 -0
- data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +65 -0
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +13 -8
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +12 -9
- data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +47 -0
- data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
- data/lib/rubocop/cop/internal_affairs/style_detected_api_use.rb +148 -0
- data/lib/rubocop/cop/internal_affairs/undefined_config.rb +73 -0
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +6 -6
- data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
- data/lib/rubocop/cop/internal_affairs.rb +20 -1
- data/lib/rubocop/cop/layout/access_modifier_indentation.rb +12 -10
- data/lib/rubocop/cop/layout/argument_alignment.rb +84 -19
- data/lib/rubocop/cop/layout/array_alignment.rb +58 -13
- data/lib/rubocop/cop/layout/assignment_indentation.rb +10 -9
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +74 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +56 -60
- data/lib/rubocop/cop/layout/block_end_newline.rb +41 -13
- data/lib/rubocop/cop/layout/case_indentation.rb +88 -30
- data/lib/rubocop/cop/layout/class_structure.rb +90 -80
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +25 -31
- data/lib/rubocop/cop/layout/comment_indentation.rb +56 -29
- data/lib/rubocop/cop/layout/condition_position.rb +17 -9
- data/lib/rubocop/cop/layout/def_end_alignment.rb +10 -11
- data/lib/rubocop/cop/layout/dot_position.rb +65 -27
- data/lib/rubocop/cop/layout/else_alignment.rb +29 -7
- data/lib/rubocop/cop/layout/empty_comment.rb +30 -30
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +61 -37
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +13 -13
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +161 -40
- data/lib/rubocop/cop/layout/empty_lines.rb +10 -13
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +32 -38
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +14 -10
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +139 -0
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +3 -6
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +8 -9
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +12 -15
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +16 -19
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +3 -6
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +12 -15
- data/lib/rubocop/cop/layout/end_alignment.rb +26 -25
- data/lib/rubocop/cop/layout/end_of_line.rb +13 -13
- data/lib/rubocop/cop/layout/extra_spacing.rb +32 -47
- data/lib/rubocop/cop/layout/first_argument_indentation.rb +74 -41
- data/lib/rubocop/cop/layout/first_array_element_indentation.rb +38 -25
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +43 -11
- data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +84 -29
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +51 -8
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +66 -14
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +54 -8
- data/lib/rubocop/cop/layout/first_parameter_indentation.rb +11 -10
- data/lib/rubocop/cop/layout/hash_alignment.rb +85 -55
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +48 -32
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +33 -124
- data/lib/rubocop/cop/layout/indentation_consistency.rb +10 -7
- data/lib/rubocop/cop/layout/indentation_style.rb +115 -0
- data/lib/rubocop/cop/layout/indentation_width.rb +51 -26
- data/lib/rubocop/cop/layout/initial_indentation.rb +8 -12
- data/lib/rubocop/cop/layout/leading_comment_space.rb +15 -13
- data/lib/rubocop/cop/layout/leading_empty_lines.rb +7 -12
- data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +138 -0
- data/lib/rubocop/cop/layout/line_continuation_spacing.rb +136 -0
- data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +141 -0
- data/lib/rubocop/cop/layout/line_length.rb +62 -63
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +53 -8
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +41 -19
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +45 -39
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +53 -10
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +64 -14
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +52 -24
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +101 -0
- data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +28 -15
- data/lib/rubocop/cop/layout/parameter_alignment.rb +8 -7
- data/lib/rubocop/cop/layout/redundant_line_break.rb +139 -0
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +60 -40
- data/lib/rubocop/cop/layout/single_line_block_chain.rb +64 -0
- data/lib/rubocop/cop/layout/space_after_colon.rb +11 -9
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +7 -10
- data/lib/rubocop/cop/layout/space_after_not.rb +11 -12
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +47 -54
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +20 -23
- data/lib/rubocop/cop/layout/space_around_keyword.rb +54 -30
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
- data/lib/rubocop/cop/layout/space_around_operators.rb +61 -28
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +43 -25
- data/lib/rubocop/cop/layout/space_before_brackets.rb +73 -0
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +11 -12
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +13 -15
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +17 -21
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +50 -55
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +8 -15
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +63 -50
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +52 -44
- data/lib/rubocop/cop/layout/space_inside_parens.rb +92 -29
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +38 -9
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +9 -18
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +25 -32
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +13 -14
- data/lib/rubocop/cop/layout/trailing_empty_lines.rb +20 -25
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +73 -19
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +43 -0
- data/lib/rubocop/cop/legacy/corrector.rb +27 -0
- data/lib/rubocop/cop/lint/ambiguous_assignment.rb +54 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +44 -11
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +60 -12
- data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +111 -0
- data/lib/rubocop/cop/lint/ambiguous_range.rb +105 -0
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +44 -7
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +20 -8
- data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -10
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +68 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +30 -5
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +2 -2
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +100 -0
- data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +93 -0
- data/lib/rubocop/cop/lint/debugger.rb +76 -26
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +109 -52
- data/lib/rubocop/cop/lint/deprecated_constants.rb +88 -0
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +154 -0
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +32 -3
- data/lib/rubocop/cop/lint/duplicate_branch.rb +153 -0
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +4 -14
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/duplicate_hash_key.rb +3 -5
- data/lib/rubocop/cop/lint/duplicate_magic_comment.rb +73 -0
- data/lib/rubocop/cop/lint/duplicate_methods.rb +63 -34
- data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +96 -0
- data/lib/rubocop/cop/lint/duplicate_require.rb +56 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +5 -3
- data/lib/rubocop/cop/lint/else_layout.rb +37 -9
- data/lib/rubocop/cop/lint/empty_block.rb +94 -0
- data/lib/rubocop/cop/lint/empty_class.rb +95 -0
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +175 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +6 -8
- data/lib/rubocop/cop/lint/empty_expression.rb +3 -3
- data/lib/rubocop/cop/lint/empty_file.rb +48 -0
- data/lib/rubocop/cop/lint/empty_in_pattern.rb +64 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +5 -8
- data/lib/rubocop/cop/lint/empty_when.rb +34 -9
- data/lib/rubocop/cop/lint/ensure_return.rb +29 -16
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +28 -30
- data/lib/rubocop/cop/lint/flip_flop.rb +9 -3
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +3 -4
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +45 -10
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +47 -0
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +15 -17
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +8 -8
- data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +79 -0
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +15 -21
- data/lib/rubocop/cop/lint/inherit_exception.rb +32 -36
- data/lib/rubocop/cop/lint/interpolation_check.rb +28 -9
- data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +51 -0
- data/lib/rubocop/cop/lint/literal_as_condition.rb +43 -17
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +49 -16
- data/lib/rubocop/cop/lint/loop.rb +32 -9
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +51 -24
- data/lib/rubocop/cop/lint/missing_super.rb +101 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +36 -0
- data/lib/rubocop/cop/lint/multiple_comparison.rb +15 -15
- data/lib/rubocop/cop/lint/nested_method_definition.rb +71 -26
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +19 -7
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +26 -6
- data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
- data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +162 -0
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +112 -16
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +13 -10
- data/lib/rubocop/cop/lint/number_conversion.rb +137 -27
- data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +47 -0
- data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +40 -0
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +16 -20
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +132 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +42 -14
- data/lib/rubocop/cop/lint/percent_string_array.rb +18 -13
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -15
- data/lib/rubocop/cop/lint/raise_exception.rb +91 -0
- data/lib/rubocop/cop/lint/rand_one.rb +6 -5
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +180 -119
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +46 -32
- data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +62 -0
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +45 -15
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +91 -0
- data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +73 -36
- data/lib/rubocop/cop/lint/redundant_string_coercion.rb +9 -16
- data/lib/rubocop/cop/lint/redundant_with_index.rb +26 -28
- data/lib/rubocop/cop/lint/redundant_with_object.rb +25 -29
- data/lib/rubocop/cop/lint/refinement_import_methods.rb +51 -0
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +13 -5
- data/lib/rubocop/cop/lint/require_parentheses.rb +8 -8
- data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
- data/lib/rubocop/cop/lint/require_relative_self_path.rb +50 -0
- data/lib/rubocop/cop/lint/rescue_exception.rb +3 -4
- data/lib/rubocop/cop/lint/rescue_type.rb +10 -16
- data/lib/rubocop/cop/lint/return_in_void_context.rb +7 -22
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +48 -15
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +16 -18
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +13 -5
- data/lib/rubocop/cop/lint/script_permission.rb +11 -8
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +14 -21
- data/lib/rubocop/cop/lint/shadowed_argument.rb +10 -16
- data/lib/rubocop/cop/lint/shadowed_exception.rb +34 -41
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +56 -7
- data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
- data/lib/rubocop/cop/lint/suppressed_exception.rb +55 -18
- data/lib/rubocop/cop/lint/symbol_conversion.rb +179 -0
- data/lib/rubocop/cop/lint/syntax.rb +10 -30
- data/lib/rubocop/cop/lint/to_enum_arguments.rb +89 -0
- data/lib/rubocop/cop/lint/to_json.rb +22 -14
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +55 -0
- data/lib/rubocop/cop/lint/triple_quotes.rb +71 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +6 -8
- data/lib/rubocop/cop/lint/unexpected_block_arity.rb +90 -0
- data/lib/rubocop/cop/lint/unified_integer.rb +7 -8
- data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +204 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +6 -8
- data/lib/rubocop/cop/lint/unreachable_loop.rb +202 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +19 -12
- data/lib/rubocop/cop/lint/unused_method_argument.rb +48 -13
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +6 -3
- data/lib/rubocop/cop/lint/uri_regexp.rb +13 -48
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +45 -27
- data/lib/rubocop/cop/lint/useless_assignment.rb +11 -15
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +8 -13
- data/lib/rubocop/cop/lint/useless_method_definition.rb +69 -0
- data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +119 -0
- data/lib/rubocop/cop/lint/useless_setter_call.rb +18 -13
- data/lib/rubocop/cop/lint/useless_times.rb +114 -0
- data/lib/rubocop/cop/lint/void.rb +16 -25
- data/lib/rubocop/cop/message_annotator.rb +5 -4
- data/lib/rubocop/cop/metrics/abc_size.rb +35 -3
- data/lib/rubocop/cop/metrics/block_length.rb +47 -11
- data/lib/rubocop/cop/metrics/block_nesting.rb +6 -11
- data/lib/rubocop/cop/metrics/class_length.rb +46 -12
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +30 -7
- data/lib/rubocop/cop/metrics/method_length.rb +41 -6
- data/lib/rubocop/cop/metrics/module_length.rb +35 -10
- data/lib/rubocop/cop/metrics/parameter_lists.rb +79 -13
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +8 -10
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +76 -16
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +182 -0
- data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
- data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +143 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
- data/lib/rubocop/cop/migration/department_name.rb +39 -30
- data/lib/rubocop/cop/mixin/alignment.rb +18 -11
- data/lib/rubocop/cop/mixin/allowed_identifiers.rb +18 -0
- data/lib/rubocop/cop/mixin/allowed_methods.rb +40 -0
- data/lib/rubocop/cop/mixin/allowed_pattern.rb +56 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +58 -23
- data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +56 -19
- data/lib/rubocop/cop/mixin/code_length.rb +30 -9
- data/lib/rubocop/cop/mixin/comments_help.rb +80 -0
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +24 -14
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +4 -11
- data/lib/rubocop/cop/mixin/configurable_max.rb +1 -0
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
- data/lib/rubocop/cop/mixin/def_node.rb +4 -11
- data/lib/rubocop/cop/mixin/documentation_comment.rb +9 -9
- data/lib/rubocop/cop/mixin/duplication.rb +1 -1
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +14 -14
- data/lib/rubocop/cop/mixin/empty_parameter.rb +2 -1
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +17 -4
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +22 -8
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +14 -10
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +41 -6
- data/lib/rubocop/cop/mixin/gem_declaration.rb +13 -0
- data/lib/rubocop/cop/mixin/gemspec_help.rb +30 -0
- data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +20 -11
- data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +187 -0
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +58 -38
- data/lib/rubocop/cop/mixin/heredoc.rb +5 -0
- data/lib/rubocop/cop/mixin/interpolation.rb +1 -3
- data/lib/rubocop/cop/mixin/line_length_help.rb +35 -15
- data/lib/rubocop/cop/mixin/match_range.rb +2 -5
- data/lib/rubocop/cop/mixin/method_complexity.rb +27 -10
- data/lib/rubocop/cop/mixin/method_preference.rb +1 -2
- data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +39 -16
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +6 -4
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +18 -46
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +15 -15
- data/lib/rubocop/cop/mixin/negative_conditional.rb +6 -4
- data/lib/rubocop/cop/mixin/nil_methods.rb +3 -5
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +16 -6
- data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +85 -12
- data/lib/rubocop/cop/mixin/percent_literal.rb +0 -6
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +16 -14
- data/lib/rubocop/cop/mixin/preferred_delimiters.rb +6 -9
- data/lib/rubocop/cop/mixin/range_help.rb +55 -18
- data/lib/rubocop/cop/mixin/rational_literal.rb +1 -0
- data/lib/rubocop/cop/mixin/require_library.rb +61 -0
- data/lib/rubocop/cop/mixin/rescue_node.rb +15 -7
- data/lib/rubocop/cop/mixin/safe_assignment.rb +6 -2
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +6 -7
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +7 -7
- data/lib/rubocop/cop/mixin/statement_modifier.rb +59 -22
- data/lib/rubocop/cop/mixin/string_help.rb +5 -2
- data/lib/rubocop/cop/mixin/string_literals_help.rb +3 -5
- data/lib/rubocop/cop/mixin/surrounding_space.rb +28 -40
- data/lib/rubocop/cop/mixin/symbol_help.rb +13 -0
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
- data/lib/rubocop/cop/mixin/trailing_body.rb +2 -3
- data/lib/rubocop/cop/mixin/trailing_comma.rb +14 -19
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +25 -32
- data/lib/rubocop/cop/mixin/unused_argument.rb +5 -9
- data/lib/rubocop/cop/mixin/visibility_help.rb +72 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +22 -4
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -11
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +18 -8
- data/lib/rubocop/cop/naming/block_forwarding.rb +121 -0
- data/lib/rubocop/cop/naming/block_parameter_name.rb +4 -4
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +16 -4
- data/lib/rubocop/cop/naming/constant_name.rb +9 -6
- data/lib/rubocop/cop/naming/file_name.rb +74 -39
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +13 -7
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +5 -5
- data/lib/rubocop/cop/naming/inclusive_language.rb +270 -0
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +136 -27
- data/lib/rubocop/cop/naming/method_name.rb +35 -7
- data/lib/rubocop/cop/naming/method_parameter_name.rb +4 -4
- data/lib/rubocop/cop/naming/predicate_name.rb +42 -16
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +67 -16
- data/lib/rubocop/cop/naming/variable_name.rb +13 -2
- data/lib/rubocop/cop/naming/variable_number.rb +107 -12
- data/lib/rubocop/cop/offense.rb +35 -12
- data/lib/rubocop/cop/registry.rb +128 -36
- data/lib/rubocop/cop/security/compound_hash.rb +106 -0
- data/lib/rubocop/cop/security/eval.rb +5 -3
- data/lib/rubocop/cop/security/io_methods.rb +49 -0
- data/lib/rubocop/cop/security/json_load.rb +17 -16
- data/lib/rubocop/cop/security/marshal_load.rb +5 -5
- data/lib/rubocop/cop/security/open.rb +29 -11
- data/lib/rubocop/cop/security/yaml_load.rb +22 -10
- data/lib/rubocop/cop/severity.rb +4 -14
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +110 -12
- data/lib/rubocop/cop/style/accessor_grouping.rb +154 -0
- data/lib/rubocop/cop/style/alias.rb +55 -46
- data/lib/rubocop/cop/style/and_or.rb +42 -30
- data/lib/rubocop/cop/style/arguments_forwarding.rb +154 -0
- data/lib/rubocop/cop/style/array_coercion.rb +87 -0
- data/lib/rubocop/cop/style/array_intersect.rb +111 -0
- data/lib/rubocop/cop/style/array_join.rb +9 -9
- data/lib/rubocop/cop/style/ascii_comments.rb +7 -11
- data/lib/rubocop/cop/style/attr.rb +16 -16
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +10 -13
- data/lib/rubocop/cop/style/bare_percent_literals.rb +13 -15
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +60 -0
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +125 -0
- data/lib/rubocop/cop/style/block_comments.rb +15 -19
- data/lib/rubocop/cop/style/block_delimiters.rb +105 -39
- data/lib/rubocop/cop/style/case_equality.rb +84 -6
- data/lib/rubocop/cop/style/case_like_if.rb +263 -0
- data/lib/rubocop/cop/style/character_literal.rb +20 -16
- data/lib/rubocop/cop/style/class_and_module_children.rb +71 -29
- data/lib/rubocop/cop/style/class_check.rb +7 -12
- data/lib/rubocop/cop/style/class_equality_comparison.rb +116 -0
- data/lib/rubocop/cop/style/class_methods.rb +9 -15
- data/lib/rubocop/cop/style/class_methods_definitions.rb +158 -0
- data/lib/rubocop/cop/style/class_vars.rb +24 -8
- data/lib/rubocop/cop/style/collection_compact.rb +120 -0
- data/lib/rubocop/cop/style/collection_methods.rb +34 -21
- data/lib/rubocop/cop/style/colon_method_call.rb +8 -10
- data/lib/rubocop/cop/style/colon_method_definition.rb +7 -7
- data/lib/rubocop/cop/style/combinable_loops.rb +95 -0
- data/lib/rubocop/cop/style/command_literal.rb +23 -29
- data/lib/rubocop/cop/style/comment_annotation.rb +69 -36
- data/lib/rubocop/cop/style/commented_keyword.rb +42 -23
- data/lib/rubocop/cop/style/concat_array_literals.rb +86 -0
- data/lib/rubocop/cop/style/conditional_assignment.rb +94 -95
- data/lib/rubocop/cop/style/constant_visibility.rb +32 -3
- data/lib/rubocop/cop/style/copyright.rb +21 -24
- data/lib/rubocop/cop/style/date_time.rb +22 -6
- data/lib/rubocop/cop/style/def_with_parentheses.rb +22 -20
- data/lib/rubocop/cop/style/dir.rb +15 -13
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +87 -0
- data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
- data/lib/rubocop/cop/style/documentation.rb +117 -22
- data/lib/rubocop/cop/style/documentation_method.rb +3 -2
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +7 -16
- data/lib/rubocop/cop/style/double_negation.rb +134 -10
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +48 -16
- data/lib/rubocop/cop/style/each_with_object.rb +53 -24
- data/lib/rubocop/cop/style/empty_block_parameter.rb +11 -12
- data/lib/rubocop/cop/style/empty_case_condition.rb +32 -27
- data/lib/rubocop/cop/style/empty_else.rb +54 -25
- data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +11 -12
- data/lib/rubocop/cop/style/empty_literal.rb +48 -33
- data/lib/rubocop/cop/style/empty_method.rb +29 -25
- data/lib/rubocop/cop/style/encoding.rb +30 -23
- data/lib/rubocop/cop/style/end_block.rb +8 -5
- data/lib/rubocop/cop/style/endless_method.rb +101 -0
- data/lib/rubocop/cop/style/env_home.rb +56 -0
- data/lib/rubocop/cop/style/eval_with_location.rb +143 -54
- data/lib/rubocop/cop/style/even_odd.rb +10 -12
- data/lib/rubocop/cop/style/expand_path_arguments.rb +28 -26
- data/lib/rubocop/cop/style/explicit_block_argument.rb +153 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +116 -0
- data/lib/rubocop/cop/style/fetch_env_var.rb +132 -0
- data/lib/rubocop/cop/style/file_read.rb +112 -0
- data/lib/rubocop/cop/style/file_write.rb +136 -0
- data/lib/rubocop/cop/style/float_division.rb +69 -12
- data/lib/rubocop/cop/style/for.rb +13 -13
- data/lib/rubocop/cop/style/format_string.rb +31 -25
- data/lib/rubocop/cop/style/format_string_token.rb +138 -31
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +35 -54
- data/lib/rubocop/cop/style/global_std_stream.rb +70 -0
- data/lib/rubocop/cop/style/global_vars.rb +3 -3
- data/lib/rubocop/cop/style/guard_clause.rb +186 -33
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +100 -0
- data/lib/rubocop/cop/style/hash_conversion.rb +134 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +61 -16
- data/lib/rubocop/cop/style/hash_except.rb +177 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +77 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +106 -45
- data/lib/rubocop/cop/style/hash_transform_keys.rb +31 -15
- data/lib/rubocop/cop/style/hash_transform_values.rb +29 -15
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +106 -11
- data/lib/rubocop/cop/style/if_inside_else.rb +65 -2
- data/lib/rubocop/cop/style/if_unless_modifier.rb +81 -51
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
- data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +161 -0
- data/lib/rubocop/cop/style/if_with_semicolon.rb +51 -3
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +6 -4
- data/lib/rubocop/cop/style/in_pattern_then.rb +56 -0
- data/lib/rubocop/cop/style/infinite_loop.rb +28 -26
- data/lib/rubocop/cop/style/inline_comment.rb +5 -5
- data/lib/rubocop/cop/style/inverse_methods.rb +55 -52
- data/lib/rubocop/cop/style/ip_addresses.rb +4 -5
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +75 -0
- data/lib/rubocop/cop/style/lambda.rb +12 -18
- data/lib/rubocop/cop/style/lambda_call.rb +20 -45
- data/lib/rubocop/cop/style/line_end_concatenation.rb +40 -28
- data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
- data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
- data/lib/rubocop/cop/style/map_to_hash.rb +68 -0
- data/lib/rubocop/cop/style/map_to_set.rb +61 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +91 -39
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +12 -18
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +76 -25
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +39 -15
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +17 -7
- data/lib/rubocop/cop/style/method_def_parentheses.rb +43 -29
- data/lib/rubocop/cop/style/min_max.rb +11 -15
- data/lib/rubocop/cop/style/min_max_comparison.rb +73 -0
- data/lib/rubocop/cop/style/missing_else.rb +44 -49
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +12 -6
- data/lib/rubocop/cop/style/mixin_grouping.rb +29 -42
- data/lib/rubocop/cop/style/mixin_usage.rb +13 -31
- data/lib/rubocop/cop/style/module_function.rb +99 -33
- data/lib/rubocop/cop/style/multiline_block_chain.rb +17 -7
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +6 -13
- data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
- data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +60 -0
- data/lib/rubocop/cop/style/multiline_memoization.rb +16 -14
- data/lib/rubocop/cop/style/multiline_method_signature.rb +34 -4
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +59 -12
- data/lib/rubocop/cop/style/multiline_when_then.rb +24 -19
- data/lib/rubocop/cop/style/multiple_comparison.rb +78 -13
- data/lib/rubocop/cop/style/mutable_constant.rb +117 -44
- data/lib/rubocop/cop/style/negated_if.rb +10 -11
- data/lib/rubocop/cop/style/negated_if_else_condition.rb +134 -0
- data/lib/rubocop/cop/style/negated_unless.rb +10 -11
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_file_dirname.rb +66 -0
- data/lib/rubocop/cop/style/nested_modifier.rb +11 -18
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +33 -21
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +43 -5
- data/lib/rubocop/cop/style/next.rb +20 -31
- data/lib/rubocop/cop/style/nil_comparison.rb +20 -12
- data/lib/rubocop/cop/style/nil_lambda.rb +70 -0
- data/lib/rubocop/cop/style/non_nil_check.rb +57 -35
- data/lib/rubocop/cop/style/not.rb +23 -29
- data/lib/rubocop/cop/style/numbered_parameters.rb +46 -0
- data/lib/rubocop/cop/style/numbered_parameters_limit.rb +50 -0
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +7 -12
- data/lib/rubocop/cop/style/numeric_literals.rb +44 -29
- data/lib/rubocop/cop/style/numeric_predicate.rb +72 -33
- data/lib/rubocop/cop/style/object_then.rb +74 -0
- data/lib/rubocop/cop/style/one_line_conditional.rb +56 -31
- data/lib/rubocop/cop/style/open_struct_use.rb +69 -0
- data/lib/rubocop/cop/style/operator_method_call.rb +53 -0
- data/lib/rubocop/cop/style/option_hash.rb +4 -5
- data/lib/rubocop/cop/style/optional_arguments.rb +9 -8
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +64 -0
- data/lib/rubocop/cop/style/or_assignment.rb +12 -11
- data/lib/rubocop/cop/style/parallel_assignment.rb +28 -25
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +20 -9
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +17 -25
- data/lib/rubocop/cop/style/percent_q_literals.rb +12 -15
- data/lib/rubocop/cop/style/perl_backrefs.rb +106 -17
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +21 -22
- data/lib/rubocop/cop/style/proc.rb +10 -7
- data/lib/rubocop/cop/style/quoted_symbols.rb +124 -0
- data/lib/rubocop/cop/style/raise_args.rb +49 -39
- data/lib/rubocop/cop/style/random_with_offset.rb +31 -36
- data/lib/rubocop/cop/style/redundant_argument.rb +98 -0
- data/lib/rubocop/cop/style/redundant_assignment.rb +106 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +113 -12
- data/lib/rubocop/cop/style/redundant_capital_w.rb +9 -14
- data/lib/rubocop/cop/style/redundant_condition.rb +169 -26
- data/lib/rubocop/cop/style/redundant_conditional.rb +15 -16
- data/lib/rubocop/cop/style/redundant_constant_base.rb +85 -0
- data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +39 -0
- data/lib/rubocop/cop/style/redundant_each.rb +116 -0
- data/lib/rubocop/cop/style/redundant_exception.rb +23 -18
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +119 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +61 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +16 -14
- data/lib/rubocop/cop/style/redundant_initialize.rb +156 -0
- data/lib/rubocop/cop/style/redundant_interpolation.rb +70 -30
- data/lib/rubocop/cop/style/redundant_parentheses.rb +68 -57
- data/lib/rubocop/cop/style/redundant_percent_q.rb +17 -21
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +120 -0
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +127 -0
- data/lib/rubocop/cop/style/redundant_return.rb +37 -30
- data/lib/rubocop/cop/style/redundant_self.rb +60 -28
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +118 -0
- data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +83 -0
- data/lib/rubocop/cop/style/redundant_sort.rb +84 -41
- data/lib/rubocop/cop/style/redundant_sort_by.rb +27 -14
- data/lib/rubocop/cop/style/redundant_string_escape.rb +184 -0
- data/lib/rubocop/cop/style/regexp_literal.rb +26 -32
- data/lib/rubocop/cop/style/require_order.rb +142 -0
- data/lib/rubocop/cop/style/rescue_modifier.rb +41 -14
- data/lib/rubocop/cop/style/rescue_standard_error.rb +36 -34
- data/lib/rubocop/cop/style/return_nil.rb +15 -9
- data/lib/rubocop/cop/style/safe_navigation.rb +107 -56
- data/lib/rubocop/cop/style/sample.rb +18 -17
- data/lib/rubocop/cop/style/select_by_regexp.rb +152 -0
- data/lib/rubocop/cop/style/self_assignment.rb +27 -23
- data/lib/rubocop/cop/style/semicolon.rb +65 -32
- data/lib/rubocop/cop/style/send.rb +6 -8
- data/lib/rubocop/cop/style/signal_exception.rb +39 -32
- data/lib/rubocop/cop/style/single_argument_dig.rb +65 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +39 -15
- data/lib/rubocop/cop/style/single_line_methods.rb +82 -20
- data/lib/rubocop/cop/style/slicing_with_range.rb +51 -0
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +248 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +107 -57
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +18 -25
- data/lib/rubocop/cop/style/static_class.rb +128 -0
- data/lib/rubocop/cop/style/stderr_puts.rb +10 -14
- data/lib/rubocop/cop/style/string_chars.rb +41 -0
- data/lib/rubocop/cop/style/string_concatenation.rb +178 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +13 -8
- data/lib/rubocop/cop/style/string_literals.rb +20 -20
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +6 -4
- data/lib/rubocop/cop/style/string_methods.rb +8 -18
- data/lib/rubocop/cop/style/strip.rb +11 -15
- data/lib/rubocop/cop/style/struct_inheritance.rb +38 -5
- data/lib/rubocop/cop/style/swap_values.rb +112 -0
- data/lib/rubocop/cop/style/symbol_array.rb +20 -26
- data/lib/rubocop/cop/style/symbol_literal.rb +6 -10
- data/lib/rubocop/cop/style/symbol_proc.rb +135 -35
- data/lib/rubocop/cop/style/ternary_parentheses.rb +47 -51
- data/lib/rubocop/cop/style/top_level_method_definition.rb +85 -0
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +11 -10
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +4 -7
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +42 -10
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +44 -6
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +105 -0
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +47 -6
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +10 -39
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +17 -32
- data/lib/rubocop/cop/style/trivial_accessors.rb +111 -48
- data/lib/rubocop/cop/style/unless_else.rb +10 -10
- data/lib/rubocop/cop/style/unless_logical_operators.rb +105 -0
- data/lib/rubocop/cop/style/unpack_first.rb +8 -11
- data/lib/rubocop/cop/style/variable_interpolation.rb +9 -12
- data/lib/rubocop/cop/style/when_then.rb +7 -7
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +16 -24
- data/lib/rubocop/cop/style/word_array.rb +67 -26
- data/lib/rubocop/cop/style/yoda_condition.rb +41 -25
- data/lib/rubocop/cop/style/yoda_expression.rb +74 -0
- data/lib/rubocop/cop/style/zero_length_predicate.rb +56 -31
- data/lib/rubocop/cop/team.rb +147 -85
- data/lib/rubocop/cop/util.rb +97 -30
- data/lib/rubocop/cop/utils/format_string.rb +22 -9
- data/lib/rubocop/cop/variable_force/assignment.rb +3 -3
- data/lib/rubocop/cop/variable_force/branch.rb +19 -10
- data/lib/rubocop/cop/variable_force/reference.rb +1 -3
- data/lib/rubocop/cop/variable_force/scope.rb +6 -9
- data/lib/rubocop/cop/variable_force/variable.rb +9 -12
- data/lib/rubocop/cop/variable_force/variable_table.rb +2 -2
- data/lib/rubocop/cop/variable_force.rb +28 -59
- data/lib/rubocop/cops_documentation_generator.rb +322 -0
- data/lib/rubocop/core_ext/string.rb +2 -2
- data/lib/rubocop/directive_comment.rb +144 -0
- data/lib/rubocop/error.rb +1 -0
- data/lib/rubocop/ext/processed_source.rb +20 -0
- data/lib/rubocop/ext/range.rb +15 -0
- data/lib/rubocop/ext/regexp_node.rb +87 -0
- data/lib/rubocop/ext/regexp_parser.rb +92 -0
- data/lib/rubocop/feature_loader.rb +94 -0
- data/lib/rubocop/file_finder.rb +12 -13
- data/lib/rubocop/file_patterns.rb +43 -0
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/base_formatter.rb +0 -4
- data/lib/rubocop/formatter/clang_style_formatter.rb +6 -4
- data/lib/rubocop/formatter/disabled_config_formatter.rb +82 -39
- data/lib/rubocop/formatter/emacs_style_formatter.rb +2 -0
- data/lib/rubocop/formatter/formatter_set.rb +24 -23
- data/lib/rubocop/formatter/git_hub_actions_formatter.rb +57 -0
- data/lib/rubocop/formatter/html_formatter.rb +17 -26
- data/lib/rubocop/formatter/json_formatter.rb +5 -6
- data/lib/rubocop/formatter/junit_formatter.rb +45 -15
- data/lib/rubocop/formatter/markdown_formatter.rb +78 -0
- data/lib/rubocop/formatter/offense_count_formatter.rb +17 -8
- data/lib/rubocop/formatter/pacman_formatter.rb +1 -1
- data/lib/rubocop/formatter/progress_formatter.rb +3 -4
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +42 -8
- data/lib/rubocop/formatter/tap_formatter.rb +8 -4
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +8 -6
- data/lib/rubocop/formatter.rb +35 -0
- data/lib/rubocop/lockfile.rb +40 -0
- data/lib/rubocop/magic_comment.rb +101 -17
- data/lib/rubocop/name_similarity.rb +18 -10
- data/lib/rubocop/options.rb +335 -188
- data/lib/rubocop/path_util.rb +58 -37
- data/lib/rubocop/platform.rb +1 -1
- data/lib/rubocop/rake_task.rb +43 -17
- data/lib/rubocop/remote_config.rb +17 -15
- data/lib/rubocop/result_cache.rb +74 -44
- data/lib/rubocop/rspec/cop_helper.rb +36 -37
- data/lib/rubocop/rspec/expect_offense.rb +134 -41
- data/lib/rubocop/rspec/parallel_formatter.rb +90 -0
- data/lib/rubocop/rspec/shared_contexts.rb +115 -36
- data/lib/rubocop/rspec/support.rb +16 -1
- data/lib/rubocop/runner.rb +172 -91
- data/lib/rubocop/server/cache.rb +148 -0
- data/lib/rubocop/server/cli.rb +128 -0
- data/lib/rubocop/server/client_command/base.rb +44 -0
- data/lib/rubocop/server/client_command/exec.rb +64 -0
- data/lib/rubocop/server/client_command/restart.rb +25 -0
- data/lib/rubocop/server/client_command/start.rb +43 -0
- data/lib/rubocop/server/client_command/status.rb +28 -0
- data/lib/rubocop/server/client_command/stop.rb +31 -0
- data/lib/rubocop/server/client_command.rb +26 -0
- data/lib/rubocop/server/core.rb +96 -0
- data/lib/rubocop/server/errors.rb +23 -0
- data/lib/rubocop/server/helper.rb +34 -0
- data/lib/rubocop/server/server_command/base.rb +50 -0
- data/lib/rubocop/server/server_command/exec.rb +34 -0
- data/lib/rubocop/server/server_command/stop.rb +24 -0
- data/lib/rubocop/server/server_command.rb +21 -0
- data/lib/rubocop/server/socket_reader.rb +69 -0
- data/lib/rubocop/server.rb +53 -0
- data/lib/rubocop/string_interpreter.rb +7 -4
- data/lib/rubocop/target_finder.rb +58 -48
- data/lib/rubocop/target_ruby.rb +135 -15
- data/lib/rubocop/util.rb +16 -0
- data/lib/rubocop/version.rb +84 -7
- data/lib/rubocop/yaml_duplication_checker.rb +2 -1
- data/lib/rubocop.rb +213 -103
- metadata +307 -91
- data/bin/console +0 -10
- data/bin/setup +0 -7
- data/lib/rubocop/ast/builder.rb +0 -83
- data/lib/rubocop/ast/node/alias_node.rb +0 -24
- data/lib/rubocop/ast/node/and_node.rb +0 -29
- data/lib/rubocop/ast/node/args_node.rb +0 -29
- data/lib/rubocop/ast/node/array_node.rb +0 -57
- data/lib/rubocop/ast/node/block_node.rb +0 -117
- data/lib/rubocop/ast/node/break_node.rb +0 -17
- data/lib/rubocop/ast/node/case_node.rb +0 -56
- data/lib/rubocop/ast/node/class_node.rb +0 -31
- data/lib/rubocop/ast/node/def_node.rb +0 -82
- data/lib/rubocop/ast/node/defined_node.rb +0 -17
- data/lib/rubocop/ast/node/ensure_node.rb +0 -17
- data/lib/rubocop/ast/node/float_node.rb +0 -12
- data/lib/rubocop/ast/node/for_node.rb +0 -53
- data/lib/rubocop/ast/node/forward_args_node.rb +0 -18
- data/lib/rubocop/ast/node/hash_node.rb +0 -109
- data/lib/rubocop/ast/node/if_node.rb +0 -175
- data/lib/rubocop/ast/node/int_node.rb +0 -12
- data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
- data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -261
- data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
- data/lib/rubocop/ast/node/mixin/numeric_node.rb +0 -21
- data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
- data/lib/rubocop/ast/node/module_node.rb +0 -24
- data/lib/rubocop/ast/node/or_node.rb +0 -29
- data/lib/rubocop/ast/node/pair_node.rb +0 -63
- data/lib/rubocop/ast/node/range_node.rb +0 -18
- data/lib/rubocop/ast/node/regexp_node.rb +0 -33
- data/lib/rubocop/ast/node/resbody_node.rb +0 -24
- data/lib/rubocop/ast/node/retry_node.rb +0 -17
- data/lib/rubocop/ast/node/return_node.rb +0 -24
- data/lib/rubocop/ast/node/self_class_node.rb +0 -24
- data/lib/rubocop/ast/node/send_node.rb +0 -13
- data/lib/rubocop/ast/node/str_node.rb +0 -16
- data/lib/rubocop/ast/node/super_node.rb +0 -21
- data/lib/rubocop/ast/node/symbol_node.rb +0 -12
- data/lib/rubocop/ast/node/until_node.rb +0 -35
- data/lib/rubocop/ast/node/when_node.rb +0 -53
- data/lib/rubocop/ast/node/while_node.rb +0 -35
- data/lib/rubocop/ast/node/yield_node.rb +0 -21
- data/lib/rubocop/ast/node.rb +0 -632
- data/lib/rubocop/ast/sexp.rb +0 -16
- data/lib/rubocop/ast/traversal.rb +0 -200
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +0 -105
- data/lib/rubocop/cop/layout/tab.rb +0 -75
- data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -19
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +0 -29
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
- data/lib/rubocop/node_pattern.rb +0 -887
- data/lib/rubocop/processed_source.rb +0 -216
- data/lib/rubocop/string_util.rb +0 -14
- data/lib/rubocop/token.rb +0 -114
@@ -3,34 +3,46 @@
|
|
3
3
|
module RuboCop
|
4
4
|
module Cop
|
5
5
|
module Security
|
6
|
-
#
|
6
|
+
# Checks for the use of YAML class methods which have
|
7
7
|
# potential security issues leading to remote code execution when
|
8
8
|
# loading from an untrusted source.
|
9
9
|
#
|
10
|
+
# NOTE: Ruby 3.1+ (Psych 4) uses `Psych.load` as `Psych.safe_load` by default.
|
11
|
+
#
|
12
|
+
# @safety
|
13
|
+
# The behavior of the code might change depending on what was
|
14
|
+
# in the YAML payload, since `YAML.safe_load` is more restrictive.
|
15
|
+
#
|
10
16
|
# @example
|
11
17
|
# # bad
|
12
|
-
# YAML.load("---
|
18
|
+
# YAML.load("--- !ruby/object:Foo {}") # Psych 3 is unsafe by default
|
13
19
|
#
|
14
20
|
# # good
|
15
|
-
# YAML.safe_load("---
|
16
|
-
# YAML.
|
21
|
+
# YAML.safe_load("--- !ruby/object:Foo {}", [Foo]) # Ruby 2.5 (Psych 3)
|
22
|
+
# YAML.safe_load("--- !ruby/object:Foo {}", permitted_classes: [Foo]) # Ruby 3.0- (Psych 3)
|
23
|
+
# YAML.load("--- !ruby/object:Foo {}", permitted_classes: [Foo]) # Ruby 3.1+ (Psych 4)
|
24
|
+
# YAML.dump(foo)
|
17
25
|
#
|
18
|
-
class YAMLLoad <
|
26
|
+
class YAMLLoad < Base
|
27
|
+
extend AutoCorrector
|
28
|
+
|
19
29
|
MSG = 'Prefer using `YAML.safe_load` over `YAML.load`.'
|
30
|
+
RESTRICT_ON_SEND = %i[load].freeze
|
20
31
|
|
32
|
+
# @!method yaml_load(node)
|
21
33
|
def_node_matcher :yaml_load, <<~PATTERN
|
22
34
|
(send (const {nil? cbase} :YAML) :load ...)
|
23
35
|
PATTERN
|
24
36
|
|
25
37
|
def on_send(node)
|
38
|
+
return if target_ruby_version >= 3.1
|
39
|
+
|
26
40
|
yaml_load(node) do
|
27
|
-
add_offense(node
|
41
|
+
add_offense(node.loc.selector) do |corrector|
|
42
|
+
corrector.replace(node.loc.selector, 'safe_load')
|
43
|
+
end
|
28
44
|
end
|
29
45
|
end
|
30
|
-
|
31
|
-
def autocorrect(node)
|
32
|
-
->(corrector) { corrector.replace(node.loc.selector, 'safe_load') }
|
33
|
-
end
|
34
46
|
end
|
35
47
|
end
|
36
48
|
end
|
data/lib/rubocop/cop/severity.rb
CHANGED
@@ -6,11 +6,10 @@ module RuboCop
|
|
6
6
|
class Severity
|
7
7
|
include Comparable
|
8
8
|
|
9
|
-
|
10
|
-
NAMES = %i[refactor convention warning error fatal].freeze
|
9
|
+
NAMES = %i[info refactor convention warning error fatal].freeze
|
11
10
|
|
12
11
|
# @api private
|
13
|
-
CODE_TABLE = { R: :refactor, C: :convention,
|
12
|
+
CODE_TABLE = { I: :info, R: :refactor, C: :convention,
|
14
13
|
W: :warning, E: :error, F: :fatal }.freeze
|
15
14
|
|
16
15
|
# @api public
|
@@ -19,10 +18,9 @@ module RuboCop
|
|
19
18
|
#
|
20
19
|
# @return [Symbol]
|
21
20
|
# severity.
|
22
|
-
# any of `:refactor`, `:convention`, `:warning`, `:error` or `:fatal`.
|
21
|
+
# any of `:info`, `:refactor`, `:convention`, `:warning`, `:error` or `:fatal`.
|
23
22
|
attr_reader :name
|
24
23
|
|
25
|
-
# @api private
|
26
24
|
def self.name_from_code(code)
|
27
25
|
name = code.to_sym
|
28
26
|
CODE_TABLE[name] || name
|
@@ -31,30 +29,24 @@ module RuboCop
|
|
31
29
|
# @api private
|
32
30
|
def initialize(name_or_code)
|
33
31
|
name = Severity.name_from_code(name_or_code)
|
34
|
-
unless NAMES.include?(name)
|
35
|
-
raise ArgumentError, "Unknown severity: #{name}"
|
36
|
-
end
|
32
|
+
raise ArgumentError, "Unknown severity: #{name}" unless NAMES.include?(name)
|
37
33
|
|
38
34
|
@name = name.freeze
|
39
35
|
freeze
|
40
36
|
end
|
41
37
|
|
42
|
-
# @api private
|
43
38
|
def to_s
|
44
39
|
@name.to_s
|
45
40
|
end
|
46
41
|
|
47
|
-
# @api private
|
48
42
|
def code
|
49
43
|
@name.to_s[0].upcase
|
50
44
|
end
|
51
45
|
|
52
|
-
# @api private
|
53
46
|
def level
|
54
47
|
NAMES.index(name) + 1
|
55
48
|
end
|
56
49
|
|
57
|
-
# @api private
|
58
50
|
def ==(other)
|
59
51
|
@name == if other.is_a?(Symbol)
|
60
52
|
other
|
@@ -63,12 +55,10 @@ module RuboCop
|
|
63
55
|
end
|
64
56
|
end
|
65
57
|
|
66
|
-
# @api private
|
67
58
|
def hash
|
68
59
|
@name.hash
|
69
60
|
end
|
70
61
|
|
71
|
-
# @api private
|
72
62
|
def <=>(other)
|
73
63
|
level <=> other.level
|
74
64
|
end
|
@@ -5,11 +5,17 @@ module RuboCop
|
|
5
5
|
module Style
|
6
6
|
# Access modifiers should be declared to apply to a group of methods
|
7
7
|
# or inline before each method, depending on configuration.
|
8
|
+
# EnforcedStyle config covers only method definitions.
|
9
|
+
# Applications of visibility methods to symbols can be controlled
|
10
|
+
# using AllowModifiersOnSymbols config.
|
8
11
|
#
|
9
|
-
# @
|
12
|
+
# @safety
|
13
|
+
# Autocorrection is not safe, because the visibility of dynamically
|
14
|
+
# defined methods can vary depending on the state determined by
|
15
|
+
# the group access modifier.
|
10
16
|
#
|
17
|
+
# @example EnforcedStyle: group (default)
|
11
18
|
# # bad
|
12
|
-
#
|
13
19
|
# class Foo
|
14
20
|
#
|
15
21
|
# private def bar; end
|
@@ -18,7 +24,6 @@ module RuboCop
|
|
18
24
|
# end
|
19
25
|
#
|
20
26
|
# # good
|
21
|
-
#
|
22
27
|
# class Foo
|
23
28
|
#
|
24
29
|
# private
|
@@ -27,10 +32,9 @@ module RuboCop
|
|
27
32
|
# def baz; end
|
28
33
|
#
|
29
34
|
# end
|
30
|
-
# @example EnforcedStyle: inline
|
31
35
|
#
|
36
|
+
# @example EnforcedStyle: inline
|
32
37
|
# # bad
|
33
|
-
#
|
34
38
|
# class Foo
|
35
39
|
#
|
36
40
|
# private
|
@@ -41,15 +45,33 @@ module RuboCop
|
|
41
45
|
# end
|
42
46
|
#
|
43
47
|
# # good
|
44
|
-
#
|
45
48
|
# class Foo
|
46
49
|
#
|
47
50
|
# private def bar; end
|
48
51
|
# private def baz; end
|
49
52
|
#
|
50
53
|
# end
|
51
|
-
|
54
|
+
#
|
55
|
+
# @example AllowModifiersOnSymbols: true (default)
|
56
|
+
# # good
|
57
|
+
# class Foo
|
58
|
+
#
|
59
|
+
# private :bar, :baz
|
60
|
+
#
|
61
|
+
# end
|
62
|
+
#
|
63
|
+
# @example AllowModifiersOnSymbols: false
|
64
|
+
# # bad
|
65
|
+
# class Foo
|
66
|
+
#
|
67
|
+
# private :bar, :baz
|
68
|
+
#
|
69
|
+
# end
|
70
|
+
class AccessModifierDeclarations < Base
|
71
|
+
extend AutoCorrector
|
72
|
+
|
52
73
|
include ConfigurableEnforcedStyle
|
74
|
+
include RangeHelp
|
53
75
|
|
54
76
|
GROUP_STYLE_MESSAGE = [
|
55
77
|
'`%<access_modifier>s` should not be',
|
@@ -61,14 +83,25 @@ module RuboCop
|
|
61
83
|
'inlined in method definitions.'
|
62
84
|
].join(' ')
|
63
85
|
|
86
|
+
RESTRICT_ON_SEND = %i[private protected public module_function].freeze
|
87
|
+
|
88
|
+
ALLOWED_NODE_TYPES = %i[pair block].freeze
|
89
|
+
|
90
|
+
# @!method access_modifier_with_symbol?(node)
|
91
|
+
def_node_matcher :access_modifier_with_symbol?, <<~PATTERN
|
92
|
+
(send nil? {:private :protected :public :module_function} (sym _))
|
93
|
+
PATTERN
|
94
|
+
|
64
95
|
def on_send(node)
|
65
96
|
return unless node.access_modifier?
|
66
|
-
return if node.parent
|
97
|
+
return if ALLOWED_NODE_TYPES.include?(node.parent&.type)
|
98
|
+
return if allow_modifiers_on_symbols?(node)
|
67
99
|
|
68
100
|
if offense?(node)
|
69
|
-
add_offense(node
|
70
|
-
|
101
|
+
add_offense(node.loc.selector) do |corrector|
|
102
|
+
autocorrect(corrector, node)
|
71
103
|
end
|
104
|
+
opposite_style_detected
|
72
105
|
else
|
73
106
|
correct_style_detected
|
74
107
|
end
|
@@ -76,6 +109,27 @@ module RuboCop
|
|
76
109
|
|
77
110
|
private
|
78
111
|
|
112
|
+
def autocorrect(corrector, node)
|
113
|
+
case style
|
114
|
+
when :group
|
115
|
+
def_node = find_corresponding_def_node(node)
|
116
|
+
return unless def_node
|
117
|
+
|
118
|
+
remove_node(corrector, def_node)
|
119
|
+
remove_node(corrector, node)
|
120
|
+
insert_def(corrector, node, def_node.source)
|
121
|
+
when :inline
|
122
|
+
remove_node(corrector, node)
|
123
|
+
select_grouped_def_nodes(node).each do |grouped_def_node|
|
124
|
+
insert_inline_modifier(corrector, grouped_def_node, node.method_name)
|
125
|
+
end
|
126
|
+
end
|
127
|
+
end
|
128
|
+
|
129
|
+
def allow_modifiers_on_symbols?(node)
|
130
|
+
cop_config['AllowModifiersOnSymbols'] && access_modifier_with_symbol?(node)
|
131
|
+
end
|
132
|
+
|
79
133
|
def offense?(node)
|
80
134
|
(group_style? && access_modifier_is_inlined?(node)) ||
|
81
135
|
(inline_style? && access_modifier_is_not_inlined?(node))
|
@@ -97,8 +151,8 @@ module RuboCop
|
|
97
151
|
!access_modifier_is_inlined?(node)
|
98
152
|
end
|
99
153
|
|
100
|
-
def message(
|
101
|
-
access_modifier =
|
154
|
+
def message(range)
|
155
|
+
access_modifier = range.source
|
102
156
|
|
103
157
|
if group_style?
|
104
158
|
format(GROUP_STYLE_MESSAGE, access_modifier: access_modifier)
|
@@ -106,6 +160,50 @@ module RuboCop
|
|
106
160
|
format(INLINE_STYLE_MESSAGE, access_modifier: access_modifier)
|
107
161
|
end
|
108
162
|
end
|
163
|
+
|
164
|
+
def find_corresponding_def_node(node)
|
165
|
+
if access_modifier_with_symbol?(node)
|
166
|
+
method_name = node.arguments.first.value
|
167
|
+
node.parent.each_child_node(:def).find do |child|
|
168
|
+
child.method?(method_name)
|
169
|
+
end
|
170
|
+
else
|
171
|
+
node.arguments.first
|
172
|
+
end
|
173
|
+
end
|
174
|
+
|
175
|
+
def find_argument_less_modifier_node(node)
|
176
|
+
node.parent.each_child_node(:send).find do |child|
|
177
|
+
child.method?(node.method_name) && child.arguments.empty?
|
178
|
+
end
|
179
|
+
end
|
180
|
+
|
181
|
+
def select_grouped_def_nodes(node)
|
182
|
+
node.right_siblings.take_while do |sibling|
|
183
|
+
!(sibling.send_type? && sibling.bare_access_modifier_declaration?)
|
184
|
+
end.select(&:def_type?)
|
185
|
+
end
|
186
|
+
|
187
|
+
def insert_def(corrector, node, source)
|
188
|
+
source = [*processed_source.ast_with_comments[node].map(&:text), source].join("\n")
|
189
|
+
argument_less_modifier_node = find_argument_less_modifier_node(node)
|
190
|
+
if argument_less_modifier_node
|
191
|
+
corrector.insert_after(argument_less_modifier_node, "\n\n#{source}")
|
192
|
+
else
|
193
|
+
corrector.insert_before(
|
194
|
+
node.each_ancestor(:block, :class, :module).first.location.end,
|
195
|
+
"#{node.method_name}\n\n#{source}\n"
|
196
|
+
)
|
197
|
+
end
|
198
|
+
end
|
199
|
+
|
200
|
+
def insert_inline_modifier(corrector, node, modifier_name)
|
201
|
+
corrector.insert_before(node, "#{modifier_name} ")
|
202
|
+
end
|
203
|
+
|
204
|
+
def remove_node(corrector, node)
|
205
|
+
corrector.remove(range_with_comments_and_lines(node))
|
206
|
+
end
|
109
207
|
end
|
110
208
|
end
|
111
209
|
end
|
@@ -0,0 +1,154 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Style
|
6
|
+
# Checks for grouping of accessors in `class` and `module` bodies.
|
7
|
+
# By default it enforces accessors to be placed in grouped declarations,
|
8
|
+
# but it can be configured to enforce separating them in multiple declarations.
|
9
|
+
#
|
10
|
+
# NOTE: `Sorbet` is not compatible with "grouped" style. Consider "separated" style
|
11
|
+
# or disabling this cop.
|
12
|
+
#
|
13
|
+
# @example EnforcedStyle: grouped (default)
|
14
|
+
# # bad
|
15
|
+
# class Foo
|
16
|
+
# attr_reader :bar
|
17
|
+
# attr_reader :baz
|
18
|
+
# end
|
19
|
+
#
|
20
|
+
# # good
|
21
|
+
# class Foo
|
22
|
+
# attr_reader :bar, :baz
|
23
|
+
# end
|
24
|
+
#
|
25
|
+
# @example EnforcedStyle: separated
|
26
|
+
# # bad
|
27
|
+
# class Foo
|
28
|
+
# attr_reader :bar, :baz
|
29
|
+
# end
|
30
|
+
#
|
31
|
+
# # good
|
32
|
+
# class Foo
|
33
|
+
# attr_reader :bar
|
34
|
+
# attr_reader :baz
|
35
|
+
# end
|
36
|
+
#
|
37
|
+
class AccessorGrouping < Base
|
38
|
+
include ConfigurableEnforcedStyle
|
39
|
+
include RangeHelp
|
40
|
+
include VisibilityHelp
|
41
|
+
extend AutoCorrector
|
42
|
+
|
43
|
+
GROUPED_MSG = 'Group together all `%<accessor>s` attributes.'
|
44
|
+
SEPARATED_MSG = 'Use one attribute per `%<accessor>s`.'
|
45
|
+
|
46
|
+
ACCESSOR_METHODS = %i[attr_reader attr_writer attr_accessor attr].freeze
|
47
|
+
|
48
|
+
def on_class(node)
|
49
|
+
class_send_elements(node).each do |macro|
|
50
|
+
next unless accessor?(macro)
|
51
|
+
|
52
|
+
check(macro)
|
53
|
+
end
|
54
|
+
end
|
55
|
+
alias on_sclass on_class
|
56
|
+
alias on_module on_class
|
57
|
+
|
58
|
+
private
|
59
|
+
|
60
|
+
def check(send_node)
|
61
|
+
return if previous_line_comment?(send_node)
|
62
|
+
return unless (grouped_style? && sibling_accessors(send_node).size > 1) ||
|
63
|
+
(separated_style? && send_node.arguments.size > 1)
|
64
|
+
|
65
|
+
message = message(send_node)
|
66
|
+
add_offense(send_node, message: message) do |corrector|
|
67
|
+
autocorrect(corrector, send_node)
|
68
|
+
end
|
69
|
+
end
|
70
|
+
|
71
|
+
def autocorrect(corrector, node)
|
72
|
+
if (preferred_accessors = preferred_accessors(node))
|
73
|
+
corrector.replace(node, preferred_accessors)
|
74
|
+
else
|
75
|
+
range = range_with_surrounding_space(node.loc.expression, side: :left)
|
76
|
+
corrector.remove(range)
|
77
|
+
end
|
78
|
+
end
|
79
|
+
|
80
|
+
def previous_line_comment?(node)
|
81
|
+
comment_line?(processed_source[node.first_line - 2])
|
82
|
+
end
|
83
|
+
|
84
|
+
def class_send_elements(class_node)
|
85
|
+
class_def = class_node.body
|
86
|
+
|
87
|
+
if !class_def || class_def.def_type?
|
88
|
+
[]
|
89
|
+
elsif class_def.send_type?
|
90
|
+
[class_def]
|
91
|
+
else
|
92
|
+
class_def.each_child_node(:send).to_a
|
93
|
+
end
|
94
|
+
end
|
95
|
+
|
96
|
+
def accessor?(send_node)
|
97
|
+
send_node.macro? && ACCESSOR_METHODS.include?(send_node.method_name)
|
98
|
+
end
|
99
|
+
|
100
|
+
def grouped_style?
|
101
|
+
style == :grouped
|
102
|
+
end
|
103
|
+
|
104
|
+
def separated_style?
|
105
|
+
style == :separated
|
106
|
+
end
|
107
|
+
|
108
|
+
def sibling_accessors(send_node)
|
109
|
+
send_node.parent.each_child_node(:send).select do |sibling|
|
110
|
+
accessor?(sibling) &&
|
111
|
+
sibling.method?(send_node.method_name) &&
|
112
|
+
node_visibility(sibling) == node_visibility(send_node) &&
|
113
|
+
!previous_line_comment?(sibling)
|
114
|
+
end
|
115
|
+
end
|
116
|
+
|
117
|
+
def message(send_node)
|
118
|
+
msg = grouped_style? ? GROUPED_MSG : SEPARATED_MSG
|
119
|
+
format(msg, accessor: send_node.method_name)
|
120
|
+
end
|
121
|
+
|
122
|
+
def preferred_accessors(node)
|
123
|
+
if grouped_style?
|
124
|
+
accessors = sibling_accessors(node)
|
125
|
+
group_accessors(node, accessors) if node.loc == accessors.first.loc
|
126
|
+
else
|
127
|
+
separate_accessors(node)
|
128
|
+
end
|
129
|
+
end
|
130
|
+
|
131
|
+
def group_accessors(node, accessors)
|
132
|
+
accessor_names = accessors.flat_map { |accessor| accessor.arguments.map(&:source) }.uniq
|
133
|
+
|
134
|
+
"#{node.method_name} #{accessor_names.join(', ')}"
|
135
|
+
end
|
136
|
+
|
137
|
+
def separate_accessors(node)
|
138
|
+
node.arguments.flat_map do |arg|
|
139
|
+
lines = [
|
140
|
+
*processed_source.ast_with_comments[arg].map(&:text),
|
141
|
+
"#{node.method_name} #{arg.source}"
|
142
|
+
]
|
143
|
+
if arg == node.arguments.first
|
144
|
+
lines
|
145
|
+
else
|
146
|
+
indent = ' ' * node.loc.column
|
147
|
+
lines.map { |line| "#{indent}#{line}" }
|
148
|
+
end
|
149
|
+
end.join("\n")
|
150
|
+
end
|
151
|
+
end
|
152
|
+
end
|
153
|
+
end
|
154
|
+
end
|
@@ -3,10 +3,15 @@
|
|
3
3
|
module RuboCop
|
4
4
|
module Cop
|
5
5
|
module Style
|
6
|
-
#
|
6
|
+
# Enforces the use of either `#alias` or `#alias_method`
|
7
7
|
# depending on configuration.
|
8
8
|
# It also flags uses of `alias :symbol` rather than `alias bareword`.
|
9
9
|
#
|
10
|
+
# However, it will always enforce `method_alias` when used `alias`
|
11
|
+
# in an instance method definition and in a singleton method definition.
|
12
|
+
# If used in a block, always enforce `alias_method`
|
13
|
+
# unless it is an `instance_eval` block.
|
14
|
+
#
|
10
15
|
# @example EnforcedStyle: prefer_alias (default)
|
11
16
|
# # bad
|
12
17
|
# alias_method :bar, :foo
|
@@ -22,62 +27,67 @@ module RuboCop
|
|
22
27
|
#
|
23
28
|
# # good
|
24
29
|
# alias_method :bar, :foo
|
25
|
-
|
30
|
+
#
|
31
|
+
class Alias < Base
|
26
32
|
include ConfigurableEnforcedStyle
|
33
|
+
extend AutoCorrector
|
27
34
|
|
28
35
|
MSG_ALIAS = 'Use `alias_method` instead of `alias`.'
|
29
|
-
MSG_ALIAS_METHOD = 'Use `alias` instead of `alias_method` '
|
30
|
-
|
31
|
-
|
32
|
-
|
36
|
+
MSG_ALIAS_METHOD = 'Use `alias` instead of `alias_method` %<current>s.'
|
37
|
+
MSG_SYMBOL_ARGS = 'Use `alias %<prefer>s` instead of `alias %<current>s`.'
|
38
|
+
|
39
|
+
RESTRICT_ON_SEND = %i[alias_method].freeze
|
33
40
|
|
34
41
|
def on_send(node)
|
35
42
|
return unless node.command?(:alias_method)
|
36
43
|
return unless style == :prefer_alias && alias_keyword_possible?(node)
|
37
44
|
|
38
45
|
msg = format(MSG_ALIAS_METHOD, current: lexical_scope_type(node))
|
39
|
-
add_offense(node
|
46
|
+
add_offense(node.loc.selector, message: msg) do |corrector|
|
47
|
+
autocorrect(corrector, node)
|
48
|
+
end
|
40
49
|
end
|
41
50
|
|
42
51
|
def on_alias(node)
|
43
52
|
return unless alias_method_possible?(node)
|
44
53
|
|
45
54
|
if scope_type(node) == :dynamic || style == :prefer_alias_method
|
46
|
-
add_offense(node
|
55
|
+
add_offense(node.loc.keyword, message: MSG_ALIAS) do |corrector|
|
56
|
+
autocorrect(corrector, node)
|
57
|
+
end
|
47
58
|
elsif node.children.none? { |arg| bareword?(arg) }
|
48
|
-
add_offense_for_args(node)
|
59
|
+
add_offense_for_args(node) { |corrector| autocorrect(corrector, node) }
|
49
60
|
end
|
50
61
|
end
|
51
62
|
|
52
|
-
|
63
|
+
private
|
64
|
+
|
65
|
+
def autocorrect(corrector, node)
|
53
66
|
if node.send_type?
|
54
|
-
correct_alias_method_to_alias(node)
|
67
|
+
correct_alias_method_to_alias(corrector, node)
|
55
68
|
elsif scope_type(node) == :dynamic || style == :prefer_alias_method
|
56
|
-
correct_alias_to_alias_method(node)
|
69
|
+
correct_alias_to_alias_method(corrector, node)
|
57
70
|
else
|
58
|
-
correct_alias_with_symbol_args(node)
|
71
|
+
correct_alias_with_symbol_args(corrector, node)
|
59
72
|
end
|
60
73
|
end
|
61
74
|
|
62
|
-
private
|
63
|
-
|
64
75
|
def alias_keyword_possible?(node)
|
65
76
|
scope_type(node) != :dynamic && node.arguments.all?(&:sym_type?)
|
66
77
|
end
|
67
78
|
|
68
79
|
def alias_method_possible?(node)
|
69
80
|
scope_type(node) != :instance_eval &&
|
70
|
-
node.children.none?(&:gvar_type?)
|
81
|
+
node.children.none?(&:gvar_type?) &&
|
82
|
+
node&.parent&.type != :def
|
71
83
|
end
|
72
84
|
|
73
|
-
def add_offense_for_args(node)
|
85
|
+
def add_offense_for_args(node, &block)
|
74
86
|
existing_args = node.children.map(&:source).join(' ')
|
75
|
-
preferred_args = node.children.map { |a| a.source[1
|
87
|
+
preferred_args = node.children.map { |a| a.source[1..] }.join(' ')
|
76
88
|
arg_ranges = node.children.map(&:source_range)
|
77
|
-
msg = format(MSG_SYMBOL_ARGS,
|
78
|
-
|
79
|
-
current: existing_args)
|
80
|
-
add_offense(node, location: arg_ranges.reduce(&:join), message: msg)
|
89
|
+
msg = format(MSG_SYMBOL_ARGS, prefer: preferred_args, current: existing_args)
|
90
|
+
add_offense(arg_ranges.reduce(&:join), message: msg, &block)
|
81
91
|
end
|
82
92
|
|
83
93
|
# In this expression, will `self` be the same as the innermost enclosing
|
@@ -101,43 +111,42 @@ module RuboCop
|
|
101
111
|
end
|
102
112
|
|
103
113
|
def lexical_scope_type(node)
|
104
|
-
node.each_ancestor(:class, :module)
|
105
|
-
|
114
|
+
ancestor = node.each_ancestor(:class, :module).first
|
115
|
+
if ancestor.nil?
|
116
|
+
'at the top level'
|
117
|
+
elsif ancestor.class_type?
|
118
|
+
'in a class body'
|
119
|
+
else
|
120
|
+
'in a module body'
|
106
121
|
end
|
107
|
-
'at the top level'
|
108
122
|
end
|
109
123
|
|
110
124
|
def bareword?(sym_node)
|
111
125
|
!sym_node.source.start_with?(':')
|
112
126
|
end
|
113
127
|
|
114
|
-
def correct_alias_method_to_alias(send_node)
|
115
|
-
|
116
|
-
|
117
|
-
|
118
|
-
|
119
|
-
end
|
128
|
+
def correct_alias_method_to_alias(corrector, send_node)
|
129
|
+
new, old = *send_node.arguments
|
130
|
+
replacement = "alias #{identifier(new)} #{identifier(old)}"
|
131
|
+
|
132
|
+
corrector.replace(send_node, replacement)
|
120
133
|
end
|
121
134
|
|
122
|
-
def correct_alias_to_alias_method(node)
|
123
|
-
|
124
|
-
|
125
|
-
|
126
|
-
|
127
|
-
|
128
|
-
|
129
|
-
end
|
135
|
+
def correct_alias_to_alias_method(corrector, node)
|
136
|
+
replacement =
|
137
|
+
'alias_method ' \
|
138
|
+
":#{identifier(node.new_identifier)}, " \
|
139
|
+
":#{identifier(node.old_identifier)}"
|
140
|
+
|
141
|
+
corrector.replace(node, replacement)
|
130
142
|
end
|
131
143
|
|
132
|
-
def correct_alias_with_symbol_args(node)
|
133
|
-
|
134
|
-
|
135
|
-
node.new_identifier.source[1..-1])
|
136
|
-
corrector.replace(node.old_identifier.source_range,
|
137
|
-
node.old_identifier.source[1..-1])
|
138
|
-
end
|
144
|
+
def correct_alias_with_symbol_args(corrector, node)
|
145
|
+
corrector.replace(node.new_identifier, node.new_identifier.source[1..])
|
146
|
+
corrector.replace(node.old_identifier, node.old_identifier.source[1..])
|
139
147
|
end
|
140
148
|
|
149
|
+
# @!method identifier(node)
|
141
150
|
def_node_matcher :identifier, <<~PATTERN
|
142
151
|
(sym $_)
|
143
152
|
PATTERN
|