rubocop 0.80.0 → 1.42.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (845) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +71 -38
  4. data/assets/output.html.erb +1 -1
  5. data/config/default.yml +1682 -202
  6. data/config/obsoletion.yml +233 -0
  7. data/exe/rubocop +15 -9
  8. data/lib/rubocop/arguments_env.rb +17 -0
  9. data/lib/rubocop/arguments_file.rb +17 -0
  10. data/lib/rubocop/ast_aliases.rb +8 -0
  11. data/lib/rubocop/cache_config.rb +29 -0
  12. data/lib/rubocop/cached_data.rb +4 -4
  13. data/lib/rubocop/cli/command/auto_generate_config.rb +147 -0
  14. data/lib/rubocop/cli/command/base.rb +2 -0
  15. data/lib/rubocop/cli/command/execute_runner.rb +38 -14
  16. data/lib/rubocop/cli/command/init_dotfile.rb +4 -5
  17. data/lib/rubocop/cli/command/show_cops.rb +6 -12
  18. data/lib/rubocop/cli/command/show_docs_url.rb +48 -0
  19. data/lib/rubocop/cli/command/suggest_extensions.rb +126 -0
  20. data/lib/rubocop/cli/command/version.rb +3 -2
  21. data/lib/rubocop/cli/command.rb +1 -0
  22. data/lib/rubocop/cli/environment.rb +1 -0
  23. data/lib/rubocop/cli.rb +41 -14
  24. data/lib/rubocop/comment_config.rb +90 -99
  25. data/lib/rubocop/config.rb +117 -42
  26. data/lib/rubocop/config_finder.rb +68 -0
  27. data/lib/rubocop/config_loader.rb +122 -133
  28. data/lib/rubocop/config_loader_resolver.rb +125 -39
  29. data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
  30. data/lib/rubocop/config_obsoletion/changed_parameter.rb +26 -0
  31. data/lib/rubocop/config_obsoletion/cop_rule.rb +33 -0
  32. data/lib/rubocop/config_obsoletion/extracted_cop.rb +46 -0
  33. data/lib/rubocop/config_obsoletion/parameter_rule.rb +48 -0
  34. data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
  35. data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
  36. data/lib/rubocop/config_obsoletion/rule.rb +41 -0
  37. data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
  38. data/lib/rubocop/config_obsoletion.rb +72 -240
  39. data/lib/rubocop/config_regeneration.rb +33 -0
  40. data/lib/rubocop/config_store.rb +31 -7
  41. data/lib/rubocop/config_validator.rb +95 -29
  42. data/lib/rubocop/cop/autocorrect_logic.rb +45 -40
  43. data/lib/rubocop/cop/badge.rb +27 -32
  44. data/lib/rubocop/cop/base.rb +464 -0
  45. data/lib/rubocop/cop/bundler/duplicated_gem.rb +34 -14
  46. data/lib/rubocop/cop/bundler/gem_comment.rb +117 -10
  47. data/lib/rubocop/cop/bundler/gem_filename.rb +103 -0
  48. data/lib/rubocop/cop/bundler/gem_version.rb +133 -0
  49. data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +45 -28
  50. data/lib/rubocop/cop/bundler/ordered_gems.rb +7 -18
  51. data/lib/rubocop/cop/commissioner.rb +105 -74
  52. data/lib/rubocop/cop/cop.rb +84 -234
  53. data/lib/rubocop/cop/corrector.rb +77 -119
  54. data/lib/rubocop/cop/correctors/alignment_corrector.rb +14 -24
  55. data/lib/rubocop/cop/correctors/condition_corrector.rb +4 -7
  56. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +4 -6
  57. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +10 -11
  58. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +5 -4
  59. data/lib/rubocop/cop/correctors/if_then_corrector.rb +55 -0
  60. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +7 -7
  61. data/lib/rubocop/cop/correctors/line_break_corrector.rb +15 -12
  62. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +56 -11
  63. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +12 -13
  64. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +64 -9
  65. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +11 -22
  66. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +9 -11
  67. data/lib/rubocop/cop/correctors/require_library_corrector.rb +23 -0
  68. data/lib/rubocop/cop/correctors/space_corrector.rb +2 -4
  69. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +7 -9
  70. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +16 -19
  71. data/lib/rubocop/cop/documentation.rb +39 -0
  72. data/lib/rubocop/cop/exclude_limit.rb +26 -0
  73. data/lib/rubocop/cop/force.rb +2 -1
  74. data/lib/rubocop/cop/gemspec/dependency_version.rb +154 -0
  75. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
  76. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +11 -26
  77. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +7 -20
  78. data/lib/rubocop/cop/gemspec/require_mfa.rb +145 -0
  79. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +69 -27
  80. data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +7 -12
  81. data/lib/rubocop/cop/generator/configuration_injector.rb +4 -5
  82. data/lib/rubocop/cop/generator/require_file_injector.rb +4 -7
  83. data/lib/rubocop/cop/generator.rb +36 -41
  84. data/lib/rubocop/cop/ignored_node.rb +1 -3
  85. data/lib/rubocop/cop/internal_affairs/cop_description.rb +98 -0
  86. data/lib/rubocop/cop/internal_affairs/create_empty_file.rb +37 -0
  87. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +68 -0
  88. data/lib/rubocop/cop/internal_affairs/example_description.rb +92 -0
  89. data/lib/rubocop/cop/internal_affairs/example_heredoc_delimiter.rb +111 -0
  90. data/lib/rubocop/cop/internal_affairs/inherit_deprecated_cop_class.rb +34 -0
  91. data/lib/rubocop/cop/internal_affairs/lambda_or_proc.rb +46 -0
  92. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +60 -0
  93. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +80 -0
  94. data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +8 -17
  95. data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +4 -4
  96. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +147 -0
  97. data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +11 -14
  98. data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
  99. data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +12 -10
  100. data/lib/rubocop/cop/internal_affairs/redundant_context_config_parameter.rb +46 -0
  101. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +62 -0
  102. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +65 -0
  103. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +13 -8
  104. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +12 -9
  105. data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +47 -0
  106. data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
  107. data/lib/rubocop/cop/internal_affairs/style_detected_api_use.rb +148 -0
  108. data/lib/rubocop/cop/internal_affairs/undefined_config.rb +73 -0
  109. data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +6 -6
  110. data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
  111. data/lib/rubocop/cop/internal_affairs.rb +20 -1
  112. data/lib/rubocop/cop/layout/access_modifier_indentation.rb +12 -10
  113. data/lib/rubocop/cop/layout/argument_alignment.rb +84 -19
  114. data/lib/rubocop/cop/layout/array_alignment.rb +58 -13
  115. data/lib/rubocop/cop/layout/assignment_indentation.rb +10 -9
  116. data/lib/rubocop/cop/layout/begin_end_alignment.rb +74 -0
  117. data/lib/rubocop/cop/layout/block_alignment.rb +56 -60
  118. data/lib/rubocop/cop/layout/block_end_newline.rb +41 -13
  119. data/lib/rubocop/cop/layout/case_indentation.rb +88 -30
  120. data/lib/rubocop/cop/layout/class_structure.rb +90 -80
  121. data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
  122. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +25 -31
  123. data/lib/rubocop/cop/layout/comment_indentation.rb +56 -29
  124. data/lib/rubocop/cop/layout/condition_position.rb +17 -9
  125. data/lib/rubocop/cop/layout/def_end_alignment.rb +10 -11
  126. data/lib/rubocop/cop/layout/dot_position.rb +65 -27
  127. data/lib/rubocop/cop/layout/else_alignment.rb +29 -7
  128. data/lib/rubocop/cop/layout/empty_comment.rb +30 -30
  129. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +61 -37
  130. data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +13 -13
  131. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
  132. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +161 -40
  133. data/lib/rubocop/cop/layout/empty_lines.rb +10 -13
  134. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +32 -38
  135. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +14 -10
  136. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +139 -0
  137. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +3 -6
  138. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +8 -9
  139. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +12 -15
  140. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +16 -19
  141. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +3 -6
  142. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +12 -15
  143. data/lib/rubocop/cop/layout/end_alignment.rb +26 -25
  144. data/lib/rubocop/cop/layout/end_of_line.rb +13 -13
  145. data/lib/rubocop/cop/layout/extra_spacing.rb +32 -47
  146. data/lib/rubocop/cop/layout/first_argument_indentation.rb +74 -41
  147. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +38 -25
  148. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +43 -11
  149. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +84 -29
  150. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +51 -8
  151. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +66 -14
  152. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +54 -8
  153. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +11 -10
  154. data/lib/rubocop/cop/layout/hash_alignment.rb +85 -55
  155. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +48 -32
  156. data/lib/rubocop/cop/layout/heredoc_indentation.rb +33 -124
  157. data/lib/rubocop/cop/layout/indentation_consistency.rb +10 -7
  158. data/lib/rubocop/cop/layout/indentation_style.rb +115 -0
  159. data/lib/rubocop/cop/layout/indentation_width.rb +51 -26
  160. data/lib/rubocop/cop/layout/initial_indentation.rb +8 -12
  161. data/lib/rubocop/cop/layout/leading_comment_space.rb +15 -13
  162. data/lib/rubocop/cop/layout/leading_empty_lines.rb +7 -12
  163. data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +138 -0
  164. data/lib/rubocop/cop/layout/line_continuation_spacing.rb +136 -0
  165. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +141 -0
  166. data/lib/rubocop/cop/layout/line_length.rb +62 -63
  167. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +9 -12
  168. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +53 -8
  169. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +41 -19
  170. data/lib/rubocop/cop/layout/multiline_block_layout.rb +45 -39
  171. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +9 -12
  172. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +53 -10
  173. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +64 -14
  174. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +9 -12
  175. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +52 -24
  176. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +9 -12
  177. data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +101 -0
  178. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +28 -15
  179. data/lib/rubocop/cop/layout/parameter_alignment.rb +8 -7
  180. data/lib/rubocop/cop/layout/redundant_line_break.rb +139 -0
  181. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +60 -40
  182. data/lib/rubocop/cop/layout/single_line_block_chain.rb +64 -0
  183. data/lib/rubocop/cop/layout/space_after_colon.rb +11 -9
  184. data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
  185. data/lib/rubocop/cop/layout/space_after_method_name.rb +7 -10
  186. data/lib/rubocop/cop/layout/space_after_not.rb +11 -12
  187. data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
  188. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +47 -54
  189. data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +20 -23
  190. data/lib/rubocop/cop/layout/space_around_keyword.rb +54 -30
  191. data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
  192. data/lib/rubocop/cop/layout/space_around_operators.rb +61 -28
  193. data/lib/rubocop/cop/layout/space_before_block_braces.rb +43 -25
  194. data/lib/rubocop/cop/layout/space_before_brackets.rb +73 -0
  195. data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
  196. data/lib/rubocop/cop/layout/space_before_comment.rb +11 -12
  197. data/lib/rubocop/cop/layout/space_before_first_arg.rb +13 -15
  198. data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
  199. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +17 -21
  200. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +50 -55
  201. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +8 -15
  202. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +63 -50
  203. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +52 -44
  204. data/lib/rubocop/cop/layout/space_inside_parens.rb +92 -29
  205. data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +38 -9
  206. data/lib/rubocop/cop/layout/space_inside_range_literal.rb +9 -18
  207. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +25 -32
  208. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +13 -14
  209. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +20 -25
  210. data/lib/rubocop/cop/layout/trailing_whitespace.rb +73 -19
  211. data/lib/rubocop/cop/legacy/corrections_proxy.rb +43 -0
  212. data/lib/rubocop/cop/legacy/corrector.rb +27 -0
  213. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +54 -0
  214. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +44 -11
  215. data/lib/rubocop/cop/lint/ambiguous_operator.rb +60 -12
  216. data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +111 -0
  217. data/lib/rubocop/cop/lint/ambiguous_range.rb +105 -0
  218. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +44 -7
  219. data/lib/rubocop/cop/lint/assignment_in_condition.rb +20 -8
  220. data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -10
  221. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +68 -0
  222. data/lib/rubocop/cop/lint/boolean_symbol.rb +30 -5
  223. data/lib/rubocop/cop/lint/circular_argument_reference.rb +2 -2
  224. data/lib/rubocop/cop/lint/constant_definition_in_block.rb +100 -0
  225. data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
  226. data/lib/rubocop/cop/lint/constant_resolution.rb +93 -0
  227. data/lib/rubocop/cop/lint/debugger.rb +76 -26
  228. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +109 -52
  229. data/lib/rubocop/cop/lint/deprecated_constants.rb +88 -0
  230. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +154 -0
  231. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +32 -3
  232. data/lib/rubocop/cop/lint/duplicate_branch.rb +153 -0
  233. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +4 -14
  234. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
  235. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +3 -5
  236. data/lib/rubocop/cop/lint/duplicate_magic_comment.rb +73 -0
  237. data/lib/rubocop/cop/lint/duplicate_methods.rb +63 -34
  238. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +96 -0
  239. data/lib/rubocop/cop/lint/duplicate_require.rb +56 -0
  240. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
  241. data/lib/rubocop/cop/lint/each_with_object_argument.rb +5 -3
  242. data/lib/rubocop/cop/lint/else_layout.rb +37 -9
  243. data/lib/rubocop/cop/lint/empty_block.rb +94 -0
  244. data/lib/rubocop/cop/lint/empty_class.rb +95 -0
  245. data/lib/rubocop/cop/lint/empty_conditional_body.rb +175 -0
  246. data/lib/rubocop/cop/lint/empty_ensure.rb +6 -8
  247. data/lib/rubocop/cop/lint/empty_expression.rb +3 -3
  248. data/lib/rubocop/cop/lint/empty_file.rb +48 -0
  249. data/lib/rubocop/cop/lint/empty_in_pattern.rb +64 -0
  250. data/lib/rubocop/cop/lint/empty_interpolation.rb +5 -8
  251. data/lib/rubocop/cop/lint/empty_when.rb +34 -9
  252. data/lib/rubocop/cop/lint/ensure_return.rb +29 -16
  253. data/lib/rubocop/cop/lint/erb_new_arguments.rb +28 -30
  254. data/lib/rubocop/cop/lint/flip_flop.rb +9 -3
  255. data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
  256. data/lib/rubocop/cop/lint/float_out_of_range.rb +3 -4
  257. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +45 -10
  258. data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +47 -0
  259. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +15 -17
  260. data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
  261. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +8 -8
  262. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +79 -0
  263. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +15 -21
  264. data/lib/rubocop/cop/lint/inherit_exception.rb +32 -36
  265. data/lib/rubocop/cop/lint/interpolation_check.rb +28 -9
  266. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +51 -0
  267. data/lib/rubocop/cop/lint/literal_as_condition.rb +43 -17
  268. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +49 -16
  269. data/lib/rubocop/cop/lint/loop.rb +32 -9
  270. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +51 -24
  271. data/lib/rubocop/cop/lint/missing_super.rb +101 -0
  272. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +36 -0
  273. data/lib/rubocop/cop/lint/multiple_comparison.rb +15 -15
  274. data/lib/rubocop/cop/lint/nested_method_definition.rb +71 -26
  275. data/lib/rubocop/cop/lint/nested_percent_literal.rb +19 -7
  276. data/lib/rubocop/cop/lint/next_without_accumulator.rb +26 -6
  277. data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
  278. data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +162 -0
  279. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +112 -16
  280. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +13 -10
  281. data/lib/rubocop/cop/lint/number_conversion.rb +137 -27
  282. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +47 -0
  283. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +40 -0
  284. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +16 -20
  285. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +132 -0
  286. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +42 -14
  287. data/lib/rubocop/cop/lint/percent_string_array.rb +18 -13
  288. data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -15
  289. data/lib/rubocop/cop/lint/raise_exception.rb +91 -0
  290. data/lib/rubocop/cop/lint/rand_one.rb +6 -5
  291. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +180 -119
  292. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +46 -32
  293. data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +62 -0
  294. data/lib/rubocop/cop/lint/redundant_require_statement.rb +45 -15
  295. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +91 -0
  296. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +73 -36
  297. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +9 -16
  298. data/lib/rubocop/cop/lint/redundant_with_index.rb +26 -28
  299. data/lib/rubocop/cop/lint/redundant_with_object.rb +25 -29
  300. data/lib/rubocop/cop/lint/refinement_import_methods.rb +51 -0
  301. data/lib/rubocop/cop/lint/regexp_as_condition.rb +13 -5
  302. data/lib/rubocop/cop/lint/require_parentheses.rb +8 -8
  303. data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
  304. data/lib/rubocop/cop/lint/require_relative_self_path.rb +50 -0
  305. data/lib/rubocop/cop/lint/rescue_exception.rb +3 -4
  306. data/lib/rubocop/cop/lint/rescue_type.rb +10 -16
  307. data/lib/rubocop/cop/lint/return_in_void_context.rb +7 -22
  308. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +48 -15
  309. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +16 -18
  310. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +13 -5
  311. data/lib/rubocop/cop/lint/script_permission.rb +11 -8
  312. data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
  313. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +14 -21
  314. data/lib/rubocop/cop/lint/shadowed_argument.rb +10 -16
  315. data/lib/rubocop/cop/lint/shadowed_exception.rb +34 -41
  316. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +56 -7
  317. data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
  318. data/lib/rubocop/cop/lint/suppressed_exception.rb +55 -18
  319. data/lib/rubocop/cop/lint/symbol_conversion.rb +179 -0
  320. data/lib/rubocop/cop/lint/syntax.rb +10 -30
  321. data/lib/rubocop/cop/lint/to_enum_arguments.rb +89 -0
  322. data/lib/rubocop/cop/lint/to_json.rb +22 -14
  323. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
  324. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +55 -0
  325. data/lib/rubocop/cop/lint/triple_quotes.rb +71 -0
  326. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +6 -8
  327. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +90 -0
  328. data/lib/rubocop/cop/lint/unified_integer.rb +7 -8
  329. data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +204 -0
  330. data/lib/rubocop/cop/lint/unreachable_code.rb +6 -8
  331. data/lib/rubocop/cop/lint/unreachable_loop.rb +202 -0
  332. data/lib/rubocop/cop/lint/unused_block_argument.rb +19 -12
  333. data/lib/rubocop/cop/lint/unused_method_argument.rb +48 -13
  334. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +6 -3
  335. data/lib/rubocop/cop/lint/uri_regexp.rb +13 -48
  336. data/lib/rubocop/cop/lint/useless_access_modifier.rb +45 -27
  337. data/lib/rubocop/cop/lint/useless_assignment.rb +11 -15
  338. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +8 -13
  339. data/lib/rubocop/cop/lint/useless_method_definition.rb +69 -0
  340. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +119 -0
  341. data/lib/rubocop/cop/lint/useless_setter_call.rb +18 -13
  342. data/lib/rubocop/cop/lint/useless_times.rb +114 -0
  343. data/lib/rubocop/cop/lint/void.rb +16 -25
  344. data/lib/rubocop/cop/message_annotator.rb +5 -4
  345. data/lib/rubocop/cop/metrics/abc_size.rb +35 -3
  346. data/lib/rubocop/cop/metrics/block_length.rb +47 -11
  347. data/lib/rubocop/cop/metrics/block_nesting.rb +6 -11
  348. data/lib/rubocop/cop/metrics/class_length.rb +46 -12
  349. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +30 -7
  350. data/lib/rubocop/cop/metrics/method_length.rb +41 -6
  351. data/lib/rubocop/cop/metrics/module_length.rb +35 -10
  352. data/lib/rubocop/cop/metrics/parameter_lists.rb +79 -13
  353. data/lib/rubocop/cop/metrics/perceived_complexity.rb +8 -10
  354. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +76 -16
  355. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +182 -0
  356. data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
  357. data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +143 -0
  358. data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
  359. data/lib/rubocop/cop/migration/department_name.rb +39 -30
  360. data/lib/rubocop/cop/mixin/alignment.rb +18 -11
  361. data/lib/rubocop/cop/mixin/allowed_identifiers.rb +18 -0
  362. data/lib/rubocop/cop/mixin/allowed_methods.rb +40 -0
  363. data/lib/rubocop/cop/mixin/allowed_pattern.rb +56 -0
  364. data/lib/rubocop/cop/mixin/annotation_comment.rb +58 -23
  365. data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
  366. data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
  367. data/lib/rubocop/cop/mixin/check_line_breakable.rb +56 -19
  368. data/lib/rubocop/cop/mixin/code_length.rb +30 -9
  369. data/lib/rubocop/cop/mixin/comments_help.rb +80 -0
  370. data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +24 -14
  371. data/lib/rubocop/cop/mixin/configurable_formatting.rb +4 -11
  372. data/lib/rubocop/cop/mixin/configurable_max.rb +1 -0
  373. data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
  374. data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
  375. data/lib/rubocop/cop/mixin/def_node.rb +4 -11
  376. data/lib/rubocop/cop/mixin/documentation_comment.rb +9 -9
  377. data/lib/rubocop/cop/mixin/duplication.rb +1 -1
  378. data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +14 -14
  379. data/lib/rubocop/cop/mixin/empty_parameter.rb +2 -1
  380. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +17 -4
  381. data/lib/rubocop/cop/mixin/enforce_superclass.rb +22 -8
  382. data/lib/rubocop/cop/mixin/first_element_line_break.rb +14 -10
  383. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +41 -6
  384. data/lib/rubocop/cop/mixin/gem_declaration.rb +13 -0
  385. data/lib/rubocop/cop/mixin/gemspec_help.rb +30 -0
  386. data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +20 -11
  387. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +187 -0
  388. data/lib/rubocop/cop/mixin/hash_transform_method.rb +58 -38
  389. data/lib/rubocop/cop/mixin/heredoc.rb +5 -0
  390. data/lib/rubocop/cop/mixin/interpolation.rb +1 -3
  391. data/lib/rubocop/cop/mixin/line_length_help.rb +35 -15
  392. data/lib/rubocop/cop/mixin/match_range.rb +2 -5
  393. data/lib/rubocop/cop/mixin/method_complexity.rb +27 -10
  394. data/lib/rubocop/cop/mixin/method_preference.rb +1 -2
  395. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +39 -16
  396. data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +6 -4
  397. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +18 -46
  398. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +15 -15
  399. data/lib/rubocop/cop/mixin/negative_conditional.rb +6 -4
  400. data/lib/rubocop/cop/mixin/nil_methods.rb +3 -5
  401. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +16 -6
  402. data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
  403. data/lib/rubocop/cop/mixin/percent_array.rb +85 -12
  404. data/lib/rubocop/cop/mixin/percent_literal.rb +0 -6
  405. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +16 -14
  406. data/lib/rubocop/cop/mixin/preferred_delimiters.rb +6 -9
  407. data/lib/rubocop/cop/mixin/range_help.rb +55 -18
  408. data/lib/rubocop/cop/mixin/rational_literal.rb +1 -0
  409. data/lib/rubocop/cop/mixin/require_library.rb +61 -0
  410. data/lib/rubocop/cop/mixin/rescue_node.rb +15 -7
  411. data/lib/rubocop/cop/mixin/safe_assignment.rb +6 -2
  412. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +6 -7
  413. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +7 -7
  414. data/lib/rubocop/cop/mixin/statement_modifier.rb +59 -22
  415. data/lib/rubocop/cop/mixin/string_help.rb +5 -2
  416. data/lib/rubocop/cop/mixin/string_literals_help.rb +3 -5
  417. data/lib/rubocop/cop/mixin/surrounding_space.rb +28 -40
  418. data/lib/rubocop/cop/mixin/symbol_help.rb +13 -0
  419. data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
  420. data/lib/rubocop/cop/mixin/trailing_body.rb +2 -3
  421. data/lib/rubocop/cop/mixin/trailing_comma.rb +14 -19
  422. data/lib/rubocop/cop/mixin/uncommunicative_name.rb +25 -32
  423. data/lib/rubocop/cop/mixin/unused_argument.rb +5 -9
  424. data/lib/rubocop/cop/mixin/visibility_help.rb +72 -0
  425. data/lib/rubocop/cop/naming/accessor_method_name.rb +22 -4
  426. data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -11
  427. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +18 -8
  428. data/lib/rubocop/cop/naming/block_forwarding.rb +121 -0
  429. data/lib/rubocop/cop/naming/block_parameter_name.rb +4 -4
  430. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +16 -4
  431. data/lib/rubocop/cop/naming/constant_name.rb +9 -6
  432. data/lib/rubocop/cop/naming/file_name.rb +74 -39
  433. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +13 -7
  434. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +5 -5
  435. data/lib/rubocop/cop/naming/inclusive_language.rb +270 -0
  436. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +136 -27
  437. data/lib/rubocop/cop/naming/method_name.rb +35 -7
  438. data/lib/rubocop/cop/naming/method_parameter_name.rb +4 -4
  439. data/lib/rubocop/cop/naming/predicate_name.rb +42 -16
  440. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +67 -16
  441. data/lib/rubocop/cop/naming/variable_name.rb +13 -2
  442. data/lib/rubocop/cop/naming/variable_number.rb +107 -12
  443. data/lib/rubocop/cop/offense.rb +35 -12
  444. data/lib/rubocop/cop/registry.rb +128 -36
  445. data/lib/rubocop/cop/security/compound_hash.rb +106 -0
  446. data/lib/rubocop/cop/security/eval.rb +5 -3
  447. data/lib/rubocop/cop/security/io_methods.rb +49 -0
  448. data/lib/rubocop/cop/security/json_load.rb +17 -16
  449. data/lib/rubocop/cop/security/marshal_load.rb +5 -5
  450. data/lib/rubocop/cop/security/open.rb +29 -11
  451. data/lib/rubocop/cop/security/yaml_load.rb +22 -10
  452. data/lib/rubocop/cop/severity.rb +4 -14
  453. data/lib/rubocop/cop/style/access_modifier_declarations.rb +110 -12
  454. data/lib/rubocop/cop/style/accessor_grouping.rb +154 -0
  455. data/lib/rubocop/cop/style/alias.rb +55 -46
  456. data/lib/rubocop/cop/style/and_or.rb +42 -30
  457. data/lib/rubocop/cop/style/arguments_forwarding.rb +154 -0
  458. data/lib/rubocop/cop/style/array_coercion.rb +87 -0
  459. data/lib/rubocop/cop/style/array_intersect.rb +111 -0
  460. data/lib/rubocop/cop/style/array_join.rb +9 -9
  461. data/lib/rubocop/cop/style/ascii_comments.rb +7 -11
  462. data/lib/rubocop/cop/style/attr.rb +16 -16
  463. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +10 -13
  464. data/lib/rubocop/cop/style/bare_percent_literals.rb +13 -15
  465. data/lib/rubocop/cop/style/begin_block.rb +2 -2
  466. data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +60 -0
  467. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +125 -0
  468. data/lib/rubocop/cop/style/block_comments.rb +15 -19
  469. data/lib/rubocop/cop/style/block_delimiters.rb +105 -39
  470. data/lib/rubocop/cop/style/case_equality.rb +84 -6
  471. data/lib/rubocop/cop/style/case_like_if.rb +263 -0
  472. data/lib/rubocop/cop/style/character_literal.rb +20 -16
  473. data/lib/rubocop/cop/style/class_and_module_children.rb +71 -29
  474. data/lib/rubocop/cop/style/class_check.rb +7 -12
  475. data/lib/rubocop/cop/style/class_equality_comparison.rb +116 -0
  476. data/lib/rubocop/cop/style/class_methods.rb +9 -15
  477. data/lib/rubocop/cop/style/class_methods_definitions.rb +158 -0
  478. data/lib/rubocop/cop/style/class_vars.rb +24 -8
  479. data/lib/rubocop/cop/style/collection_compact.rb +120 -0
  480. data/lib/rubocop/cop/style/collection_methods.rb +34 -21
  481. data/lib/rubocop/cop/style/colon_method_call.rb +8 -10
  482. data/lib/rubocop/cop/style/colon_method_definition.rb +7 -7
  483. data/lib/rubocop/cop/style/combinable_loops.rb +95 -0
  484. data/lib/rubocop/cop/style/command_literal.rb +23 -29
  485. data/lib/rubocop/cop/style/comment_annotation.rb +69 -36
  486. data/lib/rubocop/cop/style/commented_keyword.rb +42 -23
  487. data/lib/rubocop/cop/style/concat_array_literals.rb +86 -0
  488. data/lib/rubocop/cop/style/conditional_assignment.rb +94 -95
  489. data/lib/rubocop/cop/style/constant_visibility.rb +32 -3
  490. data/lib/rubocop/cop/style/copyright.rb +21 -24
  491. data/lib/rubocop/cop/style/date_time.rb +22 -6
  492. data/lib/rubocop/cop/style/def_with_parentheses.rb +22 -20
  493. data/lib/rubocop/cop/style/dir.rb +15 -13
  494. data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +87 -0
  495. data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
  496. data/lib/rubocop/cop/style/documentation.rb +117 -22
  497. data/lib/rubocop/cop/style/documentation_method.rb +3 -2
  498. data/lib/rubocop/cop/style/double_cop_disable_directive.rb +7 -16
  499. data/lib/rubocop/cop/style/double_negation.rb +134 -10
  500. data/lib/rubocop/cop/style/each_for_simple_loop.rb +48 -16
  501. data/lib/rubocop/cop/style/each_with_object.rb +53 -24
  502. data/lib/rubocop/cop/style/empty_block_parameter.rb +11 -12
  503. data/lib/rubocop/cop/style/empty_case_condition.rb +32 -27
  504. data/lib/rubocop/cop/style/empty_else.rb +54 -25
  505. data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
  506. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +11 -12
  507. data/lib/rubocop/cop/style/empty_literal.rb +48 -33
  508. data/lib/rubocop/cop/style/empty_method.rb +29 -25
  509. data/lib/rubocop/cop/style/encoding.rb +30 -23
  510. data/lib/rubocop/cop/style/end_block.rb +8 -5
  511. data/lib/rubocop/cop/style/endless_method.rb +101 -0
  512. data/lib/rubocop/cop/style/env_home.rb +56 -0
  513. data/lib/rubocop/cop/style/eval_with_location.rb +143 -54
  514. data/lib/rubocop/cop/style/even_odd.rb +10 -12
  515. data/lib/rubocop/cop/style/expand_path_arguments.rb +28 -26
  516. data/lib/rubocop/cop/style/explicit_block_argument.rb +153 -0
  517. data/lib/rubocop/cop/style/exponential_notation.rb +116 -0
  518. data/lib/rubocop/cop/style/fetch_env_var.rb +132 -0
  519. data/lib/rubocop/cop/style/file_read.rb +112 -0
  520. data/lib/rubocop/cop/style/file_write.rb +136 -0
  521. data/lib/rubocop/cop/style/float_division.rb +69 -12
  522. data/lib/rubocop/cop/style/for.rb +13 -13
  523. data/lib/rubocop/cop/style/format_string.rb +31 -25
  524. data/lib/rubocop/cop/style/format_string_token.rb +138 -31
  525. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +35 -54
  526. data/lib/rubocop/cop/style/global_std_stream.rb +70 -0
  527. data/lib/rubocop/cop/style/global_vars.rb +3 -3
  528. data/lib/rubocop/cop/style/guard_clause.rb +186 -33
  529. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +100 -0
  530. data/lib/rubocop/cop/style/hash_conversion.rb +134 -0
  531. data/lib/rubocop/cop/style/hash_each_methods.rb +61 -16
  532. data/lib/rubocop/cop/style/hash_except.rb +177 -0
  533. data/lib/rubocop/cop/style/hash_like_case.rb +77 -0
  534. data/lib/rubocop/cop/style/hash_syntax.rb +106 -45
  535. data/lib/rubocop/cop/style/hash_transform_keys.rb +31 -15
  536. data/lib/rubocop/cop/style/hash_transform_values.rb +29 -15
  537. data/lib/rubocop/cop/style/identical_conditional_branches.rb +106 -11
  538. data/lib/rubocop/cop/style/if_inside_else.rb +65 -2
  539. data/lib/rubocop/cop/style/if_unless_modifier.rb +81 -51
  540. data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
  541. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +161 -0
  542. data/lib/rubocop/cop/style/if_with_semicolon.rb +51 -3
  543. data/lib/rubocop/cop/style/implicit_runtime_error.rb +6 -4
  544. data/lib/rubocop/cop/style/in_pattern_then.rb +56 -0
  545. data/lib/rubocop/cop/style/infinite_loop.rb +28 -26
  546. data/lib/rubocop/cop/style/inline_comment.rb +5 -5
  547. data/lib/rubocop/cop/style/inverse_methods.rb +55 -52
  548. data/lib/rubocop/cop/style/ip_addresses.rb +4 -5
  549. data/lib/rubocop/cop/style/keyword_parameters_order.rb +75 -0
  550. data/lib/rubocop/cop/style/lambda.rb +12 -18
  551. data/lib/rubocop/cop/style/lambda_call.rb +20 -45
  552. data/lib/rubocop/cop/style/line_end_concatenation.rb +40 -28
  553. data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
  554. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
  555. data/lib/rubocop/cop/style/map_to_hash.rb +68 -0
  556. data/lib/rubocop/cop/style/map_to_set.rb +61 -0
  557. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +91 -39
  558. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +12 -18
  559. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +76 -25
  560. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +39 -15
  561. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +17 -7
  562. data/lib/rubocop/cop/style/method_def_parentheses.rb +43 -29
  563. data/lib/rubocop/cop/style/min_max.rb +11 -15
  564. data/lib/rubocop/cop/style/min_max_comparison.rb +73 -0
  565. data/lib/rubocop/cop/style/missing_else.rb +44 -49
  566. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +12 -6
  567. data/lib/rubocop/cop/style/mixin_grouping.rb +29 -42
  568. data/lib/rubocop/cop/style/mixin_usage.rb +13 -31
  569. data/lib/rubocop/cop/style/module_function.rb +99 -33
  570. data/lib/rubocop/cop/style/multiline_block_chain.rb +17 -7
  571. data/lib/rubocop/cop/style/multiline_if_modifier.rb +6 -13
  572. data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
  573. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +60 -0
  574. data/lib/rubocop/cop/style/multiline_memoization.rb +16 -14
  575. data/lib/rubocop/cop/style/multiline_method_signature.rb +34 -4
  576. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +59 -12
  577. data/lib/rubocop/cop/style/multiline_when_then.rb +24 -19
  578. data/lib/rubocop/cop/style/multiple_comparison.rb +78 -13
  579. data/lib/rubocop/cop/style/mutable_constant.rb +117 -44
  580. data/lib/rubocop/cop/style/negated_if.rb +10 -11
  581. data/lib/rubocop/cop/style/negated_if_else_condition.rb +134 -0
  582. data/lib/rubocop/cop/style/negated_unless.rb +10 -11
  583. data/lib/rubocop/cop/style/negated_while.rb +7 -15
  584. data/lib/rubocop/cop/style/nested_file_dirname.rb +66 -0
  585. data/lib/rubocop/cop/style/nested_modifier.rb +11 -18
  586. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +33 -21
  587. data/lib/rubocop/cop/style/nested_ternary_operator.rb +43 -5
  588. data/lib/rubocop/cop/style/next.rb +20 -31
  589. data/lib/rubocop/cop/style/nil_comparison.rb +20 -12
  590. data/lib/rubocop/cop/style/nil_lambda.rb +70 -0
  591. data/lib/rubocop/cop/style/non_nil_check.rb +57 -35
  592. data/lib/rubocop/cop/style/not.rb +23 -29
  593. data/lib/rubocop/cop/style/numbered_parameters.rb +46 -0
  594. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +50 -0
  595. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +7 -12
  596. data/lib/rubocop/cop/style/numeric_literals.rb +44 -29
  597. data/lib/rubocop/cop/style/numeric_predicate.rb +72 -33
  598. data/lib/rubocop/cop/style/object_then.rb +74 -0
  599. data/lib/rubocop/cop/style/one_line_conditional.rb +56 -31
  600. data/lib/rubocop/cop/style/open_struct_use.rb +69 -0
  601. data/lib/rubocop/cop/style/operator_method_call.rb +53 -0
  602. data/lib/rubocop/cop/style/option_hash.rb +4 -5
  603. data/lib/rubocop/cop/style/optional_arguments.rb +9 -8
  604. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +64 -0
  605. data/lib/rubocop/cop/style/or_assignment.rb +12 -11
  606. data/lib/rubocop/cop/style/parallel_assignment.rb +28 -25
  607. data/lib/rubocop/cop/style/parentheses_around_condition.rb +20 -9
  608. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +17 -25
  609. data/lib/rubocop/cop/style/percent_q_literals.rb +12 -15
  610. data/lib/rubocop/cop/style/perl_backrefs.rb +106 -17
  611. data/lib/rubocop/cop/style/preferred_hash_methods.rb +21 -22
  612. data/lib/rubocop/cop/style/proc.rb +10 -7
  613. data/lib/rubocop/cop/style/quoted_symbols.rb +124 -0
  614. data/lib/rubocop/cop/style/raise_args.rb +49 -39
  615. data/lib/rubocop/cop/style/random_with_offset.rb +31 -36
  616. data/lib/rubocop/cop/style/redundant_argument.rb +98 -0
  617. data/lib/rubocop/cop/style/redundant_assignment.rb +106 -0
  618. data/lib/rubocop/cop/style/redundant_begin.rb +113 -12
  619. data/lib/rubocop/cop/style/redundant_capital_w.rb +9 -14
  620. data/lib/rubocop/cop/style/redundant_condition.rb +169 -26
  621. data/lib/rubocop/cop/style/redundant_conditional.rb +15 -16
  622. data/lib/rubocop/cop/style/redundant_constant_base.rb +85 -0
  623. data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +39 -0
  624. data/lib/rubocop/cop/style/redundant_each.rb +116 -0
  625. data/lib/rubocop/cop/style/redundant_exception.rb +23 -18
  626. data/lib/rubocop/cop/style/redundant_fetch_block.rb +119 -0
  627. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +61 -0
  628. data/lib/rubocop/cop/style/redundant_freeze.rb +16 -14
  629. data/lib/rubocop/cop/style/redundant_initialize.rb +156 -0
  630. data/lib/rubocop/cop/style/redundant_interpolation.rb +70 -30
  631. data/lib/rubocop/cop/style/redundant_parentheses.rb +68 -57
  632. data/lib/rubocop/cop/style/redundant_percent_q.rb +17 -21
  633. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +120 -0
  634. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +127 -0
  635. data/lib/rubocop/cop/style/redundant_return.rb +37 -30
  636. data/lib/rubocop/cop/style/redundant_self.rb +60 -28
  637. data/lib/rubocop/cop/style/redundant_self_assignment.rb +118 -0
  638. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +83 -0
  639. data/lib/rubocop/cop/style/redundant_sort.rb +84 -41
  640. data/lib/rubocop/cop/style/redundant_sort_by.rb +27 -14
  641. data/lib/rubocop/cop/style/redundant_string_escape.rb +184 -0
  642. data/lib/rubocop/cop/style/regexp_literal.rb +26 -32
  643. data/lib/rubocop/cop/style/require_order.rb +142 -0
  644. data/lib/rubocop/cop/style/rescue_modifier.rb +41 -14
  645. data/lib/rubocop/cop/style/rescue_standard_error.rb +36 -34
  646. data/lib/rubocop/cop/style/return_nil.rb +15 -9
  647. data/lib/rubocop/cop/style/safe_navigation.rb +107 -56
  648. data/lib/rubocop/cop/style/sample.rb +18 -17
  649. data/lib/rubocop/cop/style/select_by_regexp.rb +152 -0
  650. data/lib/rubocop/cop/style/self_assignment.rb +27 -23
  651. data/lib/rubocop/cop/style/semicolon.rb +65 -32
  652. data/lib/rubocop/cop/style/send.rb +6 -8
  653. data/lib/rubocop/cop/style/signal_exception.rb +39 -32
  654. data/lib/rubocop/cop/style/single_argument_dig.rb +65 -0
  655. data/lib/rubocop/cop/style/single_line_block_params.rb +39 -15
  656. data/lib/rubocop/cop/style/single_line_methods.rb +82 -20
  657. data/lib/rubocop/cop/style/slicing_with_range.rb +51 -0
  658. data/lib/rubocop/cop/style/sole_nested_conditional.rb +248 -0
  659. data/lib/rubocop/cop/style/special_global_vars.rb +107 -57
  660. data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +18 -25
  661. data/lib/rubocop/cop/style/static_class.rb +128 -0
  662. data/lib/rubocop/cop/style/stderr_puts.rb +10 -14
  663. data/lib/rubocop/cop/style/string_chars.rb +41 -0
  664. data/lib/rubocop/cop/style/string_concatenation.rb +178 -0
  665. data/lib/rubocop/cop/style/string_hash_keys.rb +13 -8
  666. data/lib/rubocop/cop/style/string_literals.rb +20 -20
  667. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +6 -4
  668. data/lib/rubocop/cop/style/string_methods.rb +8 -18
  669. data/lib/rubocop/cop/style/strip.rb +11 -15
  670. data/lib/rubocop/cop/style/struct_inheritance.rb +38 -5
  671. data/lib/rubocop/cop/style/swap_values.rb +112 -0
  672. data/lib/rubocop/cop/style/symbol_array.rb +20 -26
  673. data/lib/rubocop/cop/style/symbol_literal.rb +6 -10
  674. data/lib/rubocop/cop/style/symbol_proc.rb +135 -35
  675. data/lib/rubocop/cop/style/ternary_parentheses.rb +47 -51
  676. data/lib/rubocop/cop/style/top_level_method_definition.rb +85 -0
  677. data/lib/rubocop/cop/style/trailing_body_on_class.rb +4 -7
  678. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +11 -10
  679. data/lib/rubocop/cop/style/trailing_body_on_module.rb +4 -7
  680. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +42 -10
  681. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +44 -6
  682. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +105 -0
  683. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +47 -6
  684. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +10 -39
  685. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +17 -32
  686. data/lib/rubocop/cop/style/trivial_accessors.rb +111 -48
  687. data/lib/rubocop/cop/style/unless_else.rb +10 -10
  688. data/lib/rubocop/cop/style/unless_logical_operators.rb +105 -0
  689. data/lib/rubocop/cop/style/unpack_first.rb +8 -11
  690. data/lib/rubocop/cop/style/variable_interpolation.rb +9 -12
  691. data/lib/rubocop/cop/style/when_then.rb +7 -7
  692. data/lib/rubocop/cop/style/while_until_do.rb +6 -16
  693. data/lib/rubocop/cop/style/while_until_modifier.rb +16 -24
  694. data/lib/rubocop/cop/style/word_array.rb +67 -26
  695. data/lib/rubocop/cop/style/yoda_condition.rb +41 -25
  696. data/lib/rubocop/cop/style/yoda_expression.rb +74 -0
  697. data/lib/rubocop/cop/style/zero_length_predicate.rb +56 -31
  698. data/lib/rubocop/cop/team.rb +147 -85
  699. data/lib/rubocop/cop/util.rb +97 -30
  700. data/lib/rubocop/cop/utils/format_string.rb +22 -9
  701. data/lib/rubocop/cop/variable_force/assignment.rb +3 -3
  702. data/lib/rubocop/cop/variable_force/branch.rb +19 -10
  703. data/lib/rubocop/cop/variable_force/reference.rb +1 -3
  704. data/lib/rubocop/cop/variable_force/scope.rb +6 -9
  705. data/lib/rubocop/cop/variable_force/variable.rb +9 -12
  706. data/lib/rubocop/cop/variable_force/variable_table.rb +2 -2
  707. data/lib/rubocop/cop/variable_force.rb +28 -59
  708. data/lib/rubocop/cops_documentation_generator.rb +322 -0
  709. data/lib/rubocop/core_ext/string.rb +2 -2
  710. data/lib/rubocop/directive_comment.rb +144 -0
  711. data/lib/rubocop/error.rb +1 -0
  712. data/lib/rubocop/ext/processed_source.rb +20 -0
  713. data/lib/rubocop/ext/range.rb +15 -0
  714. data/lib/rubocop/ext/regexp_node.rb +87 -0
  715. data/lib/rubocop/ext/regexp_parser.rb +92 -0
  716. data/lib/rubocop/feature_loader.rb +94 -0
  717. data/lib/rubocop/file_finder.rb +12 -13
  718. data/lib/rubocop/file_patterns.rb +43 -0
  719. data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
  720. data/lib/rubocop/formatter/base_formatter.rb +0 -4
  721. data/lib/rubocop/formatter/clang_style_formatter.rb +6 -4
  722. data/lib/rubocop/formatter/disabled_config_formatter.rb +82 -39
  723. data/lib/rubocop/formatter/emacs_style_formatter.rb +2 -0
  724. data/lib/rubocop/formatter/formatter_set.rb +24 -23
  725. data/lib/rubocop/formatter/git_hub_actions_formatter.rb +57 -0
  726. data/lib/rubocop/formatter/html_formatter.rb +17 -26
  727. data/lib/rubocop/formatter/json_formatter.rb +5 -6
  728. data/lib/rubocop/formatter/junit_formatter.rb +45 -15
  729. data/lib/rubocop/formatter/markdown_formatter.rb +78 -0
  730. data/lib/rubocop/formatter/offense_count_formatter.rb +17 -8
  731. data/lib/rubocop/formatter/pacman_formatter.rb +1 -1
  732. data/lib/rubocop/formatter/progress_formatter.rb +3 -4
  733. data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
  734. data/lib/rubocop/formatter/simple_text_formatter.rb +42 -8
  735. data/lib/rubocop/formatter/tap_formatter.rb +8 -4
  736. data/lib/rubocop/formatter/worst_offenders_formatter.rb +8 -6
  737. data/lib/rubocop/formatter.rb +35 -0
  738. data/lib/rubocop/lockfile.rb +40 -0
  739. data/lib/rubocop/magic_comment.rb +101 -17
  740. data/lib/rubocop/name_similarity.rb +18 -10
  741. data/lib/rubocop/options.rb +335 -188
  742. data/lib/rubocop/path_util.rb +58 -37
  743. data/lib/rubocop/platform.rb +1 -1
  744. data/lib/rubocop/rake_task.rb +43 -17
  745. data/lib/rubocop/remote_config.rb +17 -15
  746. data/lib/rubocop/result_cache.rb +74 -44
  747. data/lib/rubocop/rspec/cop_helper.rb +36 -37
  748. data/lib/rubocop/rspec/expect_offense.rb +134 -41
  749. data/lib/rubocop/rspec/parallel_formatter.rb +90 -0
  750. data/lib/rubocop/rspec/shared_contexts.rb +115 -36
  751. data/lib/rubocop/rspec/support.rb +16 -1
  752. data/lib/rubocop/runner.rb +172 -91
  753. data/lib/rubocop/server/cache.rb +148 -0
  754. data/lib/rubocop/server/cli.rb +128 -0
  755. data/lib/rubocop/server/client_command/base.rb +44 -0
  756. data/lib/rubocop/server/client_command/exec.rb +64 -0
  757. data/lib/rubocop/server/client_command/restart.rb +25 -0
  758. data/lib/rubocop/server/client_command/start.rb +43 -0
  759. data/lib/rubocop/server/client_command/status.rb +28 -0
  760. data/lib/rubocop/server/client_command/stop.rb +31 -0
  761. data/lib/rubocop/server/client_command.rb +26 -0
  762. data/lib/rubocop/server/core.rb +96 -0
  763. data/lib/rubocop/server/errors.rb +23 -0
  764. data/lib/rubocop/server/helper.rb +34 -0
  765. data/lib/rubocop/server/server_command/base.rb +50 -0
  766. data/lib/rubocop/server/server_command/exec.rb +34 -0
  767. data/lib/rubocop/server/server_command/stop.rb +24 -0
  768. data/lib/rubocop/server/server_command.rb +21 -0
  769. data/lib/rubocop/server/socket_reader.rb +69 -0
  770. data/lib/rubocop/server.rb +53 -0
  771. data/lib/rubocop/string_interpreter.rb +7 -4
  772. data/lib/rubocop/target_finder.rb +58 -48
  773. data/lib/rubocop/target_ruby.rb +135 -15
  774. data/lib/rubocop/util.rb +16 -0
  775. data/lib/rubocop/version.rb +84 -7
  776. data/lib/rubocop/yaml_duplication_checker.rb +2 -1
  777. data/lib/rubocop.rb +213 -103
  778. metadata +307 -91
  779. data/bin/console +0 -10
  780. data/bin/setup +0 -7
  781. data/lib/rubocop/ast/builder.rb +0 -83
  782. data/lib/rubocop/ast/node/alias_node.rb +0 -24
  783. data/lib/rubocop/ast/node/and_node.rb +0 -29
  784. data/lib/rubocop/ast/node/args_node.rb +0 -29
  785. data/lib/rubocop/ast/node/array_node.rb +0 -57
  786. data/lib/rubocop/ast/node/block_node.rb +0 -117
  787. data/lib/rubocop/ast/node/break_node.rb +0 -17
  788. data/lib/rubocop/ast/node/case_node.rb +0 -56
  789. data/lib/rubocop/ast/node/class_node.rb +0 -31
  790. data/lib/rubocop/ast/node/def_node.rb +0 -82
  791. data/lib/rubocop/ast/node/defined_node.rb +0 -17
  792. data/lib/rubocop/ast/node/ensure_node.rb +0 -17
  793. data/lib/rubocop/ast/node/float_node.rb +0 -12
  794. data/lib/rubocop/ast/node/for_node.rb +0 -53
  795. data/lib/rubocop/ast/node/forward_args_node.rb +0 -18
  796. data/lib/rubocop/ast/node/hash_node.rb +0 -109
  797. data/lib/rubocop/ast/node/if_node.rb +0 -175
  798. data/lib/rubocop/ast/node/int_node.rb +0 -12
  799. data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
  800. data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
  801. data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
  802. data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
  803. data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
  804. data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
  805. data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -261
  806. data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
  807. data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
  808. data/lib/rubocop/ast/node/mixin/numeric_node.rb +0 -21
  809. data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
  810. data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
  811. data/lib/rubocop/ast/node/module_node.rb +0 -24
  812. data/lib/rubocop/ast/node/or_node.rb +0 -29
  813. data/lib/rubocop/ast/node/pair_node.rb +0 -63
  814. data/lib/rubocop/ast/node/range_node.rb +0 -18
  815. data/lib/rubocop/ast/node/regexp_node.rb +0 -33
  816. data/lib/rubocop/ast/node/resbody_node.rb +0 -24
  817. data/lib/rubocop/ast/node/retry_node.rb +0 -17
  818. data/lib/rubocop/ast/node/return_node.rb +0 -24
  819. data/lib/rubocop/ast/node/self_class_node.rb +0 -24
  820. data/lib/rubocop/ast/node/send_node.rb +0 -13
  821. data/lib/rubocop/ast/node/str_node.rb +0 -16
  822. data/lib/rubocop/ast/node/super_node.rb +0 -21
  823. data/lib/rubocop/ast/node/symbol_node.rb +0 -12
  824. data/lib/rubocop/ast/node/until_node.rb +0 -35
  825. data/lib/rubocop/ast/node/when_node.rb +0 -53
  826. data/lib/rubocop/ast/node/while_node.rb +0 -35
  827. data/lib/rubocop/ast/node/yield_node.rb +0 -21
  828. data/lib/rubocop/ast/node.rb +0 -632
  829. data/lib/rubocop/ast/sexp.rb +0 -16
  830. data/lib/rubocop/ast/traversal.rb +0 -200
  831. data/lib/rubocop/cli/command/auto_genenerate_config.rb +0 -105
  832. data/lib/rubocop/cop/layout/tab.rb +0 -75
  833. data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
  834. data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
  835. data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
  836. data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -19
  837. data/lib/rubocop/cop/mixin/ignored_pattern.rb +0 -29
  838. data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
  839. data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
  840. data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
  841. data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
  842. data/lib/rubocop/node_pattern.rb +0 -887
  843. data/lib/rubocop/processed_source.rb +0 -216
  844. data/lib/rubocop/string_util.rb +0 -14
  845. data/lib/rubocop/token.rb +0 -114
@@ -1,109 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # A node extension for `hash` nodes. This will be used in place of a plain
6
- # node when the builder constructs the AST, making its methods available
7
- # to all `hash` nodes within RuboCop.
8
- class HashNode < Node
9
- # Returns an array of all the key value pairs in the `hash` literal.
10
- #
11
- # @return [Array<PairNode>] an array of `pair` nodes
12
- def pairs
13
- each_pair.to_a
14
- end
15
-
16
- # Checks whether the `hash` node contains any `pair`- or `kwsplat` nodes.
17
- #
18
- # @return[Boolean] whether the `hash` is empty
19
- def empty?
20
- children.empty?
21
- end
22
-
23
- # Calls the given block for each `pair` node in the `hash` literal.
24
- # If no block is given, an `Enumerator` is returned.
25
- #
26
- # @return [self] if a block is given
27
- # @return [Enumerator] if no block is given
28
- def each_pair
29
- return each_child_node(:pair).to_enum unless block_given?
30
-
31
- each_child_node(:pair) do |pair|
32
- yield(*pair)
33
- end
34
-
35
- self
36
- end
37
-
38
- # Returns an array of all the keys in the `hash` literal.
39
- #
40
- # @return [Array<Node>] an array of keys in the `hash` literal
41
- def keys
42
- each_key.to_a
43
- end
44
-
45
- # Calls the given block for each `key` node in the `hash` literal.
46
- # If no block is given, an `Enumerator` is returned.
47
- #
48
- # @return [self] if a block is given
49
- # @return [Enumerator] if no block is given
50
- def each_key
51
- return pairs.map(&:key).to_enum unless block_given?
52
-
53
- pairs.map(&:key).each do |key|
54
- yield key
55
- end
56
-
57
- self
58
- end
59
-
60
- # Returns an array of all the values in the `hash` literal.
61
- #
62
- # @return [Array<Node>] an array of values in the `hash` literal
63
- def values
64
- each_pair.map(&:value)
65
- end
66
-
67
- # Calls the given block for each `value` node in the `hash` literal.
68
- # If no block is given, an `Enumerator` is returned.
69
- #
70
- # @return [self] if a block is given
71
- # @return [Enumerator] if no block is given
72
- def each_value
73
- return pairs.map(&:value).to_enum unless block_given?
74
-
75
- pairs.map(&:value).each do |value|
76
- yield value
77
- end
78
-
79
- self
80
- end
81
-
82
- # Checks whether any of the key value pairs in the `hash` literal are on
83
- # the same line.
84
- #
85
- # @note A multiline `pair` is considered to be on the same line if it
86
- # shares any of its lines with another `pair`
87
- #
88
- # @return [Boolean] whether any `pair` nodes are on the same line
89
- def pairs_on_same_line?
90
- pairs.each_cons(2).any? { |first, second| first.same_line?(second) }
91
- end
92
-
93
- # Checks whether this `hash` uses a mix of hash rocket and colon
94
- # delimiters for its pairs.
95
- #
96
- # @return [Boolean] whether the `hash` uses mixed delimiters
97
- def mixed_delimiters?
98
- pairs.map(&:delimiter).uniq.size > 1
99
- end
100
-
101
- # Checks whether the `hash` literal is delimited by curly braces.
102
- #
103
- # @return [Boolean] whether the `hash` literal is enclosed in braces
104
- def braces?
105
- loc.end&.is?('}')
106
- end
107
- end
108
- end
109
- end
@@ -1,175 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # A node extension for `if` nodes. This will be used in place of a plain
6
- # node when the builder constructs the AST, making its methods available
7
- # to all `if` nodes within RuboCop.
8
- class IfNode < Node
9
- include ConditionalNode
10
- include ModifierNode
11
-
12
- # Checks whether this node is an `if` statement. (This is not true of
13
- # ternary operators and `unless` statements.)
14
- #
15
- # @return [Boolean] whether the node is an `if` statement
16
- def if?
17
- keyword == 'if'
18
- end
19
-
20
- # Checks whether this node is an `unless` statement. (This is not true
21
- # of ternary operators and `if` statements.)
22
- #
23
- # @return [Boolean] whether the node is an `unless` statement
24
- def unless?
25
- keyword == 'unless'
26
- end
27
-
28
- # Checks whether the `if` is an `elsif`. Parser handles these by nesting
29
- # `if` nodes in the `else` branch.
30
- #
31
- # @return [Boolean] whether the node is an `elsif`
32
- def elsif?
33
- keyword == 'elsif'
34
- end
35
-
36
- # Checks whether the `if` node has an `else` clause.
37
- #
38
- # @note This returns `true` for nodes containing an `elsif` clause.
39
- # This is legacy behavior, and many cops rely on it.
40
- #
41
- # @return [Boolean] whether the node has an `else` clause
42
- def else?
43
- loc.respond_to?(:else) && loc.else
44
- end
45
-
46
- # Checks whether the `if` node is a ternary operator.
47
- #
48
- # @return [Boolean] whether the `if` node is a ternary operator
49
- def ternary?
50
- loc.respond_to?(:question)
51
- end
52
-
53
- # Returns the keyword of the `if` statement as a string. Returns an empty
54
- # string for ternary operators.
55
- #
56
- # @return [String] the keyword of the `if` statement
57
- def keyword
58
- ternary? ? '' : loc.keyword.source
59
- end
60
-
61
- # Returns the inverse keyword of the `if` node as a string. Returns `if`
62
- # for `unless` nodes and vice versa. Returns an empty string for ternary
63
- # operators.
64
- #
65
- # @return [String] the inverse keyword of the `if` statement
66
- def inverse_keyword
67
- if keyword == 'if'
68
- 'unless'
69
- elsif keyword == 'unless'
70
- 'if'
71
- else
72
- ''
73
- end
74
- end
75
-
76
- # Checks whether the `if` node is in a modifier form, i.e. a condition
77
- # trailing behind an expression. Only `if` and `unless` nodes without
78
- # other branches can be modifiers.
79
- #
80
- # @return [Boolean] whether the `if` node is a modifier
81
- def modifier_form?
82
- (if? || unless?) && super
83
- end
84
-
85
- # Chacks whether the `if` node has nested `if` nodes in any of its
86
- # branches.
87
- #
88
- # @note This performs a shallow search.
89
- #
90
- # @return [Boolean] whether the `if` node contains nested conditionals
91
- def nested_conditional?
92
- node_parts[1..2].compact.each do |branch|
93
- branch.each_node(:if) do |nested|
94
- return true unless nested.elsif?
95
- end
96
- end
97
-
98
- false
99
- end
100
-
101
- # Checks whether the `if` node has at least one `elsif` branch. Returns
102
- # true if this `if` node itself is an `elsif`.
103
- #
104
- # @return [Boolean] whether the `if` node has at least one `elsif` branch
105
- def elsif_conditional?
106
- else_branch&.if_type? && else_branch&.elsif?
107
- end
108
-
109
- # Returns the branch of the `if` node that gets evaluated when its
110
- # condition is truthy.
111
- #
112
- # @note This is normalized for `unless` nodes.
113
- #
114
- # @return [Node] the truthy branch node of the `if` node
115
- # @return [nil] if the truthy branch is empty
116
- def if_branch
117
- node_parts[1]
118
- end
119
-
120
- # Returns the branch of the `if` node that gets evaluated when its
121
- # condition is falsey.
122
- #
123
- # @note This is normalized for `unless` nodes.
124
- #
125
- # @return [Node] the falsey branch node of the `if` node
126
- # @return [nil] when there is no else branch
127
- def else_branch
128
- node_parts[2]
129
- end
130
-
131
- # Custom destructuring method. This is used to normalize the branches
132
- # for `if` and `unless` nodes, to aid comparisons and conversions.
133
- #
134
- # @return [Array<Node>] the different parts of the `if` statement
135
- def node_parts
136
- if unless?
137
- condition, false_branch, true_branch = *self
138
- else
139
- condition, true_branch, false_branch = *self
140
- end
141
-
142
- [condition, true_branch, false_branch]
143
- end
144
-
145
- # Returns an array of all the branches in the conditional statement.
146
- #
147
- # @return [Array<Node>] an array of branch nodes
148
- def branches
149
- branches = [if_branch]
150
-
151
- return branches unless else_branch
152
-
153
- other_branches = if elsif_conditional?
154
- else_branch.branches
155
- else
156
- [else_branch]
157
- end
158
- branches.concat(other_branches)
159
- end
160
-
161
- # Calls the given block for each branch node in the conditional statement.
162
- # If no block is given, an `Enumerator` is returned.
163
- #
164
- # @return [self] if a block is given
165
- # @return [Enumerator] if no block is given
166
- def each_branch
167
- return branches.to_enum(__method__) unless block_given?
168
-
169
- branches.each do |branch|
170
- yield branch
171
- end
172
- end
173
- end
174
- end
175
- end
@@ -1,12 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # A node extension for `int` nodes. This will be used in place of a plain
6
- # node when the builder constructs the AST, making its methods available to
7
- # all `int` nodes within RuboCop.
8
- class IntNode < Node
9
- include NumericNode
10
- end
11
- end
12
- end
@@ -1,45 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # A node extension for `kwsplat` nodes. This will be used in place of a
6
- # plain node when the builder constructs the AST, making its methods
7
- # available to all `kwsplat` nodes within RuboCop.
8
- class KeywordSplatNode < Node
9
- include HashElementNode
10
-
11
- DOUBLE_SPLAT = '**'
12
-
13
- # This is used for duck typing with `pair` nodes which also appear as
14
- # `hash` elements.
15
- #
16
- # @return [false]
17
- def hash_rocket?
18
- false
19
- end
20
-
21
- # This is used for duck typing with `pair` nodes which also appear as
22
- # `hash` elements.
23
- #
24
- # @return [false]
25
- def colon?
26
- false
27
- end
28
-
29
- # Returns the operator for the `kwsplat` as a string.
30
- #
31
- # @return [String] the double splat operator
32
- def operator
33
- DOUBLE_SPLAT
34
- end
35
-
36
- # Custom destructuring method. This is used to normalize the branches
37
- # for `pair` and `kwsplat` nodes, to add duck typing to `hash` elements.
38
- #
39
- # @return [Array<KeywordSplatNode>] the different parts of the `kwsplat`
40
- def node_parts
41
- [self, self]
42
- end
43
- end
44
- end
45
- end
@@ -1,16 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # Common functionality for primitive literal nodes: `sym`, `str`,
6
- # `int`, `float`, ...
7
- module BasicLiteralNode
8
- # Returns the value of the literal.
9
- #
10
- # @return [mixed] the value of the literal
11
- def value
12
- node_parts[0]
13
- end
14
- end
15
- end
16
- end
@@ -1,43 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # Common functionality for nodes that are binary operations:
6
- # `or`, `and` ...
7
- module BinaryOperatorNode
8
- # Returns the left hand side node of the binary operation.
9
- #
10
- # @return [Node] the left hand side of the binary operation
11
- def lhs
12
- node_parts[0]
13
- end
14
-
15
- # Returns the right hand side node of the binary operation.
16
- #
17
- # @return [Node] the right hand side of the binary operation
18
- def rhs
19
- node_parts[1]
20
- end
21
-
22
- # Returns all of the conditions, including nested conditions,
23
- # of the binary operation.
24
- #
25
- # @return [Array<Node>] the left and right hand side of the binary
26
- # operation and the let and right hand side of any nested binary
27
- # operators
28
- def conditions
29
- lhs, rhs = *self
30
- lhs = lhs.children.first if lhs.begin_type?
31
- rhs = rhs.children.first if rhs.begin_type?
32
-
33
- [lhs, rhs].each_with_object([]) do |side, collection|
34
- if side.operator_keyword?
35
- collection.concat(side.conditions)
36
- else
37
- collection << side
38
- end
39
- end
40
- end
41
- end
42
- end
43
- end
@@ -1,15 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # A mixin that helps give collection nodes array polymorphism.
6
- module CollectionNode
7
- extend Forwardable
8
-
9
- ARRAY_METHODS =
10
- (Array.instance_methods - Object.instance_methods - [:to_a]).freeze
11
-
12
- def_delegators :to_a, *ARRAY_METHODS
13
- end
14
- end
15
- end
@@ -1,45 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # Common functionality for nodes that have conditions:
6
- # `if`, `while`, `until`, `case`.
7
- # This currently doesn't include `when` nodes, because they have multiple
8
- # conditions, and need to be checked for that.
9
- module ConditionalNode
10
- # Checks whether the condition of the node is written on a single line.
11
- #
12
- # @return [Boolean] whether the condition is on a single line
13
- def single_line_condition?
14
- loc.keyword.line == condition.source_range.line
15
- end
16
-
17
- # Checks whether the condition of the node is written on more than
18
- # one line.
19
- #
20
- # @return [Boolean] whether the condition is on more than one line
21
- def multiline_condition?
22
- !single_line_condition?
23
- end
24
-
25
- # Returns the condition of the node. This works together with each node's
26
- # custom destructuring method to select the correct part of the node.
27
- #
28
- # @return [Node, nil] the condition of the node
29
- def condition
30
- node_parts[0]
31
- end
32
-
33
- # Returns the body associated with the condition. This works together with
34
- # each node's custom destructuring method to select the correct part of
35
- # the node.
36
- #
37
- # @note For `if` nodes, this is the truthy branch.
38
- #
39
- # @return [Node, nil] the body of the node
40
- def body
41
- node_parts[1]
42
- end
43
- end
44
- end
45
- end
@@ -1,125 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # Common functionality for nodes that can be used as hash elements:
6
- # `pair`, `kwsplat`
7
- module HashElementNode
8
- # Returns the key of this `hash` element.
9
- #
10
- # @note For keyword splats, this returns the whole node
11
- #
12
- # @return [Node] the key of the hash element
13
- def key
14
- node_parts[0]
15
- end
16
-
17
- # Returns the value of this `hash` element.
18
- #
19
- # @note For keyword splats, this returns the whole node
20
- #
21
- # @return [Node] the value of the hash element
22
- def value
23
- node_parts[1]
24
- end
25
-
26
- # Checks whether this `hash` element is on the same line as `other`.
27
- #
28
- # @note A multiline element is considered to be on the same line if it
29
- # shares any of its lines with `other`
30
- #
31
- # @return [Boolean] whether this element is on the same line as `other`
32
- def same_line?(other)
33
- loc.last_line == other.loc.line || loc.line == other.loc.last_line
34
- end
35
-
36
- # Returns the delta between this pair's key and the argument pair's.
37
- #
38
- # @note Keys on the same line always return a delta of 0
39
- # @note Keyword splats always return a delta of 0 for right alignment
40
- #
41
- # @param [Symbol] alignment whether to check the left or right side
42
- # @return [Integer] the delta between the two keys
43
- def key_delta(other, alignment = :left)
44
- HashElementDelta.new(self, other).key_delta(alignment)
45
- end
46
-
47
- # Returns the delta between this element's value and the argument's.
48
- #
49
- # @note Keyword splats always return a delta of 0
50
- #
51
- # @return [Integer] the delta between the two values
52
- def value_delta(other)
53
- HashElementDelta.new(self, other).value_delta
54
- end
55
-
56
- # Returns the delta between this element's delimiter and the argument's.
57
- #
58
- # @note Pairs with different delimiter styles return a delta of 0
59
- #
60
- # @return [Integer] the delta between the two delimiters
61
- def delimiter_delta(other)
62
- HashElementDelta.new(self, other).delimiter_delta
63
- end
64
-
65
- # A helper class for comparing the positions of different parts of a
66
- # `pair` node.
67
- class HashElementDelta
68
- def initialize(first, second)
69
- @first = first
70
- @second = second
71
-
72
- raise ArgumentError unless valid_argument_types?
73
- end
74
-
75
- def key_delta(alignment = :left)
76
- return 0 if first.same_line?(second)
77
- return 0 if keyword_splat? && alignment == :right
78
-
79
- delta(first.key.loc, second.key.loc, alignment)
80
- end
81
-
82
- def value_delta
83
- return 0 if first.same_line?(second)
84
- return 0 if keyword_splat?
85
-
86
- delta(first.value.loc, second.value.loc)
87
- end
88
-
89
- def delimiter_delta
90
- return 0 if first.same_line?(second)
91
- return 0 if first.delimiter != second.delimiter
92
-
93
- delta(first.loc.operator, second.loc.operator)
94
- end
95
-
96
- private
97
-
98
- attr_reader :first, :second
99
-
100
- def valid_argument_types?
101
- [first, second].all? do |argument|
102
- argument.pair_type? || argument.kwsplat_type?
103
- end
104
- end
105
-
106
- def delta(first, second, alignment = :left)
107
- case alignment
108
- when :left
109
- first.column - second.column
110
- when :right
111
- first.last_column - second.last_column
112
- else
113
- 0
114
- end
115
- end
116
-
117
- def keyword_splat?
118
- [first, second].any?(&:kwsplat_type?)
119
- end
120
- end
121
-
122
- private_constant :HashElementDelta
123
- end
124
- end
125
- end