rubocop 0.80.0 → 1.42.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +71 -38
- data/assets/output.html.erb +1 -1
- data/config/default.yml +1682 -202
- data/config/obsoletion.yml +233 -0
- data/exe/rubocop +15 -9
- data/lib/rubocop/arguments_env.rb +17 -0
- data/lib/rubocop/arguments_file.rb +17 -0
- data/lib/rubocop/ast_aliases.rb +8 -0
- data/lib/rubocop/cache_config.rb +29 -0
- data/lib/rubocop/cached_data.rb +4 -4
- data/lib/rubocop/cli/command/auto_generate_config.rb +147 -0
- data/lib/rubocop/cli/command/base.rb +2 -0
- data/lib/rubocop/cli/command/execute_runner.rb +38 -14
- data/lib/rubocop/cli/command/init_dotfile.rb +4 -5
- data/lib/rubocop/cli/command/show_cops.rb +6 -12
- data/lib/rubocop/cli/command/show_docs_url.rb +48 -0
- data/lib/rubocop/cli/command/suggest_extensions.rb +126 -0
- data/lib/rubocop/cli/command/version.rb +3 -2
- data/lib/rubocop/cli/command.rb +1 -0
- data/lib/rubocop/cli/environment.rb +1 -0
- data/lib/rubocop/cli.rb +41 -14
- data/lib/rubocop/comment_config.rb +90 -99
- data/lib/rubocop/config.rb +117 -42
- data/lib/rubocop/config_finder.rb +68 -0
- data/lib/rubocop/config_loader.rb +122 -133
- data/lib/rubocop/config_loader_resolver.rb +125 -39
- data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
- data/lib/rubocop/config_obsoletion/changed_parameter.rb +26 -0
- data/lib/rubocop/config_obsoletion/cop_rule.rb +33 -0
- data/lib/rubocop/config_obsoletion/extracted_cop.rb +46 -0
- data/lib/rubocop/config_obsoletion/parameter_rule.rb +48 -0
- data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
- data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
- data/lib/rubocop/config_obsoletion/rule.rb +41 -0
- data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
- data/lib/rubocop/config_obsoletion.rb +72 -240
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +31 -7
- data/lib/rubocop/config_validator.rb +95 -29
- data/lib/rubocop/cop/autocorrect_logic.rb +45 -40
- data/lib/rubocop/cop/badge.rb +27 -32
- data/lib/rubocop/cop/base.rb +464 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +34 -14
- data/lib/rubocop/cop/bundler/gem_comment.rb +117 -10
- data/lib/rubocop/cop/bundler/gem_filename.rb +103 -0
- data/lib/rubocop/cop/bundler/gem_version.rb +133 -0
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +45 -28
- data/lib/rubocop/cop/bundler/ordered_gems.rb +7 -18
- data/lib/rubocop/cop/commissioner.rb +105 -74
- data/lib/rubocop/cop/cop.rb +84 -234
- data/lib/rubocop/cop/corrector.rb +77 -119
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +14 -24
- data/lib/rubocop/cop/correctors/condition_corrector.rb +4 -7
- data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +4 -6
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +10 -11
- data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +5 -4
- data/lib/rubocop/cop/correctors/if_then_corrector.rb +55 -0
- data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +7 -7
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +15 -12
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +56 -11
- data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +12 -13
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +64 -9
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +11 -22
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +9 -11
- data/lib/rubocop/cop/correctors/require_library_corrector.rb +23 -0
- data/lib/rubocop/cop/correctors/space_corrector.rb +2 -4
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +7 -9
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +16 -19
- data/lib/rubocop/cop/documentation.rb +39 -0
- data/lib/rubocop/cop/exclude_limit.rb +26 -0
- data/lib/rubocop/cop/force.rb +2 -1
- data/lib/rubocop/cop/gemspec/dependency_version.rb +154 -0
- data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +11 -26
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +7 -20
- data/lib/rubocop/cop/gemspec/require_mfa.rb +145 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +69 -27
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +7 -12
- data/lib/rubocop/cop/generator/configuration_injector.rb +4 -5
- data/lib/rubocop/cop/generator/require_file_injector.rb +4 -7
- data/lib/rubocop/cop/generator.rb +36 -41
- data/lib/rubocop/cop/ignored_node.rb +1 -3
- data/lib/rubocop/cop/internal_affairs/cop_description.rb +98 -0
- data/lib/rubocop/cop/internal_affairs/create_empty_file.rb +37 -0
- data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +68 -0
- data/lib/rubocop/cop/internal_affairs/example_description.rb +92 -0
- data/lib/rubocop/cop/internal_affairs/example_heredoc_delimiter.rb +111 -0
- data/lib/rubocop/cop/internal_affairs/inherit_deprecated_cop_class.rb +34 -0
- data/lib/rubocop/cop/internal_affairs/lambda_or_proc.rb +46 -0
- data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +60 -0
- data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +80 -0
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +8 -17
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +4 -4
- data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +147 -0
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +11 -14
- data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +12 -10
- data/lib/rubocop/cop/internal_affairs/redundant_context_config_parameter.rb +46 -0
- data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +62 -0
- data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +65 -0
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +13 -8
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +12 -9
- data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +47 -0
- data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
- data/lib/rubocop/cop/internal_affairs/style_detected_api_use.rb +148 -0
- data/lib/rubocop/cop/internal_affairs/undefined_config.rb +73 -0
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +6 -6
- data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
- data/lib/rubocop/cop/internal_affairs.rb +20 -1
- data/lib/rubocop/cop/layout/access_modifier_indentation.rb +12 -10
- data/lib/rubocop/cop/layout/argument_alignment.rb +84 -19
- data/lib/rubocop/cop/layout/array_alignment.rb +58 -13
- data/lib/rubocop/cop/layout/assignment_indentation.rb +10 -9
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +74 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +56 -60
- data/lib/rubocop/cop/layout/block_end_newline.rb +41 -13
- data/lib/rubocop/cop/layout/case_indentation.rb +88 -30
- data/lib/rubocop/cop/layout/class_structure.rb +90 -80
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +25 -31
- data/lib/rubocop/cop/layout/comment_indentation.rb +56 -29
- data/lib/rubocop/cop/layout/condition_position.rb +17 -9
- data/lib/rubocop/cop/layout/def_end_alignment.rb +10 -11
- data/lib/rubocop/cop/layout/dot_position.rb +65 -27
- data/lib/rubocop/cop/layout/else_alignment.rb +29 -7
- data/lib/rubocop/cop/layout/empty_comment.rb +30 -30
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +61 -37
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +13 -13
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +161 -40
- data/lib/rubocop/cop/layout/empty_lines.rb +10 -13
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +32 -38
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +14 -10
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +139 -0
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +3 -6
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +8 -9
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +12 -15
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +16 -19
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +3 -6
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +12 -15
- data/lib/rubocop/cop/layout/end_alignment.rb +26 -25
- data/lib/rubocop/cop/layout/end_of_line.rb +13 -13
- data/lib/rubocop/cop/layout/extra_spacing.rb +32 -47
- data/lib/rubocop/cop/layout/first_argument_indentation.rb +74 -41
- data/lib/rubocop/cop/layout/first_array_element_indentation.rb +38 -25
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +43 -11
- data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +84 -29
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +51 -8
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +66 -14
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +54 -8
- data/lib/rubocop/cop/layout/first_parameter_indentation.rb +11 -10
- data/lib/rubocop/cop/layout/hash_alignment.rb +85 -55
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +48 -32
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +33 -124
- data/lib/rubocop/cop/layout/indentation_consistency.rb +10 -7
- data/lib/rubocop/cop/layout/indentation_style.rb +115 -0
- data/lib/rubocop/cop/layout/indentation_width.rb +51 -26
- data/lib/rubocop/cop/layout/initial_indentation.rb +8 -12
- data/lib/rubocop/cop/layout/leading_comment_space.rb +15 -13
- data/lib/rubocop/cop/layout/leading_empty_lines.rb +7 -12
- data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +138 -0
- data/lib/rubocop/cop/layout/line_continuation_spacing.rb +136 -0
- data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +141 -0
- data/lib/rubocop/cop/layout/line_length.rb +62 -63
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +53 -8
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +41 -19
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +45 -39
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +53 -10
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +64 -14
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +52 -24
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +101 -0
- data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +28 -15
- data/lib/rubocop/cop/layout/parameter_alignment.rb +8 -7
- data/lib/rubocop/cop/layout/redundant_line_break.rb +139 -0
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +60 -40
- data/lib/rubocop/cop/layout/single_line_block_chain.rb +64 -0
- data/lib/rubocop/cop/layout/space_after_colon.rb +11 -9
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +7 -10
- data/lib/rubocop/cop/layout/space_after_not.rb +11 -12
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +47 -54
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +20 -23
- data/lib/rubocop/cop/layout/space_around_keyword.rb +54 -30
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
- data/lib/rubocop/cop/layout/space_around_operators.rb +61 -28
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +43 -25
- data/lib/rubocop/cop/layout/space_before_brackets.rb +73 -0
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +11 -12
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +13 -15
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +17 -21
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +50 -55
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +8 -15
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +63 -50
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +52 -44
- data/lib/rubocop/cop/layout/space_inside_parens.rb +92 -29
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +38 -9
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +9 -18
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +25 -32
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +13 -14
- data/lib/rubocop/cop/layout/trailing_empty_lines.rb +20 -25
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +73 -19
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +43 -0
- data/lib/rubocop/cop/legacy/corrector.rb +27 -0
- data/lib/rubocop/cop/lint/ambiguous_assignment.rb +54 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +44 -11
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +60 -12
- data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +111 -0
- data/lib/rubocop/cop/lint/ambiguous_range.rb +105 -0
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +44 -7
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +20 -8
- data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -10
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +68 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +30 -5
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +2 -2
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +100 -0
- data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +93 -0
- data/lib/rubocop/cop/lint/debugger.rb +76 -26
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +109 -52
- data/lib/rubocop/cop/lint/deprecated_constants.rb +88 -0
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +154 -0
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +32 -3
- data/lib/rubocop/cop/lint/duplicate_branch.rb +153 -0
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +4 -14
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/duplicate_hash_key.rb +3 -5
- data/lib/rubocop/cop/lint/duplicate_magic_comment.rb +73 -0
- data/lib/rubocop/cop/lint/duplicate_methods.rb +63 -34
- data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +96 -0
- data/lib/rubocop/cop/lint/duplicate_require.rb +56 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +5 -3
- data/lib/rubocop/cop/lint/else_layout.rb +37 -9
- data/lib/rubocop/cop/lint/empty_block.rb +94 -0
- data/lib/rubocop/cop/lint/empty_class.rb +95 -0
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +175 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +6 -8
- data/lib/rubocop/cop/lint/empty_expression.rb +3 -3
- data/lib/rubocop/cop/lint/empty_file.rb +48 -0
- data/lib/rubocop/cop/lint/empty_in_pattern.rb +64 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +5 -8
- data/lib/rubocop/cop/lint/empty_when.rb +34 -9
- data/lib/rubocop/cop/lint/ensure_return.rb +29 -16
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +28 -30
- data/lib/rubocop/cop/lint/flip_flop.rb +9 -3
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +3 -4
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +45 -10
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +47 -0
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +15 -17
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +8 -8
- data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +79 -0
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +15 -21
- data/lib/rubocop/cop/lint/inherit_exception.rb +32 -36
- data/lib/rubocop/cop/lint/interpolation_check.rb +28 -9
- data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +51 -0
- data/lib/rubocop/cop/lint/literal_as_condition.rb +43 -17
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +49 -16
- data/lib/rubocop/cop/lint/loop.rb +32 -9
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +51 -24
- data/lib/rubocop/cop/lint/missing_super.rb +101 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +36 -0
- data/lib/rubocop/cop/lint/multiple_comparison.rb +15 -15
- data/lib/rubocop/cop/lint/nested_method_definition.rb +71 -26
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +19 -7
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +26 -6
- data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
- data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +162 -0
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +112 -16
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +13 -10
- data/lib/rubocop/cop/lint/number_conversion.rb +137 -27
- data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +47 -0
- data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +40 -0
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +16 -20
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +132 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +42 -14
- data/lib/rubocop/cop/lint/percent_string_array.rb +18 -13
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -15
- data/lib/rubocop/cop/lint/raise_exception.rb +91 -0
- data/lib/rubocop/cop/lint/rand_one.rb +6 -5
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +180 -119
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +46 -32
- data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +62 -0
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +45 -15
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +91 -0
- data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +73 -36
- data/lib/rubocop/cop/lint/redundant_string_coercion.rb +9 -16
- data/lib/rubocop/cop/lint/redundant_with_index.rb +26 -28
- data/lib/rubocop/cop/lint/redundant_with_object.rb +25 -29
- data/lib/rubocop/cop/lint/refinement_import_methods.rb +51 -0
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +13 -5
- data/lib/rubocop/cop/lint/require_parentheses.rb +8 -8
- data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
- data/lib/rubocop/cop/lint/require_relative_self_path.rb +50 -0
- data/lib/rubocop/cop/lint/rescue_exception.rb +3 -4
- data/lib/rubocop/cop/lint/rescue_type.rb +10 -16
- data/lib/rubocop/cop/lint/return_in_void_context.rb +7 -22
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +48 -15
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +16 -18
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +13 -5
- data/lib/rubocop/cop/lint/script_permission.rb +11 -8
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +14 -21
- data/lib/rubocop/cop/lint/shadowed_argument.rb +10 -16
- data/lib/rubocop/cop/lint/shadowed_exception.rb +34 -41
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +56 -7
- data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
- data/lib/rubocop/cop/lint/suppressed_exception.rb +55 -18
- data/lib/rubocop/cop/lint/symbol_conversion.rb +179 -0
- data/lib/rubocop/cop/lint/syntax.rb +10 -30
- data/lib/rubocop/cop/lint/to_enum_arguments.rb +89 -0
- data/lib/rubocop/cop/lint/to_json.rb +22 -14
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +55 -0
- data/lib/rubocop/cop/lint/triple_quotes.rb +71 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +6 -8
- data/lib/rubocop/cop/lint/unexpected_block_arity.rb +90 -0
- data/lib/rubocop/cop/lint/unified_integer.rb +7 -8
- data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +204 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +6 -8
- data/lib/rubocop/cop/lint/unreachable_loop.rb +202 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +19 -12
- data/lib/rubocop/cop/lint/unused_method_argument.rb +48 -13
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +6 -3
- data/lib/rubocop/cop/lint/uri_regexp.rb +13 -48
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +45 -27
- data/lib/rubocop/cop/lint/useless_assignment.rb +11 -15
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +8 -13
- data/lib/rubocop/cop/lint/useless_method_definition.rb +69 -0
- data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +119 -0
- data/lib/rubocop/cop/lint/useless_setter_call.rb +18 -13
- data/lib/rubocop/cop/lint/useless_times.rb +114 -0
- data/lib/rubocop/cop/lint/void.rb +16 -25
- data/lib/rubocop/cop/message_annotator.rb +5 -4
- data/lib/rubocop/cop/metrics/abc_size.rb +35 -3
- data/lib/rubocop/cop/metrics/block_length.rb +47 -11
- data/lib/rubocop/cop/metrics/block_nesting.rb +6 -11
- data/lib/rubocop/cop/metrics/class_length.rb +46 -12
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +30 -7
- data/lib/rubocop/cop/metrics/method_length.rb +41 -6
- data/lib/rubocop/cop/metrics/module_length.rb +35 -10
- data/lib/rubocop/cop/metrics/parameter_lists.rb +79 -13
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +8 -10
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +76 -16
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +182 -0
- data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
- data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +143 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
- data/lib/rubocop/cop/migration/department_name.rb +39 -30
- data/lib/rubocop/cop/mixin/alignment.rb +18 -11
- data/lib/rubocop/cop/mixin/allowed_identifiers.rb +18 -0
- data/lib/rubocop/cop/mixin/allowed_methods.rb +40 -0
- data/lib/rubocop/cop/mixin/allowed_pattern.rb +56 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +58 -23
- data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +56 -19
- data/lib/rubocop/cop/mixin/code_length.rb +30 -9
- data/lib/rubocop/cop/mixin/comments_help.rb +80 -0
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +24 -14
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +4 -11
- data/lib/rubocop/cop/mixin/configurable_max.rb +1 -0
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
- data/lib/rubocop/cop/mixin/def_node.rb +4 -11
- data/lib/rubocop/cop/mixin/documentation_comment.rb +9 -9
- data/lib/rubocop/cop/mixin/duplication.rb +1 -1
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +14 -14
- data/lib/rubocop/cop/mixin/empty_parameter.rb +2 -1
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +17 -4
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +22 -8
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +14 -10
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +41 -6
- data/lib/rubocop/cop/mixin/gem_declaration.rb +13 -0
- data/lib/rubocop/cop/mixin/gemspec_help.rb +30 -0
- data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +20 -11
- data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +187 -0
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +58 -38
- data/lib/rubocop/cop/mixin/heredoc.rb +5 -0
- data/lib/rubocop/cop/mixin/interpolation.rb +1 -3
- data/lib/rubocop/cop/mixin/line_length_help.rb +35 -15
- data/lib/rubocop/cop/mixin/match_range.rb +2 -5
- data/lib/rubocop/cop/mixin/method_complexity.rb +27 -10
- data/lib/rubocop/cop/mixin/method_preference.rb +1 -2
- data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +39 -16
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +6 -4
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +18 -46
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +15 -15
- data/lib/rubocop/cop/mixin/negative_conditional.rb +6 -4
- data/lib/rubocop/cop/mixin/nil_methods.rb +3 -5
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +16 -6
- data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +85 -12
- data/lib/rubocop/cop/mixin/percent_literal.rb +0 -6
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +16 -14
- data/lib/rubocop/cop/mixin/preferred_delimiters.rb +6 -9
- data/lib/rubocop/cop/mixin/range_help.rb +55 -18
- data/lib/rubocop/cop/mixin/rational_literal.rb +1 -0
- data/lib/rubocop/cop/mixin/require_library.rb +61 -0
- data/lib/rubocop/cop/mixin/rescue_node.rb +15 -7
- data/lib/rubocop/cop/mixin/safe_assignment.rb +6 -2
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +6 -7
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +7 -7
- data/lib/rubocop/cop/mixin/statement_modifier.rb +59 -22
- data/lib/rubocop/cop/mixin/string_help.rb +5 -2
- data/lib/rubocop/cop/mixin/string_literals_help.rb +3 -5
- data/lib/rubocop/cop/mixin/surrounding_space.rb +28 -40
- data/lib/rubocop/cop/mixin/symbol_help.rb +13 -0
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
- data/lib/rubocop/cop/mixin/trailing_body.rb +2 -3
- data/lib/rubocop/cop/mixin/trailing_comma.rb +14 -19
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +25 -32
- data/lib/rubocop/cop/mixin/unused_argument.rb +5 -9
- data/lib/rubocop/cop/mixin/visibility_help.rb +72 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +22 -4
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -11
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +18 -8
- data/lib/rubocop/cop/naming/block_forwarding.rb +121 -0
- data/lib/rubocop/cop/naming/block_parameter_name.rb +4 -4
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +16 -4
- data/lib/rubocop/cop/naming/constant_name.rb +9 -6
- data/lib/rubocop/cop/naming/file_name.rb +74 -39
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +13 -7
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +5 -5
- data/lib/rubocop/cop/naming/inclusive_language.rb +270 -0
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +136 -27
- data/lib/rubocop/cop/naming/method_name.rb +35 -7
- data/lib/rubocop/cop/naming/method_parameter_name.rb +4 -4
- data/lib/rubocop/cop/naming/predicate_name.rb +42 -16
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +67 -16
- data/lib/rubocop/cop/naming/variable_name.rb +13 -2
- data/lib/rubocop/cop/naming/variable_number.rb +107 -12
- data/lib/rubocop/cop/offense.rb +35 -12
- data/lib/rubocop/cop/registry.rb +128 -36
- data/lib/rubocop/cop/security/compound_hash.rb +106 -0
- data/lib/rubocop/cop/security/eval.rb +5 -3
- data/lib/rubocop/cop/security/io_methods.rb +49 -0
- data/lib/rubocop/cop/security/json_load.rb +17 -16
- data/lib/rubocop/cop/security/marshal_load.rb +5 -5
- data/lib/rubocop/cop/security/open.rb +29 -11
- data/lib/rubocop/cop/security/yaml_load.rb +22 -10
- data/lib/rubocop/cop/severity.rb +4 -14
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +110 -12
- data/lib/rubocop/cop/style/accessor_grouping.rb +154 -0
- data/lib/rubocop/cop/style/alias.rb +55 -46
- data/lib/rubocop/cop/style/and_or.rb +42 -30
- data/lib/rubocop/cop/style/arguments_forwarding.rb +154 -0
- data/lib/rubocop/cop/style/array_coercion.rb +87 -0
- data/lib/rubocop/cop/style/array_intersect.rb +111 -0
- data/lib/rubocop/cop/style/array_join.rb +9 -9
- data/lib/rubocop/cop/style/ascii_comments.rb +7 -11
- data/lib/rubocop/cop/style/attr.rb +16 -16
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +10 -13
- data/lib/rubocop/cop/style/bare_percent_literals.rb +13 -15
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +60 -0
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +125 -0
- data/lib/rubocop/cop/style/block_comments.rb +15 -19
- data/lib/rubocop/cop/style/block_delimiters.rb +105 -39
- data/lib/rubocop/cop/style/case_equality.rb +84 -6
- data/lib/rubocop/cop/style/case_like_if.rb +263 -0
- data/lib/rubocop/cop/style/character_literal.rb +20 -16
- data/lib/rubocop/cop/style/class_and_module_children.rb +71 -29
- data/lib/rubocop/cop/style/class_check.rb +7 -12
- data/lib/rubocop/cop/style/class_equality_comparison.rb +116 -0
- data/lib/rubocop/cop/style/class_methods.rb +9 -15
- data/lib/rubocop/cop/style/class_methods_definitions.rb +158 -0
- data/lib/rubocop/cop/style/class_vars.rb +24 -8
- data/lib/rubocop/cop/style/collection_compact.rb +120 -0
- data/lib/rubocop/cop/style/collection_methods.rb +34 -21
- data/lib/rubocop/cop/style/colon_method_call.rb +8 -10
- data/lib/rubocop/cop/style/colon_method_definition.rb +7 -7
- data/lib/rubocop/cop/style/combinable_loops.rb +95 -0
- data/lib/rubocop/cop/style/command_literal.rb +23 -29
- data/lib/rubocop/cop/style/comment_annotation.rb +69 -36
- data/lib/rubocop/cop/style/commented_keyword.rb +42 -23
- data/lib/rubocop/cop/style/concat_array_literals.rb +86 -0
- data/lib/rubocop/cop/style/conditional_assignment.rb +94 -95
- data/lib/rubocop/cop/style/constant_visibility.rb +32 -3
- data/lib/rubocop/cop/style/copyright.rb +21 -24
- data/lib/rubocop/cop/style/date_time.rb +22 -6
- data/lib/rubocop/cop/style/def_with_parentheses.rb +22 -20
- data/lib/rubocop/cop/style/dir.rb +15 -13
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +87 -0
- data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
- data/lib/rubocop/cop/style/documentation.rb +117 -22
- data/lib/rubocop/cop/style/documentation_method.rb +3 -2
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +7 -16
- data/lib/rubocop/cop/style/double_negation.rb +134 -10
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +48 -16
- data/lib/rubocop/cop/style/each_with_object.rb +53 -24
- data/lib/rubocop/cop/style/empty_block_parameter.rb +11 -12
- data/lib/rubocop/cop/style/empty_case_condition.rb +32 -27
- data/lib/rubocop/cop/style/empty_else.rb +54 -25
- data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +11 -12
- data/lib/rubocop/cop/style/empty_literal.rb +48 -33
- data/lib/rubocop/cop/style/empty_method.rb +29 -25
- data/lib/rubocop/cop/style/encoding.rb +30 -23
- data/lib/rubocop/cop/style/end_block.rb +8 -5
- data/lib/rubocop/cop/style/endless_method.rb +101 -0
- data/lib/rubocop/cop/style/env_home.rb +56 -0
- data/lib/rubocop/cop/style/eval_with_location.rb +143 -54
- data/lib/rubocop/cop/style/even_odd.rb +10 -12
- data/lib/rubocop/cop/style/expand_path_arguments.rb +28 -26
- data/lib/rubocop/cop/style/explicit_block_argument.rb +153 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +116 -0
- data/lib/rubocop/cop/style/fetch_env_var.rb +132 -0
- data/lib/rubocop/cop/style/file_read.rb +112 -0
- data/lib/rubocop/cop/style/file_write.rb +136 -0
- data/lib/rubocop/cop/style/float_division.rb +69 -12
- data/lib/rubocop/cop/style/for.rb +13 -13
- data/lib/rubocop/cop/style/format_string.rb +31 -25
- data/lib/rubocop/cop/style/format_string_token.rb +138 -31
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +35 -54
- data/lib/rubocop/cop/style/global_std_stream.rb +70 -0
- data/lib/rubocop/cop/style/global_vars.rb +3 -3
- data/lib/rubocop/cop/style/guard_clause.rb +186 -33
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +100 -0
- data/lib/rubocop/cop/style/hash_conversion.rb +134 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +61 -16
- data/lib/rubocop/cop/style/hash_except.rb +177 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +77 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +106 -45
- data/lib/rubocop/cop/style/hash_transform_keys.rb +31 -15
- data/lib/rubocop/cop/style/hash_transform_values.rb +29 -15
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +106 -11
- data/lib/rubocop/cop/style/if_inside_else.rb +65 -2
- data/lib/rubocop/cop/style/if_unless_modifier.rb +81 -51
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
- data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +161 -0
- data/lib/rubocop/cop/style/if_with_semicolon.rb +51 -3
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +6 -4
- data/lib/rubocop/cop/style/in_pattern_then.rb +56 -0
- data/lib/rubocop/cop/style/infinite_loop.rb +28 -26
- data/lib/rubocop/cop/style/inline_comment.rb +5 -5
- data/lib/rubocop/cop/style/inverse_methods.rb +55 -52
- data/lib/rubocop/cop/style/ip_addresses.rb +4 -5
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +75 -0
- data/lib/rubocop/cop/style/lambda.rb +12 -18
- data/lib/rubocop/cop/style/lambda_call.rb +20 -45
- data/lib/rubocop/cop/style/line_end_concatenation.rb +40 -28
- data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
- data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
- data/lib/rubocop/cop/style/map_to_hash.rb +68 -0
- data/lib/rubocop/cop/style/map_to_set.rb +61 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +91 -39
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +12 -18
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +76 -25
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +39 -15
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +17 -7
- data/lib/rubocop/cop/style/method_def_parentheses.rb +43 -29
- data/lib/rubocop/cop/style/min_max.rb +11 -15
- data/lib/rubocop/cop/style/min_max_comparison.rb +73 -0
- data/lib/rubocop/cop/style/missing_else.rb +44 -49
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +12 -6
- data/lib/rubocop/cop/style/mixin_grouping.rb +29 -42
- data/lib/rubocop/cop/style/mixin_usage.rb +13 -31
- data/lib/rubocop/cop/style/module_function.rb +99 -33
- data/lib/rubocop/cop/style/multiline_block_chain.rb +17 -7
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +6 -13
- data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
- data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +60 -0
- data/lib/rubocop/cop/style/multiline_memoization.rb +16 -14
- data/lib/rubocop/cop/style/multiline_method_signature.rb +34 -4
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +59 -12
- data/lib/rubocop/cop/style/multiline_when_then.rb +24 -19
- data/lib/rubocop/cop/style/multiple_comparison.rb +78 -13
- data/lib/rubocop/cop/style/mutable_constant.rb +117 -44
- data/lib/rubocop/cop/style/negated_if.rb +10 -11
- data/lib/rubocop/cop/style/negated_if_else_condition.rb +134 -0
- data/lib/rubocop/cop/style/negated_unless.rb +10 -11
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_file_dirname.rb +66 -0
- data/lib/rubocop/cop/style/nested_modifier.rb +11 -18
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +33 -21
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +43 -5
- data/lib/rubocop/cop/style/next.rb +20 -31
- data/lib/rubocop/cop/style/nil_comparison.rb +20 -12
- data/lib/rubocop/cop/style/nil_lambda.rb +70 -0
- data/lib/rubocop/cop/style/non_nil_check.rb +57 -35
- data/lib/rubocop/cop/style/not.rb +23 -29
- data/lib/rubocop/cop/style/numbered_parameters.rb +46 -0
- data/lib/rubocop/cop/style/numbered_parameters_limit.rb +50 -0
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +7 -12
- data/lib/rubocop/cop/style/numeric_literals.rb +44 -29
- data/lib/rubocop/cop/style/numeric_predicate.rb +72 -33
- data/lib/rubocop/cop/style/object_then.rb +74 -0
- data/lib/rubocop/cop/style/one_line_conditional.rb +56 -31
- data/lib/rubocop/cop/style/open_struct_use.rb +69 -0
- data/lib/rubocop/cop/style/operator_method_call.rb +53 -0
- data/lib/rubocop/cop/style/option_hash.rb +4 -5
- data/lib/rubocop/cop/style/optional_arguments.rb +9 -8
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +64 -0
- data/lib/rubocop/cop/style/or_assignment.rb +12 -11
- data/lib/rubocop/cop/style/parallel_assignment.rb +28 -25
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +20 -9
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +17 -25
- data/lib/rubocop/cop/style/percent_q_literals.rb +12 -15
- data/lib/rubocop/cop/style/perl_backrefs.rb +106 -17
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +21 -22
- data/lib/rubocop/cop/style/proc.rb +10 -7
- data/lib/rubocop/cop/style/quoted_symbols.rb +124 -0
- data/lib/rubocop/cop/style/raise_args.rb +49 -39
- data/lib/rubocop/cop/style/random_with_offset.rb +31 -36
- data/lib/rubocop/cop/style/redundant_argument.rb +98 -0
- data/lib/rubocop/cop/style/redundant_assignment.rb +106 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +113 -12
- data/lib/rubocop/cop/style/redundant_capital_w.rb +9 -14
- data/lib/rubocop/cop/style/redundant_condition.rb +169 -26
- data/lib/rubocop/cop/style/redundant_conditional.rb +15 -16
- data/lib/rubocop/cop/style/redundant_constant_base.rb +85 -0
- data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +39 -0
- data/lib/rubocop/cop/style/redundant_each.rb +116 -0
- data/lib/rubocop/cop/style/redundant_exception.rb +23 -18
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +119 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +61 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +16 -14
- data/lib/rubocop/cop/style/redundant_initialize.rb +156 -0
- data/lib/rubocop/cop/style/redundant_interpolation.rb +70 -30
- data/lib/rubocop/cop/style/redundant_parentheses.rb +68 -57
- data/lib/rubocop/cop/style/redundant_percent_q.rb +17 -21
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +120 -0
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +127 -0
- data/lib/rubocop/cop/style/redundant_return.rb +37 -30
- data/lib/rubocop/cop/style/redundant_self.rb +60 -28
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +118 -0
- data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +83 -0
- data/lib/rubocop/cop/style/redundant_sort.rb +84 -41
- data/lib/rubocop/cop/style/redundant_sort_by.rb +27 -14
- data/lib/rubocop/cop/style/redundant_string_escape.rb +184 -0
- data/lib/rubocop/cop/style/regexp_literal.rb +26 -32
- data/lib/rubocop/cop/style/require_order.rb +142 -0
- data/lib/rubocop/cop/style/rescue_modifier.rb +41 -14
- data/lib/rubocop/cop/style/rescue_standard_error.rb +36 -34
- data/lib/rubocop/cop/style/return_nil.rb +15 -9
- data/lib/rubocop/cop/style/safe_navigation.rb +107 -56
- data/lib/rubocop/cop/style/sample.rb +18 -17
- data/lib/rubocop/cop/style/select_by_regexp.rb +152 -0
- data/lib/rubocop/cop/style/self_assignment.rb +27 -23
- data/lib/rubocop/cop/style/semicolon.rb +65 -32
- data/lib/rubocop/cop/style/send.rb +6 -8
- data/lib/rubocop/cop/style/signal_exception.rb +39 -32
- data/lib/rubocop/cop/style/single_argument_dig.rb +65 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +39 -15
- data/lib/rubocop/cop/style/single_line_methods.rb +82 -20
- data/lib/rubocop/cop/style/slicing_with_range.rb +51 -0
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +248 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +107 -57
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +18 -25
- data/lib/rubocop/cop/style/static_class.rb +128 -0
- data/lib/rubocop/cop/style/stderr_puts.rb +10 -14
- data/lib/rubocop/cop/style/string_chars.rb +41 -0
- data/lib/rubocop/cop/style/string_concatenation.rb +178 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +13 -8
- data/lib/rubocop/cop/style/string_literals.rb +20 -20
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +6 -4
- data/lib/rubocop/cop/style/string_methods.rb +8 -18
- data/lib/rubocop/cop/style/strip.rb +11 -15
- data/lib/rubocop/cop/style/struct_inheritance.rb +38 -5
- data/lib/rubocop/cop/style/swap_values.rb +112 -0
- data/lib/rubocop/cop/style/symbol_array.rb +20 -26
- data/lib/rubocop/cop/style/symbol_literal.rb +6 -10
- data/lib/rubocop/cop/style/symbol_proc.rb +135 -35
- data/lib/rubocop/cop/style/ternary_parentheses.rb +47 -51
- data/lib/rubocop/cop/style/top_level_method_definition.rb +85 -0
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +11 -10
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +4 -7
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +42 -10
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +44 -6
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +105 -0
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +47 -6
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +10 -39
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +17 -32
- data/lib/rubocop/cop/style/trivial_accessors.rb +111 -48
- data/lib/rubocop/cop/style/unless_else.rb +10 -10
- data/lib/rubocop/cop/style/unless_logical_operators.rb +105 -0
- data/lib/rubocop/cop/style/unpack_first.rb +8 -11
- data/lib/rubocop/cop/style/variable_interpolation.rb +9 -12
- data/lib/rubocop/cop/style/when_then.rb +7 -7
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +16 -24
- data/lib/rubocop/cop/style/word_array.rb +67 -26
- data/lib/rubocop/cop/style/yoda_condition.rb +41 -25
- data/lib/rubocop/cop/style/yoda_expression.rb +74 -0
- data/lib/rubocop/cop/style/zero_length_predicate.rb +56 -31
- data/lib/rubocop/cop/team.rb +147 -85
- data/lib/rubocop/cop/util.rb +97 -30
- data/lib/rubocop/cop/utils/format_string.rb +22 -9
- data/lib/rubocop/cop/variable_force/assignment.rb +3 -3
- data/lib/rubocop/cop/variable_force/branch.rb +19 -10
- data/lib/rubocop/cop/variable_force/reference.rb +1 -3
- data/lib/rubocop/cop/variable_force/scope.rb +6 -9
- data/lib/rubocop/cop/variable_force/variable.rb +9 -12
- data/lib/rubocop/cop/variable_force/variable_table.rb +2 -2
- data/lib/rubocop/cop/variable_force.rb +28 -59
- data/lib/rubocop/cops_documentation_generator.rb +322 -0
- data/lib/rubocop/core_ext/string.rb +2 -2
- data/lib/rubocop/directive_comment.rb +144 -0
- data/lib/rubocop/error.rb +1 -0
- data/lib/rubocop/ext/processed_source.rb +20 -0
- data/lib/rubocop/ext/range.rb +15 -0
- data/lib/rubocop/ext/regexp_node.rb +87 -0
- data/lib/rubocop/ext/regexp_parser.rb +92 -0
- data/lib/rubocop/feature_loader.rb +94 -0
- data/lib/rubocop/file_finder.rb +12 -13
- data/lib/rubocop/file_patterns.rb +43 -0
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/base_formatter.rb +0 -4
- data/lib/rubocop/formatter/clang_style_formatter.rb +6 -4
- data/lib/rubocop/formatter/disabled_config_formatter.rb +82 -39
- data/lib/rubocop/formatter/emacs_style_formatter.rb +2 -0
- data/lib/rubocop/formatter/formatter_set.rb +24 -23
- data/lib/rubocop/formatter/git_hub_actions_formatter.rb +57 -0
- data/lib/rubocop/formatter/html_formatter.rb +17 -26
- data/lib/rubocop/formatter/json_formatter.rb +5 -6
- data/lib/rubocop/formatter/junit_formatter.rb +45 -15
- data/lib/rubocop/formatter/markdown_formatter.rb +78 -0
- data/lib/rubocop/formatter/offense_count_formatter.rb +17 -8
- data/lib/rubocop/formatter/pacman_formatter.rb +1 -1
- data/lib/rubocop/formatter/progress_formatter.rb +3 -4
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +42 -8
- data/lib/rubocop/formatter/tap_formatter.rb +8 -4
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +8 -6
- data/lib/rubocop/formatter.rb +35 -0
- data/lib/rubocop/lockfile.rb +40 -0
- data/lib/rubocop/magic_comment.rb +101 -17
- data/lib/rubocop/name_similarity.rb +18 -10
- data/lib/rubocop/options.rb +335 -188
- data/lib/rubocop/path_util.rb +58 -37
- data/lib/rubocop/platform.rb +1 -1
- data/lib/rubocop/rake_task.rb +43 -17
- data/lib/rubocop/remote_config.rb +17 -15
- data/lib/rubocop/result_cache.rb +74 -44
- data/lib/rubocop/rspec/cop_helper.rb +36 -37
- data/lib/rubocop/rspec/expect_offense.rb +134 -41
- data/lib/rubocop/rspec/parallel_formatter.rb +90 -0
- data/lib/rubocop/rspec/shared_contexts.rb +115 -36
- data/lib/rubocop/rspec/support.rb +16 -1
- data/lib/rubocop/runner.rb +172 -91
- data/lib/rubocop/server/cache.rb +148 -0
- data/lib/rubocop/server/cli.rb +128 -0
- data/lib/rubocop/server/client_command/base.rb +44 -0
- data/lib/rubocop/server/client_command/exec.rb +64 -0
- data/lib/rubocop/server/client_command/restart.rb +25 -0
- data/lib/rubocop/server/client_command/start.rb +43 -0
- data/lib/rubocop/server/client_command/status.rb +28 -0
- data/lib/rubocop/server/client_command/stop.rb +31 -0
- data/lib/rubocop/server/client_command.rb +26 -0
- data/lib/rubocop/server/core.rb +96 -0
- data/lib/rubocop/server/errors.rb +23 -0
- data/lib/rubocop/server/helper.rb +34 -0
- data/lib/rubocop/server/server_command/base.rb +50 -0
- data/lib/rubocop/server/server_command/exec.rb +34 -0
- data/lib/rubocop/server/server_command/stop.rb +24 -0
- data/lib/rubocop/server/server_command.rb +21 -0
- data/lib/rubocop/server/socket_reader.rb +69 -0
- data/lib/rubocop/server.rb +53 -0
- data/lib/rubocop/string_interpreter.rb +7 -4
- data/lib/rubocop/target_finder.rb +58 -48
- data/lib/rubocop/target_ruby.rb +135 -15
- data/lib/rubocop/util.rb +16 -0
- data/lib/rubocop/version.rb +84 -7
- data/lib/rubocop/yaml_duplication_checker.rb +2 -1
- data/lib/rubocop.rb +213 -103
- metadata +307 -91
- data/bin/console +0 -10
- data/bin/setup +0 -7
- data/lib/rubocop/ast/builder.rb +0 -83
- data/lib/rubocop/ast/node/alias_node.rb +0 -24
- data/lib/rubocop/ast/node/and_node.rb +0 -29
- data/lib/rubocop/ast/node/args_node.rb +0 -29
- data/lib/rubocop/ast/node/array_node.rb +0 -57
- data/lib/rubocop/ast/node/block_node.rb +0 -117
- data/lib/rubocop/ast/node/break_node.rb +0 -17
- data/lib/rubocop/ast/node/case_node.rb +0 -56
- data/lib/rubocop/ast/node/class_node.rb +0 -31
- data/lib/rubocop/ast/node/def_node.rb +0 -82
- data/lib/rubocop/ast/node/defined_node.rb +0 -17
- data/lib/rubocop/ast/node/ensure_node.rb +0 -17
- data/lib/rubocop/ast/node/float_node.rb +0 -12
- data/lib/rubocop/ast/node/for_node.rb +0 -53
- data/lib/rubocop/ast/node/forward_args_node.rb +0 -18
- data/lib/rubocop/ast/node/hash_node.rb +0 -109
- data/lib/rubocop/ast/node/if_node.rb +0 -175
- data/lib/rubocop/ast/node/int_node.rb +0 -12
- data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
- data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -261
- data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
- data/lib/rubocop/ast/node/mixin/numeric_node.rb +0 -21
- data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
- data/lib/rubocop/ast/node/module_node.rb +0 -24
- data/lib/rubocop/ast/node/or_node.rb +0 -29
- data/lib/rubocop/ast/node/pair_node.rb +0 -63
- data/lib/rubocop/ast/node/range_node.rb +0 -18
- data/lib/rubocop/ast/node/regexp_node.rb +0 -33
- data/lib/rubocop/ast/node/resbody_node.rb +0 -24
- data/lib/rubocop/ast/node/retry_node.rb +0 -17
- data/lib/rubocop/ast/node/return_node.rb +0 -24
- data/lib/rubocop/ast/node/self_class_node.rb +0 -24
- data/lib/rubocop/ast/node/send_node.rb +0 -13
- data/lib/rubocop/ast/node/str_node.rb +0 -16
- data/lib/rubocop/ast/node/super_node.rb +0 -21
- data/lib/rubocop/ast/node/symbol_node.rb +0 -12
- data/lib/rubocop/ast/node/until_node.rb +0 -35
- data/lib/rubocop/ast/node/when_node.rb +0 -53
- data/lib/rubocop/ast/node/while_node.rb +0 -35
- data/lib/rubocop/ast/node/yield_node.rb +0 -21
- data/lib/rubocop/ast/node.rb +0 -632
- data/lib/rubocop/ast/sexp.rb +0 -16
- data/lib/rubocop/ast/traversal.rb +0 -200
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +0 -105
- data/lib/rubocop/cop/layout/tab.rb +0 -75
- data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -19
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +0 -29
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
- data/lib/rubocop/node_pattern.rb +0 -887
- data/lib/rubocop/processed_source.rb +0 -216
- data/lib/rubocop/string_util.rb +0 -14
- data/lib/rubocop/token.rb +0 -114
@@ -2,28 +2,42 @@
|
|
2
2
|
|
3
3
|
module RuboCop
|
4
4
|
module Cop
|
5
|
-
# Common functionality for enforcing a specific superclass
|
5
|
+
# Common functionality for enforcing a specific superclass.
|
6
|
+
#
|
7
|
+
# IMPORTANT: RuboCop core depended on this module when it supported Rails department.
|
8
|
+
# Rails department has been extracted to RuboCop Rails gem.
|
9
|
+
#
|
10
|
+
# @deprecated This module is deprecated and will be removed by RuboCop 2.0.
|
11
|
+
# It will not be updated to `RuboCop::Cop::Base` v1 API to maintain compatibility
|
12
|
+
# with existing RuboCop Rails 2.8 or lower.
|
13
|
+
#
|
14
|
+
# @api private
|
6
15
|
module EnforceSuperclass
|
7
16
|
def self.included(base)
|
17
|
+
warn Rainbow(
|
18
|
+
'`RuboCop::Cop::EnforceSuperclass` is deprecated and will be removed in RuboCop 2.0. ' \
|
19
|
+
'Please upgrade to RuboCop Rails 2.9 or newer to continue.'
|
20
|
+
).yellow
|
21
|
+
|
22
|
+
# @!method class_definition(node)
|
8
23
|
base.def_node_matcher :class_definition, <<~PATTERN
|
9
24
|
(class (const _ !:#{base::SUPERCLASS}) #{base::BASE_PATTERN} ...)
|
10
25
|
PATTERN
|
11
26
|
|
27
|
+
# @!method class_new_definition(node)
|
12
28
|
base.def_node_matcher :class_new_definition, <<~PATTERN
|
13
|
-
[!^(casgn nil? :#{base::SUPERCLASS} ...)
|
29
|
+
[!^(casgn {nil? cbase} :#{base::SUPERCLASS} ...)
|
30
|
+
!^^(casgn {nil? cbase} :#{base::SUPERCLASS} (block ...))
|
31
|
+
(send (const {nil? cbase} :Class) :new #{base::BASE_PATTERN})]
|
14
32
|
PATTERN
|
15
33
|
end
|
16
34
|
|
17
35
|
def on_class(node)
|
18
|
-
class_definition(node)
|
19
|
-
add_offense(node.children[1])
|
20
|
-
end
|
36
|
+
class_definition(node) { add_offense(node.children[1]) }
|
21
37
|
end
|
22
38
|
|
23
39
|
def on_send(node)
|
24
|
-
class_new_definition(node)
|
25
|
-
add_offense(node.children.last)
|
26
|
-
end
|
40
|
+
class_new_definition(node) { add_offense(node.children.last) }
|
27
41
|
end
|
28
42
|
end
|
29
43
|
end
|
@@ -7,39 +7,43 @@ module RuboCop
|
|
7
7
|
module FirstElementLineBreak
|
8
8
|
private
|
9
9
|
|
10
|
-
def check_method_line_break(node, children)
|
10
|
+
def check_method_line_break(node, children, ignore_last: false)
|
11
11
|
return if children.empty?
|
12
12
|
|
13
13
|
return unless method_uses_parens?(node, children.first)
|
14
14
|
|
15
|
-
check_children_line_break(node, children)
|
15
|
+
check_children_line_break(node, children, ignore_last: ignore_last)
|
16
16
|
end
|
17
17
|
|
18
18
|
def method_uses_parens?(node, limit)
|
19
19
|
source = node.source_range.source_line[0...limit.loc.column]
|
20
|
-
|
20
|
+
/\s*\(\s*$/.match?(source)
|
21
21
|
end
|
22
22
|
|
23
|
-
def check_children_line_break(node, children, start = node)
|
24
|
-
return if children.
|
23
|
+
def check_children_line_break(node, children, start = node, ignore_last: false)
|
24
|
+
return if children.empty?
|
25
25
|
|
26
26
|
line = start.first_line
|
27
27
|
|
28
28
|
min = first_by_line(children)
|
29
29
|
return if line != min.first_line
|
30
30
|
|
31
|
-
|
32
|
-
return if line ==
|
31
|
+
max_line = last_line(children, ignore_last: ignore_last)
|
32
|
+
return if line == max_line
|
33
33
|
|
34
|
-
add_offense(min)
|
34
|
+
add_offense(min) { |corrector| EmptyLineCorrector.insert_before(corrector, min) }
|
35
35
|
end
|
36
36
|
|
37
37
|
def first_by_line(nodes)
|
38
38
|
nodes.min_by(&:first_line)
|
39
39
|
end
|
40
40
|
|
41
|
-
def
|
42
|
-
|
41
|
+
def last_line(nodes, ignore_last:)
|
42
|
+
if ignore_last
|
43
|
+
nodes.map(&:first_line)
|
44
|
+
else
|
45
|
+
nodes.map(&:last_line)
|
46
|
+
end.max
|
43
47
|
end
|
44
48
|
end
|
45
49
|
end
|
@@ -8,16 +8,36 @@ module RuboCop
|
|
8
8
|
|
9
9
|
FROZEN_STRING_LITERAL = '# frozen_string_literal:'
|
10
10
|
FROZEN_STRING_LITERAL_ENABLED = '# frozen_string_literal: true'
|
11
|
-
|
11
|
+
FROZEN_STRING_LITERAL_TYPES_RUBY27 = %i[str dstr].freeze
|
12
|
+
|
13
|
+
private_constant :FROZEN_STRING_LITERAL_TYPES_RUBY27
|
12
14
|
|
13
15
|
def frozen_string_literal_comment_exists?
|
14
|
-
leading_comment_lines.any?
|
15
|
-
MagicComment.parse(line).valid_literal_value?
|
16
|
-
end
|
16
|
+
leading_comment_lines.any? { |line| MagicComment.parse(line).valid_literal_value? }
|
17
17
|
end
|
18
18
|
|
19
19
|
private
|
20
20
|
|
21
|
+
def frozen_string_literal?(node)
|
22
|
+
frozen_string = if target_ruby_version >= 3.0
|
23
|
+
uninterpolated_string?(node) || frozen_heredoc?(node)
|
24
|
+
else
|
25
|
+
FROZEN_STRING_LITERAL_TYPES_RUBY27.include?(node.type)
|
26
|
+
end
|
27
|
+
|
28
|
+
frozen_string && frozen_string_literals_enabled?
|
29
|
+
end
|
30
|
+
|
31
|
+
def uninterpolated_string?(node)
|
32
|
+
node.str_type? || (node.dstr_type? && node.each_descendant(:begin).none?)
|
33
|
+
end
|
34
|
+
|
35
|
+
def frozen_heredoc?(node)
|
36
|
+
return false unless node.dstr_type? && node.heredoc?
|
37
|
+
|
38
|
+
node.children.all?(&:str_type?)
|
39
|
+
end
|
40
|
+
|
21
41
|
def frozen_string_literals_enabled?
|
22
42
|
ruby_version = processed_source.ruby_version
|
23
43
|
return false unless ruby_version
|
@@ -34,8 +54,12 @@ module RuboCop
|
|
34
54
|
# And the above `ruby_version >= 3.1` is undecided whether it will be
|
35
55
|
# Ruby 3.1, 3.2, 4.0 or others.
|
36
56
|
# See https://bugs.ruby-lang.org/issues/8976#note-41 for details.
|
57
|
+
leading_comment_lines.any? { |line| MagicComment.parse(line).frozen_string_literal? }
|
58
|
+
end
|
59
|
+
|
60
|
+
def frozen_string_literals_disabled?
|
37
61
|
leading_comment_lines.any? do |line|
|
38
|
-
MagicComment.parse(line).frozen_string_literal
|
62
|
+
MagicComment.parse(line).frozen_string_literal == false
|
39
63
|
end
|
40
64
|
end
|
41
65
|
|
@@ -45,8 +69,19 @@ module RuboCop
|
|
45
69
|
end
|
46
70
|
end
|
47
71
|
|
72
|
+
def leading_magic_comments
|
73
|
+
leading_comment_lines.map { |line| MagicComment.parse(line) }
|
74
|
+
end
|
75
|
+
|
48
76
|
def leading_comment_lines
|
49
|
-
processed_source.
|
77
|
+
first_non_comment_token = processed_source.tokens.find { |token| !token.comment? }
|
78
|
+
|
79
|
+
if first_non_comment_token
|
80
|
+
# `line` is 1-indexed so we need to subtract 1 to get the array index
|
81
|
+
processed_source.lines[0...first_non_comment_token.line - 1]
|
82
|
+
else
|
83
|
+
processed_source.lines
|
84
|
+
end
|
50
85
|
end
|
51
86
|
end
|
52
87
|
end
|
@@ -0,0 +1,13 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
# Common functionality for checking gem declarations.
|
6
|
+
module GemDeclaration
|
7
|
+
extend NodePattern::Macros
|
8
|
+
|
9
|
+
# @!method gem_declaration?(node)
|
10
|
+
def_node_matcher :gem_declaration?, '(send nil? :gem str ...)'
|
11
|
+
end
|
12
|
+
end
|
13
|
+
end
|
@@ -0,0 +1,30 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
# Common functionality for checking gem declarations.
|
6
|
+
module GemspecHelp
|
7
|
+
extend NodePattern::Macros
|
8
|
+
|
9
|
+
# @!method gem_specification?(node)
|
10
|
+
def_node_matcher :gem_specification?, <<~PATTERN
|
11
|
+
(block
|
12
|
+
(send
|
13
|
+
(const
|
14
|
+
(const {cbase nil?} :Gem) :Specification) :new)
|
15
|
+
(args
|
16
|
+
(arg $_)) ...)
|
17
|
+
PATTERN
|
18
|
+
|
19
|
+
# @!method gem_specification(node)
|
20
|
+
def_node_search :gem_specification, <<~PATTERN
|
21
|
+
(block
|
22
|
+
(send
|
23
|
+
(const
|
24
|
+
(const {cbase nil?} :Gem) :Specification) :new)
|
25
|
+
(args
|
26
|
+
(arg $_)) ...)
|
27
|
+
PATTERN
|
28
|
+
end
|
29
|
+
end
|
30
|
+
end
|
@@ -43,7 +43,7 @@ module RuboCop
|
|
43
43
|
end
|
44
44
|
|
45
45
|
def value_delta(pair)
|
46
|
-
return 0 if pair.
|
46
|
+
return 0 if pair.value_on_new_line? || pair.value_omission?
|
47
47
|
|
48
48
|
correct_value_column = pair.loc.operator.end.column + 1
|
49
49
|
actual_value_column = pair.value.loc.column
|
@@ -60,10 +60,8 @@ module RuboCop
|
|
60
60
|
|
61
61
|
def deltas(first_pair, current_pair)
|
62
62
|
key_delta = key_delta(first_pair, current_pair)
|
63
|
-
separator_delta = separator_delta(first_pair, current_pair,
|
64
|
-
|
65
|
-
value_delta = value_delta(first_pair, current_pair) -
|
66
|
-
key_delta - separator_delta
|
63
|
+
separator_delta = separator_delta(first_pair, current_pair, key_delta)
|
64
|
+
value_delta = value_delta(first_pair, current_pair) - key_delta - separator_delta
|
67
65
|
|
68
66
|
{ key: key_delta, separator: separator_delta, value: value_delta }
|
69
67
|
end
|
@@ -106,17 +104,15 @@ module RuboCop
|
|
106
104
|
end
|
107
105
|
|
108
106
|
def hash_rocket_delta(first_pair, current_pair)
|
109
|
-
first_pair.loc.column + max_key_width + 1 -
|
110
|
-
current_pair.loc.operator.column
|
107
|
+
first_pair.loc.column + max_key_width + 1 - current_pair.loc.operator.column
|
111
108
|
end
|
112
109
|
|
113
110
|
def value_delta(first_pair, current_pair)
|
114
|
-
return 0 if current_pair.kwsplat_type?
|
115
|
-
|
116
111
|
correct_value_column = first_pair.key.loc.column +
|
117
112
|
current_pair.delimiter(true).length +
|
118
113
|
max_key_width
|
119
|
-
|
114
|
+
|
115
|
+
current_pair.value_omission? ? 0 : correct_value_column - current_pair.value.loc.column
|
120
116
|
end
|
121
117
|
end
|
122
118
|
|
@@ -139,7 +135,20 @@ module RuboCop
|
|
139
135
|
end
|
140
136
|
|
141
137
|
def value_delta(first_pair, current_pair)
|
142
|
-
first_pair.value_delta(current_pair)
|
138
|
+
current_pair.value_omission? ? 0 : first_pair.value_delta(current_pair)
|
139
|
+
end
|
140
|
+
end
|
141
|
+
|
142
|
+
# Handles calculation of deltas for `kwsplat` nodes.
|
143
|
+
# This is a special case that just ensures the kwsplat is aligned with the rest of the hash
|
144
|
+
# since a `kwsplat` does not have a key, separator or value.
|
145
|
+
class KeywordSplatAlignment
|
146
|
+
def deltas(first_pair, current_pair)
|
147
|
+
if Util.begins_its_line?(current_pair.source_range)
|
148
|
+
{ key: first_pair.key_delta(current_pair) }
|
149
|
+
else
|
150
|
+
{}
|
151
|
+
end
|
143
152
|
end
|
144
153
|
end
|
145
154
|
end
|
@@ -0,0 +1,187 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
# This module checks for Ruby 3.1's hash value omission syntax.
|
6
|
+
module HashShorthandSyntax
|
7
|
+
OMIT_HASH_VALUE_MSG = 'Omit the hash value.'
|
8
|
+
EXPLICIT_HASH_VALUE_MSG = 'Include the hash value.'
|
9
|
+
DO_NOT_MIX_MSG_PREFIX = 'Do not mix explicit and implicit hash values.'
|
10
|
+
DO_NOT_MIX_OMIT_VALUE_MSG = "#{DO_NOT_MIX_MSG_PREFIX} #{OMIT_HASH_VALUE_MSG}"
|
11
|
+
DO_NOT_MIX_EXPLICIT_VALUE_MSG = "#{DO_NOT_MIX_MSG_PREFIX} #{EXPLICIT_HASH_VALUE_MSG}"
|
12
|
+
|
13
|
+
def on_hash_for_mixed_shorthand(hash_node)
|
14
|
+
return if ignore_mixed_hash_shorthand_syntax?(hash_node)
|
15
|
+
|
16
|
+
hash_value_type_breakdown = breakdown_value_types_of_hash(hash_node)
|
17
|
+
|
18
|
+
if hash_with_mixed_shorthand_syntax?(hash_value_type_breakdown)
|
19
|
+
mixed_shorthand_syntax_check(hash_value_type_breakdown)
|
20
|
+
else
|
21
|
+
no_mixed_shorthand_syntax_check(hash_value_type_breakdown)
|
22
|
+
end
|
23
|
+
end
|
24
|
+
|
25
|
+
def on_pair(node)
|
26
|
+
return if ignore_hash_shorthand_syntax?(node)
|
27
|
+
|
28
|
+
hash_key_source = node.key.source
|
29
|
+
|
30
|
+
if enforced_shorthand_syntax == 'always'
|
31
|
+
return if node.value_omission? || require_hash_value?(hash_key_source, node)
|
32
|
+
|
33
|
+
message = OMIT_HASH_VALUE_MSG
|
34
|
+
replacement = "#{hash_key_source}:"
|
35
|
+
self.config_to_allow_offenses = { 'Enabled' => false }
|
36
|
+
else
|
37
|
+
return unless node.value_omission?
|
38
|
+
|
39
|
+
message = EXPLICIT_HASH_VALUE_MSG
|
40
|
+
replacement = "#{hash_key_source}: #{hash_key_source}"
|
41
|
+
end
|
42
|
+
|
43
|
+
register_offense(node, message, replacement)
|
44
|
+
end
|
45
|
+
|
46
|
+
private
|
47
|
+
|
48
|
+
# rubocop:disable Metrics/AbcSize
|
49
|
+
def register_offense(node, message, replacement)
|
50
|
+
add_offense(node.value, message: message) do |corrector|
|
51
|
+
if (def_node = def_node_that_require_parentheses(node))
|
52
|
+
white_spaces = range_between(def_node.loc.selector.end_pos,
|
53
|
+
def_node.first_argument.source_range.begin_pos)
|
54
|
+
corrector.replace(white_spaces, '(')
|
55
|
+
|
56
|
+
last_argument = def_node.arguments.last
|
57
|
+
corrector.insert_after(last_argument, ')') if node == last_argument.pairs.last
|
58
|
+
end
|
59
|
+
corrector.replace(node, replacement)
|
60
|
+
end
|
61
|
+
end
|
62
|
+
# rubocop:enable Metrics/AbcSize
|
63
|
+
|
64
|
+
def ignore_mixed_hash_shorthand_syntax?(hash_node)
|
65
|
+
target_ruby_version <= 3.0 || enforced_shorthand_syntax != 'consistent' ||
|
66
|
+
!hash_node.hash_type?
|
67
|
+
end
|
68
|
+
|
69
|
+
def ignore_hash_shorthand_syntax?(pair_node)
|
70
|
+
target_ruby_version <= 3.0 || enforced_shorthand_syntax == 'either' ||
|
71
|
+
enforced_shorthand_syntax == 'consistent' ||
|
72
|
+
!pair_node.parent.hash_type?
|
73
|
+
end
|
74
|
+
|
75
|
+
def enforced_shorthand_syntax
|
76
|
+
cop_config.fetch('EnforcedShorthandSyntax', 'always')
|
77
|
+
end
|
78
|
+
|
79
|
+
def require_hash_value?(hash_key_source, node)
|
80
|
+
return true if !node.key.sym_type? || require_hash_value_for_around_hash_literal?(node)
|
81
|
+
|
82
|
+
hash_value = node.value
|
83
|
+
return true unless hash_value.send_type? || hash_value.lvar_type?
|
84
|
+
|
85
|
+
hash_key_source != hash_value.source || hash_key_source.end_with?('!', '?')
|
86
|
+
end
|
87
|
+
|
88
|
+
def require_hash_value_for_around_hash_literal?(node)
|
89
|
+
return false unless (send_node = find_ancestor_send_node(node))
|
90
|
+
|
91
|
+
!node.parent.braces? && !use_element_of_hash_literal_as_receiver?(send_node, node.parent) &&
|
92
|
+
use_modifier_form_without_parenthesized_method_call?(send_node)
|
93
|
+
end
|
94
|
+
|
95
|
+
def def_node_that_require_parentheses(node)
|
96
|
+
return unless (send_node = find_ancestor_send_node(node))
|
97
|
+
return unless without_parentheses_call_expr_follows?(send_node)
|
98
|
+
|
99
|
+
def_node = node.each_ancestor(:send, :csend).first
|
100
|
+
|
101
|
+
def_node unless def_node && def_node.arguments.empty?
|
102
|
+
end
|
103
|
+
|
104
|
+
def find_ancestor_send_node(node)
|
105
|
+
ancestor = node.parent.parent
|
106
|
+
|
107
|
+
ancestor if ancestor&.call_type? && !ancestor&.method?(:[])
|
108
|
+
end
|
109
|
+
|
110
|
+
def use_element_of_hash_literal_as_receiver?(ancestor, parent)
|
111
|
+
# `{value:}.do_something` is a valid syntax.
|
112
|
+
ancestor.send_type? && ancestor.receiver == parent
|
113
|
+
end
|
114
|
+
|
115
|
+
def use_modifier_form_without_parenthesized_method_call?(ancestor)
|
116
|
+
return false if ancestor.respond_to?(:parenthesized?) && ancestor.parenthesized?
|
117
|
+
|
118
|
+
ancestor.ancestors.any? { |node| node.respond_to?(:modifier_form?) && node.modifier_form? }
|
119
|
+
end
|
120
|
+
|
121
|
+
def without_parentheses_call_expr_follows?(ancestor)
|
122
|
+
return false unless ancestor.respond_to?(:parenthesized?) && !ancestor.parenthesized?
|
123
|
+
|
124
|
+
right_sibling = ancestor.right_sibling
|
125
|
+
right_sibling ||= ancestor.each_ancestor.find do |node|
|
126
|
+
node.assignment? || node.send_type?
|
127
|
+
end&.right_sibling
|
128
|
+
|
129
|
+
!!right_sibling
|
130
|
+
end
|
131
|
+
|
132
|
+
def breakdown_value_types_of_hash(hash_node)
|
133
|
+
hash_node.pairs.group_by do |pair_node|
|
134
|
+
if pair_node.value_omission?
|
135
|
+
:value_omitted
|
136
|
+
elsif require_hash_value?(pair_node.key.source, pair_node)
|
137
|
+
:value_needed
|
138
|
+
else
|
139
|
+
:value_omittable
|
140
|
+
end
|
141
|
+
end
|
142
|
+
end
|
143
|
+
|
144
|
+
def hash_with_mixed_shorthand_syntax?(hash_value_type_breakdown)
|
145
|
+
hash_value_type_breakdown.keys.size > 1
|
146
|
+
end
|
147
|
+
|
148
|
+
def hash_with_values_that_cant_be_omitted?(hash_value_type_breakdown)
|
149
|
+
hash_value_type_breakdown[:value_needed]&.any?
|
150
|
+
end
|
151
|
+
|
152
|
+
def each_omitted_value_pair(hash_value_type_breakdown, &block)
|
153
|
+
hash_value_type_breakdown[:value_omitted]&.each(&block)
|
154
|
+
end
|
155
|
+
|
156
|
+
def each_omittable_value_pair(hash_value_type_breakdown, &block)
|
157
|
+
hash_value_type_breakdown[:value_omittable]&.each(&block)
|
158
|
+
end
|
159
|
+
|
160
|
+
def mixed_shorthand_syntax_check(hash_value_type_breakdown)
|
161
|
+
if hash_with_values_that_cant_be_omitted?(hash_value_type_breakdown)
|
162
|
+
each_omitted_value_pair(hash_value_type_breakdown) do |pair_node|
|
163
|
+
hash_key_source = pair_node.key.source
|
164
|
+
replacement = "#{hash_key_source}: #{hash_key_source}"
|
165
|
+
register_offense(pair_node, DO_NOT_MIX_EXPLICIT_VALUE_MSG, replacement)
|
166
|
+
end
|
167
|
+
else
|
168
|
+
each_omittable_value_pair(hash_value_type_breakdown) do |pair_node|
|
169
|
+
hash_key_source = pair_node.key.source
|
170
|
+
replacement = "#{hash_key_source}:"
|
171
|
+
register_offense(pair_node, DO_NOT_MIX_OMIT_VALUE_MSG, replacement)
|
172
|
+
end
|
173
|
+
end
|
174
|
+
end
|
175
|
+
|
176
|
+
def no_mixed_shorthand_syntax_check(hash_value_type_breakdown)
|
177
|
+
return if hash_with_values_that_cant_be_omitted?(hash_value_type_breakdown)
|
178
|
+
|
179
|
+
each_omittable_value_pair(hash_value_type_breakdown) do |pair_node|
|
180
|
+
hash_key_source = pair_node.key.source
|
181
|
+
replacement = "#{hash_key_source}:"
|
182
|
+
register_offense(pair_node, OMIT_HASH_VALUE_MSG, replacement)
|
183
|
+
end
|
184
|
+
end
|
185
|
+
end
|
186
|
+
end
|
187
|
+
end
|
@@ -5,32 +5,34 @@ module RuboCop
|
|
5
5
|
# Common functionality for Style/HashTransformKeys and
|
6
6
|
# Style/HashTransformValues
|
7
7
|
module HashTransformMethod
|
8
|
-
|
8
|
+
extend NodePattern::Macros
|
9
|
+
|
10
|
+
RESTRICT_ON_SEND = %i[[] to_h].freeze
|
11
|
+
|
12
|
+
# @!method array_receiver?(node)
|
13
|
+
def_node_matcher :array_receiver?, <<~PATTERN
|
14
|
+
{(array ...) (send _ :each_with_index) (send _ :with_index _ ?) (send _ :zip ...)}
|
15
|
+
PATTERN
|
16
|
+
|
17
|
+
def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
|
9
18
|
on_bad_each_with_object(node) do |*match|
|
10
19
|
handle_possible_offense(node, match, 'each_with_object')
|
11
20
|
end
|
21
|
+
|
22
|
+
return if target_ruby_version < 2.6
|
23
|
+
|
24
|
+
on_bad_to_h(node) { |*match| handle_possible_offense(node, match, 'to_h {...}') }
|
12
25
|
end
|
13
26
|
|
14
27
|
def on_send(node)
|
15
28
|
on_bad_hash_brackets_map(node) do |*match|
|
16
29
|
handle_possible_offense(node, match, 'Hash[_.map {...}]')
|
17
30
|
end
|
18
|
-
on_bad_map_to_h(node)
|
19
|
-
handle_possible_offense(node, match, 'map {...}.to_h')
|
20
|
-
end
|
31
|
+
on_bad_map_to_h(node) { |*match| handle_possible_offense(node, match, 'map {...}.to_h') }
|
21
32
|
end
|
22
33
|
|
23
34
|
def on_csend(node)
|
24
|
-
on_bad_map_to_h(node)
|
25
|
-
handle_possible_offense(node, match, 'map {...}.to_h')
|
26
|
-
end
|
27
|
-
end
|
28
|
-
|
29
|
-
def autocorrect(node)
|
30
|
-
lambda do |corrector|
|
31
|
-
correction = prepare_correction(node)
|
32
|
-
execute_correction(corrector, node, correction)
|
33
|
-
end
|
35
|
+
on_bad_map_to_h(node) { |*match| handle_possible_offense(node, match, 'map {...}.to_h') }
|
34
36
|
end
|
35
37
|
|
36
38
|
private
|
@@ -50,8 +52,12 @@ module RuboCop
|
|
50
52
|
raise NotImplementedError
|
51
53
|
end
|
52
54
|
|
55
|
+
# @abstract Implemented with `def_node_matcher`
|
56
|
+
def on_bad_to_h(_node)
|
57
|
+
raise NotImplementedError
|
58
|
+
end
|
59
|
+
|
53
60
|
def handle_possible_offense(node, match, match_desc)
|
54
|
-
puts node.class
|
55
61
|
captures = extract_captures(match)
|
56
62
|
|
57
63
|
# If key didn't actually change either, this is most likely a false
|
@@ -62,10 +68,13 @@ module RuboCop
|
|
62
68
|
# `transform_values` if value transformation uses key.
|
63
69
|
return if captures.transformation_uses_both_args?
|
64
70
|
|
65
|
-
|
66
|
-
|
67
|
-
|
68
|
-
)
|
71
|
+
return unless captures.use_transformed_argname?
|
72
|
+
|
73
|
+
message = "Prefer `#{new_method_name}` over `#{match_desc}`."
|
74
|
+
add_offense(node, message: message) do |corrector|
|
75
|
+
correction = prepare_correction(node)
|
76
|
+
execute_correction(corrector, node, correction)
|
77
|
+
end
|
69
78
|
end
|
70
79
|
|
71
80
|
# @abstract
|
@@ -89,6 +98,8 @@ module RuboCop
|
|
89
98
|
Autocorrection.from_hash_brackets_map(node, match)
|
90
99
|
elsif (match = on_bad_map_to_h(node))
|
91
100
|
Autocorrection.from_map_to_h(node, match)
|
101
|
+
elsif (match = on_bad_to_h(node))
|
102
|
+
Autocorrection.from_to_h(node, match)
|
92
103
|
else
|
93
104
|
raise 'unreachable'
|
94
105
|
end
|
@@ -100,18 +111,11 @@ module RuboCop
|
|
100
111
|
|
101
112
|
captures = extract_captures(correction.match)
|
102
113
|
correction.set_new_arg_name(captures.transformed_argname, corrector)
|
103
|
-
correction.set_new_body_expression(
|
104
|
-
captures.transforming_body_expr,
|
105
|
-
corrector
|
106
|
-
)
|
114
|
+
correction.set_new_body_expression(captures.transforming_body_expr, corrector)
|
107
115
|
end
|
108
116
|
|
109
117
|
# Internal helper class to hold match data
|
110
|
-
Captures = Struct.new(
|
111
|
-
:transformed_argname,
|
112
|
-
:transforming_body_expr,
|
113
|
-
:unchanged_body_expr
|
114
|
-
) do
|
118
|
+
Captures = Struct.new(:transformed_argname, :transforming_body_expr, :unchanged_body_expr) do
|
115
119
|
def noop_transformation?
|
116
120
|
transforming_body_expr.lvar_type? &&
|
117
121
|
transforming_body_expr.children == [transformed_argname]
|
@@ -120,10 +124,16 @@ module RuboCop
|
|
120
124
|
def transformation_uses_both_args?
|
121
125
|
transforming_body_expr.descendants.include?(unchanged_body_expr)
|
122
126
|
end
|
127
|
+
|
128
|
+
def use_transformed_argname?
|
129
|
+
transforming_body_expr.each_descendant(:lvar).any? do |node|
|
130
|
+
node.source == transformed_argname.to_s
|
131
|
+
end
|
132
|
+
end
|
123
133
|
end
|
124
134
|
|
125
135
|
# Internal helper class to hold autocorrect data
|
126
|
-
Autocorrection = Struct.new(:match, :block_node, :leading, :trailing) do
|
136
|
+
Autocorrection = Struct.new(:match, :block_node, :leading, :trailing) do
|
127
137
|
def self.from_each_with_object(node, match)
|
128
138
|
new(match, node, 0, 0)
|
129
139
|
end
|
@@ -133,10 +143,21 @@ module RuboCop
|
|
133
143
|
end
|
134
144
|
|
135
145
|
def self.from_map_to_h(node, match)
|
136
|
-
|
146
|
+
if node.parent&.block_type? && node.parent.send_node == node
|
147
|
+
strip_trailing_chars = 0
|
148
|
+
else
|
149
|
+
map_range = node.children.first.source_range
|
150
|
+
node_range = node.source_range
|
151
|
+
strip_trailing_chars = node_range.end_pos - map_range.end_pos
|
152
|
+
end
|
153
|
+
|
137
154
|
new(match, node.children.first, 0, strip_trailing_chars)
|
138
155
|
end
|
139
156
|
|
157
|
+
def self.from_to_h(node, match)
|
158
|
+
new(match, node, 0, 0)
|
159
|
+
end
|
160
|
+
|
140
161
|
def strip_prefix_and_suffix(node, corrector)
|
141
162
|
expression = node.loc.expression
|
142
163
|
corrector.remove_leading(expression, leading)
|
@@ -154,17 +175,16 @@ module RuboCop
|
|
154
175
|
end
|
155
176
|
|
156
177
|
def set_new_arg_name(transformed_argname, corrector)
|
157
|
-
corrector.replace(
|
158
|
-
block_node.arguments.loc.expression,
|
159
|
-
"|#{transformed_argname}|"
|
160
|
-
)
|
178
|
+
corrector.replace(block_node.arguments.loc.expression, "|#{transformed_argname}|")
|
161
179
|
end
|
162
180
|
|
163
181
|
def set_new_body_expression(transforming_body_expr, corrector)
|
164
|
-
|
165
|
-
|
166
|
-
|
167
|
-
|
182
|
+
body_source = transforming_body_expr.loc.expression.source
|
183
|
+
if transforming_body_expr.hash_type? && !transforming_body_expr.braces?
|
184
|
+
body_source = "{ #{body_source} }"
|
185
|
+
end
|
186
|
+
|
187
|
+
corrector.replace(block_node.body, body_source)
|
168
188
|
end
|
169
189
|
end
|
170
190
|
end
|
@@ -20,6 +20,11 @@ module RuboCop
|
|
20
20
|
|
21
21
|
private
|
22
22
|
|
23
|
+
def indent_level(str)
|
24
|
+
indentations = str.lines.map { |line| line[/^\s*/] }.reject { |line| line.end_with?("\n") }
|
25
|
+
indentations.empty? ? 0 : indentations.min_by(&:size).size
|
26
|
+
end
|
27
|
+
|
23
28
|
def delimiter_string(node)
|
24
29
|
node.source.match(OPENING_DELIMITER).captures[1]
|
25
30
|
end
|
@@ -15,9 +15,7 @@ module RuboCop
|
|
15
15
|
alias on_regexp on_dstr
|
16
16
|
|
17
17
|
def on_node_with_interpolations(node)
|
18
|
-
node.each_child_node(:begin)
|
19
|
-
on_interpolation(begin_node)
|
20
|
-
end
|
18
|
+
node.each_child_node(:begin) { |begin_node| on_interpolation(begin_node) }
|
21
19
|
end
|
22
20
|
|
23
21
|
# @!method on_interpolation(begin_node)
|