rubocop 0.80.0 → 1.42.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +71 -38
- data/assets/output.html.erb +1 -1
- data/config/default.yml +1682 -202
- data/config/obsoletion.yml +233 -0
- data/exe/rubocop +15 -9
- data/lib/rubocop/arguments_env.rb +17 -0
- data/lib/rubocop/arguments_file.rb +17 -0
- data/lib/rubocop/ast_aliases.rb +8 -0
- data/lib/rubocop/cache_config.rb +29 -0
- data/lib/rubocop/cached_data.rb +4 -4
- data/lib/rubocop/cli/command/auto_generate_config.rb +147 -0
- data/lib/rubocop/cli/command/base.rb +2 -0
- data/lib/rubocop/cli/command/execute_runner.rb +38 -14
- data/lib/rubocop/cli/command/init_dotfile.rb +4 -5
- data/lib/rubocop/cli/command/show_cops.rb +6 -12
- data/lib/rubocop/cli/command/show_docs_url.rb +48 -0
- data/lib/rubocop/cli/command/suggest_extensions.rb +126 -0
- data/lib/rubocop/cli/command/version.rb +3 -2
- data/lib/rubocop/cli/command.rb +1 -0
- data/lib/rubocop/cli/environment.rb +1 -0
- data/lib/rubocop/cli.rb +41 -14
- data/lib/rubocop/comment_config.rb +90 -99
- data/lib/rubocop/config.rb +117 -42
- data/lib/rubocop/config_finder.rb +68 -0
- data/lib/rubocop/config_loader.rb +122 -133
- data/lib/rubocop/config_loader_resolver.rb +125 -39
- data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
- data/lib/rubocop/config_obsoletion/changed_parameter.rb +26 -0
- data/lib/rubocop/config_obsoletion/cop_rule.rb +33 -0
- data/lib/rubocop/config_obsoletion/extracted_cop.rb +46 -0
- data/lib/rubocop/config_obsoletion/parameter_rule.rb +48 -0
- data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
- data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
- data/lib/rubocop/config_obsoletion/rule.rb +41 -0
- data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
- data/lib/rubocop/config_obsoletion.rb +72 -240
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +31 -7
- data/lib/rubocop/config_validator.rb +95 -29
- data/lib/rubocop/cop/autocorrect_logic.rb +45 -40
- data/lib/rubocop/cop/badge.rb +27 -32
- data/lib/rubocop/cop/base.rb +464 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +34 -14
- data/lib/rubocop/cop/bundler/gem_comment.rb +117 -10
- data/lib/rubocop/cop/bundler/gem_filename.rb +103 -0
- data/lib/rubocop/cop/bundler/gem_version.rb +133 -0
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +45 -28
- data/lib/rubocop/cop/bundler/ordered_gems.rb +7 -18
- data/lib/rubocop/cop/commissioner.rb +105 -74
- data/lib/rubocop/cop/cop.rb +84 -234
- data/lib/rubocop/cop/corrector.rb +77 -119
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +14 -24
- data/lib/rubocop/cop/correctors/condition_corrector.rb +4 -7
- data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +4 -6
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +10 -11
- data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +5 -4
- data/lib/rubocop/cop/correctors/if_then_corrector.rb +55 -0
- data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +7 -7
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +15 -12
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +56 -11
- data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +12 -13
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +64 -9
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +11 -22
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +9 -11
- data/lib/rubocop/cop/correctors/require_library_corrector.rb +23 -0
- data/lib/rubocop/cop/correctors/space_corrector.rb +2 -4
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +7 -9
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +16 -19
- data/lib/rubocop/cop/documentation.rb +39 -0
- data/lib/rubocop/cop/exclude_limit.rb +26 -0
- data/lib/rubocop/cop/force.rb +2 -1
- data/lib/rubocop/cop/gemspec/dependency_version.rb +154 -0
- data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +11 -26
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +7 -20
- data/lib/rubocop/cop/gemspec/require_mfa.rb +145 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +69 -27
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +7 -12
- data/lib/rubocop/cop/generator/configuration_injector.rb +4 -5
- data/lib/rubocop/cop/generator/require_file_injector.rb +4 -7
- data/lib/rubocop/cop/generator.rb +36 -41
- data/lib/rubocop/cop/ignored_node.rb +1 -3
- data/lib/rubocop/cop/internal_affairs/cop_description.rb +98 -0
- data/lib/rubocop/cop/internal_affairs/create_empty_file.rb +37 -0
- data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +68 -0
- data/lib/rubocop/cop/internal_affairs/example_description.rb +92 -0
- data/lib/rubocop/cop/internal_affairs/example_heredoc_delimiter.rb +111 -0
- data/lib/rubocop/cop/internal_affairs/inherit_deprecated_cop_class.rb +34 -0
- data/lib/rubocop/cop/internal_affairs/lambda_or_proc.rb +46 -0
- data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +60 -0
- data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +80 -0
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +8 -17
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +4 -4
- data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +147 -0
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +11 -14
- data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +12 -10
- data/lib/rubocop/cop/internal_affairs/redundant_context_config_parameter.rb +46 -0
- data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +62 -0
- data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +65 -0
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +13 -8
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +12 -9
- data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +47 -0
- data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
- data/lib/rubocop/cop/internal_affairs/style_detected_api_use.rb +148 -0
- data/lib/rubocop/cop/internal_affairs/undefined_config.rb +73 -0
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +6 -6
- data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
- data/lib/rubocop/cop/internal_affairs.rb +20 -1
- data/lib/rubocop/cop/layout/access_modifier_indentation.rb +12 -10
- data/lib/rubocop/cop/layout/argument_alignment.rb +84 -19
- data/lib/rubocop/cop/layout/array_alignment.rb +58 -13
- data/lib/rubocop/cop/layout/assignment_indentation.rb +10 -9
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +74 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +56 -60
- data/lib/rubocop/cop/layout/block_end_newline.rb +41 -13
- data/lib/rubocop/cop/layout/case_indentation.rb +88 -30
- data/lib/rubocop/cop/layout/class_structure.rb +90 -80
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +25 -31
- data/lib/rubocop/cop/layout/comment_indentation.rb +56 -29
- data/lib/rubocop/cop/layout/condition_position.rb +17 -9
- data/lib/rubocop/cop/layout/def_end_alignment.rb +10 -11
- data/lib/rubocop/cop/layout/dot_position.rb +65 -27
- data/lib/rubocop/cop/layout/else_alignment.rb +29 -7
- data/lib/rubocop/cop/layout/empty_comment.rb +30 -30
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +61 -37
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +13 -13
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +161 -40
- data/lib/rubocop/cop/layout/empty_lines.rb +10 -13
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +32 -38
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +14 -10
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +139 -0
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +3 -6
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +8 -9
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +12 -15
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +16 -19
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +3 -6
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +12 -15
- data/lib/rubocop/cop/layout/end_alignment.rb +26 -25
- data/lib/rubocop/cop/layout/end_of_line.rb +13 -13
- data/lib/rubocop/cop/layout/extra_spacing.rb +32 -47
- data/lib/rubocop/cop/layout/first_argument_indentation.rb +74 -41
- data/lib/rubocop/cop/layout/first_array_element_indentation.rb +38 -25
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +43 -11
- data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +84 -29
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +51 -8
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +66 -14
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +54 -8
- data/lib/rubocop/cop/layout/first_parameter_indentation.rb +11 -10
- data/lib/rubocop/cop/layout/hash_alignment.rb +85 -55
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +48 -32
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +33 -124
- data/lib/rubocop/cop/layout/indentation_consistency.rb +10 -7
- data/lib/rubocop/cop/layout/indentation_style.rb +115 -0
- data/lib/rubocop/cop/layout/indentation_width.rb +51 -26
- data/lib/rubocop/cop/layout/initial_indentation.rb +8 -12
- data/lib/rubocop/cop/layout/leading_comment_space.rb +15 -13
- data/lib/rubocop/cop/layout/leading_empty_lines.rb +7 -12
- data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +138 -0
- data/lib/rubocop/cop/layout/line_continuation_spacing.rb +136 -0
- data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +141 -0
- data/lib/rubocop/cop/layout/line_length.rb +62 -63
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +53 -8
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +41 -19
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +45 -39
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +53 -10
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +64 -14
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +52 -24
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +9 -12
- data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +101 -0
- data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +28 -15
- data/lib/rubocop/cop/layout/parameter_alignment.rb +8 -7
- data/lib/rubocop/cop/layout/redundant_line_break.rb +139 -0
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +60 -40
- data/lib/rubocop/cop/layout/single_line_block_chain.rb +64 -0
- data/lib/rubocop/cop/layout/space_after_colon.rb +11 -9
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +7 -10
- data/lib/rubocop/cop/layout/space_after_not.rb +11 -12
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +47 -54
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +20 -23
- data/lib/rubocop/cop/layout/space_around_keyword.rb +54 -30
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
- data/lib/rubocop/cop/layout/space_around_operators.rb +61 -28
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +43 -25
- data/lib/rubocop/cop/layout/space_before_brackets.rb +73 -0
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +11 -12
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +13 -15
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +17 -21
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +50 -55
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +8 -15
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +63 -50
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +52 -44
- data/lib/rubocop/cop/layout/space_inside_parens.rb +92 -29
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +38 -9
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +9 -18
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +25 -32
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +13 -14
- data/lib/rubocop/cop/layout/trailing_empty_lines.rb +20 -25
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +73 -19
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +43 -0
- data/lib/rubocop/cop/legacy/corrector.rb +27 -0
- data/lib/rubocop/cop/lint/ambiguous_assignment.rb +54 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +44 -11
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +60 -12
- data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +111 -0
- data/lib/rubocop/cop/lint/ambiguous_range.rb +105 -0
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +44 -7
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +20 -8
- data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -10
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +68 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +30 -5
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +2 -2
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +100 -0
- data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +93 -0
- data/lib/rubocop/cop/lint/debugger.rb +76 -26
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +109 -52
- data/lib/rubocop/cop/lint/deprecated_constants.rb +88 -0
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +154 -0
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +32 -3
- data/lib/rubocop/cop/lint/duplicate_branch.rb +153 -0
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +4 -14
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/duplicate_hash_key.rb +3 -5
- data/lib/rubocop/cop/lint/duplicate_magic_comment.rb +73 -0
- data/lib/rubocop/cop/lint/duplicate_methods.rb +63 -34
- data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +96 -0
- data/lib/rubocop/cop/lint/duplicate_require.rb +56 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +5 -3
- data/lib/rubocop/cop/lint/else_layout.rb +37 -9
- data/lib/rubocop/cop/lint/empty_block.rb +94 -0
- data/lib/rubocop/cop/lint/empty_class.rb +95 -0
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +175 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +6 -8
- data/lib/rubocop/cop/lint/empty_expression.rb +3 -3
- data/lib/rubocop/cop/lint/empty_file.rb +48 -0
- data/lib/rubocop/cop/lint/empty_in_pattern.rb +64 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +5 -8
- data/lib/rubocop/cop/lint/empty_when.rb +34 -9
- data/lib/rubocop/cop/lint/ensure_return.rb +29 -16
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +28 -30
- data/lib/rubocop/cop/lint/flip_flop.rb +9 -3
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +3 -4
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +45 -10
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +47 -0
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +15 -17
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +8 -8
- data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +79 -0
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +15 -21
- data/lib/rubocop/cop/lint/inherit_exception.rb +32 -36
- data/lib/rubocop/cop/lint/interpolation_check.rb +28 -9
- data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +51 -0
- data/lib/rubocop/cop/lint/literal_as_condition.rb +43 -17
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +49 -16
- data/lib/rubocop/cop/lint/loop.rb +32 -9
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +51 -24
- data/lib/rubocop/cop/lint/missing_super.rb +101 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +36 -0
- data/lib/rubocop/cop/lint/multiple_comparison.rb +15 -15
- data/lib/rubocop/cop/lint/nested_method_definition.rb +71 -26
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +19 -7
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +26 -6
- data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
- data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +162 -0
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +112 -16
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +13 -10
- data/lib/rubocop/cop/lint/number_conversion.rb +137 -27
- data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +47 -0
- data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +40 -0
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +16 -20
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +132 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +42 -14
- data/lib/rubocop/cop/lint/percent_string_array.rb +18 -13
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -15
- data/lib/rubocop/cop/lint/raise_exception.rb +91 -0
- data/lib/rubocop/cop/lint/rand_one.rb +6 -5
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +180 -119
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +46 -32
- data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +62 -0
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +45 -15
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +91 -0
- data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +73 -36
- data/lib/rubocop/cop/lint/redundant_string_coercion.rb +9 -16
- data/lib/rubocop/cop/lint/redundant_with_index.rb +26 -28
- data/lib/rubocop/cop/lint/redundant_with_object.rb +25 -29
- data/lib/rubocop/cop/lint/refinement_import_methods.rb +51 -0
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +13 -5
- data/lib/rubocop/cop/lint/require_parentheses.rb +8 -8
- data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
- data/lib/rubocop/cop/lint/require_relative_self_path.rb +50 -0
- data/lib/rubocop/cop/lint/rescue_exception.rb +3 -4
- data/lib/rubocop/cop/lint/rescue_type.rb +10 -16
- data/lib/rubocop/cop/lint/return_in_void_context.rb +7 -22
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +48 -15
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +16 -18
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +13 -5
- data/lib/rubocop/cop/lint/script_permission.rb +11 -8
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +14 -21
- data/lib/rubocop/cop/lint/shadowed_argument.rb +10 -16
- data/lib/rubocop/cop/lint/shadowed_exception.rb +34 -41
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +56 -7
- data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
- data/lib/rubocop/cop/lint/suppressed_exception.rb +55 -18
- data/lib/rubocop/cop/lint/symbol_conversion.rb +179 -0
- data/lib/rubocop/cop/lint/syntax.rb +10 -30
- data/lib/rubocop/cop/lint/to_enum_arguments.rb +89 -0
- data/lib/rubocop/cop/lint/to_json.rb +22 -14
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +55 -0
- data/lib/rubocop/cop/lint/triple_quotes.rb +71 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +6 -8
- data/lib/rubocop/cop/lint/unexpected_block_arity.rb +90 -0
- data/lib/rubocop/cop/lint/unified_integer.rb +7 -8
- data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +204 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +6 -8
- data/lib/rubocop/cop/lint/unreachable_loop.rb +202 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +19 -12
- data/lib/rubocop/cop/lint/unused_method_argument.rb +48 -13
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +6 -3
- data/lib/rubocop/cop/lint/uri_regexp.rb +13 -48
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +45 -27
- data/lib/rubocop/cop/lint/useless_assignment.rb +11 -15
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +8 -13
- data/lib/rubocop/cop/lint/useless_method_definition.rb +69 -0
- data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +119 -0
- data/lib/rubocop/cop/lint/useless_setter_call.rb +18 -13
- data/lib/rubocop/cop/lint/useless_times.rb +114 -0
- data/lib/rubocop/cop/lint/void.rb +16 -25
- data/lib/rubocop/cop/message_annotator.rb +5 -4
- data/lib/rubocop/cop/metrics/abc_size.rb +35 -3
- data/lib/rubocop/cop/metrics/block_length.rb +47 -11
- data/lib/rubocop/cop/metrics/block_nesting.rb +6 -11
- data/lib/rubocop/cop/metrics/class_length.rb +46 -12
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +30 -7
- data/lib/rubocop/cop/metrics/method_length.rb +41 -6
- data/lib/rubocop/cop/metrics/module_length.rb +35 -10
- data/lib/rubocop/cop/metrics/parameter_lists.rb +79 -13
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +8 -10
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +76 -16
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +182 -0
- data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
- data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +143 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
- data/lib/rubocop/cop/migration/department_name.rb +39 -30
- data/lib/rubocop/cop/mixin/alignment.rb +18 -11
- data/lib/rubocop/cop/mixin/allowed_identifiers.rb +18 -0
- data/lib/rubocop/cop/mixin/allowed_methods.rb +40 -0
- data/lib/rubocop/cop/mixin/allowed_pattern.rb +56 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +58 -23
- data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +56 -19
- data/lib/rubocop/cop/mixin/code_length.rb +30 -9
- data/lib/rubocop/cop/mixin/comments_help.rb +80 -0
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +24 -14
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +4 -11
- data/lib/rubocop/cop/mixin/configurable_max.rb +1 -0
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
- data/lib/rubocop/cop/mixin/def_node.rb +4 -11
- data/lib/rubocop/cop/mixin/documentation_comment.rb +9 -9
- data/lib/rubocop/cop/mixin/duplication.rb +1 -1
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +14 -14
- data/lib/rubocop/cop/mixin/empty_parameter.rb +2 -1
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +17 -4
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +22 -8
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +14 -10
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +41 -6
- data/lib/rubocop/cop/mixin/gem_declaration.rb +13 -0
- data/lib/rubocop/cop/mixin/gemspec_help.rb +30 -0
- data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +20 -11
- data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +187 -0
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +58 -38
- data/lib/rubocop/cop/mixin/heredoc.rb +5 -0
- data/lib/rubocop/cop/mixin/interpolation.rb +1 -3
- data/lib/rubocop/cop/mixin/line_length_help.rb +35 -15
- data/lib/rubocop/cop/mixin/match_range.rb +2 -5
- data/lib/rubocop/cop/mixin/method_complexity.rb +27 -10
- data/lib/rubocop/cop/mixin/method_preference.rb +1 -2
- data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +39 -16
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +6 -4
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +18 -46
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +15 -15
- data/lib/rubocop/cop/mixin/negative_conditional.rb +6 -4
- data/lib/rubocop/cop/mixin/nil_methods.rb +3 -5
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +16 -6
- data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +85 -12
- data/lib/rubocop/cop/mixin/percent_literal.rb +0 -6
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +16 -14
- data/lib/rubocop/cop/mixin/preferred_delimiters.rb +6 -9
- data/lib/rubocop/cop/mixin/range_help.rb +55 -18
- data/lib/rubocop/cop/mixin/rational_literal.rb +1 -0
- data/lib/rubocop/cop/mixin/require_library.rb +61 -0
- data/lib/rubocop/cop/mixin/rescue_node.rb +15 -7
- data/lib/rubocop/cop/mixin/safe_assignment.rb +6 -2
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +6 -7
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +7 -7
- data/lib/rubocop/cop/mixin/statement_modifier.rb +59 -22
- data/lib/rubocop/cop/mixin/string_help.rb +5 -2
- data/lib/rubocop/cop/mixin/string_literals_help.rb +3 -5
- data/lib/rubocop/cop/mixin/surrounding_space.rb +28 -40
- data/lib/rubocop/cop/mixin/symbol_help.rb +13 -0
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
- data/lib/rubocop/cop/mixin/trailing_body.rb +2 -3
- data/lib/rubocop/cop/mixin/trailing_comma.rb +14 -19
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +25 -32
- data/lib/rubocop/cop/mixin/unused_argument.rb +5 -9
- data/lib/rubocop/cop/mixin/visibility_help.rb +72 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +22 -4
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -11
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +18 -8
- data/lib/rubocop/cop/naming/block_forwarding.rb +121 -0
- data/lib/rubocop/cop/naming/block_parameter_name.rb +4 -4
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +16 -4
- data/lib/rubocop/cop/naming/constant_name.rb +9 -6
- data/lib/rubocop/cop/naming/file_name.rb +74 -39
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +13 -7
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +5 -5
- data/lib/rubocop/cop/naming/inclusive_language.rb +270 -0
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +136 -27
- data/lib/rubocop/cop/naming/method_name.rb +35 -7
- data/lib/rubocop/cop/naming/method_parameter_name.rb +4 -4
- data/lib/rubocop/cop/naming/predicate_name.rb +42 -16
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +67 -16
- data/lib/rubocop/cop/naming/variable_name.rb +13 -2
- data/lib/rubocop/cop/naming/variable_number.rb +107 -12
- data/lib/rubocop/cop/offense.rb +35 -12
- data/lib/rubocop/cop/registry.rb +128 -36
- data/lib/rubocop/cop/security/compound_hash.rb +106 -0
- data/lib/rubocop/cop/security/eval.rb +5 -3
- data/lib/rubocop/cop/security/io_methods.rb +49 -0
- data/lib/rubocop/cop/security/json_load.rb +17 -16
- data/lib/rubocop/cop/security/marshal_load.rb +5 -5
- data/lib/rubocop/cop/security/open.rb +29 -11
- data/lib/rubocop/cop/security/yaml_load.rb +22 -10
- data/lib/rubocop/cop/severity.rb +4 -14
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +110 -12
- data/lib/rubocop/cop/style/accessor_grouping.rb +154 -0
- data/lib/rubocop/cop/style/alias.rb +55 -46
- data/lib/rubocop/cop/style/and_or.rb +42 -30
- data/lib/rubocop/cop/style/arguments_forwarding.rb +154 -0
- data/lib/rubocop/cop/style/array_coercion.rb +87 -0
- data/lib/rubocop/cop/style/array_intersect.rb +111 -0
- data/lib/rubocop/cop/style/array_join.rb +9 -9
- data/lib/rubocop/cop/style/ascii_comments.rb +7 -11
- data/lib/rubocop/cop/style/attr.rb +16 -16
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +10 -13
- data/lib/rubocop/cop/style/bare_percent_literals.rb +13 -15
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +60 -0
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +125 -0
- data/lib/rubocop/cop/style/block_comments.rb +15 -19
- data/lib/rubocop/cop/style/block_delimiters.rb +105 -39
- data/lib/rubocop/cop/style/case_equality.rb +84 -6
- data/lib/rubocop/cop/style/case_like_if.rb +263 -0
- data/lib/rubocop/cop/style/character_literal.rb +20 -16
- data/lib/rubocop/cop/style/class_and_module_children.rb +71 -29
- data/lib/rubocop/cop/style/class_check.rb +7 -12
- data/lib/rubocop/cop/style/class_equality_comparison.rb +116 -0
- data/lib/rubocop/cop/style/class_methods.rb +9 -15
- data/lib/rubocop/cop/style/class_methods_definitions.rb +158 -0
- data/lib/rubocop/cop/style/class_vars.rb +24 -8
- data/lib/rubocop/cop/style/collection_compact.rb +120 -0
- data/lib/rubocop/cop/style/collection_methods.rb +34 -21
- data/lib/rubocop/cop/style/colon_method_call.rb +8 -10
- data/lib/rubocop/cop/style/colon_method_definition.rb +7 -7
- data/lib/rubocop/cop/style/combinable_loops.rb +95 -0
- data/lib/rubocop/cop/style/command_literal.rb +23 -29
- data/lib/rubocop/cop/style/comment_annotation.rb +69 -36
- data/lib/rubocop/cop/style/commented_keyword.rb +42 -23
- data/lib/rubocop/cop/style/concat_array_literals.rb +86 -0
- data/lib/rubocop/cop/style/conditional_assignment.rb +94 -95
- data/lib/rubocop/cop/style/constant_visibility.rb +32 -3
- data/lib/rubocop/cop/style/copyright.rb +21 -24
- data/lib/rubocop/cop/style/date_time.rb +22 -6
- data/lib/rubocop/cop/style/def_with_parentheses.rb +22 -20
- data/lib/rubocop/cop/style/dir.rb +15 -13
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +87 -0
- data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
- data/lib/rubocop/cop/style/documentation.rb +117 -22
- data/lib/rubocop/cop/style/documentation_method.rb +3 -2
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +7 -16
- data/lib/rubocop/cop/style/double_negation.rb +134 -10
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +48 -16
- data/lib/rubocop/cop/style/each_with_object.rb +53 -24
- data/lib/rubocop/cop/style/empty_block_parameter.rb +11 -12
- data/lib/rubocop/cop/style/empty_case_condition.rb +32 -27
- data/lib/rubocop/cop/style/empty_else.rb +54 -25
- data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +11 -12
- data/lib/rubocop/cop/style/empty_literal.rb +48 -33
- data/lib/rubocop/cop/style/empty_method.rb +29 -25
- data/lib/rubocop/cop/style/encoding.rb +30 -23
- data/lib/rubocop/cop/style/end_block.rb +8 -5
- data/lib/rubocop/cop/style/endless_method.rb +101 -0
- data/lib/rubocop/cop/style/env_home.rb +56 -0
- data/lib/rubocop/cop/style/eval_with_location.rb +143 -54
- data/lib/rubocop/cop/style/even_odd.rb +10 -12
- data/lib/rubocop/cop/style/expand_path_arguments.rb +28 -26
- data/lib/rubocop/cop/style/explicit_block_argument.rb +153 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +116 -0
- data/lib/rubocop/cop/style/fetch_env_var.rb +132 -0
- data/lib/rubocop/cop/style/file_read.rb +112 -0
- data/lib/rubocop/cop/style/file_write.rb +136 -0
- data/lib/rubocop/cop/style/float_division.rb +69 -12
- data/lib/rubocop/cop/style/for.rb +13 -13
- data/lib/rubocop/cop/style/format_string.rb +31 -25
- data/lib/rubocop/cop/style/format_string_token.rb +138 -31
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +35 -54
- data/lib/rubocop/cop/style/global_std_stream.rb +70 -0
- data/lib/rubocop/cop/style/global_vars.rb +3 -3
- data/lib/rubocop/cop/style/guard_clause.rb +186 -33
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +100 -0
- data/lib/rubocop/cop/style/hash_conversion.rb +134 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +61 -16
- data/lib/rubocop/cop/style/hash_except.rb +177 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +77 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +106 -45
- data/lib/rubocop/cop/style/hash_transform_keys.rb +31 -15
- data/lib/rubocop/cop/style/hash_transform_values.rb +29 -15
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +106 -11
- data/lib/rubocop/cop/style/if_inside_else.rb +65 -2
- data/lib/rubocop/cop/style/if_unless_modifier.rb +81 -51
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
- data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +161 -0
- data/lib/rubocop/cop/style/if_with_semicolon.rb +51 -3
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +6 -4
- data/lib/rubocop/cop/style/in_pattern_then.rb +56 -0
- data/lib/rubocop/cop/style/infinite_loop.rb +28 -26
- data/lib/rubocop/cop/style/inline_comment.rb +5 -5
- data/lib/rubocop/cop/style/inverse_methods.rb +55 -52
- data/lib/rubocop/cop/style/ip_addresses.rb +4 -5
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +75 -0
- data/lib/rubocop/cop/style/lambda.rb +12 -18
- data/lib/rubocop/cop/style/lambda_call.rb +20 -45
- data/lib/rubocop/cop/style/line_end_concatenation.rb +40 -28
- data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
- data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
- data/lib/rubocop/cop/style/map_to_hash.rb +68 -0
- data/lib/rubocop/cop/style/map_to_set.rb +61 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +91 -39
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +12 -18
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +76 -25
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +39 -15
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +17 -7
- data/lib/rubocop/cop/style/method_def_parentheses.rb +43 -29
- data/lib/rubocop/cop/style/min_max.rb +11 -15
- data/lib/rubocop/cop/style/min_max_comparison.rb +73 -0
- data/lib/rubocop/cop/style/missing_else.rb +44 -49
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +12 -6
- data/lib/rubocop/cop/style/mixin_grouping.rb +29 -42
- data/lib/rubocop/cop/style/mixin_usage.rb +13 -31
- data/lib/rubocop/cop/style/module_function.rb +99 -33
- data/lib/rubocop/cop/style/multiline_block_chain.rb +17 -7
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +6 -13
- data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
- data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +60 -0
- data/lib/rubocop/cop/style/multiline_memoization.rb +16 -14
- data/lib/rubocop/cop/style/multiline_method_signature.rb +34 -4
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +59 -12
- data/lib/rubocop/cop/style/multiline_when_then.rb +24 -19
- data/lib/rubocop/cop/style/multiple_comparison.rb +78 -13
- data/lib/rubocop/cop/style/mutable_constant.rb +117 -44
- data/lib/rubocop/cop/style/negated_if.rb +10 -11
- data/lib/rubocop/cop/style/negated_if_else_condition.rb +134 -0
- data/lib/rubocop/cop/style/negated_unless.rb +10 -11
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_file_dirname.rb +66 -0
- data/lib/rubocop/cop/style/nested_modifier.rb +11 -18
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +33 -21
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +43 -5
- data/lib/rubocop/cop/style/next.rb +20 -31
- data/lib/rubocop/cop/style/nil_comparison.rb +20 -12
- data/lib/rubocop/cop/style/nil_lambda.rb +70 -0
- data/lib/rubocop/cop/style/non_nil_check.rb +57 -35
- data/lib/rubocop/cop/style/not.rb +23 -29
- data/lib/rubocop/cop/style/numbered_parameters.rb +46 -0
- data/lib/rubocop/cop/style/numbered_parameters_limit.rb +50 -0
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +7 -12
- data/lib/rubocop/cop/style/numeric_literals.rb +44 -29
- data/lib/rubocop/cop/style/numeric_predicate.rb +72 -33
- data/lib/rubocop/cop/style/object_then.rb +74 -0
- data/lib/rubocop/cop/style/one_line_conditional.rb +56 -31
- data/lib/rubocop/cop/style/open_struct_use.rb +69 -0
- data/lib/rubocop/cop/style/operator_method_call.rb +53 -0
- data/lib/rubocop/cop/style/option_hash.rb +4 -5
- data/lib/rubocop/cop/style/optional_arguments.rb +9 -8
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +64 -0
- data/lib/rubocop/cop/style/or_assignment.rb +12 -11
- data/lib/rubocop/cop/style/parallel_assignment.rb +28 -25
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +20 -9
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +17 -25
- data/lib/rubocop/cop/style/percent_q_literals.rb +12 -15
- data/lib/rubocop/cop/style/perl_backrefs.rb +106 -17
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +21 -22
- data/lib/rubocop/cop/style/proc.rb +10 -7
- data/lib/rubocop/cop/style/quoted_symbols.rb +124 -0
- data/lib/rubocop/cop/style/raise_args.rb +49 -39
- data/lib/rubocop/cop/style/random_with_offset.rb +31 -36
- data/lib/rubocop/cop/style/redundant_argument.rb +98 -0
- data/lib/rubocop/cop/style/redundant_assignment.rb +106 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +113 -12
- data/lib/rubocop/cop/style/redundant_capital_w.rb +9 -14
- data/lib/rubocop/cop/style/redundant_condition.rb +169 -26
- data/lib/rubocop/cop/style/redundant_conditional.rb +15 -16
- data/lib/rubocop/cop/style/redundant_constant_base.rb +85 -0
- data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +39 -0
- data/lib/rubocop/cop/style/redundant_each.rb +116 -0
- data/lib/rubocop/cop/style/redundant_exception.rb +23 -18
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +119 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +61 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +16 -14
- data/lib/rubocop/cop/style/redundant_initialize.rb +156 -0
- data/lib/rubocop/cop/style/redundant_interpolation.rb +70 -30
- data/lib/rubocop/cop/style/redundant_parentheses.rb +68 -57
- data/lib/rubocop/cop/style/redundant_percent_q.rb +17 -21
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +120 -0
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +127 -0
- data/lib/rubocop/cop/style/redundant_return.rb +37 -30
- data/lib/rubocop/cop/style/redundant_self.rb +60 -28
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +118 -0
- data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +83 -0
- data/lib/rubocop/cop/style/redundant_sort.rb +84 -41
- data/lib/rubocop/cop/style/redundant_sort_by.rb +27 -14
- data/lib/rubocop/cop/style/redundant_string_escape.rb +184 -0
- data/lib/rubocop/cop/style/regexp_literal.rb +26 -32
- data/lib/rubocop/cop/style/require_order.rb +142 -0
- data/lib/rubocop/cop/style/rescue_modifier.rb +41 -14
- data/lib/rubocop/cop/style/rescue_standard_error.rb +36 -34
- data/lib/rubocop/cop/style/return_nil.rb +15 -9
- data/lib/rubocop/cop/style/safe_navigation.rb +107 -56
- data/lib/rubocop/cop/style/sample.rb +18 -17
- data/lib/rubocop/cop/style/select_by_regexp.rb +152 -0
- data/lib/rubocop/cop/style/self_assignment.rb +27 -23
- data/lib/rubocop/cop/style/semicolon.rb +65 -32
- data/lib/rubocop/cop/style/send.rb +6 -8
- data/lib/rubocop/cop/style/signal_exception.rb +39 -32
- data/lib/rubocop/cop/style/single_argument_dig.rb +65 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +39 -15
- data/lib/rubocop/cop/style/single_line_methods.rb +82 -20
- data/lib/rubocop/cop/style/slicing_with_range.rb +51 -0
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +248 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +107 -57
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +18 -25
- data/lib/rubocop/cop/style/static_class.rb +128 -0
- data/lib/rubocop/cop/style/stderr_puts.rb +10 -14
- data/lib/rubocop/cop/style/string_chars.rb +41 -0
- data/lib/rubocop/cop/style/string_concatenation.rb +178 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +13 -8
- data/lib/rubocop/cop/style/string_literals.rb +20 -20
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +6 -4
- data/lib/rubocop/cop/style/string_methods.rb +8 -18
- data/lib/rubocop/cop/style/strip.rb +11 -15
- data/lib/rubocop/cop/style/struct_inheritance.rb +38 -5
- data/lib/rubocop/cop/style/swap_values.rb +112 -0
- data/lib/rubocop/cop/style/symbol_array.rb +20 -26
- data/lib/rubocop/cop/style/symbol_literal.rb +6 -10
- data/lib/rubocop/cop/style/symbol_proc.rb +135 -35
- data/lib/rubocop/cop/style/ternary_parentheses.rb +47 -51
- data/lib/rubocop/cop/style/top_level_method_definition.rb +85 -0
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +11 -10
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +4 -7
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +42 -10
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +44 -6
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +105 -0
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +47 -6
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +10 -39
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +17 -32
- data/lib/rubocop/cop/style/trivial_accessors.rb +111 -48
- data/lib/rubocop/cop/style/unless_else.rb +10 -10
- data/lib/rubocop/cop/style/unless_logical_operators.rb +105 -0
- data/lib/rubocop/cop/style/unpack_first.rb +8 -11
- data/lib/rubocop/cop/style/variable_interpolation.rb +9 -12
- data/lib/rubocop/cop/style/when_then.rb +7 -7
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +16 -24
- data/lib/rubocop/cop/style/word_array.rb +67 -26
- data/lib/rubocop/cop/style/yoda_condition.rb +41 -25
- data/lib/rubocop/cop/style/yoda_expression.rb +74 -0
- data/lib/rubocop/cop/style/zero_length_predicate.rb +56 -31
- data/lib/rubocop/cop/team.rb +147 -85
- data/lib/rubocop/cop/util.rb +97 -30
- data/lib/rubocop/cop/utils/format_string.rb +22 -9
- data/lib/rubocop/cop/variable_force/assignment.rb +3 -3
- data/lib/rubocop/cop/variable_force/branch.rb +19 -10
- data/lib/rubocop/cop/variable_force/reference.rb +1 -3
- data/lib/rubocop/cop/variable_force/scope.rb +6 -9
- data/lib/rubocop/cop/variable_force/variable.rb +9 -12
- data/lib/rubocop/cop/variable_force/variable_table.rb +2 -2
- data/lib/rubocop/cop/variable_force.rb +28 -59
- data/lib/rubocop/cops_documentation_generator.rb +322 -0
- data/lib/rubocop/core_ext/string.rb +2 -2
- data/lib/rubocop/directive_comment.rb +144 -0
- data/lib/rubocop/error.rb +1 -0
- data/lib/rubocop/ext/processed_source.rb +20 -0
- data/lib/rubocop/ext/range.rb +15 -0
- data/lib/rubocop/ext/regexp_node.rb +87 -0
- data/lib/rubocop/ext/regexp_parser.rb +92 -0
- data/lib/rubocop/feature_loader.rb +94 -0
- data/lib/rubocop/file_finder.rb +12 -13
- data/lib/rubocop/file_patterns.rb +43 -0
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/base_formatter.rb +0 -4
- data/lib/rubocop/formatter/clang_style_formatter.rb +6 -4
- data/lib/rubocop/formatter/disabled_config_formatter.rb +82 -39
- data/lib/rubocop/formatter/emacs_style_formatter.rb +2 -0
- data/lib/rubocop/formatter/formatter_set.rb +24 -23
- data/lib/rubocop/formatter/git_hub_actions_formatter.rb +57 -0
- data/lib/rubocop/formatter/html_formatter.rb +17 -26
- data/lib/rubocop/formatter/json_formatter.rb +5 -6
- data/lib/rubocop/formatter/junit_formatter.rb +45 -15
- data/lib/rubocop/formatter/markdown_formatter.rb +78 -0
- data/lib/rubocop/formatter/offense_count_formatter.rb +17 -8
- data/lib/rubocop/formatter/pacman_formatter.rb +1 -1
- data/lib/rubocop/formatter/progress_formatter.rb +3 -4
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +42 -8
- data/lib/rubocop/formatter/tap_formatter.rb +8 -4
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +8 -6
- data/lib/rubocop/formatter.rb +35 -0
- data/lib/rubocop/lockfile.rb +40 -0
- data/lib/rubocop/magic_comment.rb +101 -17
- data/lib/rubocop/name_similarity.rb +18 -10
- data/lib/rubocop/options.rb +335 -188
- data/lib/rubocop/path_util.rb +58 -37
- data/lib/rubocop/platform.rb +1 -1
- data/lib/rubocop/rake_task.rb +43 -17
- data/lib/rubocop/remote_config.rb +17 -15
- data/lib/rubocop/result_cache.rb +74 -44
- data/lib/rubocop/rspec/cop_helper.rb +36 -37
- data/lib/rubocop/rspec/expect_offense.rb +134 -41
- data/lib/rubocop/rspec/parallel_formatter.rb +90 -0
- data/lib/rubocop/rspec/shared_contexts.rb +115 -36
- data/lib/rubocop/rspec/support.rb +16 -1
- data/lib/rubocop/runner.rb +172 -91
- data/lib/rubocop/server/cache.rb +148 -0
- data/lib/rubocop/server/cli.rb +128 -0
- data/lib/rubocop/server/client_command/base.rb +44 -0
- data/lib/rubocop/server/client_command/exec.rb +64 -0
- data/lib/rubocop/server/client_command/restart.rb +25 -0
- data/lib/rubocop/server/client_command/start.rb +43 -0
- data/lib/rubocop/server/client_command/status.rb +28 -0
- data/lib/rubocop/server/client_command/stop.rb +31 -0
- data/lib/rubocop/server/client_command.rb +26 -0
- data/lib/rubocop/server/core.rb +96 -0
- data/lib/rubocop/server/errors.rb +23 -0
- data/lib/rubocop/server/helper.rb +34 -0
- data/lib/rubocop/server/server_command/base.rb +50 -0
- data/lib/rubocop/server/server_command/exec.rb +34 -0
- data/lib/rubocop/server/server_command/stop.rb +24 -0
- data/lib/rubocop/server/server_command.rb +21 -0
- data/lib/rubocop/server/socket_reader.rb +69 -0
- data/lib/rubocop/server.rb +53 -0
- data/lib/rubocop/string_interpreter.rb +7 -4
- data/lib/rubocop/target_finder.rb +58 -48
- data/lib/rubocop/target_ruby.rb +135 -15
- data/lib/rubocop/util.rb +16 -0
- data/lib/rubocop/version.rb +84 -7
- data/lib/rubocop/yaml_duplication_checker.rb +2 -1
- data/lib/rubocop.rb +213 -103
- metadata +307 -91
- data/bin/console +0 -10
- data/bin/setup +0 -7
- data/lib/rubocop/ast/builder.rb +0 -83
- data/lib/rubocop/ast/node/alias_node.rb +0 -24
- data/lib/rubocop/ast/node/and_node.rb +0 -29
- data/lib/rubocop/ast/node/args_node.rb +0 -29
- data/lib/rubocop/ast/node/array_node.rb +0 -57
- data/lib/rubocop/ast/node/block_node.rb +0 -117
- data/lib/rubocop/ast/node/break_node.rb +0 -17
- data/lib/rubocop/ast/node/case_node.rb +0 -56
- data/lib/rubocop/ast/node/class_node.rb +0 -31
- data/lib/rubocop/ast/node/def_node.rb +0 -82
- data/lib/rubocop/ast/node/defined_node.rb +0 -17
- data/lib/rubocop/ast/node/ensure_node.rb +0 -17
- data/lib/rubocop/ast/node/float_node.rb +0 -12
- data/lib/rubocop/ast/node/for_node.rb +0 -53
- data/lib/rubocop/ast/node/forward_args_node.rb +0 -18
- data/lib/rubocop/ast/node/hash_node.rb +0 -109
- data/lib/rubocop/ast/node/if_node.rb +0 -175
- data/lib/rubocop/ast/node/int_node.rb +0 -12
- data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
- data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -261
- data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
- data/lib/rubocop/ast/node/mixin/numeric_node.rb +0 -21
- data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
- data/lib/rubocop/ast/node/module_node.rb +0 -24
- data/lib/rubocop/ast/node/or_node.rb +0 -29
- data/lib/rubocop/ast/node/pair_node.rb +0 -63
- data/lib/rubocop/ast/node/range_node.rb +0 -18
- data/lib/rubocop/ast/node/regexp_node.rb +0 -33
- data/lib/rubocop/ast/node/resbody_node.rb +0 -24
- data/lib/rubocop/ast/node/retry_node.rb +0 -17
- data/lib/rubocop/ast/node/return_node.rb +0 -24
- data/lib/rubocop/ast/node/self_class_node.rb +0 -24
- data/lib/rubocop/ast/node/send_node.rb +0 -13
- data/lib/rubocop/ast/node/str_node.rb +0 -16
- data/lib/rubocop/ast/node/super_node.rb +0 -21
- data/lib/rubocop/ast/node/symbol_node.rb +0 -12
- data/lib/rubocop/ast/node/until_node.rb +0 -35
- data/lib/rubocop/ast/node/when_node.rb +0 -53
- data/lib/rubocop/ast/node/while_node.rb +0 -35
- data/lib/rubocop/ast/node/yield_node.rb +0 -21
- data/lib/rubocop/ast/node.rb +0 -632
- data/lib/rubocop/ast/sexp.rb +0 -16
- data/lib/rubocop/ast/traversal.rb +0 -200
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +0 -105
- data/lib/rubocop/cop/layout/tab.rb +0 -75
- data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -19
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +0 -29
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
- data/lib/rubocop/node_pattern.rb +0 -887
- data/lib/rubocop/processed_source.rb +0 -216
- data/lib/rubocop/string_util.rb +0 -14
- data/lib/rubocop/token.rb +0 -114
@@ -0,0 +1,40 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Lint
|
6
|
+
# Checks for unintended or-assignment to a constant.
|
7
|
+
#
|
8
|
+
# Constants should always be assigned in the same location. And its value
|
9
|
+
# should always be the same. If constants are assigned in multiple
|
10
|
+
# locations, the result may vary depending on the order of `require`.
|
11
|
+
#
|
12
|
+
# @safety
|
13
|
+
# This cop is unsafe because code that is already conditionally
|
14
|
+
# assigning a constant may have its behavior changed by autocorrection.
|
15
|
+
#
|
16
|
+
# @example
|
17
|
+
#
|
18
|
+
# # bad
|
19
|
+
# CONST ||= 1
|
20
|
+
#
|
21
|
+
# # good
|
22
|
+
# CONST = 1
|
23
|
+
#
|
24
|
+
class OrAssignmentToConstant < Base
|
25
|
+
extend AutoCorrector
|
26
|
+
|
27
|
+
MSG = 'Avoid using or-assignment with constants.'
|
28
|
+
|
29
|
+
def on_or_asgn(node)
|
30
|
+
lhs, _rhs = *node
|
31
|
+
return unless lhs&.casgn_type?
|
32
|
+
|
33
|
+
add_offense(node.loc.operator) do |corrector|
|
34
|
+
corrector.replace(node.loc.operator, '=')
|
35
|
+
end
|
36
|
+
end
|
37
|
+
end
|
38
|
+
end
|
39
|
+
end
|
40
|
+
end
|
@@ -7,6 +7,9 @@ module RuboCop
|
|
7
7
|
# Checks the proper ordering of magic comments and whether
|
8
8
|
# a magic comment is not placed before a shebang.
|
9
9
|
#
|
10
|
+
# @safety
|
11
|
+
# This cop's autocorrection is unsafe because file encoding may change.
|
12
|
+
#
|
10
13
|
# @example
|
11
14
|
# # bad
|
12
15
|
#
|
@@ -27,13 +30,13 @@ module RuboCop
|
|
27
30
|
# # frozen_string_literal: true
|
28
31
|
# p [''.frozen?, ''.encoding] #=> [true, #<Encoding:US-ASCII>]
|
29
32
|
#
|
30
|
-
class OrderedMagicComments <
|
33
|
+
class OrderedMagicComments < Base
|
31
34
|
include FrozenStringLiteral
|
35
|
+
extend AutoCorrector
|
32
36
|
|
33
|
-
MSG = 'The encoding magic comment should precede all other '
|
34
|
-
'magic comments.'
|
37
|
+
MSG = 'The encoding magic comment should precede all other magic comments.'
|
35
38
|
|
36
|
-
def
|
39
|
+
def on_new_investigation
|
37
40
|
return if processed_source.buffer.source.empty?
|
38
41
|
|
39
42
|
encoding_line, frozen_string_literal_line = magic_comment_lines
|
@@ -43,28 +46,25 @@ module RuboCop
|
|
43
46
|
|
44
47
|
range = processed_source.buffer.line_range(encoding_line + 1)
|
45
48
|
|
46
|
-
add_offense(range
|
49
|
+
add_offense(range) do |corrector|
|
50
|
+
autocorrect(corrector, encoding_line, frozen_string_literal_line)
|
51
|
+
end
|
47
52
|
end
|
48
53
|
|
49
|
-
|
50
|
-
encoding_line, frozen_string_literal_line = magic_comment_lines
|
54
|
+
private
|
51
55
|
|
56
|
+
def autocorrect(corrector, encoding_line, frozen_string_literal_line)
|
52
57
|
range1 = processed_source.buffer.line_range(encoding_line + 1)
|
53
|
-
range2 =
|
54
|
-
processed_source.buffer.line_range(frozen_string_literal_line + 1)
|
58
|
+
range2 = processed_source.buffer.line_range(frozen_string_literal_line + 1)
|
55
59
|
|
56
|
-
|
57
|
-
|
58
|
-
corrector.replace(range2, range1.source)
|
59
|
-
end
|
60
|
+
corrector.replace(range1, range2.source)
|
61
|
+
corrector.replace(range2, range1.source)
|
60
62
|
end
|
61
63
|
|
62
|
-
private
|
63
|
-
|
64
64
|
def magic_comment_lines
|
65
65
|
lines = [nil, nil]
|
66
66
|
|
67
|
-
|
67
|
+
leading_magic_comments.each.with_index do |comment, index|
|
68
68
|
if comment.encoding_specified?
|
69
69
|
lines[0] = index
|
70
70
|
elsif comment.frozen_string_literal_specified?
|
@@ -76,10 +76,6 @@ module RuboCop
|
|
76
76
|
|
77
77
|
lines
|
78
78
|
end
|
79
|
-
|
80
|
-
def magic_comments
|
81
|
-
leading_comment_lines.map { |line| MagicComment.parse(line) }
|
82
|
-
end
|
83
79
|
end
|
84
80
|
end
|
85
81
|
end
|
@@ -0,0 +1,132 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Lint
|
6
|
+
# Looks for references of Regexp captures that are out of range
|
7
|
+
# and thus always returns nil.
|
8
|
+
#
|
9
|
+
# @safety
|
10
|
+
# This cop is unsafe because it is naive in how it determines what
|
11
|
+
# references are available based on the last encountered regexp, but
|
12
|
+
# it cannot handle some cases, such as conditional regexp matches, which
|
13
|
+
# leads to false positives, such as:
|
14
|
+
#
|
15
|
+
# [source,ruby]
|
16
|
+
# ----
|
17
|
+
# foo ? /(c)(b)/ =~ str : /(b)/ =~ str
|
18
|
+
# do_something if $2
|
19
|
+
# # $2 is defined for the first condition but not the second, however
|
20
|
+
# # the cop will mark this as an offense.
|
21
|
+
# ----
|
22
|
+
#
|
23
|
+
# This might be a good indication of code that should be refactored,
|
24
|
+
# however.
|
25
|
+
#
|
26
|
+
# @example
|
27
|
+
#
|
28
|
+
# /(foo)bar/ =~ 'foobar'
|
29
|
+
#
|
30
|
+
# # bad - always returns nil
|
31
|
+
#
|
32
|
+
# puts $2 # => nil
|
33
|
+
#
|
34
|
+
# # good
|
35
|
+
#
|
36
|
+
# puts $1 # => foo
|
37
|
+
#
|
38
|
+
class OutOfRangeRegexpRef < Base
|
39
|
+
MSG = '$%<backref>s is out of range (%<count>s regexp capture %<group>s detected).'
|
40
|
+
|
41
|
+
REGEXP_RECEIVER_METHODS = %i[=~ === match].to_set.freeze
|
42
|
+
REGEXP_ARGUMENT_METHODS = %i[=~ match grep gsub gsub! sub sub! [] slice slice! index rindex
|
43
|
+
scan partition rpartition start_with? end_with?].to_set.freeze
|
44
|
+
REGEXP_CAPTURE_METHODS = (REGEXP_RECEIVER_METHODS + REGEXP_ARGUMENT_METHODS).freeze
|
45
|
+
RESTRICT_ON_SEND = REGEXP_CAPTURE_METHODS
|
46
|
+
|
47
|
+
def on_new_investigation
|
48
|
+
@valid_ref = 0
|
49
|
+
end
|
50
|
+
|
51
|
+
def on_match_with_lvasgn(node)
|
52
|
+
check_regexp(node.children.first)
|
53
|
+
end
|
54
|
+
|
55
|
+
def after_send(node)
|
56
|
+
@valid_ref = nil
|
57
|
+
|
58
|
+
if regexp_first_argument?(node)
|
59
|
+
check_regexp(node.first_argument)
|
60
|
+
elsif regexp_receiver?(node)
|
61
|
+
check_regexp(node.receiver)
|
62
|
+
end
|
63
|
+
end
|
64
|
+
|
65
|
+
def on_when(node)
|
66
|
+
regexp_conditions = node.conditions.select(&:regexp_type?)
|
67
|
+
|
68
|
+
@valid_ref = regexp_conditions.map { |condition| check_regexp(condition) }.compact.max
|
69
|
+
end
|
70
|
+
|
71
|
+
def on_in_pattern(node)
|
72
|
+
regexp_patterns = patterns(node).select(&:regexp_type?)
|
73
|
+
|
74
|
+
@valid_ref = regexp_patterns.map { |pattern| check_regexp(pattern) }.compact.max
|
75
|
+
end
|
76
|
+
|
77
|
+
def on_nth_ref(node)
|
78
|
+
backref, = *node
|
79
|
+
return if @valid_ref.nil? || backref <= @valid_ref
|
80
|
+
|
81
|
+
message = format(
|
82
|
+
MSG,
|
83
|
+
backref: backref,
|
84
|
+
count: @valid_ref.zero? ? 'no' : @valid_ref,
|
85
|
+
group: @valid_ref == 1 ? 'group' : 'groups'
|
86
|
+
)
|
87
|
+
|
88
|
+
add_offense(node, message: message)
|
89
|
+
end
|
90
|
+
|
91
|
+
private
|
92
|
+
|
93
|
+
def patterns(pattern_node)
|
94
|
+
pattern = pattern_node.node_parts[0]
|
95
|
+
|
96
|
+
case pattern.type
|
97
|
+
when :array_pattern, :match_alt
|
98
|
+
pattern.children
|
99
|
+
when :match_as
|
100
|
+
patterns(pattern)
|
101
|
+
else
|
102
|
+
[pattern]
|
103
|
+
end
|
104
|
+
end
|
105
|
+
|
106
|
+
def check_regexp(node)
|
107
|
+
return if node.interpolation?
|
108
|
+
|
109
|
+
named_capture = node.each_capture(named: true).count
|
110
|
+
@valid_ref = if named_capture.positive?
|
111
|
+
named_capture
|
112
|
+
else
|
113
|
+
node.each_capture(named: false).count
|
114
|
+
end
|
115
|
+
end
|
116
|
+
|
117
|
+
def regexp_first_argument?(send_node)
|
118
|
+
send_node.first_argument&.regexp_type? \
|
119
|
+
&& REGEXP_ARGUMENT_METHODS.include?(send_node.method_name)
|
120
|
+
end
|
121
|
+
|
122
|
+
def regexp_receiver?(send_node)
|
123
|
+
send_node.receiver&.regexp_type?
|
124
|
+
end
|
125
|
+
|
126
|
+
def nth_ref_receiver?(send_node)
|
127
|
+
send_node.receiver&.nth_ref_type?
|
128
|
+
end
|
129
|
+
end
|
130
|
+
end
|
131
|
+
end
|
132
|
+
end
|
@@ -9,36 +9,64 @@ module RuboCop
|
|
9
9
|
# @example
|
10
10
|
#
|
11
11
|
# # bad
|
12
|
-
#
|
13
|
-
# puts (x + y)
|
14
|
-
#
|
15
|
-
# @example
|
12
|
+
# do_something (foo)
|
16
13
|
#
|
17
14
|
# # good
|
18
|
-
#
|
19
|
-
#
|
20
|
-
|
15
|
+
# do_something(foo)
|
16
|
+
# do_something (2 + 3) * 4
|
17
|
+
# do_something (foo * bar).baz
|
18
|
+
class ParenthesesAsGroupedExpression < Base
|
21
19
|
include RangeHelp
|
20
|
+
extend AutoCorrector
|
22
21
|
|
23
|
-
MSG = '`
|
22
|
+
MSG = '`%<argument>s` interpreted as grouped expression.'
|
24
23
|
|
25
24
|
def on_send(node)
|
26
|
-
return
|
27
|
-
return if node.operator_method? || node.setter_method?
|
28
|
-
|
29
|
-
return unless node.first_argument.source.start_with?('(')
|
25
|
+
return if valid_context?(node)
|
30
26
|
|
31
27
|
space_length = spaces_before_left_parenthesis(node)
|
32
28
|
return unless space_length.positive?
|
33
29
|
|
34
30
|
range = space_range(node.first_argument.source_range, space_length)
|
31
|
+
message = format(MSG, argument: node.first_argument.source)
|
35
32
|
|
36
|
-
add_offense(
|
33
|
+
add_offense(range, message: message) { |corrector| corrector.remove(range) }
|
37
34
|
end
|
38
35
|
alias on_csend on_send
|
39
36
|
|
40
37
|
private
|
41
38
|
|
39
|
+
def valid_context?(node)
|
40
|
+
unless node.arguments.one? && first_argument_starts_with_left_parenthesis?(node)
|
41
|
+
return true
|
42
|
+
end
|
43
|
+
return true if first_argument_block_type?(node.first_argument)
|
44
|
+
|
45
|
+
node.operator_method? || node.setter_method? || chained_calls?(node) ||
|
46
|
+
valid_first_argument?(node.first_argument)
|
47
|
+
end
|
48
|
+
|
49
|
+
def first_argument_block_type?(first_arg)
|
50
|
+
first_arg.block_type? || first_arg.numblock_type?
|
51
|
+
end
|
52
|
+
|
53
|
+
def valid_first_argument?(first_arg)
|
54
|
+
first_arg.operator_keyword? || first_arg.hash_type? || ternary_expression?(first_arg)
|
55
|
+
end
|
56
|
+
|
57
|
+
def first_argument_starts_with_left_parenthesis?(node)
|
58
|
+
node.first_argument.source.start_with?('(')
|
59
|
+
end
|
60
|
+
|
61
|
+
def chained_calls?(node)
|
62
|
+
first_argument = node.first_argument
|
63
|
+
first_argument.call_type? && (node.children.last&.children&.count || 0) > 1
|
64
|
+
end
|
65
|
+
|
66
|
+
def ternary_expression?(node)
|
67
|
+
node.if_type? && node.ternary?
|
68
|
+
end
|
69
|
+
|
42
70
|
def spaces_before_left_parenthesis(node)
|
43
71
|
receiver = node.receiver
|
44
72
|
receiver_length = if receiver
|
@@ -46,7 +74,7 @@ module RuboCop
|
|
46
74
|
else
|
47
75
|
0
|
48
76
|
end
|
49
|
-
without_receiver = node.source[receiver_length
|
77
|
+
without_receiver = node.source[receiver_length..]
|
50
78
|
|
51
79
|
# Escape question mark if any.
|
52
80
|
method_regexp = Regexp.escape(node.method_name)
|
@@ -3,12 +3,22 @@
|
|
3
3
|
module RuboCop
|
4
4
|
module Cop
|
5
5
|
module Lint
|
6
|
-
#
|
6
|
+
# Checks for quotes and commas in %w, e.g. `%w('foo', "bar")`
|
7
7
|
#
|
8
8
|
# It is more likely that the additional characters are unintended (for
|
9
9
|
# example, mistranslating an array of literals to percent string notation)
|
10
10
|
# rather than meant to be part of the resulting strings.
|
11
11
|
#
|
12
|
+
# @safety
|
13
|
+
# The cop is unsafe because the correction changes the values in the array
|
14
|
+
# and that might have been done purposely.
|
15
|
+
#
|
16
|
+
# [source,ruby]
|
17
|
+
# ----
|
18
|
+
# %w('foo', "bar") #=> ["'foo',", '"bar"']
|
19
|
+
# %w(foo bar) #=> ['foo', 'bar']
|
20
|
+
# ----
|
21
|
+
#
|
12
22
|
# @example
|
13
23
|
#
|
14
24
|
# # bad
|
@@ -20,15 +30,16 @@ module RuboCop
|
|
20
30
|
# # good
|
21
31
|
#
|
22
32
|
# %w(foo bar)
|
23
|
-
class PercentStringArray <
|
33
|
+
class PercentStringArray < Base
|
24
34
|
include PercentLiteral
|
35
|
+
extend AutoCorrector
|
25
36
|
|
26
37
|
QUOTES_AND_COMMAS = [/,$/, /^'.*'$/, /^".*"$/].freeze
|
27
38
|
LEADING_QUOTE = /^['"]/.freeze
|
28
39
|
TRAILING_QUOTE = /['"]?,?$/.freeze
|
29
40
|
|
30
41
|
MSG = "Within `%w`/`%W`, quotes and ',' are unnecessary and may be " \
|
31
|
-
|
42
|
+
'unwanted in the resulting strings.'
|
32
43
|
|
33
44
|
def on_array(node)
|
34
45
|
process(node, '%w', '%W')
|
@@ -37,20 +48,14 @@ module RuboCop
|
|
37
48
|
def on_percent_literal(node)
|
38
49
|
return unless contains_quotes_or_commas?(node)
|
39
50
|
|
40
|
-
add_offense(node)
|
41
|
-
|
42
|
-
|
43
|
-
def autocorrect(node)
|
44
|
-
lambda do |corrector|
|
45
|
-
node.values.each do |value|
|
51
|
+
add_offense(node) do |corrector|
|
52
|
+
node.each_value do |value|
|
46
53
|
range = value.loc.expression
|
47
54
|
|
48
55
|
match = range.source.match(TRAILING_QUOTE)
|
49
56
|
corrector.remove_trailing(range, match[0].length) if match
|
50
57
|
|
51
|
-
if range.source
|
52
|
-
corrector.remove_leading(range, 1)
|
53
|
-
end
|
58
|
+
corrector.remove_leading(range, 1) if LEADING_QUOTE.match?(range.source)
|
54
59
|
end
|
55
60
|
end
|
56
61
|
end
|
@@ -64,7 +69,7 @@ module RuboCop
|
|
64
69
|
# To avoid likely false positives (e.g. a single ' or ")
|
65
70
|
next if literal.gsub(/[^[[:alnum:]]]/, '').empty?
|
66
71
|
|
67
|
-
QUOTES_AND_COMMAS.any? { |pat| literal
|
72
|
+
QUOTES_AND_COMMAS.any? { |pat| literal.match?(pat) }
|
68
73
|
end
|
69
74
|
end
|
70
75
|
end
|
@@ -3,7 +3,7 @@
|
|
3
3
|
module RuboCop
|
4
4
|
module Cop
|
5
5
|
module Lint
|
6
|
-
#
|
6
|
+
# Checks for colons and commas in %i, e.g. `%i(:foo, :bar)`
|
7
7
|
#
|
8
8
|
# It is more likely that the additional characters are unintended (for
|
9
9
|
# example, mistranslating an array of literals to percent string notation)
|
@@ -20,11 +20,12 @@ module RuboCop
|
|
20
20
|
# # good
|
21
21
|
#
|
22
22
|
# %i(foo bar)
|
23
|
-
class PercentSymbolArray <
|
23
|
+
class PercentSymbolArray < Base
|
24
24
|
include PercentLiteral
|
25
|
+
extend AutoCorrector
|
25
26
|
|
26
27
|
MSG = "Within `%i`/`%I`, ':' and ',' are unnecessary and may be " \
|
27
|
-
|
28
|
+
'unwanted in the resulting symbols.'
|
28
29
|
|
29
30
|
def on_array(node)
|
30
31
|
process(node, '%i', '%I')
|
@@ -33,23 +34,21 @@ module RuboCop
|
|
33
34
|
def on_percent_literal(node)
|
34
35
|
return unless contains_colons_or_commas?(node)
|
35
36
|
|
36
|
-
add_offense(node)
|
37
|
+
add_offense(node) { |corrector| autocorrect(corrector, node) }
|
37
38
|
end
|
38
39
|
|
39
|
-
|
40
|
-
|
41
|
-
|
42
|
-
|
40
|
+
private
|
41
|
+
|
42
|
+
def autocorrect(corrector, node)
|
43
|
+
node.children.each do |child|
|
44
|
+
range = child.loc.expression
|
43
45
|
|
44
|
-
|
45
|
-
|
46
|
-
|
47
|
-
end
|
46
|
+
corrector.remove_trailing(range, 1) if range.source.end_with?(',')
|
47
|
+
corrector.remove_leading(range, 1) if
|
48
|
+
range.source.start_with?(':')
|
48
49
|
end
|
49
50
|
end
|
50
51
|
|
51
|
-
private
|
52
|
-
|
53
52
|
def contains_colons_or_commas?(node)
|
54
53
|
node.children.any? do |child|
|
55
54
|
literal = child.children.first.to_s
|
@@ -61,7 +60,7 @@ module RuboCop
|
|
61
60
|
end
|
62
61
|
|
63
62
|
def non_alphanumeric_literal?(literal)
|
64
|
-
|
63
|
+
!/[[:alnum:]]/.match?(literal)
|
65
64
|
end
|
66
65
|
end
|
67
66
|
end
|
@@ -0,0 +1,91 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Lint
|
6
|
+
# Checks for `raise` or `fail` statements which are
|
7
|
+
# raising `Exception` class.
|
8
|
+
#
|
9
|
+
# You can specify a module name that will be an implicit namespace
|
10
|
+
# using `AllowedImplicitNamespaces` option. The cop cause a false positive
|
11
|
+
# for namespaced `Exception` when a namespace is omitted. This option can
|
12
|
+
# prevent the false positive by specifying a namespace to be omitted for
|
13
|
+
# `Exception`. Alternatively, make `Exception` a fully qualified class
|
14
|
+
# name with an explicit namespace.
|
15
|
+
#
|
16
|
+
# @safety
|
17
|
+
# This cop is unsafe because it will change the exception class being
|
18
|
+
# raised, which is a change in behavior.
|
19
|
+
#
|
20
|
+
# @example
|
21
|
+
# # bad
|
22
|
+
# raise Exception, 'Error message here'
|
23
|
+
#
|
24
|
+
# # good
|
25
|
+
# raise StandardError, 'Error message here'
|
26
|
+
#
|
27
|
+
# @example AllowedImplicitNamespaces: ['Gem']
|
28
|
+
# # good
|
29
|
+
# module Gem
|
30
|
+
# def self.foo
|
31
|
+
# raise Exception # This exception means `Gem::Exception`.
|
32
|
+
# end
|
33
|
+
# end
|
34
|
+
class RaiseException < Base
|
35
|
+
extend AutoCorrector
|
36
|
+
|
37
|
+
MSG = 'Use `StandardError` over `Exception`.'
|
38
|
+
RESTRICT_ON_SEND = %i[raise fail].freeze
|
39
|
+
|
40
|
+
# @!method exception?(node)
|
41
|
+
def_node_matcher :exception?, <<~PATTERN
|
42
|
+
(send nil? {:raise :fail} $(const ${cbase nil?} :Exception) ... )
|
43
|
+
PATTERN
|
44
|
+
|
45
|
+
# @!method exception_new_with_message?(node)
|
46
|
+
def_node_matcher :exception_new_with_message?, <<~PATTERN
|
47
|
+
(send nil? {:raise :fail}
|
48
|
+
(send $(const ${cbase nil?} :Exception) :new ... ))
|
49
|
+
PATTERN
|
50
|
+
|
51
|
+
def on_send(node)
|
52
|
+
exception?(node, &check(node)) || exception_new_with_message?(node, &check(node))
|
53
|
+
end
|
54
|
+
|
55
|
+
private
|
56
|
+
|
57
|
+
def check(node)
|
58
|
+
lambda do |exception_class, cbase|
|
59
|
+
return if cbase.nil? && implicit_namespace?(node)
|
60
|
+
|
61
|
+
add_offense(exception_class) do |corrector|
|
62
|
+
prefer_exception = if exception_class.children.first&.cbase_type?
|
63
|
+
'::StandardError'
|
64
|
+
else
|
65
|
+
'StandardError'
|
66
|
+
end
|
67
|
+
|
68
|
+
corrector.replace(exception_class, prefer_exception)
|
69
|
+
end
|
70
|
+
end
|
71
|
+
end
|
72
|
+
|
73
|
+
def implicit_namespace?(node)
|
74
|
+
return false unless (parent = node.parent)
|
75
|
+
|
76
|
+
if parent.module_type?
|
77
|
+
namespace = parent.identifier.source
|
78
|
+
|
79
|
+
return allow_implicit_namespaces.include?(namespace)
|
80
|
+
end
|
81
|
+
|
82
|
+
implicit_namespace?(parent)
|
83
|
+
end
|
84
|
+
|
85
|
+
def allow_implicit_namespaces
|
86
|
+
cop_config['AllowedImplicitNamespaces'] || []
|
87
|
+
end
|
88
|
+
end
|
89
|
+
end
|
90
|
+
end
|
91
|
+
end
|
@@ -3,7 +3,7 @@
|
|
3
3
|
module RuboCop
|
4
4
|
module Cop
|
5
5
|
module Lint
|
6
|
-
#
|
6
|
+
# Checks for `rand(1)` calls.
|
7
7
|
# Such calls always return `0`.
|
8
8
|
#
|
9
9
|
# @example
|
@@ -20,12 +20,13 @@ module RuboCop
|
|
20
20
|
# # good
|
21
21
|
#
|
22
22
|
# 0 # just use 0 instead
|
23
|
-
class RandOne <
|
24
|
-
MSG = '`%<method>s` always returns `0`. '
|
25
|
-
|
23
|
+
class RandOne < Base
|
24
|
+
MSG = '`%<method>s` always returns `0`. Perhaps you meant `rand(2)` or `rand`?'
|
25
|
+
RESTRICT_ON_SEND = %i[rand].freeze
|
26
26
|
|
27
|
+
# @!method rand_one?(node)
|
27
28
|
def_node_matcher :rand_one?, <<~PATTERN
|
28
|
-
(send {(const nil? :Kernel) nil?} :rand {(int {-1 1}) (float {-1.0 1.0})})
|
29
|
+
(send {(const {nil? cbase} :Kernel) nil?} :rand {(int {-1 1}) (float {-1.0 1.0})})
|
29
30
|
PATTERN
|
30
31
|
|
31
32
|
def on_send(node)
|