rubocop 0.28.0 → 0.29.0

data/spec/rubocop/config_loader_spec.rb

@@ -246,6 +246,19 @@ describe RuboCop::ConfigLoader do
           .to be_superset(expected.to_set)
       end
     end
+
+    context 'when a file inherits from an expanded path' do
+      let(:file_path) { '.rubocop.yml' }
+
+      before do
+        create_file('~/.rubocop.yml', [''])
+        create_file(file_path, ['inherit_from: ~/.rubocop.yml'])
+      end
+
+      it 'does not fail to load expanded path' do
+        expect { configuration_from_file }.not_to raise_error
+      end
+    end
   end
 
   describe '.load_file', :isolated_environment do
@@ -266,6 +279,13 @@ describe RuboCop::ConfigLoader do
       )
     end
 
+    it 'fails with a TypeError when loading a malformed configuration file' do
+      create_file(configuration_path, 'This string is not a YAML hash')
+      expect { load_file }.to raise_error(
+        TypeError, /^Malformed configuration in .*\.rubocop\.yml$/
+      )
+    end
+
     it 'returns an empty configuration loaded from an empty file' do
       create_file(configuration_path, '')
       configuration = load_file

data/spec/rubocop/cop/lint/assignment_in_condition_spec.rb

@@ -62,6 +62,14 @@ describe RuboCop::Cop::Lint::AssignmentInCondition, :config do
     expect(cop.offenses.size).to eq(1)
   end
 
+  it 'registers an offense for collection element assignment in condition' do
+    inspect_source(cop,
+                   ['if a[3] = 10',
+                    'end'
+                   ])
+    expect(cop.offenses.size).to eq(1)
+  end
+
   it 'accepts == in condition' do
     inspect_source(cop,
                    ['if test == 10',
@@ -72,13 +80,13 @@ describe RuboCop::Cop::Lint::AssignmentInCondition, :config do
 
   it 'accepts = in a block that is called in a condition' do
     inspect_source(cop,
-                   ['return 1 if any_errors? { o = inspect(file) }'])
+                   'return 1 if any_errors? { o = inspect(file) }')
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts ||= in condition' do
     inspect_source(cop,
-                   ['raise StandardError unless foo ||= bar'])
+                   'raise StandardError unless foo ||= bar')
     expect(cop.offenses).to be_empty
   end
 
@@ -90,17 +98,33 @@ describe RuboCop::Cop::Lint::AssignmentInCondition, :config do
                      ])
       expect(cop.offenses).to be_empty
     end
+
+    it 'accepts []= in condition surrounded with braces' do
+      inspect_source(cop,
+                     ['if (test[0] = 10)',
+                      'end'
+                     ])
+      expect(cop.offenses).to be_empty
+    end
   end
 
   context 'safe assignment is not allowed' do
     let(:cop_config) { { 'AllowSafeAssignment' => false } }
 
-    it 'does not accepts = in condition surrounded with braces' do
+    it 'does not accept = in condition surrounded with braces' do
       inspect_source(cop,
                      ['if (test = 10)',
                       'end'
                      ])
       expect(cop.offenses.size).to eq(1)
     end
+
+    it 'does not accept []= in condition surrounded with braces' do
+      inspect_source(cop,
+                     ['if (test[0] = 10)',
+                      'end'
+                     ])
+      expect(cop.offenses.size).to eq(1)
+    end
   end
 end

data/spec/rubocop/cop/lint/block_alignment_spec.rb

@@ -93,14 +93,14 @@ describe RuboCop::Cop::Lint::BlockAlignment do
       expect(cop.offenses).to be_empty
     end
 
-    it 'auto-corrects alignment to the block start' do
+    it 'auto-corrects alignment to the first variable' do
       new_source = autocorrect_source(cop,
                                       ['a = b = c = test do |ala|',
                                        '    end'
                                       ])
 
       expect(new_source).to eq(['a = b = c = test do |ala|',
-                                '            end'
+                                'end'
                                ].join("\n"))
     end
   end
@@ -424,8 +424,7 @@ describe RuboCop::Cop::Lint::BlockAlignment do
 
   it 'does not raise an error for nested block in a method call' do
     inspect_source(cop,
-                   ['expect(arr.all? { |o| o.valid? })'
-                   ])
+                   'expect(arr.all? { |o| o.valid? })')
     expect(cop.offenses).to be_empty
   end
 

data/spec/rubocop/cop/lint/condition_position_spec.rb

@@ -45,7 +45,7 @@ describe RuboCop::Cop::Lint::ConditionPosition do
   end
 
   it 'handles ternary ops' do
-    inspect_source(cop, ['x ? a : b'])
+    inspect_source(cop, 'x ? a : b')
     expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/lint/debugger_spec.rb

@@ -6,7 +6,7 @@ describe RuboCop::Cop::Lint::Debugger do
   subject(:cop) { described_class.new  }
 
   it 'reports an offense for a debugger call' do
-    src = ['debugger']
+    src = 'debugger'
     inspect_source(cop, src)
     expect(cop.offenses.size).to eq(1)
     expect(cop.messages).to eq(['Remove debugger entry point `debugger`.'])
@@ -14,7 +14,7 @@ describe RuboCop::Cop::Lint::Debugger do
   end
 
   it 'reports an offense for a byebug call' do
-    src = ['byebug']
+    src = 'byebug'
     inspect_source(cop, src)
     expect(cop.offenses.size).to eq(1)
     expect(cop.messages).to eq(['Remove debugger entry point `byebug`.'])
@@ -36,23 +36,36 @@ describe RuboCop::Cop::Lint::Debugger do
                                   'binding.pry_remote'])
   end
 
+  it 'reports an offense for capybara debug methods' do
+    src = %w(save_and_open_page save_and_open_screenshot)
+    inspect_source(cop, src)
+    expect(cop.offenses.size).to eq(2)
+    expect(cop.messages)
+      .to eq(['Remove debugger entry point `save_and_open_page`.',
+              'Remove debugger entry point `save_and_open_screenshot`.'])
+    expect(cop.highlights)
+      .to eq(%w(save_and_open_page save_and_open_screenshot))
+  end
+
   it 'does not report an offense for non-pry binding' do
-    src = ['binding.pirate']
+    src = 'binding.pirate'
     inspect_source(cop, src)
     expect(cop.offenses).to be_empty
   end
 
-  %w(debugger byebug pry remote_pry pry_remote).each do |comment|
+  %w(debugger byebug pry remote_pry pry_remote
+     save_and_open_page save_and_open_screenshot).each do |comment|
     it "does not report an offense for #{comment} in comments" do
-      src = ["# #{comment}"]
+      src = "# #{comment}"
       inspect_source(cop, src)
       expect(cop.offenses).to be_empty
     end
   end
 
-  %w(debugger byebug pry remote_pry pry_remote).each do |method_name|
+  %w(debugger byebug pry remote_pry pry_remote
+     save_and_open_page save_and_open_screenshot).each do |method_name|
     it "does not report an offense for a #{method_name} method" do
-      src = ["code.#{method_name}"]
+      src = "code.#{method_name}"
       inspect_source(cop, src)
       expect(cop.offenses).to be_empty
     end

data/spec/rubocop/cop/lint/duplicate_methods_spec.rb

@@ -0,0 +1,189 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe RuboCop::Cop::Lint::DuplicateMethods do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offense for duplicate method in class' do
+    inspect_source(cop,
+                   ['class A',
+                    '  def some_method',
+                    '    implement 1',
+                    '  end',
+                    '  def some_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.offenses.size).to eq(1)
+  end
+
+  it 'does not register an offense for non-duplicate method in class' do
+    inspect_source(cop,
+                   ['class A',
+                    '  def some_method',
+                    '    implement 1',
+                    '  end',
+                    '  def any_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'registers an offense for duplicate method in module' do
+    inspect_source(cop,
+                   ['module A',
+                    '  def some_method',
+                    '    implement 1',
+                    '  end',
+                    '  def some_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.offenses.size).to eq(1)
+  end
+
+  it 'does not register an offense for non-duplicate method in module' do
+    inspect_source(cop,
+                   ['module A',
+                    '  def some_method',
+                    '    implement 1',
+                    '  end',
+                    '  def any_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'registers an offense for duplicate class methods in module' do
+    inspect_source(cop,
+                   ['module A',
+                    '  def self.some_method',
+                    '    implement 1',
+                    '  end',
+                    '  def self.some_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.offenses.size).to eq(1)
+  end
+  it 'doesn`t registers an offense for non-duplicate class methods in module' do
+    inspect_source(cop,
+                   ['module A',
+                    '  def self.some_method',
+                    '    implement 1',
+                    '  end',
+                    '  def self.any_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.offenses.size).to eq(0)
+  end
+
+  it 'differ instance and class methods in module' do
+    inspect_source(cop,
+                   ['module A',
+                    '  def some_method',
+                    '    implement 1',
+                    '  end',
+                    '  def self.some_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.offenses.size).to eq(0)
+  end
+
+  it %(registers an offense for duplicate private methods in class) do
+    inspect_source(cop,
+                   ['class A',
+                    '  private def some_method',
+                    '    implement 1',
+                    '  end',
+                    '  private def some_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.offenses.size).to eq(1)
+  end
+
+  it %(registers an offense for duplicate private self methods in class) do
+    inspect_source(cop,
+                   ['class A',
+                    '  private def self.some_method',
+                    '    implement 1',
+                    '  end',
+                    '  private def self.some_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.offenses.size).to eq(1)
+  end
+
+  it %(don`t registers an offense for different private methods in class) do
+    inspect_source(cop,
+                   ['class A',
+                    '  private def some_method',
+                    '    implement 1',
+                    '  end',
+                    '  private def any_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.offenses.size).to eq(0)
+  end
+
+  it %(registers an offense for duplicate protected methods in class) do
+    inspect_source(cop,
+                   ['class A',
+                    '  protected def some_method',
+                    '    implement 1',
+                    '  end',
+                    '  protected def some_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.offenses.size).to eq(1)
+  end
+
+  it %(registers 2 offenses for pair of duplicate methods in class) do
+    inspect_source(cop,
+                   ['class A',
+                    '  def some_method',
+                    '    implement 1',
+                    '  end',
+                    '  def some_method',
+                    '    implement 2',
+                    '  end',
+                    '  def any_method',
+                    '    implement 1',
+                    '  end',
+                    '  def any_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.offenses.size).to eq(2)
+  end
+
+  it %(generate 2 offenses with specified messages) do
+    inspect_source(cop,
+                   ['class A',
+                    '  def some_method',
+                    '    implement 1',
+                    '  end',
+                    '  def some_method',
+                    '    implement 2',
+                    '  end',
+                    '  def any_method',
+                    '    implement 1',
+                    '  end',
+                    '  def any_method',
+                    '    implement 2',
+                    '  end',
+                    'end'])
+    expect(cop.messages).to match_array([
+      %(Duplicate methods `some_method` at lines `2, 5` detected.),
+      %(Duplicate methods `any_method` at lines `8, 11` detected.)])
+  end
+end

data/spec/rubocop/cop/lint/empty_interpolation_spec.rb

@@ -6,7 +6,7 @@ describe RuboCop::Cop::Lint::EmptyInterpolation do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for #{} in interpolation' do
-    inspect_source(cop, ['"this is the #{}"'])
+    inspect_source(cop, '"this is the #{}"')
     expect(cop.offenses.size).to eq(1)
     expect(cop.highlights).to eq(['#{}'])
   end

data/spec/rubocop/cop/lint/end_in_method_spec.rb

@@ -22,7 +22,7 @@ describe RuboCop::Cop::Lint::EndInMethod do
   end
 
   it 'accepts END outside of def(s)' do
-    src = ['END { something }']
+    src = 'END { something }'
     inspect_source(cop, src)
     expect(cop.offenses).to be_empty
   end

data/spec/rubocop/cop/lint/eval_spec.rb

@@ -7,27 +7,27 @@ describe RuboCop::Cop::Lint::Eval do
 
   it 'registers an offense for eval as function' do
     inspect_source(cop,
-                   ['eval(something)'])
+                   'eval(something)')
     expect(cop.offenses.size).to eq(1)
     expect(cop.highlights) .to eq(['eval'])
   end
 
   it 'registers an offense for eval as command' do
     inspect_source(cop,
-                   ['eval something'])
+                   'eval something')
     expect(cop.offenses.size).to eq(1)
     expect(cop.highlights) .to eq(['eval'])
   end
 
   it 'does not register an offense for eval as variable' do
     inspect_source(cop,
-                   ['eval = something'])
+                   'eval = something')
     expect(cop.offenses).to be_empty
   end
 
   it 'does not register an offense for eval as method' do
     inspect_source(cop,
-                   ['something.eval'])
+                   'something.eval')
     expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/lint/literal_in_condition_spec.rb

@@ -24,6 +24,15 @@ describe RuboCop::Cop::Lint::LiteralInCondition do
       expect(cop.offenses.size).to eq(1)
     end
 
+    it "registers an offense for literal #{lit} in post-loop while" do
+      inspect_source(cop,
+                     ['begin',
+                      '  top',
+                      "end while(#{lit})"
+                     ])
+      expect(cop.offenses.size).to eq(1)
+    end
+
     it "registers an offense for literal #{lit} in until" do
       inspect_source(cop,
                      ["until #{lit}",
@@ -33,6 +42,15 @@ describe RuboCop::Cop::Lint::LiteralInCondition do
       expect(cop.offenses.size).to eq(1)
     end
 
+    it "registers an offense for literal #{lit} in post-loop until" do
+      inspect_source(cop,
+                     ['begin',
+                      '  top',
+                      "end until #{lit}"
+                     ])
+      expect(cop.offenses.size).to eq(1)
+    end
+
     it "registers an offense for literal #{lit} in case" do
       inspect_source(cop,
                      ["case #{lit}",