rubocop 0.28.0 → 0.29.0

data/spec/rubocop/cop/style/space_around_equals_in_parameter_default_spec.rb

@@ -9,7 +9,8 @@ describe RuboCop::Cop::Style::SpaceAroundEqualsInParameterDefault, :config do
     let(:cop_config) { { 'EnforcedStyle' => 'space' } }
 
     it 'registers an offense for default value assignment without space' do
-      inspect_source(cop, ['def f(x, y=0, z= 1)', 'end'])
+      inspect_source(cop, ['def f(x, y=0, z= 1)',
+                           'end'])
       expect(cop.messages)
         .to eq(['Surrounding space missing in default value assignment.'] * 2)
       expect(cop.highlights).to eq(['=', '= '])
@@ -17,18 +18,21 @@ describe RuboCop::Cop::Style::SpaceAroundEqualsInParameterDefault, :config do
     end
 
     it 'registers an offense for assignment empty string without space' do
-      inspect_source(cop, ['def f(x, y="", z=1)', 'end'])
+      inspect_source(cop, ['def f(x, y="", z=1)',
+                           'end'])
       expect(cop.offenses.size).to eq(2)
       expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'no_space')
     end
 
     it 'registers an offense for assignment of empty list without space' do
-      inspect_source(cop, ['def f(x, y=[])', 'end'])
+      inspect_source(cop, ['def f(x, y=[])',
+                           'end'])
       expect(cop.offenses.size).to eq(1)
     end
 
     it 'accepts default value assignment with space' do
-      inspect_source(cop, ['def f(x, y = 0, z = {})', 'end'])
+      inspect_source(cop, ['def f(x, y = 0, z = {})',
+                           'end'])
       expect(cop.messages).to be_empty
     end
 
@@ -38,7 +42,8 @@ describe RuboCop::Cop::Style::SpaceAroundEqualsInParameterDefault, :config do
     end
 
     it 'accepts default value assignment with space' do
-      inspect_source(cop, ['def f(x, y = +1, z = {})', 'end'])
+      inspect_source(cop, ['def f(x, y = +1, z = {})',
+                           'end'])
       expect(cop.messages).to be_empty
     end
 
@@ -53,7 +58,8 @@ describe RuboCop::Cop::Style::SpaceAroundEqualsInParameterDefault, :config do
     let(:cop_config) { { 'EnforcedStyle' => 'no_space' } }
 
     it 'registers an offense for default value assignment with space' do
-      inspect_source(cop, ['def f(x, y = 0, z =1, w= 2)', 'end'])
+      inspect_source(cop, ['def f(x, y = 0, z =1, w= 2)',
+                           'end'])
       expect(cop.messages)
         .to eq(['Surrounding space detected in default value assignment.'] * 3)
       expect(cop.highlights).to eq([' = ', ' =', '= '])
@@ -61,18 +67,21 @@ describe RuboCop::Cop::Style::SpaceAroundEqualsInParameterDefault, :config do
     end
 
     it 'registers an offense for assignment empty string with space' do
-      inspect_source(cop, ['def f(x, y = "", z = 1)', 'end'])
+      inspect_source(cop, ['def f(x, y = "", z = 1)',
+                           'end'])
       expect(cop.offenses.size).to eq(2)
       expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'space')
     end
 
     it 'registers an offense for assignment of empty list with space' do
-      inspect_source(cop, ['def f(x, y = [])', 'end'])
+      inspect_source(cop, ['def f(x, y = [])',
+                           'end'])
       expect(cop.offenses.size).to eq(1)
     end
 
     it 'accepts default value assignment without space' do
-      inspect_source(cop, ['def f(x, y=0, z={})', 'end'])
+      inspect_source(cop, ['def f(x, y=0, z={})',
+                           'end'])
       expect(cop.messages).to be_empty
     end
 

data/spec/rubocop/cop/style/space_around_operators_spec.rb

@@ -6,9 +6,11 @@ describe RuboCop::Cop::Style::SpaceAroundOperators do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for assignment without space on both sides' do
-    inspect_source(cop, ['x=0', 'y= 0', 'z =0'])
-    expect(cop.messages).to eq(
-      ["Surrounding space missing for operator '='."] * 3)
+    inspect_source(cop, ['x=0', 'y+= 0', 'z[0] =0'])
+    expect(cop.messages)
+      .to eq(["Surrounding space missing for operator '='.",
+              "Surrounding space missing for operator '+='.",
+              "Surrounding space missing for operator '='."])
   end
 
   it 'auto-corrects assignment without space on both sides' do
@@ -17,7 +19,7 @@ describe RuboCop::Cop::Style::SpaceAroundOperators do
   end
 
   it 'registers an offense for ternary operator without space' do
-    inspect_source(cop, ['x == 0?1:2'])
+    inspect_source(cop, 'x == 0?1:2')
     expect(cop.messages).to eq(
       ["Surrounding space missing for operator '?'.",
        "Surrounding space missing for operator ':'."])
@@ -71,7 +73,7 @@ describe RuboCop::Cop::Style::SpaceAroundOperators do
   end
 
   it 'registers an offense for arguments to a method' do
-    inspect_source(cop, ['puts 1+2'])
+    inspect_source(cop, 'puts 1+2')
     expect(cop.messages).to eq(
       ["Surrounding space missing for operator '+'."])
   end
@@ -82,34 +84,34 @@ describe RuboCop::Cop::Style::SpaceAroundOperators do
   end
 
   it 'accepts operator surrounded by tabs' do
-    inspect_source(cop, ["a\t+\tb"])
+    inspect_source(cop, "a\t+\tb")
     expect(cop.messages).to be_empty
   end
 
   it 'accepts operator symbols' do
-    inspect_source(cop, ['func(:-)'])
+    inspect_source(cop, 'func(:-)')
     expect(cop.messages).to be_empty
   end
 
   it 'accepts ranges' do
-    inspect_source(cop, ['a, b = (1..2), (1...3)'])
+    inspect_source(cop, 'a, b = (1..2), (1...3)')
     expect(cop.messages).to be_empty
   end
 
   it 'accepts scope operator' do
-    source = ['@io.class == Zlib::GzipWriter']
+    source = '@io.class == Zlib::GzipWriter'
     inspect_source(cop, source)
     expect(cop.messages).to be_empty
   end
 
   it 'accepts ::Kernel::raise' do
-    source = ['::Kernel::raise IllegalBlockError.new']
+    source = '::Kernel::raise IllegalBlockError.new'
     inspect_source(cop, source)
     expect(cop.messages).to be_empty
   end
 
   it 'accepts exclamation point negation' do
-    inspect_source(cop, ['x = !a&&!b'])
+    inspect_source(cop, 'x = !a&&!b')
     expect(cop.messages).to eq(
       ["Surrounding space missing for operator '&&'."])
   end
@@ -143,7 +145,7 @@ describe RuboCop::Cop::Style::SpaceAroundOperators do
   end
 
   it 'accepts splat operator' do
-    inspect_source(cop, ['return *list if options'])
+    inspect_source(cop, 'return *list if options')
     expect(cop.messages).to be_empty
   end
 
@@ -161,12 +163,12 @@ describe RuboCop::Cop::Style::SpaceAroundOperators do
   end
 
   it 'accepts an assignment with spaces' do
-    inspect_source(cop, ['x = 0'])
+    inspect_source(cop, 'x = 0')
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts an operator called with method syntax' do
-    inspect_source(cop, ['Date.today.+(1).to_s'])
+    inspect_source(cop, 'Date.today.+(1).to_s')
     expect(cop.offenses).to be_empty
   end
 
@@ -216,7 +218,7 @@ describe RuboCop::Cop::Style::SpaceAroundOperators do
   end
 
   it 'registers an offenses for exponent operator with spaces' do
-    inspect_source(cop, ['x = a * b ** 2'])
+    inspect_source(cop, 'x = a * b ** 2')
     expect(cop.messages).to eq(
       ['Space around operator ** detected.'])
   end
@@ -229,18 +231,18 @@ describe RuboCop::Cop::Style::SpaceAroundOperators do
   end
 
   it 'accepts exponent operator without spaces' do
-    inspect_source(cop, ['x = a * b**2'])
+    inspect_source(cop, 'x = a * b**2')
     expect(cop.offenses).to be_empty
   end
 
   it 'registers an offense for a setter call without spaces' do
-    inspect_source(cop, ['x.y=2'])
+    inspect_source(cop, 'x.y=2')
     expect(cop.messages).to eq(
       ["Surrounding space missing for operator '='."])
   end
 
   it 'registers an offense for a hash rocket without spaces' do
-    inspect_source(cop, ['{ 1=>2, a: b }'])
+    inspect_source(cop, '{ 1=>2, a: b }')
     expect(cop.messages).to eq(
       ["Surrounding space missing for operator '=>'."])
   end
@@ -255,7 +257,7 @@ describe RuboCop::Cop::Style::SpaceAroundOperators do
   end
 
   it 'accepts [] without space' do
-    inspect_source(cop, ['files[2]'])
+    inspect_source(cop, 'files[2]')
     expect(cop.messages).to eq([])
   end
 
@@ -275,7 +277,8 @@ describe RuboCop::Cop::Style::SpaceAroundOperators do
   end
 
   it 'registers an offense for match operators without space' do
-    inspect_source(cop, ['x=~/abc/', 'y !~/abc/'])
+    inspect_source(cop, ['x=~/abc/',
+                         'y !~/abc/'])
     expect(cop.messages)
       .to eq(["Surrounding space missing for operator '=~'.",
               "Surrounding space missing for operator '!~'."])
@@ -305,7 +308,7 @@ describe RuboCop::Cop::Style::SpaceAroundOperators do
   end
 
   it 'registers an offense for - without space with negative lhs operand' do
-    inspect_source(cop, ['-1-arg'])
+    inspect_source(cop, '-1-arg')
     expect(cop.messages)
       .to eq(["Surrounding space missing for operator '-'."])
   end

data/spec/rubocop/cop/style/space_before_block_braces_spec.rb

@@ -15,13 +15,13 @@ describe RuboCop::Cop::Style::SpaceBeforeBlockBraces do
 
   context 'when EnforcedStyle is space' do
     it 'accepts braces surrounded by spaces' do
-      inspect_source(cop, ['each { puts }'])
+      inspect_source(cop, 'each { puts }')
       expect(cop.messages).to be_empty
       expect(cop.highlights).to be_empty
     end
 
     it 'registers an offense for left brace without outer space' do
-      inspect_source(cop, ['each{ puts }'])
+      inspect_source(cop, 'each{ puts }')
       expect(cop.messages).to eq(['Space missing to the left of {.'])
       expect(cop.highlights).to eq(['{'])
       expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'no_space')
@@ -45,7 +45,7 @@ describe RuboCop::Cop::Style::SpaceBeforeBlockBraces do
     let(:cop_config) { { 'EnforcedStyle' => 'no_space' } }
 
     it 'registers an offense for braces surrounded by spaces' do
-      inspect_source(cop, ['each { puts }'])
+      inspect_source(cop, 'each { puts }')
       expect(cop.messages).to eq(['Space detected to the left of {.'])
       expect(cop.highlights).to eq([' '])
       expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'space')
@@ -65,7 +65,7 @@ describe RuboCop::Cop::Style::SpaceBeforeBlockBraces do
     end
 
     it 'accepts left brace without outer space' do
-      inspect_source(cop, ['each{ puts }'])
+      inspect_source(cop, 'each{ puts }')
       expect(cop.messages).to be_empty
       expect(cop.highlights).to be_empty
     end

data/spec/rubocop/cop/style/space_before_comma_spec.rb

@@ -6,25 +6,25 @@ describe RuboCop::Cop::Style::SpaceBeforeComma do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for block argument with space before comma' do
-    inspect_source(cop, ['each { |s , t| }'])
+    inspect_source(cop, 'each { |s , t| }')
     expect(cop.messages).to eq(
       ['Space found before comma.'])
   end
 
   it 'registers an offense for array index with space before comma' do
-    inspect_source(cop, ['formats[0 , 1]'])
+    inspect_source(cop, 'formats[0 , 1]')
     expect(cop.messages).to eq(
       ['Space found before comma.'])
   end
 
   it 'registers an offense for method call arg with space before comma' do
-    inspect_source(cop, ['a(1 , 2)'])
+    inspect_source(cop, 'a(1 , 2)')
     expect(cop.messages).to eq(
       ['Space found before comma.'])
   end
 
   it 'does not register an offense for no spaces before comma' do
-    inspect_source(cop, ['a(1, 2)'])
+    inspect_source(cop, 'a(1, 2)')
     expect(cop.messages).to be_empty
   end
 

data/spec/rubocop/cop/style/space_before_comment_spec.rb

@@ -6,17 +6,17 @@ describe RuboCop::Cop::Style::SpaceBeforeComment do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for missing space before an EOL comment' do
-    inspect_source(cop, ['a += 1# increment'])
+    inspect_source(cop, 'a += 1# increment')
     expect(cop.highlights).to eq(['# increment'])
   end
 
   it 'accepts an EOL comment with a preceding space' do
-    inspect_source(cop, ['a += 1 # increment'])
+    inspect_source(cop, 'a += 1 # increment')
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts a comment that begins a line' do
-    inspect_source(cop, ['# comment'])
+    inspect_source(cop, '# comment')
     expect(cop.offenses).to be_empty
   end
 

data/spec/rubocop/cop/style/space_before_semicolon_spec.rb

@@ -6,13 +6,13 @@ describe RuboCop::Cop::Style::SpaceBeforeSemicolon do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for space before semicolon' do
-    inspect_source(cop, ['x = 1 ; y = 2'])
+    inspect_source(cop, 'x = 1 ; y = 2')
     expect(cop.messages).to eq(
       ['Space found before semicolon.'])
   end
 
   it 'does not register an offense for no space before semicolons' do
-    inspect_source(cop, ['x = 1; y = 2'])
+    inspect_source(cop, 'x = 1; y = 2')
     expect(cop.messages).to be_empty
   end
 

data/spec/rubocop/cop/style/space_inside_block_braces_spec.rb

@@ -25,7 +25,7 @@ describe RuboCop::Cop::Style::SpaceInsideBlockBraces do
     let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'no_space' } }
 
     it 'accepts empty braces with no space inside' do
-      inspect_source(cop, ['each {}'])
+      inspect_source(cop, 'each {}')
       expect(cop.messages).to be_empty
     end
 
@@ -42,7 +42,7 @@ describe RuboCop::Cop::Style::SpaceInsideBlockBraces do
     end
 
     it 'registers an offense for empty braces with space inside' do
-      inspect_source(cop, ['each { }'])
+      inspect_source(cop, 'each { }')
       expect(cop.messages).to eq(['Space inside empty braces detected.'])
       expect(cop.highlights).to eq([' '])
     end
@@ -67,12 +67,12 @@ describe RuboCop::Cop::Style::SpaceInsideBlockBraces do
     let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'space' } }
 
     it 'accepts empty braces with space inside' do
-      inspect_source(cop, ['each { }'])
+      inspect_source(cop, 'each { }')
       expect(cop.messages).to be_empty
     end
 
     it 'registers an offense for empty braces with no space inside' do
-      inspect_source(cop, ['each {}'])
+      inspect_source(cop, 'each {}')
       expect(cop.messages).to eq(['Space missing inside empty braces.'])
       expect(cop.highlights).to eq(['{}'])
     end
@@ -83,25 +83,34 @@ describe RuboCop::Cop::Style::SpaceInsideBlockBraces do
     end
   end
 
+  context 'with invalid value for EnforcedStyleForEmptyBraces' do
+    let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'unknown' } }
+
+    it 'fails with an error' do
+      expect { inspect_source(cop, 'each { }') }
+        .to raise_error('Unknown EnforcedStyleForEmptyBraces selected!')
+    end
+  end
+
   it 'accepts braces surrounded by spaces' do
-    inspect_source(cop, ['each { puts }'])
+    inspect_source(cop, 'each { puts }')
     expect(cop.messages).to be_empty
     expect(cop.highlights).to be_empty
   end
 
   it 'accepts left brace without outer space' do
-    inspect_source(cop, ['each{ puts }'])
+    inspect_source(cop, 'each{ puts }')
     expect(cop.highlights).to be_empty
   end
 
   it 'registers an offense for left brace without inner space' do
-    inspect_source(cop, ['each {puts }'])
+    inspect_source(cop, 'each {puts }')
     expect(cop.messages).to eq(['Space missing inside {.'])
     expect(cop.highlights).to eq(['p'])
   end
 
   it 'registers an offense for right brace without inner space' do
-    inspect_source(cop, ['each { puts}'])
+    inspect_source(cop, 'each { puts}')
     expect(cop.messages).to eq(['Space missing inside }.'])
     expect(cop.highlights).to eq(['}'])
     expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
@@ -130,19 +139,19 @@ describe RuboCop::Cop::Style::SpaceInsideBlockBraces do
 
   context 'with passed in parameters' do
     it 'accepts left brace with inner space' do
-      inspect_source(cop, ['each { |x| puts }'])
+      inspect_source(cop, 'each { |x| puts }')
       expect(cop.messages).to be_empty
       expect(cop.highlights).to be_empty
     end
 
     it 'registers an offense for left brace without inner space' do
-      inspect_source(cop, ['each {|x| puts }'])
+      inspect_source(cop, 'each {|x| puts }')
       expect(cop.messages).to eq(['Space between { and | missing.'])
       expect(cop.highlights).to eq(['{|'])
     end
 
     it 'accepts new lambda syntax' do
-      inspect_source(cop, ['->(x) { x }'])
+      inspect_source(cop, '->(x) { x }')
       expect(cop.messages).to be_empty
     end
 
@@ -183,13 +192,13 @@ describe RuboCop::Cop::Style::SpaceInsideBlockBraces do
       end
 
       it 'registers an offense for left brace with inner space' do
-        inspect_source(cop, ['each { |x| puts }'])
+        inspect_source(cop, 'each { |x| puts }')
         expect(cop.messages).to eq(['Space between { and | detected.'])
         expect(cop.highlights).to eq([' '])
       end
 
       it 'accepts new lambda syntax' do
-        inspect_source(cop, ['->(x) { x }'])
+        inspect_source(cop, '->(x) { x }')
         expect(cop.messages).to be_empty
       end
 
@@ -199,7 +208,7 @@ describe RuboCop::Cop::Style::SpaceInsideBlockBraces do
       end
 
       it 'accepts left brace without inner space' do
-        inspect_source(cop, ['each {|x| puts }'])
+        inspect_source(cop, 'each {|x| puts }')
         expect(cop.messages).to be_empty
         expect(cop.highlights).to be_empty
       end
@@ -216,26 +225,26 @@ describe RuboCop::Cop::Style::SpaceInsideBlockBraces do
     end
 
     it 'accepts braces without spaces inside' do
-      inspect_source(cop, ['each {puts}'])
+      inspect_source(cop, 'each {puts}')
       expect(cop.messages).to be_empty
       expect(cop.highlights).to be_empty
     end
 
     it 'registers an offense for left brace with inner space' do
-      inspect_source(cop, ['each { puts}'])
+      inspect_source(cop, 'each { puts}')
       expect(cop.messages).to eq(['Space inside { detected.'])
       expect(cop.highlights).to eq([' '])
       expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
     it 'registers an offense for right brace with inner space' do
-      inspect_source(cop, ['each {puts  }'])
+      inspect_source(cop, 'each {puts  }')
       expect(cop.messages).to eq(['Space inside } detected.'])
       expect(cop.highlights).to eq(['  '])
     end
 
     it 'registers offenses for both braces with inner space' do
-      inspect_source(cop, ['each { puts  }'])
+      inspect_source(cop, 'each { puts  }')
       expect(cop.messages).to eq(['Space inside { detected.',
                                   'Space inside } detected.'])
       expect(cop.highlights).to eq([' ', '  '])
@@ -244,7 +253,7 @@ describe RuboCop::Cop::Style::SpaceInsideBlockBraces do
     end
 
     it 'accepts left brace without outer space' do
-      inspect_source(cop, ['each {puts}'])
+      inspect_source(cop, 'each {puts}')
       expect(cop.highlights).to be_empty
     end
 
@@ -256,19 +265,19 @@ describe RuboCop::Cop::Style::SpaceInsideBlockBraces do
     context 'with passed in parameters' do
       context 'and space before block parameters allowed' do
         it 'accepts left brace with inner space' do
-          inspect_source(cop, ['each { |x| puts}'])
+          inspect_source(cop, 'each { |x| puts}')
           expect(cop.messages).to eq([])
           expect(cop.highlights).to eq([])
         end
 
         it 'registers an offense for left brace without inner space' do
-          inspect_source(cop, ['each {|x| puts}'])
+          inspect_source(cop, 'each {|x| puts}')
           expect(cop.messages).to eq(['Space between { and | missing.'])
           expect(cop.highlights).to eq(['{|'])
         end
 
         it 'accepts new lambda syntax' do
-          inspect_source(cop, ['->(x) {x}'])
+          inspect_source(cop, '->(x) {x}')
           expect(cop.messages).to be_empty
         end
 
@@ -288,13 +297,13 @@ describe RuboCop::Cop::Style::SpaceInsideBlockBraces do
         end
 
         it 'registers an offense for left brace with inner space' do
-          inspect_source(cop, ['each { |x| puts}'])
+          inspect_source(cop, 'each { |x| puts}')
           expect(cop.messages).to eq(['Space between { and | detected.'])
           expect(cop.highlights).to eq([' '])
         end
 
         it 'accepts new lambda syntax' do
-          inspect_source(cop, ['->(x) {x}'])
+          inspect_source(cop, '->(x) {x}')
           expect(cop.messages).to be_empty
         end