rubocop 0.28.0 → 0.29.0

data/spec/rubocop/cop/style/method_call_parentheses_spec.rb

@@ -9,22 +9,22 @@ describe RuboCop::Cop::Style::MethodCallParentheses, :config do
   end
 
   it 'registers an offense for parens in method call without args' do
-    inspect_source(cop, ['top.test()'])
+    inspect_source(cop, 'top.test()')
     expect(cop.offenses.size).to eq(1)
   end
 
   it 'accepts parentheses for methods starting with an upcase letter' do
-    inspect_source(cop, ['Test()'])
+    inspect_source(cop, 'Test()')
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts no parens in method call without args' do
-    inspect_source(cop, ['top.test'])
+    inspect_source(cop, 'top.test')
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts parens in method call with args' do
-    inspect_source(cop, ['top.test(a)'])
+    inspect_source(cop, 'top.test(a)')
     expect(cop.offenses).to be_empty
   end
 

data/spec/rubocop/cop/style/method_called_on_do_end_block_spec.rb

@@ -33,13 +33,13 @@ describe RuboCop::Cop::Style::MethodCalledOnDoEndBlock do
 
   context 'with a single-line do..end block' do
     it 'registers an offense for a chained call' do
-      inspect_source(cop, ['a do b end.c'])
+      inspect_source(cop, 'a do b end.c')
       expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['end.c'])
     end
 
     it 'accepts a single-line do..end block with a chained block' do
-      inspect_source(cop, ['a do b end.c do d end'])
+      inspect_source(cop, 'a do b end.c do d end')
       expect(cop.offenses).to be_empty
     end
   end
@@ -53,7 +53,7 @@ describe RuboCop::Cop::Style::MethodCalledOnDoEndBlock do
     end
 
     it 'accepts a single-line block with a chained call' do
-      inspect_source(cop, ['a { b }.c'])
+      inspect_source(cop, 'a { b }.c')
       expect(cop.offenses).to be_empty
     end
   end

data/spec/rubocop/cop/style/method_name_spec.rb

@@ -118,7 +118,7 @@ describe RuboCop::Cop::Style::MethodName, :config do
     let(:cop_config) { { 'EnforcedStyle' => 'other' } }
 
     it 'fails' do
-      expect { inspect_source(cop, ['def a', 'end']) }
+      expect { inspect_source(cop, 'def a', 'end') }
         .to raise_error(RuntimeError)
     end
   end

data/spec/rubocop/cop/style/multiline_block_layout_spec.rb

@@ -87,6 +87,36 @@ describe RuboCop::Cop::Style::MultilineBlockLayout do
       .to eq(['Block body expression is on the same line as the block start.'])
   end
 
+  it 'registers an offense for line-break before arguments' do
+    inspect_source(cop,
+                   ['test do',
+                    '  |x| play_with(x)',
+                    'end'])
+    expect(cop.messages)
+      .to eq(['Block argument expression is not on the same line as the ' \
+              'block start.'])
+  end
+
+  it 'registers an offense for line-break before arguments with empty block' do
+    inspect_source(cop,
+                   ['test do',
+                    '  |x|',
+                    'end'])
+    expect(cop.messages)
+      .to eq(['Block argument expression is not on the same line as the ' \
+              'block start.'])
+  end
+
+  it 'registers an offense for line-break within arguments' do
+    inspect_source(cop,
+                   ['test do |x,',
+                    '  y|',
+                    'end'])
+    expect(cop.messages)
+      .to eq(['Block argument expression is not on the same line as the ' \
+              'block start.'])
+  end
+
   it 'auto-corrects a do/end block with params that is missing newlines' do
     src = ['test do |foo| bar',
            'end']
@@ -135,4 +165,35 @@ describe RuboCop::Cop::Style::MultilineBlockLayout do
                               '  bar',
                               '}'].join("\n"))
   end
+
+  it 'auto-corrects a line-break before arguments' do
+    new_source = autocorrect_source(cop,
+                                    ['test do',
+                                     '  |x| play_with(x)',
+                                     'end'])
+
+    expect(new_source).to eq(['test do |x|',
+                              '  play_with(x)',
+                              'end'].join("\n"))
+  end
+
+  it 'auto-corrects a line-break before arguments with empty block' do
+    new_source = autocorrect_source(cop,
+                                    ['test do',
+                                     '  |x|',
+                                     'end'])
+
+    expect(new_source).to eq(['test do |x|',
+                              'end'].join("\n"))
+  end
+
+  it 'auto-corrects a line-break within arguments' do
+    new_source = autocorrect_source(cop,
+                                    ['test do |x,',
+                                     '  y| play_with(x, y)',
+                                     'end'])
+    expect(new_source).to eq(['test do |x, y|',
+                              '  play_with(x, y)',
+                              'end'].join("\n"))
+  end
 end

data/spec/rubocop/cop/style/multiline_if_then_spec.rb

@@ -102,9 +102,7 @@ describe RuboCop::Cop::Style::MultilineIfThen do
   end
 
   it 'does not get confused by a postfix unless' do
-    inspect_source(cop,
-                   ['two unless one'
-                   ])
+    inspect_source(cop, 'two unless one')
     expect(cop.offenses).to be_empty
   end
 

data/spec/rubocop/cop/style/multiline_operation_indentation_spec.rb

@@ -151,6 +151,14 @@ describe RuboCop::Cop::Style::MultilineOperationIndentation do
       expect(cop.messages).to be_empty
     end
 
+    it 'accepts any indentation of parameters to #[]' do
+      inspect_source(cop,
+                     ['payment = Models::IncomingPayments[',
+                      "        id:      input['incoming-payment-id'],",
+                      '           user_id: @user[:id]]'])
+      expect(cop.messages).to be_empty
+    end
+
     it 'registers an offense for extra indentation of 3rd line in typical ' \
        'RSpec code' do
       inspect_source(cop,

data/spec/rubocop/cop/style/multiline_ternary_operator_spec.rb

@@ -12,7 +12,7 @@ describe RuboCop::Cop::Style::MultilineTernaryOperator do
   end
 
   it 'accepts a single line ternary operator expression' do
-    inspect_source(cop, ['a = cond ? b : c'])
+    inspect_source(cop, 'a = cond ? b : c')
     expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/nested_ternary_operator_spec.rb

@@ -6,7 +6,7 @@ describe RuboCop::Cop::Style::NestedTernaryOperator do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for a nested ternary operator expression' do
-    inspect_source(cop, ['a ? (b ? b1 : b2) : a2'])
+    inspect_source(cop, 'a ? (b ? b1 : b2) : a2')
     expect(cop.offenses.size).to eq(1)
   end
 

data/spec/rubocop/cop/style/next_spec.rb

@@ -282,4 +282,20 @@ describe RuboCop::Cop::Style::Next, :config do
       expect(cop.highlights).to eq(['each'])
     end
   end
+
+  context 'Invalid MinBodyLength' do
+    let(:cop_config) do
+      { 'MinBodyLength' => -2 }
+    end
+
+    it 'fails with an error' do
+      source = ['loop do',
+                '  if o == 1',
+                '    puts o',
+                '  end',
+                'end']
+      expect { inspect_source(cop, source) }
+        .to raise_error('MinBodyLength needs to be a positive integer!')
+    end
+  end
 end

data/spec/rubocop/cop/style/numeric_literals_spec.rb

@@ -7,19 +7,19 @@ describe RuboCop::Cop::Style::NumericLiterals, :config do
   let(:cop_config) { { 'MinDigits' => 5 } }
 
   it 'registers an offense for a long undelimited integer' do
-    inspect_source(cop, ['a = 12345'])
+    inspect_source(cop, 'a = 12345')
     expect(cop.offenses.size).to eq(1)
     expect(cop.config_to_allow_offenses).to eq('MinDigits' => 6)
   end
 
   it 'registers an offense for a float with a long undelimited integer part' do
-    inspect_source(cop, ['a = 123456.789'])
+    inspect_source(cop, 'a = 123456.789')
     expect(cop.offenses.size).to eq(1)
     expect(cop.config_to_allow_offenses).to eq('MinDigits' => 7)
   end
 
   it 'registers an offense for an integer with misplaced underscore' do
-    inspect_source(cop, ['a = 123_456_78_90_00'])
+    inspect_source(cop, 'a = 123_456_78_90_00')
     expect(cop.offenses.size).to eq(1)
     expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
   end
@@ -31,12 +31,12 @@ describe RuboCop::Cop::Style::NumericLiterals, :config do
   end
 
   it 'accepts a short integer without underscore' do
-    inspect_source(cop, ['a = 123'])
+    inspect_source(cop, 'a = 123')
     expect(cop.messages).to be_empty
   end
 
   it 'does not count a leading minus sign as a digit' do
-    inspect_source(cop, ['a = -1230'])
+    inspect_source(cop, 'a = -1230')
     expect(cop.messages).to be_empty
   end
 

data/spec/rubocop/cop/style/one_line_conditional_spec.rb

@@ -6,7 +6,7 @@ describe RuboCop::Cop::Style::OneLineConditional do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for one line if/then/end' do
-    inspect_source(cop, ['if cond then run else dont end'])
+    inspect_source(cop, 'if cond then run else dont end')
     expect(cop.messages).to eq(['Favor the ternary operator (?:)' \
                                 ' over if/then/else/end constructs.'])
   end

data/spec/rubocop/cop/style/parentheses_around_condition_spec.rb

@@ -88,7 +88,7 @@ describe RuboCop::Cop::Style::ParenthesesAroundCondition, :config do
   end
 
   it 'is not confused by leading parenthesis in subexpression' do
-    inspect_source(cop, ['(a > b) && other ? one : two'])
+    inspect_source(cop, '(a > b) && other ? one : two')
     expect(cop.offenses).to be_empty
   end
 
@@ -107,12 +107,12 @@ describe RuboCop::Cop::Style::ParenthesesAroundCondition, :config do
   end
 
   it 'does not blow up when the condition is a ternary op' do
-    inspect_source(cop, ['x if (a ? b : c)'])
+    inspect_source(cop, 'x if (a ? b : c)')
     expect(cop.offenses.size).to eq(1)
   end
 
   context 'safe assignment is allowed' do
-    it 'accepts = in condition surrounded with parentheses' do
+    it 'accepts variable assignment in condition surrounded with parentheses' do
       inspect_source(cop,
                      ['if (test = 10)',
                       'end'
@@ -120,6 +120,14 @@ describe RuboCop::Cop::Style::ParenthesesAroundCondition, :config do
       expect(cop.offenses).to be_empty
     end
 
+    it 'accepts element assignment in condition surrounded with parentheses' do
+      inspect_source(cop,
+                     ['if (test[0] = 10)',
+                      'end'
+                     ])
+      expect(cop.offenses).to be_empty
+    end
+
     it 'accepts setter in condition surrounded with parentheses' do
       inspect_source(cop,
                      ['if (self.test = 10)',
@@ -132,12 +140,22 @@ describe RuboCop::Cop::Style::ParenthesesAroundCondition, :config do
   context 'safe assignment is not allowed' do
     let(:cop_config) { { 'AllowSafeAssignment' => false } }
 
-    it 'does not accept = in condition surrounded with parentheses' do
+    it 'does not accept variable assignment in condition surrounded with ' \
+       'parentheses' do
       inspect_source(cop,
                      ['if (test = 10)',
                       'end'
                      ])
       expect(cop.offenses.size).to eq(1)
     end
+
+    it 'does not accept element assignment in condition surrounded with ' \
+       'parentheses' do
+      inspect_source(cop,
+                     ['if (test[0] = 10)',
+                      'end'
+                     ])
+      expect(cop.offenses.size).to eq(1)
+    end
   end
 end

data/spec/rubocop/cop/style/percent_literal_delimiters_spec.rb

@@ -23,12 +23,12 @@ describe RuboCop::Cop::Style::PercentLiteralDelimiters, :config do
 
   context '`%` interpolated string' do
     it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, ['%[string]'])
+      inspect_source(cop, '%[string]')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters' do
-      inspect_source(cop, ['%(string)'])
+      inspect_source(cop, '%(string)')
       expect(cop.messages).to eq([
         '`%`-literals should be delimited by `[` and `]`'
       ])
@@ -36,25 +36,25 @@ describe RuboCop::Cop::Style::PercentLiteralDelimiters, :config do
 
     it 'does not register an offense for other delimiters ' \
        'when containing preferred delimiter characters' do
-      inspect_source(cop, ['%([string])'])
+      inspect_source(cop, '%([string])')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters ' \
        'when containing preferred delimiter characters in interpolation' do
-      inspect_source(cop, ['%(#{[1].first})'])
+      inspect_source(cop, '%(#{[1].first})')
       expect(cop.messages.size).to eq(1)
     end
   end
 
   context '`%q` string' do
     it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, ['%q[string]'])
+      inspect_source(cop, '%q[string]')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters' do
-      inspect_source(cop, ['%q(string)'])
+      inspect_source(cop, '%q(string)')
       expect(cop.messages).to eq([
         '`%q`-literals should be delimited by `[` and `]`'
       ])
@@ -62,19 +62,19 @@ describe RuboCop::Cop::Style::PercentLiteralDelimiters, :config do
 
     it 'does not register an offense for other delimiters ' \
        'when containing preferred delimiter characters' do
-      inspect_source(cop, ['%q([string])'])
+      inspect_source(cop, '%q([string])')
       expect(cop.offenses).to be_empty
     end
   end
 
   context '`%Q` interpolated string' do
     it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, ['%Q[string]'])
+      inspect_source(cop, '%Q[string]')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters' do
-      inspect_source(cop, ['%Q(string)'])
+      inspect_source(cop, '%Q(string)')
       expect(cop.messages).to eq([
         '`%Q`-literals should be delimited by `[` and `]`'
       ])
@@ -82,25 +82,25 @@ describe RuboCop::Cop::Style::PercentLiteralDelimiters, :config do
 
     it 'does not register an offense for other delimiters ' \
        'when containing preferred delimiter characters' do
-      inspect_source(cop, ['%Q([string])'])
+      inspect_source(cop, '%Q([string])')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters ' \
        'when containing preferred delimiter characters in interpolation' do
-      inspect_source(cop, ['%Q(#{[1].first})'])
+      inspect_source(cop, '%Q(#{[1].first})')
       expect(cop.messages.size).to eq(1)
     end
   end
 
   context '`%w` string array' do
     it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, ['%w[some words]'])
+      inspect_source(cop, '%w[some words]')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters' do
-      inspect_source(cop, ['%w(some words)'])
+      inspect_source(cop, '%w(some words)')
       expect(cop.messages).to eq([
         '`%w`-literals should be delimited by `[` and `]`'
       ])
@@ -108,19 +108,19 @@ describe RuboCop::Cop::Style::PercentLiteralDelimiters, :config do
 
     it 'does not register an offense for other delimiters ' \
        'when containing preferred delimiter characters' do
-      inspect_source(cop, ['%w([some] [words])'])
+      inspect_source(cop, '%w([some] [words])')
       expect(cop.offenses).to be_empty
     end
   end
 
   context '`%W` interpolated string array' do
     it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, ['%W[some words]'])
+      inspect_source(cop, '%W[some words]')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters' do
-      inspect_source(cop, ['%W(some words)'])
+      inspect_source(cop, '%W(some words)')
       expect(cop.messages).to eq([
         '`%W`-literals should be delimited by `[` and `]`'
       ])
@@ -128,25 +128,25 @@ describe RuboCop::Cop::Style::PercentLiteralDelimiters, :config do
 
     it 'does not register an offense for other delimiters ' \
        'when containing preferred delimiter characters' do
-      inspect_source(cop, ['%W([some] [words])'])
+      inspect_source(cop, '%W([some] [words])')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters ' \
        'when containing preferred delimiter characters in interpolation' do
-      inspect_source(cop, ['%W(#{[1].first})'])
+      inspect_source(cop, '%W(#{[1].first})')
       expect(cop.messages.size).to eq(1)
     end
   end
 
   context '`%r` interpolated regular expression' do
     it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, ['%r[regexp]'])
+      inspect_source(cop, '%r[regexp]')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters' do
-      inspect_source(cop, ['%r(regexp)'])
+      inspect_source(cop, '%r(regexp)')
       expect(cop.messages).to eq([
         '`%r`-literals should be delimited by `[` and `]`'
       ])
@@ -154,25 +154,25 @@ describe RuboCop::Cop::Style::PercentLiteralDelimiters, :config do
 
     it 'does not register an offense for other delimiters ' \
        'when containing preferred delimiter characters' do
-      inspect_source(cop, ['%r([regexp])'])
+      inspect_source(cop, '%r([regexp])')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters ' \
        'when containing preferred delimiter characters in interpolation' do
-      inspect_source(cop, ['%r(#{[1].first})'])
+      inspect_source(cop, '%r(#{[1].first})')
       expect(cop.messages.size).to eq(1)
     end
   end
 
-  context '`%i` symbol array', ruby: 2.0 do
+  context '`%i` symbol array', ruby: 2 do
     it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, ['%i[some symbols]'])
+      inspect_source(cop, '%i[some symbols]')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters' do
-      inspect_source(cop, ['%i(some symbols)'])
+      inspect_source(cop, '%i(some symbols)')
       expect(cop.messages).to eq([
         '`%i`-literals should be delimited by `[` and `]`'
       ])
@@ -181,12 +181,12 @@ describe RuboCop::Cop::Style::PercentLiteralDelimiters, :config do
 
   context '`%s` symbol' do
     it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, ['%s[symbol]'])
+      inspect_source(cop, '%s[symbol]')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters' do
-      inspect_source(cop, ['%s(symbol)'])
+      inspect_source(cop, '%s(symbol)')
       expect(cop.messages).to eq([
         '`%s`-literals should be delimited by `[` and `]`'
       ])
@@ -195,12 +195,12 @@ describe RuboCop::Cop::Style::PercentLiteralDelimiters, :config do
 
   context '`%x` interpolated system call' do
     it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, ['%x[command]'])
+      inspect_source(cop, '%x[command]')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters' do
-      inspect_source(cop, ['%x(command)'])
+      inspect_source(cop, '%x(command)')
       expect(cop.messages).to eq([
         '`%x`-literals should be delimited by `[` and `]`'
       ])
@@ -208,13 +208,13 @@ describe RuboCop::Cop::Style::PercentLiteralDelimiters, :config do
 
     it 'does not register an offense for other delimiters ' \
        'when containing preferred delimiter characters' do
-      inspect_source(cop, ['%x([command])'])
+      inspect_source(cop, '%x([command])')
       expect(cop.offenses).to be_empty
     end
 
     it 'registers an offense for other delimiters ' \
        'when containing preferred delimiter characters in interpolation' do
-      inspect_source(cop, ['%x(#{[1].first})'])
+      inspect_source(cop, '%x(#{[1].first})')
       expect(cop.messages.size).to eq(1)
     end
   end