rubocop 0.28.0 → 0.29.0

data/spec/rubocop/cop/style/space_inside_brackets_spec.rb

@@ -56,12 +56,12 @@ describe RuboCop::Cop::Style::SpaceInsideBrackets do
   end
 
   it 'accepts square brackets called with method call syntax' do
-    inspect_source(cop, ['subject.[](0)'])
+    inspect_source(cop, 'subject.[](0)')
     expect(cop.messages).to be_empty
   end
 
   it 'only reports a single space once' do
-    inspect_source(cop, ['[ ]'])
+    inspect_source(cop, '[ ]')
     expect(cop.messages).to eq(
       ['Space inside square brackets detected.'])
   end

data/spec/rubocop/cop/style/space_inside_hash_literal_braces_spec.rb

@@ -10,12 +10,12 @@ describe RuboCop::Cop::Style::SpaceInsideHashLiteralBraces, :config do
     let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'no_space' } }
 
     it 'accepts empty braces with no space inside' do
-      inspect_source(cop, ['h = {}'])
+      inspect_source(cop, 'h = {}')
       expect(cop.messages).to be_empty
     end
 
     it 'registers an offense for empty braces with space inside' do
-      inspect_source(cop, ['h = { }'])
+      inspect_source(cop, 'h = { }')
       expect(cop.messages)
         .to eq(['Space inside empty hash literal braces detected.'])
       expect(cop.highlights).to eq([' '])
@@ -31,12 +31,12 @@ describe RuboCop::Cop::Style::SpaceInsideHashLiteralBraces, :config do
     let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'space' } }
 
     it 'accepts empty braces with space inside' do
-      inspect_source(cop, ['h = { }'])
+      inspect_source(cop, 'h = { }')
       expect(cop.messages).to be_empty
     end
 
     it 'registers an offense for empty braces with no space inside' do
-      inspect_source(cop, ['h = {}'])
+      inspect_source(cop, 'h = {}')
       expect(cop.messages)
         .to eq(['Space inside empty hash literal braces missing.'])
       expect(cop.highlights).to eq(['{'])
@@ -62,7 +62,7 @@ describe RuboCop::Cop::Style::SpaceInsideHashLiteralBraces, :config do
 
   it 'registers an offense for correct + opposite' do
     inspect_source(cop,
-                   ['h = { a: 1}'])
+                   'h = { a: 1}')
     expect(cop.messages).to eq(['Space inside } missing.'])
     expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
   end
@@ -79,7 +79,7 @@ describe RuboCop::Cop::Style::SpaceInsideHashLiteralBraces, :config do
 
     it 'registers an offense for hashes with spaces' do
       inspect_source(cop,
-                     ['h = { a: 1, b: 2 }'])
+                     'h = { a: 1, b: 2 }')
       expect(cop.messages).to eq(['Space inside { detected.',
                                   'Space inside } detected.'])
       expect(cop.highlights).to eq([' ', ' '])
@@ -88,7 +88,7 @@ describe RuboCop::Cop::Style::SpaceInsideHashLiteralBraces, :config do
 
     it 'registers an offense for opposite + correct' do
       inspect_source(cop,
-                     ['h = {a: 1 }'])
+                     'h = {a: 1 }')
       expect(cop.messages).to eq(['Space inside } detected.'])
       expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
@@ -134,14 +134,14 @@ describe RuboCop::Cop::Style::SpaceInsideHashLiteralBraces, :config do
   end
 
   it 'accepts hash literals with no braces' do
-    inspect_source(cop, ['x(a: b.c)'])
+    inspect_source(cop, 'x(a: b.c)')
     expect(cop.offenses).to be_empty
   end
 
   it 'can handle interpolation in a braceless hash literal' do
     # A tricky special case where the closing brace of the
     # interpolation risks getting confused for a hash literal brace.
-    inspect_source(cop, ['f(get: "#{x}")'])
+    inspect_source(cop, 'f(get: "#{x}")')
     expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/space_inside_parens_spec.rb

@@ -19,7 +19,7 @@ describe RuboCop::Cop::Style::SpaceInsideParens do
   end
 
   it 'accepts parentheses with no spaces' do
-    inspect_source(cop, ['split("\n")'])
+    inspect_source(cop, 'split("\n")')
     expect(cop.messages).to be_empty
   end
 

data/spec/rubocop/cop/style/special_global_vars_spec.rb

@@ -6,28 +6,28 @@ describe RuboCop::Cop::Style::SpecialGlobalVars do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for $:' do
-    inspect_source(cop, ['puts $:'])
+    inspect_source(cop, 'puts $:')
     expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Prefer `$LOAD_PATH` over `$:`.'])
   end
 
   it 'registers an offense for $"' do
-    inspect_source(cop, ['puts $"'])
+    inspect_source(cop, 'puts $"')
     expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Prefer `$LOADED_FEATURES` over `$"`.'])
   end
 
   it 'registers an offense for $0' do
-    inspect_source(cop, ['puts $0'])
+    inspect_source(cop, 'puts $0')
     expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Prefer `$PROGRAM_NAME` over `$0`.'])
   end
 
   it 'registers an offense for $$' do
-    inspect_source(cop, ['puts $$'])
+    inspect_source(cop, 'puts $$')
     expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Prefer `$PROCESS_ID` or `$PID` from the English ' \
@@ -35,13 +35,13 @@ describe RuboCop::Cop::Style::SpecialGlobalVars do
   end
 
   it 'is clear about variables from the English library vs those not' do
-    inspect_source(cop, ['puts $*'])
+    inspect_source(cop, 'puts $*')
     expect(cop.messages)
       .to eq(['Prefer `$ARGV` from the English library, or `ARGV` over `$*`.'])
   end
 
   it 'does not register an offense for backrefs like $1' do
-    inspect_source(cop, ['puts $1'])
+    inspect_source(cop, 'puts $1')
     expect(cop.offenses).to be_empty
   end
 

data/spec/rubocop/cop/style/string_literals_in_interpolation_spec.rb

@@ -9,7 +9,7 @@ describe RuboCop::Cop::Style::StringLiteralsInInterpolation, :config do
     let(:cop_config) { { 'EnforcedStyle' => 'single_quotes' } }
 
     it 'registers an offense for double quotes within embedded expression' do
-      src = ['"#{"A"}"']
+      src = '"#{"A"}"'
       inspect_source(cop, src)
       expect(cop.messages)
         .to eq(['Prefer single-quoted strings inside interpolations.'])
@@ -26,7 +26,7 @@ describe RuboCop::Cop::Style::StringLiteralsInInterpolation, :config do
     end
 
     it 'accepts double quotes on a static string' do
-      src = ['"A"']
+      src = '"A"'
       inspect_source(cop, src)
       expect(cop.offenses).to be_empty
     end
@@ -92,7 +92,7 @@ describe RuboCop::Cop::Style::StringLiteralsInInterpolation, :config do
     let(:cop_config) { { 'EnforcedStyle' => 'other' } }
 
     it 'fails' do
-      expect { inspect_source(cop, ['a = "#{"b"}"']) }
+      expect { inspect_source(cop, 'a = "#{"b"}"') }
         .to raise_error(RuntimeError)
     end
   end

data/spec/rubocop/cop/style/string_literals_spec.rb

@@ -35,22 +35,22 @@ describe RuboCop::Cop::Style::StringLiterals, :config do
     end
 
     it 'accepts single quotes' do
-      inspect_source(cop, ["a = 'x'"])
+      inspect_source(cop, "a = 'x'")
       expect(cop.offenses).to be_empty
     end
 
     it 'accepts single quotes in interpolation' do
-      inspect_source(cop, [%q("hello#{hash['there']}")])
+      inspect_source(cop, %q("hello#{hash['there']}"))
       expect(cop.offenses).to be_empty
     end
 
     it 'accepts %q and %Q quotes' do
-      inspect_source(cop, ['a = %q(x) + %Q[x]'])
+      inspect_source(cop, 'a = %q(x) + %Q[x]')
       expect(cop.offenses).to be_empty
     end
 
     it 'accepts % quotes' do
-      inspect_source(cop, ['a = %(x)'])
+      inspect_source(cop, 'a = %(x)')
       expect(cop.offenses).to be_empty
     end
 
@@ -77,7 +77,7 @@ describe RuboCop::Cop::Style::StringLiterals, :config do
     end
 
     it 'accepts double quotes at the start of regexp literals' do
-      inspect_source(cop, ['s = /"((?:[^\\"]|\\.)*)"/'])
+      inspect_source(cop, 's = /"((?:[^\\"]|\\.)*)"/')
       expect(cop.offenses).to be_empty
     end
 
@@ -91,17 +91,17 @@ describe RuboCop::Cop::Style::StringLiterals, :config do
     end
 
     it 'accepts " in a %w' do
-      inspect_source(cop, ['%w(")'])
+      inspect_source(cop, '%w(")')
       expect(cop.offenses).to be_empty
     end
 
     it 'accepts \\\\\n in a string' do # this would be: "\\\n"
-      inspect_source(cop, ['"foo \\\\\n bar"'])
+      inspect_source(cop, '"foo \\\\\n bar"')
       expect(cop.offenses).to be_empty
     end
 
     it 'accepts double quotes in interpolation' do
-      src = ['"#{"A"}"']
+      src = '"#{"A"}"'
       inspect_source(cop, src)
       expect(cop.offenses).to be_empty
     end
@@ -137,7 +137,7 @@ describe RuboCop::Cop::Style::StringLiterals, :config do
 
     it 'registers offense for single quotes when double quotes would ' \
       'be equivalent' do
-      inspect_source(cop, ["s = 'abc'"])
+      inspect_source(cop, "s = 'abc'")
       expect(cop.highlights).to eq(["'abc'"])
       expect(cop.messages)
         .to eq(['Prefer double-quoted strings unless you need ' \
@@ -158,22 +158,22 @@ describe RuboCop::Cop::Style::StringLiterals, :config do
     end
 
     it 'accepts double quotes' do
-      inspect_source(cop, ['a = "x"'])
+      inspect_source(cop, 'a = "x"')
       expect(cop.offenses).to be_empty
     end
 
     it 'accepts single quotes in interpolation' do
-      inspect_source(cop, [%q("hello#{hash['there']}")])
+      inspect_source(cop, %q("hello#{hash['there']}"))
       expect(cop.offenses).to be_empty
     end
 
     it 'accepts %q and %Q quotes' do
-      inspect_source(cop, ['a = %q(x) + %Q[x]'])
+      inspect_source(cop, 'a = %q(x) + %Q[x]')
       expect(cop.offenses).to be_empty
     end
 
     it 'accepts % quotes' do
-      inspect_source(cop, ['a = %(x)'])
+      inspect_source(cop, 'a = %(x)')
       expect(cop.offenses).to be_empty
     end
 
@@ -194,12 +194,12 @@ describe RuboCop::Cop::Style::StringLiterals, :config do
     end
 
     it 'accepts single quotes at the start of regexp literals' do
-      inspect_source(cop, ["s = /'((?:[^\\']|\\.)*)'/"])
+      inspect_source(cop, "s = /'((?:[^\\']|\\.)*)'/")
       expect(cop.offenses).to be_empty
     end
 
     it "accepts ' in a %w" do
-      inspect_source(cop, ["%w(')"])
+      inspect_source(cop, "%w(')")
       expect(cop.offenses).to be_empty
     end
 
@@ -221,7 +221,7 @@ describe RuboCop::Cop::Style::StringLiterals, :config do
     let(:cop_config) { { 'EnforcedStyle' => 'other' } }
 
     it 'fails' do
-      expect { inspect_source(cop, ['a = "b"']) }
+      expect { inspect_source(cop, 'a = "b"') }
         .to raise_error(RuntimeError)
     end
   end

data/spec/rubocop/cop/style/struct_inheritance_spec.rb

@@ -0,0 +1,44 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe RuboCop::Cop::Style::StructInheritance do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offense when extending instance of Struct' do
+    inspect_source(cop,
+                   ['class Person < Struct.new(:first_name, :last_name)',
+                    'end'
+                   ])
+    expect(cop.offenses.size).to eq(1)
+  end
+
+  it 'registers an offense when extending instance of Struct' do
+    inspect_source(cop,
+                   ['class Person < Struct.new(:first_name, :last_name) do end',
+                    'end'
+                   ])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts plain class' do
+    inspect_source(cop,
+                   ['class Person',
+                    'end'
+                   ])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts extending DelegateClass' do
+    inspect_source(cop,
+                   ['class Person < DelegateClass(Animal)',
+                    'end'
+                   ])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts assignment to Struct.new' do
+    inspect_source(cop, 'Person = Struct.new(:first_name, :last_name)')
+    expect(cop.offenses).to be_empty
+  end
+end

data/spec/rubocop/cop/style/symbol_array_spec.rb

@@ -5,33 +5,33 @@ require 'spec_helper'
 describe RuboCop::Cop::Style::SymbolArray do
   subject(:cop) { described_class.new }
 
-  it 'registers an offense for arrays of symbols', ruby: 2.0 do
+  it 'registers an offense for arrays of symbols', ruby: 2 do
     inspect_source(cop,
-                   ['[:one, :two, :three]'])
+                   '[:one, :two, :three]')
     expect(cop.offenses.size).to eq(1)
   end
 
-  it 'does not reg an offense for array with non-syms', ruby: 2.0 do
+  it 'does not reg an offense for array with non-syms', ruby: 2 do
     inspect_source(cop,
-                   ['[:one, :two, "three"]'])
+                   '[:one, :two, "three"]')
     expect(cop.offenses).to be_empty
   end
 
-  it 'does not reg an offense for array starting with %i', ruby: 2.0 do
+  it 'does not reg an offense for array starting with %i', ruby: 2 do
     inspect_source(cop,
-                   ['%i(one two three)'])
+                   '%i(one two three)')
     expect(cop.offenses).to be_empty
   end
 
-  it 'does not reg an offense for array with one element', ruby: 2.0 do
+  it 'does not reg an offense for array with one element', ruby: 2 do
     inspect_source(cop,
-                   ['[:three]'])
+                   '[:three]')
     expect(cop.offenses).to be_empty
   end
 
   it 'does nothing on Ruby 1.9', ruby: 1.9 do
     inspect_source(cop,
-                   ['[:one, :two, :three]'])
+                   '[:one, :two, :three]')
     expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/symbol_proc_spec.rb

@@ -16,68 +16,68 @@ describe RuboCop::Cop::Style::SymbolProc, :config do
   end
 
   it 'registers an offense for a block when method in body is unary -/=' do
-    inspect_source(cop, ['something.map { |x| -x }'])
+    inspect_source(cop, 'something.map { |x| -x }')
     expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Pass `&:-@` as an argument to `map` instead of a block.'])
   end
 
   it 'accepts method receiving another argument beside the block' do
-    inspect_source(cop, ['File.open(file) { |f| f.readlines }'])
+    inspect_source(cop, 'File.open(file) { |f| f.readlines }')
 
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts block with more than 1 arguments' do
-    inspect_source(cop, ['something { |x, y| x.method }'])
+    inspect_source(cop, 'something { |x, y| x.method }')
 
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts lambda with 1 argument' do
-    inspect_source(cop, ['->(x) { x.method }'])
+    inspect_source(cop, '->(x) { x.method }')
 
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts proc with 1 argument' do
-    inspect_source(cop, ['proc { |x| x.method }'])
+    inspect_source(cop, 'proc { |x| x.method }')
 
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts Proc.new with 1 argument' do
-    inspect_source(cop, ['Proc.new { |x| x.method }'])
+    inspect_source(cop, 'Proc.new { |x| x.method }')
 
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts ignored method' do
-    inspect_source(cop, ['respond_to { |format| format.xml }'])
+    inspect_source(cop, 'respond_to { |format| format.xml }')
 
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts block with no arguments' do
-    inspect_source(cop, ['something { x.method }'])
+    inspect_source(cop, 'something { x.method }')
 
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts empty block body' do
-    inspect_source(cop, ['something { |x| }'])
+    inspect_source(cop, 'something { |x| }')
 
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts block with more than 1 expression in body' do
-    inspect_source(cop, ['something { |x| x.method; something_else }'])
+    inspect_source(cop, 'something { |x| x.method; something_else }')
 
     expect(cop.offenses).to be_empty
   end
 
   it 'accepts block when method in body is not called on block arg' do
-    inspect_source(cop, ['something { |x| y.method }'])
+    inspect_source(cop, 'something { |x| y.method }')
 
     expect(cop.offenses).to be_empty
   end
@@ -94,7 +94,7 @@ describe RuboCop::Cop::Style::SymbolProc, :config do
   end
 
   it 'does not crash with a bare method call' do
-    run = -> { inspect_source(cop, ['coll.map { |s| bare_method }']) }
+    run = -> { inspect_source(cop, 'coll.map { |s| bare_method }') }
     expect(&run).not_to raise_error
   end
 end