rubocop 0.13.1 → 0.14.0

data/spec/rubocop/cop/style/space_before_modifier_keyword_spec.rb

@@ -2,52 +2,46 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe SpaceBeforeModifierKeyword do
-        subject(:cop) { described_class.new }
+describe Rubocop::Cop::Style::SpaceBeforeModifierKeyword do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for missing space before if/unless' do
-          inspect_source(cop, ['(a = 3)if a == 2',
-                               'a = "test"if a == 2',
-                               'a = 42unless a == 2',
-                               'a = [1,2,3]unless a == 2',
-                               'a = {:a => "b"}if a == 2'])
-          expect(cop.highlights).to eq([')', '"', '2', ']', '}'])
-        end
+  it 'registers an offence for missing space before if/unless' do
+    inspect_source(cop, ['(a = 3)if a == 2',
+                         'a = "test"if a == 2',
+                         'a = 42unless a == 2',
+                         'a = [1,2,3]unless a == 2',
+                         'a = {:a => "b"}if a == 2'])
+    expect(cop.highlights).to eq([')', '"', '2', ']', '}'])
+  end
 
-        it 'registers an offence for missing space before while/until' do
-          inspect_source(cop, ['(a = 3)while b',
-                               'a = "test"until b',
-                               'a = 42while b',
-                               'a = [1,2,3]until b',
-                               'a = {:a => "b"}while b'])
-          expect(cop.highlights).to eq([')', '"', '2', ']', '}'])
-        end
+  it 'registers an offence for missing space before while/until' do
+    inspect_source(cop, ['(a = 3)while b',
+                         'a = "test"until b',
+                         'a = 42while b',
+                         'a = [1,2,3]until b',
+                         'a = {:a => "b"}while b'])
+    expect(cop.highlights).to eq([')', '"', '2', ']', '}'])
+  end
 
-        it 'accepts modifiers with preceding space' do
-          inspect_source(cop, ['(a = 3) if b',
-                               'a = "test" unless b',
-                               'a = 42 while b',
-                               'a = [1,2,3] until b'])
-          expect(cop.offences).to be_empty
-        end
+  it 'accepts modifiers with preceding space' do
+    inspect_source(cop, ['(a = 3) if b',
+                         'a = "test" unless b',
+                         'a = 42 while b',
+                         'a = [1,2,3] until b'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'accepts elsif at beginning of line' do
-          inspect_source(cop, ["if RUBY_VERSION.between?('1.9.2', '2.0.0')",
-                               "  require 'testing/performance/ruby/yarv'",
-                               'elsif RUBY_VERSION.between?("1.8.6", "1.9")',
-                               "  require 'testing/performance/ruby/mri'",
-                               'end'])
-          expect(cop.highlights).to eq([])
-        end
+  it 'accepts elsif at beginning of line' do
+    inspect_source(cop, ["if RUBY_VERSION.between?('1.9.2', '2.0.0')",
+                         "  require 'testing/performance/ruby/yarv'",
+                         'elsif RUBY_VERSION.between?("1.8.6", "1.9")',
+                         "  require 'testing/performance/ruby/mri'",
+                         'end'])
+    expect(cop.highlights).to eq([])
+  end
 
-        it 'does not crash on ternary conditionals' do
-          inspect_source(cop, 'a ? b : c')
-          expect(cop.offences).to be_empty
-        end
-      end
-    end
+  it 'does not crash on ternary conditionals' do
+    inspect_source(cop, 'a ? b : c')
+    expect(cop.offences).to be_empty
   end
 end

data/spec/rubocop/cop/style/space_inside_brackets_spec.rb

@@ -2,50 +2,44 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe SpaceInsideBrackets do
-        subject(:space) { SpaceInsideBrackets.new }
-
-        it 'registers an offence for an array literal with spaces inside' do
-          inspect_source(space, ['a = [1, 2 ]',
-                                 'b = [ 1, 2]'])
-          expect(space.messages).to eq(
-            ['Space inside square brackets detected.',
-             'Space inside square brackets detected.'])
-        end
-
-        it 'accepts space inside strings within square brackets' do
-          inspect_source(space, ["['Encoding:',",
-                                 " '  Enabled: false']"])
-          expect(space.messages).to be_empty
-        end
-
-        it 'accepts space inside square brackets if on its own row' do
-          inspect_source(space, ['a = [',
-                                 '     1, 2',
-                                 '    ]'])
-          expect(space.messages).to be_empty
-        end
-
-        it 'accepts square brackets as method name' do
-          inspect_source(space, ['def Vector.[](*array)',
-                                 'end'])
-          expect(space.messages).to be_empty
-        end
-
-        it 'accepts square brackets called with method call syntax' do
-          inspect_source(space, ['subject.[](0)'])
-          expect(space.messages).to be_empty
-        end
-
-        it 'only reports a single space once' do
-          inspect_source(space, ['[ ]'])
-          expect(space.messages).to eq(
-            ['Space inside square brackets detected.'])
-        end
-      end
-    end
+describe Rubocop::Cop::Style::SpaceInsideBrackets do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for an array literal with spaces inside' do
+    inspect_source(cop, ['a = [1, 2 ]',
+                         'b = [ 1, 2]'])
+    expect(cop.messages).to eq(
+      ['Space inside square brackets detected.',
+       'Space inside square brackets detected.'])
+  end
+
+  it 'accepts space inside strings within square brackets' do
+    inspect_source(cop, ["['Encoding:',",
+                         " '  Enabled: false']"])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts space inside square brackets if on its own row' do
+    inspect_source(cop, ['a = [',
+                         '     1, 2',
+                         '    ]'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts square brackets as method name' do
+    inspect_source(cop, ['def Vector.[](*array)',
+                         'end'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts square brackets called with method call syntax' do
+    inspect_source(cop, ['subject.[](0)'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'only reports a single space once' do
+    inspect_source(cop, ['[ ]'])
+    expect(cop.messages).to eq(
+      ['Space inside square brackets detected.'])
   end
 end

data/spec/rubocop/cop/style/space_inside_hash_literal_braces_spec.rb

@@ -2,84 +2,78 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe SpaceInsideHashLiteralBraces, :config do
-        subject(:cop) { SpaceInsideHashLiteralBraces.new(config) }
-        let(:cop_config) { { 'EnforcedStyleIsWithSpaces' => true } }
+describe Rubocop::Cop::Style::SpaceInsideHashLiteralBraces, :config do
+  subject(:cop) { described_class.new(config) }
+  let(:cop_config) { { 'EnforcedStyleIsWithSpaces' => true } }
 
-        it 'registers an offence for hashes with no spaces if so configured' do
-          inspect_source(cop,
-                         ['h = {a: 1, b: 2}',
-                          'h = {a => 1 }'])
-          expect(cop.messages).to eq(
-            ['Space inside hash literal braces missing.'] * 3)
-          expect(cop.highlights).to eq(['{', '}', '{'])
-        end
+  it 'registers an offence for hashes with no spaces if so configured' do
+    inspect_source(cop,
+                   ['h = {a: 1, b: 2}',
+                    'h = {a => 1 }'])
+    expect(cop.messages).to eq(
+      ['Space inside hash literal braces missing.'] * 3)
+    expect(cop.highlights).to eq(['{', '}', '{'])
+  end
 
-        context 'when EnforcedStyleIsWithSpaces is disabled' do
-          let(:cop_config) { { 'EnforcedStyleIsWithSpaces' => false } }
+  context 'when EnforcedStyleIsWithSpaces is disabled' do
+    let(:cop_config) { { 'EnforcedStyleIsWithSpaces' => false } }
 
-          it 'registers an offence for hashes with spaces' do
-            inspect_source(cop,
-                           ['h = { a: 1, b: 2 }'])
-            expect(cop.messages).to eq(
-              ['Space inside hash literal braces detected.'] * 2)
-            expect(cop.highlights).to eq(['{', '}'])
-          end
+    it 'registers an offence for hashes with spaces' do
+      inspect_source(cop,
+                     ['h = { a: 1, b: 2 }'])
+      expect(cop.messages).to eq(
+        ['Space inside hash literal braces detected.'] * 2)
+      expect(cop.highlights).to eq(['{', '}'])
+    end
 
-          it 'accepts hashes with no spaces' do
-            inspect_source(cop,
-                           ['h = {a: 1, b: 2}',
-                            'h = {a => 1}'])
-            expect(cop.offences).to be_empty
-          end
+    it 'accepts hashes with no spaces' do
+      inspect_source(cop,
+                     ['h = {a: 1, b: 2}',
+                      'h = {a => 1}'])
+      expect(cop.offences).to be_empty
+    end
 
-          it 'accepts multiline hashes for no space' do
-            inspect_source(cop,
-                           ['h = {',
-                            '      a: 1,',
-                            '      b: 2,',
-                            '}'])
-            expect(cop.offences).to be_empty
-          end
+    it 'accepts multiline hashes for no space' do
+      inspect_source(cop,
+                     ['h = {',
+                      '      a: 1,',
+                      '      b: 2,',
+                      '}'])
+      expect(cop.offences).to be_empty
+    end
 
-          it 'accepts empty hashes without spaces' do
-            inspect_source(cop, ['h = {}'])
-            expect(cop.offences).to be_empty
-          end
-        end
+    it 'accepts empty hashes without spaces' do
+      inspect_source(cop, ['h = {}'])
+      expect(cop.offences).to be_empty
+    end
+  end
 
-        it 'accepts hashes with spaces by default' do
-          inspect_source(cop,
-                         ['h = { a: 1, b: 2 }',
-                          'h = { a => 1 }'])
-          expect(cop.offences).to be_empty
-        end
+  it 'accepts hashes with spaces by default' do
+    inspect_source(cop,
+                   ['h = { a: 1, b: 2 }',
+                    'h = { a => 1 }'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'accepts empty hashes without spaces by default' do
-          inspect_source(cop, ['h = {}'])
-          expect(cop.offences).to be_empty
-        end
+  it 'accepts empty hashes without spaces by default' do
+    inspect_source(cop, ['h = {}'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'accepts empty hashes without spaces even if configured true' do
-          inspect_source(cop, ['h = {}'])
-          expect(cop.offences).to be_empty
-        end
+  it 'accepts empty hashes without spaces even if configured true' do
+    inspect_source(cop, ['h = {}'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'accepts hash literals with no braces' do
-          inspect_source(cop, ['x(a: b.c)'])
-          expect(cop.offences).to be_empty
-        end
+  it 'accepts hash literals with no braces' do
+    inspect_source(cop, ['x(a: b.c)'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'can handle interpolation in a braceless hash literal' do
-          # A tricky special case where the closing brace of the
-          # interpolation risks getting confused for a hash literal brace.
-          inspect_source(cop, ['f(get: "#{x}")'])
-          expect(cop.offences).to be_empty
-        end
-      end
-    end
+  it 'can handle interpolation in a braceless hash literal' do
+    # A tricky special case where the closing brace of the
+    # interpolation risks getting confused for a hash literal brace.
+    inspect_source(cop, ['f(get: "#{x}")'])
+    expect(cop.offences).to be_empty
   end
 end

data/spec/rubocop/cop/style/space_inside_parens_spec.rb

@@ -2,32 +2,26 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe SpaceInsideParens do
-        subject(:space) { SpaceInsideParens.new }
+describe Rubocop::Cop::Style::SpaceInsideParens do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for spaces inside parens' do
-          inspect_source(space, ['f( 3)',
-                                 'g(3 )'])
-          expect(space.messages).to eq(
-            ['Space inside parentheses detected.',
-             'Space inside parentheses detected.'])
-        end
+  it 'registers an offence for spaces inside parens' do
+    inspect_source(cop, ['f( 3)',
+                         'g(3 )'])
+    expect(cop.messages).to eq(
+      ['Space inside parentheses detected.',
+       'Space inside parentheses detected.'])
+  end
 
-        it 'accepts parentheses in block parameter list' do
-          inspect_source(space,
-                         ['list.inject(Tms.new) { |sum, (label, item)|',
-                          '}'])
-          expect(space.messages).to be_empty
-        end
+  it 'accepts parentheses in block parameter list' do
+    inspect_source(cop,
+                   ['list.inject(Tms.new) { |sum, (label, item)|',
+                    '}'])
+    expect(cop.messages).to be_empty
+  end
 
-        it 'accepts parentheses with no spaces' do
-          inspect_source(space, ['split("\n")'])
-          expect(space.messages).to be_empty
-        end
-      end
-    end
+  it 'accepts parentheses with no spaces' do
+    inspect_source(cop, ['split("\n")'])
+    expect(cop.messages).to be_empty
   end
 end

data/spec/rubocop/cop/style/special_global_vars_spec.rb

@@ -2,51 +2,45 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe SpecialGlobalVars do
-        subject(:cop) { described_class.new }
-
-        it 'registers an offence for $:' do
-          inspect_source(cop, ['puts $:'])
-          expect(cop.offences.size).to eq(1)
-          expect(cop.messages)
-            .to eq(['Prefer $LOAD_PATH over $:.'])
-        end
-
-        it 'registers an offence for $"' do
-          inspect_source(cop, ['puts $"'])
-          expect(cop.offences.size).to eq(1)
-          expect(cop.messages)
-            .to eq(['Prefer $LOADED_FEATURES over $".'])
-        end
-
-        it 'registers an offence for $0' do
-          inspect_source(cop, ['puts $0'])
-          expect(cop.offences.size).to eq(1)
-          expect(cop.messages)
-            .to eq(['Prefer $PROGRAM_NAME over $0.'])
-        end
-
-        it 'registers an offence for $$' do
-          inspect_source(cop, ['puts $$'])
-          expect(cop.offences.size).to eq(1)
-          expect(cop.messages)
-            .to eq(['Prefer $PID or $PROCESS_ID from English library' +
-              ' over $$.'])
-        end
-
-        it 'does not register an offence for backrefs like $1' do
-          inspect_source(cop, ['puts $1'])
-          expect(cop.offences).to be_empty
-        end
-
-        it 'auto-corrects $: to $LOAD_PATH' do
-          new_source = autocorrect_source(cop, '$:')
-          expect(new_source).to eq('$LOAD_PATH')
-        end
-      end
-    end
+describe Rubocop::Cop::Style::SpecialGlobalVars do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for $:' do
+    inspect_source(cop, ['puts $:'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Prefer $LOAD_PATH over $:.'])
+  end
+
+  it 'registers an offence for $"' do
+    inspect_source(cop, ['puts $"'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Prefer $LOADED_FEATURES over $".'])
+  end
+
+  it 'registers an offence for $0' do
+    inspect_source(cop, ['puts $0'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Prefer $PROGRAM_NAME over $0.'])
+  end
+
+  it 'registers an offence for $$' do
+    inspect_source(cop, ['puts $$'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Prefer $PID or $PROCESS_ID from English library' +
+        ' over $$.'])
+  end
+
+  it 'does not register an offence for backrefs like $1' do
+    inspect_source(cop, ['puts $1'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'auto-corrects $: to $LOAD_PATH' do
+    new_source = autocorrect_source(cop, '$:')
+    expect(new_source).to eq('$LOAD_PATH')
   end
 end