rubocop 0.13.1 → 0.14.0

data/spec/rubocop/cop/lint/debugger_spec.rb

@@ -0,0 +1,39 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Lint::Debugger do
+  subject(:cop) { described_class.new  }
+
+  it 'reports an offence for a debugger call' do
+    src = ['debugger']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'reports an offence for pry bindings' do
+    src = ['binding.pry',
+           'binding.remote_pry']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(2)
+  end
+
+  it 'does not report an offence for non-pry binding' do
+    src = ['binding.pirate']
+    inspect_source(cop, src)
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does not report an offence for debugger in comments' do
+    src = ['# debugger']
+    inspect_source(cop, src)
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does not report an offence for a debugger or pry method' do
+    src = ['code.debugger',
+           'door.pry']
+    inspect_source(cop, src)
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/lint/empty_ensure_spec.rb

@@ -2,32 +2,26 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Lint
-      describe EmptyEnsure do
-        subject(:cop) { EmptyEnsure.new }
+describe Rubocop::Cop::Lint::EmptyEnsure do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for empty ensure' do
-          inspect_source(cop,
-                         ['begin',
-                          '  something',
-                          'ensure',
-                          'end'])
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'registers an offence for empty ensure' do
+    inspect_source(cop,
+                   ['begin',
+                    '  something',
+                    'ensure',
+                    'end'])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'does not register an offence for non-empty ensure' do
-          inspect_source(cop,
-                         ['begin',
-                          '  something',
-                          '  return',
-                          'ensure',
-                          '  file.close',
-                          'end'])
-          expect(cop.offences).to be_empty
-        end
-      end
-    end
+  it 'does not register an offence for non-empty ensure' do
+    inspect_source(cop,
+                   ['begin',
+                    '  something',
+                    '  return',
+                    'ensure',
+                    '  file.close',
+                    'end'])
+    expect(cop.offences).to be_empty
   end
 end

data/spec/rubocop/cop/lint/end_alignment_spec.rb

@@ -3,68 +3,62 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Lint
-      describe EndAlignment do
-        subject(:cop) { EndAlignment.new }
+describe Rubocop::Cop::Lint::EndAlignment do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for mismatched class end' do
-          inspect_source(cop,
-                         ['class Test',
-                          '  end'
-                         ])
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'registers an offence for mismatched class end' do
+    inspect_source(cop,
+                   ['class Test',
+                    '  end'
+                   ])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'registers an offence for mismatched module end' do
-          inspect_source(cop,
-                         ['module Test',
-                          '  end'
-                         ])
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'registers an offence for mismatched module end' do
+    inspect_source(cop,
+                   ['module Test',
+                    '  end'
+                   ])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'registers an offence for mismatched def end' do
-          inspect_source(cop,
-                         ['def test',
-                          '  end'
-                         ])
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'registers an offence for mismatched def end' do
+    inspect_source(cop,
+                   ['def test',
+                    '  end'
+                   ])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'registers an offence for mismatched defs end' do
-          inspect_source(cop,
-                         ['def Test.test',
-                          '  end'
-                         ])
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'registers an offence for mismatched defs end' do
+    inspect_source(cop,
+                   ['def Test.test',
+                    '  end'
+                   ])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'registers an offence for mismatched if end' do
-          inspect_source(cop,
-                         ['if test',
-                          '  end'
-                         ])
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'registers an offence for mismatched if end' do
+    inspect_source(cop,
+                   ['if test',
+                    '  end'
+                   ])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'registers an offence for mismatched while end' do
-          inspect_source(cop,
-                         ['while test',
-                          '  end'
-                         ])
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'registers an offence for mismatched while end' do
+    inspect_source(cop,
+                   ['while test',
+                    '  end'
+                   ])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'registers an offence for mismatched until end' do
-          inspect_source(cop,
-                         ['until test',
-                          '  end'
-                         ])
-          expect(cop.offences.size).to eq(1)
-        end
-      end
-    end
+  it 'registers an offence for mismatched until end' do
+    inspect_source(cop,
+                   ['until test',
+                    '  end'
+                   ])
+    expect(cop.offences.size).to eq(1)
   end
 end

data/spec/rubocop/cop/lint/end_in_method_spec.rb

@@ -2,34 +2,28 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Lint
-      describe EndInMethod do
-        subject(:cop) { EndInMethod.new }
+describe Rubocop::Cop::Lint::EndInMethod do
+  subject(:cop) { described_class.new }
 
-        it 'reports an offence for def with an END inside' do
-          src = ['def test',
-                 '  END { something }',
-                 'end']
-          inspect_source(cop, src)
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'reports an offence for def with an END inside' do
+    src = ['def test',
+           '  END { something }',
+           'end']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'reports an offence for defs with an END inside' do
-          src = ['def self.test',
-                 '  END { something }',
-                 'end']
-          inspect_source(cop, src)
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'reports an offence for defs with an END inside' do
+    src = ['def self.test',
+           '  END { something }',
+           'end']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'accepts END outside of def(s)' do
-          src = ['END { something }']
-          inspect_source(cop, src)
-          expect(cop.offences).to be_empty
-        end
-      end
-    end
+  it 'accepts END outside of def(s)' do
+    src = ['END { something }']
+    inspect_source(cop, src)
+    expect(cop.offences).to be_empty
   end
 end

data/spec/rubocop/cop/lint/ensure_return_spec.rb

@@ -2,44 +2,38 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Lint
-      describe EnsureReturn do
-        subject(:cop) { EnsureReturn.new }
+describe Rubocop::Cop::Lint::EnsureReturn do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for return in ensure' do
-          inspect_source(cop,
-                         ['begin',
-                          '  something',
-                          'ensure',
-                          '  file.close',
-                          '  return',
-                          'end'])
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'registers an offence for return in ensure' do
+    inspect_source(cop,
+                   ['begin',
+                    '  something',
+                    'ensure',
+                    '  file.close',
+                    '  return',
+                    'end'])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'does not register an offence for return outside ensure' do
-          inspect_source(cop,
-                         ['begin',
-                          '  something',
-                          '  return',
-                          'ensure',
-                          '  file.close',
-                          'end'])
-          expect(cop.offences).to be_empty
-        end
+  it 'does not register an offence for return outside ensure' do
+    inspect_source(cop,
+                   ['begin',
+                    '  something',
+                    '  return',
+                    'ensure',
+                    '  file.close',
+                    'end'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'does not check when ensure block has no body' do
-          expect do
-            inspect_source(cop,
-                           ['begin',
-                            '  something',
-                            'ensure',
-                            'end'])
-          end.to_not raise_exception
-        end
-      end
-    end
+  it 'does not check when ensure block has no body' do
+    expect do
+      inspect_source(cop,
+                     ['begin',
+                      '  something',
+                      'ensure',
+                      'end'])
+    end.to_not raise_exception
   end
 end

data/spec/rubocop/cop/lint/eval_spec.rb

@@ -2,40 +2,34 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Lint
-      describe Eval do
-        subject(:a) { Eval.new }
+describe Rubocop::Cop::Lint::Eval do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for eval as function' do
-          inspect_source(a,
-                         ['eval(something)'])
-          expect(a.offences.size).to eq(1)
-          expect(a.messages)
-            .to eq([Eval::MSG])
-        end
+  it 'registers an offence for eval as function' do
+    inspect_source(cop,
+                   ['eval(something)'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['The use of eval is a serious security risk.'])
+  end
 
-        it 'registers an offence for eval as command' do
-          inspect_source(a,
-                         ['eval something'])
-          expect(a.offences.size).to eq(1)
-          expect(a.messages)
-            .to eq([Eval::MSG])
-        end
+  it 'registers an offence for eval as command' do
+    inspect_source(cop,
+                   ['eval something'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['The use of eval is a serious security risk.'])
+  end
 
-        it 'does not register an offence for eval as variable' do
-          inspect_source(a,
-                         ['eval = something'])
-          expect(a.offences).to be_empty
-        end
+  it 'does not register an offence for eval as variable' do
+    inspect_source(cop,
+                   ['eval = something'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'does not register an offence for eval as method' do
-          inspect_source(a,
-                         ['something.eval'])
-          expect(a.offences).to be_empty
-        end
-      end
-    end
+  it 'does not register an offence for eval as method' do
+    inspect_source(cop,
+                   ['something.eval'])
+    expect(cop.offences).to be_empty
   end
 end

data/spec/rubocop/cop/lint/handle_exceptions_spec.rb

@@ -2,35 +2,29 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Lint
-      describe HandleExceptions do
-        subject(:he) { HandleExceptions.new }
+describe Rubocop::Cop::Lint::HandleExceptions do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for empty rescue block' do
-          inspect_source(he,
-                         ['begin',
-                          '  something',
-                          'rescue',
-                          '  #do nothing',
-                          'end'])
-          expect(he.offences.size).to eq(1)
-          expect(he.messages)
-            .to eq([HandleExceptions::MSG])
-        end
+  it 'registers an offence for empty rescue block' do
+    inspect_source(cop,
+                   ['begin',
+                    '  something',
+                    'rescue',
+                    '  #do nothing',
+                    'end'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Do not suppress exceptions.'])
+  end
 
-        it 'does not register an offence for rescue with body' do
-          inspect_source(he,
-                         ['begin',
-                          '  something',
-                          '  return',
-                          'rescue',
-                          '  file.close',
-                          'end'])
-          expect(he.offences).to be_empty
-        end
-      end
-    end
+  it 'does not register an offence for rescue with body' do
+    inspect_source(cop,
+                   ['begin',
+                    '  something',
+                    '  return',
+                    'rescue',
+                    '  file.close',
+                    'end'])
+    expect(cop.offences).to be_empty
   end
 end