rubocop 0.13.1 → 0.14.0

data/spec/rubocop/cop/style/favor_sprintf_spec.rb

@@ -2,52 +2,46 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe FavorSprintf do
-        subject(:fs) { FavorSprintf.new }
-
-        it 'registers an offence for a string followed by something' do
-          inspect_source(fs,
-                         ['puts "%d" % 10'])
-          expect(fs.offences.size).to eq(1)
-          expect(fs.messages)
-            .to eq([FavorSprintf::MSG])
-        end
-
-        it 'registers an offence for something followed by an array' do
-          inspect_source(fs,
-                         ['puts x % [10, 11]'])
-          expect(fs.offences.size).to eq(1)
-          expect(fs.messages)
-            .to eq([FavorSprintf::MSG])
-        end
-
-        it 'does not register an offence for numbers' do
-          inspect_source(fs,
-                         ['puts 10 % 4'])
-          expect(fs.offences).to be_empty
-        end
-
-        it 'does not register an offence for ambiguous cases' do
-          inspect_source(fs,
-                         ['puts x % 4'])
-          expect(fs.offences).to be_empty
-
-          inspect_source(fs,
-                         ['puts x % Y'])
-          expect(fs.offences).to be_empty
-        end
-
-        it 'works if the first operand contains embedded expressions' do
-          inspect_source(fs,
-                         ['puts "#{x * 5} %d #{@test}" % 10'])
-          expect(fs.offences.size).to eq(1)
-          expect(fs.messages)
-            .to eq([FavorSprintf::MSG])
-        end
-      end
-    end
+describe Rubocop::Cop::Style::FavorSprintf do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for a string followed by something' do
+    inspect_source(cop,
+                   ['puts "%d" % 10'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Favor sprintf over String#%.'])
+  end
+
+  it 'registers an offence for something followed by an array' do
+    inspect_source(cop,
+                   ['puts x % [10, 11]'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Favor sprintf over String#%.'])
+  end
+
+  it 'does not register an offence for numbers' do
+    inspect_source(cop,
+                   ['puts 10 % 4'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does not register an offence for ambiguous cases' do
+    inspect_source(cop,
+                   ['puts x % 4'])
+    expect(cop.offences).to be_empty
+
+    inspect_source(cop,
+                   ['puts x % Y'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'works if the first operand contains embedded expressions' do
+    inspect_source(cop,
+                   ['puts "#{x * 5} %d #{@test}" % 10'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Favor sprintf over String#%.'])
   end
 end

data/spec/rubocop/cop/style/favor_unless_over_negated_if_spec.rb

@@ -2,81 +2,75 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe FavorUnlessOverNegatedIf do
-        subject(:cop) { described_class.new }
+describe Rubocop::Cop::Style::FavorUnlessOverNegatedIf do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for if with exclamation point condition' do
-          inspect_source(cop,
-                         ['if !a_condition',
-                          '  some_method',
-                          'end',
-                          'some_method if !a_condition',
-                         ])
-          expect(cop.messages).to eq(
-            ['Favor unless (or control flow or) over if for negative ' +
-             'conditions.'] * 2)
-        end
+  it 'registers an offence for if with exclamation point condition' do
+    inspect_source(cop,
+                   ['if !a_condition',
+                    '  some_method',
+                    'end',
+                    'some_method if !a_condition',
+                   ])
+    expect(cop.messages).to eq(
+      ['Favor unless (or control flow or) over if for negative ' +
+       'conditions.'] * 2)
+  end
 
-        it 'registers an offence for if with "not" condition' do
-          inspect_source(cop,
-                         ['if not a_condition',
-                          '  some_method',
-                          'end',
-                          'some_method if not a_condition'])
-          expect(cop.messages).to eq(
-            ['Favor unless (or control flow or) over if for negative ' +
-             'conditions.'] * 2)
-          expect(cop.offences.map(&:line)).to eq([1, 4])
-        end
+  it 'registers an offence for if with "not" condition' do
+    inspect_source(cop,
+                   ['if not a_condition',
+                    '  some_method',
+                    'end',
+                    'some_method if not a_condition'])
+    expect(cop.messages).to eq(
+      ['Favor unless (or control flow or) over if for negative ' +
+       'conditions.'] * 2)
+    expect(cop.offences.map(&:line)).to eq([1, 4])
+  end
 
-        it 'accepts an if/else with negative condition' do
-          inspect_source(cop,
-                         ['if !a_condition',
-                          '  some_method',
-                          'else',
-                          '  something_else',
-                          'end',
-                          'if not a_condition',
-                          '  some_method',
-                          'elsif other_condition',
-                          '  something_else',
-                          'end'])
-          expect(cop.offences).to be_empty
-        end
+  it 'accepts an if/else with negative condition' do
+    inspect_source(cop,
+                   ['if !a_condition',
+                    '  some_method',
+                    'else',
+                    '  something_else',
+                    'end',
+                    'if not a_condition',
+                    '  some_method',
+                    'elsif other_condition',
+                    '  something_else',
+                    'end'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'accepts an if where only part of the contition is negated' do
-          inspect_source(cop,
-                         ['if !condition && another_condition',
-                          '  some_method',
-                          'end',
-                          'if not condition or another_condition',
-                          '  some_method',
-                          'end',
-                          'some_method if not condition or another_condition'])
-          expect(cop.offences).to be_empty
-        end
+  it 'accepts an if where only part of the contition is negated' do
+    inspect_source(cop,
+                   ['if !condition && another_condition',
+                    '  some_method',
+                    'end',
+                    'if not condition or another_condition',
+                    '  some_method',
+                    'end',
+                    'some_method if not condition or another_condition'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'is not confused by negated elsif' do
-          inspect_source(cop,
-                         ['if test.is_a?(String)',
-                          '  3',
-                          'elsif test.is_a?(Array)',
-                          '  2',
-                          'elsif !test.nil?',
-                          '  1',
-                          'end'])
+  it 'is not confused by negated elsif' do
+    inspect_source(cop,
+                   ['if test.is_a?(String)',
+                    '  3',
+                    'elsif test.is_a?(Array)',
+                    '  2',
+                    'elsif !test.nil?',
+                    '  1',
+                    'end'])
 
-          expect(cop.offences).to be_empty
-        end
+    expect(cop.offences).to be_empty
+  end
 
-        it 'does not blow up for ternary ops' do
-          inspect_source(cop, 'a ? b : c')
-          expect(cop.offences).to be_empty
-        end
-      end
-    end
+  it 'does not blow up for ternary ops' do
+    inspect_source(cop, 'a ? b : c')
+    expect(cop.offences).to be_empty
   end
 end

data/spec/rubocop/cop/style/favor_until_over_negated_while_spec.rb

@@ -2,46 +2,40 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe FavorUntilOverNegatedWhile do
-        subject(:fav_until) { FavorUntilOverNegatedWhile.new }
+describe Rubocop::Cop::Style::FavorUntilOverNegatedWhile do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for while with exclamation point condition' do
-          inspect_source(fav_until,
-                         ['while !a_condition',
-                          '  some_method',
-                          'end',
-                          'some_method while !a_condition',
-                         ])
-          expect(fav_until.messages).to eq(
-            ['Favor until over while for negative conditions.'] * 2)
-        end
+  it 'registers an offence for while with exclamation point condition' do
+    inspect_source(cop,
+                   ['while !a_condition',
+                    '  some_method',
+                    'end',
+                    'some_method while !a_condition',
+                   ])
+    expect(cop.messages).to eq(
+      ['Favor until over while for negative conditions.'] * 2)
+  end
 
-        it 'registers an offence for while with "not" condition' do
-          inspect_source(fav_until,
-                         ['while (not a_condition)',
-                          '  some_method',
-                          'end',
-                          'some_method while not a_condition'])
-          expect(fav_until.messages).to eq(
-            ['Favor until over while for negative conditions.'] * 2)
-          expect(fav_until.offences.map(&:line)).to eq([1, 4])
-        end
+  it 'registers an offence for while with "not" condition' do
+    inspect_source(cop,
+                   ['while (not a_condition)',
+                    '  some_method',
+                    'end',
+                    'some_method while not a_condition'])
+    expect(cop.messages).to eq(
+      ['Favor until over while for negative conditions.'] * 2)
+    expect(cop.offences.map(&:line)).to eq([1, 4])
+  end
 
-        it 'accepts an while where only part of the contition is negated' do
-          inspect_source(fav_until,
-                         ['while !a_condition && another_condition',
-                          '  some_method',
-                          'end',
-                          'while not a_condition or another_condition',
-                          '  some_method',
-                          'end',
-                          'some_method while not a_condition or other_cond'])
-          expect(fav_until.messages).to be_empty
-        end
-      end
-    end
+  it 'accepts an while where only part of the contition is negated' do
+    inspect_source(cop,
+                   ['while !a_condition && another_condition',
+                    '  some_method',
+                    'end',
+                    'while not a_condition or another_condition',
+                    '  some_method',
+                    'end',
+                    'some_method while not a_condition or other_cond'])
+    expect(cop.messages).to be_empty
   end
 end

data/spec/rubocop/cop/style/final_newline_spec.rb

@@ -2,30 +2,24 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe FinalNewline do
-        subject(:cop) { described_class.new }
+describe Rubocop::Cop::Style::FinalNewline do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for missing final newline' do
-          source = ['x = 0', 'top']
-          inspect_source(cop, source)
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'registers an offence for missing final newline' do
+    source = ['x = 0', 'top']
+    inspect_source(cop, source)
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'accepts a final newline' do
-          source = ['x = 0', 'top', '']
-          inspect_source(cop, source)
-          expect(cop.offences).to be_empty
-        end
+  it 'accepts a final newline' do
+    source = ['x = 0', 'top', '']
+    inspect_source(cop, source)
+    expect(cop.offences).to be_empty
+  end
 
-        it 'accepts an empty file' do
-          source = ['']
-          inspect_source(cop, source)
-          expect(cop.offences).to be_empty
-        end
-      end
-    end
+  it 'accepts an empty file' do
+    source = ['']
+    inspect_source(cop, source)
+    expect(cop.offences).to be_empty
   end
 end

data/spec/rubocop/cop/style/for_spec.rb

@@ -2,32 +2,26 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe For do
-        subject(:cop) { described_class.new }
+describe Rubocop::Cop::Style::For do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for for' do
-          inspect_source(cop,
-                         ['def func',
-                          '  for n in [1, 2, 3] do',
-                          '    puts n',
-                          '  end',
-                          'end'])
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'registers an offence for for' do
+    inspect_source(cop,
+                   ['def func',
+                    '  for n in [1, 2, 3] do',
+                    '    puts n',
+                    '  end',
+                    'end'])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'does not register an offence for :for' do
-          inspect_source(cop, ['[:for, :ala, :bala]'])
-          expect(cop.offences).to be_empty
-        end
+  it 'does not register an offence for :for' do
+    inspect_source(cop, ['[:for, :ala, :bala]'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'does not register an offence for def for' do
-          inspect_source(cop, ['def for; end'])
-          expect(cop.offences).to be_empty
-        end
-      end
-    end
+  it 'does not register an offence for def for' do
+    inspect_source(cop, ['def for; end'])
+    expect(cop.offences).to be_empty
   end
 end

data/spec/rubocop/cop/style/global_vars_spec.rb

@@ -2,39 +2,33 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe GlobalVars, :config do
-        cop_config = {
-          'AllowedVariables' => ['$allowed']
-        }
+describe Rubocop::Cop::Style::GlobalVars, :config do
+  cop_config = {
+    'AllowedVariables' => ['$allowed']
+  }
 
-        subject(:cop) { described_class.new(config) }
-        let(:cop_config) { cop_config }
+  subject(:cop) { described_class.new(config) }
+  let(:cop_config) { cop_config }
 
-        it 'registers an offence for $custom' do
-          inspect_source(cop, ['puts $custom'])
-          expect(cop.offences.size).to eq(1)
-        end
-
-        it 'allows user whitelisted variables' do
-          inspect_source(cop, ['puts $allowed'])
-          expect(cop.offences).to be_empty
-        end
+  it 'registers an offence for $custom' do
+    inspect_source(cop, ['puts $custom'])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        described_class::BUILT_IN_VARS.each do |var|
-          it "does not register an offence for built-in variable #{var}" do
-            inspect_source(cop, ["puts #{var}"])
-            expect(cop.offences).to be_empty
-          end
-        end
+  it 'allows user whitelisted variables' do
+    inspect_source(cop, ['puts $allowed'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'does not register an offence for backrefs like $1' do
-          inspect_source(cop, ['puts $1'])
-          expect(cop.offences).to be_empty
-        end
-      end
+  described_class::BUILT_IN_VARS.each do |var|
+    it "does not register an offence for built-in variable #{var}" do
+      inspect_source(cop, ["puts #{var}"])
+      expect(cop.offences).to be_empty
     end
   end
+
+  it 'does not register an offence for backrefs like $1' do
+    inspect_source(cop, ['puts $1'])
+    expect(cop.offences).to be_empty
+  end
 end