rubocop 0.13.1 → 0.14.0

data/spec/rubocop/cop/style/constant_name_spec.rb

@@ -2,64 +2,58 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe ConstantName do
-        subject(:const) { ConstantName.new }
+describe Rubocop::Cop::Style::ConstantName do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for camel case in const name' do
-          inspect_source(const,
-                         ['TopCase = 5'])
-          expect(const.offences.size).to eq(1)
-        end
+  it 'registers an offence for camel case in const name' do
+    inspect_source(cop,
+                   ['TopCase = 5'])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'registers offences for camel case in multiple const assignment' do
-          inspect_source(const,
-                         ['TopCase, Test2, TEST_3 = 5, 6, 7'])
-          expect(const.offences.size).to eq(2)
-        end
+  it 'registers offences for camel case in multiple const assignment' do
+    inspect_source(cop,
+                   ['TopCase, Test2, TEST_3 = 5, 6, 7'])
+    expect(cop.offences.size).to eq(2)
+  end
 
-        it 'registers an offence for snake case in const name' do
-          inspect_source(const,
-                         ['TOP_test = 5'])
-          expect(const.offences.size).to eq(1)
-        end
+  it 'registers an offence for snake case in const name' do
+    inspect_source(cop,
+                   ['TOP_test = 5'])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'allows screaming snake case in const name' do
-          inspect_source(const,
-                         ['TOP_TEST = 5'])
-          expect(const.offences).to be_empty
-        end
+  it 'allows screaming snake case in const name' do
+    inspect_source(cop,
+                   ['TOP_TEST = 5'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'allows screaming snake case in multiple const assignment' do
-          inspect_source(const,
-                         ['TOP_TEST, TEST_2 = 5, 6'])
-          expect(const.offences).to be_empty
-        end
+  it 'allows screaming snake case in multiple const assignment' do
+    inspect_source(cop,
+                   ['TOP_TEST, TEST_2 = 5, 6'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'does not check names if rhs is a method call' do
-          inspect_source(const,
-                         ['AnythingGoes = test'])
-          expect(const.offences).to be_empty
-        end
+  it 'does not check names if rhs is a method call' do
+    inspect_source(cop,
+                   ['AnythingGoes = test'])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'does not check names if rhs is a method call with block' do
-          inspect_source(const,
-                         ['AnythingGoes = test do',
-                          '  do_something',
-                          'end'
-                          ])
-          expect(const.offences).to be_empty
-        end
+  it 'does not check names if rhs is a method call with block' do
+    inspect_source(cop,
+                   ['AnythingGoes = test do',
+                    '  do_something',
+                    'end'
+                    ])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'checks qualified const names' do
-          inspect_source(const,
-                         ['::AnythingGoes = 30',
-                          'a::Bar_foo = 10'])
-          expect(const.offences.size).to eq(2)
-        end
-      end
-    end
+  it 'checks qualified const names' do
+    inspect_source(cop,
+                   ['::AnythingGoes = 30',
+                    'a::Bar_foo = 10'])
+    expect(cop.offences.size).to eq(2)
   end
 end

data/spec/rubocop/cop/style/def_with_parentheses_spec.rb

@@ -2,44 +2,38 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe DefWithParentheses do
-        subject(:cop) { described_class.new }
+describe Rubocop::Cop::Style::DefWithParentheses do
+  subject(:cop) { described_class.new }
 
-        it 'reports an offence for def with empty parens' do
-          src = ['def func()',
-                 'end']
-          inspect_source(cop, src)
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'reports an offence for def with empty parens' do
+    src = ['def func()',
+           'end']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'reports an offence for class def with empty parens' do
-          src = ['def Test.func()',
-                 'end']
-          inspect_source(cop, src)
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'reports an offence for class def with empty parens' do
+    src = ['def Test.func()',
+           'end']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'accepts def with arg and parens' do
-          src = ['def func(a)',
-                 'end']
-          inspect_source(cop, src)
-          expect(cop.offences).to be_empty
-        end
+  it 'accepts def with arg and parens' do
+    src = ['def func(a)',
+           'end']
+    inspect_source(cop, src)
+    expect(cop.offences).to be_empty
+  end
 
-        it 'accepts empty parentheses in one liners' do
-          src = ["def to_s() join '/' end"]
-          inspect_source(cop, src)
-          expect(cop.offences).to be_empty
-        end
+  it 'accepts empty parentheses in one liners' do
+    src = ["def to_s() join '/' end"]
+    inspect_source(cop, src)
+    expect(cop.offences).to be_empty
+  end
 
-        it 'auto-removes unneeded parens' do
-          new_source = autocorrect_source(cop, "def test();\nsomething\nend")
-          expect(new_source).to eq("def test;\nsomething\nend")
-        end
-      end
-    end
+  it 'auto-removes unneeded parens' do
+    new_source = autocorrect_source(cop, "def test();\nsomething\nend")
+    expect(new_source).to eq("def test;\nsomething\nend")
   end
 end

data/spec/rubocop/cop/style/def_without_parentheses_spec.rb

@@ -2,38 +2,32 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe DefWithoutParentheses do
-        subject(:cop) { described_class.new }
+describe Rubocop::Cop::Style::DefWithoutParentheses do
+  subject(:cop) { described_class.new }
 
-        it 'reports an offence for def with parameters but no parens' do
-          src = ['def func a, b',
-                 'end']
-          inspect_source(cop, src)
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'reports an offence for def with parameters but no parens' do
+    src = ['def func a, b',
+           'end']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'reports an offence for class def with parameters but no parens' do
-          src = ['def Test.func a, b',
-                 'end']
-          inspect_source(cop, src)
-          expect(cop.offences.size).to eq(1)
-        end
+  it 'reports an offence for class def with parameters but no parens' do
+    src = ['def Test.func a, b',
+           'end']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'accepts def with no args and no parens' do
-          src = ['def func',
-                 'end']
-          inspect_source(cop, src)
-          expect(cop.offences).to be_empty
-        end
+  it 'accepts def with no args and no parens' do
+    src = ['def func',
+           'end']
+    inspect_source(cop, src)
+    expect(cop.offences).to be_empty
+  end
 
-        it 'auto-adds required parens' do
-          new_source = autocorrect_source(cop, 'def test param; end')
-          expect(new_source).to eq('def test (param); end')
-        end
-      end
-    end
+  it 'auto-adds required parens' do
+    new_source = autocorrect_source(cop, 'def test param; end')
+    expect(new_source).to eq('def test (param); end')
   end
 end

data/spec/rubocop/cop/style/documentation_spec.rb

@@ -2,78 +2,72 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe Documentation do
-        subject(:documentation) { Documentation.new }
+describe Rubocop::Cop::Style::Documentation do
+  subject(:cop) { described_class.new }
 
-        it 'registers an offence for non-empty class' do
-          inspect_source(documentation,
-                         ['class My_Class',
-                          '  TEST = 20',
-                          'end'
-                         ])
-          expect(documentation.offences.size).to eq(1)
-        end
+  it 'registers an offence for non-empty class' do
+    inspect_source(cop,
+                   ['class My_Class',
+                    '  TEST = 20',
+                    'end'
+                   ])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'registers an offence for non-namespace' do
-          inspect_source(documentation,
-                         ['module My_Class',
-                          '  TEST = 20',
-                          'end'
-                         ])
-          expect(documentation.offences.size).to eq(1)
-        end
+  it 'registers an offence for non-namespace' do
+    inspect_source(cop,
+                   ['module My_Class',
+                    '  TEST = 20',
+                    'end'
+                   ])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'registers an offence for empty module without documentation' do
-          # Because why would you have an empty module? It requires some
-          # explanation.
-          inspect_source(documentation,
-                         ['module Test',
-                          'end'
-                         ])
-          expect(documentation.offences.size).to eq(1)
-        end
+  it 'registers an offence for empty module without documentation' do
+    # Because why would you have an empty module? It requires some
+    # explanation.
+    inspect_source(cop,
+                   ['module Test',
+                    'end'
+                   ])
+    expect(cop.offences.size).to eq(1)
+  end
 
-        it 'accepts non-empty class with documentation' do
-          inspect_source(documentation,
-                         ['# class comment',
-                          'class My_Class',
-                          '  TEST = 20',
-                          'end'
-                         ])
-          expect(documentation.offences).to be_empty
-        end
+  it 'accepts non-empty class with documentation' do
+    inspect_source(cop,
+                   ['# class comment',
+                    'class My_Class',
+                    '  TEST = 20',
+                    'end'
+                   ])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'accepts non-empty module with documentation' do
-          inspect_source(documentation,
-                         ['# class comment',
-                          'module My_Class',
-                          '  TEST = 20',
-                          'end'
-                         ])
-          expect(documentation.offences).to be_empty
-        end
+  it 'accepts non-empty module with documentation' do
+    inspect_source(cop,
+                   ['# class comment',
+                    'module My_Class',
+                    '  TEST = 20',
+                    'end'
+                   ])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'accepts empty class without documentation' do
-          inspect_source(documentation,
-                         ['class My_Class',
-                          'end'
-                         ])
-          expect(documentation.offences).to be_empty
-        end
+  it 'accepts empty class without documentation' do
+    inspect_source(cop,
+                   ['class My_Class',
+                    'end'
+                   ])
+    expect(cop.offences).to be_empty
+  end
 
-        it 'accepts namespace module without documentation' do
-          inspect_source(documentation,
-                         ['module Test',
-                          '  class A; end',
-                          '  class B; end',
-                          'end'
-                         ])
-          expect(documentation.offences).to be_empty
-        end
-      end
-    end
+  it 'accepts namespace module without documentation' do
+    inspect_source(cop,
+                   ['module Test',
+                    '  class A; end',
+                    '  class B; end',
+                    'end'
+                   ])
+    expect(cop.offences).to be_empty
   end
 end

data/spec/rubocop/cop/style/dot_position_spec.rb

@@ -2,74 +2,68 @@
 
 require 'spec_helper'
 
-module Rubocop
-  module Cop
-    module Style
-      describe DotPosition, :config do
-        subject(:cop) { DotPosition.new(config) }
+describe Rubocop::Cop::Style::DotPosition, :config do
+  subject(:cop) { described_class.new(config) }
 
-        context 'Leading dots style' do
-          let(:cop_config) { { 'Style' => 'Leading' } }
+  context 'Leading dots style' do
+    let(:cop_config) { { 'Style' => 'Leading' } }
 
-          it 'registers an offence for trailing dot in multi-line call' do
-            inspect_source(cop, ['something.',
-                                 '  method_name'])
-            expect(cop.offences.size).to eq(1)
-          end
+    it 'registers an offence for trailing dot in multi-line call' do
+      inspect_source(cop, ['something.',
+                           '  method_name'])
+      expect(cop.offences.size).to eq(1)
+    end
 
-          it 'accepts leading do in multi-line method call' do
-            inspect_source(cop, ['something',
-                                 '  .method_name'])
-            expect(cop.offences).to be_empty
-          end
+    it 'accepts leading do in multi-line method call' do
+      inspect_source(cop, ['something',
+                           '  .method_name'])
+      expect(cop.offences).to be_empty
+    end
 
-          it 'does not err on method call with no dots' do
-            inspect_source(cop, ['puts something'])
-            expect(cop.offences).to be_empty
-          end
+    it 'does not err on method call with no dots' do
+      inspect_source(cop, ['puts something'])
+      expect(cop.offences).to be_empty
+    end
 
-          it 'does not err on method call without a method name' do
-            inspect_source(cop, ['l.', '(1)'])
-            expect(cop.offences.size).to eq(1)
-          end
-        end
+    it 'does not err on method call without a method name' do
+      inspect_source(cop, ['l.', '(1)'])
+      expect(cop.offences.size).to eq(1)
+    end
+  end
 
-        context 'Trailing dots style' do
-          let(:cop_config) { { 'Style' => 'Trailing' } }
+  context 'Trailing dots style' do
+    let(:cop_config) { { 'Style' => 'Trailing' } }
 
-          it 'registers an offence for leading dot in multi-line call' do
-            inspect_source(cop, ['something',
-                                 '  .method_name'])
-            expect(cop.offences.size).to eq(1)
-          end
+    it 'registers an offence for leading dot in multi-line call' do
+      inspect_source(cop, ['something',
+                           '  .method_name'])
+      expect(cop.offences.size).to eq(1)
+    end
 
-          it 'accepts trailing dot in multi-line method call' do
-            inspect_source(cop, ['something.',
-                                 '  method_name'])
-            expect(cop.offences).to be_empty
-          end
+    it 'accepts trailing dot in multi-line method call' do
+      inspect_source(cop, ['something.',
+                           '  method_name'])
+      expect(cop.offences).to be_empty
+    end
 
-          it 'does not err on method call with no dots' do
-            inspect_source(cop, ['puts something'])
-            expect(cop.offences).to be_empty
-          end
+    it 'does not err on method call with no dots' do
+      inspect_source(cop, ['puts something'])
+      expect(cop.offences).to be_empty
+    end
 
-          it 'does not err on method call without a method name' do
-            inspect_source(cop, ['l', '.(1)'])
-            expect(cop.offences.size).to eq(1)
-          end
-        end
+    it 'does not err on method call without a method name' do
+      inspect_source(cop, ['l', '.(1)'])
+      expect(cop.offences.size).to eq(1)
+    end
+  end
 
-        context 'Unknown style' do
-          let(:cop_config) { { 'Style' => 'test' } }
+  context 'Unknown style' do
+    let(:cop_config) { { 'Style' => 'test' } }
 
-          it 'raises an exception' do
-            expect do
-              inspect_source(cop, ['something.top'])
-            end.to raise_error(RuntimeError)
-          end
-        end
-      end
+    it 'raises an exception' do
+      expect do
+        inspect_source(cop, ['something.top'])
+      end.to raise_error(RuntimeError)
     end
   end
 end