ripple 0.9.5 → 1.0.0.beta

data/spec/ripple/associations/many_reference_proxy_spec.rb

@@ -0,0 +1,170 @@
+require 'spec_helper'
+
+describe Ripple::Associations::ManyReferenceProxy do
+  # require 'support/models/transactions'
+
+  before :each do
+    @account = Account.new {|e| e.key = "accounty"}
+    @payment_method = PaymentMethod.new {|e| e.key = "paymadoo"}
+    @other_payment_method = PaymentMethod.new {|e| e.key = "otherpaym"}
+    Ripple.client.stub(:search => {"response" => {"docs" => []}})
+  end
+
+  it "should be empty before any associated documents are set" do
+    @account.payment_methods.should be_empty
+  end
+
+  it "should accept an array of documents" do
+    @account.payment_methods = [@payment_method]
+  end
+
+  it "should set the key on the sub object when assigning" do
+    @account.payment_methods = [@payment_method]
+    @payment_method.account_key.should == "accounty"
+  end
+
+  it "should be able to replace the entire collection of documents (even appended ones)" do
+    @account.payment_methods << @payment_method
+    @account.payment_methods = [@other_payment_method]
+    @account.payment_methods.should == [@other_payment_method]
+  end
+
+  it "should return the assigned documents when assigning" do
+    t = (@account.payment_methods = [@payment_method])
+    t.should == [@payment_method]
+  end
+
+  it "should find the associated documents when accessing" do
+    Ripple.client.should_receive(:search).with("payment_methods", "account_key: accounty").and_return({"response" => {"docs" => ["id" => "paymadoo"]}})
+    PaymentMethod.should_receive(:find).with(["paymadoo"]).and_return([@payment_method])
+    @account.payment_methods.should == [@payment_method]
+  end
+
+  it "should replace associated documents with a new set" do
+    @account.payment_methods = [@payment_method]
+    @account.payment_methods = [@other_payment_method]
+    @account.payment_methods.should == [@other_payment_method]
+  end
+
+  it "should return an array from to_ary" do
+    @account.payment_methods << @payment_method
+    @account.payment_methods.to_ary.should == [@payment_method]
+  end
+
+  it "should refuse assigning a collection of the wrong type" do
+    lambda { @account.payment_methods = nil }.should raise_error
+    lambda { @account.payment_methods = @payment_method }.should raise_error
+    lambda { @account.payment_methods = [@account] }.should raise_error
+  end
+
+  describe "#<< (when the target has not already been loaded)" do
+    it "avoids searching when adding a record to an unloaded association" do
+      PaymentMethod.should_not_receive(:search)
+      @account.payment_methods << @payment_method
+    end
+
+    it "should be able to count the associated documents" do
+      @account.payment_methods << @payment_method
+      @account.payment_methods.count.should == 1
+      @account.payment_methods << @other_payment_method
+      @account.payment_methods.count.should == 2
+    end
+
+    it "should be able to count without loading documents" do
+      Ripple.client.stub(:search => {"response" => {"docs" => [{"id" => @payment_method.key}, {"id" => @other_payment_method.key}]}})
+      PaymentMethod.should_not_receive(:find)
+      @account.payment_methods.count.should == 2
+    end
+
+    it "should be able to append documents to the associated set" do
+      @account.payment_methods << @payment_method
+      @account.payment_methods << @other_payment_method
+      @account.should have(2).payment_methods
+    end
+
+    it "should be able to chain calls to adding documents" do
+      @account.payment_methods << @payment_method << @other_payment_method
+      @account.should have(2).payment_methods
+    end
+
+    it "should assign the keys on the sub object when appending" do
+      @account.payment_methods << @payment_method << @other_payment_method
+      [@payment_method, @other_payment_method].each do |t|
+        t.account_key.should == "accounty"
+      end
+    end
+
+    it "does not return duplicates (for when the object has been appended and it's robject is found while walking the links)" do
+      @account.payment_methods.stub(:find_target => Set.new([@payment_method]))
+      @account.payment_methods.reset
+      @account.payment_methods << @payment_method
+      @account.payment_methods.should == [@payment_method]
+    end
+  end
+
+  describe "#reset" do
+    it "clears appended documents" do
+      @account.payment_methods << @payment_method
+      @account.payment_methods.reset
+      @account.payment_methods.should == []
+    end
+  end
+
+  describe "#keys" do
+    let(:ze_keys) { %w(1 2 3) }
+    let(:search_results) do
+      {"response" => {"docs" => ze_keys.map { |k| {"id" => k} }}}
+    end
+
+    before(:each) do
+      Ripple.client.stub(:search => search_results)
+      PaymentMethod.stub(:find => [@payment_method])
+    end
+
+    it "returns a set of keys" do
+      @account.payment_methods.keys.should be_a(Set)
+      @account.payment_methods.keys.to_a.should == ze_keys
+    end
+
+    it "is memoized between calls" do
+      @account.payment_methods.keys.should equal(@account.payment_methods.keys)
+    end
+
+    it "is cleared when the association is reset" do
+      orig_set = @account.payment_methods.keys
+      @account.payment_methods.reset
+      @account.payment_methods.keys.should_not equal(orig_set)
+    end
+
+    it "is cleared when the association is replaced" do
+      orig_set = @account.payment_methods.keys
+      @account.payment_methods.replace([@payment_method])
+      @account.payment_methods.keys.should_not equal(orig_set)
+    end
+
+    it "maintains the list of keys properly as new documents are appended" do
+      @account.payment_methods << @payment_method
+      @account.payment_methods.should have(1).key
+      @account.payment_methods << @other_payment_method
+      @account.payment_methods.should have(2).keys
+    end
+  end
+
+  describe "#include?" do
+    it "delegates to the set of keys so as not to unnecessarily load the associated documents" do
+      @account.payment_methods.keys.should_receive(:include?).with(@payment_method.key).and_return(true)
+      @account.payment_methods.include?(@payment_method).should be_true
+    end
+
+    it "short-circuits and returns false if the given object is not a ripple document" do
+      @account.payment_methods.keys.should_not_receive(:include?)
+      @account.payment_methods.include?(Object.new).should be_false
+    end
+
+    it "returns false if the document's bucket is different from the associations bucket, even if the keys are the same" do
+      @account.payment_methods << @payment_method
+      other_account = Account.new { |p| p.key = @payment_method.key }
+      @account.payment_methods.include?(other_account).should be_false
+    end
+  end
+end

data/spec/ripple/associations/many_stored_key_proxy_spec.rb

@@ -0,0 +1,158 @@
+require 'spec_helper'
+
+describe Ripple::Associations::ManyStoredKeyProxy do
+  # require 'support/models/transactions'
+
+  before :each do
+    @account = Account.new {|t| t.key = "accounty" }
+    @transaction_one = Transaction.new {|t| t.key = "one" }
+    @transaction_two = Transaction.new {|t| t.key = "two" }
+    @transaction_three = Transaction.new {|t| t.key = "three" }
+    @transaction_one.stub(:new_record?).and_return(false)
+    @transaction_two.stub(:new_record?).and_return(false)
+    @transaction_three.stub(:new_record?).and_return(false)
+  end
+
+  it "should be empty before any associated documents are set" do
+    @account.transactions.should be_empty
+  end
+
+  it "should allow appending" do
+    @account.transactions << @transaction_one
+    @account.transactions.should == [@transaction_one]
+    @account.transaction_keys.should == ["one"]
+  end
+
+  it "should be able to chain calls to adding documents" do
+    @account.transactions << @transaction_one << @transaction_two
+    @account.transactions.should == [@transaction_one, @transaction_two]
+  end
+
+  it "creates the right type of key collection" do
+    Object.module_eval do
+      class DifferentlyKeyedAccount
+        include Ripple::Document
+        property :transaction_keys, SortedSet
+        many :transactions, :using => :stored_key
+      end
+    end
+
+    account = DifferentlyKeyedAccount.new
+    account.transactions << @transaction_one
+    account.transaction_keys.should == SortedSet.new(["one"])
+  end
+
+  it "should accept an array of documents" do
+    @account.transactions = [@transaction_one]
+    @account.transactions.should == [@transaction_one]
+    @account.transaction_keys.should == %w(one)
+  end
+
+  it "should be able to replace the entire collection of documents (even appended ones)" do
+    @account.transactions << @transaction_one
+    @account.transactions = [@transaction_two]
+    @account.transactions.should == [@transaction_two]
+    @account.transaction_keys.should == %w(two)
+  end
+
+  it "should return the assigned documents when assigning" do
+    t = (@account.transactions = [@transaction_one])
+    t.should == [@transaction_one]
+  end
+
+  it "asks the keys set for the count to avoid having to unnecessarily load all documents" do
+    @account.transactions << @transaction_one
+    @account.transaction_keys.stub(:size => 17)
+    @account.transactions.count.should == 17
+  end
+
+  it "should return an array from to_ary" do
+    @account.transactions << @transaction_one
+    @account.transactions.to_ary.should == [@transaction_one]
+  end
+
+  it "should refuse assigning a collection of the wrong type" do
+    lambda { @account.transactions = nil }.should raise_error
+    lambda { @account.transactions = @transaction_one }.should raise_error
+    lambda { @account.transactions = [@account] }.should raise_error
+  end
+
+  it "should refuse appending a document of the wrong type" do
+    lambda { @account.transactions << Account.new }.should raise_error
+  end
+
+  describe "#reset" do
+    it "clears appended documents" do
+      @account.transactions << @transaction_one
+      @account.transactions.reset
+      @account.transactions.should == []
+    end
+
+    it "resets to the saved state of the proxy" do
+      Transaction.stub(:find).and_return([@transaction_one])
+      @account.transactions << @transaction_two
+      @account.transactions.reset
+      Transaction.stub(:find).and_return([@transaction_one])
+      @account.transactions.should == [ @transaction_one ]
+    end
+  end
+
+  describe "#include?" do
+    it "delegates to the set of keys so as not to unnecessarily load the associated documents" do
+      @account.transactions.keys.should_receive(:include?).with(@transaction_two.key).and_return(true)
+      @account.transactions.include?(@transaction_two).should be_true
+    end
+
+    it "short-circuits and returns false if the given object is not a ripple document" do
+      @account.transactions.keys.should_not_receive(:include?)
+      @account.transactions.include?(Object.new).should be_false
+    end
+
+    it "returns false if the document's bucket is different from the associations bucket, even if the keys are the same" do
+      @account.transactions << @transaction_one
+      other_account = Account.new { |p| p.key = @transaction_one.key }
+      @account.transactions.include?(other_account).should be_false
+    end
+  end
+
+  describe "#keys" do
+    before do
+      @account.transactions << @transaction_one << @transaction_two
+    end
+
+    it "returns a set of keys" do
+      @account.transactions.keys.should be_a(Array)
+      @account.transactions.keys.to_a.should == %w(one two)
+    end
+
+    it "is memoized between calls" do
+      @account.transactions.keys.should equal(@account.transactions.keys)
+    end
+
+    it "is cleared when the association is reset" do
+      orig_set = @account.transactions.keys
+      @account.transactions.reset
+      @account.transactions.keys.should_not equal(orig_set)
+      @account.transactions.keys.should == []
+    end
+
+    it "is cleared when the association is replaced" do
+      orig_set = @account.transactions.keys
+      @account.transactions.replace([@transaction_one])
+      @account.transactions.keys.should_not equal(orig_set)
+      @account.transactions.keys.to_a.should == %w(one)
+    end
+
+    it "maintains the list of keys properly as new documents are appended" do
+      @account.transactions.keys.size.should == 2
+      @account.transactions << @transaction_three
+      @account.transactions.keys.size.should == 3
+    end
+
+  end
+
+  it "temporarily bombs if the document you're appending isn't saved. This behavior shouldn't last long." do
+    lambda { @account.transactions << Transaction.new }.should raise_error
+  end
+
+end

data/spec/ripple/associations/one_embedded_proxy_spec.rb

@@ -1,29 +1,16 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Ripple::Associations::OneEmbeddedProxy do
-  require 'support/models/family'
-  require 'support/models/user'
-  require 'support/models/address'
-  
+  # require 'support/models/family'
+  # require 'support/models/user'
+  # require 'support/models/address'
+
   before :each do
     @parent = Parent.new
     @child  = Child.new
     @gchild = Grandchild.new
   end
-  
+
   it "should not have a child before one is set" do
     @parent.child.should be_nil
   end
@@ -31,27 +18,27 @@ describe Ripple::Associations::OneEmbeddedProxy do
   it "should raise NoMethodError when an undefined method is called on the unset child" do
     expect { @parent.child.some_undefined_method }.to raise_error(NoMethodError)
   end
-  
+
   it "should be able to set and get its child" do
     @parent.child = @child
     @parent.child.should equal(@child)
   end
-  
+
   it "should set the parent document on the child when assigning" do
     @parent.child = @child
     @child._parent_document.should == @parent
   end
-  
+
   it "should return the assignment when assigning" do
     rtn = @parent.child = @child
     rtn.should == @child
   end
-  
+
   it "should set the parent document on the child when accessing" do
     @parent.child = @child
     @parent.child._parent_document.should == @parent
   end
-  
+
   it "should be able to replace its child with a different child" do
     @son = Child.new(:name => 'Son')
     @parent.child = @child
@@ -59,18 +46,18 @@ describe Ripple::Associations::OneEmbeddedProxy do
     @parent.child = @son
     @parent.child.name.should == 'Son'
   end
-  
+
   it "should be able to build a new child" do
     Child.stub!(:new).and_return(@child)
     @parent.child.build.should == @child
   end
-  
+
   it "should assign a parent to the child created with instantiate_target" do
     Child.stub!(:new).and_return(@child)
     @child._parent_document.should be_nil
     @parent.child.build._parent_document.should == @parent
   end
-  
+
   it "should validate the child when saving the parent" do
     @parent.valid?.should be_true
     @child.name = ''
@@ -78,12 +65,12 @@ describe Ripple::Associations::OneEmbeddedProxy do
     @child.valid?.should be_false
     @parent.valid?.should be_false
   end
-  
+
   it "should not save the root document when a child is invalid" do
     @parent.child = @child
     @parent.save.should be_false
   end
-  
+
   it "should allow embedding documents in embedded documents" do
     @parent.child = @child
     @child.gchild = @gchild
@@ -95,28 +82,28 @@ describe Ripple::Associations::OneEmbeddedProxy do
     lambda { @parent.child = @gchild }.should raise_error
     lambda { @child.gchild = [] }.should raise_error
   end
-  
+
   describe "callbacks" do
     before :each do
       $pinger = mock("callback verifier")
     end
-    
+
     it "should run callbacks for the child and documents" do
       $pinger.should_receive(:ping).once
       Child.before_validation { $pinger.ping }
       @child = Child.new
       @child.valid?
-    end 
+    end
 
     # this will work using parent and child classes, but only run by itself
     # it also works using different classes, but only run in this file
     # IDK why that is, but my Yakshaver 2000 just ran out of juice
-    
+
     # does this even matter? we call valid? all over the place and that
-    # will trigger the callback anyway. 
-    # you probably shouldn't use validation callbacks and expect them to 
+    # will trigger the callback anyway.
+    # you probably shouldn't use validation callbacks and expect them to
     # *only* run once
-    
+
     # it "should run callbacks for the parent and child and documents respectivly" do
     #   $pinger = mock("callback verifier")
     #   $pinger.should_receive(:ping).once
@@ -128,7 +115,7 @@ describe Ripple::Associations::OneEmbeddedProxy do
     #   @parent.child = @child
     #   @parent.valid?
     # end
-    
+
     after :each do
       Child.reset_callbacks(:validation)
       Parent.reset_callbacks(:validation)