ripple 0.9.5 → 1.0.0.beta

data/spec/ripple/attribute_methods_spec.rb

@@ -1,20 +1,7 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Ripple::AttributeMethods do
-  require 'support/models/widget'
+  # require 'support/models/widget'
 
   before :each do
     @widget = Widget.new
@@ -59,6 +46,13 @@ describe Ripple::AttributeMethods do
       @widget.manufactured.should == false
     end
 
+    it "dups the default if it is duplicable so that two document do not share the same mutable value" do
+      widget2 = Widget.new
+      @widget.name.should_not be(widget2.name)
+      widget2.name.gsub!("w", "f")
+      @widget.name.should == "widget"
+    end
+
     it "should allow raw attribute access when accessing the document with []" do
       @widget['name'].should == 'widget'
     end
@@ -81,8 +75,9 @@ describe Ripple::AttributeMethods do
     end
 
     it "should allow assignment of undefined attributes when assigning to the document with []=" do
-      @widget['name'] = 'sprocket'
-      @widget.name.should == 'sprocket'
+      @widget.should_not respond_to(:shoe_size)
+      @widget['shoe_size'] = 8
+      @widget['shoe_size'].should == 8
     end
 
     it "should type cast assigned values automatically" do
@@ -143,8 +138,28 @@ describe Ripple::AttributeMethods do
     Widget.properties.delete(:start_date) # cleanup
   end
 
-  it "should provide a hash representation of all of the attributes" do
-    @widget.attributes.should == {"name" => "widget", "size" => nil, "manufactured" => false, "shipped_at" => nil}
+  describe "#attributes" do
+    it "it returns a hash representation of all of the attributes" do
+      @widget.attributes.should == {"name" => "widget", "size" => nil, "manufactured" => false, "shipped_at" => nil}
+    end
+
+    it "does not include ghost attributes (attributes that do not have a defined property)" do
+      @widget['some_undefined_prop'] = 3.14159
+      @widget.attributes.should_not include('some_undefined_prop')
+    end
+  end
+
+  describe "#raw_attributes" do
+    it "returns a hash representation, including attributes for undefined properties" do
+      @widget['some_undefined_prop'] = 17
+      @widget.raw_attributes.should == {
+        'name'                => 'widget',
+        'size'                => nil,
+        'manufactured'        => false,
+        'shipped_at'          => nil,
+        'some_undefined_prop' => 17
+      }
+    end
   end
 
   it "should load attributes from mass assignment" do
@@ -196,9 +211,20 @@ describe Ripple::AttributeMethods do
     @widget.manufactured.should be_false
   end
 
-  it "should allow protected attributes to be mass assigned" do
+  it "should allow protected attributes to be mass assigned via raw_attributes=" do
     @widget = Widget.new
-    @widget.send(:attributes=, { :manufactured => true }, false)
+    @widget.send(:raw_attributes=, { :manufactured => true })
     @widget.manufactured.should be_true
   end
+
+  it "should allow mass assigning arbitrary attributes via raw_attributes" do
+    @widget = Widget.new
+    @widget.__send__(:raw_attributes=, :explode => '?BOOM')
+    @widget[:explode].should eq('?BOOM')
+  end
+
+  it "should raise an ArgumentError with an undefined property message when mass assigning a property that doesn't exist" do
+    lambda { @widget = Widget.new(:explode => '?BOOM') }.should raise_error(ArgumentError, %q[Undefined property :explode for class 'Widget'])
+  end
+
 end

data/spec/ripple/bucket_access_spec.rb

@@ -1,22 +1,9 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../spec_helper", File.dirname(__FILE__))
+require 'spec_helper'
 
 describe Ripple::Document::BucketAccess do
-  require 'support/models/invoice'
-  require 'support/models/late_invoice'
-  require 'support/models/paid_invoice'
+  # require 'support/models/invoice'
+  # require 'support/models/late_invoice'
+  # require 'support/models/paid_invoice'
 
   it "should use the plural model name as the bucket name" do
     Invoice.bucket_name.should == "invoices"

data/spec/ripple/callbacks_spec.rb

@@ -1,20 +1,7 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Ripple::Callbacks do
-  require 'support/models/box'
+  # require 'support/models/box'
 
   it "should add create, update, save, and destroy callback declarations" do
     [:save, :create, :update, :destroy].each do |event|
@@ -49,6 +36,55 @@ describe Ripple::Callbacks do
       @box.save
     end
 
+    it "propagates callbacks to embedded associated documents" do
+      Box.before_save { $pinger.ping }
+      BoxSide.before_save { $pinger.ping }
+      $pinger.should_receive(:ping).exactly(2).times
+      @box = Box.new
+      @box.sides << BoxSide.new
+      @box.save
+    end
+
+    it 'does not persist the object to riak multiple times when propagating callbacks' do
+      Box.before_save { }
+      BoxSide.before_save { }
+      @box = Box.new
+      @box.sides << BoxSide.new << BoxSide.new
+
+      @box.robject.should_receive(:store).once
+      @box.save
+    end
+
+    it 'invokes the before/after callbacks in the correct order on embedded associated documents' do
+      callbacks = []
+      BoxSide.before_save { callbacks << :before_save }
+      BoxSide.after_save  { callbacks << :after_save  }
+
+      @box = Box.new
+      @box.sides << BoxSide.new
+      @box.robject.stub(:store) do
+        callbacks << :save
+      end
+      @box.save
+
+      callbacks.should == [:before_save, :save, :after_save]
+    end
+
+    it 'does not allow around callbacks on embedded associated documents' do
+      expect {
+        BoxSide.around_save { }
+      }.to raise_error(/around_save callbacks are not supported/)
+    end
+
+    it 'does not propagate validation callbacks multiple times' do
+      Box.before_validation { $pinger.ping }
+      BoxSide.before_validation { $pinger.ping }
+      $pinger.should_receive(:ping).exactly(2).times
+      @box = Box.new
+      @box.sides << BoxSide.new
+      @box.valid?
+    end
+
     it "should call create callbacks on save when the document is new" do
       Box.before_create { $pinger.ping }
       Box.after_create { $pinger.ping }
@@ -133,6 +169,7 @@ describe Ripple::Callbacks do
     after :each do
       [:save, :create, :update, :destroy, :validation].each do |type|
         Box.reset_callbacks(type)
+        BoxSide.reset_callbacks(type)
       end
     end
   end

data/spec/ripple/conflict/resolver_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+
+module Ripple
+  module Conflict
+    describe Resolver do
+      it 'is registered as an on conflict hook with Riak::RObject' do
+        Riak::RObject.on_conflict_hooks.should include(described_class.to_proc)
+      end
+
+      describe 'calling the lambda returned by .to_proc' do
+        let(:sibling_1) { stub(:data => { '_type' => 'User' } ) }
+        let(:sibling_2) { stub(:data => { '_type' => 'User' } ) }
+        let(:user_siblings) { [sibling_1, sibling_2] }
+        let(:wheel_sibling) { stub(:data => { '_type' => 'Wheel' } ) }
+        let(:robject) { stub(:siblings => user_siblings) }
+        let(:resolved_robject) { stub("Resolved RObject") }
+        let(:resolved_document) { stub(:robject => resolved_robject) }
+
+        let!(:resolver) { described_class.new(robject, User) }
+
+        it 'creates a resolver for the appropriate model class, resolves the robject, and returns the resolved robject' do
+          described_class.
+            should_receive(:new).
+            with(robject, User).
+            and_return(resolver)
+
+          resolver.should_receive(:resolve)
+          resolver.stub(:document => resolved_document)
+
+          described_class.to_proc.call(robject).should be(resolved_robject)
+        end
+
+        it 'returns nil and does not attempt resolution when given an robject with siblings of different types' do
+          user_siblings << wheel_sibling
+          described_class.should_not_receive(:new)
+          described_class.to_proc.call(robject).should be_nil
+        end
+      end
+    end
+  end
+end
+

data/spec/ripple/conversion_spec.rb

@@ -1,20 +1,7 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Ripple::Conversion do
-  require 'support/models/box'
+  # require 'support/models/box'
 
   before :each do
     @box = Box.new { |a| a.key = 'some-key' }

data/spec/ripple/core_ext_spec.rb

@@ -1,17 +1,4 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Time do
   before { @date_format = Ripple.date_format }
@@ -46,7 +33,7 @@ describe DateTime do
   after  { Ripple.date_format = @date_format }
 
   before :each do
-    Time.zone = :utc
+    Time.zone = "UTC"
   end
 
   it "serializes to JSON in UTC, ISO 8601 format by default" do
@@ -104,3 +91,13 @@ describe "Boolean" do
     }.should_not raise_error(NameError)
   end
 end
+
+describe Set do
+  describe "#as_json" do
+    it 'returns an array of the #as_json result of each element' do
+      set = Set.new([stub(:as_json => 's1'), stub(:as_json => 's2')])
+      set.as_json.should =~ ['s1', 's2']
+    end
+  end
+end
+

data/spec/ripple/document/link_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+module Ripple
+  module Document
+    describe self do
+      describe "#to_link" do
+        let(:tag)      { 'invoices' }
+        let(:document) { Invoice.new }
+        let(:to_link)  { document.to_link(tag) }
+
+        it "returns a #{described_class}::Link" do
+          to_link.should be_a(Link)
+        end
+
+        it "sets the document to this document" do
+          to_link.send(:document).should equal(document)
+        end
+
+        it "sets the tag to the given tag" do
+          to_link.tag.should == tag
+        end
+      end
+    end
+
+    describe Link do
+      let(:key)      { 'the-invoice-key' }
+      let(:tag)      { 'invoices' }
+      let(:document) { Invoice.new { |i| i.key = key } }
+      let(:link)     { described_class.new(document, tag) }
+
+      it 'does not fetch the key immediately' do
+        document.should_not_receive(:key)
+        link
+      end
+
+      describe '#key' do
+        it "returns the document's key" do
+          link.key.should == key
+        end
+      end
+
+      describe '#bucket' do
+        it "returns the bucket name from the document class" do
+          link.bucket.should == Invoice.bucket_name
+        end
+      end
+
+      describe '#tag' do
+        it 'returns the tag passed to the constructor' do
+          link.tag.should == tag
+        end
+      end
+
+      describe "#hash" do
+        it 'does not use the key' do
+          document.should_not_receive(:key)
+          link.hash
+        end
+
+        it "uses the document's #hash" do
+          document.should_receive(:hash).and_return(1234)
+          link.hash.should == 1234
+        end
+      end
+    end
+  end
+end

data/spec/ripple/document_spec.rb

@@ -1,20 +1,7 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../spec_helper", File.dirname(__FILE__))
+require 'spec_helper'
 
 describe Ripple::Document do
-  require 'support/models/page'
+  # require 'support/models/page'
 
   it "should add bucket access methods to classes when included" do
     (class << Page; self; end).included_modules.should include(Ripple::Document::BucketAccess)
@@ -38,22 +25,50 @@ describe Ripple::Document do
       [@doc,@doc2,@sub,@error].each {|d| d.key = "root"; d.stub!(:new?).and_return(false) }
     end
 
-    it "should be equal if the same object" do
+    it "should be == and eql? if the same object, and have the same hash key" do
       @doc.should == @doc
+      @doc.should eql(@doc)
+      @doc.hash.should == @doc.hash
     end
 
-    it "should be equal if instance of same class and key" do
+    it "should be == and eql? and have the same hash key if instance of same class and key" do
       @doc.should == @doc2
+      @doc2.should == @doc
+      @doc.should eql(@doc2)
+      @doc2.should eql(@doc)
+      @doc.hash.should == @doc2.hash
+    end
+
+    it "should be == but not eql? and have different hash keys if they have the same key but one is a subclass of the other" do
       @doc.should == @sub
+      @sub.should == @doc
+
+      @doc.should_not eql(@sub)
+      @sub.should_not eql(@doc)
+
+      @doc.hash.should_not == @sub.hash
     end
 
-    it "should be equal if of the same bucket and key" do
+    it "should be == but not eql? and have different hash keys if of the same bucket and key" do
       @doc.should == @error
+      @error.should == @doc
+
+      @doc.should_not eql(@error)
+      @error.should_not eql(@doc)
+
+      @doc.hash.should_not == @error.hash
+      @error.hash.should_not == @doc.hash
     end
 
-    it "should not be equal if new record" do
+    it "should not be == or eql? or have the same hash key if new record" do
       @doc2.stub!(:new?).and_return(true)
       @doc.should_not == @doc2
+      @doc2.should_not == @doc
+
+      @doc.should_not eql(@doc2)
+      @doc2.should_not eql(@doc)
+
+      @doc.hash.should_not == @doc2.hash
     end
   end