ripple 0.9.5 → 1.0.0.beta

data/spec/ripple/associations/one_key_proxy_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+
+describe Ripple::Associations::OneKeyProxy do
+
+  before :each do
+    @user    = User.new
+    @profile = Profile.new(:color => 'blue')
+  end
+
+  describe "User with a key corresponded profile" do
+    it "should not have a profile before it is set" do
+      @user.profile.should be_nil
+    end
+
+    it "should be able to get and set its profile" do
+      @user.profile = @profile
+      @user.profile.should eq(@profile)
+    end
+
+    it "should return the assignment when assigning" do
+      rtn = @user.profile = @profile
+      rtn.should eq(@profile)
+    end
+
+    it "should be able to replace its profile with a new one" do
+      @user.profile = @profile
+      @user.profile = Profile.new(:color => 'red')
+      @user.profile.color.should eq('red')
+    end
+
+    it "should be able to build a new profile" do
+      Profile.stub(:new).and_return(@profile)
+      @user.profile.build.should eq(@profile)
+    end
+
+    it "should assign its key to the associated profile when assigning" do
+      @user.key     = "foo"
+      @user.profile = @profile
+      @profile.key.should eq("foo")
+    end
+
+    it "should assign its key to the built profile" do
+      @user.key = "foo"
+      @user.profile.build.key.should eq("foo")
+    end
+
+    it "should update the key on the profile when updating it on the user" do
+      @user.profile = @profile
+      @user.key = "foo"
+      @profile.key.should eq("foo")
+    end
+
+    it "should not update the key of a previous profile" do
+      @profile2 = Profile.new
+      @user.profile = @profile
+      @user.profile = @profile2
+      @user.key = "foo"
+      @profile.key.should_not eq("foo")
+    end
+
+    it "should not infinitely loop when assigning a user to the profile" do
+      @user2 = User.new
+      @user.profile = @profile
+      @profile.user = @user2
+      @profile.key = "foo"
+      @user2.key.should eq("foo")
+    end
+
+    it "should update the user's key when being updated on the profile" do
+      @user.profile = @profile
+      @profile.key = "foo"
+      @user.key.should eq("foo")
+    end
+
+    it "should work properly with custom key methods" do
+      @user = Ninja.new(:name => 'Naruto')
+      @user.profile = @profile
+      @profile.key.should eq("ninja-naruto")
+    end
+  end
+
+end

data/spec/ripple/associations/one_linked_proxy_spec.rb

@@ -1,21 +1,8 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Ripple::Associations::OneLinkedProxy do
-  require 'support/models/tasks'
-  require 'support/models/family'
+  # require 'support/models/tasks'
+  # require 'support/models/family'
 
   before :each do
     @person = Person.new {|p| p.key = "riak-user" }
@@ -36,7 +23,7 @@ describe Ripple::Associations::OneLinkedProxy do
 
   it "should set the link on the RObject when assigning" do
     @person.profile = @profile
-    @person.robject.links.should include(@profile.robject.to_link("profile"))
+    @person.robject.links.should include(@profile.to_link("profile"))
   end
 
   it "should return the assigned document when assigning" do
@@ -44,18 +31,30 @@ describe Ripple::Associations::OneLinkedProxy do
     ret.should == @profile
   end
 
-  it "should save the new document when assigning" do
-    @profile.should_receive(:new?).and_return(true)
-    @profile.should_receive(:save).and_return(true)
-    @person.profile = @profile
-  end
-
   it "should link-walk to the associated document when accessing" do
     @person.robject.links << @profile.robject.to_link("profile")
     @person.robject.should_receive(:walk).with(Riak::WalkSpec.new(:bucket => "profiles", :tag => "profile")).and_return([[@profile.robject]])
     @person.profile.should be_present
   end
 
+  it "handles conflict appropriately by selecting the linked-walk robject that matches the link" do
+    @person.robject.links << @profile.robject.to_link("profile")
+    @person.robject.
+      should_receive(:walk).
+      with(Riak::WalkSpec.new(:bucket => "profiles", :tag => "profile")).
+      and_return([[@other_profile.robject, @profile.robject]])
+
+    @person.profile.should == @profile
+  end
+
+  it "allows the links to be replaced directly" do
+    @person.profile = @profile
+    @person.profile.__send__(:should_receive, :reset)
+    @person.profile.__send__(:links).should == [@profile.robject.to_link("profile")]
+    @person.profile.replace_links(@other_profile.robject.to_link("profile"))
+    @person.profile.__send__(:links).should == [@other_profile.robject.to_link("profile")]
+  end
+
   it "should return nil immediately if the association link is missing" do
     @person.robject.links.should be_empty
     @person.profile.should be_nil

data/spec/ripple/associations/one_stored_key_proxy_spec.rb

@@ -0,0 +1,72 @@
+require 'spec_helper'
+
+describe Ripple::Associations::OneStoredKeyProxy do
+  # require 'support/models/transactions'
+  # require 'support/models/family'
+
+  before :each do
+    @account = Account.new {|e| e.key = "accounty" }
+    @other_account = Account.new{|e| e.key = "ickycount" }
+    @transaction = Transaction.new{|e| e.key = "transacty" }
+  end
+
+  it "should be blank before the associated document is set" do
+    @transaction.account.should_not be_present
+  end
+
+  it "should accept a single document" do
+    lambda { @transaction.account = @account }.should_not raise_error
+  end
+
+  it "should set the key when assigning" do
+    @transaction.account = @account
+    @transaction.account_key.should == "accounty"
+  end
+
+  it "should return the assigned document when assigning" do
+    ret = (@transaction.account = @account)
+    ret.should == @account
+  end
+
+  it "should find the associated document when accessing" do
+    @transaction.account_key = "accounty"
+    Account.should_receive(:find).with("accounty").and_return(@account)
+    @transaction.account.should be_present
+  end
+
+  it "should return nil immediately if the association link is missing" do
+    @transaction.account_key.should be_nil
+    @transaction.account.should be_nil
+  end
+
+  it "should replace associated document with a new one" do
+    @transaction.account = @account
+    @transaction.account = @other_account
+    @transaction.account.should == @other_account
+    @transaction.account_key.should == "ickycount"
+  end
+
+  it "should replace the associated document with the target of the proxy" do
+    other_transaction = Transaction.new {|e| e.key = "ickytrans" }
+    other_transaction.account = @other_account
+
+    @transaction.account = other_transaction.account
+    @transaction.account.should == @other_account
+  end
+
+  it "refuses assigning a proxy if its target is the wrong type" do
+    parent = Parent.new{|e| e.child = Child.new}
+    lambda { @transaction.account = parent.child }.should raise_error
+  end
+
+  it "should refuse assigning a document of the wrong type" do
+    lambda { @transaction.account = @transaction }.should raise_error
+  end
+
+  it "should nil out the association if nil is assigned" do
+    @transaction.account = @account
+    @transaction.account = nil
+    @transaction.account.should be_nil
+    @transaction.account_key.should be_nil
+  end
+end

data/spec/ripple/associations/proxy_spec.rb

@@ -1,17 +1,4 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Ripple::Associations::Proxy do
   require 'support/associations/proxies'
@@ -75,4 +62,23 @@ describe Ripple::Associations::Proxy do
     it { should be_blank }
     it { should_not be_present }
   end
-end
+
+  describe "#has_changed_documents?" do
+    before(:each) { @proxy.respond_to?(:loaded_documents).should be_true }
+
+    it "returns true if any of the loaded documents return true from #changed?" do
+      @proxy.stub(:loaded_documents => [stub(:changed? => false), stub(:changed? => true)])
+      @proxy.has_changed_documents?.should be_true
+    end
+
+    it "returns false if none of the loaded documents return true from #changed?" do
+      @proxy.stub(:loaded_documents => [stub(:changed? => false), stub(:changed? => false)])
+      @proxy.has_changed_documents?.should be_false
+    end
+
+    it "returns false if it has no loaded documents" do
+      @proxy.stub(:loaded_documents => [])
+      @proxy.has_changed_documents?.should be_false
+    end
+  end
+end

data/spec/ripple/associations_spec.rb

@@ -1,22 +1,9 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Ripple::Associations do
-  require 'support/models/invoice'
-  require 'support/models/customer'
-  require 'support/models/note'
+  # require 'support/models/invoice'
+  # require 'support/models/customer'
+  # require 'support/models/note'
 
   it "should provide access to the associations hash" do
     Invoice.should respond_to(:associations)
@@ -27,6 +14,15 @@ describe Ripple::Associations do
     Invoice.embedded_associations.should == Array(Invoice.associations[:note])
   end
 
+  it "should collect the linked associations" do
+    Invoice.linked_associations.should == Array(Invoice.associations[:customer])
+  end
+
+  it "should collect the stored_key associations" do
+    Account.stored_key_associations.should == Array(Account.associations[:transactions])
+    Transaction.stored_key_associations.should == Array(Transaction.associations[:account])
+  end
+
   it "should copy associations to a subclass" do
     Invoice.associations[:foo] = "bar"
     class SubInvoice < Invoice; end
@@ -50,11 +46,16 @@ describe Ripple::Associations do
     end
   end
 
-  after do
-    Invoice.associations.delete(:foo)
-    Invoice.associations.delete(:items)
-    SubInvoice.associations.delete(:foo) if defined?(SubInvoice)
-    Invoice.associations.delete(:payee)
+  before(:all) do
+    @orig_invoice = Invoice
+    Object.send(:remove_const, :Invoice)
+    class Invoice < @orig_invoice; end
+  end
+
+  after(:all) do
+    Object.send(:remove_const, :SubInvoice) if defined?(SubInvoice)
+    Object.send(:remove_const, :Invoice)
+    Object.send(:const_set, :Invoice, @orig_invoice)
   end
 end
 
@@ -81,7 +82,22 @@ describe Ripple::Association do
   end
 
   describe "determining the target class" do
-    require 'support/models/tree'
+    context "when in a nested module scope" do
+      it "should find the target via the owner's module scope" do
+        @association = Ripple::Association.new(:many, :children)
+        @association.setup_on(Nested::Scope::Parent)
+        @association.klass.should == Nested::Scope::Child
+      end
+
+      it "should not try to find the target in the owner's scope when the class name is fully qualified" do
+        @association = Ripple::Association.new(:many, :children, :class_name => "Nested::Scope::Child")
+        @association.setup_on(Nested::Scope::Parent)
+        expect {
+          @association.klass
+        }.should_not raise_error
+        @association.klass.should == Nested::Scope::Child
+      end
+    end
 
     it "should default to the constantized class name" do
       @association = Ripple::Association.new(:one, :t, :class_name => "Trunk")
@@ -110,4 +126,19 @@ describe Ripple::Association do
   it "should determine an instance variable based on the name" do
     Ripple::Association.new(:many, :pages).ivar.should == "@_pages"
   end
+
+  describe "key correspondence" do
+    require 'support/models/profile'
+    require 'support/models/user'
+
+    it "should raise an exception if trying to use a many association when :using => :key" do
+      expect { Profile.many :user, :using => :key }.to raise_error(ArgumentError, "You cannot use a many association using :key")
+    end
+
+    it "should add the key_delegate attr_accessor to the model declaring the association" do
+      Profile.one :user, :using => :key
+      Profile.new.should respond_to(:key_delegate)
+      Profile.new.should respond_to(:key_delegate=)
+    end
+  end
 end

data/spec/ripple/attribute_methods/dirty_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path("../../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Ripple::AttributeMethods::Dirty do
   let(:company)    { Company.new }
@@ -12,18 +12,69 @@ describe Ripple::AttributeMethods::Dirty do
       company.robject.stub!(:store).and_return(true)
       company.name = 'Fizz Buzz, Inc.'
     end
-    
+
     it "should capture previous changes when saving" do
       company.save
       company.previous_changes.should include('name')
     end
 
     it "should make previous changes available to after callbacks" do
-      class << company
+      my_class = Class.new(Company) do
         after_save {|c| c['pc'] = previous_changes }
       end
-      company.save
-      company['pc'].should include('name')
+      comp = my_class.new
+      comp.robject.stub!(:store).and_return(true)
+      comp.name = 'Fizz Buzz, Inc.'
+      comp.save
+      comp['pc'].should include('name')
+    end
+  end
+
+  describe "#changed?" do
+
+    it "returns true if the document's attributes have changed (regardless of whether or not it has any embedded associated documents)" do
+      company.name = 'Fizz Buzz, Inc'
+      company.should be_changed
+    end
+
+
+    context "when the document's attributes have not changed" do
+      it 'returns false if it has no embedded associated documents' do
+        company.should_not be_changed
+      end
+
+      context 'when the document has embedded associated documents' do
+        before(:each) do
+          company.ceo = ceo
+          company.invoices << invoice
+          company.departments << department
+          department.managers << manager
+        end
+
+        it 'returns false if all the embedded documents are not changed' do
+          company.should_not be_changed
+        end
+
+        it 'does not consider changes to linked associated documents' do
+          invoice.should_not_receive(:changed?)
+          company.changed?
+        end
+
+        it 'returns true if a one embedded association document is changed' do
+          ceo.should_receive(:changed?).and_return(true)
+          company.should be_changed
+        end
+
+        it 'returns true if a many embedded association document is changed' do
+          department.should_receive(:changed?).and_return(true)
+          company.should be_changed
+        end
+
+        it 'recurses through the whole embedded document structure to find changed grandchild documents' do
+          manager.should_receive(:changed?).and_return(true)
+          company.should be_changed
+        end
+      end
     end
   end
 end