ripple 0.9.5 → 1.0.0.beta

data/spec/ripple/key_spec.rb

@@ -1,24 +1,12 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../spec_helper", File.dirname(__FILE__))
+require 'spec_helper'
 
 describe Ripple::Document::Key do
-  require 'support/models/box'
+  # require 'support/models/box'
+
   before do
     @box = Box.new
   end
-  
+
   it "should define key getter and setter" do
     @box.should respond_to(:key)
     @box.should respond_to(:key=)
@@ -39,5 +27,5 @@ describe Ripple::Document::Key do
     @box.shape.should == "square"
     @box.shape = "oblong"
     @box.key.should == "oblong"
-  end  
+  end
 end

data/spec/ripple/observable_spec.rb

@@ -1,21 +1,8 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Ripple::Observable do
-  require 'support/models/clock'
-  require 'support/models/clock_observer'
+  # require 'support/models/clock'
+  # require 'support/models/clock_observer'
 
   before :each do
     @client   = Ripple.client

data/spec/ripple/persistence_spec.rb

@@ -1,20 +1,7 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Ripple::Document::Persistence do
-  require 'support/models/widget'
+  # require 'support/models/widget'
 
   before :each do
     @backend = mock("Backend")
@@ -24,6 +11,16 @@ describe Ripple::Document::Persistence do
     @widget = Widget.new(:size => 1000)
   end
 
+  it "forces the content type to 'application/json'" do
+    @widget.robject.content_type = 'application/not-json'
+
+    @backend.should_receive(:store_object) do |obj, *_|
+      obj.content_type.should == 'application/json'
+    end
+
+    @widget.save
+  end
+
   it "should save a new object to Riak" do
     json = @widget.attributes.merge("_type" => "Widget").to_json
     @backend.should_receive(:store_object) do |obj, _, _, _|
@@ -112,13 +109,13 @@ describe Ripple::Document::Persistence do
   end
 
   it "should allow unexpected exceptions to be raised" do
-    robject = mock("robject", :key => @widget.key, "data=" => true)
+    robject = mock("robject", :key => @widget.key, "data=" => true, "content_type=" => true)
     robject.should_receive(:store).and_raise(Riak::HTTPFailedRequest.new(:post, 200, 404, {}, "404 not found"))
     @widget.stub!(:robject).and_return(robject)
     lambda { @widget.save }.should raise_error(Riak::FailedRequest)
   end
 
-  it "should reload a saved object" do
+  it "should reload a saved object, including associations" do
     json = @widget.attributes.merge(:_type => "Widget").to_json
     @backend.should_receive(:store_object) do |obj, _, _, _|
       obj.raw_data.should == json
@@ -129,8 +126,12 @@ describe Ripple::Document::Persistence do
     @widget.save
     @backend.should_receive(:reload_object) do |obj, _|
       obj.key.should == "new_widget"
+      obj.content_type = 'application/json'
       obj.raw_data = '{"name":"spring","size":10,"shipped_at":"Sat, 01 Jan 2000 20:15:01 -0000","_type":"Widget"}'
+      obj
     end
+
+    @widget.widget_parts.should_receive(:reset)
     @widget.reload
     @widget.changes.should be_blank
     @widget.name.should == "spring"
@@ -150,7 +151,7 @@ describe Ripple::Document::Persistence do
 
   it "should destroy all saved objects" do
     @widget.should_receive(:destroy).and_return(true)
-    Widget.should_receive(:all).and_yield(@widget)
+    Widget.should_receive(:list).and_yield(@widget)
     Widget.destroy_all.should be_true
   end
 
@@ -209,4 +210,119 @@ describe Ripple::Document::Persistence do
       widget.destroy
     end
   end
+
+  shared_examples_for "saving a parent document with linked child documents" do
+    before(:each) do
+      @backend.stub(:store_object)
+    end
+
+    it 'saves new children when the parent is saved' do
+      children.each do |child|
+        child.stub(:new? => true)
+        child.should_receive(:save)
+      end
+      parent.save
+    end
+
+    it 'saves children that have changes when the parent is saved' do
+      children.each do |child|
+        child.stub(:new? => false)
+        child.stub(:changed? => true)
+        child.should_receive(:save)
+      end
+      parent.save
+    end
+
+    it 'does not save children that have no changes and are not new when the parent is saved' do
+      children.each do |child|
+        child.stub(:new? => false)
+        child.stub(:changed? => false)
+        child.should_not_receive(:save)
+      end
+      parent.save
+    end
+  end
+
+  context "for a document with a many linked association" do
+    before(:all) do
+      # check assumptions of these examples
+      Widget.associations[:widget_parts].should be_many
+      Widget.associations[:widget_parts].should be_linked
+    end
+
+    it_behaves_like "saving a parent document with linked child documents" do
+      let(:parent)   { Widget.new(:name => 'fizzbuzz') }
+      let(:children) { %w[ fizz buzz ].map { |n| WidgetPart.new(:name => n) } }
+
+      before(:each) do
+        children.each { |c| parent.widget_parts << c }
+      end
+    end
+  end
+
+  describe "for a document with a one linked association" do
+    before(:all) do
+      # check assumptions of these examples
+      Invoice.associations[:customer].should be_one
+      Invoice.associations[:customer].should be_linked
+    end
+
+    it_behaves_like "saving a parent document with linked child documents" do
+      let(:parent)   { Invoice.new }
+      let(:children) { [Customer.new] }
+
+      before(:each) do
+        parent.customer = children.first
+      end
+    end
+  end
+
+  shared_examples_for "embedded association persistence logic" do
+    before(:each) do
+      @backend.stub(:store_object)
+    end
+
+    it "does not save children when the parent is saved" do
+      children.each do |child|
+        child.stub(:new? => true, :changed? => true)
+        child.should_not_receive(:save)
+      end
+
+      parent.save
+    end
+  end
+
+  describe "for a document with a many embedded association" do
+    before(:all) do
+      # check assumptions of these examples
+      Clock.associations[:modes].should be_many
+      Clock.associations[:modes].should be_embedded
+    end
+
+    it_behaves_like "embedded association persistence logic" do
+      let(:parent)   { Clock.new }
+      let(:children) { [1, 2].map { |i| Mode.new } }
+
+      before(:each) do
+        children.each { |c| parent.modes << c }
+      end
+    end
+  end
+
+  describe "for a document with a one embedded association" do
+    before(:all) do
+      # check assumptions of these examples
+      Parent.associations[:child].should be_one
+      Parent.associations[:child].should be_embedded
+    end
+
+    it_behaves_like "embedded association persistence logic" do
+      let(:parent)   { Parent.new }
+      let(:children) { [Child.new(:name => 'Bobby', :age => 9)] }
+
+      before(:each) do
+        parent.child = children.first
+      end
+    end
+  end
 end

data/spec/ripple/properties_spec.rb

@@ -1,20 +1,7 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Ripple::Properties do
-  require 'support/models/email'
+  # require 'support/models/email'
 
   it "should make the model class have a property definition method" do
     Email.should respond_to(:property)
@@ -252,5 +239,24 @@ describe Ripple::Property do
         @prop.type_cast("  ").should be_nil
       end
     end
+
+    describe "when type is a Set type" do
+      let(:prop) { Ripple::Property.new(:foo, Set) }
+
+      it "casts an array to a a set" do
+        prop.type_cast([1]).should be_a(Set)
+        prop.type_cast([1]).to_a.should == [1]
+      end
+
+      it "does not cast nil" do
+        prop.type_cast(nil).should be_nil
+      end
+
+      it "raises an error when casting a non-enumerable" do
+        expect {
+          prop.type_cast(1)
+        }.to raise_error(Ripple::PropertyTypeMismatch)
+      end
+    end
   end
 end

data/spec/ripple/ripple_spec.rb

@@ -1,17 +1,4 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../spec_helper", File.dirname(__FILE__))
+require 'spec_helper'
 
 describe Ripple do
   it "should have a client" do

data/spec/ripple/serialization_spec.rb

@@ -1,22 +1,9 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-require File.expand_path("../../spec_helper", __FILE__)
+require 'spec_helper'
 
 describe Ripple::Serialization do
-  require 'support/models/invoice'
-  require 'support/models/note'
-  require 'support/models/customer'
+  # require 'support/models/invoice'
+  # require 'support/models/note'
+  # require 'support/models/customer'
 
   it "should provide JSON serialization" do
     Invoice.new.should respond_to(:to_json)
@@ -33,11 +20,23 @@ describe Ripple::Serialization do
       doc.serializable_hash['key'].should == "1"
     end
 
+    it "should be able to exclude the document key" do
+      doc = Invoice.new
+      doc.key = "1"
+      doc.serializable_hash(:except => [:key]).should_not include("key")
+    end
+
     it "should include embedded documents by default" do
       doc = Invoice.new(:note => {:text => "Dear customer,..."}).serializable_hash
       doc['note'].should eql({'text' => "Dear customer,..."})
     end
 
+    it "should exclude the _type field from embedded documents" do
+      doc = Invoice.new
+      doc.note = Note.new :text => "Dear customer,..."
+      doc.serializable_hash['note'].should_not include("_type")
+    end
+
     it "should exclude specified attributes" do
       hash = Invoice.new.serializable_hash(:except => [:created_at])
       hash.should_not include('created_at')

data/spec/ripple/timestamps_spec.rb

@@ -1,55 +1,76 @@
-# Copyright 2010 Sean Cribbs, Sonian Inc., and Basho Technologies, Inc.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#        http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
+
+shared_examples_for "a timestamped model" do
+  it "adds a created_at property" do
+    subject.should respond_to(:created_at)
+  end
+
+  it "adds an updated_at property" do
+    subject.should respond_to(:updated_at)
+  end
+
+  it "sets the created_at timestamp when the object is initialized" do
+    subject.created_at.should_not be_nil
+  end
+
+  it "does not set the updated_at timestamp when the object is initialized" do
+    subject.updated_at.should be_nil
+  end
+
+  it "sets the updated_at timestamp when the object is saved" do
+    record_to_save.save
+    subject.updated_at.should_not be_nil
+  end
+
+  it "updates the updated_at timestamp when the object is updated" do
+    record_to_save.save
+    start = subject.updated_at
+    record_to_save.save
+    subject.updated_at.should > start
+  end
+
+  it "does not update the created_at timestamp when the object is updated" do
+    record_to_save.save
+    start = subject.created_at
+    record_to_save.save
+    subject.created_at.should == start
+  end
+end
 
 describe Ripple::Timestamps do
-  require 'support/models/clock'
-  
-  before :each do
-    response = {:headers => {"content-type" => ["application/json"]}, :body => "{}"}
-    @client = Ripple.client
-    @backend = mock("Backend", :store_object => true)
-    @client.stub!(:backend).and_return(@backend)
-    @clock = Clock.new
-  end
-  
-  it "should add a created_at property" do
-    @clock.should respond_to(:created_at)
-  end
-  
-  it "should add an updated_at property" do
-    @clock.should respond_to(:updated_at)
-  end
-  
-  it "should set the created_at timestamp when the object is initialized" do
-    @clock.created_at.should_not be_nil
-  end
-  
-  it "should not set the updated_at timestamp when the object is initialized" do
-    @clock.updated_at.should be_nil
-  end
-  
-  it "should set the updated_at timestamp when the object is created" do
-    @clock.save
-    @clock.updated_at.should_not be_nil
-  end
-  
-  it "should update the updated_at timestamp when the object is updated" do
-    @clock.save
-    start = @clock.updated_at
-    @clock.save
-    @clock.updated_at.should > start
-  end  
+  # require 'support/models/clock'
+
+  let(:backend) { mock("Backend", :store_object => true) }
+  before(:each) { Ripple.client.stub!(:backend).and_return(backend) }
+
+  context "for a Ripple::Document" do
+    it_behaves_like "a timestamped model" do
+      subject { Clock.new }
+      let(:record_to_save) { subject }
+    end
+  end
+
+  context "for a Ripple::EmbeddedDocument when directly saved" do
+    it_behaves_like "a timestamped model" do
+      let(:clock) { Clock.new }
+      subject { Mode.new }
+      let(:record_to_save) { subject }
+
+      before(:each) do
+        clock.modes << subject
+      end
+    end
+  end
+
+  context "for a Ripple::EmbeddedDocument when the parent is saved" do
+    it_behaves_like "a timestamped model" do
+      let(:clock) { Clock.new }
+      subject { Mode.new }
+      let(:record_to_save) { clock }
+
+      before(:each) do
+        clock.modes << subject
+      end
+    end
+  end
 end