refinerycms-pages 2.0.10 → 2.1.0

data/spec/lib/refinery/pages/tab_spec.rb

@@ -0,0 +1,89 @@
+require "spec_helper"
+
+module Refinery
+  module Pages
+
+    describe ".tabs" do
+      after do
+        Refinery::Pages.instance_eval { @tabs = [] }
+      end
+
+      it "returns an array of registered tabs" do
+        rspec_tab = Refinery::Pages::Tab.register do |tab|
+          tab.name = "rspec"
+          tab.partial = "rspec"
+        end
+
+        Refinery::Pages.tabs.should include(rspec_tab)
+      end
+    end
+
+    describe ".tabs_for_template" do
+      after do
+        Refinery::Pages.instance_eval { @tabs = [] }
+      end
+
+      it "returns all tabs for which #templates hasn't been set" do
+        rspec_tab = Refinery::Pages::Tab.register do |tab|
+          tab.name = "rspec"
+          tab.partial = "rspec"
+        end
+
+        Refinery::Pages.tabs_for_template("huh").should include(rspec_tab)
+      end
+
+      it "returns tabs with matched template" do
+        rspec_tab = Refinery::Pages::Tab.register do |tab|
+          tab.name = "rspec"
+          tab.partial = "rspec"
+          tab.templates = "rspec"
+        end
+
+        Refinery::Pages.tabs_for_template("rspec").should include(rspec_tab)
+      end
+    end
+
+    describe Tab do
+      after do
+        Refinery::Pages.instance_eval { @tabs = [] }
+      end
+
+      describe ".register" do
+        it "requires name to be set" do
+          lambda {
+            Refinery::Pages::Tab.register do |tab|
+              tab.partial = "rspec"
+            end
+          }.should raise_error
+        end
+
+        it "requires partial to be set" do
+          lambda {
+            Refinery::Pages::Tab.register do |tab|
+              tab.name = "rspec"
+            end
+          }.should raise_error
+        end
+
+        it "sets #templates if it's not set" do
+          rspec_tab = Refinery::Pages::Tab.register do |tab|
+            tab.name = "rspec"
+            tab.partial = "rspec"
+          end
+
+          rspec_tab.templates.should eq(["all"])
+        end
+
+        it "converts #templates to array if it's not an array already" do
+          rspec_tab = Refinery::Pages::Tab.register do |tab|
+            tab.name = "rspec"
+            tab.partial = "rspec"
+            tab.templates = "rspec"
+          end
+
+          rspec_tab.templates.should eq(["rspec"])
+        end
+      end
+    end
+  end
+end

data/spec/lib/refinery/pages/url_spec.rb

@@ -0,0 +1,74 @@
+require "spec_helper"
+require 'refinery/pages/url'
+
+module Refinery
+  module Pages
+    describe Url::Localised do
+      describe ".handle?" do
+        it "returns true if link_url is present" do
+          page = double(:page, :link_url => "/")
+          Url::Localised.handle?(page).should be_true
+        end
+      end
+
+      describe "#url" do
+        let(:page) { double(:page, :link_url => "/test") }
+
+        context "when current frontend locale != default frontend locale" do
+          it "returns link_url prefixed with current frontend locale" do
+            Refinery::I18n.stub(:current_frontend_locale).and_return(:lv)
+            Refinery::I18n.stub(:default_frontend_locale).and_return(:en)
+            Url::Localised.new(page).url.should eq("/lv/test")
+          end
+        end
+
+        context "when current frontend locale == default frontend locale" do
+          it "returns unaltered link_url" do
+            Refinery::I18n.stub(:current_frontend_locale).and_return(:en)
+            Refinery::I18n.stub(:default_frontend_locale).and_return(:en)
+            Url::Localised.new(page).url.should eq("/test")
+          end
+        end
+      end
+    end
+
+    describe Url::Marketable do
+      describe ".handle?" do
+        it "returns true if marketable_url config is set to true" do
+          page = double(:page)
+          Refinery::Pages.stub(:marketable_url).and_return(true)
+          Url::Marketable.handle?(page).should be_true
+        end
+      end
+
+      describe "#url" do
+        it "returns hash" do
+          page = double(:page, :nested_url => "test")
+          Url::Marketable.new(page).url.should eq({
+            :controller => "/refinery/pages", :action => "show", :only_path => true,
+            :path => "test", :id => nil
+          })
+        end
+      end
+    end
+
+    describe Url::Normal do
+      describe ".handle?" do
+        it "returns true if to_param is present" do
+          page = double(:page, :to_param => "test")
+          Url::Normal.handle?(page).should be_true
+        end
+      end
+
+      describe "#url" do
+        it "returns hash" do
+          page = double(:page, :to_param => "test")
+          Url::Normal.new(page).url.should eq({
+            :controller => "/refinery/pages", :action => "show", :only_path => true,
+            :path => nil, :id => "test"
+          })
+        end
+      end
+    end
+  end
+end

data/spec/models/refinery/page_spec.rb

@@ -3,7 +3,6 @@ require 'spec_helper'
 
 module Refinery
   describe Page do
-
     let(:page_title) { 'RSpec is great for testing too' }
     let(:child_title) { 'The child page' }
 
@@ -16,15 +15,24 @@ module Refinery
     let(:created_child) { created_page.children.create!(:title => child_title) }
 
     def page_cannot_be_destroyed
+      page.should_receive(:puts_destroy_help)
       page.destroy.should == false
     end
 
     def turn_off_marketable_urls
-      Refinery::Pages.stub(:marketable_urls).and_return(false)
+      Pages.stub(:marketable_urls).and_return(false)
     end
 
     def turn_on_marketable_urls
-      Refinery::Pages.stub(:marketable_urls).and_return(true)
+      Pages.stub(:marketable_urls).and_return(true)
+    end
+
+    def turn_off_slug_scoping
+      Pages.stub(:scope_slug_by_parent).and_return(false)
+    end
+
+    def turn_on_slug_scoping
+      Pages.stub(:scope_slug_by_parent).and_return(true)
     end
 
     context 'cannot be deleted under certain rules' do
@@ -106,9 +114,9 @@ module Refinery
 
     context 'canonicals' do
       before do
-        ::Refinery::I18n.stub(:default_frontend_locale).and_return(:en)
-        ::Refinery::I18n.stub(:frontend_locales).and_return([Refinery::I18n.default_frontend_locale, :ru])
-        ::Refinery::I18n.stub(:current_frontend_locale).and_return(Refinery::I18n.default_frontend_locale)
+        Refinery::I18n.stub(:default_frontend_locale).and_return(:en)
+        Refinery::I18n.stub(:frontend_locales).and_return([I18n.default_frontend_locale, :ru])
+        Refinery::I18n.stub(:current_frontend_locale).and_return(I18n.default_frontend_locale)
 
         page.save
       end
@@ -118,7 +126,7 @@ module Refinery
 
       describe '#canonical' do
         let!(:default_canonical) {
-          Globalize.with_locale(::Refinery::I18n.default_frontend_locale) {
+          Globalize.with_locale(Refinery::I18n.default_frontend_locale) {
             page.canonical
           }
         }
@@ -143,7 +151,7 @@ module Refinery
 
       describe '#canonical_slug' do
         let!(:default_canonical_slug) {
-          Globalize.with_locale(::Refinery::I18n.default_frontend_locale) {
+          Globalize.with_locale(Refinery::I18n.default_frontend_locale) {
             page.canonical_slug
           }
         }
@@ -169,16 +177,20 @@ module Refinery
     context 'custom slugs' do
       let(:custom_page_slug) { 'custom-page-slug' }
       let(:custom_child_slug) { 'custom-child-slug' }
+      let(:custom_route) { '/products/my-product' }
       let(:page_with_custom_slug) {
         subject.class.new(:title => page_title, :custom_slug => custom_page_slug)
       }
       let(:child_with_custom_slug) {
         page.children.new(:title => child_title, :custom_slug => custom_child_slug)
       }
+      let(:page_with_custom_route) {
+        subject.class.new(:title => page_title, :custom_slug => custom_route)
+      }
 
       after(:each) do
-        ::Refinery::I18n.stub(:current_frontend_locale).and_return(Refinery::I18n.default_frontend_locale)
-        ::Refinery::I18n.current_locale = Refinery::I18n.default_locale
+        Refinery::I18n.stub(:current_frontend_locale).and_return(I18n.default_frontend_locale)
+        Refinery::I18n.stub(:current_locale).and_return(I18n.default_locale)
       end
 
       it 'returns its path with custom slug' do
@@ -187,6 +199,23 @@ module Refinery
         page_with_custom_slug.url[:path].should == [custom_page_slug]
       end
 
+      it 'allows a custom route when slug scoping is off' do
+        turn_off_slug_scoping
+        page_with_custom_route.save
+        page_with_custom_route.url[:id].should be_nil
+        page_with_custom_route.url[:path].should == [custom_route]
+        turn_on_slug_scoping
+      end
+
+      it 'allows slashes in custom routes but slugs everything in between' do
+        turn_off_slug_scoping
+        page_needing_a_slugging = subject.class.new(:title => page_title, :custom_slug => 'products/category/sub category/my product is cool!')
+        page_needing_a_slugging.save
+        page_needing_a_slugging.url[:id].should be_nil
+        page_needing_a_slugging.url[:path].should == ['products/category/sub-category/my-product-is-cool']
+        turn_on_slug_scoping
+      end
+
       it 'returns its path underneath its parent with custom urls' do
         child_with_custom_slug.save
         page.save
@@ -195,9 +224,41 @@ module Refinery
         child_with_custom_slug.url[:path].should == [page.url[:path].first, custom_child_slug]
       end
 
+      it 'does not return a path underneath its parent when scoping is off' do
+        turn_off_slug_scoping
+        child_with_custom_slug.save
+        page.save
+
+        child_with_custom_slug.url[:id].should be_nil
+        child_with_custom_slug.url[:path].should == [custom_child_slug]
+        turn_on_slug_scoping
+      end
+
+      it "doesn't allow slashes in slug" do
+        page_with_slashes_in_slug = subject.class.new(:title => page_title, :custom_slug => '/products/category')
+        page_with_slashes_in_slug.save
+        page_with_slashes_in_slug.url[:path].should == ['productscategory']
+      end
+
+      it "allow slashes in slug when slug scoping is off" do
+        turn_off_slug_scoping
+        page_with_slashes_in_slug = subject.class.new(:title => page_title, :custom_slug => 'products/category/subcategory')
+        page_with_slashes_in_slug.save
+        page_with_slashes_in_slug.url[:path].should == ['products/category/subcategory']
+        turn_on_slug_scoping
+      end
+
+      it "strips leading and trailing slashes in slug when slug scoping is off" do
+        turn_off_slug_scoping
+        page_with_slashes_in_slug = subject.class.new(:title => page_title, :custom_slug => '/products/category/subcategory/')
+        page_with_slashes_in_slug.save
+        page_with_slashes_in_slug.url[:path].should == ['products/category/subcategory']
+        turn_on_slug_scoping
+      end
+
       it 'returns its path with custom slug when using different locale' do
-        ::Refinery::I18n.stub(:current_frontend_locale).and_return(:ru)
-        ::Refinery::I18n.current_locale = :ru
+        Refinery::I18n.stub(:current_frontend_locale).and_return(:ru)
+        Refinery::I18n.stub(:current_locale).and_return(:ru)
         page_with_custom_slug.custom_slug = "#{custom_page_slug}-ru"
         page_with_custom_slug.save
         page_with_custom_slug.reload
@@ -207,8 +268,8 @@ module Refinery
       end
 
       it 'returns path underneath its parent with custom urls when using different locale' do
-        ::Refinery::I18n.stub(:current_frontend_locale).and_return(:ru)
-        ::Refinery::I18n.current_locale = :ru
+        Refinery::I18n.stub(:current_frontend_locale).and_return(:ru)
+        Refinery::I18n.stub(:current_locale).and_return(:ru)
         child_with_custom_slug.custom_slug = "#{custom_child_slug}-ru"
         child_with_custom_slug.save
         child_with_custom_slug.reload
@@ -217,16 +278,17 @@ module Refinery
         child_with_custom_slug.url[:path].should == [page.url[:path].first, "#{custom_child_slug}-ru"]
       end
 
-    end
+      context "given a page with a custom_slug exists" do
+        before do
+          FactoryGirl.create(:page, :custom_slug => custom_page_slug)
+        end
 
-    context 'home page' do
-      it 'responds as the home page' do
-        page.link_url = '/'
-        page.home?.should == true
-      end
+        it "fails validation when a new record uses that custom_slug" do
+          new_page = Page.new :custom_slug => custom_page_slug
+          new_page.valid?
 
-      it 'responds as a normal page when not set to home page' do
-        page.home?.should == false
+          new_page.errors[:custom_slug].should_not be_empty
+        end
       end
     end
 
@@ -241,8 +303,37 @@ module Refinery
         page.content_for('BoDY').should == "<p>I'm the first page part for this page.</p>"
       end
 
-      it 'return all page part content' do
-        page.all_page_part_content.should == "<p>I'm the first page part for this page.</p> <p>Closely followed by the second page part.</p>"
+      it 'requires a unique title' do
+        page.save
+        page.parts.create(:title => 'body')
+        duplicate_title_part = page.parts.create(:title => 'body')
+
+        duplicate_title_part.errors[:title].should be_present
+      end
+
+      it 'only requires a unique title on the same page' do
+        part_one = Page.create(:title => 'first page').parts.create(:title => 'body')
+        part_two = Page.create(:title => 'second page').parts.create(:title => 'body')
+
+        part_two.errors[:title].should be_empty
+      end
+
+      context 'when using content_for?' do
+
+        it 'return true when page part has content' do
+          page.content_for?(:body).should be_true
+        end
+
+        it 'return false when page part does not exist' do
+          page.parts = []
+          page.content_for?(:body).should be_false
+        end
+
+        it 'return false when page part does not have any content' do
+          page.parts.first.content = ''
+          page.content_for?(:body).should be_false
+        end
+
       end
 
       it 'reposition correctly' do
@@ -295,10 +386,6 @@ module Refinery
 
     context 'meta data' do
       context 'responds to' do
-        it 'meta_keywords' do
-          page.respond_to?(:meta_keywords)
-        end
-
         it 'meta_description' do
           page.respond_to?(:meta_description)
         end
@@ -309,11 +396,6 @@ module Refinery
       end
 
       context 'allows us to assign to' do
-        it 'meta_keywords' do
-          page.meta_keywords = 'Some, great, keywords'
-          page.meta_keywords.should == 'Some, great, keywords'
-        end
-
         it 'meta_description' do
           page.meta_description = 'This is my description of the page for search results.'
           page.meta_description.should == 'This is my description of the page for search results.'
@@ -326,14 +408,6 @@ module Refinery
       end
 
       context 'allows us to update' do
-        it 'meta_keywords' do
-          page.meta_keywords = 'Some, great, keywords'
-          page.save
-
-          page.reload
-          page.meta_keywords.should == 'Some, great, keywords'
-        end
-
         it 'meta_description' do
           page.meta_description = 'This is my description of the page for search results.'
           page.save
@@ -355,12 +429,12 @@ module Refinery
 
     describe "#to_refinery_menu_item" do
       let(:page) do
-        Refinery::Page.new(
+        Page.new(
           :id => 5,
           :parent_id => 8,
           :menu_match => "^/foo$"
 
-        # Refinery::Page does not allow setting lft and rgt, so stub them.
+        # Page does not allow setting lft and rgt, so stub them.
         ).tap do |p|
           p[:lft] = 6
           p[:rgt] = 7
@@ -387,30 +461,6 @@ module Refinery
         end
       end
 
-      context "with #page_menu_title" do
-        before do
-          page.page_menu_title = "Page Menu Title"
-        end
-
-        it_should_behave_like "Refinery menu item hash"
-
-        it "returns the page_menu_title for :title" do
-          subject[:title].should eq("Page Menu Title")
-        end
-      end
-
-      context "with #page_title" do
-        before do
-          page.page_title = "Page Title"
-        end
-
-        it_should_behave_like "Refinery menu item hash"
-
-        it "returns the page_title for :title" do
-          subject[:title].should eq("Page Title")
-        end
-      end
-
       context "with #menu_title" do
         before do
           page[:menu_title] = "Menu Title"
@@ -436,7 +486,7 @@ module Refinery
       end
     end
 
-    describe ".in_menu?" do
+    describe "#in_menu?" do
       context "when live? and show_in_menu? returns true" do
         it "returns true" do
           page.stub(:live?).and_return(true)
@@ -458,7 +508,7 @@ module Refinery
       end
     end
 
-    describe ".not_in_menu?" do
+    describe "#not_in_menu?" do
       context "when in_menu? returns true" do
         it "returns false" do
           page.stub(:in_menu?).and_return(true)
@@ -486,11 +536,86 @@ module Refinery
       end
 
       it "should return (root) about page when looking for '/about'" do
-        Refinery::Page.find_by_path('/about').should == created_root_about
+        Page.find_by_path('/about').should == created_root_about
       end
 
       it "should return child about page when looking for '/team/about'" do
-        Refinery::Page.find_by_path('/team/about').should == created_child
+        Page.find_by_path('/team/about').should == created_child
+      end
+    end
+
+    describe ".find_by_path_or_id" do
+      let!(:market) { FactoryGirl.create(:page, :title => "market") }
+      let(:path) { "market" }
+      let(:id) { market.id }
+
+      context "when path param is present" do
+        context "when path is friendly_id" do
+          it "finds page using path" do
+            Page.find_by_path_or_id(path, "").should eq(market)
+          end
+        end
+
+        context "when path is not friendly_id" do
+          it "finds page using id" do
+            Page.find_by_path_or_id(id, "").should eq(market)
+          end
+        end
+      end
+
+      context "when id param is present" do
+        it "finds page using id" do
+          Page.find_by_path_or_id("", id).should eq(market)
+        end
+      end
+    end
+
+    describe "#deletable?" do
+      let(:deletable_page) do
+        page.deletable  = true
+        page.link_url   = ""
+        page.menu_match = ""
+        page.stub(:puts_destroy_help).and_return('')
+        page
+      end
+
+      context "when deletable is true and link_url, and menu_match is blank" do
+        it "returns true" do
+          deletable_page.deletable?.should be_true
+        end
+      end
+
+      context "when deletable is false and link_url, and menu_match is blank" do
+        it "returns false" do
+          deletable_page.deletable = false
+          deletable_page.deletable?.should be_false
+        end
+      end
+
+      context "when deletable is false and link_url or menu_match isn't blank" do
+        it "returns false" do
+          deletable_page.deletable  = false
+          deletable_page.link_url   = "text"
+          deletable_page.deletable?.should be_false
+
+          deletable_page.menu_match = "text"
+          deletable_page.deletable?.should be_false
+        end
+      end
+    end
+
+    describe "#destroy" do
+      before do
+        page.deletable  = false
+        page.link_url   = "link_url"
+        page.menu_match = "menu_match"
+        page.save!
+      end
+
+      it "shows message" do
+        page.should_receive(:puts_destroy_help)
+
+        page.destroy
       end
     end
   end