refinerycms-pages 2.0.10 → 2.1.0

data/spec/{requests → features}/refinery/pages_spec.rb

@@ -7,11 +7,8 @@ module Refinery
     let(:about_page) { Page.create :title => 'About' }
     let(:draft_page) { Page.create :title => 'Draft', :draft => true }
     before do
-      # So that we can use Refinery.
-      Refinery::PagesController.any_instance.stub(:refinery_user_required?).and_return(false)
-
       # Stub the menu pages we're expecting
-      Refinery::Page.stub(:fast_menu).and_return([home_page, about_page])
+      Page.stub(:fast_menu).and_return([home_page, about_page])
     end
 
     def standard_page_menu_items_exist?
@@ -24,17 +21,17 @@ module Refinery
 
     describe 'when marketable urls are' do
       describe 'enabled' do
-        before { Refinery::Pages.stub(:marketable_urls).and_return(true) }
+        before { Pages.stub(:marketable_urls).and_return(true) }
 
         it 'shows the homepage' do
-          Refinery::PagesController.any_instance.stub(:find_page).and_return(:home_page)
+          PagesController.any_instance.stub(:find_page).and_return(:home_page)
           visit '/'
 
           standard_page_menu_items_exist?
         end
 
         it 'shows a show page' do
-          Refinery::PagesController.any_instance.stub(:find_page).and_return(:about_page)
+          PagesController.any_instance.stub(:find_page).and_return(:about_page)
           visit refinery.page_path(about_page)
 
           standard_page_menu_items_exist?
@@ -42,10 +39,10 @@ module Refinery
       end
 
       describe 'disabled' do
-        before { Refinery::Pages.stub(:marketable_urls).and_return(false) }
+        before { Pages.stub(:marketable_urls).and_return(false) }
 
         it 'shows the homepage' do
-          Refinery::PagesController.any_instance.stub(:find_page).and_return(:home_page)
+          PagesController.any_instance.stub(:find_page).and_return(:home_page)
           visit '/'
 
           standard_page_menu_items_exist?
@@ -56,7 +53,7 @@ module Refinery
         end
 
         it 'shows the about page' do
-          Refinery::PagesController.any_instance.stub(:find_page).and_return(:about_page)
+          PagesController.any_instance.stub(:find_page).and_return(:about_page)
           visit refinery.page_path(about_page)
 
           standard_page_menu_items_exist?
@@ -71,12 +68,18 @@ module Refinery
         find("#body_content_title").text.should == about_page.title
       end
 
+      it "should hide title when config is set" do
+        Pages.stub(:show_title_in_body).and_return(false)
+        visit '/about'
+        page.should_not have_selector("#body_content_title")
+      end
+
       it "uses title in the menu" do
         find(".selected").text.strip.should == about_page.title
       end
 
       it "uses title in browser title" do
-        find("title").should have_content(about_page.title)
+        page.has_title?(about_page.title)
       end
     end
 
@@ -84,7 +87,7 @@ module Refinery
       let(:page_mt) { Page.create :title => 'Company News' }
 
       before do
-        Refinery::Page.stub(:fast_menu).and_return([page_mt])
+        Page.stub(:fast_menu).and_return([page_mt])
       end
 
       describe 'set' do
@@ -102,7 +105,7 @@ module Refinery
         it "does not effect browser title and page title" do
           visit "/news"
 
-          find("title").should have_content(page_mt.title)
+          page.has_title?(page_mt.title)
           find("#body_content_title").text.should == page_mt.title
         end
       end
@@ -129,12 +132,12 @@ module Refinery
         Page.create :title => 'About Us', :browser_title => 'About Our Company'
       }
       before do
-        Refinery::Page.stub(:fast_menu).and_return([page_bt])
+        Page.stub(:fast_menu).and_return([page_bt])
       end
       it 'should have the browser_title in the title tag' do
         visit '/about-us'
 
-        page.find("title").text == page_bt.title
+        page.has_title?(page_bt.title)
       end
 
       it 'should not effect page title and menu title' do
@@ -148,7 +151,7 @@ module Refinery
     describe 'custom_slug' do
       let(:page_cs) { Page.create :title => 'About Us' }
       before do
-        Refinery::Page.stub(:fast_menu).and_return([page_cs])
+        Page.stub(:fast_menu).and_return([page_cs])
       end
 
       describe 'not set' do
@@ -181,6 +184,23 @@ module Refinery
           page_cs.reload
         end
       end
+
+      describe 'set with slashes' do
+        before do
+          Pages.stub(:scope_slug_by_parent).and_return(false)
+          page_cs.custom_slug = "products/my product/cool one!"
+          page_cs.save
+        end
+
+        after do
+          Pages.stub(:scope_slug_by_parent).and_return(true)
+        end
+
+        it 'should make and use a new friendly_id' do
+          visit '/products/my-product/cool-one'
+          current_path.should == '/products/my-product/cool-one'
+        end
+      end
     end
 
     # Following specs are converted from one of the cucumber features.
@@ -211,7 +231,9 @@ module Refinery
       let(:submenu_page) { about_page.children.create :title => 'Sample Submenu' }
 
       before do
-        Refinery::Page.stub(:fast_menu).and_return([home_page, submenu_page, about_page.reload].sort_by(&:lft))
+        Page.stub(:fast_menu).and_return(
+          [home_page, submenu_page, about_page.reload].sort_by(&:lft)
+        )
       end
 
       it "succeeds" do
@@ -227,7 +249,9 @@ module Refinery
     describe "special characters title" do
       let(:special_page) { Page.create :title => 'ä ö ü spéciål chåråctÉrs' }
       before do
-        Refinery::Page.stub(:fast_menu).and_return([home_page, about_page, special_page])
+        Page.stub(:fast_menu).and_return(
+          [home_page, about_page, special_page]
+        )
       end
 
       it "succeeds" do
@@ -247,7 +271,7 @@ module Refinery
       }
 
       before do
-        Refinery::Page.stub(:fast_menu).and_return(
+        Page.stub(:fast_menu).and_return(
           [home_page, special_page, about_page.reload].sort_by &:lft
         )
       end
@@ -267,7 +291,7 @@ module Refinery
       let(:hidden_page) { Page.create :title => "Hidden", :show_in_menu => false }
 
       before do
-        Refinery::Page.stub(:fast_menu).and_return([home_page, about_page])
+        Page.stub(:fast_menu).and_return([home_page, about_page])
       end
 
       it "succeeds" do
@@ -283,14 +307,13 @@ module Refinery
     end
 
     describe "skip to first child" do
-      let(:child_page) { about_page.children.create :title => "Child Page" }
+      let!(:child_page) { about_page.children.create :title => "Child Page" }
       before do
-       child_page
        about = about_page.reload
        about.skip_to_first_child = true
        about.save!
 
-       Refinery::Page.stub(:fast_menu).and_return([home_page, about, child_page].sort_by(&:lft))
+       Page.stub(:fast_menu).and_return([home_page, about, child_page].sort_by(&:lft))
       end
 
       it "succeeds" do
@@ -301,5 +324,98 @@ module Refinery
         end
       end
     end
+
+    describe "full page caching" do
+      include CachingHelpers
+      let(:cached_page) { Page.create :title => 'Another Cached page' }
+
+      context "is enabled", :caching do
+        it "should create a cached file when none exists" do
+          cached_page.should_not be_cached
+
+          visit refinery.page_path(cached_page)
+
+          cached_page.should be_cached
+        end
+      end
+
+      context "is disabled" do
+        it "should not cache a page" do
+          page.should_not be_cached
+          visit refinery.page_path(cached_page)
+          cached_page.should_not be_cached
+        end
+      end
+    end
+
+    context "with multiple locales" do
+
+      describe "redirects" do
+        before { Refinery::I18n.stub(:frontend_locales).and_return([:en, :ru]) }
+        after { Refinery::I18n.unstub(:frontend_locales) }
+        let(:en_page_title) { 'News' }
+        let(:en_page_slug) { 'news' }
+        let(:ru_page_title) { 'Новости' }
+        let(:ru_page_slug_encoded) { '%D0%BD%D0%BE%D0%B2%D0%BE%D1%81%D1%82%D0%B8' }
+        let!(:news_page) do
+          _page = Globalize.with_locale(:en) {
+            Page.create :title => en_page_title
+          }
+          Globalize.with_locale(:ru) do
+            _page.title = ru_page_title
+            _page.save
+          end
+
+          _page
+        end
+
+        it "should recognise when default locale is in the path" do
+          visit "/en/#{en_page_slug}"
+
+          current_path.should == "/en/#{en_page_slug}"
+        end
+
+        it "should redirect to default locale slug" do
+          visit "/#{ru_page_slug_encoded}"
+
+          current_path.should == "/#{en_page_slug}"
+        end
+
+        it "should redirect to second locale slug" do
+          visit "/ru/#{en_page_slug}"
+
+          current_path.should == "/ru/#{ru_page_slug_encoded}"
+
+          visit "/en/#{en_page_slug}"
+        end
+
+        describe "nested page" do
+          let(:nested_page_title) { '2012' }
+          let(:nested_page_slug) { '2012' }
+
+          let!(:nested_page) do
+            _page = Globalize.with_locale(:en) {
+              news_page.children.create :title => nested_page_title
+            }
+
+            Globalize.with_locale(:ru) do
+              _page.title = nested_page_title
+              _page.save
+            end
+
+            _page
+          end
+
+          it "should redirect to localized url" do
+            visit "/ru/#{en_page_slug}/#{nested_page_slug}"
+
+            current_path.should == "/ru/#{ru_page_slug_encoded}/#{nested_page_slug}"
+
+            visit "/en/#{en_page_slug}/#{nested_page_slug}"
+          end
+        end
+      end
+    end
+
   end
 end

data/spec/helpers/refinery/pages/admin/pages_helper_spec.rb

@@ -4,27 +4,35 @@ module Refinery
   module Admin
     describe PagesHelper do
       describe "#template_options" do
-        context "when page layout/view templte is set" do
-          it "returns empty hash" do
+        context "when page layout/view template is set" do
+          it "returns those templates as selected" do
             page = FactoryGirl.create(:page)
 
             page.view_template = "rspec_template"
-            helper.template_options(:view_template, page).should eq({})
+            helper.template_options(:view_template, page).should eq(:selected => "rspec_template")
 
             page.layout_template = "rspec_layout"
-            helper.template_options(:layout_template, page).should eq({})
+            helper.template_options(:layout_template, page).should eq(:selected => "rspec_layout")
           end
         end
 
-        context "when page layout/view template isn't set" do
-          context "when page has parent" do
-            it "returns option hash based on parent page" do
-              parent = FactoryGirl.create(:page, :view_template => "rspec_view",
-                                                 :layout_template => "rspec_layout")
-              page = FactoryGirl.create(:page, :parent_id => parent.id)
+        context "when page layout template is set using symbols" do
+          before do
+            Pages.config.stub(:layout_template_whitelist).and_return [:three, :one, :two]
+          end
+
+          it "works as expected" do
+            page = FactoryGirl.create(:page, :layout_template => "three")
+
+            helper.template_options(:layout_template, page).should eq(:selected => 'three')
+          end
+        end
 
-              expected_view = { :selected => parent.view_template }
-              helper.template_options(:view_template, page).should eq(expected_view)
+        context "when page layout template isn't set" do
+          context "when page has parent and parent has layout_template set" do
+            it "returns parent layout_template as selected" do
+              parent = FactoryGirl.create(:page, :layout_template => "rspec_layout")
+              page = FactoryGirl.create(:page, :parent_id => parent.id)
 
               expected_layout = { :selected => parent.layout_template }
               helper.template_options(:layout_template, page).should eq(expected_layout)
@@ -32,18 +40,10 @@ module Refinery
           end
 
           context "when page doesn't have parent page" do
-            before do
-              Refinery::Pages.stub(:view_template_whitelist).and_return(%w(one two))
-              Refinery::Pages.stub(:layout_template_whitelist).and_return(%w(two one))
-            end
-
-            it "returns option hash with first item from configured whitelist" do
+            it "returns default application template" do
               page = FactoryGirl.create(:page)
 
-              expected_view = { :selected => "one" }
-              helper.template_options(:view_template, page).should eq(expected_view)
-
-              expected_layout = { :selected => "two" }
+              expected_layout = { :selected => "application" }
               helper.template_options(:layout_template, page).should eq(expected_layout)
             end
           end
@@ -57,7 +57,7 @@ module Refinery
           it "adds 'hidden' label" do
             page.show_in_menu = false
 
-            helper.page_meta_information(page).should eq("<span class=\"label\">hidden</span>")
+            helper.page_meta_information(page).should eq(%q{<span class="label">hidden</span>})
           end
         end
 
@@ -65,7 +65,7 @@ module Refinery
           it "adds 'draft' label" do
             page.draft = true
 
-            helper.page_meta_information(page).should eq("<span class=\"label notice\">draft</span>")
+            helper.page_meta_information(page).should eq(%q{<span class="label notice">draft</span>})
           end
         end
       end
@@ -93,7 +93,7 @@ module Refinery
 
         context "when title for current locale isn't available" do
           it "returns existing title from translations" do
-            Refinery::Page::Translation.where(:locale => :en).first.delete
+            Page.translation_class.where(:locale => :en).first.destroy
             helper.page_title_with_translations(page).should eq("melnraksts")
           end
         end

data/spec/lib/refinery/pages/caching_spec.rb

@@ -0,0 +1,90 @@
+require "spec_helper"
+require 'refinery/pages/caching'
+
+module Refinery
+  module Pages
+    describe Caching, :caching do
+      let(:cache_path) { "/tmp"}
+      let(:refinery_cache_path) { "/tmp/refinery/cache/pages"}
+      let(:refinery_cache_file) { refinery_cache_path + ".html"}
+      before do
+        FileUtils.mkpath refinery_cache_path
+        FileUtils.touch refinery_cache_file
+      end
+
+      after do
+        FileUtils.rm_rf refinery_cache_path
+        FileUtils.rm_rf refinery_cache_file
+      end
+
+      let(:cache) { Caching.new(cache_path) }
+
+      describe "#expire!" do
+        it "should call #clear_caching! and #delete_static_files!" do
+          cache.should_receive(:clear_caching!)
+          cache.should_receive(:delete_static_files!)
+          cache.expire!
+        end
+
+        describe "#clear_caching!" do
+          context "rails cache store supports #delete_matched" do
+            before { Rails.cache.stub(:delete_matched)}
+
+            it "should clear rails cache that matched namespace" do
+              Rails.cache.should_receive(:delete_matched).with(/.*pages.*/)
+              cache.expire!
+            end
+          end
+
+          context "rails cache store does not supports #delete_matched" do
+            before { Rails.cache.stub(:delete_matched).and_raise(NotImplementedError) }
+
+            it "should clear rails cache that matched namespace" do
+              Rails.cache.should_receive(:clear)
+              silence_warnings do
+                cache.expire!
+              end
+            end
+          end
+        end
+
+        describe "#delete_static_files!" do
+          context "valid cache directory" do
+            before { cache.should_receive(:cache_dir_valid?).and_return(true) }
+
+            it "should call #delete_page_cache_directory! and #delete_page_cache_index_file!" do
+              cache.should_receive(:delete_page_cache_directory!)
+              cache.should_receive(:delete_page_cache_index_file!)
+              cache.expire!
+            end
+
+            it "should remove page cache directory" do
+              File.exists?(refinery_cache_path).should be_true
+              cache.expire!
+              File.exists?(refinery_cache_path).should be_false
+            end
+
+            it "should remove home page cache file" do
+              File.exists?(refinery_cache_file).should be_true
+              cache.expire!
+              File.exists?(refinery_cache_file).should be_false
+            end
+
+          end
+
+          context "invalid cache directory" do
+            let(:cache) { Caching.new() }
+            before { cache.should_receive(:cache_dir_valid?).and_return(false) }
+
+            it "should not call #delete_page_cache_directory! and #delete_page_cache_index_file!" do
+              cache.should_not_receive(:delete_page_cache_directory!)
+              cache.should_not_receive(:delete_page_cache_index_file!)
+              cache.expire!
+            end
+          end
+        end
+      end
+
+    end
+  end
+end