reek 1.2.6 → 1.2.8

data/spec/reek/smells/uncommunicative_name_spec.rb

@@ -1,146 +0,0 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
-
-require 'reek/method_context'
-require 'reek/smells/uncommunicative_name'
-
-include Reek
-include Reek::Smells
-
-describe UncommunicativeName, "method name" do
-  it 'should not report one-word method name' do
-    'def help(fred) basics(17) end'.should_not reek
-  end
-  it 'should report one-letter method name' do
-    'def x(fred) basics(17) end'.should reek_only_of(:UncommunicativeName, /x/)
-  end
-  it 'should report name of the form "x2"' do
-    'def x2(fred) basics(17) end'.should reek_only_of(:UncommunicativeName, /x2/)
-  end
-  it 'should report long name ending in a number' do
-    'def method2(fred) basics(17) end'.should reek_only_of(:UncommunicativeName, /method2/)
-  end
-end
-
-describe UncommunicativeName, "field name" do
-  it 'should not report one-word field name' do
-    'class Thing; def help(fred) @simple end end'.should_not reek
-  end
-  it 'should report one-letter fieldname' do
-    'class Thing; def simple(fred) @x end end'.should reek_only_of(:UncommunicativeName, /@x/, /Thing/, /variable name/)
-  end
-  it 'should report name of the form "x2"' do
-    'class Thing; def simple(fred) @x2 end end'.should reek_only_of(:UncommunicativeName, /@x2/, /Thing/, /variable name/)
-  end
-  it 'should report long name ending in a number' do
-    'class Thing; def simple(fred) @field12 end end'.should reek_only_of(:UncommunicativeName, /@field12/, /Thing/, /variable name/)
-  end
-  it 'should report one-letter fieldname in assignment' do
-    'class Thing; def simple(fred) @x = fred end end'.should reek_only_of(:UncommunicativeName, /@x/, /Thing/, /variable name/)
-  end
-end
-
-describe UncommunicativeName, "local variable name" do
-  it 'should not report one-word variable name' do
-    'def help(fred) simple = jim(45) end'.should_not reek
-  end
-  it 'should report one-letter variable name' do
-    'def simple(fred) x = jim(45) end'.should reek_only_of(:UncommunicativeName, /x/, /variable name/)
-  end
-  it 'should report name of the form "x2"' do
-    'def simple(fred) x2 = jim(45) end'.should reek_only_of(:UncommunicativeName, /x2/, /variable name/)
-  end
-  it 'should report long name ending in a number' do
-    'def simple(fred) var123 = jim(45) end'.should reek_only_of(:UncommunicativeName, /var123/, /variable name/)
-  end
-  it 'should report variable name only once' do
-    'def simple(fred) x = jim(45); x = y end'.should reek_only_of(:UncommunicativeName, /x/)
-  end
-
-  it 'should report a bad name inside a block' do
-    src = 'def clean(text) text.each { q2 = 3 } end'
-    src.should reek_of(:UncommunicativeName, /q2/)
-  end
-end
-
-describe UncommunicativeName, "parameter name" do
-  it 'should not recognise *' do
-    'def help(xray, *) basics(17) end'.should_not reek
-  end
-  it "should report parameter's name" do
-    'def help(x) basics(17) end'.should reek_only_of(:UncommunicativeName, /x/, /variable name/)
-  end
-  it 'should report name of the form "x2"' do
-    'def help(x2) basics(17) end'.should reek_only_of(:UncommunicativeName, /x2/, /variable name/)
-  end
-  it 'should report long name ending in a number' do
-    'def help(param1) basics(17) end'.should reek_only_of(:UncommunicativeName, /param1/, /variable name/)
-  end
-end
-
-describe UncommunicativeName, "block parameter name" do
-  it "should report parameter's name" do
-    'def help() @stuff.each {|x|} end'.should reek_only_of(:UncommunicativeName, /x/, /block/, /variable name/)
-  end
-
-  it "should report method name via if context" do
-    src = <<EOS
-def bad
-  unless @mod then
-    @sig.each { |x| x.to_s }
-  end
-end
-EOS
-
-    src.should reek_only_of(:UncommunicativeName, /'x'/)
-  end
-end
-
-describe UncommunicativeName, "several names" do
-
-  it 'should report all bad names' do
-    ruby = 'class Oof; def y(x) @z = x end end'.sniff
-    ruby.should reek_of(:UncommunicativeName, /'x'/)
-    ruby.should reek_of(:UncommunicativeName, /'y'/)
-    ruby.should reek_of(:UncommunicativeName, /'@z'/)
-  end
-
-  it 'should report all bad block parameters' do
-    source =<<EOS
-class Thing
-  def bad(fred)
-    @fred.each {|x| 4 - x }
-    @jim.each {|y| y - 4 }
-  end
-end
-EOS
-
-    source.should reek_of(:UncommunicativeName, /'x'/)
-    source.should reek_of(:UncommunicativeName, /'y'/)
-  end
-end
-
-describe UncommunicativeName do
-  before :each do
-    @detector = UncommunicativeName.new
-  end
-
-  context '#examine' do
-    it 'should return true when reporting a smell' do
-      mc = MethodContext.new(StopContext.new, s(:defn, :x, s(:args)))
-      @detector.examine(mc).should == true
-    end
-
-    it 'should return false when not reporting a smell' do
-      mc = MethodContext.new(StopContext.new, s(:defn, :not_bad, s(:args)))
-      @detector.examine(mc).should == false
-    end
-  end
-
-  context 'accepting names' do
-    it 'accepts Inline::C' do
-      ctx = mock('context')
-      ctx.should_receive(:full_name).and_return('Inline::C')
-      @detector.accept?(ctx).should == true
-    end
-  end
-end

data/spec/reek/sniffer_spec.rb

@@ -1,11 +0,0 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
-
-include Reek
-
-describe Sniffer do
-  it 'detects smells in a file' do
-    dirty_file = Dir['spec/samples/two_smelly_files/*.rb'][0]
-    File.new(dirty_file).sniff.should be_smelly
-  end
-
-end

data/spec/reek/stop_context_spec.rb

@@ -1,33 +0,0 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
-
-require 'reek/stop_context'
-
-include Reek
-include Reek::Smells
-
-describe StopContext do
-  before :each do
-    @stop = StopContext.new
-  end
-
-  context 'with a module that is not loaded' do
-    it 'does not find the module' do
-      @stop.find_module('Nobbles').should == nil
-    end
-    it 'does not find an unqualified class in the module' do
-      @stop.find_module('HtmlExtension').should == nil
-    end
-  end
-
-  context 'with a module that is loaded' do
-    it 'finds the module' do
-      @stop.find_module('Reek').name.should == 'Reek'
-    end
-  end
-
-  context 'full_name' do
-    it "reports full context" do
-      @stop.full_name.should == ''
-    end
-  end
-end

data/spec/reek/tree_dresser_spec.rb

@@ -1,20 +0,0 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
-
-require 'reek/tree_dresser'
-
-include Reek
-
-describe TreeDresser do
-  before(:each) do
-    @dresser = TreeDresser.new
-  end
-
-  it 'maps :if to IfNode' do
-    @dresser.extensions_for(:if).should == 'IfNode'
-  end
-
-  it 'maps :call to CallNode' do
-    @dresser.extensions_for(:call).should == 'CallNode'
-  end
-end
-