reek 1.2.6 → 1.2.8

data/spec/samples/demo/demo.rb

@@ -0,0 +1,8 @@
+class Dirty
+  # This method smells of :reek:NestedIterators but ignores them
+  def awful(x, y, offset = 0, log = false)
+    puts @screen.title
+    @screen = widgets.map {|w| w.each {|key| key += 3}}
+    puts @screen.contents
+  end
+end

data/spec/samples/empty_config_file/dirty.rb

@@ -1,7 +1,8 @@
+# smelly class for testing purposes
 class Dirty
   def a
     puts @s.title
-    @s.map {|x| x.each {|key| key += 3}}
+    @s = fred.map {|x| x.each {|key| key += 3}}
     puts @s.title
   end
 end

data/spec/samples/exceptions.reek

@@ -1,4 +1,4 @@
 ---
-UncommunicativeName:
+UncommunicativeVariableName:
   accept:
   - md5

data/spec/samples/inline_config/dirty.rb

@@ -0,0 +1,16 @@
+# :reek:Duplication: { allow_calls: [ puts ] }
+# smells of :reek:NestedIterators but ignores them
+class Dirty
+  def a
+    puts @s.title
+    @s = fred.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+
+  # :reek:Duplication: { max_calls: 2 }
+  def b
+    puts @s.title
+    @s = fred.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/inline_config/masked.reek

@@ -0,0 +1,7 @@
+---
+IrresponsibleModule:
+  enabled: false
+UncommunicativeVariableName:
+  enabled: false
+UncommunicativeMethodName:
+  enabled: false

data/spec/samples/mask_some/dirty.rb

@@ -0,0 +1,8 @@
+# smelly class for testing purposes
+class Dirty
+  def a
+    puts @s.title
+    @s = fred.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/mask_some/some.reek

@@ -0,0 +1,8 @@
+---
+Duplication:
+  allow_calls:
+    - puts\(@s.title\)
+UncommunicativeVariableName:
+  enabled: false
+UncommunicativeMethodName:
+  enabled: false

data/spec/samples/masked/dirty.rb

@@ -1,7 +1,8 @@
+# smelly class for testing purposes
 class Dirty
   def a
     puts @s.title
-    @s.map {|x| x.each {|key| key += 3}}
+    @s = fred.map {|x| x.each {|key| key += 3}}
     puts @s.title
   end
 end

data/spec/samples/masked/masked.reek

@@ -1,3 +1,5 @@
 ---
-UncommunicativeName:
+UncommunicativeVariableName:
+  enabled: false
+UncommunicativeMethodName:
   enabled: false

data/spec/samples/mixed_results/clean_one.rb

@@ -1,3 +1,4 @@
+# clean class for testing purposes
 class Clean
   def assign
     puts @sub.title

data/spec/samples/mixed_results/clean_three.rb

@@ -1,3 +1,4 @@
+# clean class for testing purposes
 class Clean
   def assign
     puts @sub.title

data/spec/samples/mixed_results/clean_two.rb

@@ -1,3 +1,4 @@
+# clean class for testing purposes
 class Clean
   def assign
     puts @sub.title

data/spec/samples/mixed_results/dirty_one.rb

@@ -1,3 +1,4 @@
+# smelly class for testing purposes
 class Dirty
   def a
     puts @s.title

data/spec/samples/mixed_results/dirty_two.rb

@@ -1,3 +1,4 @@
+# smelly class for testing purposes
 class Dirty
   def a
     puts @s.title

data/spec/samples/not_quite_masked/dirty.rb

@@ -1,9 +1,10 @@
+# smelly class for testing purposes
 class Dirty
   attr_reader :property
 
   def a
     puts @s.title
-    @s.map {|x| x.each {|key| key += 3}}
+    @s = fred.map {|x| x.each {|key| key += 3}}
     puts @s.title
   end
 end

data/spec/samples/not_quite_masked/masked.reek

@@ -1,5 +1,5 @@
 ---
-UncommunicativeName:
+UncommunicativeVariableName:
   accept:
     - x
 

data/spec/samples/overrides/masked/dirty.rb

@@ -1,7 +1,8 @@
+# smelly class for testing purposes
 class Dirty
   def a
     puts @s.title
-    @s.map {|x| x.each {|key| key += 3}}
+    @s = fred.map {|x| x.each {|key| key += 3}}
     puts @s.title
   end
 end

data/spec/samples/overrides/masked/lower.reek

@@ -1,5 +1,7 @@
 ---
 Duplication:
   enabled: true
-UncommunicativeName:
+UncommunicativeVariableName:
+  enabled: false
+UncommunicativeMethodName:
   enabled: false

data/spec/samples/three_clean_files/clean_one.rb

@@ -1,3 +1,4 @@
+# clean class for testing purposes
 class Clean
   def assign
     puts @sub.title

data/spec/samples/three_clean_files/clean_three.rb

@@ -1,3 +1,4 @@
+# clean class for testing purposes
 class Clean
   def assign
     puts @sub.title

data/spec/samples/three_clean_files/clean_two.rb

@@ -1,3 +1,4 @@
+# clean class for testing purposes
 class Clean
   def assign
     puts @sub.title

data/spec/samples/two_smelly_files/dirty_one.rb

@@ -1,7 +1,8 @@
+# smelly class for testing purposes
 class Dirty
   def a
     puts @s.title
-    @s.map {|x| x.each {|key| key += 3}}
+    @s = puts.map {|x| x.each {|key| key += 3}}
     puts @s.title
   end
 end

data/spec/samples/two_smelly_files/dirty_two.rb

@@ -1,7 +1,8 @@
+# smelly class for testing purposes
 class Dirty
   def a
     puts @s.title
-    @s.map {|x| x.each {|key| key += 3}}
+    @s = p.map {|x| x.each {|key| key += 3}}
     puts @s.title
   end
 end

data/spec/spec_helper.rb

@@ -1,4 +1,3 @@
-$:.unshift File.dirname(__FILE__) + '/../lib'
 
 require 'rubygems'
 begin
@@ -10,6 +9,15 @@ end
 
 require 'spec/autorun'
 
-require 'reek/adapters/spec'
+require File.join((File.dirname(File.dirname(File.expand_path(__FILE__)))), 'lib', 'reek', 'spec')
+require File.join((File.dirname(File.dirname(File.expand_path(__FILE__)))), 'lib', 'reek', 'source', 'tree_dresser')
+
+require File.join(File.dirname(File.expand_path(__FILE__)), 'matchers', 'smell_of_matcher')
 
 SAMPLES_DIR = 'spec/samples' unless Object.const_defined?('SAMPLES_DIR')
+
+def ast(*args)
+  result = Reek::Source::TreeDresser.new.dress(s(*args))
+  result.line = 1
+  result
+end

data/tasks/reek.rake

@@ -1,7 +1,7 @@
 begin
-  require 'reek/adapters/rake_task'
+  require 'reek/rake/task'
 
-  Reek::RakeTask.new do |t|
+  Reek::Rake::Task.new do |t|
     t.fail_on_error = true
     t.verbose = false
     t.reek_opts = '--quiet'

data/tasks/test.rake

@@ -14,6 +14,13 @@ namespace 'test' do
     t.rcov = false
   end
 
+  desc 'Tests various release attributes of the gem'
+  Spec::Rake::SpecTask.new('gem') do |t|
+    t.spec_files = FileList['spec/gem/**/*_spec.rb']
+    t.rcov = false
+  end
+
+  desc 'Tests code quality'
   Spec::Rake::SpecTask.new('quality') do |t|
     t.spec_files = FileList['quality/**/*_spec.rb']
     t.spec_opts = ['--color']
@@ -37,14 +44,16 @@ namespace 'test' do
     t.cucumber_opts = "features --format progress --color"
   end
 
-  desc 'Runs all unit tests, acceptance tests and quality checks'
+  desc 'Runs all unit tests and acceptance tests'
   task 'all' => ['test:spec', 'test:features', 'test:multiruby']
+
+  task 'release' => ['test:gem', 'test:all']
 end
 
 task 'clobber_rcov' => 'test:clobber_rcov'
 
-desc 'synonym for test:spec'
+desc 'Synonym for test:spec'
 task 'spec' => 'test:spec'
 
-desc 'synonym for test:all'
+desc 'Synonym for test:all'
 task 'test' => 'test:all'

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: reek
 version: !ruby/object:Gem::Version 
-  version: 1.2.6
+  prerelease: false
+  segments: 
+  - 1
+  - 2
+  - 8
+  version: 1.2.8
 platform: ruby
 authors: 
 - Kevin Rutherford
@@ -9,39 +14,48 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-28 00:00:00 +00:00
+date: 2010-04-26 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: ruby_parser
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        segments: 
+        - 2
+        - 0
         version: "2.0"
-    version: 
+  type: :runtime
+  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: ruby2ruby
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        segments: 
+        - 1
+        - 2
         version: "1.2"
-    version: 
+  type: :runtime
+  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: sexp_processor
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        segments: 
+        - 3
+        - 0
         version: "3.0"
-    version: 
+  type: :runtime
+  version_requirements: *id003
 description: |
   Reek is a tool that examines Ruby classes, modules and methods
   and reports any code smells it finds.
@@ -55,55 +69,54 @@ extensions: []
 extra_rdoc_files: 
 - History.txt
 - License.txt
-- README.rdoc
 files: 
+- .yardopts
 - History.txt
 - License.txt
-- README.rdoc
+- README.md
 - Rakefile
 - bin/reek
 - config/defaults.reek
+- features/api.feature
 - features/masking_smells.feature
 - features/options.feature
-- features/profile.feature
 - features/rake_task.feature
 - features/reports.feature
 - features/samples.feature
 - features/stdin.feature
 - features/step_definitions/reek_steps.rb
 - features/support/env.rb
+- features/yaml.feature
 - lib/reek.rb
-- lib/reek/adapters/application.rb
-- lib/reek/adapters/command_line.rb
-- lib/reek/adapters/config_file.rb
-- lib/reek/adapters/core_extras.rb
-- lib/reek/adapters/rake_task.rb
-- lib/reek/adapters/report.rb
-- lib/reek/adapters/source.rb
-- lib/reek/adapters/spec.rb
-- lib/reek/block_context.rb
-- lib/reek/class_context.rb
-- lib/reek/code_context.rb
-- lib/reek/code_parser.rb
-- lib/reek/configuration.rb
-- lib/reek/detector_stack.rb
-- lib/reek/help_command.rb
-- lib/reek/if_context.rb
-- lib/reek/masking_collection.rb
-- lib/reek/method_context.rb
-- lib/reek/module_context.rb
-- lib/reek/name.rb
-- lib/reek/object_refs.rb
-- lib/reek/reek_command.rb
-- lib/reek/sexp_formatter.rb
-- lib/reek/singleton_method_context.rb
+- lib/reek/cli/application.rb
+- lib/reek/cli/command_line.rb
+- lib/reek/cli/help_command.rb
+- lib/reek/cli/reek_command.rb
+- lib/reek/cli/report.rb
+- lib/reek/cli/version_command.rb
+- lib/reek/cli/yaml_command.rb
+- lib/reek/core/code_context.rb
+- lib/reek/core/code_parser.rb
+- lib/reek/core/method_context.rb
+- lib/reek/core/module_context.rb
+- lib/reek/core/object_refs.rb
+- lib/reek/core/singleton_method_context.rb
+- lib/reek/core/smell_configuration.rb
+- lib/reek/core/sniffer.rb
+- lib/reek/core/stop_context.rb
+- lib/reek/core/warning_collector.rb
+- lib/reek/examiner.rb
+- lib/reek/rake/task.rb
 - lib/reek/smell_warning.rb
+- lib/reek/smells.rb
 - lib/reek/smells/attribute.rb
+- lib/reek/smells/boolean_parameter.rb
 - lib/reek/smells/class_variable.rb
 - lib/reek/smells/control_couple.rb
 - lib/reek/smells/data_clump.rb
 - lib/reek/smells/duplication.rb
 - lib/reek/smells/feature_envy.rb
+- lib/reek/smells/irresponsible_module.rb
 - lib/reek/smells/large_class.rb
 - lib/reek/smells/long_method.rb
 - lib/reek/smells/long_parameter_list.rb
@@ -111,55 +124,73 @@ files:
 - lib/reek/smells/nested_iterators.rb
 - lib/reek/smells/simulated_polymorphism.rb
 - lib/reek/smells/smell_detector.rb
-- lib/reek/smells/uncommunicative_name.rb
+- lib/reek/smells/uncommunicative_method_name.rb
+- lib/reek/smells/uncommunicative_module_name.rb
+- lib/reek/smells/uncommunicative_parameter_name.rb
+- lib/reek/smells/uncommunicative_variable_name.rb
 - lib/reek/smells/utility_function.rb
-- lib/reek/sniffer.rb
-- lib/reek/stop_context.rb
-- lib/reek/tree_dresser.rb
-- lib/reek/version_command.rb
-- lib/reek/yield_call_context.rb
+- lib/reek/source.rb
+- lib/reek/source/code_comment.rb
+- lib/reek/source/config_file.rb
+- lib/reek/source/core_extras.rb
+- lib/reek/source/reference_collector.rb
+- lib/reek/source/sexp_formatter.rb
+- lib/reek/source/source_code.rb
+- lib/reek/source/source_file.rb
+- lib/reek/source/source_locator.rb
+- lib/reek/source/tree_dresser.rb
+- lib/reek/spec.rb
+- lib/reek/spec/should_reek.rb
+- lib/reek/spec/should_reek_of.rb
+- lib/reek/spec/should_reek_only_of.rb
 - reek.gemspec
-- spec/reek/adapters/report_spec.rb
-- spec/reek/adapters/should_reek_of_spec.rb
-- spec/reek/adapters/should_reek_only_of_spec.rb
-- spec/reek/adapters/should_reek_spec.rb
-- spec/reek/adapters/source_spec.rb
-- spec/reek/block_context_spec.rb
-- spec/reek/class_context_spec.rb
-- spec/reek/code_context_spec.rb
-- spec/reek/code_parser_spec.rb
-- spec/reek/config_spec.rb
-- spec/reek/configuration_spec.rb
-- spec/reek/help_command_spec.rb
-- spec/reek/if_context_spec.rb
-- spec/reek/masking_collection_spec.rb
-- spec/reek/method_context_spec.rb
-- spec/reek/module_context_spec.rb
-- spec/reek/name_spec.rb
-- spec/reek/object_refs_spec.rb
-- spec/reek/object_source_spec.rb
-- spec/reek/reek_command_spec.rb
-- spec/reek/singleton_method_context_spec.rb
+- spec/matchers/smell_of_matcher.rb
+- spec/reek/cli/help_command_spec.rb
+- spec/reek/cli/reek_command_spec.rb
+- spec/reek/cli/report_spec.rb
+- spec/reek/cli/version_command_spec.rb
+- spec/reek/cli/yaml_command_spec.rb
+- spec/reek/core/code_context_spec.rb
+- spec/reek/core/code_parser_spec.rb
+- spec/reek/core/config_spec.rb
+- spec/reek/core/method_context_spec.rb
+- spec/reek/core/module_context_spec.rb
+- spec/reek/core/object_refs_spec.rb
+- spec/reek/core/singleton_method_context_spec.rb
+- spec/reek/core/smell_configuration_spec.rb
+- spec/reek/core/stop_context_spec.rb
+- spec/reek/core/warning_collector_spec.rb
+- spec/reek/examiner_spec.rb
 - spec/reek/smell_warning_spec.rb
 - spec/reek/smells/attribute_spec.rb
 - spec/reek/smells/behaves_like_variable_detector.rb
+- spec/reek/smells/boolean_parameter_spec.rb
 - spec/reek/smells/class_variable_spec.rb
 - spec/reek/smells/control_couple_spec.rb
 - spec/reek/smells/data_clump_spec.rb
 - spec/reek/smells/duplication_spec.rb
 - spec/reek/smells/feature_envy_spec.rb
+- spec/reek/smells/irresponsible_module_spec.rb
 - spec/reek/smells/large_class_spec.rb
 - spec/reek/smells/long_method_spec.rb
 - spec/reek/smells/long_parameter_list_spec.rb
+- spec/reek/smells/long_yield_list_spec.rb
 - spec/reek/smells/nested_iterators_spec.rb
 - spec/reek/smells/simulated_polymorphism_spec.rb
-- spec/reek/smells/smell_detector_spec.rb
-- spec/reek/smells/uncommunicative_name_spec.rb
+- spec/reek/smells/smell_detector_shared.rb
+- spec/reek/smells/uncommunicative_method_name_spec.rb
+- spec/reek/smells/uncommunicative_module_name_spec.rb
+- spec/reek/smells/uncommunicative_parameter_name_spec.rb
+- spec/reek/smells/uncommunicative_variable_name_spec.rb
 - spec/reek/smells/utility_function_spec.rb
-- spec/reek/sniffer_spec.rb
-- spec/reek/stop_context_spec.rb
-- spec/reek/tree_dresser_spec.rb
-- spec/reek/version_command_spec.rb
+- spec/reek/source/code_comment_spec.rb
+- spec/reek/source/object_source_spec.rb
+- spec/reek/source/reference_collector_spec.rb
+- spec/reek/source/source_code_spec.rb
+- spec/reek/source/tree_dresser_spec.rb
+- spec/reek/spec/should_reek_of_spec.rb
+- spec/reek/spec/should_reek_only_of_spec.rb
+- spec/reek/spec/should_reek_spec.rb
 - spec/samples/all_but_one_masked/clean_one.rb
 - spec/samples/all_but_one_masked/dirty.rb
 - spec/samples/all_but_one_masked/masked.reek
@@ -169,12 +200,19 @@ files:
 - spec/samples/clean_due_to_masking/dirty_one.rb
 - spec/samples/clean_due_to_masking/dirty_two.rb
 - spec/samples/clean_due_to_masking/masked.reek
+- spec/samples/config/allow_duplication.reek
+- spec/samples/config/deeper_nested_iterators.reek
 - spec/samples/corrupt_config_file/corrupt.reek
 - spec/samples/corrupt_config_file/dirty.rb
+- spec/samples/demo/demo.rb
 - spec/samples/empty_config_file/dirty.rb
 - spec/samples/empty_config_file/empty.reek
 - spec/samples/exceptions.reek
+- spec/samples/inline_config/dirty.rb
+- spec/samples/inline_config/masked.reek
 - spec/samples/inline.rb
+- spec/samples/mask_some/dirty.rb
+- spec/samples/mask_some/some.reek
 - spec/samples/masked/dirty.rb
 - spec/samples/masked/masked.reek
 - spec/samples/mixed_results/clean_one.rb
@@ -204,29 +242,33 @@ licenses: []
 
 post_install_message: |
   
-  For more information on reek, see http://wiki.github.com/kevinrutherford/reek
+  Thank you for downloading Reek. For info:
+    - see the reek wiki http://wiki.github.com/kevinrutherford/reek
+    - follow @rubyreek on twitter
 
 rdoc_options: 
 - --main
-- README.rdoc
+- README.md
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: reek
-rubygems_version: 1.3.5
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: Code smell detector for Ruby