reek 1.2.6 → 1.2.8

data/spec/reek/smells/irresponsible_module_spec.rb

@@ -0,0 +1,58 @@
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'irresponsible_module')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+
+include Reek::Smells
+
+describe IrresponsibleModule do
+  before(:each) do
+    @bad_module_name = 'WrongUn'
+    @detector = IrresponsibleModule.new('yoof')
+  end
+
+  it_should_behave_like 'SmellDetector'
+
+  it "does not report a class having a comment" do
+    src = <<EOS
+# test class
+class Responsible; end
+EOS
+    ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+    @detector.examine_context(ctx).should be_empty
+  end
+  it "reports a class without a comment" do
+    src = "class #{@bad_module_name}; end"
+    ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+    smells = @detector.examine_context(ctx)
+    smells.length.should == 1
+    smells[0].smell_class.should == IrresponsibleModule::SMELL_CLASS
+    smells[0].subclass.should == IrresponsibleModule::SMELL_SUBCLASS
+    smells[0].lines.should == [1]
+    smells[0].smell[IrresponsibleModule::MODULE_NAME_KEY].should == @bad_module_name
+  end
+  it "reports a class with an empty comment" do
+    src = <<EOS
+#
+#
+#  
+class #{@bad_module_name}; end
+EOS
+    ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+    smells = @detector.examine_context(ctx)
+    smells.length.should == 1
+    smells[0].smell_class.should == IrresponsibleModule::SMELL_CLASS
+    smells[0].subclass.should == IrresponsibleModule::SMELL_SUBCLASS
+    smells[0].lines.should == [4]
+    smells[0].smell[IrresponsibleModule::MODULE_NAME_KEY].should == @bad_module_name
+  end
+  it 'reports a fq module name correctly' do
+    src = 'class Foo::Bar; end'
+    ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+    smells = @detector.examine_context(ctx)
+    smells.length.should == 1
+    smells[0].smell_class.should == IrresponsibleModule::SMELL_CLASS
+    smells[0].subclass.should == IrresponsibleModule::SMELL_SUBCLASS
+    smells[0].smell[IrresponsibleModule::MODULE_NAME_KEY].should == 'Foo::Bar'
+    smells[0].context.should match(/#{smells[0].smell[IrresponsibleModule::MODULE_NAME_KEY]}/)
+  end
+end

data/spec/reek/smells/large_class_spec.rb

@@ -1,78 +1,43 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
-
-require 'reek/class_context'
-require 'reek/stop_context'
-require 'reek/code_parser'
-require 'reek/smells/large_class'
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'large_class')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'examiner')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'code_parser')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
 
 include Reek
 include Reek::Smells
 
-describe LargeClass, 'when exceptions are listed' do
+describe LargeClass do
   before(:each) do
-    @class_name = 'Humungous'
-    src = <<EOS
-class #{@class_name}
-  def me01x()3 end;def me02x()3 end;def me03x()3 end;def me04x()3 end;def me05x()3 end
-  def me11x()3 end;def me12x()3 end;def me13x()3 end;def me14x()3 end;def me15x()3 end
-  def me21x()3 end;def me22x()3 end;def me23x()3 end;def me24x()3 end;def me25x()3 end
-  def me31x()3 end;def me32x()3 end;def me33x()3 end;def me34x()3 end;def me35x()3 end
-  def me41x()3 end;def me42x()3 end;def me43x()3 end;def me44x()3 end;def me45x()3 end
-  def me51x()3 end
-end
-EOS
-    @ctx = ClassContext.from_s(src)
-    @config = LargeClass.default_config
-  end
-
-  it 'should ignore first excepted name' do
-    @config[LargeClass::EXCLUDE_KEY] = [@class_name]
-    lc = LargeClass.new(@config)
-    lc.examine(@ctx).should == false
-  end
-
-  it 'should ignore second excepted name' do
-    @config[LargeClass::EXCLUDE_KEY] = ['Oversized', @class_name]
-    lc = LargeClass.new(@config)
-    lc.examine(@ctx).should == false
+    @source_name = 'elephant'
+    @detector = LargeClass.new(@source_name)
   end
 
-  it 'should report non-excepted name' do
-    @config[LargeClass::EXCLUDE_KEY] = ['SmellMe']
-    lc = LargeClass.new(@config)
-    lc.examine(@ctx).should == true
-  end
-end
-
-describe LargeClass, 'checking source code' do
+  it_should_behave_like 'SmellDetector'
 
   context 'counting instance variables' do
-    it 'should not report empty class' do
-      ClassContext.from_s('class Empty;end').should have(0).variable_names
-    end
-
-    it 'should count ivars in one method' do
-      ClassContext.from_s('class Empty;def ivars() @aa=@ab=@ac=@ad; end;end').should have(4).variable_names
+    it 'should not report 9 ivars' do
+      '# clean class for testing purposes
+class Empty;def ivars() @aa=@ab=@ac=@ad=@ae=@af=@ag=@ah=@ai=4; end;end'.should_not reek
     end
 
-    it 'should count ivars in 2 methods' do
-      ClassContext.from_s('class Empty;def iv1() @aa=@ab; end;def iv2() @aa=@ac; end;end').should have(3).variable_names
-    end
-
-    it 'should not report 9 ivars' do
-      'class Empty;def ivars() @aa=@ab=@ac=@ad=@ae=@af=@ag=@ah=@ai; end;end'.should_not reek
+    it 'counts each ivar only once' do
+      '# clean class for testing purposes
+class Empty;def ivars() @aa=@ab=@ac=@ad=@ae=@af=@ag=@ah=@ai=4;@aa=3; end;end'.should_not reek
     end
 
     it 'should report 10 ivars' do
-      'class Empty;def ivars() @aa=@ab=@ac=@ad=@ae=@af=@ag=@ah=@ai=@aj; end;end'.should reek_of(:LargeClass)
+      '# smelly class for testing purposes
+class Empty;def ivars() @aa=@ab=@ac=@ad=@ae=@af=@ag=@ah=@ai=@aj=4; end;end'.should reek_only_of(:LargeClass)
     end
 
     it 'should not report 10 ivars in 2 extensions' do
       src = <<EOS
+# clean class for testing purposes
 class Full;def ivars_a() @aa=@ab=@ac=@ad=@ae; end;end
+# clean class for testing purposes
 class Full;def ivars_b() @af=@ag=@ah=@ai=@aj; end;end
 EOS
-
       src.should_not reek
     end
   end
@@ -81,6 +46,7 @@ EOS
 
     it 'should not report 25 methods' do
       src = <<EOS
+# smelly class for testing purposes
 class Full
   def me01x()3 end;def me02x()3 end;def me03x()3 end;def me04x()3 end;def me05x()3 end
   def me11x()3 end;def me12x()3 end;def me13x()3 end;def me14x()3 end;def me15x()3 end
@@ -89,7 +55,8 @@ class Full
   def me41x()3 end;def me42x()3 end;def me43x()3 end;def me44x()3 end;def me45x()3 end
 end
 EOS
-      src.should_not reek
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      @detector.examine_context(ctx).should be_empty
     end
 
     it 'should report 26 methods' do
@@ -103,7 +70,11 @@ class Full
   def me51x()3 end
 end
 EOS
-      src.should reek_of(:LargeClass)
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      smells = @detector.examine_context(ctx)
+      smells.length.should == 1
+      smells[0].subclass.should == LargeClass::SUBCLASS_TOO_MANY_METHODS
+      smells[0].smell[LargeClass::METHOD_COUNT_KEY].should == 26
     end
   end
 
@@ -119,7 +90,46 @@ class Full
   def me51x()3 end
 end
 EOS
-      src.should_not reek_of(:LargeClass)
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      @detector.examine_context(ctx).should be_empty
     end
   end
+
+  it 'reports correctly when the class has many methods' do
+    src = <<EOS
+class Full
+  def me01x()3 end;def me02x()3 end;def me03x()3 end;def me04x()3 end;def me05x()3 end
+  def me11x()3 end;def me12x()3 end;def me13x()3 end;def me14x()3 end;def me15x()3 end
+  def me21x()3 end;def me22x()3 end;def me23x()3 end;def me24x()3 end;def me25x()3 end
+  def me31x()3 end;def me32x()3 end;def me33x()3 end;def me34x()3 end;def me35x()3 end
+  def me41x()3 end;def me42x()3 end;def me43x()3 end;def me44x()3 end;def me45x()3 end
+  def me51x()3 end
+end
+EOS
+    ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+    @warning = @detector.examine_context(ctx)[0]
+    @warning.source.should == @source_name
+    @warning.smell_class.should == 'LargeClass'
+    @warning.subclass.should == LargeClass::SUBCLASS_TOO_MANY_METHODS
+    @warning.smell[LargeClass::METHOD_COUNT_KEY].should == 26
+    @warning.lines.should == [1]
+  end
+
+  it 'reports correctly when the class has 30 instance variables' do
+    src = <<EOS
+# smelly class for testing purposes
+class Empty
+  def ivars
+    @aa=@ab=@ac=@ad=@ae=@af=@ag=@ah=@ai=@aj=4
+  end
+end
+EOS
+    ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+    @warning = @detector.examine_context(ctx)[0]
+    @warning.source.should == @source_name
+    @warning.smell_class.should == 'LargeClass'
+    @warning.subclass.should == LargeClass::SUBCLASS_TOO_MANY_IVARS
+    @warning.smell[LargeClass::IVAR_COUNT_KEY].should == 10
+    @warning.lines.should == [2]
+  end
 end

data/spec/reek/smells/long_method_spec.rb

@@ -1,29 +1,32 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
-
-require 'reek/code_parser'
-require 'reek/sniffer'
-require 'reek/smells/long_method'
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'long_method')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'code_parser')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'sniffer')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
 
 include Reek
 include Reek::Smells
 
 def process_method(src)
   source = src.to_reek_source
-  sniffer = Sniffer.new(source)
-  CodeParser.new(sniffer).process_defn(source.syntax_tree)
+  sniffer = Core::Sniffer.new(source)
+  Core::CodeParser.new(sniffer).process_defn(source.syntax_tree)
 end
 
 describe LongMethod do
   it 'should not report short methods' do
-    'def short(arga) alf = f(1);@bet = 2;@cut = 3;@dit = 4; @emp = 5;end'.should_not reek
+    src = 'def short(arga) alf = f(1);@bet = 2;@cut = 3;@dit = 4; @emp = 5;end'
+    src.should_not smell_of(LongMethod)
   end
 
   it 'should report long methods' do
-    'def long(arga) alf = f(1);@bet = 2;@cut = 3;@dit = 4; @emp = 5;@fry = 6;end'.should reek_only_of(:LongMethod, /6 statements/)
+    src = 'def long(arga) alf = f(1);@bet = 2;@cut = 3;@dit = 4; @emp = 5;@fry = 6;end'
+    src.should reek_only_of(:LongMethod, /6 statements/)
   end
 
   it 'should not report initialize' do
-    'def initialize(arga) alf = f(1);@bet = 2;@cut = 3;@dit = 4; @emp = 5;@fry = 6;end'.should_not reek
+    src = 'def initialize(arga) alf = f(1);@bet = 2;@cut = 3;@dit = 4; @emp = 5;@fry = 6;end'
+    src.should_not smell_of(LongMethod)
   end
 
   it 'should only report a long method once' do
@@ -194,3 +197,30 @@ EOS
     method.num_statements.should == 6
   end
 end
+
+describe LongMethod do
+  before(:each) do
+    @detector = LongMethod.new('silver')
+  end
+
+  it_should_behave_like 'SmellDetector'
+
+  context 'when the method has 30 statements' do
+    before :each do
+      @num_statements = 30
+      ctx = mock('method_context', :null_object => true)
+      ctx.should_receive(:num_statements).and_return(@num_statements)
+      ctx.should_receive(:config).and_return({})
+      @smells = @detector.examine_context(ctx)
+    end
+    it 'reports only 1 smell' do
+      @smells.length.should == 1
+    end
+    it 'reports the number of statements' do
+      @smells[0].smell[LongMethod::STATEMENT_COUNT_KEY].should == @num_statements
+    end
+    it 'reports the correct subclass' do
+      @smells[0].subclass.should == LongMethod::SUBCLASS_TOO_MANY_STATEMENTS
+    end
+  end
+end

data/spec/reek/smells/long_parameter_list_spec.rb

@@ -1,72 +1,94 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
-
-require 'reek/smells/long_parameter_list'
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'long_parameter_list')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
 
 include Reek
 include Reek::Smells
 
 describe LongParameterList do
-  
-  describe 'for methods with few parameters' do
+
+  context 'for methods with few parameters' do
     it 'should report nothing for no parameters' do
-      'def simple; f(3);true; end'.should_not reek
+      'def simple; f(3);true; end'.should_not smell_of(LongParameterList)
     end
     it 'should report nothing for 1 parameter' do
-      'def simple(yep) f(3);true end'.should_not reek
+      'def simple(yep) f(3);true end'.should_not smell_of(LongParameterList)
     end
     it 'should report nothing for 2 parameters' do
-      'def simple(yep,zero) f(3);true end'.should_not reek
+      'def simple(yep,zero) f(3);true end'.should_not smell_of(LongParameterList)
     end
     it 'should not count an optional block' do
-      'def simple(alpha, yep, zero, &opt) f(3);true end'.should_not reek
+      'def simple(alpha, yep, zero, &opt) f(3);true end'.should_not smell_of(LongParameterList)
     end
     it 'should not report inner block with too many parameters' do
-      'def simple(yep,zero); m[3]; rand(34); f.each { |arga, argb, argc, argd| true}; end'.should_not reek
+      src = 'def simple(yep,zero); m[3]; rand(34); f.each { |arga, argb, argc, argd| true}; end'
+      src.should_not smell_of(LongParameterList)
     end
 
     describe 'and default values' do
       it 'should report nothing for 1 parameter' do
-        'def simple(zero=nil) f(3);false end'.should_not reek
+        'def simple(zero=nil) f(3);false end'.should_not smell_of(LongParameterList)
       end
       it 'should report nothing for 2 parameters with 1 default' do
-        'def simple(yep, zero=nil) f(3);false end'.should_not reek
+        'def simple(yep, zero=nil) f(3);false end'.should_not smell_of(LongParameterList)
       end
       it 'should report nothing for 2 defaulted parameters' do
-        'def simple(yep=4, zero=nil) f(3);false end'.should_not reek
+        'def simple(yep=4, zero=nil) f(3);false end'.should_not smell_of(LongParameterList)
       end
     end
   end
 
   describe 'for methods with too many parameters' do
     it 'should report 4 parameters' do
-      'def simple(arga, argb, argc, argd) f(3);true end'.should reek_only_of(:LongParameterList, /4 parameters/)
+      src = 'def simple(arga, argb, argc, argd) f(3);true end'
+      src.should smell_of(LongParameterList, LongParameterList::PARAMETER_COUNT_KEY => 4)
     end
     it 'should report 8 parameters' do
-      'def simple(arga, argb, argc, argd,arge, argf, argg, argh) f(3);true end'.should reek_only_of(:LongParameterList, /8 parameters/)
+      src = 'def simple(arga, argb, argc, argd,arge, argf, argg, argh) f(3);true end'
+      src.should smell_of(LongParameterList, LongParameterList::PARAMETER_COUNT_KEY => 8)
     end
 
     describe 'and default values' do
       it 'should report 3 with 1 defaulted' do
-        'def simple(polly, queue, yep, zero=nil) f(3);false end'.should reek_only_of(:LongParameterList, /4 parameters/)
+        src = 'def simple(polly, queue, yep, zero=nil) f(3);false end'
+        src.should smell_of(LongParameterList, LongParameterList::PARAMETER_COUNT_KEY => 4)
       end
       it 'should report with 3 defaulted' do
-        'def simple(aarg, polly=2, yep=:truth, zero=nil) f(3);false end'.should reek_only_of(:LongParameterList, /4 parameters/)
+        src = 'def simple(aarg, polly=2, yep=:truth, zero=nil) f(3);false end'
+        src.should smell_of(LongParameterList, LongParameterList::PARAMETER_COUNT_KEY => 4)
       end
     end
   end
-  
-  describe 'yield' do
-    it 'should not report yield with no parameters' do
-      'def simple(arga, argb, &blk) f(3);yield; end'.should_not reek
-    end
-    it 'should not report yield with few parameters' do
-      'def simple(arga, argb, &blk) f(3);yield a,b; end'.should_not reek
+end
+
+describe LongParameterList do
+  before(:each) do
+    @source_name = 'smokin'
+    @detector = LongParameterList.new(@source_name)
+  end
+
+  it_should_behave_like 'SmellDetector'
+
+  context 'when a smell is reported' do
+    before :each do
+      src = <<EOS
+def badguy(arga, argb, argc, argd)
+  f(3)
+  true
+end
+EOS
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      @smells = @detector.examine_context(ctx)
+      @warning = @smells[0]
     end
-    it 'should report yield with many parameters' do
-      'def simple(arga, argb, &blk) f(3);yield arga,argb,arga,argb; end'.should reek_only_of(:LongYieldList, /simple/, /yields/, /4/)
+
+    it_should_behave_like 'common fields set correctly'
+
+    it 'reports the number of parameters' do
+      @warning.smell[LongParameterList::PARAMETER_COUNT_KEY].should == 4
     end
-    it 'should not report yield of a long expression' do
-      'def simple(arga, argb, &blk) f(3);yield(if @dec then argb else 5+3 end); end'.should_not reek
+    it 'reports the line number of the method' do
+      @warning.lines.should == [1]
     end
   end
 end

data/spec/reek/smells/long_yield_list_spec.rb

@@ -0,0 +1,57 @@
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'long_yield_list')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+
+include Reek
+include Reek::Smells
+
+describe LongYieldList do
+  before(:each) do
+    @source_name = 'oo la la'
+    @detector = LongYieldList.new(@source_name)
+    # SMELL: can't use the default config, because that contains an override,
+    # which causes the mocked matches?() method to be called twice!!
+  end
+
+  it_should_behave_like 'SmellDetector'
+
+  context 'yield' do
+    it 'should not report yield with no parameters' do
+      src = 'def simple(arga, argb, &blk) f(3);yield; end'
+      src.should_not smell_of(LongYieldList)
+    end
+    it 'should not report yield with few parameters' do
+      src = 'def simple(arga, argb, &blk) f(3);yield a,b; end'
+      src.should_not smell_of(LongYieldList)
+    end
+    it 'should report yield with many parameters' do
+      src = 'def simple(arga, argb, &blk) f(3);yield arga,argb,arga,argb; end'
+      src.should smell_of(LongYieldList, LongYieldList::PARAMETER_COUNT_KEY => 4)
+    end
+    it 'should not report yield of a long expression' do
+      src = 'def simple(arga, argb, &blk) f(3);yield(if @dec then argb else 5+3 end); end'
+      src.should_not smell_of(LongYieldList)
+    end
+  end
+
+  context 'when a smells is reported' do
+    before :each do
+      src = <<EOS
+def simple(arga, argb, &blk)
+  f(3)
+  yield(arga,argb,arga,argb)
+  end
+EOS
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      @smells = @detector.examine_context(ctx)
+      @warning = @smells[0]
+    end
+
+    it_should_behave_like 'common fields set correctly'
+
+    it 'reports the correct values' do
+      @warning.smell['parameter_count'].should == 4
+      @warning.lines.should == [3]
+    end
+  end
+end

data/spec/reek/smells/nested_iterators_spec.rb

@@ -1,13 +1,28 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
-
-require 'reek/smells/nested_iterators'
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'nested_iterators')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
 
 include Reek::Smells
 
 describe NestedIterators do
 
+  context 'with no iterators' do
+    it 'reports no smells' do
+      src = 'def fred() nothing = true; end'
+      src.should_not smell_of(NestedIterators)
+    end
+  end
+
+  context 'with one iterator' do
+    it 'reports no smells' do
+      src = 'def fred() nothing.each {|item| item}; end'
+      src.should_not smell_of(NestedIterators)
+    end
+  end
+
   it 'should report nested iterators in a method' do
-    'def bad(fred) @fred.each {|item| item.each {|ting| ting.ting} } end'.should reek_only_of(:NestedIterators)
+    src = 'def bad(fred) @fred.each {|item| item.each {|ting| ting.ting} } end'
+    src.should smell_of(NestedIterators)
   end
 
   it 'should not report method with successive iterators' do
@@ -17,7 +32,7 @@ def bad(fred)
   @jim.each {|ting| ting.each }
 end
 EOS
-    src.should_not reek
+    src.should_not smell_of(NestedIterators)
   end
 
   it 'should not report method with chained iterators' do
@@ -26,7 +41,7 @@ def chained
   @sig.keys.sort_by { |xray| xray.to_s }.each { |min| md5 << min.to_s }
 end
 EOS
-    src.should_not reek
+    src.should_not smell_of(NestedIterators)
   end
 
   it 'should report nested iterators only once per method' do
@@ -36,7 +51,100 @@ def bad(fred)
   @jim.each {|ting| ting.each {|piece| @hal.send} }
 end
 EOS
-    src.should reek_only_of(:NestedIterators)
+    src.should smell_of(NestedIterators, {}, {})
   end
+
+  context 'when the allowed nesting depth is 3' do
+    before :each do
+      @config = {NestedIterators::MAX_ALLOWED_NESTING_KEY => 3}
+    end
+
+    it 'should not report nested iterators 2 levels deep' do
+      src = <<EOS
+def bad(fred)
+  @fred.each {|one| one.each {|two| two.two} }
 end
+EOS
+      src.should_not smell_of(NestedIterators).with_config(@config)
+    end
+
+    it 'should not report nested iterators 3 levels deep' do
+      src = <<EOS
+def bad(fred)
+  @fred.each {|one| one.each {|two| two.each {|three| three.three} } }
+end
+EOS
+      src.should_not smell_of(NestedIterators).with_config(@config)
+    end
+
+    it 'should report nested iterators 4 levels deep' do
+      src = <<EOS
+def bad(fred)
+  @fred.each {|one| one.each {|two| two.each {|three| three.each {|four| four.four} } } }
+end
+EOS
+      src.should smell_of(NestedIterators).with_config(@config)
+    end
+  end
+
+  context 'when ignoring iterators' do
+    before :each do
+      @config = {NestedIterators::IGNORE_ITERATORS_KEY => ['ignore_me']}
+    end
 
+    it 'should not report nesting the ignored iterator inside another' do
+      src = 'def bad(fred) @fred.each {|item| item.ignore_me {|ting| ting.ting} } end'
+      src.should_not smell_of(NestedIterators).with_config(@config)
+    end
+
+    it 'should not report nesting inside the ignored iterator' do
+      src = 'def bad(fred) @fred.ignore_me {|item| item.each {|ting| ting.ting} } end'
+      src.should_not smell_of(NestedIterators).with_config(@config)
+    end
+
+    it 'should report nested iterators inside the ignored iterator' do
+      src = 'def bad(fred) @fred.ignore_me {|item| item.each {|ting| ting.each {|other| other.other} } } end'
+      src.should smell_of(NestedIterators, NestedIterators::NESTING_DEPTH_KEY => 2).with_config(@config)
+    end
+
+    it 'should report nested iterators outside the ignored iterator' do
+      src = 'def bad(fred) @fred.each {|item| item.each {|ting| ting.ignore_me {|other| other.other} } } end'
+      src.should smell_of(NestedIterators, NestedIterators::NESTING_DEPTH_KEY => 2).with_config(@config)
+    end
+
+    it 'should report nested iterators with the ignored iterator between them' do
+      src = 'def bad(fred) @fred.each {|item| item.ignore_me {|ting| ting.ting {|other| other.other} } } end'
+      src.should smell_of(NestedIterators, NestedIterators::NESTING_DEPTH_KEY => 2).with_config(@config)
+    end
+  end
+end
+
+describe NestedIterators do
+  before(:each) do
+    @source_name = 'cuckoo'
+    @detector = NestedIterators.new(@source_name)
+  end
+
+  it_should_behave_like 'SmellDetector'
+
+  context 'when a smell is reported' do
+    before :each do
+      src = <<EOS
+def fred()
+  nothing.each do |item|
+    again.each {|thing| item }
+  end
+end
+EOS
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      @warning = @detector.examine_context(ctx)[0]
+    end
+
+    it_should_behave_like 'common fields set correctly'
+
+    it 'reports correct values' do
+      @warning.smell[NestedIterators::NESTING_DEPTH_KEY].should == 2
+      @warning.lines.should == [3]
+    end
+  end
+end