reek 1.2.6 → 1.2.8

data/spec/reek/smells/simulated_polymorphism_spec.rb

@@ -1,15 +1,19 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'simulated_polymorphism')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'code_context')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
 
-require 'reek/smells/simulated_polymorphism'
-require 'reek/code_context'
-
-include Reek
+include Reek::Core
 include Reek::Smells
 
 describe SimulatedPolymorphism do
   before :each do
-    @detector = SimulatedPolymorphism.new
+    @source_name = 'howdy-doody'
+    @detector = SimulatedPolymorphism.new(@source_name)
   end
+
+  it_should_behave_like 'SmellDetector'
+
   context 'with no conditionals' do
     it 'gathers an empty hash' do
       ast = 'module Stable; end'.to_reek_source.syntax_tree
@@ -26,38 +30,70 @@ describe SimulatedPolymorphism do
     end
   end
 
+  context 'with an empty condition' do
+    it 'does not record the condition' do
+      ast = 'def fred() case; when 3; end; end'.to_reek_source.syntax_tree
+      ctx = CodeContext.new(nil, ast)
+      @detector.conditional_counts(ctx).length.should == 0
+    end
+  end
+
   context 'with three identical conditionals' do
     before :each do
-      cond = '@field == :sym'
-      @cond_expr = cond.to_reek_source.syntax_tree
+      @cond = '@field == :sym'
+      @cond_expr = @cond.to_reek_source.syntax_tree
       src = <<EOS
 class Scrunch
   def first
-    return #{cond} ? 0 : 3;
+    puts "hello" if @debug
+    return #{@cond} ? 0 : 3;
   end
   def second
-    if #{cond}
+    if #{@cond}
       @other += " quarts"
     end
   end
   def third
-    raise 'flu!' unless #{cond}
+    raise 'flu!' unless #{@cond}
   end
 end
 EOS
 
       ast = src.to_reek_source.syntax_tree
-      ctx = CodeContext.new(nil, ast)
-      @conds = @detector.conditional_counts(ctx)
+      @ctx = CodeContext.new(nil, ast)
+      @conds = @detector.conditional_counts(@ctx)
     end
-    it 'finds one matching conditional' do
-      @conds.length.should == 1
-    end
-    it 'returns the condition expr' do
-      @conds.keys[0].should == @cond_expr
+    it 'finds both conditionals' do
+      @conds.length.should == 2
     end
     it 'knows there are three copies' do
-      @conds[@cond_expr].should == 3
+      @conds[@cond_expr].length.should == 3
+    end
+
+    context 'looking at the YAML' do
+      before :each do
+        @detector.examine(@ctx)
+        warning = @detector.smells_found.to_a[0]   # SMELL: too cumbersome!
+        @yaml = warning.to_yaml
+      end
+      it 'reports the source' do
+        @yaml.should match(/source:\s*#{@source_name}/)
+      end
+      it 'reports the class' do
+        @yaml.should match(/class:\s*SimulatedPolymorphism/)
+      end
+      it 'reports the subclass' do
+        @yaml.should match(/subclass:\s*RepeatedConditional/)
+      end
+      it 'reports the expression' do
+        @yaml.should match(/expression:\s*\(#{@cond}\)/)
+      end
+      it 'reports the number of occurrences' do
+        @yaml.should match(/occurrences:\s*3/)
+      end
+      it 'reports the referring lines' do
+        @yaml.should match(/lines:\s*- 4\s*- 7\s*- 12/)
+      end
     end
   end
 
@@ -90,7 +126,7 @@ EOS
       @conds.keys[0].should == @cond_expr
     end
     it 'knows there are three copies' do
-      @conds[@cond_expr].should == 2
+      @conds[@cond_expr].length.should == 2
     end
   end
 

data/spec/reek/smells/smell_detector_shared.rb

@@ -0,0 +1,42 @@
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'smell_configuration')
+
+include Reek::Core
+
+shared_examples_for 'SmellDetector' do
+  context 'exception matching follows the context' do
+    before :each do
+      @ctx = mock('context')
+#      @ctx.should_receive(:exp).and_return(nil)
+      @ctx.should_receive(:config).and_return({})
+    end
+    it 'when false' do
+      @ctx.should_receive(:matches?).at_least(:once).and_return(false)
+      @detector.exception?(@ctx).should == false
+    end
+
+    it 'when true' do
+      @ctx.should_receive(:matches?).at_least(:once).and_return(true)
+      @detector.exception?(@ctx).should == true
+    end
+  end
+
+  context 'configuration' do
+    it 'becomes disabled when disabled' do
+      @detector.configure_with({SmellConfiguration::ENABLED_KEY => false})
+      @detector.should_not be_enabled
+    end
+  end
+end
+
+shared_examples_for 'common fields set correctly' do
+  it 'reports the source' do
+    @warning.source.should == @source_name
+  end
+  it 'reports the class' do
+    @warning.smell_class.should == @detector.class::SMELL_CLASS
+  end
+  it 'reports the subclass' do
+    @warning.subclass.should == @detector.class::SMELL_SUBCLASS
+  end
+end

data/spec/reek/smells/uncommunicative_method_name_spec.rb

@@ -0,0 +1,42 @@
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'uncommunicative_method_name')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'code_parser')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'sniffer')
+
+include Reek
+include Reek::Smells
+
+describe UncommunicativeMethodName do
+  before :each do
+    @source_name = 'wallamalloo'
+    @detector = UncommunicativeMethodName.new(@source_name)
+  end
+
+  it_should_behave_like 'SmellDetector'
+
+  ['help', '+', '-', '/', '*'].each do |method_name|
+    it "accepts the method name '#{method_name}'" do
+      "def #{method_name}(fred) basics(17) end".should_not smell_of(UncommunicativeMethodName)
+    end
+  end
+
+  ['x', 'x2', 'method2'].each do |method_name|
+    context 'with a bad name' do
+      before :each do
+        src = 'def x() end'
+        ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+        @smells = @detector.examine_context(ctx)
+        @warning = @smells[0]
+      end
+
+      it_should_behave_like 'common fields set correctly'
+
+      it 'reports the correct values' do
+        @smells[0].smell[UncommunicativeMethodName::METHOD_NAME_KEY].should == 'x'
+        @smells[0].lines.should == [1]
+        @smells[0].context.should == 'x'
+      end
+    end
+  end
+end

data/spec/reek/smells/uncommunicative_module_name_spec.rb

@@ -0,0 +1,66 @@
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'uncommunicative_module_name')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'code_parser')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'sniffer')
+
+include Reek
+include Reek::Smells
+
+describe UncommunicativeModuleName do
+  before :each do
+    @source_name = 'classy'
+    @detector = UncommunicativeModuleName.new(@source_name)
+  end
+
+  it_should_behave_like 'SmellDetector'
+
+  ['class', 'module'].each do |type|
+    it 'does not report one-word name' do
+      "#{type} Helper; end".should_not reek_of(:UncommunicativeModuleName)
+    end
+    it 'reports one-letter name' do
+      "#{type} X; end".should reek_of(:UncommunicativeModuleName, /X/)
+    end
+    it 'reports name of the form "x2"' do
+      "#{type} X2; end".should reek_of(:UncommunicativeModuleName, /X2/)
+    end
+    it 'reports long name ending in a number' do
+      "#{type} Printer2; end".should reek_of(:UncommunicativeModuleName, /Printer2/)
+    end
+    it 'reports a bad scoped name' do
+      src = "#{type} Foo::X; end"
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      smells = @detector.examine_context(ctx)
+      smells.length.should == 1
+      smells[0].smell_class.should == UncommunicativeModuleName::SMELL_CLASS
+      smells[0].subclass.should == UncommunicativeModuleName::SMELL_SUBCLASS
+      smells[0].smell[UncommunicativeModuleName::MODULE_NAME_KEY].should == 'X'
+      smells[0].context.should match(/#{smells[0].smell[UncommunicativeModuleName::MODULE_NAME_KEY]}/)
+    end
+  end
+
+  context 'accepting names' do
+    it 'accepts Inline::C' do
+      src = 'module Inline::C; end'
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      @detector.examine_context(ctx).should be_empty
+    end
+  end
+
+  context 'looking at the YAML' do
+    before :each do
+      src = 'module Printer2; end'
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      smells = @detector.examine_context(ctx)
+      @warning = smells[0]
+    end
+
+    it_should_behave_like 'common fields set correctly'
+
+    it 'reports the correct values' do
+      @warning.smell[UncommunicativeModuleName::MODULE_NAME_KEY].should == 'Printer2'
+      @warning.lines.should == [1]
+    end
+  end
+end

data/spec/reek/smells/uncommunicative_parameter_name_spec.rb

@@ -0,0 +1,71 @@
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'uncommunicative_parameter_name')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'method_context')
+
+include Reek::Core
+include Reek::Smells
+
+describe UncommunicativeParameterName do
+  before :each do
+    @source_name = 'wallamalloo'
+    @detector = UncommunicativeParameterName.new(@source_name)
+  end
+
+  it_should_behave_like 'SmellDetector'
+
+  context "parameter name" do
+    ['obj.', ''].each do |host|
+      it 'does not recognise *' do
+        "def #{host}help(xray, *) basics(17) end".should_not smell_of(UncommunicativeParameterName)
+      end
+      it "reports parameter's name" do
+        src = "def #{host}help(x) basics(17) end"
+        src.should smell_of(UncommunicativeParameterName, {UncommunicativeParameterName::PARAMETER_NAME_KEY => 'x'})
+      end
+
+      context 'with a name of the form "x2"' do
+        before :each do
+          @bad_param = 'x2'
+          src = "def #{host}help(#{@bad_param}) basics(17) end"
+          ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+          @smells = @detector.examine_context(ctx)
+        end
+        it 'reports only 1 smell' do
+          @smells.length.should == 1
+        end
+        it 'reports uncommunicative parameter name' do
+          @smells[0].subclass.should == UncommunicativeParameterName::SMELL_SUBCLASS
+        end
+        it 'reports the parameter name' do
+          @smells[0].smell[UncommunicativeParameterName::PARAMETER_NAME_KEY].should == @bad_param
+        end
+      end
+      it 'reports long name ending in a number' do
+        @bad_param = 'param2'
+        src = "def #{host}help(#{@bad_param}) basics(17) end"
+        ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+        smells = @detector.examine_context(ctx)
+        smells.length.should == 1
+        smells[0].subclass.should == UncommunicativeParameterName::SMELL_SUBCLASS
+        smells[0].smell[UncommunicativeParameterName::PARAMETER_NAME_KEY].should == @bad_param
+      end
+    end
+  end
+
+  context 'looking at the YAML' do
+    before :each do
+      src = 'def bad(good, bad2, good_again) end'
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      @smells = @detector.examine_context(ctx)
+      @warning = @smells[0]
+    end
+
+    it_should_behave_like 'common fields set correctly'
+
+    it 'reports the correct values' do
+      @warning.smell[UncommunicativeParameterName::PARAMETER_NAME_KEY].should == 'bad2'
+      @warning.lines.should == [1]
+    end
+  end
+end

data/spec/reek/smells/uncommunicative_variable_name_spec.rb

@@ -0,0 +1,120 @@
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'uncommunicative_variable_name')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'code_parser')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'sniffer')
+
+include Reek
+include Reek::Smells
+
+describe UncommunicativeVariableName do
+  before :each do
+    @source_name = 'wallamalloo'
+    @detector = UncommunicativeVariableName.new(@source_name)
+  end
+
+  it_should_behave_like 'SmellDetector'
+
+  context "field name" do
+    it 'does not report use of one-letter fieldname' do
+      src = 'class Thing; def simple(fred) @x end end'
+      src.should_not smell_of(UncommunicativeVariableName)
+    end
+    it 'reports one-letter fieldname in assignment' do
+      src = 'class Thing; def simple(fred) @x = fred end end'
+      src.should reek_of(:UncommunicativeVariableName, /@x/, /Thing/, /variable name/)
+    end
+  end
+
+  context "local variable name" do
+    it 'does not report one-word variable name' do
+      'def help(fred) simple = jim(45) end'.should_not smell_of(UncommunicativeVariableName)
+    end
+    it 'reports one-letter variable name' do
+      src = 'def simple(fred) x = jim(45) end'
+      src.should smell_of(UncommunicativeVariableName,
+        {UncommunicativeVariableName::VARIABLE_NAME_KEY => 'x'})
+    end
+    it 'reports name of the form "x2"' do
+      src = 'def simple(fred) x2 = jim(45) end'
+      src.should smell_of(UncommunicativeVariableName,
+        {UncommunicativeVariableName::VARIABLE_NAME_KEY => 'x2'})
+    end
+    it 'reports long name ending in a number' do
+      @bad_var = 'var123'
+      src = "def simple(fred) #{@bad_var} = jim(45) end"
+      src.should smell_of(UncommunicativeVariableName,
+        {UncommunicativeVariableName::VARIABLE_NAME_KEY => @bad_var})
+    end
+    it 'reports variable name only once' do
+      src = 'def simple(fred) x = jim(45); x = y end'
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      smells = @detector.examine_context(ctx)
+      smells.length.should == 1
+      smells[0].subclass.should == UncommunicativeVariableName::SMELL_SUBCLASS
+      smells[0].smell[UncommunicativeVariableName::VARIABLE_NAME_KEY].should == 'x'
+      smells[0].lines.should == [1,1]
+    end
+    it 'reports a bad name inside a block' do
+      src = 'def clean(text) text.each { q2 = 3 } end'
+      src.should smell_of(UncommunicativeVariableName,
+        {UncommunicativeVariableName::VARIABLE_NAME_KEY => 'q2'})
+    end
+    it 'reports variable name outside any method' do
+      'class Simple; x = jim(45); end'.should reek_of(:UncommunicativeVariableName, /x/)
+    end
+  end
+
+  context "block parameter name" do
+    it "reports deep block parameter" do
+      src = <<EOS
+  def bad
+    unless @mod then
+      @sig.each { |x| x.to_s }
+    end
+  end
+EOS
+      src.should smell_of(UncommunicativeVariableName,
+        {UncommunicativeVariableName::VARIABLE_NAME_KEY => 'x'})
+    end
+  end
+
+  context 'when a smell is reported' do
+    before :each do
+      src = <<EOS
+def bad
+  unless @mod then
+     x2 = xy.to_s
+     x2
+     x2 = 56
+  end
+end
+EOS
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      @smells = @detector.examine_context(ctx)
+      @warning = @smells[0]
+    end
+
+    it_should_behave_like 'common fields set correctly'
+
+    it 'reports the correct values' do
+      @warning.smell['variable_name'].should == 'x2'
+      @warning.lines.should == [3,5]
+    end
+  end
+
+  context 'when a smell is reported in a singleton method' do
+    before :each do
+      src = 'def self.bad() x2 = 4; end'
+      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      @smells = @detector.examine_context(ctx)
+      @warning = @smells[0]
+    end
+
+    it_should_behave_like 'common fields set correctly'
+
+    it 'reports the fq context' do
+      @warning.context.should == 'self.bad'
+    end
+  end
+end

data/spec/reek/smells/utility_function_spec.rb

@@ -1,14 +1,32 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
-
-require 'reek/smells/utility_function'
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'utility_function')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
 
 include Reek
 include Reek::Smells
 
 describe UtilityFunction do
+  before(:each) do
+    @source_name = 'loser'
+    @detector = UtilityFunction.new(@source_name)
+  end
+
+  it_should_behave_like 'SmellDetector'
+
+  context 'with a singleton method' do
+    ['self', 'local_call', '$global'].each do |receiver|
+      it 'ignores the receiver' do
+        src = "def #{receiver}.simple(arga) arga.to_s + arga.to_i end"
+        ctx = MethodContext.new(nil, src.to_reek_source.syntax_tree)
+        @detector.examine_context(ctx).should be_empty
+      end
+    end
+  end
   context 'with no calls' do
     it 'does not report empty method' do
-      'def simple(arga) end'.should_not reek
+      src = 'def simple(arga) end'
+      ctx = MethodContext.new(nil, src.to_reek_source.syntax_tree)
+      @detector.examine_context(ctx).should be_empty
     end
     it 'does not report literal' do
       'def simple(arga) 3; end'.should_not reek
@@ -25,6 +43,10 @@ describe UtilityFunction do
     it 'recognises an ivar reference within a block' do
       'def clean(text) text.each { @fred = 3} end'.should_not reek
     end
+    it 'copes with nil superclass' do
+      '# clean class for testing purposes
+class Object; def is_maybe?() false end end'.should_not reek
+    end
   end
 
   context 'with only one call' do
@@ -40,6 +62,9 @@ describe UtilityFunction do
     it 'reports two calls' do
       'def simple(arga) arga.to_s + arga.to_i end'.should reek_of(:UtilityFunction, /simple/)
     end
+    it 'counts a local call in a param initializer' do
+      'def simple(arga=local) arga.to_s end'.should_not reek_of(:UtilityFunction)
+    end
     it 'should count usages of self'do
       'def <=>(other) Options[:sort_order].compare(self, other) end'.should_not reek
     end
@@ -59,6 +84,7 @@ describe UtilityFunction do
 
     it 'should recognise a deep call' do
       src = <<EOS
+# clean class for testing purposes
   class Red
     def deep(text)
       text.each { |mod| atts = shelve(mod) }
@@ -72,4 +98,24 @@ EOS
       src.should_not reek
     end
   end
+
+  context 'when a smells is reported' do
+    before :each do
+      src = <<EOS
+def simple(arga)
+  arga.b.c
+end
+EOS
+      source = src.to_reek_source
+      sniffer = Sniffer.new(source)
+      mctx = CodeParser.new(sniffer).process_defn(source.syntax_tree)
+      @warning = @detector.examine_context(mctx)[0]   # SMELL: too cumbersome!
+    end
+
+    it_should_behave_like 'common fields set correctly'
+
+    it 'reports the line number of the method' do
+      @warning.lines.should == [1]
+    end
+  end
 end

data/spec/reek/source/code_comment_spec.rb

@@ -0,0 +1,82 @@
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'source', 'code_comment')
+
+include Reek::Source
+
+describe CodeComment do
+  context 'with an empty comment' do
+    before :each do
+      @comment = CodeComment.new('')
+    end
+    it 'is not descriptive' do
+      @comment.is_descriptive?.should be_false
+    end
+    it 'has an empty config' do
+      @comment.config.should be_empty
+    end
+  end
+
+  context 'comment checks' do
+    it 'rejects an empty comment' do
+      CodeComment.new('#').is_descriptive?.should be_false
+    end
+    it 'rejects a 1-word comment' do
+      CodeComment.new("# fred\n#  ").is_descriptive?.should be_false
+    end
+    it 'accepts a 2-word comment' do
+      CodeComment.new('# fred here  ').is_descriptive?.should be_true
+    end
+    it 'accepts a multi-word comment' do
+      CodeComment.new("# fred here \n# with \n   # biscuits ").is_descriptive?.should be_true
+    end
+  end
+
+  context 'comment config' do
+    it 'parses hashed options' do
+      config = CodeComment.new("# :reek:Duplication: { enabled: false }").config
+      config.should include('Duplication')
+      config['Duplication'].should include('enabled')
+      config['Duplication']['enabled'].should be_false
+    end
+    it 'parses hashed options with ruby names' do
+      config = CodeComment.new("# :reek:nested_iterators: { enabled: true }").config
+      config.should include('NestedIterators')
+      config['NestedIterators'].should include('enabled')
+      config['NestedIterators']['enabled'].should be_true
+    end
+    it 'parses multiple hashed options' do
+      config = CodeComment.new("# :reek:Duplication: { enabled: false }\n:reek:nested_iterators: { enabled: true }").config
+      config.should include('Duplication','NestedIterators')
+      config['Duplication'].should include('enabled')
+      config['Duplication']['enabled'].should be_false
+      config['NestedIterators'].should include('enabled')
+      config['NestedIterators']['enabled'].should be_true
+    end
+    it 'parses multiple hashed options on the same line' do
+      config = CodeComment.new("# :reek:Duplication: { enabled: false } and :reek:nested_iterators: { enabled: true }").config
+      config.should include('Duplication','NestedIterators')
+      config['Duplication'].should include('enabled')
+      config['Duplication']['enabled'].should be_false
+      config['NestedIterators'].should include('enabled')
+      config['NestedIterators']['enabled'].should be_true
+    end
+    it 'parses multiple unhashed options on the same line' do
+      config = CodeComment.new("# :reek:Duplication and :reek:nested_iterators").config
+      config.should include('Duplication','NestedIterators')
+      config['Duplication'].should include('enabled')
+      config['Duplication']['enabled'].should be_false
+      config['NestedIterators'].should include('enabled')
+      config['NestedIterators']['enabled'].should be_false
+    end
+    it 'disables the smell if no options are specifed' do
+      config = CodeComment.new("# :reek:Duplication").config
+      config.should include('Duplication')
+      config['Duplication'].should include('enabled')
+      config['Duplication']['enabled'].should be_false
+    end
+    it 'ignores smells after a space' do
+      config = CodeComment.new("# :reek: Duplication").config
+      config.should_not include('Duplication')
+    end
+  end
+end

data/spec/reek/source/object_source_spec.rb

@@ -0,0 +1,20 @@
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+
+include Reek
+
+describe Dir do
+  it 'reports correct smells via the Dir matcher' do
+    files = Dir['spec/samples/two_smelly_files/*.rb']
+    files.should reek
+    files.should reek_of(:UncommunicativeVariableName)
+    files.should_not reek_of(:LargeClass)
+  end
+
+  it 'copes with daft file specs' do
+    Dir["spec/samples/two_smelly_files/*/.rb"].should_not reek
+  end
+
+  it 'copes with empty array' do
+    [].should_not reek
+  end
+end