rails_best_practices 1.19.2 → 1.20.1

data/spec/fixtures/lib/rails_best_practices/plugins/reviews/not_use_rails_root_review.rb

@@ -5,8 +5,7 @@ require 'rails_best_practices/reviews/review'
 module RailsBestPractices
   module Plugins
     module Reviews
-      class NotUseRailsRootReview < RailsBestPractices::Reviews::Review
-      end
+      class NotUseRailsRootReview < RailsBestPractices::Reviews::Review; end
     end
   end
 end

data/spec/rails_best_practices/analyzer_spec.rb

@@ -5,39 +5,70 @@ require 'tmpdir'
 
 module RailsBestPractices
   describe Analyzer do
-    subject { Analyzer.new('.') }
+    subject { described_class.new('.') }
 
     describe '::new' do
-      it 'should expand a relative path to an absolute' do
+      it 'expands a relative path to an absolute' do
         expect(subject.path).to eq File.expand_path('.')
       end
     end
 
     describe 'expand_dirs_to_files' do
-      it 'should expand all files in spec directory' do
+      it 'expands all files in spec directory' do
         dir = File.dirname(__FILE__)
         expect(subject.expand_dirs_to_files(dir)).to be_include(dir + '/analyzer_spec.rb')
       end
     end
 
     describe 'file_sort' do
-      it 'should get models first, mailers, helpers and then others' do
-        files = ['app/controllers/users_controller.rb', 'app/mailers/user_mailer.rb', 'app/helpers/users_helper.rb', 'app/models/user.rb', 'app/views/users/index.html.haml', 'app/views/users/show.html.slim', 'lib/user.rb']
-        expect(subject.file_sort(files)).to eq(['app/models/user.rb', 'app/mailers/user_mailer.rb', 'app/helpers/users_helper.rb', 'app/controllers/users_controller.rb', 'app/views/users/index.html.haml', 'app/views/users/show.html.slim', 'lib/user.rb'])
+      it 'gets models first, mailers, helpers and then others' do
+        files = [
+          'app/controllers/users_controller.rb',
+          'app/mailers/user_mailer.rb',
+          'app/helpers/users_helper.rb',
+          'app/models/user.rb',
+          'app/views/users/index.html.haml',
+          'app/views/users/show.html.slim',
+          'lib/user.rb'
+        ]
+        expect(subject.file_sort(files)).to eq(
+          [
+            'app/models/user.rb',
+            'app/mailers/user_mailer.rb',
+            'app/helpers/users_helper.rb',
+            'app/controllers/users_controller.rb',
+            'app/views/users/index.html.haml',
+            'app/views/users/show.html.slim',
+            'lib/user.rb'
+          ]
+        )
       end
     end
 
     describe 'file_ignore' do
       before do
-        @all = ['app/controllers/users_controller.rb', 'app/mailers/user_mailer.rb', 'app/models/user.rb', 'app/views/users/index.html.haml', 'app/views/users/show.html.slim', 'lib/user.rb']
-        @filtered = ['app/controllers/users_controller.rb', 'app/mailers/user_mailer.rb', 'app/models/user.rb', 'app/views/users/index.html.haml', 'app/views/users/show.html.slim']
-      end
-
-      it 'should ignore lib' do
+        @all = [
+          'app/controllers/users_controller.rb',
+          'app/mailers/user_mailer.rb',
+          'app/models/user.rb',
+          'app/views/users/index.html.haml',
+          'app/views/users/show.html.slim',
+          'lib/user.rb'
+        ]
+        @filtered = [
+          'app/controllers/users_controller.rb',
+          'app/mailers/user_mailer.rb',
+          'app/models/user.rb',
+          'app/views/users/index.html.haml',
+          'app/views/users/show.html.slim'
+        ]
+      end
+
+      it 'ignores lib' do
         expect(subject.file_ignore(@all, 'lib/')).to eq(@filtered)
       end
 
-      it 'should ignore regexp patterns' do
+      it 'ignores regexp patterns' do
         expect(subject.file_ignore(@all, /lib/)).to eq(@filtered)
       end
     end
@@ -88,7 +119,7 @@ module RailsBestPractices
     end
 
     describe 'output_terminal_errors' do
-      it 'should output errors in terminal' do
+      it 'outputs errors in terminal' do
         check1 = Reviews::LawOfDemeterReview.new
         check2 = Reviews::UseQueryAttributeReview.new
         runner = Core::Runner.new(reviews: [check1, check2])
@@ -102,11 +133,14 @@ module RailsBestPractices
         subject.output_terminal_errors
         result = $stdout.string
         $stdout = $origin_stdout
-        expect(result).to eq([
-          "\e[31mapp/models/user.rb:10 - law of demeter\e[0m",
-          "\e[31mapp/models/post.rb:100 - use query attribute\e[0m",
-          "\e[32m\nPlease go to https://rails-bestpractices.com to see more useful Rails Best Practices.\e[0m",
-          "\e[31m\nFound 2 warnings.\e[0m"].join("\n") + "\n")
+        expect(result).to eq(
+          [
+            "\e[31mapp/models/user.rb:10 - law of demeter\e[0m",
+            "\e[31mapp/models/post.rb:100 - use query attribute\e[0m",
+            "\e[32m\nPlease go to https://rails-bestpractices.com to see more useful Rails Best Practices.\e[0m",
+            "\e[31m\nFound 2 warnings.\e[0m"
+          ].join("\n") + "\n"
+        )
       end
     end
 
@@ -114,10 +148,7 @@ module RailsBestPractices
       let(:output_file) { 'rails_best_practices_output.json' }
 
       subject do
-        described_class.new('.',
-          'format' => 'json',
-          'output-file' => output_file
-        )
+        described_class.new('.', 'format' => 'json', 'output-file' => output_file)
       end
 
       let(:check1) { Reviews::LawOfDemeterReview.new }
@@ -142,54 +173,54 @@ module RailsBestPractices
     end
 
     describe 'parse_files' do
-      it 'should not filter out all files when the path contains "vendor"' do
-        Dir.mktmpdir { |random_dir|
+      it 'does not filter out all files when the path contains "vendor"' do
+        Dir.mktmpdir do |random_dir|
           Dir.mkdir(File.join(random_dir, 'vendor'))
           Dir.mkdir(File.join(random_dir, 'vendor', 'my_project'))
           File.open(File.join(random_dir, 'vendor', 'my_project', 'my_file.rb'), 'w') { |file| file << 'woot' }
-          analyzer = Analyzer.new(File.join(random_dir, 'vendor', 'my_project'))
+          analyzer = described_class.new(File.join(random_dir, 'vendor', 'my_project'))
           expect(analyzer.parse_files).to be_include File.join(random_dir, 'vendor', 'my_project', 'my_file.rb')
-        }
+        end
       end
 
-      it 'should not filter out all files when the path contains "spec"' do
-        Dir.mktmpdir { |random_dir|
+      it 'does not filter out all files when the path contains "spec"' do
+        Dir.mktmpdir do |random_dir|
           Dir.mkdir(File.join(random_dir, 'spec'))
           Dir.mkdir(File.join(random_dir, 'spec', 'my_project'))
           File.open(File.join(random_dir, 'spec', 'my_project', 'my_file.rb'), 'w') { |file| file << 'woot' }
-          analyzer = Analyzer.new(File.join(random_dir, 'spec', 'my_project'))
+          analyzer = described_class.new(File.join(random_dir, 'spec', 'my_project'))
           expect(analyzer.parse_files).to be_include File.join(random_dir, 'spec', 'my_project', 'my_file.rb')
-        }
+        end
       end
 
-      it 'should not filter out all files when the path contains "test"' do
-        Dir.mktmpdir { |random_dir|
+      it 'does not filter out all files when the path contains "test"' do
+        Dir.mktmpdir do |random_dir|
           Dir.mkdir(File.join(random_dir, 'test'))
           Dir.mkdir(File.join(random_dir, 'test', 'my_project'))
           File.open(File.join(random_dir, 'test', 'my_project', 'my_file.rb'), 'w') { |file| file << 'woot' }
-          analyzer = Analyzer.new(File.join(random_dir, 'test', 'my_project'))
+          analyzer = described_class.new(File.join(random_dir, 'test', 'my_project'))
           expect(analyzer.parse_files).to be_include File.join(random_dir, 'test', 'my_project', 'my_file.rb')
-        }
+        end
       end
 
-      it 'should not filter out all files when the path contains "features"' do
-        Dir.mktmpdir { |random_dir|
+      it 'does not filter out all files when the path contains "features"' do
+        Dir.mktmpdir do |random_dir|
           Dir.mkdir(File.join(random_dir, 'test'))
           Dir.mkdir(File.join(random_dir, 'test', 'my_project'))
           File.open(File.join(random_dir, 'test', 'my_project', 'my_file.rb'), 'w') { |file| file << 'woot' }
-          analyzer = Analyzer.new(File.join(random_dir, 'test', 'my_project'))
+          analyzer = described_class.new(File.join(random_dir, 'test', 'my_project'))
           expect(analyzer.parse_files).to be_include File.join(random_dir, 'test', 'my_project', 'my_file.rb')
-        }
+        end
       end
 
-      it 'should not filter out all files when the path contains "tmp"' do
-        Dir.mktmpdir { |random_dir|
+      it 'does not filter out all files when the path contains "tmp"' do
+        Dir.mktmpdir do |random_dir|
           Dir.mkdir(File.join(random_dir, 'tmp'))
           Dir.mkdir(File.join(random_dir, 'tmp', 'my_project'))
           File.open(File.join(random_dir, 'tmp', 'my_project', 'my_file.rb'), 'w') { |file| file << 'woot' }
-          analyzer = Analyzer.new(File.join(random_dir, 'tmp', 'my_project'))
+          analyzer = described_class.new(File.join(random_dir, 'tmp', 'my_project'))
           expect(analyzer.parse_files).to be_include File.join(random_dir, 'tmp', 'my_project', 'my_file.rb')
-        }
+        end
       end
     end
   end

data/spec/rails_best_practices/core/check_spec.rb

@@ -4,13 +4,13 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Check do
-    let(:check) { Check.new }
+    let(:check) { described_class.new }
 
     context 'debug' do
-      it 'should be debug mode' do
-        Check.debug
-        expect(Check).to be_debug
-        Check.class_eval { @debug = false }
+      it 'is debug mode' do
+        described_class.debug
+        expect(described_class).to be_debug
+        described_class.class_eval { @debug = false }
       end
     end
   end

data/spec/rails_best_practices/core/checks_loader_spec.rb

@@ -4,17 +4,17 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe ChecksLoader do
-    let(:checks_loader) { ChecksLoader.new(RailsBestPractices::Analyzer::DEFAULT_CONFIG) }
+    let(:checks_loader) { described_class.new(RailsBestPractices::Analyzer::DEFAULT_CONFIG) }
 
     describe 'load_lexicals' do
-      it 'should load lexical checks from the default configuration' do
+      it 'loads lexical checks from the default configuration' do
         lexicals = checks_loader.load_lexicals
         expect(lexicals.map(&:class)).to include(RailsBestPractices::Lexicals::RemoveTrailingWhitespaceCheck)
       end
     end
 
     describe 'load_reviews' do
-      it 'should load the reviews from the default the configuration' do
+      it 'loads the reviews from the default the configuration' do
         reviews = checks_loader.load_reviews
         expect(reviews.map(&:class)).to include(RailsBestPractices::Reviews::AlwaysAddDbIndexReview)
       end

data/spec/rails_best_practices/core/configs_spec.rb

@@ -4,6 +4,6 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Configs do
-    it { should be_a_kind_of Hash }
+    it { is_expected.to be_a_kind_of Hash }
   end
 end

data/spec/rails_best_practices/core/controllers_spec.rb

@@ -4,6 +4,6 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Controllers do
-    it { should be_a_kind_of Klasses }
+    it { is_expected.to be_a_kind_of Klasses }
   end
 end

data/spec/rails_best_practices/core/error_spec.rb

@@ -4,29 +4,32 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Error do
-    it 'should return error with filename, line number and message' do
-      expect(Error.new(
-        filename: 'app/models/user.rb',
-        line_number: '100',
-        message: 'not good',
-        type: 'BogusReview').to_s).to eq('app/models/user.rb:100 - not good')
+    it 'returns error with filename, line number and message' do
+      expect(
+        described_class.new(
+          filename: 'app/models/user.rb', line_number: '100', message: 'not good', type: 'BogusReview'
+        ).to_s
+      ).to eq('app/models/user.rb:100 - not good')
     end
 
-    it 'should return short filename' do
+    it 'returns short filename' do
       Runner.base_path = '../rails-bestpractices.com'
-      expect(Error.new(
-        filename: '../rails-bestpractices.com/app/models/user.rb',
-        line_number: '100',
-        message: 'not good',
-        type: 'BogusReview').short_filename).to eq('app/models/user.rb')
+      expect(
+        described_class.new(
+          filename: '../rails-bestpractices.com/app/models/user.rb',
+          line_number: '100',
+          message: 'not good',
+          type: 'BogusReview'
+        ).short_filename
+      ).to eq('app/models/user.rb')
     end
 
-    it 'should return first line number' do
-      expect(Error.new(
-        filename: 'app/models/user.rb',
-        line_number: '50,70,100',
-        message: 'not good',
-        type: 'BogusReview').first_line_number).to eq('50')
+    it 'returns first line number' do
+      expect(
+        described_class.new(
+          filename: 'app/models/user.rb', line_number: '50,70,100', message: 'not good', type: 'BogusReview'
+        ).first_line_number
+      ).to eq('50')
     end
   end
 end

data/spec/rails_best_practices/core/except_methods_spec.rb

@@ -10,7 +10,7 @@ module RailsBestPractices::Core
       let(:except_method) { '*#*' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql true
+        expect(described_class.matches(method, except_method)).to eql true
       end
     end
 
@@ -18,7 +18,7 @@ module RailsBestPractices::Core
       let(:except_method) { '*#approve' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql true
+        expect(described_class.matches(method, except_method)).to eql true
       end
     end
 
@@ -26,7 +26,7 @@ module RailsBestPractices::Core
       let(:except_method) { '*#disapprove' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql false
+        expect(described_class.matches(method, except_method)).to eql false
       end
     end
 
@@ -34,7 +34,7 @@ module RailsBestPractices::Core
       let(:except_method) { 'BlogPost#*' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql true
+        expect(described_class.matches(method, except_method)).to eql true
       end
     end
 
@@ -42,7 +42,7 @@ module RailsBestPractices::Core
       let(:except_method) { 'User#*' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql false
+        expect(described_class.matches(method, except_method)).to eql false
       end
     end
 
@@ -50,7 +50,7 @@ module RailsBestPractices::Core
       let(:except_method) { 'BlogPost#approve' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql true
+        expect(described_class.matches(method, except_method)).to eql true
       end
     end
 
@@ -58,7 +58,7 @@ module RailsBestPractices::Core
       let(:except_method) { 'User#disapprove' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql false
+        expect(described_class.matches(method, except_method)).to eql false
       end
     end
   end

data/spec/rails_best_practices/core/gems_spec.rb

@@ -4,15 +4,15 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Gems do
-    it { should be_a_kind_of Array }
+    it { is_expected.to be_a_kind_of Array }
 
-    let(:gems) { Gems.new }
+    let(:gems) { described_class.new }
     before do
       gems << Gem.new('rails', '4.0.0')
       gems << Gem.new('mysql2', '0.2.0')
     end
 
-    context '#has_gem?' do
+    describe '#has_gem?' do
       it 'has rails gem' do
         expect(gems).to be_has_gem 'rails'
       end
@@ -22,7 +22,7 @@ module RailsBestPractices::Core
       end
     end
 
-    context '#gem_version' do
+    describe '#gem_version' do
       it 'gets rails version' do
         expect(gems.gem_version('rails')).to eq '4.0.0'
       end

data/spec/rails_best_practices/core/helpers_spec.rb

@@ -4,6 +4,6 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Helpers do
-    it { should be_a_kind_of Modules }
+    it { is_expected.to be_a_kind_of Modules }
   end
 end

data/spec/rails_best_practices/core/klasses_spec.rb

@@ -4,10 +4,10 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Klasses do
-    it { should be_a_kind_of Array }
+    it { is_expected.to be_a_kind_of Array }
 
     context 'Klass' do
-      context '#class_name' do
+      describe '#class_name' do
         it 'gets class name without module' do
           klass = Klass.new('BlogPost', 'Post', [])
           expect(klass.class_name).to eq('BlogPost')
@@ -19,7 +19,7 @@ module RailsBestPractices::Core
         end
       end
 
-      context '#extend_class_name' do
+      describe '#extend_class_name' do
         it 'gets extend class name without module' do
           klass = Klass.new('BlogPost', 'Post', [])
           expect(klass.extend_class_name).to eq('Post')

data/spec/rails_best_practices/core/mailers_spec.rb

@@ -4,6 +4,6 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Mailers do
-    it { should be_a_kind_of Klasses }
+    it { is_expected.to be_a_kind_of Klasses }
   end
 end