rails_best_practices 1.19.2 → 1.20.1

data/spec/rails_best_practices/prepares/gemfile_prepare_spec.rb

@@ -5,26 +5,26 @@ require 'spec_helper'
 module RailsBestPractices
   module Prepares
     describe GemfilePrepare do
-      let(:runner) { Core::Runner.new(prepares: GemfilePrepare.new) }
+      let(:runner) { Core::Runner.new(prepares: described_class.new) }
 
       context 'gemfile' do
-        it 'should parse gems' do
-          content = <<-EOF
-GEM
-  remote: https://rubygems.org/
-  specs:
-    rails (3.2.13)
-      actionmailer (= 3.2.13)
-      actionpack (= 3.2.13)
-      activerecord (= 3.2.13)
-      activeresource (= 3.2.13)
-      activesupport (= 3.2.13)
-      bundler (~> 1.0)
-      railties (= 3.2.13)
-    mysql2 (0.3.12b6)
+        it 'parses gems' do
+          content = <<~EOF
+            GEM
+              remote: https://rubygems.org/
+              specs:
+                rails (3.2.13)
+                  actionmailer (= 3.2.13)
+                  actionpack (= 3.2.13)
+                  activerecord (= 3.2.13)
+                  activeresource (= 3.2.13)
+                  activesupport (= 3.2.13)
+                  bundler (~> 1.0)
+                  railties (= 3.2.13)
+                mysql2 (0.3.12b6)
 
-PLATFORMS
-  ruby
+            PLATFORMS
+              ruby
           EOF
           runner.prepare('Gemfile.lock', content)
           gems = Prepares.gems

data/spec/rails_best_practices/prepares/helper_prepare_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Prepares
     describe HelperPrepare do
-      let(:runner) { Core::Runner.new(prepares: HelperPrepare.new) }
+      let(:runner) { Core::Runner.new(prepares: described_class.new) }
 
       context 'methods' do
-        it 'should parse helper methods' do
+        it 'parses helper methods' do
           content = <<-EOF
           module PostsHelper
             def used; end
@@ -20,7 +20,7 @@ module RailsBestPractices
           expect(methods.get_methods('PostsHelper').map(&:method_name)).to eq(%w[used unused])
         end
 
-        it 'should parse helpers' do
+        it 'parses helpers' do
           content = <<-EOF
           module PostsHelper
           end

data/spec/rails_best_practices/prepares/initializer_prepare_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Prepares
     describe InitializerPrepare do
-      let(:runner) { Core::Runner.new(prepares: InitializerPrepare.new) }
+      let(:runner) { Core::Runner.new(prepares: described_class.new) }
 
       context 'initializers' do
-        it 'should set include_forbidden_attributes_protection config' do
+        it 'sets include_forbidden_attributes_protection config' do
           content = <<-EOF
           class AR
             ActiveRecord::Base.send(:include, ActiveModel::ForbiddenAttributesProtection)
@@ -19,7 +19,7 @@ module RailsBestPractices
           expect(configs['railsbp.include_forbidden_attributes_protection']).to eq('true')
         end
 
-        it 'should not set include_forbidden_attributes_protection config' do
+        it 'does not set include_forbidden_attributes_protection config' do
           content = <<-EOF
           class AR
           end

data/spec/rails_best_practices/prepares/mailer_prepare_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Prepares
     describe MailerPrepare do
-      let(:runner) { Core::Runner.new(prepares: MailerPrepare.new) }
+      let(:runner) { Core::Runner.new(prepares: described_class.new) }
 
-      it 'should parse mailer names' do
+      it 'parses mailer names' do
         content = <<-EOF
         class ProjectMailer < ActionMailer::Base
         end

data/spec/rails_best_practices/prepares/model_prepare_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Prepares
     describe ModelPrepare do
-      let(:runner) { Core::Runner.new(prepares: ModelPrepare.new) }
+      let(:runner) { Core::Runner.new(prepares: described_class.new) }
 
       context 'models' do
         it 'class_name with modules ::' do
@@ -32,7 +32,7 @@ module RailsBestPractices
       end
 
       context 'associations' do
-        it 'should parse model associations' do
+        it 'parses model associations' do
           content = <<-EOF
           class Project < ActiveRecord::Base
             belongs_to              :portfolio
@@ -43,14 +43,22 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/project.rb', content)
           model_associations = Prepares.model_associations
-          expect(model_associations.get_association('Project', 'portfolio')).to eq('meta' => 'belongs_to', 'class_name' => 'Portfolio')
-          expect(model_associations.get_association('Project', 'project_manager')).to eq('meta' => 'has_one', 'class_name' => 'ProjectManager')
-          expect(model_associations.get_association('Project', 'milestones')).to eq('meta' => 'has_many', 'class_name' => 'Milestone')
-          expect(model_associations.get_association('Project', 'categories')).to eq('meta' => 'has_and_belongs_to_many', 'class_name' => 'Category')
+          expect(model_associations.get_association('Project', 'portfolio')).to eq(
+            'meta' => 'belongs_to', 'class_name' => 'Portfolio'
+          )
+          expect(model_associations.get_association('Project', 'project_manager')).to eq(
+            'meta' => 'has_one', 'class_name' => 'ProjectManager'
+          )
+          expect(model_associations.get_association('Project', 'milestones')).to eq(
+            'meta' => 'has_many', 'class_name' => 'Milestone'
+          )
+          expect(model_associations.get_association('Project', 'categories')).to eq(
+            'meta' => 'has_and_belongs_to_many', 'class_name' => 'Category'
+          )
         end
 
         context 'with class_name option' do
-          it 'should parse belongs_to' do
+          it 'parses belongs_to' do
             content = <<-EOF
             class Post < ActiveRecord::Base
               belongs_to :author, "class_name" => "Person"
@@ -58,10 +66,12 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/post.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Post', 'author')).to eq('meta' => 'belongs_to', 'class_name' => 'Person')
+            expect(model_associations.get_association('Post', 'author')).to eq(
+              'meta' => 'belongs_to', 'class_name' => 'Person'
+            )
           end
 
-          it 'should parse has_one' do
+          it 'parses has_one' do
             content = <<-EOF
             class Project < ActiveRecord::Base
               has_one :project_manager, "class_name" => "Person"
@@ -69,10 +79,12 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/post.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Project', 'project_manager')).to eq('meta' => 'has_one', 'class_name' => 'Person')
+            expect(model_associations.get_association('Project', 'project_manager')).to eq(
+              'meta' => 'has_one', 'class_name' => 'Person'
+            )
           end
 
-          it 'should parse has_many' do
+          it 'parses has_many' do
             content = <<-EOF
             class Project < ActiveRecord::Base
               has_many :people, "class_name" => "Person"
@@ -80,10 +92,12 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/project.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Project', 'people')).to eq('meta' => 'has_many', 'class_name' => 'Person')
+            expect(model_associations.get_association('Project', 'people')).to eq(
+              'meta' => 'has_many', 'class_name' => 'Person'
+            )
           end
 
-          it 'should parse has_and_belongs_to_many' do
+          it 'parses has_and_belongs_to_many' do
             content = <<-EOF
             class Citizen < ActiveRecord::Base
               has_and_belongs_to_many :nations, "class_name" => "Country"
@@ -91,11 +105,13 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/citizen.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Citizen', 'nations')).to eq('meta' => 'has_and_belongs_to_many', 'class_name' => 'Country')
+            expect(model_associations.get_association('Citizen', 'nations')).to eq(
+              'meta' => 'has_and_belongs_to_many', 'class_name' => 'Country'
+            )
           end
 
           context 'namespace' do
-            it 'should parse with namespace' do
+            it 'parses with namespace' do
               content = <<-EOF
               class Community < ActiveRecord::Base
                 has_many :members
@@ -110,11 +126,15 @@ module RailsBestPractices
               runner.prepare('app/models/community/member.rb', content)
               runner.after_prepare
               model_associations = Prepares.model_associations
-              expect(model_associations.get_association('Community', 'members')).to eq('meta' => 'has_many', 'class_name' => 'Community::Member')
-              expect(model_associations.get_association('Community::Member', 'community')).to eq('meta' => 'belongs_to', 'class_name' => 'Community')
+              expect(model_associations.get_association('Community', 'members')).to eq(
+                'meta' => 'has_many', 'class_name' => 'Community::Member'
+              )
+              expect(model_associations.get_association('Community::Member', 'community')).to eq(
+                'meta' => 'belongs_to', 'class_name' => 'Community'
+              )
             end
 
-            it 'should parse without namespace' do
+            it 'parses without namespace' do
               content = <<-EOF
               class Community::Member::Rating < ActiveRecord::Base
                 belongs_to :member
@@ -129,14 +149,18 @@ module RailsBestPractices
               runner.prepare('app/models/community/member.rb', content)
               runner.after_prepare
               model_associations = Prepares.model_associations
-              expect(model_associations.get_association('Community::Member::Rating', 'member')).to eq('meta' => 'belongs_to', 'class_name' => 'Community::Member')
-              expect(model_associations.get_association('Community::Member', 'ratings')).to eq('meta' => 'has_many', 'class_name' => 'Community::Member::Rating')
+              expect(model_associations.get_association('Community::Member::Rating', 'member')).to eq(
+                'meta' => 'belongs_to', 'class_name' => 'Community::Member'
+              )
+              expect(model_associations.get_association('Community::Member', 'ratings')).to eq(
+                'meta' => 'has_many', 'class_name' => 'Community::Member::Rating'
+              )
             end
           end
         end
 
         context 'mongoid embeds' do
-          it 'should parse embeds_many' do
+          it 'parses embeds_many' do
             content = <<-EOF
             class Person
               include Mongoid::Document
@@ -145,10 +169,12 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/person.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Person', 'addresses')).to eq('meta' => 'embeds_many', 'class_name' => 'Address')
+            expect(model_associations.get_association('Person', 'addresses')).to eq(
+              'meta' => 'embeds_many', 'class_name' => 'Address'
+            )
           end
 
-          it 'should parse embeds_one' do
+          it 'parses embeds_one' do
             content = <<-EOF
             class Lush
               include Mongoid::Document
@@ -157,10 +183,12 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/lush.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Lush', 'whiskey')).to eq('meta' => 'embeds_one', 'class_name' => 'Drink')
+            expect(model_associations.get_association('Lush', 'whiskey')).to eq(
+              'meta' => 'embeds_one', 'class_name' => 'Drink'
+            )
           end
 
-          it 'should parse embedded_in' do
+          it 'parses embedded_in' do
             content = <<-EOF
             class Drink
               include Mongoid::Document
@@ -169,12 +197,14 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/drink.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Drink', 'alcoholic')).to eq('meta' => 'embedded_in', 'class_name' => 'Lush')
+            expect(model_associations.get_association('Drink', 'alcoholic')).to eq(
+              'meta' => 'embedded_in', 'class_name' => 'Lush'
+            )
           end
         end
 
         context 'mongomapper many/one' do
-          it 'should parse one' do
+          it 'parses one' do
             content = <<-EOF
             class Employee
               include MongoMapper::Document
@@ -183,10 +213,12 @@ module RailsBestPractices
             EOF
             runner.prepare('app/models/employee.rb', content)
             model_associations = Prepares.model_associations
-            expect(model_associations.get_association('Employee', 'desk')).to eq('meta' => 'one', 'class_name' => 'Desk')
+            expect(model_associations.get_association('Employee', 'desk')).to eq(
+              'meta' => 'one', 'class_name' => 'Desk'
+            )
           end
 
-          it 'should parse many' do
+          it 'parses many' do
             content = <<-EOF
             class Tree
               include MongoMapper::Document
@@ -201,7 +233,7 @@ module RailsBestPractices
       end
 
       context 'methods' do
-        it 'should parse model methods' do
+        it 'parses model methods' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def save; end
@@ -213,7 +245,7 @@ module RailsBestPractices
           expect(methods.get_methods('Post').map(&:method_name)).to eq(%w[save find])
         end
 
-        it 'should parse model methods with access control' do
+        it 'parses model methods with access control' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def save; end
@@ -232,7 +264,7 @@ module RailsBestPractices
           expect(methods.get_methods('Post', 'private').map(&:method_name)).to eq(['find_by_sql'])
         end
 
-        it 'should parse model methods with module ::' do
+        it 'parses model methods with module ::' do
           content = <<-EOF
           class Admin::Blog::Post < ActiveRecord::Base
             def save; end
@@ -244,7 +276,7 @@ module RailsBestPractices
           expect(methods.get_methods('Admin::Blog::Post').map(&:method_name)).to eq(%w[save find])
         end
 
-        it 'should parse model methods with module' do
+        it 'parses model methods with module' do
           content = <<-EOF
           module Admin
             module Blog
@@ -260,7 +292,7 @@ module RailsBestPractices
           expect(methods.get_methods('Admin::Blog::Post').map(&:method_name)).to eq(%w[save find])
         end
 
-        it 'should not add methods from module' do
+        it 'does not add methods from module' do
           content = <<-EOF
             class Model < ActiveRecord::Base
             end
@@ -279,7 +311,7 @@ module RailsBestPractices
       end
 
       context 'scope' do
-        it 'should treat named_scope as method' do
+        it 'treats named_scope as method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             named_scope :active, conditions: {active: true}
@@ -290,7 +322,7 @@ module RailsBestPractices
           expect(methods.get_methods('Post').map(&:method_name)).to eq(['active'])
         end
 
-        it 'should treat scope as method' do
+        it 'treats scope as method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             scope :active, where(active: true)
@@ -303,7 +335,7 @@ module RailsBestPractices
       end
 
       context 'alias' do
-        it 'should treat alias as method' do
+        it 'treats alias as method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             alias :new :old
@@ -314,7 +346,7 @@ module RailsBestPractices
           expect(methods.get_methods('Post').map(&:method_name)).to eq(['new'])
         end
 
-        it 'should treat alias_method as method' do
+        it 'treats alias_method as method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             alias_method :new, :old
@@ -325,7 +357,7 @@ module RailsBestPractices
           expect(methods.get_methods('Post').map(&:method_name)).to eq(['new'])
         end
 
-        it 'should treat alias_method_chain as method' do
+        it 'treats alias_method_chain as method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             alias_method_chain :method, :feature
@@ -338,7 +370,7 @@ module RailsBestPractices
       end
 
       context 'attributes' do
-        it 'should parse mongoid field' do
+        it 'parses mongoid field' do
           content = <<-EOF
           class Post
             include Mongoid::Document
@@ -358,7 +390,7 @@ module RailsBestPractices
           expect(model_attributes.get_attribute_type('Post', 'active')).to eq('Boolean')
         end
 
-        it 'should parse mongomapper field' do
+        it 'parses mongomapper field' do
           content = <<-EOF
           class Post
             include MongoMapper::Document
@@ -382,13 +414,17 @@ module RailsBestPractices
       end
 
       context 'no error' do
-        it 'should raised for finder_sql option' do
+        it 'raiseds for finder_sql option' do
           content = <<-EOF
           class EventSubscription < ActiveRecord::Base
             has_many :event_notification_template, finder_sql: ?
           end
           EOF
-          content = content.sub('?', '\'SELECT event_notification_templates.* from event_notification_templates where event_type_id=#{event_type_id} and delivery_method_id=#{delivery_method_id}\'')
+          content =
+            content.sub(
+              '?',
+              '\'SELECT event_notification_templates.* from event_notification_templates where event_type_id=#{event_type_id} and delivery_method_id=#{delivery_method_id}\''
+            )
           expect { runner.prepare('app/models/event_subscription.rb', content) }.not_to raise_error
         end
       end

data/spec/rails_best_practices/prepares/route_prepare_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Prepares
     describe RoutePrepare do
-      let(:runner) { Core::Runner.new(prepares: RoutePrepare.new) }
+      let(:runner) { Core::Runner.new(prepares: described_class.new) }
 
       context 'resources' do
-        it 'should add resources route' do
+        it 'adds resources route' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
@@ -17,10 +17,20 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(7)
-          expect(routes.map(&:to_s)).to eq(['PostsController#index', 'PostsController#show', 'PostsController#new', 'PostsController#create', 'PostsController#edit', 'PostsController#update', 'PostsController#destroy'])
-        end
-
-        it 'should add multiple resources route' do
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'PostsController#index',
+              'PostsController#show',
+              'PostsController#new',
+              'PostsController#create',
+              'PostsController#edit',
+              'PostsController#update',
+              'PostsController#destroy'
+            ]
+          )
+        end
+
+        it 'adds multiple resources route' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, :users
@@ -31,7 +41,7 @@ module RailsBestPractices
           expect(routes.size).to eq(14)
         end
 
-        it 'should add resources route with explict controller' do
+        it 'adds resources route with explict controller' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, controller: :blog_posts
@@ -40,10 +50,20 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(7)
-          expect(routes.map(&:to_s)).to eq(['BlogPostsController#index', 'BlogPostsController#show', 'BlogPostsController#new', 'BlogPostsController#create', 'BlogPostsController#edit', 'BlogPostsController#update', 'BlogPostsController#destroy'])
-        end
-
-        it 'should add resources route with only option' do
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'BlogPostsController#index',
+              'BlogPostsController#show',
+              'BlogPostsController#new',
+              'BlogPostsController#create',
+              'BlogPostsController#edit',
+              'BlogPostsController#update',
+              'BlogPostsController#destroy'
+            ]
+          )
+        end
+
+        it 'adds resources route with only option' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: [:index, :show, :new, :create]
@@ -52,10 +72,12 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(4)
-          expect(routes.map(&:to_s)).to eq(['PostsController#index', 'PostsController#show', 'PostsController#new', 'PostsController#create'])
+          expect(routes.map(&:to_s)).to eq(
+            ['PostsController#index', 'PostsController#show', 'PostsController#new', 'PostsController#create']
+          )
         end
 
-        it 'should add resources route with except option' do
+        it 'adds resources route with except option' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, except: [:edit, :update, :destroy]
@@ -64,10 +86,12 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(4)
-          expect(routes.map(&:to_s)).to eq(['PostsController#index', 'PostsController#show', 'PostsController#new', 'PostsController#create'])
+          expect(routes.map(&:to_s)).to eq(
+            ['PostsController#index', 'PostsController#show', 'PostsController#new', 'PostsController#create']
+          )
         end
 
-        it 'should not add resources routes with only: :none' do
+        it 'does not add resources routes with only: :none' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: :none
@@ -78,7 +102,7 @@ module RailsBestPractices
           expect(routes.size).to eq(0)
         end
 
-        it 'should not add resources routes with except: :all' do
+        it 'does not add resources routes with except: :all' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, except: :all
@@ -89,7 +113,7 @@ module RailsBestPractices
           expect(routes.size).to eq(0)
         end
 
-        it 'should add resources routes with members' do
+        it 'adds resources routes with members' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             namespace :admin do
@@ -104,14 +128,17 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          expect(routes.map(&:to_s)).to eq([
-            'Admin::PostsController#edit',
-            'Admin::PostsController#update',
-            'Admin::PostsController#link_to_post',
-            'Admin::PostsController#extra_update'])
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'Admin::PostsController#edit',
+              'Admin::PostsController#update',
+              'Admin::PostsController#link_to_post',
+              'Admin::PostsController#extra_update'
+            ]
+          )
         end
 
-        it 'should add resources routes with members inline' do
+        it 'adds resources routes with members inline' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             namespace :admin do
@@ -123,15 +150,18 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          expect(routes.map(&:to_s)).to eq([
-            'Admin::PostsController#edit',
-            'Admin::PostsController#update',
-            'Admin::PostsController#link_to_post',
-            'Admin::PostsController#extra_update',
-            'Admin::PostsController#retrieve'])
-        end
-
-        it 'should add connect route' do
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'Admin::PostsController#edit',
+              'Admin::PostsController#update',
+              'Admin::PostsController#link_to_post',
+              'Admin::PostsController#extra_update',
+              'Admin::PostsController#retrieve'
+            ]
+          )
+        end
+
+        it 'adds connect route' do
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.connect 'vote', controller: "votes", action: "create", method: :post
@@ -142,7 +172,7 @@ module RailsBestPractices
           expect(routes.map(&:to_s)).to eq(['VotesController#create'])
         end
 
-        it 'should add named route' do
+        it 'adds named route' do
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.login '/player/login', controller: 'sessions', action: 'new', conditions: { method: :get }
@@ -155,7 +185,7 @@ module RailsBestPractices
       end
 
       context 'resource' do
-        it 'should add resource route' do
+        it 'adds resource route' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts
@@ -164,10 +194,19 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(6)
-          expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#new', 'PostsController#create', 'PostsController#edit', 'PostsController#update', 'PostsController#destroy'])
-        end
-
-        it 'should add multiple resource route' do
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'PostsController#show',
+              'PostsController#new',
+              'PostsController#create',
+              'PostsController#edit',
+              'PostsController#update',
+              'PostsController#destroy'
+            ]
+          )
+        end
+
+        it 'adds multiple resource route' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, :users
@@ -178,7 +217,7 @@ module RailsBestPractices
           expect(routes.size).to eq(12)
         end
 
-        it 'should add resource route with only option' do
+        it 'adds resource route with only option' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, only: [:show, :new, :create]
@@ -190,7 +229,7 @@ module RailsBestPractices
           expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#new', 'PostsController#create'])
         end
 
-        it 'should add resource route with except option' do
+        it 'adds resource route with except option' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, except: [:edit, :update, :destroy]
@@ -202,7 +241,7 @@ module RailsBestPractices
           expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#new', 'PostsController#create'])
         end
 
-        it 'should not add resource routes with only: :none' do
+        it 'does not add resource routes with only: :none' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, only: :none
@@ -213,7 +252,7 @@ module RailsBestPractices
           expect(routes.size).to eq(0)
         end
 
-        it 'should not add resource routes with except: :all' do
+        it 'does not add resource routes with except: :all' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, except: :all
@@ -224,7 +263,7 @@ module RailsBestPractices
           expect(routes.size).to eq(0)
         end
 
-        it 'should add resource routes with get/post/put/patch/delete routes' do
+        it 'adds resource routes with get/post/put/patch/delete routes' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: [:show] do
@@ -244,13 +283,25 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(7)
-          expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#list', 'PostsController#search', 'PostsController#available', 'PostsController#create', 'PostsController#update', 'PostsController#update'])
-        end
-
-        it 'should add custom resources routes with {}' do
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'PostsController#show',
+              'PostsController#list',
+              'PostsController#search',
+              'PostsController#available',
+              'PostsController#create',
+              'PostsController#update',
+              'PostsController#update'
+            ]
+          )
+        end
+
+        it 'adds custom resources routes with {}' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
-            resources :posts, only: [:show] { get :inactive, on: :collection }
+            resources :posts, only: [:show] do
+              get :inactive, on: :collection
+            end
           end
           EOF
           runner.prepare('config/routes.rb', content)
@@ -259,7 +310,7 @@ module RailsBestPractices
           expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#inactive'])
         end
 
-        it 'should add resources routes with get %w() routes' do
+        it 'adds resources routes with get %w() routes' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: [:show] do
@@ -272,10 +323,12 @@ module RailsBestPractices
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
           expect(routes.size).to eq(3)
-          expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#latest', 'PostsController#popular'])
+          expect(routes.map(&:to_s)).to eq(
+            ['PostsController#show', 'PostsController#latest', 'PostsController#popular']
+          )
         end
 
-        it 'should add route with nested routes' do
+        it 'adds route with nested routes' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
@@ -288,7 +341,7 @@ module RailsBestPractices
           expect(routes.size).to eq(14)
         end
 
-        it 'should add route with namespace' do
+        it 'adds route with namespace' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             namespace :admin do
@@ -303,7 +356,7 @@ module RailsBestPractices
           expect(routes.map(&:to_s)).to eq(['Admin::Test::PostsController#index'])
         end
 
-        it 'should add route with namespace, but without resources' do
+        it 'adds route with namespace, but without resources' do
           content = <<-EOF
           RailsBestPracticesCom::Appllication.routes.draw do
             namespace :something do
@@ -314,10 +367,12 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          expect(routes.map(&:to_s)).to eq(['SomethingController#route_one', 'SomethingController#route_two', 'SomethingController#custom_action'])
+          expect(routes.map(&:to_s)).to eq(
+            ['SomethingController#route_one', 'SomethingController#route_two', 'SomethingController#custom_action']
+          )
         end
 
-        it 'should add route with scope' do
+        it 'adds route with scope' do
           content = <<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               scope module: "admin" do
@@ -337,17 +392,19 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          expect(routes.map(&:to_s)).to eq([
-                                          'Admin::PostsController#index',
-                                          'Admin::DiscussionsController#index',
-                                          'CommentsController#index',
-                                          'UsersController#show',
-                                          'UsersController#preview'
-                                        ])
+          expect(routes.map(&:to_s)).to eq(
+            [
+              'Admin::PostsController#index',
+              'Admin::DiscussionsController#index',
+              'CommentsController#index',
+              'UsersController#show',
+              'UsersController#preview'
+            ]
+          )
         end
       end
 
-      it 'should add route for direct get/post' do
+      it 'adds route for direct get/post' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           get 'posts/show'
@@ -360,10 +417,18 @@ module RailsBestPractices
         runner.prepare('config/routes.rb', content)
         routes = Prepares.routes
         expect(routes.size).to eq(5)
-        expect(routes.map(&:to_s)).to eq(['PostsController#show', 'PostsController#create', 'PostsController#update', 'PostsController#destroy', 'HighVoltage::PagesController#show'])
+        expect(routes.map(&:to_s)).to eq(
+          [
+            'PostsController#show',
+            'PostsController#create',
+            'PostsController#update',
+            'PostsController#destroy',
+            'HighVoltage::PagesController#show'
+          ]
+        )
       end
 
-      it 'should add routes for another get/post' do
+      it 'adds routes for another get/post' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw
           get "/login", to: 'sessions#new', as: :login
@@ -375,7 +440,7 @@ module RailsBestPractices
         expect(routes.first.to_s).to eq('SessionsController#new')
       end
 
-      it 'should add match route' do
+      it 'adds match route' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match '/auth/:provider/callback' => 'authentications#create'
@@ -386,7 +451,7 @@ module RailsBestPractices
         expect(routes.map(&:to_s)).to eq(['AuthenticationsController#create'])
       end
 
-      it 'should add match route with all actions' do
+      it 'adds match route with all actions' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match 'internal/:action/*whatever', controller: "internal"
@@ -397,7 +462,7 @@ module RailsBestPractices
         expect(routes.map(&:to_s)).to eq(['InternalController#*'])
       end
 
-      it 'should add root route' do
+      it 'adds root route' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           root to: 'home#index'
@@ -408,7 +473,7 @@ module RailsBestPractices
         expect(routes.map(&:to_s)).to eq(['HomeController#index'])
       end
 
-      it 'should add root shortcut route' do
+      it 'adds root shortcut route' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           root 'home#index'
@@ -419,7 +484,7 @@ module RailsBestPractices
         expect(routes.map(&:to_s)).to eq(['HomeController#index'])
       end
 
-      it 'should do nothing for default route' do
+      it 'does nothing for default route' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match ':controller(/:action(/:id(.:format)))'
@@ -430,7 +495,7 @@ module RailsBestPractices
         expect(routes.size).to eq(0)
       end
 
-      it 'should do nothing for redirect' do
+      it 'does nothing for redirect' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match "/stories/:name" => redirect("/posts/%{name}")
@@ -442,7 +507,7 @@ module RailsBestPractices
         expect(routes.size).to eq(0)
       end
 
-      it 'should parse customize route in nested resources' do
+      it 'parses customize route in nested resources' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           resources :posts do
@@ -456,7 +521,7 @@ module RailsBestPractices
         expect(routes.last.to_s).to eq('PostsController#stop')
       end
 
-      it 'should parse custom route for resource with explicit to and different action name' do
+      it 'parses custom route for resource with explicit to and different action name' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           resources :posts do
@@ -469,7 +534,7 @@ module RailsBestPractices
         expect(routes.last.to_s).to eq('PostsController#stop')
       end
 
-      it 'should parse custom route for resource with symbol action name' do
+      it 'parses custom route for resource with symbol action name' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           resources :posts do
@@ -482,7 +547,7 @@ module RailsBestPractices
         expect(routes.last.to_s).to eq('PostsController#stop')
       end
 
-      it 'should not take former resources for direct get/post' do
+      it 'does not take former resources for direct get/post' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           resources :posts
@@ -494,7 +559,7 @@ module RailsBestPractices
         expect(routes.last.to_s).to eq('SprintsController#stop')
       end
 
-      it 'should not parse wrong route' do
+      it 'does not parse wrong route' do
         content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match ':controller/:action' => '#index', as: :auto_complete