rails_best_practices 1.19.2 → 1.20.1

data/spec/rails_best_practices/reviews/use_say_with_time_in_migrations_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe UseSayWithTimeInMigrationsReview do
-      let(:runner) { Core::Runner.new(reviews: UseSayWithTimeInMigrationsReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should use say with time in migrations' do
+      it 'uses say with time in migrations' do
         content = <<-EOF
         def self.up
           User.find_each do |user|
@@ -18,10 +18,12 @@ module RailsBestPractices
         EOF
         runner.review('db/migrate/20101010080658_update_users.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('db/migrate/20101010080658_update_users.rb:2 - use say with time in migrations')
+        expect(runner.errors[0].to_s).to eq(
+          'db/migrate/20101010080658_update_users.rb:2 - use say with time in migrations'
+        )
       end
 
-      it 'should use say with time in migrations with create_table' do
+      it 'uses say with time in migrations with create_table' do
         content = <<-EOF
         def self.up
           create_table :users do |t|
@@ -37,10 +39,12 @@ module RailsBestPractices
         EOF
         runner.review('db/migrate/20101010080658_update_users.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('db/migrate/20101010080658_update_users.rb:7 - use say with time in migrations')
+        expect(runner.errors[0].to_s).to eq(
+          'db/migrate/20101010080658_update_users.rb:7 - use say with time in migrations'
+        )
       end
 
-      it 'should not use say with time in migrations' do
+      it 'does not use say with time in migrations' do
         content = <<-EOF
         def self.up
           say_with_time("Initialize first_name and last_name for users") do
@@ -56,7 +60,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not use say with time in migrations when not first code line' do
+      it 'does not use say with time in migrations when not first code line' do
         content = <<-EOF
         def self.up
           User.find_each do |user|
@@ -70,7 +74,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not use say with time when default migration message' do
+      it 'does not use say with time when default migration message' do
         content = <<-EOF
         def self.up
           create_table :users do |t|
@@ -84,7 +88,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not raise an error' do
+      it 'does not raise an error' do
         content = <<-EOF
         class AddAdmin < ActiveRecord::Migration
 
@@ -120,8 +124,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(3)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: UseSayWithTimeInMigrationsReview.new(ignored_files: /20101010080658_update_users/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /20101010080658_update_users/))
         content = <<-EOF
         def self.up
           User.find_each do |user|

data/spec/rails_best_practices/reviews/use_scope_access_review_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe UseScopeAccessReview do
-      let(:runner) { Core::Runner.new(reviews: UseScopeAccessReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
       context 'if' do
-        it 'should use scope access' do
+        it 'uses scope access' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -26,7 +26,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it 'should use scope access with if in one line' do
+        it 'uses scope access with if in one line' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -41,7 +41,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it "should use scope access with '? :'" do
+        it "uses scope access with '? :'" do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -56,7 +56,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it 'should use scope access by comparing with id' do
+        it 'uses scope access by comparing with id' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -74,7 +74,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it 'should use scope access with current_user ==' do
+        it 'uses scope access with current_user ==' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -92,7 +92,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it 'should use scope access by current_user.id ==' do
+        it 'uses scope access by current_user.id ==' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -112,7 +112,7 @@ module RailsBestPractices
       end
 
       context 'unless' do
-        it 'should use scope access' do
+        it 'uses scope access' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -130,7 +130,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it 'should use scope access by comparing with id' do
+        it 'uses scope access by comparing with id' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -148,7 +148,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it 'should use scope access with current_user ==' do
+        it 'uses scope access with current_user ==' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -166,7 +166,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it 'should use scope access by current_user.id ==' do
+        it 'uses scope access by current_user.id ==' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -184,7 +184,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it 'should no error in use_scope_access_review' do
+        it 'noes error in use_scope_access_review' do
           content = <<-EOF
           class CommentsController < ApplicationController
             def add_comment
@@ -206,8 +206,8 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not check ignored files' do
-          runner = Core::Runner.new(reviews: UseScopeAccessReview.new(ignored_files: /posts_controller/))
+        it 'does not check ignored files' do
+          runner = Core::Runner.new(reviews: described_class.new(ignored_files: /posts_controller/))
           content = <<-EOF
           class PostsController < ApplicationController
             def edit

data/spec/rails_best_practices/reviews/use_turbo_sprockets_rails3_review_spec.rb

@@ -5,21 +5,21 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe UseTurboSprocketsRails3Review do
-      let(:runner) { Core::Runner.new(prepares: Prepares::GemfilePrepare.new, reviews: UseTurboSprocketsRails3Review.new) }
+      let(:runner) { Core::Runner.new(prepares: Prepares::GemfilePrepare.new, reviews: described_class.new) }
 
-      it 'should use turbo-sprockets-rails3' do
-        content = <<-EOF
-GEM
-  remote: https://rubygems.org
-  specs:
-    rails (3.2.13)
-      actionmailer (= 3.2.13)
-      actionpack (= 3.2.13)
-      activerecord (= 3.2.13)
-      activeresource (= 3.2.13)
-      activesupport (= 3.2.13)
-      bundler (~> 1.0)
-      railties (= 3.2.13)
+      it 'uses turbo-sprockets-rails3' do
+        content = <<~EOF
+          GEM
+            remote: https://rubygems.org
+            specs:
+              rails (3.2.13)
+                actionmailer (= 3.2.13)
+                actionpack (= 3.2.13)
+                activerecord (= 3.2.13)
+                activeresource (= 3.2.13)
+                activesupport (= 3.2.13)
+                bundler (~> 1.0)
+                railties (= 3.2.13)
         EOF
         runner.prepare('Gemfile.lock', content)
         content = <<-EOF
@@ -32,22 +32,22 @@ GEM
         expect(runner.errors[0].to_s).to eq('Capfile:2 - speed up assets precompile with turbo-sprockets-rails3')
       end
 
-      it 'should not use turbo-sprockets-rails3 with turbo-sprockets-rails3 gem' do
-        content = <<-EOF
-GEM
-  remote: https://rubygems.org
-  specs:
-    rails (3.2.13)
-      actionmailer (= 3.2.13)
-      actionpack (= 3.2.13)
-      activerecord (= 3.2.13)
-      activeresource (= 3.2.13)
-      activesupport (= 3.2.13)
-      bundler (~> 1.0)
-      railties (= 3.2.13)
-    turbo-sprockets-rails3 (0.3.6)
-      railties (> 3.2.8, < 4.0.0)
-      sprockets (>= 2.0.0)
+      it 'does not use turbo-sprockets-rails3 with turbo-sprockets-rails3 gem' do
+        content = <<~EOF
+          GEM
+            remote: https://rubygems.org
+            specs:
+              rails (3.2.13)
+                actionmailer (= 3.2.13)
+                actionpack (= 3.2.13)
+                activerecord (= 3.2.13)
+                activeresource (= 3.2.13)
+                activesupport (= 3.2.13)
+                bundler (~> 1.0)
+                railties (= 3.2.13)
+              turbo-sprockets-rails3 (0.3.6)
+                railties (> 3.2.8, < 4.0.0)
+                sprockets (>= 2.0.0)
         EOF
         runner.prepare('Gemfile.lock', content)
         content = <<-EOF
@@ -59,7 +59,7 @@ GEM
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not use turbo-sprockets-rails3 without deploy/assets' do
+      it 'does not use turbo-sprockets-rails3 without deploy/assets' do
         content = <<-EOF
         load 'deploy' if respond_to?(:namespace)
         #load 'deploy/assets'
@@ -69,19 +69,19 @@ GEM
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not use turbo-sprockets-rails3 with rails4 gem' do
-        content = <<-EOF
-GEM
-  remote: https://rubygems.org
-  specs:
-    rails (4.0.0)
-      actionmailer (= 4.0.0)
-      actionpack (= 4.0.0)
-      activerecord (= 4.0.0)
-      activeresource (= 4.0.0)
-      activesupport (= 4.0.0)
-      bundler (~> 1.0)
-      railties (= 3.2.13)
+      it 'does not use turbo-sprockets-rails3 with rails4 gem' do
+        content = <<~EOF
+          GEM
+            remote: https://rubygems.org
+            specs:
+              rails (4.0.0)
+                actionmailer (= 4.0.0)
+                actionpack (= 4.0.0)
+                activerecord (= 4.0.0)
+                activeresource (= 4.0.0)
+                activesupport (= 4.0.0)
+                bundler (~> 1.0)
+                railties (= 3.2.13)
         EOF
         runner.prepare('Gemfile.lock', content)
         content = <<-EOF
@@ -93,21 +93,23 @@ GEM
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(prepares: Prepares::GemfilePrepare.new,
-                                  reviews: UseTurboSprocketsRails3Review.new(ignored_files: /Capfile/))
-        content = <<-EOF
-GEM
-  remote: https://rubygems.org
-  specs:
-    rails (3.2.13)
-      actionmailer (= 3.2.13)
-      actionpack (= 3.2.13)
-      activerecord (= 3.2.13)
-      activeresource (= 3.2.13)
-      activesupport (= 3.2.13)
-      bundler (~> 1.0)
-      railties (= 3.2.13)
+      it 'does not check ignored files' do
+        runner =
+          Core::Runner.new(
+            prepares: Prepares::GemfilePrepare.new, reviews: described_class.new(ignored_files: /Capfile/)
+          )
+        content = <<~EOF
+          GEM
+            remote: https://rubygems.org
+            specs:
+              rails (3.2.13)
+                actionmailer (= 3.2.13)
+                actionpack (= 3.2.13)
+                activerecord (= 3.2.13)
+                activeresource (= 3.2.13)
+                activesupport (= 3.2.13)
+                bundler (~> 1.0)
+                railties (= 3.2.13)
         EOF
         runner.prepare('Gemfile.lock', content)
         content = <<-EOF

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.19.2
+  version: 1.20.1
 platform: ruby
 authors:
 - Richard Huang
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-05-01 00:00:00.000000000 Z
+date: 2021-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.8
+        version: 0.5.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.8
+        version: 0.5.2
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: ruby-progressbar
   requirement: !ruby/object:Gem::Requirement
@@ -154,16 +154,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -205,6 +205,7 @@ files:
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
+- Gemfile.lock
 - Guardfile
 - MIT_LICENSE
 - README.md
@@ -213,6 +214,7 @@ files:
 - bin/rails_best_practices
 - lib/rails_best_practices.rb
 - lib/rails_best_practices/analyzer.rb
+- lib/rails_best_practices/cli.rb
 - lib/rails_best_practices/colorize.rb
 - lib/rails_best_practices/command.rb
 - lib/rails_best_practices/core.rb
@@ -237,6 +239,7 @@ files:
 - lib/rails_best_practices/lexicals/long_line_check.rb
 - lib/rails_best_practices/lexicals/remove_tab_check.rb
 - lib/rails_best_practices/lexicals/remove_trailing_whitespace_check.rb
+- lib/rails_best_practices/option_parser.rb
 - lib/rails_best_practices/prepares.rb
 - lib/rails_best_practices/prepares/config_prepare.rb
 - lib/rails_best_practices/prepares/controller_prepare.rb
@@ -376,10 +379,6 @@ post_install_message: |
 
         http://rails-bestpractices.com
 
-    Please also try our online service
-
-        http://railsbp.com
-
     Enjoy!
 
         Richard Huang (flyerhzm@gmail.com)
@@ -400,9 +399,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: a code metric tool for rails codes.
 test_files: