rails_best_practices 1.19.2 → 1.20.1

data/spec/rails_best_practices/reviews/remove_unused_methods_in_models_review_spec.rb

@@ -5,13 +5,14 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe RemoveUnusedMethodsInModelsReview do
-      let(:runner) { Core::Runner.new(
-        prepares: Prepares::ModelPrepare.new,
-        reviews: RemoveUnusedMethodsInModelsReview.new('except_methods' => ['*#set_cache'])
-      ) }
+      let(:runner) do
+        Core::Runner.new(
+          prepares: Prepares::ModelPrepare.new, reviews: described_class.new('except_methods' => ['*#set_cache'])
+        )
+      end
 
       context 'private' do
-        it 'should remove unused methods' do
+        it 'removes unused methods' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def find; end
@@ -34,7 +35,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/models/post.rb:4 - remove unused methods (Post#find_by_sql)')
         end
 
-        it 'should not remove unused methods with except_methods' do
+        it 'does not remove unused methods with except_methods' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def set_cache; end
@@ -46,7 +47,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods with var_ref' do
+        it 'does not remove unused methods with var_ref' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def find
@@ -70,7 +71,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods with callback' do
+        it 'does not remove unused methods with callback' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             after_save :expire_cache
@@ -84,7 +85,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with command' do
+        it 'does not remove unused method with command' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def fetch
@@ -108,7 +109,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with call' do
+        it 'does not remove unused method with call' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def conditions
@@ -132,7 +133,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with message' do
+        it 'does not remove unused method with message' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def save
@@ -158,7 +159,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with validation condition' do
+        it 'does not remove unused method with validation condition' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             validates_uniqueness_of :login, if: :email_blank?
@@ -172,7 +173,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with aasm' do
+        it 'does not remove unused method with aasm' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             aasm_state :accepted, enter: [:update_datetime]
@@ -186,7 +187,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with initialize' do
+        it 'does not remove unused method with initialize' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             private
@@ -201,7 +202,7 @@ module RailsBestPractices
       end
 
       context 'public' do
-        it 'should remove unused methods' do
+        it 'removes unused methods' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def fetch; end
@@ -213,7 +214,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/models/post.rb:2 - remove unused methods (Post#fetch)')
         end
 
-        it 'should not remove unused methods' do
+        it 'does not remove unused methods' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def fetch; end
@@ -232,7 +233,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods for attribute assignment' do
+        it 'does not remove unused methods for attribute assignment' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def user=(user); end
@@ -244,7 +245,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods for try' do
+        it 'does not remove unused methods for try' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def find(user_id); end
@@ -264,7 +265,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods for send' do
+        it 'does not remove unused methods for send' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def find(user_id); end
@@ -284,7 +285,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should remove unused methods for send string_embexpre' do
+        it 'removes unused methods for send string_embexpre' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def find_first; end
@@ -305,7 +306,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(1)
         end
 
-        it 'should remove unused methods for send variable' do
+        it 'removes unused methods for send variable' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def first; end
@@ -328,7 +329,7 @@ module RailsBestPractices
       end
 
       context 'protected' do
-        it 'should not remove unused methods' do
+        it 'does not remove unused methods' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             protected
@@ -350,7 +351,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/models/post.rb:3 - remove unused methods (Post#test)')
         end
 
-        it 'should not remove unused methods' do
+        it 'does not remove unused methods' do
           post_content = <<-EOF
           class Post < ActiveRecord::Base
             protected
@@ -382,7 +383,7 @@ module RailsBestPractices
       end
 
       context 'named_scope' do
-        it 'should not remove unused named_scope' do
+        it 'does not remove unused named_scope' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             named_scope :active, conditions: {active: true}
@@ -402,7 +403,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should remove unused named_scope' do
+        it 'removes unused named_scope' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             named_scope :active, conditions: {active: true}
@@ -417,7 +418,7 @@ module RailsBestPractices
       end
 
       context 'scope' do
-        it 'should not remove unused scope' do
+        it 'does not remove unused scope' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             scope :active, where(active: true)
@@ -437,7 +438,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should remove unused named_scope' do
+        it 'removes unused named_scope' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             scope :active, where(active: true)
@@ -452,7 +453,7 @@ module RailsBestPractices
       end
 
       context 'alias' do
-        it 'should not remove unused method with alias' do
+        it 'does not remove unused method with alias' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def old; end
@@ -473,7 +474,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-         it 'should not remove unused method with symbol alias' do
+        it 'does not remove unused method with symbol alias' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def old; end
@@ -494,7 +495,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with alias_method' do
+        it 'does not remove unused method with alias_method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def old; end
@@ -515,7 +516,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with alias_method_chain' do
+        it 'does not remove unused method with alias_method_chain' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def method_with_feature; end
@@ -538,7 +539,7 @@ module RailsBestPractices
       end
 
       context 'methods hash' do
-        it 'should not remove unused method with methods hash' do
+        it 'does not remove unused method with methods hash' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def to_xml(options = {})
@@ -556,7 +557,7 @@ module RailsBestPractices
       end
 
       context 'callbacks' do
-        it 'should not remove unused method' do
+        it 'does not remove unused method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             before_save :init_columns
@@ -575,7 +576,7 @@ module RailsBestPractices
       end
 
       context 'validates' do
-        it 'should not remove unused method' do
+        it 'does not remove unused method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             validate :valid_birth_date
@@ -590,7 +591,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method for validate_on_create and validate_on_update' do
+        it 'does not remove unused method for validate_on_create and validate_on_update' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             validate_on_create :valid_email
@@ -607,7 +608,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods for to_param' do
+        it 'does not remove unused methods for to_param' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def to_param
@@ -623,7 +624,7 @@ module RailsBestPractices
       end
 
       context 'helper method' do
-        it 'should not remove unused method for coommand_call collection_select' do
+        it 'does not remove unused method for coommand_call collection_select' do
           content = <<-EOF
           class Category < ActiveRecord::Base
             def indented_name; end
@@ -639,7 +640,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method for command collection_select' do
+        it 'does not remove unused method for command collection_select' do
           content = <<-EOF
           class Category < ActiveRecord::Base
             def indented_name; end
@@ -655,7 +656,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method for options_from_collection_for_select' do
+        it 'does not remove unused method for options_from_collection_for_select' do
           content = <<-EOF
           class Category < ActiveRecord::Base
             def indented_name; end
@@ -672,7 +673,7 @@ module RailsBestPractices
         end
       end
 
-      it 'should not remove unused methods for rabl view' do
+      it 'does not remove unused methods for rabl view' do
         content = <<-EOF
         class User
           def first_name; end
@@ -691,7 +692,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not skip :call as call message' do
+      it 'does not skip :call as call message' do
         content = <<-EOF
         module DateRange
           RANGES = lambda {
@@ -706,29 +707,32 @@ module RailsBestPractices
         runner.review('app/mixins/date_range.rb', content)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(prepares: Prepares::ModelPrepare.new,
-                                  reviews: RemoveUnusedMethodsInModelsReview.new(except_methods: [], ignored_files: /post/))
+      it 'does not check ignored files' do
+        runner =
+          Core::Runner.new(
+            prepares: Prepares::ModelPrepare.new,
+            reviews: described_class.new(except_methods: [], ignored_files: /post/)
+          )
 
-          content = <<-EOF
+        content = <<-EOF
           class Post < ActiveRecord::Base
             def find; end
             private
             def find_by_sql; end
           end
-          EOF
-          runner.prepare('app/models/post.rb', content)
-          runner.review('app/models/post.rb', content)
-          content = <<-EOF
+        EOF
+        runner.prepare('app/models/post.rb', content)
+        runner.review('app/models/post.rb', content)
+        content = <<-EOF
           class PostsController < ApplicationController
             def get
               Post.new.find
             end
           end
-          EOF
-          runner.review('app/controllers/posts_controller.rb', content)
-          runner.after_review
-          expect(runner.errors.size).to eq(0)
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        runner.after_review
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe ReplaceComplexCreationWithFactoryMethodReview do
-      let(:runner) { Core::Runner.new(reviews: ReplaceComplexCreationWithFactoryMethodReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should replace complex creation with factory method' do
+      it 'replaces complex creation with factory method' do
         content = <<-EOF
         class InvoiceController < ApplicationController
           def create
@@ -28,10 +28,12 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/invoices_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/controllers/invoices_controller.rb:2 - replace complex creation with factory method (@invoice attribute_assignment_count > 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/controllers/invoices_controller.rb:2 - replace complex creation with factory method (@invoice attribute_assignment_count > 2)'
+        )
       end
 
-      it 'should not replace complex creation with factory method with simple creation' do
+      it 'does not replace complex creation with factory method with simple creation' do
         content = <<-EOF
         class InvoiceController < ApplicationController
           def create
@@ -46,7 +48,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not replace complex creation with factory method when attrasgn_count is 5' do
+      it 'does not replace complex creation with factory method when attrasgn_count is 5' do
         content = <<-EOF
         class InvoiceController < ApplicationController
           def create
@@ -65,13 +67,13 @@ module RailsBestPractices
           end
         end
         EOF
-        runner = Core::Runner.new(reviews: ReplaceComplexCreationWithFactoryMethodReview.new('attribute_assignment_count' => 5))
+        runner = Core::Runner.new(reviews: described_class.new('attribute_assignment_count' => 5))
         runner.review('app/controllers/invoices_controller.rb', content)
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: ReplaceComplexCreationWithFactoryMethodReview.new(ignored_files: /invoices_controller/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /invoices_controller/))
         content = <<-EOF
         class InvoiceController < ApplicationController
           def create

data/spec/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review_spec.rb

@@ -5,36 +5,42 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe ReplaceInstanceVariableWithLocalVariableReview do
-      let(:runner) { Core::Runner.new(reviews: ReplaceInstanceVariableWithLocalVariableReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should replace instance variable with local varialbe' do
+      it 'replaces instance variable with local varialbe' do
         content = <<-EOF
         <%= @post.title %>
         EOF
         runner.review('app/views/posts/_post.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/_post.html.erb:1 - replace instance variable with local variable')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/_post.html.erb:1 - replace instance variable with local variable'
+        )
       end
 
-      it 'should replace instance variable with local varialbe in haml file' do
-        content = <<-EOF
-= @post.title
+      it 'replaces instance variable with local varialbe in haml file' do
+        content = <<~EOF
+          = @post.title
         EOF
         runner.review('app/views/posts/_post.html.haml', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/_post.html.haml:1 - replace instance variable with local variable')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/_post.html.haml:1 - replace instance variable with local variable'
+        )
       end
 
-      it 'should replace instance variable with local varialbe in slim file' do
-        content = <<-EOF
-= @post.title
+      it 'replaces instance variable with local varialbe in slim file' do
+        content = <<~EOF
+          = @post.title
         EOF
         runner.review('app/views/posts/_post.html.slim', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/_post.html.slim:1 - replace instance variable with local variable')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/_post.html.slim:1 - replace instance variable with local variable'
+        )
       end
 
-      it 'should not replace instance variable with local varialbe' do
+      it 'does not replace instance variable with local varialbe' do
         content = <<-EOF
         <%= post.title %>
         EOF
@@ -42,8 +48,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: ReplaceInstanceVariableWithLocalVariableReview.new(ignored_files: /views\/posts/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{views/posts}))
         content = <<-EOF
         <%= @post.title %>
         EOF