puppet 6.0.7-universal-darwin → 6.0.8-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +4 -8
  4. data/lib/puppet/application/device.rb +99 -83
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/configurer.rb +5 -4
  7. data/lib/puppet/defaults.rb +31 -11
  8. data/lib/puppet/indirector/request.rb +26 -15
  9. data/lib/puppet/network/http/connection.rb +15 -7
  10. data/lib/puppet/transaction/event_manager.rb +1 -5
  11. data/lib/puppet/type/file/source.rb +0 -1
  12. data/lib/puppet/util/connection.rb +15 -6
  13. data/lib/puppet/util/http_proxy.rb +3 -2
  14. data/lib/puppet/version.rb +1 -1
  15. data/locales/puppet.pot +99 -40
  16. data/man/man5/puppet.conf.5 +8 -8
  17. data/man/man8/puppet-agent.8 +1 -1
  18. data/man/man8/puppet-apply.8 +1 -1
  19. data/man/man8/puppet-catalog.8 +1 -1
  20. data/man/man8/puppet-config.8 +1 -1
  21. data/man/man8/puppet-describe.8 +1 -1
  22. data/man/man8/puppet-device.8 +1 -1
  23. data/man/man8/puppet-doc.8 +1 -1
  24. data/man/man8/puppet-epp.8 +1 -1
  25. data/man/man8/puppet-facts.8 +1 -1
  26. data/man/man8/puppet-filebucket.8 +1 -1
  27. data/man/man8/puppet-generate.8 +1 -1
  28. data/man/man8/puppet-help.8 +1 -1
  29. data/man/man8/puppet-key.8 +1 -1
  30. data/man/man8/puppet-lookup.8 +1 -1
  31. data/man/man8/puppet-man.8 +1 -1
  32. data/man/man8/puppet-module.8 +1 -1
  33. data/man/man8/puppet-node.8 +1 -1
  34. data/man/man8/puppet-parser.8 +1 -1
  35. data/man/man8/puppet-plugin.8 +1 -1
  36. data/man/man8/puppet-report.8 +1 -1
  37. data/man/man8/puppet-resource.8 +1 -1
  38. data/man/man8/puppet-script.8 +1 -1
  39. data/man/man8/puppet-ssl.8 +1 -1
  40. data/man/man8/puppet-status.8 +1 -1
  41. data/man/man8/puppet.8 +2 -2
  42. data/spec/integration/agent/logging_spec.rb +5 -7
  43. data/spec/integration/application/apply_spec.rb +18 -16
  44. data/spec/integration/application/doc_spec.rb +1 -2
  45. data/spec/integration/application/lookup_spec.rb +5 -5
  46. data/spec/integration/configurer_spec.rb +5 -6
  47. data/spec/integration/defaults_spec.rb +5 -6
  48. data/spec/integration/directory_environments_spec.rb +1 -1
  49. data/spec/integration/faces/config_spec.rb +3 -4
  50. data/spec/integration/faces/documentation_spec.rb +0 -1
  51. data/spec/integration/faces/plugin_spec.rb +1 -1
  52. data/spec/integration/file_bucket/file_spec.rb +2 -4
  53. data/spec/integration/file_serving/content_spec.rb +0 -1
  54. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  55. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  56. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  57. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  58. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  59. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  60. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  61. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  62. data/spec/integration/network/authconfig_spec.rb +23 -24
  63. data/spec/integration/network/formats_spec.rb +0 -1
  64. data/spec/integration/node/environment_spec.rb +0 -1
  65. data/spec/integration/node/facts_spec.rb +9 -10
  66. data/spec/integration/node_spec.rb +6 -7
  67. data/spec/integration/parser/catalog_spec.rb +1 -5
  68. data/spec/integration/parser/collection_spec.rb +1 -2
  69. data/spec/integration/parser/compiler_spec.rb +6 -6
  70. data/spec/integration/parser/scope_spec.rb +1 -1
  71. data/spec/integration/parser/undef_param_spec.rb +1 -1
  72. data/spec/integration/provider/service/init_spec.rb +4 -5
  73. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  74. data/spec/integration/provider/service/windows_spec.rb +1 -2
  75. data/spec/integration/reference/providers_spec.rb +1 -2
  76. data/spec/integration/reports_spec.rb +1 -2
  77. data/spec/integration/resource/catalog_spec.rb +14 -17
  78. data/spec/integration/resource/type_collection_spec.rb +4 -5
  79. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  80. data/spec/integration/ssl/host_spec.rb +1 -2
  81. data/spec/integration/ssl/key_spec.rb +0 -1
  82. data/spec/integration/test/test_helper_spec.rb +0 -1
  83. data/spec/integration/transaction/report_spec.rb +6 -11
  84. data/spec/integration/transaction_spec.rb +18 -19
  85. data/spec/integration/type/exec_spec.rb +0 -1
  86. data/spec/integration/type/file_spec.rb +13 -14
  87. data/spec/integration/type/package_spec.rb +19 -23
  88. data/spec/integration/type/tidy_spec.rb +1 -2
  89. data/spec/integration/type_spec.rb +0 -1
  90. data/spec/integration/util/autoload_spec.rb +1 -2
  91. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  92. data/spec/integration/util/settings_spec.rb +0 -1
  93. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  94. data/spec/integration/util/windows/principal_spec.rb +0 -1
  95. data/spec/integration/util/windows/process_spec.rb +4 -6
  96. data/spec/integration/util/windows/registry_spec.rb +41 -51
  97. data/spec/integration/util/windows/security_spec.rb +2 -4
  98. data/spec/integration/util/windows/user_spec.rb +18 -20
  99. data/spec/integration/util_spec.rb +4 -7
  100. data/spec/lib/puppet_spec/compiler.rb +1 -1
  101. data/spec/lib/puppet_spec/files.rb +0 -1
  102. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  103. data/spec/lib/puppet_spec/scope.rb +1 -2
  104. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  105. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  106. data/spec/shared_behaviours/file_serving.rb +6 -8
  107. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  108. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  109. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  110. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  111. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  112. data/spec/spec_helper.rb +10 -1
  113. data/spec/unit/agent/disabler_spec.rb +4 -5
  114. data/spec/unit/agent/locker_spec.rb +12 -13
  115. data/spec/unit/agent_spec.rb +80 -85
  116. data/spec/unit/application/agent_spec.rb +88 -93
  117. data/spec/unit/application/apply_spec.rb +82 -83
  118. data/spec/unit/application/config_spec.rb +0 -1
  119. data/spec/unit/application/describe_spec.rb +6 -7
  120. data/spec/unit/application/device_spec.rb +395 -419
  121. data/spec/unit/application/doc_spec.rb +44 -46
  122. data/spec/unit/application/face_base_spec.rb +61 -62
  123. data/spec/unit/application/facts_spec.rb +3 -4
  124. data/spec/unit/application/filebucket_spec.rb +66 -74
  125. data/spec/unit/application/indirection_base_spec.rb +8 -6
  126. data/spec/unit/application/lookup_spec.rb +26 -26
  127. data/spec/unit/application/resource_spec.rb +42 -48
  128. data/spec/unit/application/ssl_spec.rb +3 -3
  129. data/spec/unit/application_spec.rb +82 -92
  130. data/spec/unit/capability_spec.rb +6 -6
  131. data/spec/unit/certificate_factory_spec.rb +3 -5
  132. data/spec/unit/configurer/downloader_spec.rb +20 -21
  133. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  134. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  135. data/spec/unit/configurer_spec.rb +189 -192
  136. data/spec/unit/confine/exists_spec.rb +17 -15
  137. data/spec/unit/confine/false_spec.rb +5 -6
  138. data/spec/unit/confine/feature_spec.rb +7 -5
  139. data/spec/unit/confine/true_spec.rb +5 -6
  140. data/spec/unit/confine/variable_spec.rb +14 -15
  141. data/spec/unit/confine_collection_spec.rb +28 -29
  142. data/spec/unit/confine_spec.rb +13 -14
  143. data/spec/unit/confiner_spec.rb +10 -11
  144. data/spec/unit/context/trusted_information_spec.rb +1 -1
  145. data/spec/unit/daemon_spec.rb +35 -36
  146. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  147. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  148. data/spec/unit/datatypes_spec.rb +3 -4
  149. data/spec/unit/defaults_spec.rb +18 -13
  150. data/spec/unit/environments_spec.rb +7 -7
  151. data/spec/unit/etc_spec.rb +30 -32
  152. data/spec/unit/external/pson_spec.rb +0 -1
  153. data/spec/unit/face/catalog_spec.rb +0 -1
  154. data/spec/unit/face/config_spec.rb +31 -35
  155. data/spec/unit/face/epp_face_spec.rb +3 -4
  156. data/spec/unit/face/facts_spec.rb +5 -6
  157. data/spec/unit/face/generate_spec.rb +4 -5
  158. data/spec/unit/face/help_spec.rb +7 -8
  159. data/spec/unit/face/key_spec.rb +0 -1
  160. data/spec/unit/face/man_spec.rb +1 -2
  161. data/spec/unit/face/module/install_spec.rb +3 -5
  162. data/spec/unit/face/module/list_spec.rb +2 -12
  163. data/spec/unit/face/module/search_spec.rb +11 -9
  164. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  165. data/spec/unit/face/node_spec.rb +23 -24
  166. data/spec/unit/face/parser_spec.rb +3 -3
  167. data/spec/unit/face/plugin_spec.rb +36 -9
  168. data/spec/unit/face/status_spec.rb +0 -1
  169. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  170. data/spec/unit/file_bucket/file_spec.rb +0 -2
  171. data/spec/unit/file_serving/base_spec.rb +14 -15
  172. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  173. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  174. data/spec/unit/file_serving/content_spec.rb +10 -11
  175. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  176. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  177. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  178. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  179. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  180. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  181. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  182. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  183. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  184. data/spec/unit/file_serving/mount_spec.rb +0 -1
  185. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  186. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  187. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  188. data/spec/unit/file_system_spec.rb +2 -2
  189. data/spec/unit/forge/errors_spec.rb +1 -1
  190. data/spec/unit/forge/forge_spec.rb +13 -14
  191. data/spec/unit/forge/module_release_spec.rb +18 -18
  192. data/spec/unit/forge/repository_spec.rb +29 -30
  193. data/spec/unit/forge_spec.rb +15 -11
  194. data/spec/unit/functions/binary_file_spec.rb +3 -3
  195. data/spec/unit/functions/contain_spec.rb +0 -2
  196. data/spec/unit/functions/defined_spec.rb +0 -1
  197. data/spec/unit/functions/epp_spec.rb +2 -2
  198. data/spec/unit/functions/find_file_spec.rb +7 -7
  199. data/spec/unit/functions/include_spec.rb +0 -4
  200. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  201. data/spec/unit/functions/lookup_spec.rb +1 -2
  202. data/spec/unit/functions/module_directory_spec.rb +12 -12
  203. data/spec/unit/functions/require_spec.rb +0 -3
  204. data/spec/unit/functions/shared.rb +5 -8
  205. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  206. data/spec/unit/functions4_spec.rb +9 -10
  207. data/spec/unit/gettext/config_spec.rb +4 -4
  208. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  209. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  210. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  211. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  212. data/spec/unit/hiera_puppet_spec.rb +20 -20
  213. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  214. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  215. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  216. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  217. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  218. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  219. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  220. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  221. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  222. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  223. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  224. data/spec/unit/indirector/envelope_spec.rb +1 -2
  225. data/spec/unit/indirector/exec_spec.rb +4 -5
  226. data/spec/unit/indirector/face_spec.rb +9 -9
  227. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  228. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  229. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  230. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  231. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  232. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  233. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  234. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  235. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  236. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  237. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  238. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  239. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  240. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  241. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  242. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  243. data/spec/unit/indirector/file_server_spec.rb +87 -87
  244. data/spec/unit/indirector/indirection_spec.rb +242 -226
  245. data/spec/unit/indirector/json_spec.rb +7 -9
  246. data/spec/unit/indirector/key/file_spec.rb +21 -22
  247. data/spec/unit/indirector/memory_spec.rb +6 -7
  248. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  249. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  250. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  251. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  252. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  253. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  254. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  255. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  256. data/spec/unit/indirector/none_spec.rb +5 -5
  257. data/spec/unit/indirector/plain_spec.rb +7 -8
  258. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  259. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  260. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  261. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  262. data/spec/unit/indirector/request_spec.rb +11 -12
  263. data/spec/unit/indirector/resource/ral_spec.rb +46 -54
  264. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  265. data/spec/unit/indirector/rest_spec.rb +113 -110
  266. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  267. data/spec/unit/indirector/status/local_spec.rb +0 -1
  268. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  269. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  270. data/spec/unit/indirector/terminus_spec.rb +27 -27
  271. data/spec/unit/indirector/yaml_spec.rb +5 -6
  272. data/spec/unit/indirector_spec.rb +1 -2
  273. data/spec/unit/info_service_spec.rb +1 -1
  274. data/spec/unit/interface/action_builder_spec.rb +0 -1
  275. data/spec/unit/interface/action_manager_spec.rb +0 -1
  276. data/spec/unit/interface/action_spec.rb +2 -3
  277. data/spec/unit/interface/documentation_spec.rb +0 -1
  278. data/spec/unit/interface/face_collection_spec.rb +19 -12
  279. data/spec/unit/interface_spec.rb +3 -3
  280. data/spec/unit/man_spec.rb +3 -4
  281. data/spec/unit/module_spec.rb +46 -51
  282. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  283. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  284. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  285. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  286. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  287. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  288. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  289. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  290. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  291. data/spec/unit/module_tool/tar_spec.rb +12 -13
  292. data/spec/unit/module_tool_spec.rb +7 -12
  293. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  294. data/spec/unit/network/authconfig_spec.rb +17 -18
  295. data/spec/unit/network/authorization_spec.rb +4 -5
  296. data/spec/unit/network/authstore_spec.rb +0 -1
  297. data/spec/unit/network/format_handler_spec.rb +0 -1
  298. data/spec/unit/network/format_spec.rb +9 -10
  299. data/spec/unit/network/format_support_spec.rb +28 -29
  300. data/spec/unit/network/formats_spec.rb +4 -5
  301. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  302. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  303. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  304. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  305. data/spec/unit/network/http/api_spec.rb +0 -2
  306. data/spec/unit/network/http/compression_spec.rb +21 -22
  307. data/spec/unit/network/http/connection_spec.rb +41 -36
  308. data/spec/unit/network/http/factory_spec.rb +5 -6
  309. data/spec/unit/network/http/handler_spec.rb +9 -18
  310. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  311. data/spec/unit/network/http/pool_spec.rb +28 -29
  312. data/spec/unit/network/http/request_spec.rb +0 -2
  313. data/spec/unit/network/http/response_spec.rb +11 -13
  314. data/spec/unit/network/http/route_spec.rb +0 -1
  315. data/spec/unit/network/http/session_spec.rb +1 -2
  316. data/spec/unit/network/http/site_spec.rb +0 -1
  317. data/spec/unit/network/http_pool_spec.rb +18 -9
  318. data/spec/unit/network/http_spec.rb +0 -1
  319. data/spec/unit/network/resolver_spec.rb +25 -26
  320. data/spec/unit/network/rights_spec.rb +52 -53
  321. data/spec/unit/node/environment_spec.rb +14 -15
  322. data/spec/unit/node/facts_spec.rb +5 -7
  323. data/spec/unit/node_spec.rb +4 -10
  324. data/spec/unit/other/selinux_spec.rb +0 -1
  325. data/spec/unit/parameter/boolean_spec.rb +1 -2
  326. data/spec/unit/parameter/package_options_spec.rb +1 -2
  327. data/spec/unit/parameter/path_spec.rb +0 -1
  328. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  329. data/spec/unit/parameter/value_spec.rb +0 -1
  330. data/spec/unit/parameter_spec.rb +9 -9
  331. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  332. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  333. data/spec/unit/parser/compiler_spec.rb +84 -96
  334. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  335. data/spec/unit/parser/files_spec.rb +0 -1
  336. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  337. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  338. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  339. data/spec/unit/parser/functions/file_spec.rb +13 -14
  340. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  341. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  342. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  343. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  344. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  345. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  346. data/spec/unit/parser/functions/split_spec.rb +0 -1
  347. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  348. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  349. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  350. data/spec/unit/parser/functions/template_spec.rb +13 -13
  351. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  352. data/spec/unit/parser/functions_spec.rb +6 -7
  353. data/spec/unit/parser/relationship_spec.rb +0 -1
  354. data/spec/unit/parser/resource_spec.rb +42 -42
  355. data/spec/unit/parser/scope_spec.rb +39 -35
  356. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  357. data/spec/unit/parser/type_loader_spec.rb +17 -19
  358. data/spec/unit/pops/adaptable_spec.rb +0 -1
  359. data/spec/unit/pops/benchmark_spec.rb +0 -1
  360. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  361. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  362. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  363. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  364. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  365. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  366. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  367. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  368. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  371. data/spec/unit/pops/factory_spec.rb +3 -4
  372. data/spec/unit/pops/issues_spec.rb +19 -20
  373. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  374. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  375. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  376. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  377. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  378. data/spec/unit/pops/migration_spec.rb +3 -5
  379. data/spec/unit/pops/model/model_spec.rb +0 -1
  380. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  381. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  382. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  383. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  384. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  385. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  386. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  387. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  388. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  389. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  390. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  391. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  392. data/spec/unit/pops/pn_spec.rb +0 -1
  393. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  394. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  395. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  396. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  397. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  398. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  399. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  400. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  401. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  402. data/spec/unit/pops/visitor_spec.rb +0 -1
  403. data/spec/unit/property/boolean_spec.rb +1 -1
  404. data/spec/unit/property/ensure_spec.rb +0 -1
  405. data/spec/unit/property/keyvalue_spec.rb +32 -34
  406. data/spec/unit/property/list_spec.rb +26 -27
  407. data/spec/unit/property/ordered_list_spec.rb +10 -14
  408. data/spec/unit/property_spec.rb +42 -43
  409. data/spec/unit/provider/aix_object_spec.rb +47 -45
  410. data/spec/unit/provider/command_spec.rb +9 -9
  411. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  412. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  413. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  414. data/spec/unit/provider/exec_spec.rb +0 -1
  415. data/spec/unit/provider/file/posix_spec.rb +22 -24
  416. data/spec/unit/provider/file/windows_spec.rb +15 -17
  417. data/spec/unit/provider/group/aix_spec.rb +3 -2
  418. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  419. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  420. data/spec/unit/provider/group/pw_spec.rb +11 -11
  421. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  422. data/spec/unit/provider/ldap_spec.rb +61 -62
  423. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  424. data/spec/unit/provider/nameservice_spec.rb +38 -40
  425. data/spec/unit/provider/package/aix_spec.rb +15 -15
  426. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  427. data/spec/unit/provider/package/apt_spec.rb +44 -27
  428. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  429. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  430. data/spec/unit/provider/package/base_spec.rb +4 -4
  431. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  432. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  433. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  434. data/spec/unit/provider/package/gem_spec.rb +51 -43
  435. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  436. data/spec/unit/provider/package/macports_spec.rb +46 -42
  437. data/spec/unit/provider/package/nim_spec.rb +30 -39
  438. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  439. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  440. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  441. data/spec/unit/provider/package/pip_spec.rb +71 -72
  442. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  443. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  444. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  445. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  446. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  447. data/spec/unit/provider/package/portage_spec.rb +70 -74
  448. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  449. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  450. data/spec/unit/provider/package/sun_spec.rb +16 -18
  451. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  452. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  453. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  454. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  455. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  456. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  457. data/spec/unit/provider/package/windows_spec.rb +36 -32
  458. data/spec/unit/provider/package/yum_spec.rb +7 -7
  459. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  460. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  461. data/spec/unit/provider/service/base_spec.rb +4 -5
  462. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  463. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  464. data/spec/unit/provider/service/debian_spec.rb +38 -38
  465. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  466. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  467. data/spec/unit/provider/service/init_spec.rb +53 -52
  468. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  469. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  470. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  471. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  472. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  473. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  474. data/spec/unit/provider/service/runit_spec.rb +29 -27
  475. data/spec/unit/provider/service/smf_spec.rb +74 -66
  476. data/spec/unit/provider/service/src_spec.rb +46 -47
  477. data/spec/unit/provider/service/systemd_spec.rb +104 -113
  478. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  479. data/spec/unit/provider/service/windows_spec.rb +33 -41
  480. data/spec/unit/provider/user/aix_spec.rb +31 -31
  481. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  482. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  483. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  484. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  485. data/spec/unit/provider/user/pw_spec.rb +37 -35
  486. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  487. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  488. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  489. data/spec/unit/provider_spec.rb +35 -35
  490. data/spec/unit/puppet_pal_2pec.rb +4 -5
  491. data/spec/unit/puppet_pal_spec.rb +0 -1
  492. data/spec/unit/puppet_spec.rb +6 -7
  493. data/spec/unit/relationship_spec.rb +0 -1
  494. data/spec/unit/reports/http_spec.rb +21 -23
  495. data/spec/unit/reports/store_spec.rb +3 -4
  496. data/spec/unit/reports_spec.rb +12 -14
  497. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  498. data/spec/unit/resource/catalog_spec.rb +72 -68
  499. data/spec/unit/resource/status_spec.rb +6 -8
  500. data/spec/unit/resource/type_collection_spec.rb +17 -18
  501. data/spec/unit/resource/type_spec.rb +34 -35
  502. data/spec/unit/resource_spec.rb +36 -32
  503. data/spec/unit/rest/client_spec.rb +58 -27
  504. data/spec/unit/rest/route_spec.rb +5 -5
  505. data/spec/unit/scheduler/job_spec.rb +0 -1
  506. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  507. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  508. data/spec/unit/settings/array_setting_spec.rb +1 -1
  509. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  510. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  511. data/spec/unit/settings/config_file_spec.rb +0 -1
  512. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  513. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  514. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  515. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  516. data/spec/unit/settings/file_setting_spec.rb +44 -46
  517. data/spec/unit/settings/path_setting_spec.rb +1 -2
  518. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  519. data/spec/unit/settings/string_setting_spec.rb +14 -15
  520. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  521. data/spec/unit/settings/value_translator_spec.rb +0 -1
  522. data/spec/unit/settings_spec.rb +228 -235
  523. data/spec/unit/ssl/base_spec.rb +14 -15
  524. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  525. data/spec/unit/ssl/certificate_spec.rb +23 -25
  526. data/spec/unit/ssl/digest_spec.rb +0 -1
  527. data/spec/unit/ssl/host_spec.rb +166 -149
  528. data/spec/unit/ssl/key_spec.rb +30 -31
  529. data/spec/unit/ssl/validator_spec.rb +38 -39
  530. data/spec/unit/task_spec.rb +44 -45
  531. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  532. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  533. data/spec/unit/transaction/event_spec.rb +16 -15
  534. data/spec/unit/transaction/persistence_spec.rb +16 -17
  535. data/spec/unit/transaction/report_spec.rb +11 -12
  536. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  537. data/spec/unit/transaction_spec.rb +100 -101
  538. data/spec/unit/type/component_spec.rb +0 -1
  539. data/spec/unit/type/exec_spec.rb +60 -56
  540. data/spec/unit/type/file/checksum_spec.rb +9 -10
  541. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  542. data/spec/unit/type/file/content_spec.rb +58 -61
  543. data/spec/unit/type/file/ctime_spec.rb +0 -1
  544. data/spec/unit/type/file/ensure_spec.rb +12 -13
  545. data/spec/unit/type/file/group_spec.rb +5 -7
  546. data/spec/unit/type/file/mode_spec.rb +4 -6
  547. data/spec/unit/type/file/mtime_spec.rb +0 -1
  548. data/spec/unit/type/file/owner_spec.rb +6 -8
  549. data/spec/unit/type/file/selinux_spec.rb +17 -19
  550. data/spec/unit/type/file/source_spec.rb +104 -101
  551. data/spec/unit/type/file/type_spec.rb +0 -1
  552. data/spec/unit/type/file_spec.rb +195 -185
  553. data/spec/unit/type/filebucket_spec.rb +4 -5
  554. data/spec/unit/type/group_spec.rb +6 -8
  555. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  556. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  557. data/spec/unit/type/package_spec.rb +56 -57
  558. data/spec/unit/type/resources_spec.rb +72 -74
  559. data/spec/unit/type/schedule_spec.rb +24 -26
  560. data/spec/unit/type/service_spec.rb +48 -48
  561. data/spec/unit/type/stage_spec.rb +0 -1
  562. data/spec/unit/type/tidy_spec.rb +61 -62
  563. data/spec/unit/type/user_spec.rb +24 -25
  564. data/spec/unit/type/whit_spec.rb +0 -1
  565. data/spec/unit/type_spec.rb +55 -54
  566. data/spec/unit/util/at_fork_spec.rb +18 -19
  567. data/spec/unit/util/autoload_spec.rb +55 -56
  568. data/spec/unit/util/backups_spec.rb +34 -35
  569. data/spec/unit/util/character_encoding_spec.rb +5 -5
  570. data/spec/unit/util/checksums_spec.rb +38 -39
  571. data/spec/unit/util/colors_spec.rb +1 -2
  572. data/spec/unit/util/command_line_spec.rb +24 -25
  573. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  574. data/spec/unit/util/diff_spec.rb +7 -8
  575. data/spec/unit/util/errors_spec.rb +0 -1
  576. data/spec/unit/util/execution_spec.rb +185 -161
  577. data/spec/unit/util/execution_stub_spec.rb +0 -1
  578. data/spec/unit/util/feature_spec.rb +21 -14
  579. data/spec/unit/util/filetype_spec.rb +49 -49
  580. data/spec/unit/util/http_proxy_spec.rb +12 -12
  581. data/spec/unit/util/inifile_spec.rb +26 -31
  582. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  583. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  584. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  585. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  586. data/spec/unit/util/lockfile_spec.rb +0 -1
  587. data/spec/unit/util/log/destinations_spec.rb +30 -33
  588. data/spec/unit/util/log_spec.rb +35 -36
  589. data/spec/unit/util/logging_spec.rb +58 -72
  590. data/spec/unit/util/metric_spec.rb +0 -1
  591. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  592. data/spec/unit/util/multi_match_spec.rb +0 -1
  593. data/spec/unit/util/network_device/config_spec.rb +0 -1
  594. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  595. data/spec/unit/util/network_device_spec.rb +7 -9
  596. data/spec/unit/util/package_spec.rb +0 -1
  597. data/spec/unit/util/pidlock_spec.rb +21 -22
  598. data/spec/unit/util/plist_spec.rb +40 -33
  599. data/spec/unit/util/posix_spec.rb +54 -51
  600. data/spec/unit/util/rdoc_spec.rb +9 -10
  601. data/spec/unit/util/reference_spec.rb +0 -1
  602. data/spec/unit/util/resource_template_spec.rb +20 -20
  603. data/spec/unit/util/retry_action_spec.rb +7 -8
  604. data/spec/unit/util/rubygems_spec.rb +7 -8
  605. data/spec/unit/util/run_mode_spec.rb +3 -4
  606. data/spec/unit/util/selinux_spec.rb +79 -72
  607. data/spec/unit/util/splayer_spec.rb +8 -9
  608. data/spec/unit/util/ssl_spec.rb +0 -1
  609. data/spec/unit/util/storage_spec.rb +3 -4
  610. data/spec/unit/util/suidmanager_spec.rb +45 -54
  611. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  612. data/spec/unit/util/tag_set_spec.rb +0 -1
  613. data/spec/unit/util/tagging_spec.rb +0 -1
  614. data/spec/unit/util/terminal_spec.rb +9 -10
  615. data/spec/unit/util/user_attr_spec.rb +1 -2
  616. data/spec/unit/util/warnings_spec.rb +3 -4
  617. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  618. data/spec/unit/util/watcher_spec.rb +51 -21
  619. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  620. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  621. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  622. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  623. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  624. data/spec/unit/util/windows/file_spec.rb +0 -1
  625. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  626. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  627. data/spec/unit/util/windows/service_spec.rb +66 -68
  628. data/spec/unit/util/windows/sid_spec.rb +11 -13
  629. data/spec/unit/util/windows/string_spec.rb +0 -1
  630. data/spec/unit/util_spec.rb +55 -57
  631. data/spec/unit/version_spec.rb +6 -6
  632. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe 'Puppet::Util::AtFork' do
@@ -19,7 +18,7 @@ describe 'Puppet::Util::AtFork' do
19
18
  describe '.get_handler' do
20
19
  context 'when on Solaris' do
21
20
  before :each do
22
- Facter.expects(:value).with(:operatingsystem).returns('Solaris')
21
+ expect(Facter).to receive(:value).with(:operatingsystem).and_return('Solaris')
23
22
  end
24
23
 
25
24
  after :each do
@@ -29,7 +28,7 @@ describe 'Puppet::Util::AtFork' do
29
28
  end
30
29
 
31
30
  def stub_solaris_handler(stub_noop_too = false)
32
- Puppet::Util::AtFork.stubs(:require).with() do |lib|
31
+ allow(Puppet::Util::AtFork).to receive(:require).with(anything) do |lib|
33
32
  if lib == 'puppet/util/at_fork/solaris'
34
33
  load lib + '.rb'
35
34
  true
@@ -41,7 +40,7 @@ describe 'Puppet::Util::AtFork' do
41
40
  else
42
41
  false
43
42
  end
44
- end.returns(true)
43
+ end.and_return(true)
45
44
 
46
45
  unless stub_noop_too
47
46
  Object.class_exec do
@@ -56,18 +55,18 @@ describe 'Puppet::Util::AtFork' do
56
55
  end
57
56
  end
58
57
 
59
- TOPLEVEL_BINDING.eval('self').stubs(:require).with() do |lib|
58
+ allow(TOPLEVEL_BINDING.eval('self')).to receive(:require).with(anything) do |lib|
60
59
  if lib == 'fiddle'
61
60
  raise LoadError, 'no fiddle' if stub_noop_too
62
61
  else
63
62
  Kernel.require lib
64
63
  end
65
64
  true
66
- end.returns(true)
65
+ end.and_return(true)
67
66
  end
68
67
 
69
68
  it %q(should return the Solaris specific AtFork handler) do
70
- Puppet::Util::AtFork.stubs(:require).with() do |lib|
69
+ allow(Puppet::Util::AtFork).to receive(:require).with(anything) do |lib|
71
70
  if lib == 'puppet/util/at_fork/solaris'
72
71
  Puppet::Util::AtFork.class_exec do
73
72
  const_set(:Solaris, Class.new)
@@ -76,7 +75,7 @@ describe 'Puppet::Util::AtFork' do
76
75
  else
77
76
  false
78
77
  end
79
- end.returns(true)
78
+ end.and_return(true)
80
79
  load 'puppet/util/at_fork.rb'
81
80
  expect(Puppet::Util::AtFork.get_handler.class).to eq(Puppet::Util::AtFork::Solaris)
82
81
  end
@@ -89,24 +88,24 @@ describe 'Puppet::Util::AtFork' do
89
88
 
90
89
  it %q(should fail when libcontract cannot be loaded) do
91
90
  stub_solaris_handler
92
- Fiddle::Handle.expects(:new).with(regexp_matches(/^libcontract.so.*/)).raises(Fiddle::DLError, 'no such library')
91
+ expect(Fiddle::Handle).to receive(:new).with(/^libcontract.so.*/).and_raise(Fiddle::DLError, 'no such library')
93
92
  expect { load 'puppet/util/at_fork.rb' }.to raise_error(Fiddle::DLError, 'no such library')
94
93
  end
95
94
 
96
95
  it %q(should fail when libcontract doesn't define all the necessary functions) do
97
96
  stub_solaris_handler
98
- handle = stub('Fiddle::Handle')
99
- Fiddle::Handle.expects(:new).with(regexp_matches(/^libcontract.so.*/)).returns(handle)
100
- handle.expects(:[]).raises(Fiddle::DLError, 'no such method')
97
+ handle = double('Fiddle::Handle')
98
+ expect(Fiddle::Handle).to receive(:new).with(/^libcontract.so.*/).and_return(handle)
99
+ expect(handle).to receive(:[]).and_raise(Fiddle::DLError, 'no such method')
101
100
  expect { load 'puppet/util/at_fork.rb' }.to raise_error(Fiddle::DLError, 'no such method')
102
101
  end
103
102
 
104
103
  it %q(the returned Solaris specific handler should respond to the expected methods) do
105
104
  stub_solaris_handler
106
- handle = stub('Fiddle::Handle')
107
- Fiddle::Handle.expects(:new).with(regexp_matches(/^libcontract.so.*/)).returns(handle)
108
- handle.stubs(:[]).returns(nil)
109
- Fiddle::Function.stubs(:new).returns(Proc.new {})
105
+ handle = double('Fiddle::Handle')
106
+ expect(Fiddle::Handle).to receive(:new).with(/^libcontract.so.*/).and_return(handle)
107
+ allow(handle).to receive(:[]).and_return(nil)
108
+ allow(Fiddle::Function).to receive(:new).and_return(Proc.new {})
110
109
  load 'puppet/util/at_fork.rb'
111
110
  expect(Puppet::Util::AtFork.get_handler.public_methods).to include(*EXPECTED_HANDLER_METHODS)
112
111
  end
@@ -114,11 +113,11 @@ describe 'Puppet::Util::AtFork' do
114
113
 
115
114
  context 'when NOT on Solaris' do
116
115
  before :each do
117
- Facter.expects(:value).with(:operatingsystem).returns(nil)
116
+ expect(Facter).to receive(:value).with(:operatingsystem).and_return(nil)
118
117
  end
119
118
 
120
119
  def stub_noop_handler(namespace_only = false)
121
- Puppet::Util::AtFork.stubs(:require).with() do |lib|
120
+ allow(Puppet::Util::AtFork).to receive(:require).with(anything) do |lib|
122
121
  if lib == 'puppet/util/at_fork/noop'
123
122
  if namespace_only
124
123
  Puppet::Util::AtFork.class_exec do
@@ -131,7 +130,7 @@ describe 'Puppet::Util::AtFork' do
131
130
  else
132
131
  false
133
132
  end
134
- end.returns(true)
133
+ end.and_return(true)
135
134
  end
136
135
 
137
136
  it %q(should return the Noop AtFork handler) do
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'fileutils'
4
3
 
@@ -13,13 +12,13 @@ describe Puppet::Util::Autoload do
13
12
  @autoload = Puppet::Util::Autoload.new("foo", "tmp")
14
13
 
15
14
  @loaded = {}
16
- @autoload.class.stubs(:loaded).returns(@loaded)
15
+ allow(@autoload.class).to receive(:loaded).and_return(@loaded)
17
16
  end
18
17
 
19
18
  describe "when building the search path" do
20
19
  before :each do
21
20
  ## modulepath/libdir can't be used until after app settings are initialized, so we need to simulate that:
22
- Puppet.settings.stubs(:app_defaults_initialized?).returns(true)
21
+ allow(Puppet.settings).to receive(:app_defaults_initialized?).and_return(true)
23
22
  end
24
23
 
25
24
  def with_libdir(libdir)
@@ -86,8 +85,8 @@ describe Puppet::Util::Autoload do
86
85
  Puppet[:vendormoduledir] = vendor_dir
87
86
 
88
87
  with_libdir(libdir) do
89
- @autoload.class.expects(:gem_directories).returns %w{/one /two}
90
- @autoload.class.expects(:module_directories).returns %w{/three /four}
88
+ expect(@autoload.class).to receive(:gem_directories).and_return(%w{/one /two})
89
+ expect(@autoload.class).to receive(:module_directories).and_return(%w{/three /four})
91
90
  dirs = @autoload.class.search_directories(nil)
92
91
  expect(dirs[0..4]).to eq(%w{/one /two /three /four} + [libdir])
93
92
  expect(dirs.last).to eq(module_libdir)
@@ -97,8 +96,8 @@ describe Puppet::Util::Autoload do
97
96
  it "does not split the Puppet[:libdir]" do
98
97
  dir = File.expand_path("/libdir1#{File::PATH_SEPARATOR}/libdir2")
99
98
  with_libdir(dir) do
100
- @autoload.class.expects(:gem_directories).returns %w{/one /two}
101
- @autoload.class.expects(:module_directories).returns %w{/three /four}
99
+ expect(@autoload.class).to receive(:gem_directories).and_return(%w{/one /two})
100
+ expect(@autoload.class).to receive(:module_directories).and_return(%w{/three /four})
102
101
  dirs = @autoload.class.search_directories(nil)
103
102
  expect(dirs).to include(dir)
104
103
  end
@@ -107,10 +106,10 @@ describe Puppet::Util::Autoload do
107
106
 
108
107
  describe "when loading a file" do
109
108
  before do
110
- @autoload.class.stubs(:search_directories).returns [make_absolute("/a")]
111
- FileTest.stubs(:directory?).returns true
109
+ allow(@autoload.class).to receive(:search_directories).and_return([make_absolute("/a")])
110
+ allow(FileTest).to receive(:directory?).and_return(true)
112
111
  @time_a = Time.utc(2010, 'jan', 1, 6, 30)
113
- File.stubs(:mtime).returns @time_a
112
+ allow(File).to receive(:mtime).and_return(@time_a)
114
113
  end
115
114
 
116
115
  after(:each) do
@@ -119,9 +118,9 @@ describe Puppet::Util::Autoload do
119
118
 
120
119
  [RuntimeError, LoadError, SyntaxError].each do |error|
121
120
  it "should die with Puppet::Error if a #{error.to_s} exception is thrown" do
122
- Puppet::FileSystem.stubs(:exist?).returns true
121
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
123
122
 
124
- Kernel.expects(:load).raises error
123
+ expect(Kernel).to receive(:load).and_raise(error)
125
124
 
126
125
  expect { @autoload.load("foo", env) }.to raise_error(Puppet::Error)
127
126
  end
@@ -132,24 +131,24 @@ describe Puppet::Util::Autoload do
132
131
  end
133
132
 
134
133
  it "should register loaded files with the autoloader" do
135
- Puppet::FileSystem.stubs(:exist?).returns true
136
- Kernel.stubs(:load)
134
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
135
+ allow(Kernel).to receive(:load)
137
136
  @autoload.load("myfile", env)
138
137
 
139
138
  expect(@autoload.class.loaded?("tmp/myfile.rb")).to be
140
139
  end
141
140
 
142
141
  it "should be seen by loaded? on the instance using the short name" do
143
- Puppet::FileSystem.stubs(:exist?).returns true
144
- Kernel.stubs(:load)
142
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
143
+ allow(Kernel).to receive(:load)
145
144
  @autoload.load("myfile", env)
146
145
 
147
146
  expect(@autoload.loaded?("myfile.rb")).to be
148
147
  end
149
148
 
150
149
  it "should register loaded files with the main loaded file list so they are not reloaded by ruby" do
151
- Puppet::FileSystem.stubs(:exist?).returns true
152
- Kernel.stubs(:load)
150
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
151
+ allow(Kernel).to receive(:load)
153
152
 
154
153
  @autoload.load("myfile", env)
155
154
 
@@ -157,17 +156,17 @@ describe Puppet::Util::Autoload do
157
156
  end
158
157
 
159
158
  it "should load the first file in the searchpath" do
160
- @autoload.stubs(:search_directories).returns [make_absolute("/a"), make_absolute("/b")]
161
- FileTest.stubs(:directory?).returns true
162
- Puppet::FileSystem.stubs(:exist?).returns true
163
- Kernel.expects(:load).with(make_absolute("/a/tmp/myfile.rb"), optionally(anything))
159
+ allow(@autoload).to receive(:search_directories).and_return([make_absolute("/a"), make_absolute("/b")])
160
+ allow(FileTest).to receive(:directory?).and_return(true)
161
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
162
+ expect(Kernel).to receive(:load).with(make_absolute("/a/tmp/myfile.rb"), any_args)
164
163
 
165
164
  @autoload.load("myfile", env)
166
165
  end
167
166
 
168
167
  it "should treat equivalent paths to a loaded file as loaded" do
169
- Puppet::FileSystem.stubs(:exist?).returns true
170
- Kernel.stubs(:load)
168
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
169
+ allow(Kernel).to receive(:load)
171
170
  @autoload.load("myfile", env)
172
171
 
173
172
  expect(@autoload.class.loaded?("tmp/myfile")).to be
@@ -179,26 +178,26 @@ describe Puppet::Util::Autoload do
179
178
 
180
179
  describe "when loading all files" do
181
180
  before do
182
- @autoload.class.stubs(:search_directories).returns [make_absolute("/a")]
183
- FileTest.stubs(:directory?).returns true
184
- Dir.stubs(:glob).returns [make_absolute("/a/foo/file.rb")]
185
- Puppet::FileSystem.stubs(:exist?).returns true
181
+ allow(@autoload.class).to receive(:search_directories).and_return([make_absolute("/a")])
182
+ allow(FileTest).to receive(:directory?).and_return(true)
183
+ allow(Dir).to receive(:glob).and_return([make_absolute("/a/foo/file.rb")])
184
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
186
185
  @time_a = Time.utc(2010, 'jan', 1, 6, 30)
187
- File.stubs(:mtime).returns @time_a
186
+ allow(File).to receive(:mtime).and_return(@time_a)
188
187
 
189
- @autoload.class.stubs(:loaded?).returns(false)
188
+ allow(@autoload.class).to receive(:loaded?).and_return(false)
190
189
  end
191
190
 
192
191
  [RuntimeError, LoadError, SyntaxError].each do |error|
193
192
  it "should die an if a #{error.to_s} exception is thrown" do
194
- Kernel.expects(:load).raises error
193
+ expect(Kernel).to receive(:load).and_raise(error)
195
194
 
196
195
  expect { @autoload.loadall(env) }.to raise_error(Puppet::Error)
197
196
  end
198
197
  end
199
198
 
200
199
  it "should require the full path to the file" do
201
- Kernel.expects(:load).with(make_absolute("/a/foo/file.rb"), optionally(anything))
200
+ expect(Kernel).to receive(:load).with(make_absolute("/a/foo/file.rb"), any_args)
202
201
 
203
202
  @autoload.loadall(env)
204
203
  end
@@ -222,14 +221,14 @@ describe Puppet::Util::Autoload do
222
221
  end
223
222
 
224
223
  it "changes should be seen by changed? on the instance using the short name" do
225
- File.stubs(:mtime).returns(@first_time)
226
- Puppet::FileSystem.stubs(:exist?).returns true
227
- Kernel.stubs(:load)
224
+ allow(File).to receive(:mtime).and_return(@first_time)
225
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
226
+ allow(Kernel).to receive(:load)
228
227
  @autoload.load("myfile", env)
229
228
  expect(@autoload.loaded?("myfile")).to be
230
229
  expect(@autoload.changed?("myfile", env)).not_to be
231
230
 
232
- File.stubs(:mtime).returns(@second_time)
231
+ allow(File).to receive(:mtime).and_return(@second_time)
233
232
  expect(@autoload.changed?("myfile", env)).to be
234
233
 
235
234
  $LOADED_FEATURES.delete("tmp/myfile.rb")
@@ -237,51 +236,51 @@ describe Puppet::Util::Autoload do
237
236
 
238
237
  describe "in one directory" do
239
238
  before :each do
240
- @autoload.class.stubs(:search_directories).returns [make_absolute("/a")]
241
- File.expects(:mtime).with(@file_a).returns(@first_time)
239
+ allow(@autoload.class).to receive(:search_directories).and_return([make_absolute("/a")])
240
+ expect(File).to receive(:mtime).with(@file_a).and_return(@first_time)
242
241
  @autoload.class.mark_loaded("file", @file_a)
243
242
  end
244
243
 
245
244
  it "should reload if mtime changes" do
246
- File.stubs(:mtime).with(@file_a).returns(@first_time + 60)
247
- Puppet::FileSystem.stubs(:exist?).with(@file_a).returns true
248
- Kernel.expects(:load).with(@file_a, optionally(anything))
245
+ allow(File).to receive(:mtime).with(@file_a).and_return(@first_time + 60)
246
+ allow(Puppet::FileSystem).to receive(:exist?).with(@file_a).and_return(true)
247
+ expect(Kernel).to receive(:load).with(@file_a, any_args)
249
248
  @autoload.class.reload_changed(env)
250
249
  end
251
250
 
252
251
  it "should do nothing if the file is deleted" do
253
- File.stubs(:mtime).with(@file_a).raises(Errno::ENOENT)
254
- Puppet::FileSystem.stubs(:exist?).with(@file_a).returns false
255
- Kernel.expects(:load).never
252
+ allow(File).to receive(:mtime).with(@file_a).and_raise(Errno::ENOENT)
253
+ allow(Puppet::FileSystem).to receive(:exist?).with(@file_a).and_return(false)
254
+ expect(Kernel).not_to receive(:load)
256
255
  @autoload.class.reload_changed(env)
257
256
  end
258
257
  end
259
258
 
260
259
  describe "in two directories" do
261
260
  before :each do
262
- @autoload.class.stubs(:search_directories).returns [make_absolute("/a"), make_absolute("/b")]
261
+ allow(@autoload.class).to receive(:search_directories).and_return([make_absolute("/a"), make_absolute("/b")])
263
262
  end
264
263
 
265
264
  it "should load b/file when a/file is deleted" do
266
- File.expects(:mtime).with(@file_a).returns(@first_time)
265
+ expect(File).to receive(:mtime).with(@file_a).and_return(@first_time)
267
266
  @autoload.class.mark_loaded("file", @file_a)
268
- File.stubs(:mtime).with(@file_a).raises(Errno::ENOENT)
269
- Puppet::FileSystem.stubs(:exist?).with(@file_a).returns false
270
- Puppet::FileSystem.stubs(:exist?).with(@file_b).returns true
271
- File.stubs(:mtime).with(@file_b).returns @first_time
272
- Kernel.expects(:load).with(@file_b, optionally(anything))
267
+ allow(File).to receive(:mtime).with(@file_a).and_raise(Errno::ENOENT)
268
+ allow(Puppet::FileSystem).to receive(:exist?).with(@file_a).and_return(false)
269
+ allow(Puppet::FileSystem).to receive(:exist?).with(@file_b).and_return(true)
270
+ allow(File).to receive(:mtime).with(@file_b).and_return(@first_time)
271
+ expect(Kernel).to receive(:load).with(@file_b, any_args)
273
272
  @autoload.class.reload_changed(env)
274
273
  expect(@autoload.class.send(:loaded)["file"]).to eq([@file_b, @first_time])
275
274
  end
276
275
 
277
276
  it "should load a/file when b/file is loaded and a/file is created" do
278
- File.stubs(:mtime).with(@file_b).returns @first_time
279
- Puppet::FileSystem.stubs(:exist?).with(@file_b).returns true
277
+ allow(File).to receive(:mtime).with(@file_b).and_return(@first_time)
278
+ allow(Puppet::FileSystem).to receive(:exist?).with(@file_b).and_return(true)
280
279
  @autoload.class.mark_loaded("file", @file_b)
281
280
 
282
- File.stubs(:mtime).with(@file_a).returns @first_time
283
- Puppet::FileSystem.stubs(:exist?).with(@file_a).returns true
284
- Kernel.expects(:load).with(@file_a, optionally(anything))
281
+ allow(File).to receive(:mtime).with(@file_a).and_return(@first_time)
282
+ allow(Puppet::FileSystem).to receive(:exist?).with(@file_a).and_return(true)
283
+ expect(Kernel).to receive(:load).with(@file_a, any_args)
285
284
  @autoload.class.reload_changed(env)
286
285
  expect(@autoload.class.send(:loaded)["file"]).to eq([@file_a, @first_time])
287
286
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/util/backups'
@@ -6,10 +5,10 @@ require 'puppet/util/backups'
6
5
  describe Puppet::Util::Backups do
7
6
  include PuppetSpec::Files
8
7
 
9
- let(:bucket) { stub('bucket', :name => "foo") }
8
+ let(:bucket) { double('bucket', :name => "foo") }
10
9
  let!(:file) do
11
10
  f = Puppet::Type.type(:file).new(:name => path, :backup => 'foo')
12
- f.stubs(:bucket).returns(bucket)
11
+ allow(f).to receive(:bucket).and_return(bucket)
13
12
  f
14
13
  end
15
14
 
@@ -19,8 +18,8 @@ describe Puppet::Util::Backups do
19
18
  it "should noop if the file does not exist" do
20
19
  file = Puppet::Type.type(:file).new(:name => path)
21
20
 
22
- file.expects(:bucket).never
23
- Puppet::FileSystem.expects(:exist?).with(path).returns false
21
+ expect(file).not_to receive(:bucket)
22
+ expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(false)
24
23
 
25
24
  file.perform_backup
26
25
  end
@@ -28,24 +27,24 @@ describe Puppet::Util::Backups do
28
27
  it "should succeed silently if self[:backup] is false" do
29
28
  file = Puppet::Type.type(:file).new(:name => path, :backup => false)
30
29
 
31
- file.expects(:bucket).never
32
- Puppet::FileSystem.expects(:exist?).never
30
+ expect(file).not_to receive(:bucket)
31
+ expect(Puppet::FileSystem).not_to receive(:exist?)
33
32
 
34
33
  file.perform_backup
35
34
  end
36
35
 
37
36
  it "a bucket should be used when provided" do
38
37
  lstat_path_as(path, 'file')
39
- bucket.expects(:backup).with(path).returns("mysum")
40
- Puppet::FileSystem.expects(:exist?).with(path).returns(true)
38
+ expect(bucket).to receive(:backup).with(path).and_return("mysum")
39
+ expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
41
40
 
42
41
  file.perform_backup
43
42
  end
44
43
 
45
44
  it "should propagate any exceptions encountered when backing up to a filebucket" do
46
45
  lstat_path_as(path, 'file')
47
- bucket.expects(:backup).raises ArgumentError
48
- Puppet::FileSystem.expects(:exist?).with(path).returns(true)
46
+ expect(bucket).to receive(:backup).and_raise(ArgumentError)
47
+ expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
49
48
 
50
49
  expect { file.perform_backup }.to raise_error(ArgumentError)
51
50
  end
@@ -57,42 +56,42 @@ describe Puppet::Util::Backups do
57
56
 
58
57
  it "should remove any local backup if one exists" do
59
58
  lstat_path_as(backup, 'file')
60
- Puppet::FileSystem.expects(:unlink).with(backup)
61
- FileUtils.stubs(:cp_r)
62
- Puppet::FileSystem.expects(:exist?).with(path).returns(true)
59
+ expect(Puppet::FileSystem).to receive(:unlink).with(backup)
60
+ allow(FileUtils).to receive(:cp_r)
61
+ expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
63
62
 
64
63
  file.perform_backup
65
64
  end
66
65
 
67
66
  it "should fail when the old backup can't be removed" do
68
67
  lstat_path_as(backup, 'file')
69
- Puppet::FileSystem.expects(:unlink).with(backup).raises ArgumentError
70
- FileUtils.expects(:cp_r).never
71
- Puppet::FileSystem.expects(:exist?).with(path).returns(true)
68
+ expect(Puppet::FileSystem).to receive(:unlink).with(backup).and_raise(ArgumentError)
69
+ expect(FileUtils).not_to receive(:cp_r)
70
+ expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
72
71
 
73
72
  expect { file.perform_backup }.to raise_error(Puppet::Error)
74
73
  end
75
74
 
76
75
  it "should not try to remove backups that don't exist" do
77
- Puppet::FileSystem.expects(:lstat).with(backup).raises(Errno::ENOENT)
78
- Puppet::FileSystem.expects(:unlink).with(backup).never
79
- FileUtils.stubs(:cp_r)
80
- Puppet::FileSystem.expects(:exist?).with(path).returns(true)
76
+ expect(Puppet::FileSystem).to receive(:lstat).with(backup).and_raise(Errno::ENOENT)
77
+ expect(Puppet::FileSystem).not_to receive(:unlink).with(backup)
78
+ allow(FileUtils).to receive(:cp_r)
79
+ expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
81
80
 
82
81
  file.perform_backup
83
82
  end
84
83
 
85
84
  it "a copy should be created in the local directory" do
86
- FileUtils.expects(:cp_r).with(path, backup, :preserve => true)
87
- Puppet::FileSystem.stubs(:exist?).with(path).returns(true)
85
+ expect(FileUtils).to receive(:cp_r).with(path, backup, :preserve => true)
86
+ allow(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
88
87
 
89
88
  expect(file.perform_backup).to be_truthy
90
89
  end
91
90
 
92
91
  it "should propagate exceptions if no backup can be created" do
93
- FileUtils.expects(:cp_r).raises ArgumentError
92
+ expect(FileUtils).to receive(:cp_r).and_raise(ArgumentError)
94
93
 
95
- Puppet::FileSystem.stubs(:exist?).with(path).returns(true)
94
+ allow(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
96
95
  expect { file.perform_backup }.to raise_error(Puppet::Error)
97
96
  end
98
97
  end
@@ -103,15 +102,15 @@ describe Puppet::Util::Backups do
103
102
  let(:filename) { File.join(path, 'file') }
104
103
 
105
104
  it "a bucket should work when provided" do
106
- File.stubs(:file?).with(filename).returns true
107
- Find.expects(:find).with(path).yields(filename)
105
+ allow(File).to receive(:file?).with(filename).and_return(true)
106
+ expect(Find).to receive(:find).with(path).and_yield(filename)
108
107
 
109
- bucket.expects(:backup).with(filename).returns true
108
+ expect(bucket).to receive(:backup).with(filename).and_return(true)
110
109
 
111
110
  lstat_path_as(path, 'directory')
112
111
 
113
- Puppet::FileSystem.stubs(:exist?).with(path).returns(true)
114
- Puppet::FileSystem.stubs(:exist?).with(filename).returns(true)
112
+ allow(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
113
+ allow(Puppet::FileSystem).to receive(:exist?).with(filename).and_return(true)
115
114
 
116
115
  file.perform_backup
117
116
  end
@@ -119,16 +118,16 @@ describe Puppet::Util::Backups do
119
118
  it "should do nothing when recursing" do
120
119
  file = Puppet::Type.type(:file).new(:name => path, :backup => 'foo', :recurse => true)
121
120
 
122
- bucket.expects(:backup).never
123
- stub_file = stub('file', :stat => stub('stat', :ftype => 'directory'))
124
- Puppet::FileSystem.stubs(:new).with(path).returns stub_file
125
- Find.expects(:find).never
121
+ expect(bucket).not_to receive(:backup)
122
+ stub_file = double('file', :stat => double('stat', :ftype => 'directory'))
123
+ allow(Puppet::FileSystem).to receive(:new).with(path).and_return(stub_file)
124
+ expect(Find).not_to receive(:find)
126
125
 
127
126
  file.perform_backup
128
127
  end
129
128
  end
130
129
 
131
130
  def lstat_path_as(path, ftype)
132
- Puppet::FileSystem.expects(:lstat).with(path).returns(stub('File::Stat', :ftype => ftype))
131
+ expect(Puppet::FileSystem).to receive(:lstat).with(path).and_return(double('File::Stat', :ftype => ftype))
133
132
  end
134
133
  end