puppet 6.0.7-universal-darwin → 6.0.8-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +4 -8
  4. data/lib/puppet/application/device.rb +99 -83
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/configurer.rb +5 -4
  7. data/lib/puppet/defaults.rb +31 -11
  8. data/lib/puppet/indirector/request.rb +26 -15
  9. data/lib/puppet/network/http/connection.rb +15 -7
  10. data/lib/puppet/transaction/event_manager.rb +1 -5
  11. data/lib/puppet/type/file/source.rb +0 -1
  12. data/lib/puppet/util/connection.rb +15 -6
  13. data/lib/puppet/util/http_proxy.rb +3 -2
  14. data/lib/puppet/version.rb +1 -1
  15. data/locales/puppet.pot +99 -40
  16. data/man/man5/puppet.conf.5 +8 -8
  17. data/man/man8/puppet-agent.8 +1 -1
  18. data/man/man8/puppet-apply.8 +1 -1
  19. data/man/man8/puppet-catalog.8 +1 -1
  20. data/man/man8/puppet-config.8 +1 -1
  21. data/man/man8/puppet-describe.8 +1 -1
  22. data/man/man8/puppet-device.8 +1 -1
  23. data/man/man8/puppet-doc.8 +1 -1
  24. data/man/man8/puppet-epp.8 +1 -1
  25. data/man/man8/puppet-facts.8 +1 -1
  26. data/man/man8/puppet-filebucket.8 +1 -1
  27. data/man/man8/puppet-generate.8 +1 -1
  28. data/man/man8/puppet-help.8 +1 -1
  29. data/man/man8/puppet-key.8 +1 -1
  30. data/man/man8/puppet-lookup.8 +1 -1
  31. data/man/man8/puppet-man.8 +1 -1
  32. data/man/man8/puppet-module.8 +1 -1
  33. data/man/man8/puppet-node.8 +1 -1
  34. data/man/man8/puppet-parser.8 +1 -1
  35. data/man/man8/puppet-plugin.8 +1 -1
  36. data/man/man8/puppet-report.8 +1 -1
  37. data/man/man8/puppet-resource.8 +1 -1
  38. data/man/man8/puppet-script.8 +1 -1
  39. data/man/man8/puppet-ssl.8 +1 -1
  40. data/man/man8/puppet-status.8 +1 -1
  41. data/man/man8/puppet.8 +2 -2
  42. data/spec/integration/agent/logging_spec.rb +5 -7
  43. data/spec/integration/application/apply_spec.rb +18 -16
  44. data/spec/integration/application/doc_spec.rb +1 -2
  45. data/spec/integration/application/lookup_spec.rb +5 -5
  46. data/spec/integration/configurer_spec.rb +5 -6
  47. data/spec/integration/defaults_spec.rb +5 -6
  48. data/spec/integration/directory_environments_spec.rb +1 -1
  49. data/spec/integration/faces/config_spec.rb +3 -4
  50. data/spec/integration/faces/documentation_spec.rb +0 -1
  51. data/spec/integration/faces/plugin_spec.rb +1 -1
  52. data/spec/integration/file_bucket/file_spec.rb +2 -4
  53. data/spec/integration/file_serving/content_spec.rb +0 -1
  54. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  55. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  56. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  57. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  58. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  59. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  60. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  61. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  62. data/spec/integration/network/authconfig_spec.rb +23 -24
  63. data/spec/integration/network/formats_spec.rb +0 -1
  64. data/spec/integration/node/environment_spec.rb +0 -1
  65. data/spec/integration/node/facts_spec.rb +9 -10
  66. data/spec/integration/node_spec.rb +6 -7
  67. data/spec/integration/parser/catalog_spec.rb +1 -5
  68. data/spec/integration/parser/collection_spec.rb +1 -2
  69. data/spec/integration/parser/compiler_spec.rb +6 -6
  70. data/spec/integration/parser/scope_spec.rb +1 -1
  71. data/spec/integration/parser/undef_param_spec.rb +1 -1
  72. data/spec/integration/provider/service/init_spec.rb +4 -5
  73. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  74. data/spec/integration/provider/service/windows_spec.rb +1 -2
  75. data/spec/integration/reference/providers_spec.rb +1 -2
  76. data/spec/integration/reports_spec.rb +1 -2
  77. data/spec/integration/resource/catalog_spec.rb +14 -17
  78. data/spec/integration/resource/type_collection_spec.rb +4 -5
  79. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  80. data/spec/integration/ssl/host_spec.rb +1 -2
  81. data/spec/integration/ssl/key_spec.rb +0 -1
  82. data/spec/integration/test/test_helper_spec.rb +0 -1
  83. data/spec/integration/transaction/report_spec.rb +6 -11
  84. data/spec/integration/transaction_spec.rb +18 -19
  85. data/spec/integration/type/exec_spec.rb +0 -1
  86. data/spec/integration/type/file_spec.rb +13 -14
  87. data/spec/integration/type/package_spec.rb +19 -23
  88. data/spec/integration/type/tidy_spec.rb +1 -2
  89. data/spec/integration/type_spec.rb +0 -1
  90. data/spec/integration/util/autoload_spec.rb +1 -2
  91. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  92. data/spec/integration/util/settings_spec.rb +0 -1
  93. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  94. data/spec/integration/util/windows/principal_spec.rb +0 -1
  95. data/spec/integration/util/windows/process_spec.rb +4 -6
  96. data/spec/integration/util/windows/registry_spec.rb +41 -51
  97. data/spec/integration/util/windows/security_spec.rb +2 -4
  98. data/spec/integration/util/windows/user_spec.rb +18 -20
  99. data/spec/integration/util_spec.rb +4 -7
  100. data/spec/lib/puppet_spec/compiler.rb +1 -1
  101. data/spec/lib/puppet_spec/files.rb +0 -1
  102. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  103. data/spec/lib/puppet_spec/scope.rb +1 -2
  104. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  105. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  106. data/spec/shared_behaviours/file_serving.rb +6 -8
  107. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  108. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  109. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  110. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  111. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  112. data/spec/spec_helper.rb +10 -1
  113. data/spec/unit/agent/disabler_spec.rb +4 -5
  114. data/spec/unit/agent/locker_spec.rb +12 -13
  115. data/spec/unit/agent_spec.rb +80 -85
  116. data/spec/unit/application/agent_spec.rb +88 -93
  117. data/spec/unit/application/apply_spec.rb +82 -83
  118. data/spec/unit/application/config_spec.rb +0 -1
  119. data/spec/unit/application/describe_spec.rb +6 -7
  120. data/spec/unit/application/device_spec.rb +395 -419
  121. data/spec/unit/application/doc_spec.rb +44 -46
  122. data/spec/unit/application/face_base_spec.rb +61 -62
  123. data/spec/unit/application/facts_spec.rb +3 -4
  124. data/spec/unit/application/filebucket_spec.rb +66 -74
  125. data/spec/unit/application/indirection_base_spec.rb +8 -6
  126. data/spec/unit/application/lookup_spec.rb +26 -26
  127. data/spec/unit/application/resource_spec.rb +42 -48
  128. data/spec/unit/application/ssl_spec.rb +3 -3
  129. data/spec/unit/application_spec.rb +82 -92
  130. data/spec/unit/capability_spec.rb +6 -6
  131. data/spec/unit/certificate_factory_spec.rb +3 -5
  132. data/spec/unit/configurer/downloader_spec.rb +20 -21
  133. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  134. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  135. data/spec/unit/configurer_spec.rb +189 -192
  136. data/spec/unit/confine/exists_spec.rb +17 -15
  137. data/spec/unit/confine/false_spec.rb +5 -6
  138. data/spec/unit/confine/feature_spec.rb +7 -5
  139. data/spec/unit/confine/true_spec.rb +5 -6
  140. data/spec/unit/confine/variable_spec.rb +14 -15
  141. data/spec/unit/confine_collection_spec.rb +28 -29
  142. data/spec/unit/confine_spec.rb +13 -14
  143. data/spec/unit/confiner_spec.rb +10 -11
  144. data/spec/unit/context/trusted_information_spec.rb +1 -1
  145. data/spec/unit/daemon_spec.rb +35 -36
  146. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  147. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  148. data/spec/unit/datatypes_spec.rb +3 -4
  149. data/spec/unit/defaults_spec.rb +18 -13
  150. data/spec/unit/environments_spec.rb +7 -7
  151. data/spec/unit/etc_spec.rb +30 -32
  152. data/spec/unit/external/pson_spec.rb +0 -1
  153. data/spec/unit/face/catalog_spec.rb +0 -1
  154. data/spec/unit/face/config_spec.rb +31 -35
  155. data/spec/unit/face/epp_face_spec.rb +3 -4
  156. data/spec/unit/face/facts_spec.rb +5 -6
  157. data/spec/unit/face/generate_spec.rb +4 -5
  158. data/spec/unit/face/help_spec.rb +7 -8
  159. data/spec/unit/face/key_spec.rb +0 -1
  160. data/spec/unit/face/man_spec.rb +1 -2
  161. data/spec/unit/face/module/install_spec.rb +3 -5
  162. data/spec/unit/face/module/list_spec.rb +2 -12
  163. data/spec/unit/face/module/search_spec.rb +11 -9
  164. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  165. data/spec/unit/face/node_spec.rb +23 -24
  166. data/spec/unit/face/parser_spec.rb +3 -3
  167. data/spec/unit/face/plugin_spec.rb +36 -9
  168. data/spec/unit/face/status_spec.rb +0 -1
  169. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  170. data/spec/unit/file_bucket/file_spec.rb +0 -2
  171. data/spec/unit/file_serving/base_spec.rb +14 -15
  172. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  173. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  174. data/spec/unit/file_serving/content_spec.rb +10 -11
  175. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  176. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  177. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  178. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  179. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  180. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  181. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  182. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  183. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  184. data/spec/unit/file_serving/mount_spec.rb +0 -1
  185. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  186. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  187. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  188. data/spec/unit/file_system_spec.rb +2 -2
  189. data/spec/unit/forge/errors_spec.rb +1 -1
  190. data/spec/unit/forge/forge_spec.rb +13 -14
  191. data/spec/unit/forge/module_release_spec.rb +18 -18
  192. data/spec/unit/forge/repository_spec.rb +29 -30
  193. data/spec/unit/forge_spec.rb +15 -11
  194. data/spec/unit/functions/binary_file_spec.rb +3 -3
  195. data/spec/unit/functions/contain_spec.rb +0 -2
  196. data/spec/unit/functions/defined_spec.rb +0 -1
  197. data/spec/unit/functions/epp_spec.rb +2 -2
  198. data/spec/unit/functions/find_file_spec.rb +7 -7
  199. data/spec/unit/functions/include_spec.rb +0 -4
  200. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  201. data/spec/unit/functions/lookup_spec.rb +1 -2
  202. data/spec/unit/functions/module_directory_spec.rb +12 -12
  203. data/spec/unit/functions/require_spec.rb +0 -3
  204. data/spec/unit/functions/shared.rb +5 -8
  205. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  206. data/spec/unit/functions4_spec.rb +9 -10
  207. data/spec/unit/gettext/config_spec.rb +4 -4
  208. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  209. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  210. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  211. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  212. data/spec/unit/hiera_puppet_spec.rb +20 -20
  213. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  214. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  215. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  216. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  217. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  218. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  219. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  220. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  221. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  222. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  223. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  224. data/spec/unit/indirector/envelope_spec.rb +1 -2
  225. data/spec/unit/indirector/exec_spec.rb +4 -5
  226. data/spec/unit/indirector/face_spec.rb +9 -9
  227. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  228. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  229. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  230. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  231. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  232. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  233. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  234. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  235. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  236. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  237. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  238. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  239. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  240. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  241. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  242. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  243. data/spec/unit/indirector/file_server_spec.rb +87 -87
  244. data/spec/unit/indirector/indirection_spec.rb +242 -226
  245. data/spec/unit/indirector/json_spec.rb +7 -9
  246. data/spec/unit/indirector/key/file_spec.rb +21 -22
  247. data/spec/unit/indirector/memory_spec.rb +6 -7
  248. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  249. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  250. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  251. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  252. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  253. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  254. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  255. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  256. data/spec/unit/indirector/none_spec.rb +5 -5
  257. data/spec/unit/indirector/plain_spec.rb +7 -8
  258. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  259. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  260. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  261. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  262. data/spec/unit/indirector/request_spec.rb +11 -12
  263. data/spec/unit/indirector/resource/ral_spec.rb +46 -54
  264. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  265. data/spec/unit/indirector/rest_spec.rb +113 -110
  266. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  267. data/spec/unit/indirector/status/local_spec.rb +0 -1
  268. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  269. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  270. data/spec/unit/indirector/terminus_spec.rb +27 -27
  271. data/spec/unit/indirector/yaml_spec.rb +5 -6
  272. data/spec/unit/indirector_spec.rb +1 -2
  273. data/spec/unit/info_service_spec.rb +1 -1
  274. data/spec/unit/interface/action_builder_spec.rb +0 -1
  275. data/spec/unit/interface/action_manager_spec.rb +0 -1
  276. data/spec/unit/interface/action_spec.rb +2 -3
  277. data/spec/unit/interface/documentation_spec.rb +0 -1
  278. data/spec/unit/interface/face_collection_spec.rb +19 -12
  279. data/spec/unit/interface_spec.rb +3 -3
  280. data/spec/unit/man_spec.rb +3 -4
  281. data/spec/unit/module_spec.rb +46 -51
  282. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  283. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  284. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  285. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  286. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  287. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  288. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  289. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  290. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  291. data/spec/unit/module_tool/tar_spec.rb +12 -13
  292. data/spec/unit/module_tool_spec.rb +7 -12
  293. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  294. data/spec/unit/network/authconfig_spec.rb +17 -18
  295. data/spec/unit/network/authorization_spec.rb +4 -5
  296. data/spec/unit/network/authstore_spec.rb +0 -1
  297. data/spec/unit/network/format_handler_spec.rb +0 -1
  298. data/spec/unit/network/format_spec.rb +9 -10
  299. data/spec/unit/network/format_support_spec.rb +28 -29
  300. data/spec/unit/network/formats_spec.rb +4 -5
  301. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  302. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  303. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  304. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  305. data/spec/unit/network/http/api_spec.rb +0 -2
  306. data/spec/unit/network/http/compression_spec.rb +21 -22
  307. data/spec/unit/network/http/connection_spec.rb +41 -36
  308. data/spec/unit/network/http/factory_spec.rb +5 -6
  309. data/spec/unit/network/http/handler_spec.rb +9 -18
  310. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  311. data/spec/unit/network/http/pool_spec.rb +28 -29
  312. data/spec/unit/network/http/request_spec.rb +0 -2
  313. data/spec/unit/network/http/response_spec.rb +11 -13
  314. data/spec/unit/network/http/route_spec.rb +0 -1
  315. data/spec/unit/network/http/session_spec.rb +1 -2
  316. data/spec/unit/network/http/site_spec.rb +0 -1
  317. data/spec/unit/network/http_pool_spec.rb +18 -9
  318. data/spec/unit/network/http_spec.rb +0 -1
  319. data/spec/unit/network/resolver_spec.rb +25 -26
  320. data/spec/unit/network/rights_spec.rb +52 -53
  321. data/spec/unit/node/environment_spec.rb +14 -15
  322. data/spec/unit/node/facts_spec.rb +5 -7
  323. data/spec/unit/node_spec.rb +4 -10
  324. data/spec/unit/other/selinux_spec.rb +0 -1
  325. data/spec/unit/parameter/boolean_spec.rb +1 -2
  326. data/spec/unit/parameter/package_options_spec.rb +1 -2
  327. data/spec/unit/parameter/path_spec.rb +0 -1
  328. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  329. data/spec/unit/parameter/value_spec.rb +0 -1
  330. data/spec/unit/parameter_spec.rb +9 -9
  331. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  332. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  333. data/spec/unit/parser/compiler_spec.rb +84 -96
  334. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  335. data/spec/unit/parser/files_spec.rb +0 -1
  336. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  337. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  338. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  339. data/spec/unit/parser/functions/file_spec.rb +13 -14
  340. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  341. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  342. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  343. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  344. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  345. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  346. data/spec/unit/parser/functions/split_spec.rb +0 -1
  347. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  348. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  349. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  350. data/spec/unit/parser/functions/template_spec.rb +13 -13
  351. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  352. data/spec/unit/parser/functions_spec.rb +6 -7
  353. data/spec/unit/parser/relationship_spec.rb +0 -1
  354. data/spec/unit/parser/resource_spec.rb +42 -42
  355. data/spec/unit/parser/scope_spec.rb +39 -35
  356. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  357. data/spec/unit/parser/type_loader_spec.rb +17 -19
  358. data/spec/unit/pops/adaptable_spec.rb +0 -1
  359. data/spec/unit/pops/benchmark_spec.rb +0 -1
  360. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  361. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  362. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  363. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  364. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  365. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  366. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  367. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  368. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  371. data/spec/unit/pops/factory_spec.rb +3 -4
  372. data/spec/unit/pops/issues_spec.rb +19 -20
  373. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  374. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  375. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  376. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  377. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  378. data/spec/unit/pops/migration_spec.rb +3 -5
  379. data/spec/unit/pops/model/model_spec.rb +0 -1
  380. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  381. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  382. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  383. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  384. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  385. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  386. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  387. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  388. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  389. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  390. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  391. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  392. data/spec/unit/pops/pn_spec.rb +0 -1
  393. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  394. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  395. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  396. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  397. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  398. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  399. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  400. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  401. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  402. data/spec/unit/pops/visitor_spec.rb +0 -1
  403. data/spec/unit/property/boolean_spec.rb +1 -1
  404. data/spec/unit/property/ensure_spec.rb +0 -1
  405. data/spec/unit/property/keyvalue_spec.rb +32 -34
  406. data/spec/unit/property/list_spec.rb +26 -27
  407. data/spec/unit/property/ordered_list_spec.rb +10 -14
  408. data/spec/unit/property_spec.rb +42 -43
  409. data/spec/unit/provider/aix_object_spec.rb +47 -45
  410. data/spec/unit/provider/command_spec.rb +9 -9
  411. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  412. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  413. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  414. data/spec/unit/provider/exec_spec.rb +0 -1
  415. data/spec/unit/provider/file/posix_spec.rb +22 -24
  416. data/spec/unit/provider/file/windows_spec.rb +15 -17
  417. data/spec/unit/provider/group/aix_spec.rb +3 -2
  418. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  419. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  420. data/spec/unit/provider/group/pw_spec.rb +11 -11
  421. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  422. data/spec/unit/provider/ldap_spec.rb +61 -62
  423. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  424. data/spec/unit/provider/nameservice_spec.rb +38 -40
  425. data/spec/unit/provider/package/aix_spec.rb +15 -15
  426. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  427. data/spec/unit/provider/package/apt_spec.rb +44 -27
  428. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  429. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  430. data/spec/unit/provider/package/base_spec.rb +4 -4
  431. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  432. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  433. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  434. data/spec/unit/provider/package/gem_spec.rb +51 -43
  435. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  436. data/spec/unit/provider/package/macports_spec.rb +46 -42
  437. data/spec/unit/provider/package/nim_spec.rb +30 -39
  438. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  439. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  440. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  441. data/spec/unit/provider/package/pip_spec.rb +71 -72
  442. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  443. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  444. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  445. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  446. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  447. data/spec/unit/provider/package/portage_spec.rb +70 -74
  448. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  449. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  450. data/spec/unit/provider/package/sun_spec.rb +16 -18
  451. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  452. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  453. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  454. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  455. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  456. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  457. data/spec/unit/provider/package/windows_spec.rb +36 -32
  458. data/spec/unit/provider/package/yum_spec.rb +7 -7
  459. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  460. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  461. data/spec/unit/provider/service/base_spec.rb +4 -5
  462. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  463. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  464. data/spec/unit/provider/service/debian_spec.rb +38 -38
  465. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  466. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  467. data/spec/unit/provider/service/init_spec.rb +53 -52
  468. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  469. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  470. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  471. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  472. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  473. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  474. data/spec/unit/provider/service/runit_spec.rb +29 -27
  475. data/spec/unit/provider/service/smf_spec.rb +74 -66
  476. data/spec/unit/provider/service/src_spec.rb +46 -47
  477. data/spec/unit/provider/service/systemd_spec.rb +104 -113
  478. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  479. data/spec/unit/provider/service/windows_spec.rb +33 -41
  480. data/spec/unit/provider/user/aix_spec.rb +31 -31
  481. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  482. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  483. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  484. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  485. data/spec/unit/provider/user/pw_spec.rb +37 -35
  486. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  487. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  488. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  489. data/spec/unit/provider_spec.rb +35 -35
  490. data/spec/unit/puppet_pal_2pec.rb +4 -5
  491. data/spec/unit/puppet_pal_spec.rb +0 -1
  492. data/spec/unit/puppet_spec.rb +6 -7
  493. data/spec/unit/relationship_spec.rb +0 -1
  494. data/spec/unit/reports/http_spec.rb +21 -23
  495. data/spec/unit/reports/store_spec.rb +3 -4
  496. data/spec/unit/reports_spec.rb +12 -14
  497. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  498. data/spec/unit/resource/catalog_spec.rb +72 -68
  499. data/spec/unit/resource/status_spec.rb +6 -8
  500. data/spec/unit/resource/type_collection_spec.rb +17 -18
  501. data/spec/unit/resource/type_spec.rb +34 -35
  502. data/spec/unit/resource_spec.rb +36 -32
  503. data/spec/unit/rest/client_spec.rb +58 -27
  504. data/spec/unit/rest/route_spec.rb +5 -5
  505. data/spec/unit/scheduler/job_spec.rb +0 -1
  506. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  507. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  508. data/spec/unit/settings/array_setting_spec.rb +1 -1
  509. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  510. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  511. data/spec/unit/settings/config_file_spec.rb +0 -1
  512. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  513. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  514. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  515. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  516. data/spec/unit/settings/file_setting_spec.rb +44 -46
  517. data/spec/unit/settings/path_setting_spec.rb +1 -2
  518. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  519. data/spec/unit/settings/string_setting_spec.rb +14 -15
  520. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  521. data/spec/unit/settings/value_translator_spec.rb +0 -1
  522. data/spec/unit/settings_spec.rb +228 -235
  523. data/spec/unit/ssl/base_spec.rb +14 -15
  524. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  525. data/spec/unit/ssl/certificate_spec.rb +23 -25
  526. data/spec/unit/ssl/digest_spec.rb +0 -1
  527. data/spec/unit/ssl/host_spec.rb +166 -149
  528. data/spec/unit/ssl/key_spec.rb +30 -31
  529. data/spec/unit/ssl/validator_spec.rb +38 -39
  530. data/spec/unit/task_spec.rb +44 -45
  531. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  532. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  533. data/spec/unit/transaction/event_spec.rb +16 -15
  534. data/spec/unit/transaction/persistence_spec.rb +16 -17
  535. data/spec/unit/transaction/report_spec.rb +11 -12
  536. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  537. data/spec/unit/transaction_spec.rb +100 -101
  538. data/spec/unit/type/component_spec.rb +0 -1
  539. data/spec/unit/type/exec_spec.rb +60 -56
  540. data/spec/unit/type/file/checksum_spec.rb +9 -10
  541. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  542. data/spec/unit/type/file/content_spec.rb +58 -61
  543. data/spec/unit/type/file/ctime_spec.rb +0 -1
  544. data/spec/unit/type/file/ensure_spec.rb +12 -13
  545. data/spec/unit/type/file/group_spec.rb +5 -7
  546. data/spec/unit/type/file/mode_spec.rb +4 -6
  547. data/spec/unit/type/file/mtime_spec.rb +0 -1
  548. data/spec/unit/type/file/owner_spec.rb +6 -8
  549. data/spec/unit/type/file/selinux_spec.rb +17 -19
  550. data/spec/unit/type/file/source_spec.rb +104 -101
  551. data/spec/unit/type/file/type_spec.rb +0 -1
  552. data/spec/unit/type/file_spec.rb +195 -185
  553. data/spec/unit/type/filebucket_spec.rb +4 -5
  554. data/spec/unit/type/group_spec.rb +6 -8
  555. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  556. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  557. data/spec/unit/type/package_spec.rb +56 -57
  558. data/spec/unit/type/resources_spec.rb +72 -74
  559. data/spec/unit/type/schedule_spec.rb +24 -26
  560. data/spec/unit/type/service_spec.rb +48 -48
  561. data/spec/unit/type/stage_spec.rb +0 -1
  562. data/spec/unit/type/tidy_spec.rb +61 -62
  563. data/spec/unit/type/user_spec.rb +24 -25
  564. data/spec/unit/type/whit_spec.rb +0 -1
  565. data/spec/unit/type_spec.rb +55 -54
  566. data/spec/unit/util/at_fork_spec.rb +18 -19
  567. data/spec/unit/util/autoload_spec.rb +55 -56
  568. data/spec/unit/util/backups_spec.rb +34 -35
  569. data/spec/unit/util/character_encoding_spec.rb +5 -5
  570. data/spec/unit/util/checksums_spec.rb +38 -39
  571. data/spec/unit/util/colors_spec.rb +1 -2
  572. data/spec/unit/util/command_line_spec.rb +24 -25
  573. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  574. data/spec/unit/util/diff_spec.rb +7 -8
  575. data/spec/unit/util/errors_spec.rb +0 -1
  576. data/spec/unit/util/execution_spec.rb +185 -161
  577. data/spec/unit/util/execution_stub_spec.rb +0 -1
  578. data/spec/unit/util/feature_spec.rb +21 -14
  579. data/spec/unit/util/filetype_spec.rb +49 -49
  580. data/spec/unit/util/http_proxy_spec.rb +12 -12
  581. data/spec/unit/util/inifile_spec.rb +26 -31
  582. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  583. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  584. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  585. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  586. data/spec/unit/util/lockfile_spec.rb +0 -1
  587. data/spec/unit/util/log/destinations_spec.rb +30 -33
  588. data/spec/unit/util/log_spec.rb +35 -36
  589. data/spec/unit/util/logging_spec.rb +58 -72
  590. data/spec/unit/util/metric_spec.rb +0 -1
  591. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  592. data/spec/unit/util/multi_match_spec.rb +0 -1
  593. data/spec/unit/util/network_device/config_spec.rb +0 -1
  594. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  595. data/spec/unit/util/network_device_spec.rb +7 -9
  596. data/spec/unit/util/package_spec.rb +0 -1
  597. data/spec/unit/util/pidlock_spec.rb +21 -22
  598. data/spec/unit/util/plist_spec.rb +40 -33
  599. data/spec/unit/util/posix_spec.rb +54 -51
  600. data/spec/unit/util/rdoc_spec.rb +9 -10
  601. data/spec/unit/util/reference_spec.rb +0 -1
  602. data/spec/unit/util/resource_template_spec.rb +20 -20
  603. data/spec/unit/util/retry_action_spec.rb +7 -8
  604. data/spec/unit/util/rubygems_spec.rb +7 -8
  605. data/spec/unit/util/run_mode_spec.rb +3 -4
  606. data/spec/unit/util/selinux_spec.rb +79 -72
  607. data/spec/unit/util/splayer_spec.rb +8 -9
  608. data/spec/unit/util/ssl_spec.rb +0 -1
  609. data/spec/unit/util/storage_spec.rb +3 -4
  610. data/spec/unit/util/suidmanager_spec.rb +45 -54
  611. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  612. data/spec/unit/util/tag_set_spec.rb +0 -1
  613. data/spec/unit/util/tagging_spec.rb +0 -1
  614. data/spec/unit/util/terminal_spec.rb +9 -10
  615. data/spec/unit/util/user_attr_spec.rb +1 -2
  616. data/spec/unit/util/warnings_spec.rb +3 -4
  617. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  618. data/spec/unit/util/watcher_spec.rb +51 -21
  619. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  620. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  621. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  622. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  623. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  624. data/spec/unit/util/windows/file_spec.rb +0 -1
  625. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  626. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  627. data/spec/unit/util/windows/service_spec.rb +66 -68
  628. data/spec/unit/util/windows/sid_spec.rb +11 -13
  629. data/spec/unit/util/windows/string_spec.rb +0 -1
  630. data/spec/unit/util_spec.rb +55 -57
  631. data/spec/unit/version_spec.rb +6 -6
  632. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/application/apply'
@@ -11,7 +10,7 @@ describe Puppet::Application::Apply do
11
10
 
12
11
  before :each do
13
12
  @apply = Puppet::Application[:apply]
14
- Puppet::Util::Log.stubs(:newdestination)
13
+ allow(Puppet::Util::Log).to receive(:newdestination)
15
14
  Puppet[:reports] = "none"
16
15
  end
17
16
 
@@ -29,26 +28,25 @@ describe Puppet::Application::Apply do
29
28
  end
30
29
 
31
30
  it "should store argument value when calling handle_#{option}" do
32
- @apply.options.expects(:[]=).with(option, 'arg')
31
+ expect(@apply.options).to receive(:[]=).with(option, 'arg')
33
32
  @apply.send("handle_#{option}".to_sym, 'arg')
34
33
  end
35
34
  end
36
35
 
37
36
  it "should set the code to the provided code when :execute is used" do
38
- @apply.options.expects(:[]=).with(:code, 'arg')
37
+ expect(@apply.options).to receive(:[]=).with(:code, 'arg')
39
38
  @apply.send("handle_execute".to_sym, 'arg')
40
39
  end
41
40
 
42
41
  describe "when applying options" do
43
-
44
42
  it "should set the log destination with --logdest" do
45
- Puppet::Log.expects(:newdestination).with("console")
43
+ expect(Puppet::Log).to receive(:newdestination).with("console")
46
44
 
47
45
  @apply.handle_logdest("console")
48
46
  end
49
47
 
50
48
  it "should set the setdest options to true" do
51
- @apply.options.expects(:[]=).with(:setdest,true)
49
+ expect(@apply.options).to receive(:[]=).with(:setdest,true)
52
50
 
53
51
  @apply.handle_logdest("console")
54
52
  end
@@ -56,16 +54,16 @@ describe Puppet::Application::Apply do
56
54
 
57
55
  describe "during setup" do
58
56
  before :each do
59
- Puppet::Log.stubs(:newdestination)
60
- Puppet::FileBucket::Dipper.stubs(:new)
61
- STDIN.stubs(:read)
62
- Puppet::Transaction::Report.indirection.stubs(:cache_class=)
57
+ allow(Puppet::Log).to receive(:newdestination)
58
+ allow(Puppet::FileBucket::Dipper).to receive(:new)
59
+ allow(STDIN).to receive(:read)
60
+ allow(Puppet::Transaction::Report.indirection).to receive(:cache_class=)
63
61
  end
64
62
 
65
63
  describe "with --test" do
66
64
  it "should call setup_test" do
67
65
  @apply.options[:test] = true
68
- @apply.expects(:setup_test)
66
+ expect(@apply).to receive(:setup_test)
69
67
 
70
68
  @apply.setup
71
69
  end
@@ -88,20 +86,20 @@ describe Puppet::Application::Apply do
88
86
  end
89
87
 
90
88
  it "should set console as the log destination if logdest option wasn't provided" do
91
- Puppet::Log.expects(:newdestination).with(:console)
89
+ expect(Puppet::Log).to receive(:newdestination).with(:console)
92
90
 
93
91
  @apply.setup
94
92
  end
95
93
 
96
94
  it "sets the log destination if logdest is provided via settings" do
97
- Puppet::Log.expects(:newdestination).with("set_via_config")
95
+ expect(Puppet::Log).to receive(:newdestination).with("set_via_config")
98
96
  Puppet[:logdest] = "set_via_config"
99
97
 
100
98
  @apply.setup
101
99
  end
102
100
 
103
101
  it "should set INT trap" do
104
- Signal.expects(:trap).with(:INT)
102
+ expect(Signal).to receive(:trap).with(:INT)
105
103
 
106
104
  @apply.setup
107
105
  end
@@ -119,25 +117,24 @@ describe Puppet::Application::Apply do
119
117
  end
120
118
 
121
119
  it "should print puppet config if asked to in Puppet config" do
122
- Puppet.settings.stubs(:print_configs?).returns true
123
- Puppet.settings.expects(:print_configs).returns true
120
+ allow(Puppet.settings).to receive(:print_configs?).and_return(true)
121
+ expect(Puppet.settings).to receive(:print_configs).and_return(true)
124
122
  expect { @apply.setup }.to exit_with 0
125
123
  end
126
124
 
127
125
  it "should exit after printing puppet config if asked to in Puppet config" do
128
- Puppet.settings.stubs(:print_configs?).returns(true)
126
+ allow(Puppet.settings).to receive(:print_configs?).and_return(true)
129
127
  expect { @apply.setup }.to exit_with 1
130
128
  end
131
129
 
132
130
  it "should use :main, :puppetd, and :ssl" do
133
- Puppet.settings.unstub(:use)
134
- Puppet.settings.expects(:use).with(:main, :agent, :ssl)
131
+ expect(Puppet.settings).to receive(:use).with(:main, :agent, :ssl)
135
132
 
136
133
  @apply.setup
137
134
  end
138
135
 
139
136
  it "should tell the report handler to cache locally as yaml" do
140
- Puppet::Transaction::Report.indirection.expects(:cache_class=).with(:yaml)
137
+ expect(Puppet::Transaction::Report.indirection).to receive(:cache_class=).with(:yaml)
141
138
 
142
139
  @apply.setup
143
140
  end
@@ -169,14 +166,14 @@ describe Puppet::Application::Apply do
169
166
  it "should dispatch to 'apply' if it was called with 'apply'" do
170
167
  @apply.options[:catalog] = "foo"
171
168
 
172
- @apply.expects(:apply)
169
+ expect(@apply).to receive(:apply)
173
170
  @apply.run_command
174
171
  end
175
172
 
176
173
  it "should dispatch to main otherwise" do
177
- @apply.stubs(:options).returns({})
174
+ allow(@apply).to receive(:options).and_return({})
178
175
 
179
- @apply.expects(:main)
176
+ expect(@apply).to receive(:main)
180
177
  @apply.run_command
181
178
  end
182
179
 
@@ -197,17 +194,17 @@ describe Puppet::Application::Apply do
197
194
  Puppet::Node.indirection.save(@node)
198
195
 
199
196
  @catalog = Puppet::Resource::Catalog.new("testing", Puppet.lookup(:environments).get(Puppet[:environment]))
200
- @catalog.stubs(:to_ral).returns(@catalog)
197
+ allow(@catalog).to receive(:to_ral).and_return(@catalog)
201
198
 
202
- Puppet::Resource::Catalog.indirection.stubs(:find).returns(@catalog)
199
+ allow(Puppet::Resource::Catalog.indirection).to receive(:find).and_return(@catalog)
203
200
 
204
- STDIN.stubs(:read)
201
+ allow(STDIN).to receive(:read)
205
202
 
206
- @transaction = stub('transaction')
207
- @catalog.stubs(:apply).returns(@transaction)
203
+ @transaction = double('transaction')
204
+ allow(@catalog).to receive(:apply).and_return(@transaction)
208
205
 
209
- Puppet::Util::Storage.stubs(:load)
210
- Puppet::Configurer.any_instance.stubs(:save_last_run_summary) # to prevent it from trying to write files
206
+ allow(Puppet::Util::Storage).to receive(:load)
207
+ allow_any_instance_of(Puppet::Configurer).to receive(:save_last_run_summary) # to prevent it from trying to write files
211
208
  end
212
209
 
213
210
  after :each do
@@ -224,23 +221,23 @@ describe Puppet::Application::Apply do
224
221
 
225
222
  it "should set the code to run from --code" do
226
223
  @apply.options[:code] = "code to run"
227
- Puppet.expects(:[]=).with(:code,"code to run")
224
+ expect(Puppet).to receive(:[]=).with(:code,"code to run")
228
225
 
229
226
  expect { @apply.main }.to exit_with 0
230
227
  end
231
228
 
232
229
  it "should set the code to run from STDIN if no arguments" do
233
- @apply.command_line.stubs(:args).returns([])
234
- STDIN.stubs(:read).returns("code to run")
230
+ allow(@apply.command_line).to receive(:args).and_return([])
231
+ allow(STDIN).to receive(:read).and_return("code to run")
235
232
 
236
- Puppet.expects(:[]=).with(:code,"code to run")
233
+ expect(Puppet).to receive(:[]=).with(:code,"code to run")
237
234
 
238
235
  expect { @apply.main }.to exit_with 0
239
236
  end
240
237
 
241
238
  it "should raise an error if a file is passed on command line and the file does not exist" do
242
239
  noexist = tmpfile('noexist.pp')
243
- @apply.command_line.stubs(:args).returns([noexist])
240
+ allow(@apply.command_line).to receive(:args).and_return([noexist])
244
241
  expect { @apply.main }.to raise_error(RuntimeError, "Could not find file #{noexist}")
245
242
  end
246
243
 
@@ -248,7 +245,7 @@ describe Puppet::Application::Apply do
248
245
  manifest = tmpfile('starwarsIV')
249
246
  FileUtils.touch(manifest)
250
247
 
251
- @apply.command_line.stubs(:args).returns([manifest, 'starwarsI', 'starwarsII'])
248
+ allow(@apply.command_line).to receive(:args).and_return([manifest, 'starwarsI', 'starwarsII'])
252
249
 
253
250
  expect { @apply.main }.to exit_with 0
254
251
 
@@ -258,13 +255,13 @@ describe Puppet::Application::Apply do
258
255
  end
259
256
 
260
257
  it "should splay" do
261
- @apply.expects(:splay)
258
+ expect(@apply).to receive(:splay)
262
259
 
263
260
  expect { @apply.main }.to exit_with 0
264
261
  end
265
262
 
266
263
  it "should raise an error if we can't find the node" do
267
- Puppet::Node.indirection.expects(:find).returns(nil)
264
+ expect(Puppet::Node.indirection).to receive(:find).and_return(nil)
268
265
 
269
266
  expect { @apply.main }.to raise_error(RuntimeError, /Could not find node/)
270
267
  end
@@ -275,68 +272,68 @@ describe Puppet::Application::Apply do
275
272
  File.open(classfile, 'w') { |c| c.puts 'class' }
276
273
  Puppet[:classfile] = classfile
277
274
 
278
- @node.expects(:classes=).with(['class'])
275
+ expect(@node).to receive(:classes=).with(['class'])
279
276
 
280
277
  expect { @apply.main }.to exit_with 0
281
278
  end
282
279
 
283
280
  it "should compile the catalog" do
284
- Puppet::Resource::Catalog.indirection.expects(:find).returns(@catalog)
281
+ expect(Puppet::Resource::Catalog.indirection).to receive(:find).and_return(@catalog)
285
282
 
286
283
  expect { @apply.main }.to exit_with 0
287
284
  end
288
285
 
289
286
  it 'should called the DeferredResolver to resolve any Deferred values' do
290
- Puppet::Pops::Evaluator::DeferredResolver.expects(:resolve_and_replace).with(any_parameters)
287
+ expect(Puppet::Pops::Evaluator::DeferredResolver).to receive(:resolve_and_replace).with(any_args)
291
288
  expect { @apply.main }.to exit_with 0
292
289
  end
293
290
 
294
291
  it 'should make the Puppet::Pops::Loaders available when applying the compiled catalog' do
295
- Puppet::Resource::Catalog.indirection.expects(:find).returns(@catalog)
296
- @apply.expects(:apply_catalog).with(@catalog) do
292
+ expect(Puppet::Resource::Catalog.indirection).to receive(:find).and_return(@catalog)
293
+ expect(@apply).to receive(:apply_catalog) do |catalog|
294
+ expect(@catalog).to eq(@catalog)
297
295
  fail('Loaders not found') unless Puppet.lookup(:loaders) { nil }.is_a?(Puppet::Pops::Loaders)
298
296
  true
299
- end.returns(0)
297
+ end.and_return(0)
300
298
  expect { @apply.main }.to exit_with 0
301
299
  end
302
300
 
303
301
  it "should transform the catalog to ral" do
304
-
305
- @catalog.expects(:to_ral).returns(@catalog)
302
+ expect(@catalog).to receive(:to_ral).and_return(@catalog)
306
303
 
307
304
  expect { @apply.main }.to exit_with 0
308
305
  end
309
306
 
310
307
  it "should finalize the catalog" do
311
- @catalog.expects(:finalize)
308
+ expect(@catalog).to receive(:finalize)
312
309
 
313
310
  expect { @apply.main }.to exit_with 0
314
311
  end
315
312
 
316
313
  it "should not save the classes or resource file by default" do
317
- @catalog.expects(:write_class_file).never
318
- @catalog.expects(:write_resource_file).never
314
+ expect(@catalog).not_to receive(:write_class_file)
315
+ expect(@catalog).not_to receive(:write_resource_file)
319
316
  expect { @apply.main }.to exit_with 0
320
317
  end
321
318
 
322
319
  it "should save the classes and resources files when requested" do
323
320
  @apply.options[:write_catalog_summary] = true
324
321
 
325
- @catalog.expects(:write_class_file).once
326
- @catalog.expects(:write_resource_file).once
322
+ expect(@catalog).to receive(:write_class_file).once
323
+ expect(@catalog).to receive(:write_resource_file).once
327
324
 
328
325
  expect { @apply.main }.to exit_with 0
329
326
  end
330
327
 
331
328
  it "should call the prerun and postrun commands on a Configurer instance" do
332
- Puppet::Configurer.any_instance.expects(:execute_prerun_command).returns(true)
333
- Puppet::Configurer.any_instance.expects(:execute_postrun_command).returns(true)
329
+ expect_any_instance_of(Puppet::Configurer).to receive(:execute_prerun_command).and_return(true)
330
+ expect_any_instance_of(Puppet::Configurer).to receive(:execute_postrun_command).and_return(true)
334
331
 
335
332
  expect { @apply.main }.to exit_with 0
336
333
  end
337
334
 
338
335
  it "should apply the catalog" do
339
- @catalog.expects(:apply).returns(stub_everything('transaction'))
336
+ expect(@catalog).to receive(:apply).and_return(double('transaction'))
340
337
 
341
338
  expect { @apply.main }.to exit_with 0
342
339
  end
@@ -344,9 +341,9 @@ describe Puppet::Application::Apply do
344
341
  it "should save the last run summary" do
345
342
  Puppet[:noop] = false
346
343
  report = Puppet::Transaction::Report.new
347
- Puppet::Transaction::Report.stubs(:new).returns(report)
344
+ allow(Puppet::Transaction::Report).to receive(:new).and_return(report)
348
345
 
349
- Puppet::Configurer.any_instance.expects(:save_last_run_summary).with(report)
346
+ expect_any_instance_of(Puppet::Configurer).to receive(:save_last_run_summary).with(report)
350
347
  expect { @apply.main }.to exit_with 0
351
348
  end
352
349
 
@@ -378,7 +375,7 @@ describe Puppet::Application::Apply do
378
375
  end
379
376
 
380
377
  it "should raise an error if we can't find the facts" do
381
- Puppet::Node::Facts.indirection.expects(:find).returns(nil)
378
+ expect(Puppet::Node::Facts.indirection).to receive(:find).and_return(nil)
382
379
 
383
380
  expect { @apply.main }.to raise_error(RuntimeError, /Could not find facts/)
384
381
  end
@@ -391,30 +388,30 @@ describe Puppet::Application::Apply do
391
388
 
392
389
  it "should exit with report's computed exit status" do
393
390
  Puppet[:noop] = false
394
- Puppet::Transaction::Report.any_instance.stubs(:exit_status).returns(666)
391
+ allow_any_instance_of(Puppet::Transaction::Report).to receive(:exit_status).and_return(666)
395
392
 
396
393
  expect { @apply.main }.to exit_with 666
397
394
  end
398
395
 
399
396
  it "should exit with report's computed exit status, even if --noop is set" do
400
397
  Puppet[:noop] = true
401
- Puppet::Transaction::Report.any_instance.stubs(:exit_status).returns(666)
398
+ allow_any_instance_of(Puppet::Transaction::Report).to receive(:exit_status).and_return(666)
402
399
 
403
400
  expect { @apply.main }.to exit_with 666
404
401
  end
405
402
 
406
403
  it "should always exit with 0 if option is disabled" do
407
404
  Puppet[:noop] = false
408
- report = stub 'report', :exit_status => 666
409
- @transaction.stubs(:report).returns(report)
405
+ report = double('report', :exit_status => 666)
406
+ allow(@transaction).to receive(:report).and_return(report)
410
407
 
411
408
  expect { @apply.main }.to exit_with 0
412
409
  end
413
410
 
414
411
  it "should always exit with 0 if --noop" do
415
412
  Puppet[:noop] = true
416
- report = stub 'report', :exit_status => 666
417
- @transaction.stubs(:report).returns(report)
413
+ report = double('report', :exit_status => 666)
414
+ allow(@transaction).to receive(:report).and_return(report)
418
415
 
419
416
  expect { @apply.main }.to exit_with 0
420
417
  end
@@ -435,23 +432,23 @@ describe Puppet::Application::Apply do
435
432
  it "should read the catalog in from disk if a file name is provided" do
436
433
  @apply.options[:catalog] = temporary_catalog
437
434
  catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
438
- Puppet::Resource::Catalog.stubs(:convert_from).with(default_format, '"something"').returns(catalog)
435
+ allow(Puppet::Resource::Catalog).to receive(:convert_from).with(default_format, '"something"').and_return(catalog)
439
436
  @apply.apply
440
437
  end
441
438
 
442
439
  it "should read the catalog in from stdin if '-' is provided" do
443
440
  @apply.options[:catalog] = "-"
444
- $stdin.expects(:read).returns '"something"'
441
+ expect($stdin).to receive(:read).and_return('"something"')
445
442
  catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
446
- Puppet::Resource::Catalog.stubs(:convert_from).with(default_format, '"something"').returns(catalog)
443
+ allow(Puppet::Resource::Catalog).to receive(:convert_from).with(default_format, '"something"').and_return(catalog)
447
444
  @apply.apply
448
445
  end
449
446
 
450
447
  it "should deserialize the catalog from the default format" do
451
448
  @apply.options[:catalog] = temporary_catalog
452
- Puppet::Resource::Catalog.stubs(:default_format).returns :rot13_piglatin
449
+ allow(Puppet::Resource::Catalog).to receive(:default_format).and_return(:rot13_piglatin)
453
450
  catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
454
- Puppet::Resource::Catalog.stubs(:convert_from).with(:rot13_piglatin,'"something"').returns(catalog)
451
+ allow(Puppet::Resource::Catalog).to receive(:convert_from).with(:rot13_piglatin,'"something"').and_return(catalog)
455
452
  @apply.apply
456
453
  end
457
454
 
@@ -463,12 +460,12 @@ describe Puppet::Application::Apply do
463
460
  it "should convert the catalog to a RAL catalog and use a Configurer instance to apply it" do
464
461
  @apply.options[:catalog] = temporary_catalog
465
462
  catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
466
- Puppet::Resource::Catalog.stubs(:convert_from).with(default_format, '"something"').returns catalog
467
- catalog.expects(:to_ral).returns "mycatalog"
463
+ allow(Puppet::Resource::Catalog).to receive(:convert_from).with(default_format, '"something"').and_return(catalog)
464
+ expect(catalog).to receive(:to_ral).and_return("mycatalog")
468
465
 
469
- configurer = stub 'configurer'
470
- Puppet::Configurer.expects(:new).returns configurer
471
- configurer.expects(:run).
466
+ configurer = double('configurer')
467
+ expect(Puppet::Configurer).to receive(:new).and_return(configurer)
468
+ expect(configurer).to receive(:run).
472
469
  with(:catalog => "mycatalog", :pluginsync => false)
473
470
 
474
471
  @apply.apply
@@ -477,11 +474,13 @@ describe Puppet::Application::Apply do
477
474
  it 'should make the Puppet::Pops::Loaders available when applying a catalog' do
478
475
  @apply.options[:catalog] = temporary_catalog
479
476
  catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
480
- @apply.expects(:read_catalog).with('something') do
477
+ expect(@apply).to receive(:read_catalog) do |arg|
478
+ expect(arg).to eq('"something"')
481
479
  fail('Loaders not found') unless Puppet.lookup(:loaders) { nil }.is_a?(Puppet::Pops::Loaders)
482
480
  true
483
- end.returns(catalog)
484
- @apply.expects(:apply_catalog).with(catalog) do
481
+ end.and_return(catalog)
482
+ expect(@apply).to receive(:apply_catalog) do |cat|
483
+ expect(cat).to eq(catalog)
485
484
  fail('Loaders not found') unless Puppet.lookup(:loaders) { nil }.is_a?(Puppet::Pops::Loaders)
486
485
  true
487
486
  end
@@ -490,10 +489,10 @@ describe Puppet::Application::Apply do
490
489
 
491
490
  it "should call the DeferredResolver to resolve Deferred values" do
492
491
  @apply.options[:catalog] = temporary_catalog
493
- Puppet::Resource::Catalog.stubs(:default_format).returns :rot13_piglatin
492
+ allow(Puppet::Resource::Catalog).to receive(:default_format).and_return(:rot13_piglatin)
494
493
  catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
495
- Puppet::Resource::Catalog.stubs(:convert_from).with(:rot13_piglatin,'"something"').returns(catalog)
496
- Puppet::Pops::Evaluator::DeferredResolver.expects(:resolve_and_replace).with(any_parameters)
494
+ allow(Puppet::Resource::Catalog).to receive(:convert_from).with(:rot13_piglatin, '"something"').and_return(catalog)
495
+ expect(Puppet::Pops::Evaluator::DeferredResolver).to receive(:resolve_and_replace).with(any_args)
497
496
  @apply.apply
498
497
  end
499
498
  end
@@ -520,7 +519,7 @@ describe Puppet::Application::Apply do
520
519
  Puppet.settings[:classfile] = classfile
521
520
 
522
521
  #We don't actually need the resource to do anything, we are using it's properties in other parts of the workflow.
523
- Puppet::Util::Execution.stubs(:execute)
522
+ allow(Puppet::Util::Execution).to receive(:execute)
524
523
 
525
524
  expect { @apply.main }.to exit_with 0
526
525
 
@@ -534,7 +533,7 @@ describe Puppet::Application::Apply do
534
533
  describe "apply_catalog" do
535
534
  it "should call the configurer with the catalog" do
536
535
  catalog = "I am a catalog"
537
- Puppet::Configurer.any_instance.expects(:run).
536
+ expect_any_instance_of(Puppet::Configurer).to receive(:run).
538
537
  with(:catalog => catalog, :pluginsync => false)
539
538
  @apply.send(:apply_catalog, catalog)
540
539
  end
@@ -542,7 +541,7 @@ describe Puppet::Application::Apply do
542
541
 
543
542
  it "should honor the catalog_cache_terminus setting" do
544
543
  Puppet.settings[:catalog_cache_terminus] = "json"
545
- Puppet::Resource::Catalog.indirection.expects(:cache_class=).with(:json)
544
+ expect(Puppet::Resource::Catalog.indirection).to receive(:cache_class=).with(:json)
546
545
 
547
546
  @apply.initialize_app_defaults
548
547
  @apply.setup